drivers/net/bnxt/bnxt_rxq.c

   1 /* SPDX-License-Identifier: BSD-3-Clause
   2  * Copyright(c) 2014-2018 Broadcom
   3  * All rights reserved.
   4  */
   5
   6 #include <inttypes.h>
   7
   8 #include <rte_malloc.h>
   9
  10 #include "bnxt.h"
  11 #include "bnxt_filter.h"
  12 #include "bnxt_hwrm.h"
  13 #include "bnxt_ring.h"
  14 #include "bnxt_rxq.h"
  15 #include "bnxt_rxr.h"
  16 #include "bnxt_vnic.h"
  17 #include "hsi_struct_def_dpdk.h"
  18
  19 /*
  20  * RX Queues
  21  */
  22
  23 void bnxt_free_rxq_stats(struct bnxt_rx_queue *rxq)
  24 {
  25         if (rxq && rxq->cp_ring && rxq->cp_ring->hw_stats)
  26                 rxq->cp_ring->hw_stats = NULL;
  27 }
  28
  29 int bnxt_mq_rx_configure(struct bnxt *bp)
  30 {
  31         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
  32         const struct rte_eth_vmdq_rx_conf *conf =
  33                     &dev_conf->rx_adv_conf.vmdq_rx_conf;
  34         unsigned int i, j, nb_q_per_grp = 1, ring_idx = 0;
  35         int start_grp_id, end_grp_id = 1, rc = 0;
  36         struct bnxt_vnic_info *vnic;
  37         struct bnxt_filter_info *filter;
  38         enum rte_eth_nb_pools pools = 1, max_pools = 0;
  39         struct bnxt_rx_queue *rxq;
  40
  41         bp->nr_vnics = 0;
  42
  43         /* Single queue mode */
  44         if (bp->rx_cp_nr_rings < 2) {
  45                 vnic = &bp->vnic_info[0];
  46                 if (!vnic) {
  47                         PMD_DRV_LOG(ERR, "VNIC alloc failed\n");
  48                         rc = -ENOMEM;
  49                         goto err_out;
  50                 }
  51                 vnic->flags |= BNXT_VNIC_INFO_BCAST;
  52                 bp->nr_vnics++;
  53
  54                 rxq = bp->eth_dev->data->rx_queues[0];
  55                 rxq->vnic = vnic;
  56
  57                 vnic->func_default = true;
  58                 vnic->start_grp_id = 0;
  59                 vnic->end_grp_id = vnic->start_grp_id;
  60                 filter = bnxt_alloc_filter(bp);
  61                 if (!filter) {
  62                         PMD_DRV_LOG(ERR, "L2 filter alloc failed\n");
  63                         rc = -ENOMEM;
  64                         goto err_out;
  65                 }
  66                 filter->mac_index = 0;
  67                 filter->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
  68                 STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
  69                 goto out;
  70         }
  71
  72         /* Multi-queue mode */
  73         if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB_RSS) {
  74                 /* VMDq ONLY, VMDq+RSS, VMDq+DCB, VMDq+DCB+RSS */
  75
  76                 switch (dev_conf->rxmode.mq_mode) {
  77                 case ETH_MQ_RX_VMDQ_RSS:
  78                 case ETH_MQ_RX_VMDQ_ONLY:
  79                 case ETH_MQ_RX_VMDQ_DCB_RSS:
  80                         /* FALLTHROUGH */
  81                         /* ETH_8/64_POOLs */
  82                         pools = conf->nb_queue_pools;
  83                         /* For each pool, allocate MACVLAN CFA rule & VNIC */
  84                         max_pools = RTE_MIN(bp->max_vnics,
  85                                             RTE_MIN(bp->max_l2_ctx,
  86                                             RTE_MIN(bp->max_rsscos_ctx,
  87                                                     ETH_64_POOLS)));
  88                         PMD_DRV_LOG(DEBUG,
  89                                     "pools = %u max_pools = %u\n",
  90                                     pools, max_pools);
  91                         if (pools > max_pools)
  92                                 pools = max_pools;
  93                         break;
  94                 case ETH_MQ_RX_RSS:
  95                         pools = bp->rx_cosq_cnt ? bp->rx_cosq_cnt : 1;
  96                         break;
  97                 default:
  98                         PMD_DRV_LOG(ERR, "Unsupported mq_mod %d\n",
  99                                 dev_conf->rxmode.mq_mode);
 100                         rc = -EINVAL;
 101                         goto err_out;
 102                 }
 103         } else if (!dev_conf->rxmode.mq_mode) {
 104                 pools = bp->rx_cosq_cnt ? bp->rx_cosq_cnt : pools;
 105         }
 106
 107         pools = RTE_MIN(pools, bp->rx_cp_nr_rings);
 108         nb_q_per_grp = bp->rx_cp_nr_rings / pools;
 109         bp->rx_num_qs_per_vnic = nb_q_per_grp;
 110         PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n",
 111                     pools, nb_q_per_grp);
 112         start_grp_id = 0;
 113         end_grp_id = nb_q_per_grp;
 114
 115         for (i = 0; i < pools; i++) {
 116                 vnic = &bp->vnic_info[i];
 117                 if (!vnic) {
 118                         PMD_DRV_LOG(ERR, "VNIC alloc failed\n");
 119                         rc = -ENOMEM;
 120                         goto err_out;
 121                 }
 122                 vnic->flags |= BNXT_VNIC_INFO_BCAST;
 123                 bp->nr_vnics++;
 124
 125                 for (j = 0; j < nb_q_per_grp; j++, ring_idx++) {
 126                         rxq = bp->eth_dev->data->rx_queues[ring_idx];
 127                         rxq->vnic = vnic;
 128                         PMD_DRV_LOG(DEBUG,
 129                                     "rxq[%d] = %p vnic[%d] = %p\n",
 130                                     ring_idx, rxq, i, vnic);
 131                 }
 132                 if (i == 0) {
 133                         if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB) {
 134                                 bp->eth_dev->data->promiscuous = 1;
 135                                 vnic->flags |= BNXT_VNIC_INFO_PROMISC;
 136                         }
 137                         vnic->func_default = true;
 138                 }
 139                 vnic->start_grp_id = start_grp_id;
 140                 vnic->end_grp_id = end_grp_id;
 141
 142                 if (i) {
 143                         if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB ||
 144                             !(dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS))
 145                                 vnic->rss_dflt_cr = true;
 146                         goto skip_filter_allocation;
 147                 }
 148                 filter = bnxt_alloc_filter(bp);
 149                 if (!filter) {
 150                         PMD_DRV_LOG(ERR, "L2 filter alloc failed\n");
 151                         rc = -ENOMEM;
 152                         goto err_out;
 153                 }
 154                 filter->mac_index = 0;
 155                 filter->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
 156                 /*
 157                  * TODO: Configure & associate CFA rule for
 158                  * each VNIC for each VMDq with MACVLAN, MACVLAN+TC
 159                  */
 160                 STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
 161
 162 skip_filter_allocation:
 163                 start_grp_id = end_grp_id;
 164                 end_grp_id += nb_q_per_grp;
 165         }
 166
 167 out:
 168         if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
 169                 struct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf;
 170
 171                 if (bp->flags & BNXT_FLAG_UPDATE_HASH)
 172                         bp->flags &= ~BNXT_FLAG_UPDATE_HASH;
 173
 174                 for (i = 0; i < bp->nr_vnics; i++) {
 175                         vnic = &bp->vnic_info[i];
 176                         vnic->hash_type =
 177                                 bnxt_rte_to_hwrm_hash_types(rss->rss_hf);
 178
 179                         /*
 180                          * Use the supplied key if the key length is
 181                          * acceptable and the rss_key is not NULL
 182                          */
 183                         if (rss->rss_key &&
 184                             rss->rss_key_len <= HW_HASH_KEY_SIZE)
 185                                 memcpy(vnic->rss_hash_key,
 186                                        rss->rss_key, rss->rss_key_len);
 187                 }
 188         }
 189
 190         return rc;
 191
 192 err_out:
 193         /* Free allocated vnic/filters */
 194
 195         return rc;
 196 }
 197
 198 void bnxt_rx_queue_release_mbufs(struct bnxt_rx_queue *rxq)
 199 {
 200         struct rte_mbuf **sw_ring;
 201         struct bnxt_tpa_info *tpa_info;
 202         uint16_t i;
 203
 204         if (!rxq)
 205                 return;
 206
 207         rte_spinlock_lock(&rxq->lock);
 208
 209         sw_ring = rxq->rx_ring->rx_buf_ring;
 210         if (sw_ring) {
 211                 for (i = 0;
 212                      i < rxq->rx_ring->rx_ring_struct->ring_size; i++) {
 213                         if (sw_ring[i]) {
 214                                 rte_pktmbuf_free_seg(sw_ring[i]);
 215                                 sw_ring[i] = NULL;
 216                         }
 217                 }
 218         }
 219         /* Free up mbufs in Agg ring */
 220         sw_ring = rxq->rx_ring->ag_buf_ring;
 221         if (sw_ring) {
 222                 for (i = 0;
 223                      i < rxq->rx_ring->ag_ring_struct->ring_size; i++) {
 224                         if (sw_ring[i]) {
 225                                 rte_pktmbuf_free_seg(sw_ring[i]);
 226                                 sw_ring[i] = NULL;
 227                         }
 228                 }
 229         }
 230
 231         /* Free up mbufs in TPA */
 232         tpa_info = rxq->rx_ring->tpa_info;
 233         if (tpa_info) {
 234                 int max_aggs = BNXT_TPA_MAX_AGGS(rxq->bp);
 235
 236                 for (i = 0; i < max_aggs; i++) {
 237                         if (tpa_info[i].mbuf) {
 238                                 rte_pktmbuf_free_seg(tpa_info[i].mbuf);
 239                                 tpa_info[i].mbuf = NULL;
 240                         }
 241                 }
 242         }
 243
 244         rte_spinlock_unlock(&rxq->lock);
 245 }
 246
 247 void bnxt_free_rx_mbufs(struct bnxt *bp)
 248 {
 249         struct bnxt_rx_queue *rxq;
 250         int i;
 251
 252         for (i = 0; i < (int)bp->rx_nr_rings; i++) {
 253                 rxq = bp->rx_queues[i];
 254                 bnxt_rx_queue_release_mbufs(rxq);
 255         }
 256 }
 257
 258 void bnxt_rx_queue_release_op(void *rx_queue)
 259 {
 260         struct bnxt_rx_queue *rxq = (struct bnxt_rx_queue *)rx_queue;
 261
 262         if (rxq) {
 263                 if (is_bnxt_in_error(rxq->bp))
 264                         return;
 265
 266                 bnxt_rx_queue_release_mbufs(rxq);
 267
 268                 /* Free RX ring hardware descriptors */
 269                 bnxt_free_ring(rxq->rx_ring->rx_ring_struct);
 270                 /* Free RX Agg ring hardware descriptors */
 271                 bnxt_free_ring(rxq->rx_ring->ag_ring_struct);
 272
 273                 /* Free RX completion ring hardware descriptors */
 274                 bnxt_free_ring(rxq->cp_ring->cp_ring_struct);
 275
 276                 bnxt_free_rxq_stats(rxq);
 277                 rte_memzone_free(rxq->mz);
 278                 rxq->mz = NULL;
 279
 280                 rte_free(rxq);
 281         }
 282 }
 283
 284 int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,
 285                                uint16_t queue_idx,
 286                                uint16_t nb_desc,
 287                                unsigned int socket_id,
 288                                const struct rte_eth_rxconf *rx_conf,
 289                                struct rte_mempool *mp)
 290 {
 291         struct bnxt *bp = eth_dev->data->dev_private;
 292         uint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads;
 293         struct bnxt_rx_queue *rxq;
 294         int rc = 0;
 295         uint8_t queue_state;
 296
 297         rc = is_bnxt_in_error(bp);
 298         if (rc)
 299                 return rc;
 300
 301         if (queue_idx >= BNXT_MAX_RINGS(bp)) {
 302                 PMD_DRV_LOG(ERR,
 303                         "Cannot create Rx ring %d. Only %d rings available\n",
 304                         queue_idx, bp->max_rx_rings);
 305                 return -EINVAL;
 306         }
 307
 308         if (nb_desc < BNXT_MIN_RING_DESC || nb_desc > MAX_RX_DESC_CNT) {
 309                 PMD_DRV_LOG(ERR, "nb_desc %d is invalid\n", nb_desc);
 310                 rc = -EINVAL;
 311                 goto out;
 312         }
 313
 314         if (eth_dev->data->rx_queues) {
 315                 rxq = eth_dev->data->rx_queues[queue_idx];
 316                 if (rxq)
 317                         bnxt_rx_queue_release_op(rxq);
 318         }
 319         rxq = rte_zmalloc_socket("bnxt_rx_queue", sizeof(struct bnxt_rx_queue),
 320                                  RTE_CACHE_LINE_SIZE, socket_id);
 321         if (!rxq) {
 322                 PMD_DRV_LOG(ERR, "bnxt_rx_queue allocation failed!\n");
 323                 rc = -ENOMEM;
 324                 goto out;
 325         }
 326         rxq->bp = bp;
 327         rxq->mb_pool = mp;
 328         rxq->nb_rx_desc = nb_desc;
 329         rxq->rx_free_thresh =
 330                 RTE_MIN(rte_align32pow2(nb_desc) / 4, RTE_BNXT_MAX_RX_BURST);
 331
 332         PMD_DRV_LOG(DEBUG, "RX Buf MTU %d\n", eth_dev->data->mtu);
 333
 334         rc = bnxt_init_rx_ring_struct(rxq, socket_id);
 335         if (rc)
 336                 goto out;
 337
 338         PMD_DRV_LOG(DEBUG, "RX Buf size is %d\n", rxq->rx_buf_size);
 339         rxq->queue_id = queue_idx;
 340         rxq->port_id = eth_dev->data->port_id;
 341         if (rx_offloads & DEV_RX_OFFLOAD_KEEP_CRC)
 342                 rxq->crc_len = RTE_ETHER_CRC_LEN;
 343         else
 344                 rxq->crc_len = 0;
 345
 346         eth_dev->data->rx_queues[queue_idx] = rxq;
 347         /* Allocate RX ring hardware descriptors */
 348         if (bnxt_alloc_rings(bp, queue_idx, NULL, rxq, rxq->cp_ring, NULL,
 349                              "rxr")) {
 350                 PMD_DRV_LOG(ERR,
 351                         "ring_dma_zone_reserve for rx_ring failed!\n");
 352                 bnxt_rx_queue_release_op(rxq);
 353                 rc = -ENOMEM;
 354                 goto out;
 355         }
 356         rte_atomic64_init(&rxq->rx_mbuf_alloc_fail);
 357
 358         /* rxq 0 must not be stopped when used as async CPR */
 359         if (!BNXT_NUM_ASYNC_CPR(bp) && queue_idx == 0)
 360                 rxq->rx_deferred_start = false;
 361         else
 362                 rxq->rx_deferred_start = rx_conf->rx_deferred_start;
 363
 364         if (rxq->rx_deferred_start) {
 365                 queue_state = RTE_ETH_QUEUE_STATE_STOPPED;
 366                 rxq->rx_started = false;
 367         } else {
 368                 queue_state = RTE_ETH_QUEUE_STATE_STARTED;
 369                 rxq->rx_started = true;
 370         }
 371         eth_dev->data->rx_queue_state[queue_idx] = queue_state;
 372         rte_spinlock_init(&rxq->lock);
 373
 374         /* Configure mtu if it is different from what was configured before */
 375         if (!queue_idx)
 376                 bnxt_mtu_set_op(eth_dev, eth_dev->data->mtu);
 377
 378 out:
 379         return rc;
 380 }
 381
 382 int
 383 bnxt_rx_queue_intr_enable_op(struct rte_eth_dev *eth_dev, uint16_t queue_id)
 384 {
 385         struct bnxt *bp = eth_dev->data->dev_private;
 386         struct bnxt_rx_queue *rxq;
 387         struct bnxt_cp_ring_info *cpr;
 388         int rc = 0;
 389
 390         rc = is_bnxt_in_error(bp);
 391         if (rc)
 392                 return rc;
 393
 394         if (eth_dev->data->rx_queues) {
 395                 rxq = eth_dev->data->rx_queues[queue_id];
 396                 if (!rxq)
 397                         return -EINVAL;
 398
 399                 cpr = rxq->cp_ring;
 400                 B_CP_DB_REARM(cpr, cpr->cp_raw_cons);
 401         }
 402         return rc;
 403 }
 404
 405 int
 406 bnxt_rx_queue_intr_disable_op(struct rte_eth_dev *eth_dev, uint16_t queue_id)
 407 {
 408         struct bnxt *bp = eth_dev->data->dev_private;
 409         struct bnxt_rx_queue *rxq;
 410         struct bnxt_cp_ring_info *cpr;
 411         int rc = 0;
 412
 413         rc = is_bnxt_in_error(bp);
 414         if (rc)
 415                 return rc;
 416
 417         if (eth_dev->data->rx_queues) {
 418                 rxq = eth_dev->data->rx_queues[queue_id];
 419                 if (!rxq)
 420                         return -EINVAL;
 421
 422                 cpr = rxq->cp_ring;
 423                 B_CP_DB_DISARM(cpr);
 424         }
 425         return rc;
 426 }
 427
 428 int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 429 {
 430         struct bnxt *bp = dev->data->dev_private;
 431         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
 432         struct bnxt_rx_queue *rxq = bp->rx_queues[rx_queue_id];
 433         struct bnxt_vnic_info *vnic = NULL;
 434         int rc = 0;
 435
 436         rc = is_bnxt_in_error(bp);
 437         if (rc)
 438                 return rc;
 439
 440         if (rxq == NULL) {
 441                 PMD_DRV_LOG(ERR, "Invalid Rx queue %d\n", rx_queue_id);
 442                 return -EINVAL;
 443         }
 444
 445         /* Set the queue state to started here.
 446          * We check the status of the queue while posting buffer.
 447          * If queue is it started, we do not post buffers for Rx.
 448          */
 449         rxq->rx_started = true;
 450         dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
 451
 452         bnxt_free_hwrm_rx_ring(bp, rx_queue_id);
 453         rc = bnxt_alloc_hwrm_rx_ring(bp, rx_queue_id);
 454         if (rc)
 455                 return rc;
 456
 457         if (BNXT_CHIP_THOR(bp)) {
 458                 /* Reconfigure default receive ring and MRU. */
 459                 bnxt_hwrm_vnic_cfg(bp, rxq->vnic);
 460         }
 461         PMD_DRV_LOG(INFO, "Rx queue started %d\n", rx_queue_id);
 462
 463         if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
 464                 vnic = rxq->vnic;
 465
 466                 if (BNXT_HAS_RING_GRPS(bp)) {
 467                         if (vnic->fw_grp_ids[rx_queue_id] != INVALID_HW_RING_ID)
 468                                 return 0;
 469
 470                         vnic->fw_grp_ids[rx_queue_id] =
 471                                         bp->grp_info[rx_queue_id].fw_grp_id;
 472                         PMD_DRV_LOG(DEBUG,
 473                                     "vnic = %p fw_grp_id = %d\n",
 474                                     vnic, bp->grp_info[rx_queue_id].fw_grp_id);
 475                 }
 476
 477                 PMD_DRV_LOG(DEBUG, "Rx Queue Count %d\n", vnic->rx_queue_cnt);
 478                 rc = bnxt_vnic_rss_configure(bp, vnic);
 479         }
 480
 481         if (rc != 0) {
 482                 dev->data->rx_queue_state[rx_queue_id] =
 483                                 RTE_ETH_QUEUE_STATE_STOPPED;
 484                 rxq->rx_started = false;
 485         }
 486
 487         PMD_DRV_LOG(INFO,
 488                     "queue %d, rx_deferred_start %d, state %d!\n",
 489                     rx_queue_id, rxq->rx_deferred_start,
 490                     bp->eth_dev->data->rx_queue_state[rx_queue_id]);
 491
 492         return rc;
 493 }
 494
 495 int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 496 {
 497         struct bnxt *bp = dev->data->dev_private;
 498         struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
 499         struct bnxt_vnic_info *vnic = NULL;
 500         struct bnxt_rx_queue *rxq = NULL;
 501         int active_queue_cnt = 0;
 502         int i, rc = 0;
 503
 504         rc = is_bnxt_in_error(bp);
 505         if (rc)
 506                 return rc;
 507
 508         /* For the stingray platform and other platforms needing tighter
 509          * control of resource utilization, Rx CQ 0 also works as
 510          * Default CQ for async notifications
 511          */
 512         if (!BNXT_NUM_ASYNC_CPR(bp) && !rx_queue_id) {
 513                 PMD_DRV_LOG(ERR, "Cannot stop Rx queue id %d\n", rx_queue_id);
 514                 return -EINVAL;
 515         }
 516
 517         rxq = bp->rx_queues[rx_queue_id];
 518         if (!rxq) {
 519                 PMD_DRV_LOG(ERR, "Invalid Rx queue %d\n", rx_queue_id);
 520                 return -EINVAL;
 521         }
 522
 523         vnic = rxq->vnic;
 524         if (!vnic) {
 525                 PMD_DRV_LOG(ERR, "VNIC not initialized for RxQ %d\n",
 526                             rx_queue_id);
 527                 return -EINVAL;
 528         }
 529
 530         dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;
 531         rxq->rx_started = false;
 532         PMD_DRV_LOG(DEBUG, "Rx queue stopped\n");
 533
 534         if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
 535                 if (BNXT_HAS_RING_GRPS(bp))
 536                         vnic->fw_grp_ids[rx_queue_id] = INVALID_HW_RING_ID;
 537
 538                 PMD_DRV_LOG(DEBUG, "Rx Queue Count %d\n", vnic->rx_queue_cnt);
 539                 rc = bnxt_vnic_rss_configure(bp, vnic);
 540         }
 541
 542         if (BNXT_CHIP_THOR(bp)) {
 543                 /* Compute current number of active receive queues. */
 544                 for (i = vnic->start_grp_id; i < vnic->end_grp_id; i++)
 545                         if (bp->rx_queues[i]->rx_started)
 546                                 active_queue_cnt++;
 547
 548                 /*
 549                  * For Thor, we need to ensure that the VNIC default receive
 550                  * ring corresponds to an active receive queue. When no queue
 551                  * is active, we need to temporarily set the MRU to zero so
 552                  * that packets are dropped early in the receive pipeline in
 553                  * order to prevent the VNIC default receive ring from being
 554                  * accessed.
 555                  */
 556                 if (active_queue_cnt == 0) {
 557                         uint16_t saved_mru = vnic->mru;
 558
 559                         vnic->mru = 0;
 560                         /* Reconfigure default receive ring and MRU. */
 561                         bnxt_hwrm_vnic_cfg(bp, vnic);
 562                         vnic->mru = saved_mru;
 563                 } else {
 564                         /* Reconfigure default receive ring. */
 565                         bnxt_hwrm_vnic_cfg(bp, vnic);
 566                 }
 567         }
 568
 569         if (rc == 0)
 570                 bnxt_rx_queue_release_mbufs(rxq);
 571
 572         return rc;
 573 }