net/ice: clean input set macro definition
[dpdk.git] / app / test-pmd / cmdline_mtr.c
index 846de88..3982787 100644 (file)
@@ -74,7 +74,7 @@ parse_uint(uint64_t *value, const char *str)
 }
 
 static int
-parse_dscp_table_entries(char *str, enum rte_mtr_color **dscp_table)
+parse_dscp_table_entries(char *str, enum rte_color **dscp_table)
 {
        char *token;
        int i = 0;
@@ -84,21 +84,21 @@ parse_dscp_table_entries(char *str, enum rte_mtr_color **dscp_table)
                return 0;
 
        /* Allocate memory for dscp table */
-       *dscp_table = (enum rte_mtr_color *)malloc(MAX_DSCP_TABLE_ENTRIES *
-               sizeof(enum rte_mtr_color));
+       *dscp_table = (enum rte_color *)malloc(MAX_DSCP_TABLE_ENTRIES *
+               sizeof(enum rte_color));
        if (*dscp_table == NULL)
                return -1;
 
        while (1) {
                if (strcmp(token, "G") == 0 ||
                        strcmp(token, "g") == 0)
-                       *dscp_table[i++] = RTE_MTR_GREEN;
+                       *dscp_table[i++] = RTE_COLOR_GREEN;
                else if (strcmp(token, "Y") == 0 ||
                        strcmp(token, "y") == 0)
-                       *dscp_table[i++] = RTE_MTR_YELLOW;
+                       *dscp_table[i++] = RTE_COLOR_YELLOW;
                else if (strcmp(token, "R") == 0 ||
                        strcmp(token, "r") == 0)
-                       *dscp_table[i++] = RTE_MTR_RED;
+                       *dscp_table[i++] = RTE_COLOR_RED;
                else {
                        free(*dscp_table);
                        return -1;
@@ -117,7 +117,7 @@ parse_dscp_table_entries(char *str, enum rte_mtr_color **dscp_table)
 
 static int
 parse_meter_color_str(char *c_str, uint32_t *use_prev_meter_color,
-       enum rte_mtr_color **dscp_table)
+       enum rte_color **dscp_table)
 {
        char *token;
        uint64_t previous_mtr_color = 0;
@@ -182,20 +182,20 @@ parse_policer_action_string(char *p_str, uint32_t action_mask,
                        return -1;
 
                if (g_color == 0 && (action_mask & 0x1)) {
-                       actions[RTE_MTR_GREEN] = action;
+                       actions[RTE_COLOR_GREEN] = action;
                        g_color = 1;
                } else if (y_color == 0 && (action_mask & 0x2)) {
-                       actions[RTE_MTR_YELLOW] = action;
+                       actions[RTE_COLOR_YELLOW] = action;
                        y_color = 1;
                } else
-                       actions[RTE_MTR_RED] = action;
+                       actions[RTE_COLOR_RED] = action;
        }
        return 0;
 }
 
 static int
 parse_multi_token_string(char *t_str, uint16_t *port_id,
-       uint32_t *mtr_id, enum rte_mtr_color **dscp_table)
+       uint32_t *mtr_id, enum rte_color **dscp_table)
 {
        char *token;
        uint64_t val;
@@ -253,11 +253,11 @@ cmdline_parse_token_string_t cmd_show_port_meter_cap_cap =
                struct cmd_show_port_meter_cap_result, cap, "cap");
 cmdline_parse_token_num_t cmd_show_port_meter_cap_port_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_show_port_meter_cap_result, port_id, UINT16);
+               struct cmd_show_port_meter_cap_result, port_id, RTE_UINT16);
 
 static void cmd_show_port_meter_cap_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_show_port_meter_cap_result *res = parsed_result;
        struct rte_mtr_capabilities cap;
@@ -312,7 +312,7 @@ static void cmd_show_port_meter_cap_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_show_port_meter_cap = {
        .f = cmd_show_port_meter_cap_parsed,
        .data = NULL,
-       .help_str = "Show port meter cap",
+       .help_str = "show port meter cap <port_id>",
        .tokens = {
                (void *)&cmd_show_port_meter_cap_show,
                (void *)&cmd_show_port_meter_cap_port,
@@ -359,27 +359,27 @@ cmdline_parse_token_string_t cmd_add_port_meter_profile_srtcm_srtcm_rfc2697 =
 cmdline_parse_token_num_t cmd_add_port_meter_profile_srtcm_port_id =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_srtcm_result,
-                       port_id, UINT16);
+                       port_id, RTE_UINT16);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_srtcm_profile_id =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_srtcm_result,
-                       profile_id, UINT32);
+                       profile_id, RTE_UINT32);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_srtcm_cir =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_srtcm_result,
-                       cir, UINT64);
+                       cir, RTE_UINT64);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_srtcm_cbs =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_srtcm_result,
-                       cbs, UINT64);
+                       cbs, RTE_UINT64);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_srtcm_ebs =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_srtcm_result,
-                       ebs, UINT64);
+                       ebs, RTE_UINT64);
 
 static void cmd_add_port_meter_profile_srtcm_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_add_port_meter_profile_srtcm_result *res = parsed_result;
        struct rte_mtr_meter_profile mp;
@@ -408,7 +408,7 @@ static void cmd_add_port_meter_profile_srtcm_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_add_port_meter_profile_srtcm = {
        .f = cmd_add_port_meter_profile_srtcm_parsed,
        .data = NULL,
-       .help_str = "Add port meter profile srtcm (rfc2697)",
+       .help_str = "add port meter profile srtcm_rfc2697 <port_id> <profile_id> <cir> <cbs> <ebs>",
        .tokens = {
                (void *)&cmd_add_port_meter_profile_srtcm_add,
                (void *)&cmd_add_port_meter_profile_srtcm_port,
@@ -461,31 +461,31 @@ cmdline_parse_token_string_t cmd_add_port_meter_profile_trtcm_trtcm_rfc2698 =
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_port_id =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_result,
-                       port_id, UINT16);
+                       port_id, RTE_UINT16);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_profile_id =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_result,
-                       profile_id, UINT32);
+                       profile_id, RTE_UINT32);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_cir =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_result,
-                       cir, UINT64);
+                       cir, RTE_UINT64);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_pir =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_result,
-                       pir, UINT64);
+                       pir, RTE_UINT64);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_cbs =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_result,
-                       cbs, UINT64);
+                       cbs, RTE_UINT64);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_pbs =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_result,
-                       pbs, UINT64);
+                       pbs, RTE_UINT64);
 
 static void cmd_add_port_meter_profile_trtcm_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_add_port_meter_profile_trtcm_result *res = parsed_result;
        struct rte_mtr_meter_profile mp;
@@ -515,7 +515,7 @@ static void cmd_add_port_meter_profile_trtcm_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_add_port_meter_profile_trtcm = {
        .f = cmd_add_port_meter_profile_trtcm_parsed,
        .data = NULL,
-       .help_str = "Add port meter profile trtcm (rfc2698)",
+       .help_str = "add port meter profile trtcm_rfc2698 <port_id> <profile_id> <cir> <pir> <cbs> <pbs>",
        .tokens = {
                (void *)&cmd_add_port_meter_profile_trtcm_add,
                (void *)&cmd_add_port_meter_profile_trtcm_port,
@@ -571,32 +571,32 @@ cmdline_parse_token_string_t
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_rfc4115_port_id =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_rfc4115_result,
-                       port_id, UINT16);
+                       port_id, RTE_UINT16);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_rfc4115_profile_id =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_rfc4115_result,
-                       profile_id, UINT32);
+                       profile_id, RTE_UINT32);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_rfc4115_cir =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_rfc4115_result,
-                       cir, UINT64);
+                       cir, RTE_UINT64);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_rfc4115_eir =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_rfc4115_result,
-                       eir, UINT64);
+                       eir, RTE_UINT64);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_rfc4115_cbs =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_rfc4115_result,
-                       cbs, UINT64);
+                       cbs, RTE_UINT64);
 cmdline_parse_token_num_t cmd_add_port_meter_profile_trtcm_rfc4115_ebs =
        TOKEN_NUM_INITIALIZER(
                struct cmd_add_port_meter_profile_trtcm_rfc4115_result,
-                       ebs, UINT64);
+                       ebs, RTE_UINT64);
 
 static void cmd_add_port_meter_profile_trtcm_rfc4115_parsed(
        void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_add_port_meter_profile_trtcm_rfc4115_result *res =
                parsed_result;
@@ -627,7 +627,7 @@ static void cmd_add_port_meter_profile_trtcm_rfc4115_parsed(
 cmdline_parse_inst_t cmd_add_port_meter_profile_trtcm_rfc4115 = {
        .f = cmd_add_port_meter_profile_trtcm_rfc4115_parsed,
        .data = NULL,
-       .help_str = "Add port meter profile trtcm (rfc4115)",
+       .help_str = "add port meter profile trtcm_rfc4115 <port_id> <profile_id> <cir> <eir> <cbs> <ebs>",
        .tokens = {
                (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_add,
                (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port,
@@ -672,15 +672,15 @@ cmdline_parse_token_string_t cmd_del_port_meter_profile_profile =
 cmdline_parse_token_num_t cmd_del_port_meter_profile_port_id =
        TOKEN_NUM_INITIALIZER(
                struct cmd_del_port_meter_profile_result,
-                       port_id, UINT16);
+                       port_id, RTE_UINT16);
 cmdline_parse_token_num_t cmd_del_port_meter_profile_profile_id =
        TOKEN_NUM_INITIALIZER(
                struct cmd_del_port_meter_profile_result,
-                       profile_id, UINT32);
+                       profile_id, RTE_UINT32);
 
 static void cmd_del_port_meter_profile_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_del_port_meter_profile_result *res = parsed_result;
        struct rte_mtr_error error;
@@ -702,7 +702,7 @@ static void cmd_del_port_meter_profile_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_del_port_meter_profile = {
        .f = cmd_del_port_meter_profile_parsed,
        .data = NULL,
-       .help_str = "Delete port meter profile",
+       .help_str = "del port meter profile <port_id> <profile_id>",
        .tokens = {
                (void *)&cmd_del_port_meter_profile_del,
                (void *)&cmd_del_port_meter_profile_port,
@@ -742,13 +742,13 @@ cmdline_parse_token_string_t cmd_create_port_meter_meter =
                struct cmd_create_port_meter_result, meter, "meter");
 cmdline_parse_token_num_t cmd_create_port_meter_port_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_create_port_meter_result, port_id, UINT16);
+               struct cmd_create_port_meter_result, port_id, RTE_UINT16);
 cmdline_parse_token_num_t cmd_create_port_meter_mtr_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_create_port_meter_result, mtr_id, UINT32);
+               struct cmd_create_port_meter_result, mtr_id, RTE_UINT32);
 cmdline_parse_token_num_t cmd_create_port_meter_profile_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_create_port_meter_result, profile_id, UINT32);
+               struct cmd_create_port_meter_result, profile_id, RTE_UINT32);
 cmdline_parse_token_string_t cmd_create_port_meter_meter_enable =
        TOKEN_STRING_INITIALIZER(struct cmd_create_port_meter_result,
                meter_enable, "yes#no");
@@ -763,17 +763,17 @@ cmdline_parse_token_string_t cmd_create_port_meter_r_action =
                r_action, "R#Y#G#D#r#y#g#d");
 cmdline_parse_token_num_t cmd_create_port_meter_statistics_mask =
        TOKEN_NUM_INITIALIZER(struct cmd_create_port_meter_result,
-               statistics_mask, UINT64);
+               statistics_mask, RTE_UINT64);
 cmdline_parse_token_num_t cmd_create_port_meter_shared =
        TOKEN_NUM_INITIALIZER(struct cmd_create_port_meter_result,
-               shared, UINT32);
+               shared, RTE_UINT32);
 cmdline_parse_token_string_t cmd_create_port_meter_input_color =
        TOKEN_STRING_INITIALIZER(struct cmd_create_port_meter_result,
                meter_input_color, TOKEN_STRING_MULTI);
 
 static void cmd_create_port_meter_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_create_port_meter_result *res = parsed_result;
        struct rte_mtr_error error;
@@ -782,7 +782,7 @@ static void cmd_create_port_meter_parsed(void *parsed_result,
        uint32_t shared = res->shared;
        uint32_t use_prev_meter_color = 0;
        uint16_t port_id = res->port_id;
-       enum rte_mtr_color *dscp_table = NULL;
+       enum rte_color *dscp_table = NULL;
        char *c_str = res->meter_input_color;
        int ret;
 
@@ -808,11 +808,11 @@ static void cmd_create_port_meter_parsed(void *parsed_result,
        else
                params.meter_enable = 0;
 
-       params.action[RTE_MTR_GREEN] =
+       params.action[RTE_COLOR_GREEN] =
                string_to_policer_action(res->g_action);
-       params.action[RTE_MTR_YELLOW] =
+       params.action[RTE_COLOR_YELLOW] =
                string_to_policer_action(res->y_action);
-       params.action[RTE_MTR_RED] =
+       params.action[RTE_COLOR_RED] =
                string_to_policer_action(res->r_action);
        params.stats_mask = res->statistics_mask;
 
@@ -827,7 +827,10 @@ static void cmd_create_port_meter_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_create_port_meter = {
        .f = cmd_create_port_meter_parsed,
        .data = NULL,
-       .help_str = "Create port meter",
+       .help_str = "create port meter <port_id> <mtr_id> <profile_id> <meter_enable>(yes|no) "
+               "<g_action>(R|Y|G|D) <y_action>(R|Y|G|D) <r_action>(R|Y|G|D) "
+               "<stats_mask> <shared> <use_pre_meter_color> "
+               "[<dscp_tbl_entry0> <dscp_tbl_entry1> ...<dscp_tbl_entry63>]",
        .tokens = {
                (void *)&cmd_create_port_meter_create,
                (void *)&cmd_create_port_meter_port,
@@ -866,14 +869,14 @@ cmdline_parse_token_string_t cmd_enable_port_meter_meter =
                struct cmd_enable_port_meter_result, meter, "meter");
 cmdline_parse_token_num_t cmd_enable_port_meter_port_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_enable_port_meter_result, port_id, UINT16);
+               struct cmd_enable_port_meter_result, port_id, RTE_UINT16);
 cmdline_parse_token_num_t cmd_enable_port_meter_mtr_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_enable_port_meter_result, mtr_id, UINT32);
+               struct cmd_enable_port_meter_result, mtr_id, RTE_UINT32);
 
 static void cmd_enable_port_meter_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_enable_port_meter_result *res = parsed_result;
        struct rte_mtr_error error;
@@ -896,7 +899,7 @@ static void cmd_enable_port_meter_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_enable_port_meter = {
        .f = cmd_enable_port_meter_parsed,
        .data = NULL,
-       .help_str = "Enable port meter",
+       .help_str = "enable port meter <port_id> <mtr_id>",
        .tokens = {
                (void *)&cmd_enable_port_meter_enable,
                (void *)&cmd_enable_port_meter_port,
@@ -927,14 +930,14 @@ cmdline_parse_token_string_t cmd_disable_port_meter_meter =
                struct cmd_disable_port_meter_result, meter, "meter");
 cmdline_parse_token_num_t cmd_disable_port_meter_port_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_disable_port_meter_result, port_id, UINT16);
+               struct cmd_disable_port_meter_result, port_id, RTE_UINT16);
 cmdline_parse_token_num_t cmd_disable_port_meter_mtr_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_disable_port_meter_result, mtr_id, UINT32);
+               struct cmd_disable_port_meter_result, mtr_id, RTE_UINT32);
 
 static void cmd_disable_port_meter_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_disable_port_meter_result *res = parsed_result;
        struct rte_mtr_error error;
@@ -957,7 +960,7 @@ static void cmd_disable_port_meter_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_disable_port_meter = {
        .f = cmd_disable_port_meter_parsed,
        .data = NULL,
-       .help_str = "Disable port meter",
+       .help_str = "disable port meter <port_id> <mtr_id>",
        .tokens = {
                (void *)&cmd_disable_port_meter_disable,
                (void *)&cmd_disable_port_meter_port,
@@ -988,14 +991,14 @@ cmdline_parse_token_string_t cmd_del_port_meter_meter =
                struct cmd_del_port_meter_result, meter, "meter");
 cmdline_parse_token_num_t cmd_del_port_meter_port_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_del_port_meter_result, port_id, UINT16);
+               struct cmd_del_port_meter_result, port_id, RTE_UINT16);
 cmdline_parse_token_num_t cmd_del_port_meter_mtr_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_del_port_meter_result, mtr_id, UINT32);
+               struct cmd_del_port_meter_result, mtr_id, RTE_UINT32);
 
 static void cmd_del_port_meter_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_del_port_meter_result *res = parsed_result;
        struct rte_mtr_error error;
@@ -1018,7 +1021,7 @@ static void cmd_del_port_meter_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_del_port_meter = {
        .f = cmd_del_port_meter_parsed,
        .data = NULL,
-       .help_str = "Delete port meter",
+       .help_str = "del port meter <port_id> <mtr_id>",
        .tokens = {
                (void *)&cmd_del_port_meter_del,
                (void *)&cmd_del_port_meter_port,
@@ -1054,17 +1057,20 @@ cmdline_parse_token_string_t cmd_set_port_meter_profile_profile =
                struct cmd_set_port_meter_profile_result, profile, "profile");
 cmdline_parse_token_num_t cmd_set_port_meter_profile_port_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_set_port_meter_profile_result, port_id, UINT16);
+               struct cmd_set_port_meter_profile_result, port_id,
+               RTE_UINT16);
 cmdline_parse_token_num_t cmd_set_port_meter_profile_mtr_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_set_port_meter_profile_result, mtr_id, UINT32);
+               struct cmd_set_port_meter_profile_result, mtr_id,
+               RTE_UINT32);
 cmdline_parse_token_num_t cmd_set_port_meter_profile_profile_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_set_port_meter_profile_result, profile_id, UINT32);
+               struct cmd_set_port_meter_profile_result, profile_id,
+               RTE_UINT32);
 
 static void cmd_set_port_meter_profile_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_set_port_meter_profile_result *res = parsed_result;
        struct rte_mtr_error error;
@@ -1089,7 +1095,7 @@ static void cmd_set_port_meter_profile_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_set_port_meter_profile = {
        .f = cmd_set_port_meter_profile_parsed,
        .data = NULL,
-       .help_str = "Set port meter profile",
+       .help_str = "set port meter profile <port_id> <mtr_id> <profile_id>",
        .tokens = {
                (void *)&cmd_set_port_meter_profile_set,
                (void *)&cmd_set_port_meter_profile_port,
@@ -1129,12 +1135,12 @@ cmdline_parse_token_string_t cmd_set_port_meter_dscp_table_token_string =
                token_string, TOKEN_STRING_MULTI);
 
 static void cmd_set_port_meter_dscp_table_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_set_port_meter_dscp_table_result *res = parsed_result;
        struct rte_mtr_error error;
-       enum rte_mtr_color *dscp_table = NULL;
+       enum rte_color *dscp_table = NULL;
        char *t_str = res->token_string;
        uint32_t mtr_id = 0;
        uint16_t port_id;
@@ -1148,22 +1154,23 @@ static void cmd_set_port_meter_dscp_table_parsed(void *parsed_result,
        }
 
        if (port_id_is_invalid(port_id, ENABLED_WARN))
-               return;
+               goto free_table;
 
        /* Update Meter DSCP Table*/
        ret = rte_mtr_meter_dscp_table_update(port_id, mtr_id,
                dscp_table, &error);
-       if (ret != 0) {
+       if (ret != 0)
                print_err_msg(&error);
-               return;
-       }
+
+free_table:
        free(dscp_table);
 }
 
 cmdline_parse_inst_t cmd_set_port_meter_dscp_table = {
        .f = cmd_set_port_meter_dscp_table_parsed,
        .data = NULL,
-       .help_str = "Update port meter dscp table",
+       .help_str = "set port meter dscp table <port_id> <mtr_id> "
+               "[<dscp_tbl_entry0> <dscp_tbl_entry1> ... <dscp_tbl_entry63>]",
        .tokens = {
                (void *)&cmd_set_port_meter_dscp_table_set,
                (void *)&cmd_set_port_meter_dscp_table_port,
@@ -1208,23 +1215,23 @@ cmdline_parse_token_string_t cmd_set_port_meter_policer_action_action =
 cmdline_parse_token_num_t cmd_set_port_meter_policer_action_port_id =
        TOKEN_NUM_INITIALIZER(
                struct cmd_set_port_meter_policer_action_result, port_id,
-               UINT16);
+               RTE_UINT16);
 cmdline_parse_token_num_t cmd_set_port_meter_policer_action_mtr_id =
        TOKEN_NUM_INITIALIZER(
                struct cmd_set_port_meter_policer_action_result, mtr_id,
-               UINT32);
+               RTE_UINT32);
 cmdline_parse_token_num_t cmd_set_port_meter_policer_action_action_mask =
        TOKEN_NUM_INITIALIZER(
                struct cmd_set_port_meter_policer_action_result, action_mask,
-               UINT32);
+               RTE_UINT32);
 cmdline_parse_token_string_t cmd_set_port_meter_policer_action_policer_action =
        TOKEN_STRING_INITIALIZER(
                struct cmd_set_port_meter_policer_action_result,
                policer_action, TOKEN_STRING_MULTI);
 
 static void cmd_set_port_meter_policer_action_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_set_port_meter_policer_action_result *res = parsed_result;
        enum rte_mtr_policer_action *actions;
@@ -1245,7 +1252,7 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result,
        }
 
        /* Allocate memory for policer actions */
-       actions = (enum rte_mtr_policer_action *)malloc(RTE_MTR_COLORS *
+       actions = (enum rte_mtr_policer_action *)malloc(RTE_COLORS *
                sizeof(enum rte_mtr_policer_action));
        if (actions == NULL) {
                printf("Memory for policer actions not allocated (error)\n");
@@ -1262,6 +1269,7 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result,
        ret = rte_mtr_policer_actions_update(port_id, mtr_id,
                action_mask, actions, &error);
        if (ret != 0) {
+               free(actions);
                print_err_msg(&error);
                return;
        }
@@ -1272,7 +1280,8 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_set_port_meter_policer_action = {
        .f = cmd_set_port_meter_policer_action_parsed,
        .data = NULL,
-       .help_str = "Set port meter policer action",
+       .help_str = "set port meter policer action <port_id> <mtr_id> "
+               "<action_mask> <action0> [<action1> <action2>]",
        .tokens = {
                (void *)&cmd_set_port_meter_policer_action_set,
                (void *)&cmd_set_port_meter_policer_action_port,
@@ -1316,18 +1325,20 @@ cmdline_parse_token_string_t cmd_set_port_meter_stats_mask_mask =
                struct cmd_set_port_meter_stats_mask_result, mask, "mask");
 cmdline_parse_token_num_t cmd_set_port_meter_stats_mask_port_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_set_port_meter_stats_mask_result, port_id, UINT16);
+               struct cmd_set_port_meter_stats_mask_result, port_id,
+               RTE_UINT16);
 cmdline_parse_token_num_t cmd_set_port_meter_stats_mask_mtr_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_set_port_meter_stats_mask_result, mtr_id, UINT32);
+               struct cmd_set_port_meter_stats_mask_result, mtr_id,
+               RTE_UINT32);
 cmdline_parse_token_num_t cmd_set_port_meter_stats_mask_stats_mask =
        TOKEN_NUM_INITIALIZER(
                struct cmd_set_port_meter_stats_mask_result, stats_mask,
-               UINT64);
+               RTE_UINT64);
 
 static void cmd_set_port_meter_stats_mask_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_set_port_meter_stats_mask_result *res = parsed_result;
        struct rte_mtr_error error;
@@ -1349,7 +1360,7 @@ static void cmd_set_port_meter_stats_mask_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_set_port_meter_stats_mask = {
        .f = cmd_set_port_meter_stats_mask_parsed,
        .data = NULL,
-       .help_str = "Set port meter stats mask",
+       .help_str = "set port meter stats mask <port_id> <mtr_id> <stats_mask>",
        .tokens = {
                (void *)&cmd_set_port_meter_stats_mask_set,
                (void *)&cmd_set_port_meter_stats_mask_port,
@@ -1388,17 +1399,17 @@ cmdline_parse_token_string_t cmd_show_port_meter_stats_stats =
                struct cmd_show_port_meter_stats_result, stats, "stats");
 cmdline_parse_token_num_t cmd_show_port_meter_stats_port_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_show_port_meter_stats_result, port_id, UINT16);
+               struct cmd_show_port_meter_stats_result, port_id, RTE_UINT16);
 cmdline_parse_token_num_t cmd_show_port_meter_stats_mtr_id =
        TOKEN_NUM_INITIALIZER(
-               struct cmd_show_port_meter_stats_result, mtr_id, UINT32);
+               struct cmd_show_port_meter_stats_result, mtr_id, RTE_UINT32);
 cmdline_parse_token_string_t cmd_show_port_meter_stats_clear =
        TOKEN_STRING_INITIALIZER(
                struct cmd_show_port_meter_stats_result, clear, "yes#no");
 
 static void cmd_show_port_meter_stats_parsed(void *parsed_result,
-       __attribute__((unused)) struct cmdline *cl,
-       __attribute__((unused)) void *data)
+       __rte_unused struct cmdline *cl,
+       __rte_unused void *data)
 {
        struct cmd_show_port_meter_stats_result *res = parsed_result;
        struct rte_mtr_stats stats;
@@ -1426,22 +1437,22 @@ static void cmd_show_port_meter_stats_parsed(void *parsed_result,
        /* Display stats */
        if (stats_mask & RTE_MTR_STATS_N_PKTS_GREEN)
                printf("\tPkts G: %" PRIu64 "\n",
-                       stats.n_pkts[RTE_MTR_GREEN]);
+                       stats.n_pkts[RTE_COLOR_GREEN]);
        if (stats_mask & RTE_MTR_STATS_N_BYTES_GREEN)
                printf("\tBytes G: %" PRIu64 "\n",
-                       stats.n_bytes[RTE_MTR_GREEN]);
+                       stats.n_bytes[RTE_COLOR_GREEN]);
        if (stats_mask & RTE_MTR_STATS_N_PKTS_YELLOW)
                printf("\tPkts Y: %" PRIu64 "\n",
-                       stats.n_pkts[RTE_MTR_YELLOW]);
+                       stats.n_pkts[RTE_COLOR_YELLOW]);
        if (stats_mask & RTE_MTR_STATS_N_BYTES_YELLOW)
                printf("\tBytes Y: %" PRIu64 "\n",
-                       stats.n_bytes[RTE_MTR_YELLOW]);
+                       stats.n_bytes[RTE_COLOR_YELLOW]);
        if (stats_mask & RTE_MTR_STATS_N_PKTS_RED)
                printf("\tPkts R: %" PRIu64 "\n",
-                       stats.n_pkts[RTE_MTR_RED]);
+                       stats.n_pkts[RTE_COLOR_RED]);
        if (stats_mask & RTE_MTR_STATS_N_BYTES_RED)
                printf("\tBytes R: %" PRIu64 "\n",
-                       stats.n_bytes[RTE_MTR_RED]);
+                       stats.n_bytes[RTE_COLOR_RED]);
        if (stats_mask & RTE_MTR_STATS_N_PKTS_DROPPED)
                printf("\tPkts DROPPED: %" PRIu64 "\n",
                        stats.n_pkts_dropped);
@@ -1453,7 +1464,7 @@ static void cmd_show_port_meter_stats_parsed(void *parsed_result,
 cmdline_parse_inst_t cmd_show_port_meter_stats = {
        .f = cmd_show_port_meter_stats_parsed,
        .data = NULL,
-       .help_str = "Show port meter stats",
+       .help_str = "show port meter stats <port_id> <mtr_id> <clear>(yes|no)",
        .tokens = {
                (void *)&cmd_show_port_meter_stats_show,
                (void *)&cmd_show_port_meter_stats_port,