app/testpmd: fix stack overflow for EEPROM display
[dpdk.git] / app / test-pmd / testpmd.c
index a40fe1e..e1da961 100644 (file)
@@ -36,7 +36,6 @@
 #include <rte_alarm.h>
 #include <rte_per_lcore.h>
 #include <rte_lcore.h>
-#include <rte_atomic.h>
 #include <rte_branch_prediction.h>
 #include <rte_mempool.h>
 #include <rte_malloc.h>
@@ -55,7 +54,9 @@
 #include <rte_pdump.h>
 #endif
 #include <rte_flow.h>
+#ifdef RTE_LIB_METRICS
 #include <rte_metrics.h>
+#endif
 #ifdef RTE_LIB_BITRATESTATS
 #include <rte_bitrate.h>
 #endif
 #endif
 
 #define EXTMEM_HEAP_NAME "extmem"
-#define EXTBUF_ZONE_SIZE RTE_PGSIZE_2M
+/*
+ * Zone size with the malloc overhead (max of debug and release variants)
+ * must fit into the smallest supported hugepage size (2M),
+ * so that an IOVA-contiguous zone of this size can always be allocated
+ * if there are free 2M hugepages.
+ */
+#define EXTBUF_ZONE_SIZE (RTE_PGSIZE_2M - 4 * RTE_CACHE_LINE_SIZE)
 
 uint16_t verbose_level = 0; /**< Silent by default. */
 int testpmd_logtype; /**< Log type for testpmd logs */
@@ -188,6 +195,7 @@ struct fwd_engine * fwd_engines[] = {
 #ifdef RTE_LIBRTE_IEEE1588
        &ieee1588_fwd_engine,
 #endif
+       &shared_rxq_engine,
        NULL,
 };
 
@@ -219,6 +227,11 @@ unsigned int xstats_display_num; /**< Size of extended statistics to show */
  */
 uint8_t f_quit;
 
+/*
+ * Max Rx frame size, set by '--max-pkt-len' parameter.
+ */
+uint32_t max_rx_pkt_len;
+
 /*
  * Configuration of packet segments used to scatter received packets
  * if some of split features is configured.
@@ -343,7 +356,7 @@ uint64_t noisy_lkup_num_reads_writes;
 /*
  * Receive Side Scaling (RSS) configuration.
  */
-uint64_t rss_hf = ETH_RSS_IP; /* RSS IP by default. */
+uint64_t rss_hf = RTE_ETH_RSS_IP; /* RSS IP by default. */
 
 /*
  * Port topology configuration
@@ -442,7 +455,7 @@ uint32_t bypass_timeout = RTE_PMD_IXGBE_BYPASS_TMT_OFF;
 uint8_t latencystats_enabled;
 
 /*
- * Lcore ID to serive latency statistics.
+ * Lcore ID to service latency statistics.
  */
 lcoreid_t latencystats_lcore_id = -1;
 
@@ -451,21 +464,15 @@ lcoreid_t latencystats_lcore_id = -1;
 /*
  * Ethernet device configuration.
  */
-struct rte_eth_rxmode rx_mode = {
-       /* Default maximum frame length.
-        * Zero is converted to "RTE_ETHER_MTU + PMD Ethernet overhead"
-        * in init_config().
-        */
-       .max_rx_pkt_len = 0,
-};
+struct rte_eth_rxmode rx_mode;
 
 struct rte_eth_txmode tx_mode = {
-       .offloads = DEV_TX_OFFLOAD_MBUF_FAST_FREE,
+       .offloads = RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE,
 };
 
-struct rte_fdir_conf fdir_conf = {
+struct rte_eth_fdir_conf fdir_conf = {
        .mode = RTE_FDIR_MODE_NONE,
-       .pballoc = RTE_FDIR_PBALLOC_64K,
+       .pballoc = RTE_ETH_FDIR_PBALLOC_64K,
        .status = RTE_FDIR_REPORT_STATUS,
        .mask = {
                .vlan_tci_mask = 0xFFEF,
@@ -503,6 +510,11 @@ uint8_t record_core_cycles;
  */
 uint8_t record_burst_stats;
 
+/*
+ * Number of ports per shared Rx queue group, 0 disable.
+ */
+uint32_t rxq_share;
+
 unsigned int num_sockets = 0;
 unsigned int socket_ids[RTE_MAX_NUMA_NODES];
 
@@ -513,13 +525,15 @@ lcoreid_t bitrate_lcore_id;
 uint8_t bitrate_enabled;
 #endif
 
+#ifdef RTE_LIB_GRO
 struct gro_status gro_ports[RTE_MAX_ETHPORTS];
 uint8_t gro_flush_cycles = GRO_DEFAULT_FLUSH_CYCLES;
+#endif
 
 /*
  * hexadecimal bitmask of RX mq mode can be enabled.
  */
-enum rte_eth_rx_mq_mode rx_mq_mode = ETH_MQ_RX_VMDQ_DCB_RSS;
+enum rte_eth_rx_mq_mode rx_mq_mode = RTE_ETH_MQ_RX_VMDQ_DCB_RSS;
 
 /*
  * Used to set forced link speed
@@ -573,25 +587,6 @@ eth_rx_metadata_negotiate_mp(uint16_t port_id)
        }
 }
 
-static void
-flow_pick_transfer_proxy_mp(uint16_t port_id)
-{
-       struct rte_port *port = &ports[port_id];
-       int ret;
-
-       port->flow_transfer_proxy = port_id;
-
-       if (!is_proc_primary())
-               return;
-
-       ret = rte_flow_pick_transfer_proxy(port_id, &port->flow_transfer_proxy,
-                                          NULL);
-       if (ret != 0) {
-               fprintf(stderr, "Error picking flow transfer proxy for port %u: %s - ignore\n",
-                       port_id, rte_strerror(-ret));
-       }
-}
-
 static int
 eth_dev_configure_mp(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
                      const struct rte_eth_conf *dev_conf)
@@ -653,8 +648,10 @@ static void fill_xstats_display_info(void);
  */
 static int all_ports_started(void);
 
+#ifdef RTE_LIB_GSO
 struct gso_status gso_ports[RTE_MAX_ETHPORTS];
 uint16_t gso_max_segment_size = RTE_ETHER_MAX_LEN - RTE_ETHER_CRC_LEN;
+#endif
 
 /* Holds the registered mbuf dynamic flags names. */
 char dynf_names[64][RTE_MBUF_DYN_NAMESIZE];
@@ -1070,12 +1067,11 @@ setup_extbuf(uint32_t nb_mbufs, uint16_t mbuf_sz, unsigned int socket_id,
                        ext_num = 0;
                        break;
                }
-               mz = rte_memzone_reserve_aligned(mz_name, EXTBUF_ZONE_SIZE,
-                                                socket_id,
-                                                RTE_MEMZONE_IOVA_CONTIG |
-                                                RTE_MEMZONE_1GB |
-                                                RTE_MEMZONE_SIZE_HINT_ONLY,
-                                                EXTBUF_ZONE_SIZE);
+               mz = rte_memzone_reserve(mz_name, EXTBUF_ZONE_SIZE,
+                                        socket_id,
+                                        RTE_MEMZONE_IOVA_CONTIG |
+                                        RTE_MEMZONE_1GB |
+                                        RTE_MEMZONE_SIZE_HINT_ONLY);
                if (mz == NULL) {
                        /*
                         * The caller exits on external buffer creation
@@ -1542,16 +1538,28 @@ check_nb_hairpinq(queueid_t hairpinq)
        return 0;
 }
 
+static int
+get_eth_overhead(struct rte_eth_dev_info *dev_info)
+{
+       uint32_t eth_overhead;
+
+       if (dev_info->max_mtu != UINT16_MAX &&
+           dev_info->max_rx_pktlen > dev_info->max_mtu)
+               eth_overhead = dev_info->max_rx_pktlen - dev_info->max_mtu;
+       else
+               eth_overhead = RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
+
+       return eth_overhead;
+}
+
 static void
 init_config_port_offloads(portid_t pid, uint32_t socket_id)
 {
        struct rte_port *port = &ports[pid];
-       uint16_t data_size;
        int ret;
        int i;
 
        eth_rx_metadata_negotiate_mp(pid);
-       flow_pick_transfer_proxy_mp(pid);
 
        port->dev_conf.txmode = tx_mode;
        port->dev_conf.rxmode = rx_mode;
@@ -1560,15 +1568,9 @@ init_config_port_offloads(portid_t pid, uint32_t socket_id)
        if (ret != 0)
                rte_exit(EXIT_FAILURE, "rte_eth_dev_info_get() failed\n");
 
-       ret = update_jumbo_frame_offload(pid);
-       if (ret != 0)
-               fprintf(stderr,
-                       "Updating jumbo frame offload failed for port %u\n",
-                       pid);
-
-       if (!(port->dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE))
+       if (!(port->dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE))
                port->dev_conf.txmode.offloads &=
-                       ~DEV_TX_OFFLOAD_MBUF_FAST_FREE;
+                       ~RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;
 
        /* Apply Rx offloads configuration */
        for (i = 0; i < port->dev_info.max_rx_queues; i++)
@@ -1580,6 +1582,10 @@ init_config_port_offloads(portid_t pid, uint32_t socket_id)
        if (eth_link_speed)
                port->dev_conf.link_speeds = eth_link_speed;
 
+       if (max_rx_pkt_len)
+               port->dev_conf.rxmode.mtu = max_rx_pkt_len -
+                       get_eth_overhead(&port->dev_info);
+
        /* set flag to initialize port/queue */
        port->need_reconfig = 1;
        port->need_reconfig_queues = 1;
@@ -1592,14 +1598,20 @@ init_config_port_offloads(portid_t pid, uint32_t socket_id)
         */
        if (port->dev_info.rx_desc_lim.nb_mtu_seg_max != UINT16_MAX &&
            port->dev_info.rx_desc_lim.nb_mtu_seg_max != 0) {
-               data_size = rx_mode.max_rx_pkt_len /
-                       port->dev_info.rx_desc_lim.nb_mtu_seg_max;
-
-               if ((data_size + RTE_PKTMBUF_HEADROOM) > mbuf_data_size[0]) {
-                       mbuf_data_size[0] = data_size + RTE_PKTMBUF_HEADROOM;
-                       TESTPMD_LOG(WARNING,
-                                   "Configured mbuf size of the first segment %hu\n",
-                                   mbuf_data_size[0]);
+               uint32_t eth_overhead = get_eth_overhead(&port->dev_info);
+               uint16_t mtu;
+
+               if (rte_eth_dev_get_mtu(pid, &mtu) == 0) {
+                       uint16_t data_size = (mtu + eth_overhead) /
+                               port->dev_info.rx_desc_lim.nb_mtu_seg_max;
+                       uint16_t buffer_size = data_size + RTE_PKTMBUF_HEADROOM;
+
+                       if (buffer_size > mbuf_data_size[0]) {
+                               mbuf_data_size[0] = buffer_size;
+                               TESTPMD_LOG(WARNING,
+                                       "Configured mbuf size of the first segment %hu\n",
+                                       mbuf_data_size[0]);
+                       }
                }
        }
 }
@@ -1611,8 +1623,12 @@ init_config(void)
        struct rte_mempool *mbp;
        unsigned int nb_mbuf_per_pool;
        lcoreid_t  lc_id;
+#ifdef RTE_LIB_GRO
        struct rte_gro_param gro_param;
+#endif
+#ifdef RTE_LIB_GSO
        uint32_t gso_types;
+#endif
 
        /* Configuration of logical cores. */
        fwd_lcores = rte_zmalloc("testpmd: fwd_lcores",
@@ -1695,8 +1711,10 @@ init_config(void)
 
        init_port_config();
 
-       gso_types = DEV_TX_OFFLOAD_TCP_TSO | DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
-               DEV_TX_OFFLOAD_GRE_TNL_TSO | DEV_TX_OFFLOAD_UDP_TSO;
+#ifdef RTE_LIB_GSO
+       gso_types = RTE_ETH_TX_OFFLOAD_TCP_TSO | RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
+               RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | RTE_ETH_TX_OFFLOAD_UDP_TSO;
+#endif
        /*
         * Records which Mbuf pool to use by each logical core, if needed.
         */
@@ -1707,6 +1725,7 @@ init_config(void)
                if (mbp == NULL)
                        mbp = mbuf_pool_find(0, 0);
                fwd_lcores[lc_id]->mbp = mbp;
+#ifdef RTE_LIB_GSO
                /* initialize GSO context */
                fwd_lcores[lc_id]->gso_ctx.direct_pool = mbp;
                fwd_lcores[lc_id]->gso_ctx.indirect_pool = mbp;
@@ -1714,10 +1733,12 @@ init_config(void)
                fwd_lcores[lc_id]->gso_ctx.gso_size = RTE_ETHER_MAX_LEN -
                        RTE_ETHER_CRC_LEN;
                fwd_lcores[lc_id]->gso_ctx.flag = 0;
+#endif
        }
 
        fwd_config_setup();
 
+#ifdef RTE_LIB_GRO
        /* create a gro context for each lcore */
        gro_param.gro_types = RTE_GRO_TCP_IPV4;
        gro_param.max_flow_num = GRO_MAX_FLUSH_CYCLES;
@@ -1731,6 +1752,7 @@ init_config(void)
                                        "rte_gro_ctx_create() failed\n");
                }
        }
+#endif
 }
 
 
@@ -1857,7 +1879,7 @@ pkt_burst_stats_display(const char *rx_tx, struct pkt_burst_stats *pbs)
        pktnb_stats[0] = 0;
 
        /* Find the next 2 burst sizes with highest occurrences. */
-       for (nb_pkt = 1; nb_pkt < MAX_PKT_BURST; nb_pkt++) {
+       for (nb_pkt = 1; nb_pkt < MAX_PKT_BURST + 1; nb_pkt++) {
                nb_burst = pbs->pkt_burst_spread[nb_pkt];
 
                if (nb_burst == 0)
@@ -2288,6 +2310,10 @@ start_packet_forwarding(int with_tx_first)
 
        fwd_config_setup();
 
+       pkt_fwd_config_display(&cur_fwd_config);
+       if (!pkt_fwd_shared_rxq_check())
+               return;
+
        port_fwd_begin = cur_fwd_config.fwd_eng->port_fwd_begin;
        if (port_fwd_begin != NULL) {
                for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++) {
@@ -2317,7 +2343,6 @@ start_packet_forwarding(int with_tx_first)
        if(!no_flush_rx)
                flush_fwd_rx_queues();
 
-       pkt_fwd_config_display(&cur_fwd_config);
        rxtx_config_display();
 
        fwd_stats_reset();
@@ -2496,9 +2521,9 @@ setup_hairpin_queues(portid_t pi, portid_t p_pi, uint16_t cnt_pi)
                        continue;
 
                /* Fail to setup rx queue, return */
-               if (rte_atomic16_cmpset(&(port->port_status),
-                                       RTE_PORT_HANDLING,
-                                       RTE_PORT_STOPPED) == 0)
+               if (port->port_status == RTE_PORT_HANDLING)
+                       port->port_status = RTE_PORT_STOPPED;
+               else
                        fprintf(stderr,
                                "Port %d can not be set back to stopped\n", pi);
                fprintf(stderr, "Fail to configure port %d hairpin queues\n",
@@ -2519,9 +2544,9 @@ setup_hairpin_queues(portid_t pi, portid_t p_pi, uint16_t cnt_pi)
                        continue;
 
                /* Fail to setup rx queue, return */
-               if (rte_atomic16_cmpset(&(port->port_status),
-                                       RTE_PORT_HANDLING,
-                                       RTE_PORT_STOPPED) == 0)
+               if (port->port_status == RTE_PORT_HANDLING)
+                       port->port_status = RTE_PORT_STOPPED;
+               else
                        fprintf(stderr,
                                "Port %d can not be set back to stopped\n", pi);
                fprintf(stderr, "Fail to configure port %d hairpin queues\n",
@@ -2704,13 +2729,17 @@ start_port(portid_t pid)
 
                need_check_link_status = 0;
                port = &ports[pi];
-               if (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_STOPPED,
-                                                RTE_PORT_HANDLING) == 0) {
+               if (port->port_status == RTE_PORT_STOPPED)
+                       port->port_status = RTE_PORT_HANDLING;
+               else {
                        fprintf(stderr, "Port %d is now not stopped\n", pi);
                        continue;
                }
 
                if (port->need_reconfig > 0) {
+                       struct rte_eth_conf dev_conf;
+                       int k;
+
                        port->need_reconfig = 0;
 
                        if (flow_isolate_all) {
@@ -2732,13 +2761,15 @@ start_port(portid_t pid)
                                        pi);
                                return -1;
                        }
+
                        /* configure port */
                        diag = eth_dev_configure_mp(pi, nb_rxq + nb_hairpinq,
                                                     nb_txq + nb_hairpinq,
                                                     &(port->dev_conf));
                        if (diag != 0) {
-                               if (rte_atomic16_cmpset(&(port->port_status),
-                               RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0)
+                               if (port->port_status == RTE_PORT_HANDLING)
+                                       port->port_status = RTE_PORT_STOPPED;
+                               else
                                        fprintf(stderr,
                                                "Port %d can not be set back to stopped\n",
                                                pi);
@@ -2748,6 +2779,36 @@ start_port(portid_t pid)
                                port->need_reconfig = 1;
                                return -1;
                        }
+                       /* get device configuration*/
+                       if (0 !=
+                               eth_dev_conf_get_print_err(pi, &dev_conf)) {
+                               fprintf(stderr,
+                                       "port %d can not get device configuration\n",
+                                       pi);
+                               return -1;
+                       }
+                       /* Apply Rx offloads configuration */
+                       if (dev_conf.rxmode.offloads !=
+                           port->dev_conf.rxmode.offloads) {
+                               port->dev_conf.rxmode.offloads |=
+                                       dev_conf.rxmode.offloads;
+                               for (k = 0;
+                                    k < port->dev_info.max_rx_queues;
+                                    k++)
+                                       port->rx_conf[k].offloads |=
+                                               dev_conf.rxmode.offloads;
+                       }
+                       /* Apply Tx offloads configuration */
+                       if (dev_conf.txmode.offloads !=
+                           port->dev_conf.txmode.offloads) {
+                               port->dev_conf.txmode.offloads |=
+                                       dev_conf.txmode.offloads;
+                               for (k = 0;
+                                    k < port->dev_info.max_tx_queues;
+                                    k++)
+                                       port->tx_conf[k].offloads |=
+                                               dev_conf.txmode.offloads;
+                       }
                }
                if (port->need_reconfig_queues > 0 && is_proc_primary()) {
                        port->need_reconfig_queues = 0;
@@ -2769,9 +2830,9 @@ start_port(portid_t pid)
                                        continue;
 
                                /* Fail to setup tx queue, return */
-                               if (rte_atomic16_cmpset(&(port->port_status),
-                                                       RTE_PORT_HANDLING,
-                                                       RTE_PORT_STOPPED) == 0)
+                               if (port->port_status == RTE_PORT_HANDLING)
+                                       port->port_status = RTE_PORT_STOPPED;
+                               else
                                        fprintf(stderr,
                                                "Port %d can not be set back to stopped\n",
                                                pi);
@@ -2821,9 +2882,9 @@ start_port(portid_t pid)
                                        continue;
 
                                /* Fail to setup rx queue, return */
-                               if (rte_atomic16_cmpset(&(port->port_status),
-                                                       RTE_PORT_HANDLING,
-                                                       RTE_PORT_STOPPED) == 0)
+                               if (port->port_status == RTE_PORT_HANDLING)
+                                       port->port_status = RTE_PORT_STOPPED;
+                               else
                                        fprintf(stderr,
                                                "Port %d can not be set back to stopped\n",
                                                pi);
@@ -2858,16 +2919,18 @@ start_port(portid_t pid)
                                pi, rte_strerror(-diag));
 
                        /* Fail to setup rx queue, return */
-                       if (rte_atomic16_cmpset(&(port->port_status),
-                               RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0)
+                       if (port->port_status == RTE_PORT_HANDLING)
+                               port->port_status = RTE_PORT_STOPPED;
+                       else
                                fprintf(stderr,
                                        "Port %d can not be set back to stopped\n",
                                        pi);
                        continue;
                }
 
-               if (rte_atomic16_cmpset(&(port->port_status),
-                       RTE_PORT_HANDLING, RTE_PORT_STARTED) == 0)
+               if (port->port_status == RTE_PORT_HANDLING)
+                       port->port_status = RTE_PORT_STARTED;
+               else
                        fprintf(stderr, "Port %d can not be set into started\n",
                                pi);
 
@@ -2969,8 +3032,9 @@ stop_port(portid_t pid)
                }
 
                port = &ports[pi];
-               if (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_STARTED,
-                                               RTE_PORT_HANDLING) == 0)
+               if (port->port_status == RTE_PORT_STARTED)
+                       port->port_status = RTE_PORT_HANDLING;
+               else
                        continue;
 
                if (hairpin_mode & 0xf) {
@@ -2996,8 +3060,9 @@ stop_port(portid_t pid)
                        RTE_LOG(ERR, EAL, "rte_eth_dev_stop failed for port %u\n",
                                pi);
 
-               if (rte_atomic16_cmpset(&(port->port_status),
-                       RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0)
+               if (port->port_status == RTE_PORT_HANDLING)
+                       port->port_status = RTE_PORT_STOPPED;
+               else
                        fprintf(stderr, "Port %d can not be set into stopped\n",
                                pi);
                need_check_link_status = 1;
@@ -3060,14 +3125,14 @@ close_port(portid_t pid)
                }
 
                port = &ports[pi];
-               if (rte_atomic16_cmpset(&(port->port_status),
-                       RTE_PORT_CLOSED, RTE_PORT_CLOSED) == 1) {
+               if (port->port_status == RTE_PORT_CLOSED) {
                        fprintf(stderr, "Port %d is already closed\n", pi);
                        continue;
                }
 
                if (is_proc_primary()) {
                        port_flow_flush(pi);
+                       port_flex_item_flush(pi);
                        rte_eth_dev_close(pi);
                }
 
@@ -3406,7 +3471,7 @@ check_all_ports_link_status(uint32_t port_mask)
                                continue;
                        }
                        /* clear all_ports_up flag if any link down */
-                       if (link.link_status == ETH_LINK_DOWN) {
+                       if (link.link_status == RTE_ETH_LINK_DOWN) {
                                all_ports_up = 0;
                                break;
                        }
@@ -3578,14 +3643,23 @@ dev_event_callback(const char *device_name, enum rte_dev_event_type type,
 }
 
 static void
-rxtx_port_config(struct rte_port *port)
+rxtx_port_config(portid_t pid)
 {
        uint16_t qid;
        uint64_t offloads;
+       struct rte_port *port = &ports[pid];
 
        for (qid = 0; qid < nb_rxq; qid++) {
                offloads = port->rx_conf[qid].offloads;
                port->rx_conf[qid] = port->dev_info.default_rxconf;
+
+               if (rxq_share > 0 &&
+                   (port->dev_info.dev_capa & RTE_ETH_DEV_CAPA_RXQ_SHARE)) {
+                       /* Non-zero share group to enable RxQ share. */
+                       port->rx_conf[qid].share_group = pid / rxq_share + 1;
+                       port->rx_conf[qid].share_qid = qid; /* Equal mapping. */
+               }
+
                if (offloads != 0)
                        port->rx_conf[qid].offloads = offloads;
 
@@ -3635,77 +3709,39 @@ rxtx_port_config(struct rte_port *port)
 }
 
 /*
- * Helper function to arrange max_rx_pktlen value and JUMBO_FRAME offload,
- * MTU is also aligned if JUMBO_FRAME offload is not set.
+ * Helper function to set MTU from frame size
  *
  * port->dev_info should be set before calling this function.
  *
  * return 0 on success, negative on error
  */
 int
-update_jumbo_frame_offload(portid_t portid)
+update_mtu_from_frame_size(portid_t portid, uint32_t max_rx_pktlen)
 {
        struct rte_port *port = &ports[portid];
        uint32_t eth_overhead;
-       uint64_t rx_offloads;
-       int ret;
-       bool on;
-
-       /* Update the max_rx_pkt_len to have MTU as RTE_ETHER_MTU */
-       if (port->dev_info.max_mtu != UINT16_MAX &&
-           port->dev_info.max_rx_pktlen > port->dev_info.max_mtu)
-               eth_overhead = port->dev_info.max_rx_pktlen -
-                               port->dev_info.max_mtu;
-       else
-               eth_overhead = RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
-
-       rx_offloads = port->dev_conf.rxmode.offloads;
+       uint16_t mtu, new_mtu;
 
-       /* Default config value is 0 to use PMD specific overhead */
-       if (port->dev_conf.rxmode.max_rx_pkt_len == 0)
-               port->dev_conf.rxmode.max_rx_pkt_len = RTE_ETHER_MTU + eth_overhead;
+       eth_overhead = get_eth_overhead(&port->dev_info);
 
-       if (port->dev_conf.rxmode.max_rx_pkt_len <= RTE_ETHER_MTU + eth_overhead) {
-               rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
-               on = false;
-       } else {
-               if ((port->dev_info.rx_offload_capa & DEV_RX_OFFLOAD_JUMBO_FRAME) == 0) {
-                       fprintf(stderr,
-                               "Frame size (%u) is not supported by port %u\n",
-                               port->dev_conf.rxmode.max_rx_pkt_len,
-                               portid);
-                       return -1;
-               }
-               rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
-               on = true;
+       if (rte_eth_dev_get_mtu(portid, &mtu) != 0) {
+               printf("Failed to get MTU for port %u\n", portid);
+               return -1;
        }
 
-       if (rx_offloads != port->dev_conf.rxmode.offloads) {
-               uint16_t qid;
+       new_mtu = max_rx_pktlen - eth_overhead;
 
-               port->dev_conf.rxmode.offloads = rx_offloads;
+       if (mtu == new_mtu)
+               return 0;
 
-               /* Apply JUMBO_FRAME offload configuration to Rx queue(s) */
-               for (qid = 0; qid < port->dev_info.nb_rx_queues; qid++) {
-                       if (on)
-                               port->rx_conf[qid].offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
-                       else
-                               port->rx_conf[qid].offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
-               }
+       if (eth_dev_set_mtu_mp(portid, new_mtu) != 0) {
+               fprintf(stderr,
+                       "Failed to set MTU to %u for port %u\n",
+                       new_mtu, portid);
+               return -1;
        }
 
-       /* If JUMBO_FRAME is set MTU conversion done by ethdev layer,
-        * if unset do it here
-        */
-       if ((rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) == 0) {
-               ret = eth_dev_set_mtu_mp(portid,
-                               port->dev_conf.rxmode.max_rx_pkt_len - eth_overhead);
-               if (ret)
-                       fprintf(stderr,
-                               "Failed to set MTU to %u for port %u\n",
-                               port->dev_conf.rxmode.max_rx_pkt_len - eth_overhead,
-                               portid);
-       }
+       port->dev_conf.rxmode.mtu = new_mtu;
 
        return 0;
 }
@@ -3715,7 +3751,7 @@ init_port_config(void)
 {
        portid_t pid;
        struct rte_port *port;
-       int ret;
+       int ret, i;
 
        RTE_ETH_FOREACH_DEV(pid) {
                port = &ports[pid];
@@ -3735,15 +3771,24 @@ init_port_config(void)
                }
 
                if (port->dcb_flag == 0) {
-                       if( port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0)
+                       if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) {
                                port->dev_conf.rxmode.mq_mode =
                                        (enum rte_eth_rx_mq_mode)
-                                               (rx_mq_mode & ETH_MQ_RX_RSS);
-                       else
-                               port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
+                                               (rx_mq_mode & RTE_ETH_MQ_RX_RSS);
+                       } else {
+                               port->dev_conf.rxmode.mq_mode = RTE_ETH_MQ_RX_NONE;
+                               port->dev_conf.rxmode.offloads &=
+                                               ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
+
+                               for (i = 0;
+                                    i < port->dev_info.nb_rx_queues;
+                                    i++)
+                                       port->rx_conf[i].offloads &=
+                                               ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
+                       }
                }
 
-               rxtx_port_config(port);
+               rxtx_port_config(pid);
 
                ret = eth_macaddr_get_print_err(pid, &port->eth_addr);
                if (ret != 0)
@@ -3827,9 +3872,9 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,
                vmdq_rx_conf->enable_default_pool = 0;
                vmdq_rx_conf->default_pool = 0;
                vmdq_rx_conf->nb_queue_pools =
-                       (num_tcs ==  ETH_4_TCS ? ETH_32_POOLS : ETH_16_POOLS);
+                       (num_tcs ==  RTE_ETH_4_TCS ? RTE_ETH_32_POOLS : RTE_ETH_16_POOLS);
                vmdq_tx_conf->nb_queue_pools =
-                       (num_tcs ==  ETH_4_TCS ? ETH_32_POOLS : ETH_16_POOLS);
+                       (num_tcs ==  RTE_ETH_4_TCS ? RTE_ETH_32_POOLS : RTE_ETH_16_POOLS);
 
                vmdq_rx_conf->nb_pool_maps = vmdq_rx_conf->nb_queue_pools;
                for (i = 0; i < vmdq_rx_conf->nb_pool_maps; i++) {
@@ -3837,7 +3882,7 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,
                        vmdq_rx_conf->pool_map[i].pools =
                                1 << (i % vmdq_rx_conf->nb_queue_pools);
                }
-               for (i = 0; i < ETH_DCB_NUM_USER_PRIORITIES; i++) {
+               for (i = 0; i < RTE_ETH_DCB_NUM_USER_PRIORITIES; i++) {
                        vmdq_rx_conf->dcb_tc[i] = i % num_tcs;
                        vmdq_tx_conf->dcb_tc[i] = i % num_tcs;
                }
@@ -3845,8 +3890,8 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,
                /* set DCB mode of RX and TX of multiple queues */
                eth_conf->rxmode.mq_mode =
                                (enum rte_eth_rx_mq_mode)
-                                       (rx_mq_mode & ETH_MQ_RX_VMDQ_DCB);
-               eth_conf->txmode.mq_mode = ETH_MQ_TX_VMDQ_DCB;
+                                       (rx_mq_mode & RTE_ETH_MQ_RX_VMDQ_DCB);
+               eth_conf->txmode.mq_mode = RTE_ETH_MQ_TX_VMDQ_DCB;
        } else {
                struct rte_eth_dcb_rx_conf *rx_conf =
                                &eth_conf->rx_adv_conf.dcb_rx_conf;
@@ -3862,23 +3907,23 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,
                rx_conf->nb_tcs = num_tcs;
                tx_conf->nb_tcs = num_tcs;
 
-               for (i = 0; i < ETH_DCB_NUM_USER_PRIORITIES; i++) {
+               for (i = 0; i < RTE_ETH_DCB_NUM_USER_PRIORITIES; i++) {
                        rx_conf->dcb_tc[i] = i % num_tcs;
                        tx_conf->dcb_tc[i] = i % num_tcs;
                }
 
                eth_conf->rxmode.mq_mode =
                                (enum rte_eth_rx_mq_mode)
-                                       (rx_mq_mode & ETH_MQ_RX_DCB_RSS);
+                                       (rx_mq_mode & RTE_ETH_MQ_RX_DCB_RSS);
                eth_conf->rx_adv_conf.rss_conf = rss_conf;
-               eth_conf->txmode.mq_mode = ETH_MQ_TX_DCB;
+               eth_conf->txmode.mq_mode = RTE_ETH_MQ_TX_DCB;
        }
 
        if (pfc_en)
                eth_conf->dcb_capability_en =
-                               ETH_DCB_PG_SUPPORT | ETH_DCB_PFC_SUPPORT;
+                               RTE_ETH_DCB_PG_SUPPORT | RTE_ETH_DCB_PFC_SUPPORT;
        else
-               eth_conf->dcb_capability_en = ETH_DCB_PG_SUPPORT;
+               eth_conf->dcb_capability_en = RTE_ETH_DCB_PG_SUPPORT;
 
        return 0;
 }
@@ -3907,7 +3952,14 @@ init_port_dcb_config(portid_t pid,
        retval = get_eth_dcb_conf(pid, &port_conf, dcb_mode, num_tcs, pfc_en);
        if (retval < 0)
                return retval;
-       port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;
+       port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
+       /* remove RSS HASH offload for DCB in vt mode */
+       if (port_conf.rxmode.mq_mode == RTE_ETH_MQ_RX_VMDQ_DCB) {
+               port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
+               for (i = 0; i < nb_rxq; i++)
+                       rte_port->rx_conf[i].offloads &=
+                               ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
+       }
 
        /* re-configure the device . */
        retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
@@ -3955,9 +4007,9 @@ init_port_dcb_config(portid_t pid,
 
        memcpy(&rte_port->dev_conf, &port_conf, sizeof(struct rte_eth_conf));
 
-       rxtx_port_config(rte_port);
+       rxtx_port_config(pid);
        /* VLAN filter */
-       rte_port->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;
+       rte_port->dev_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
        for (i = 0; i < RTE_DIM(vlan_tags); i++)
                rx_vft_set(pid, vlan_tags[i], 1);
 
@@ -4177,8 +4229,10 @@ main(int argc, char** argv)
                                port_id, rte_strerror(-ret));
        }
 
+#ifdef RTE_LIB_METRICS
        /* Init metrics library */
        rte_metrics_init(rte_socket_id());
+#endif
 
 #ifdef RTE_LIB_LATENCYSTATS
        if (latencystats_enabled != 0) {
@@ -4202,7 +4256,6 @@ main(int argc, char** argv)
                rte_stats_bitrate_reg(bitrate_data);
        }
 #endif
-
 #ifdef RTE_LIB_CMDLINE
        if (strlen(cmdline_filename) != 0)
                cmdline_read_from_file(cmdline_filename);