net/i40e: fix 25G AOC and ACC cable detection on XXV710

[dpdk.git] / devtools / check-symbol-change.sh

diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 9952a8d..cf9cfc7 100755 (executable)
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -4,10 +4,10 @@
 
 build_map_changes()
 {
-       local fname=$1
-       local mapdb=$2
+       local fname="$1"
+       local mapdb="$2"
 
-       cat $fname | awk '
+       cat "$fname" | awk '
                # Initialize our variables
                BEGIN {map="";sym="";ar="";sec=""; in_sec=0; in_map=0}
 
@@ -25,14 +25,14 @@ build_map_changes()
                # supresses the subordonate rules below
                /[-+] a\/.*\.^(map)/ {in_map=0}
 
-               # Triggering this rule, which starts a line with a + and ends it
+               # Triggering this rule, which starts a line and ends it
                # with a { identifies a versioned section.  The section name is
                # the rest of the line with the + and { symbols remvoed.
                # Triggering this rule sets in_sec to 1, which actives the
                # symbol rule below
-               /+.*{/ {gsub("+","");
+               /^.*{/ {
                        if (in_map == 1) {
-                               sec=$1; in_sec=1;
+                               sec=$(NF-1); in_sec=1;
                        }
                }
 
@@ -71,16 +71,16 @@ build_map_changes()
                                        print map " " sym " unknown del"
                                }
                        }
-               }' > ./$mapdb
+               }' > "$mapdb"
 
-               sort -u $mapdb > ./$mapdb.2
-               mv -f $mapdb.2 $mapdb
+               sort -u "$mapdb" > "$mapdb.2"
+               mv -f "$mapdb.2" "$mapdb"
 
 }
 
 check_for_rule_violations()
 {
-       local mapdb=$1
+       local mapdb="$1"
        local mname
        local symname
        local secname
@@ -89,10 +89,10 @@ check_for_rule_violations()
 
        while read mname symname secname ar
        do
-               if [ "$ar" == "add" ]
+               if [ "$ar" = "add" ]
                then
 
-                       if [ "$secname" == "unknown" ]
+                       if [ "$secname" = "unknown" ]
                        then
                                # Just inform the user of this occurrence, but
                                # don't flag it as an error
@@ -111,7 +111,7 @@ check_for_rule_violations()
                                # to be moving from an already supported
                                # section or its a violation
                                grep -q \
-                               "$mname $symname [^EXPERIMENTAL] del" $mapdb
+                               "$mname $symname [^EXPERIMENTAL] del" "$mapdb"
                                if [ $? -ne 0 ]
                                then
                                        echo -n "ERROR: symbol $symname "
@@ -133,7 +133,7 @@ check_for_rule_violations()
                                echo "gone through the deprecation process"
                        fi
                fi
-       done < $mapdb
+       done < "$mapdb"
 
        return $ret
 }
@@ -146,14 +146,14 @@ exit_code=1
 
 clean_and_exit_on_sig()
 {
-       rm -f $mapfile
+       rm -f "$mapfile"
        exit $exit_code
 }
 
-build_map_changes $patch $mapfile
-check_for_rule_violations $mapfile
+build_map_changes "$patch" "$mapfile"
+check_for_rule_violations "$mapfile"
 exit_code=$?
 
-rm -f $mapfile
+rm -f "$mapfile"
 
 exit $exit_code