common/mlx5: refactor devargs management
[dpdk.git] / drivers / crypto / mlx5 / mlx5_crypto.c
index b22b783..e14f867 100644 (file)
@@ -4,6 +4,7 @@
 
 #include <rte_malloc.h>
 #include <rte_mempool.h>
+#include <rte_eal_paging.h>
 #include <rte_errno.h>
 #include <rte_log.h>
 #include <rte_bus_pci.h>
@@ -19,7 +20,7 @@
 
 #define MLX5_CRYPTO_DRIVER_NAME crypto_mlx5
 #define MLX5_CRYPTO_LOG_NAME pmd.crypto.mlx5
-#define MLX5_CRYPTO_MAX_QPS 1024
+#define MLX5_CRYPTO_MAX_QPS 128
 #define MLX5_CRYPTO_MAX_SEGS 56
 
 #define MLX5_CRYPTO_FEATURE_FLAGS \
@@ -33,7 +34,7 @@
 
 TAILQ_HEAD(mlx5_crypto_privs, mlx5_crypto_priv) mlx5_crypto_priv_list =
                                TAILQ_HEAD_INITIALIZER(mlx5_crypto_priv_list);
-static pthread_mutex_t priv_list_lock = PTHREAD_MUTEX_INITIALIZER;
+static pthread_mutex_t priv_list_lock;
 
 int mlx5_crypto_logtype;
 
@@ -59,7 +60,8 @@ const struct rte_cryptodev_capabilities mlx5_crypto_caps[] = {
                                },
                                .dataunit_set =
                                RTE_CRYPTO_CIPHER_DATA_UNIT_LEN_512_BYTES |
-                               RTE_CRYPTO_CIPHER_DATA_UNIT_LEN_4096_BYTES,
+                               RTE_CRYPTO_CIPHER_DATA_UNIT_LEN_4096_BYTES |
+                               RTE_CRYPTO_CIPHER_DATA_UNIT_LEN_1_MEGABYTES,
                        }, }
                }, }
        },
@@ -142,8 +144,9 @@ mlx5_crypto_dev_stop(struct rte_cryptodev *dev)
 static int
 mlx5_crypto_dev_start(struct rte_cryptodev *dev)
 {
-       RTE_SET_USED(dev);
-       return 0;
+       struct mlx5_crypto_priv *priv = dev->data->dev_private;
+
+       return mlx5_dev_mempool_subscribe(priv->cdev);
 }
 
 static int
@@ -220,6 +223,11 @@ mlx5_crypto_sym_session_configure(struct rte_cryptodev *dev,
                                             ((uint32_t)MLX5_BLOCK_SIZE_4096B <<
                                             MLX5_BLOCK_SIZE_OFFSET);
                break;
+       case 1048576:
+               sess_private_data->bsp_res = rte_cpu_to_be_32
+                                            ((uint32_t)MLX5_BLOCK_SIZE_1MB <<
+                                            MLX5_BLOCK_SIZE_OFFSET);
+               break;
        default:
                DRV_LOG(ERR, "Cipher data unit length is not supported.");
                return -ENOTSUP;
@@ -303,44 +311,10 @@ mlx5_crypto_get_block_size(struct rte_crypto_op *op)
        }
 }
 
-/**
- * Query LKey from a packet buffer for QP. If not found, add the mempool.
- *
- * @param priv
- *   Pointer to the priv object.
- * @param addr
- *   Search key.
- * @param mr_ctrl
- *   Pointer to per-queue MR control structure.
- * @param ol_flags
- *   Mbuf offload features.
- *
- * @return
- *   Searched LKey on success, UINT32_MAX on no match.
- */
 static __rte_always_inline uint32_t
-mlx5_crypto_addr2mr(struct mlx5_crypto_priv *priv, uintptr_t addr,
-                   struct mlx5_mr_ctrl *mr_ctrl, uint64_t ol_flags)
-{
-       uint32_t lkey;
-
-       /* Check generation bit to see if there's any change on existing MRs. */
-       if (unlikely(*mr_ctrl->dev_gen_ptr != mr_ctrl->cur_gen))
-               mlx5_mr_flush_local_cache(mr_ctrl);
-       /* Linear search on MR cache array. */
-       lkey = mlx5_mr_lookup_lkey(mr_ctrl->cache, &mr_ctrl->mru,
-                                  MLX5_MR_CACHE_N, addr);
-       if (likely(lkey != UINT32_MAX))
-               return lkey;
-       /* Take slower bottom-half on miss. */
-       return mlx5_mr_addr2mr_bh(priv->cdev->pd, 0, &priv->mr_scache, mr_ctrl,
-                                 addr, !!(ol_flags & EXT_ATTACHED_MBUF));
-}
-
-static __rte_always_inline uint32_t
-mlx5_crypto_klm_set(struct mlx5_crypto_priv *priv, struct mlx5_crypto_qp *qp,
-                     struct rte_mbuf *mbuf, struct mlx5_wqe_dseg *klm,
-                     uint32_t offset, uint32_t *remain)
+mlx5_crypto_klm_set(struct mlx5_crypto_qp *qp, struct rte_mbuf *mbuf,
+                   struct mlx5_wqe_dseg *klm, uint32_t offset,
+                   uint32_t *remain)
 {
        uint32_t data_len = (rte_pktmbuf_data_len(mbuf) - offset);
        uintptr_t addr = rte_pktmbuf_mtod_offset(mbuf, uintptr_t, offset);
@@ -350,23 +324,21 @@ mlx5_crypto_klm_set(struct mlx5_crypto_priv *priv, struct mlx5_crypto_qp *qp,
        *remain -= data_len;
        klm->bcount = rte_cpu_to_be_32(data_len);
        klm->pbuf = rte_cpu_to_be_64(addr);
-       klm->lkey = mlx5_crypto_addr2mr(priv, addr, &qp->mr_ctrl,
-                                       mbuf->ol_flags);
+       klm->lkey = mlx5_mr_mb2mr(&qp->mr_ctrl, mbuf);
        return klm->lkey;
 
 }
 
 static __rte_always_inline uint32_t
-mlx5_crypto_klms_set(struct mlx5_crypto_priv *priv, struct mlx5_crypto_qp *qp,
-                    struct rte_crypto_op *op, struct rte_mbuf *mbuf,
-                    struct mlx5_wqe_dseg *klm)
+mlx5_crypto_klms_set(struct mlx5_crypto_qp *qp, struct rte_crypto_op *op,
+                    struct rte_mbuf *mbuf, struct mlx5_wqe_dseg *klm)
 {
        uint32_t remain_len = op->sym->cipher.data.length;
        uint32_t nb_segs = mbuf->nb_segs;
        uint32_t klm_n = 1u;
 
        /* First mbuf needs to take the cipher offset. */
-       if (unlikely(mlx5_crypto_klm_set(priv, qp, mbuf, klm,
+       if (unlikely(mlx5_crypto_klm_set(qp, mbuf, klm,
                     op->sym->cipher.data.offset, &remain_len) == UINT32_MAX)) {
                op->status = RTE_CRYPTO_OP_STATUS_ERROR;
                return 0;
@@ -378,7 +350,7 @@ mlx5_crypto_klms_set(struct mlx5_crypto_priv *priv, struct mlx5_crypto_qp *qp,
                        op->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;
                        return 0;
                }
-               if (unlikely(mlx5_crypto_klm_set(priv, qp, mbuf, ++klm, 0,
+               if (unlikely(mlx5_crypto_klm_set(qp, mbuf, ++klm, 0,
                                                 &remain_len) == UINT32_MAX)) {
                        op->status = RTE_CRYPTO_OP_STATUS_ERROR;
                        return 0;
@@ -404,7 +376,7 @@ mlx5_crypto_wqe_set(struct mlx5_crypto_priv *priv,
        uint32_t ds;
        bool ipl = op->sym->m_dst == NULL || op->sym->m_dst == op->sym->m_src;
        /* Set UMR WQE. */
-       uint32_t klm_n = mlx5_crypto_klms_set(priv, qp, op,
+       uint32_t klm_n = mlx5_crypto_klms_set(qp, op,
                                   ipl ? op->sym->m_src : op->sym->m_dst, klms);
 
        if (unlikely(klm_n == 0))
@@ -430,8 +402,7 @@ mlx5_crypto_wqe_set(struct mlx5_crypto_priv *priv,
        cseg = RTE_PTR_ADD(cseg, priv->umr_wqe_size);
        klms = RTE_PTR_ADD(cseg, sizeof(struct mlx5_rdma_write_wqe));
        if (!ipl) {
-               klm_n = mlx5_crypto_klms_set(priv, qp, op, op->sym->m_src,
-                                            klms);
+               klm_n = mlx5_crypto_klms_set(qp, op, op->sym->m_src, klms);
                if (unlikely(klm_n == 0))
                        return 0;
        } else {
@@ -456,20 +427,6 @@ mlx5_crypto_wqe_set(struct mlx5_crypto_priv *priv,
        return 1;
 }
 
-static __rte_always_inline void
-mlx5_crypto_uar_write(uint64_t val, struct mlx5_crypto_priv *priv)
-{
-#ifdef RTE_ARCH_64
-       *priv->uar_addr = val;
-#else /* !RTE_ARCH_64 */
-       rte_spinlock_lock(&priv->uar32_sl);
-       *(volatile uint32_t *)priv->uar_addr = val;
-       rte_io_wmb();
-       *((volatile uint32_t *)priv->uar_addr + 1) = val >> 32;
-       rte_spinlock_unlock(&priv->uar32_sl);
-#endif
-}
-
 static uint16_t
 mlx5_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops,
                          uint16_t nb_ops)
@@ -505,11 +462,9 @@ mlx5_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops,
                qp->pi++;
        } while (--remain);
        qp->stats.enqueued_count += nb_ops;
-       rte_io_wmb();
-       qp->qp_obj.db_rec[MLX5_SND_DBR] = rte_cpu_to_be_32(qp->db_pi);
-       rte_wmb();
-       mlx5_crypto_uar_write(*(volatile uint64_t *)qp->wqe, qp->priv);
-       rte_wmb();
+       mlx5_doorbell_ring(&priv->uar.bf_db, *(volatile uint64_t *)qp->wqe,
+                          qp->db_pi, &qp->qp_obj.db_rec[MLX5_SND_DBR],
+                          !priv->uar.dbnc);
        return nb_ops;
 }
 
@@ -590,7 +545,7 @@ mlx5_crypto_qp_init(struct mlx5_crypto_priv *priv, struct mlx5_crypto_qp *qp)
                ucseg->if_cf_toe_cq_res = RTE_BE32(1u << MLX5_UMRC_IF_OFFSET);
                ucseg->mkey_mask = RTE_BE64(1u << 0); /* Mkey length bit. */
                ucseg->ko_to_bs = rte_cpu_to_be_32
-                       ((RTE_ALIGN(priv->max_segs_num, 4u) <<
+                       ((MLX5_CRYPTO_KLM_SEGS_NUM(priv->umr_wqe_size) <<
                         MLX5_UMRC_KO_OFFSET) | (4 << MLX5_UMRC_TO_BS_OFFSET));
                bsf->keytag = priv->keytag;
                /* Init RDMA WRITE WQE. */
@@ -614,7 +569,7 @@ mlx5_crypto_indirect_mkeys_prepare(struct mlx5_crypto_priv *priv,
                .umr_en = 1,
                .crypto_en = 1,
                .set_remote_rw = 1,
-               .klm_num = RTE_ALIGN(priv->max_segs_num, 4),
+               .klm_num = MLX5_CRYPTO_KLM_SEGS_NUM(priv->umr_wqe_size),
        };
 
        for (umr = (struct mlx5_umr_wqe *)qp->qp_obj.umem_buf, i = 0;
@@ -642,8 +597,9 @@ mlx5_crypto_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id,
        uint16_t log_nb_desc = rte_log2_u32(qp_conf->nb_descriptors);
        uint32_t ret;
        uint32_t alloc_size = sizeof(*qp);
+       uint32_t log_wqbb_n;
        struct mlx5_devx_cq_attr cq_attr = {
-               .uar_page_id = mlx5_os_get_devx_uar_page_id(priv->uar),
+               .uar_page_id = mlx5_os_get_devx_uar_page_id(priv->uar.obj),
        };
 
        if (dev->data->queue_pairs[qp_id] != NULL)
@@ -664,26 +620,29 @@ mlx5_crypto_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id,
                DRV_LOG(ERR, "Failed to create CQ.");
                goto error;
        }
+       log_wqbb_n = rte_log2_u32(RTE_BIT32(log_nb_desc) *
+                               (priv->wqe_set_size / MLX5_SEND_WQE_BB));
        attr.pd = priv->cdev->pdn;
-       attr.uar_index = mlx5_os_get_devx_uar_page_id(priv->uar);
+       attr.uar_index = mlx5_os_get_devx_uar_page_id(priv->uar.obj);
        attr.cqn = qp->cq_obj.cq->id;
-       attr.rq_size = 0;
-       attr.sq_size = RTE_BIT32(log_nb_desc);
-       attr.ts_format = mlx5_ts_format_conv(priv->qp_ts_format);
-       ret = mlx5_devx_qp_create(priv->cdev->ctx, &qp->qp_obj, log_nb_desc,
-                                 &attr, socket_id);
+       attr.num_of_receive_wqes = 0;
+       attr.num_of_send_wqbbs = RTE_BIT32(log_wqbb_n);
+       attr.ts_format =
+               mlx5_ts_format_conv(priv->cdev->config.hca_attr.qp_ts_format);
+       ret = mlx5_devx_qp_create(priv->cdev->ctx, &qp->qp_obj,
+                                       attr.num_of_send_wqbbs * MLX5_WQE_SIZE,
+                                       &attr, socket_id);
        if (ret) {
                DRV_LOG(ERR, "Failed to create QP.");
                goto error;
        }
-       if (mlx5_mr_btree_init(&qp->mr_ctrl.cache_bh, MLX5_MR_BTREE_CACHE_N,
-                              priv->dev_config.socket_id) != 0) {
+       if (mlx5_mr_ctrl_init(&qp->mr_ctrl, &priv->cdev->mr_scache.dev_gen,
+                             priv->dev_config.socket_id) != 0) {
                DRV_LOG(ERR, "Cannot allocate MR Btree for qp %u.",
                        (uint32_t)qp_id);
                rte_errno = ENOMEM;
                goto error;
        }
-       qp->mr_ctrl.dev_gen_ptr = &priv->mr_scache.dev_gen;
        /*
         * In Order to configure self loopback, when calling devx qp2rts the
         * remote QP id that is used is the id of the same QP.
@@ -753,30 +712,6 @@ static struct rte_cryptodev_ops mlx5_crypto_ops = {
        .sym_configure_raw_dp_ctx       = NULL,
 };
 
-static void
-mlx5_crypto_uar_release(struct mlx5_crypto_priv *priv)
-{
-       if (priv->uar != NULL) {
-               mlx5_glue->devx_free_uar(priv->uar);
-               priv->uar = NULL;
-       }
-}
-
-static int
-mlx5_crypto_uar_prepare(struct mlx5_crypto_priv *priv)
-{
-       priv->uar = mlx5_devx_alloc_uar(priv->cdev->ctx, -1);
-       if (priv->uar)
-               priv->uar_addr = mlx5_os_get_devx_uar_reg_addr(priv->uar);
-       if (priv->uar == NULL || priv->uar_addr == NULL) {
-               rte_errno = errno;
-               DRV_LOG(ERR, "Failed to allocate UAR.");
-               return -1;
-       }
-       return 0;
-}
-
-
 static int
 mlx5_crypto_args_check_handler(const char *key, const char *val, void *opaque)
 {
@@ -787,8 +722,6 @@ mlx5_crypto_args_check_handler(const char *key, const char *val, void *opaque)
        int ret;
        int i;
 
-       if (strcmp(key, "class") == 0)
-               return 0;
        if (strcmp(key, "wcs_file") == 0) {
                file = fopen(val, "rb");
                if (file == NULL) {
@@ -816,10 +749,8 @@ mlx5_crypto_args_check_handler(const char *key, const char *val, void *opaque)
                return -errno;
        }
        if (strcmp(key, "max_segs_num") == 0) {
-               if (!tmp || tmp > MLX5_CRYPTO_MAX_SEGS) {
-                       DRV_LOG(WARNING, "Invalid max_segs_num: %d, should"
-                               " be less than %d.",
-                               (uint32_t)tmp, MLX5_CRYPTO_MAX_SEGS);
+               if (!tmp) {
+                       DRV_LOG(ERR, "max_segs_num must be greater than 0.");
                        rte_errno = EINVAL;
                        return -rte_errno;
                }
@@ -830,97 +761,133 @@ mlx5_crypto_args_check_handler(const char *key, const char *val, void *opaque)
                attr->credential_pointer = (uint32_t)tmp;
        } else if (strcmp(key, "keytag") == 0) {
                devarg_prms->keytag = tmp;
-       } else {
-               DRV_LOG(WARNING, "Invalid key %s.", key);
        }
        return 0;
 }
 
 static int
-mlx5_crypto_parse_devargs(struct rte_devargs *devargs,
+mlx5_crypto_parse_devargs(struct mlx5_kvargs_ctrl *mkvlist,
                          struct mlx5_crypto_devarg_params *devarg_prms)
 {
        struct mlx5_devx_crypto_login_attr *attr = &devarg_prms->login_attr;
-       struct rte_kvargs *kvlist;
+       const char **params = (const char *[]){
+               "credential_id",
+               "import_kek_id",
+               "keytag",
+               "max_segs_num",
+               "wcs_file",
+               NULL,
+       };
 
        /* Default values. */
        attr->credential_pointer = 0;
        attr->session_import_kek_ptr = 0;
        devarg_prms->keytag = 0;
        devarg_prms->max_segs_num = 8;
-       if (devargs == NULL) {
+       if (mkvlist == NULL) {
                DRV_LOG(ERR,
-       "No login devargs in order to enable crypto operations in the device.");
+                       "No login devargs in order to enable crypto operations in the device.");
                rte_errno = EINVAL;
                return -1;
        }
-       kvlist = rte_kvargs_parse(devargs->args, NULL);
-       if (kvlist == NULL) {
-               DRV_LOG(ERR, "Failed to parse devargs.");
-               rte_errno = EINVAL;
-               return -1;
-       }
-       if (rte_kvargs_process(kvlist, NULL, mlx5_crypto_args_check_handler,
-                          devarg_prms) != 0) {
+       if (mlx5_kvargs_process(mkvlist, params, mlx5_crypto_args_check_handler,
+                               devarg_prms) != 0) {
                DRV_LOG(ERR, "Devargs handler function Failed.");
-               rte_kvargs_free(kvlist);
                rte_errno = EINVAL;
                return -1;
        }
-       rte_kvargs_free(kvlist);
        if (devarg_prms->login_devarg == false) {
                DRV_LOG(ERR,
-       "No login credential devarg in order to enable crypto operations "
-       "in the device.");
+                       "No login credential devarg in order to enable crypto operations in the device.");
                rte_errno = EINVAL;
                return -1;
        }
        return 0;
 }
 
-/**
- * Callback for memory event.
- *
- * @param event_type
- *   Memory event type.
- * @param addr
- *   Address of memory.
- * @param len
- *   Size of memory.
+/*
+ * Calculate UMR WQE size and RDMA Write WQE size with the
+ * following limitations:
+ *     - Each WQE size is multiple of 64.
+ *     - The summarize of both UMR WQE and RDMA_W WQE is a power of 2.
+ *     - The number of entries in the UMR WQE's KLM list is multiple of 4.
  */
 static void
-mlx5_crypto_mr_mem_event_cb(enum rte_mem_event event_type, const void *addr,
-                           size_t len, void *arg __rte_unused)
+mlx5_crypto_get_wqe_sizes(uint32_t segs_num, uint32_t *umr_size,
+                       uint32_t *rdmaw_size)
 {
-       struct mlx5_crypto_priv *priv;
+       uint32_t diff, wqe_set_size;
+
+       *umr_size = MLX5_CRYPTO_UMR_WQE_STATIC_SIZE +
+                       RTE_ALIGN(segs_num, 4) *
+                       sizeof(struct mlx5_wqe_dseg);
+       /* Make sure UMR WQE size is multiple of WQBB. */
+       *umr_size = RTE_ALIGN(*umr_size, MLX5_SEND_WQE_BB);
+       *rdmaw_size = sizeof(struct mlx5_rdma_write_wqe) +
+                       sizeof(struct mlx5_wqe_dseg) *
+                       (segs_num <= 2 ? 2 : 2 +
+                       RTE_ALIGN(segs_num - 2, 4));
+       /* Make sure RDMA_WRITE WQE size is multiple of WQBB. */
+       *rdmaw_size = RTE_ALIGN(*rdmaw_size, MLX5_SEND_WQE_BB);
+       wqe_set_size = *rdmaw_size + *umr_size;
+       diff = rte_align32pow2(wqe_set_size) - wqe_set_size;
+       /* Make sure wqe_set size is power of 2. */
+       if (diff)
+               *umr_size += diff;
+}
 
-       /* Must be called from the primary process. */
-       MLX5_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);
-       switch (event_type) {
-       case RTE_MEM_EVENT_FREE:
-               pthread_mutex_lock(&priv_list_lock);
-               /* Iterate all the existing mlx5 devices. */
-               TAILQ_FOREACH(priv, &mlx5_crypto_priv_list, next)
-                       mlx5_free_mr_by_addr(&priv->mr_scache,
-                                            mlx5_os_get_ctx_device_name
-                                                             (priv->cdev->ctx),
-                                            addr, len);
-               pthread_mutex_unlock(&priv_list_lock);
-               break;
-       case RTE_MEM_EVENT_ALLOC:
-       default:
-               break;
+static uint8_t
+mlx5_crypto_max_segs_num(uint16_t max_wqe_size)
+{
+       int klms_sizes = max_wqe_size - MLX5_CRYPTO_UMR_WQE_STATIC_SIZE;
+       uint32_t max_segs_cap = RTE_ALIGN_FLOOR(klms_sizes, MLX5_SEND_WQE_BB) /
+                       sizeof(struct mlx5_wqe_dseg);
+
+       MLX5_ASSERT(klms_sizes >= MLX5_SEND_WQE_BB);
+       while (max_segs_cap) {
+               uint32_t umr_wqe_size, rdmw_wqe_size;
+
+               mlx5_crypto_get_wqe_sizes(max_segs_cap, &umr_wqe_size,
+                                               &rdmw_wqe_size);
+               if (umr_wqe_size <= max_wqe_size &&
+                               rdmw_wqe_size <= max_wqe_size)
+                       break;
+               max_segs_cap -= 4;
+       }
+       return max_segs_cap;
+}
+
+static int
+mlx5_crypto_configure_wqe_size(struct mlx5_crypto_priv *priv,
+                               uint16_t max_wqe_size, uint32_t max_segs_num)
+{
+       uint32_t rdmw_wqe_size, umr_wqe_size;
+
+       mlx5_crypto_get_wqe_sizes(max_segs_num, &umr_wqe_size,
+                                       &rdmw_wqe_size);
+       priv->wqe_set_size = rdmw_wqe_size + umr_wqe_size;
+       if (umr_wqe_size > max_wqe_size ||
+                               rdmw_wqe_size > max_wqe_size) {
+               DRV_LOG(ERR, "Invalid max_segs_num: %u. should be %u or lower.",
+                       max_segs_num,
+                       mlx5_crypto_max_segs_num(max_wqe_size));
+               rte_errno = EINVAL;
+               return -EINVAL;
        }
+       priv->umr_wqe_size = (uint16_t)umr_wqe_size;
+       priv->umr_wqe_stride = priv->umr_wqe_size / MLX5_SEND_WQE_BB;
+       priv->max_rdmar_ds = rdmw_wqe_size / sizeof(struct mlx5_wqe_dseg);
+       return 0;
 }
 
 static int
-mlx5_crypto_dev_probe(struct mlx5_common_device *cdev)
+mlx5_crypto_dev_probe(struct mlx5_common_device *cdev,
+                     struct mlx5_kvargs_ctrl *mkvlist)
 {
        struct rte_cryptodev *crypto_dev;
        struct mlx5_devx_obj *login;
        struct mlx5_crypto_priv *priv;
        struct mlx5_crypto_devarg_params devarg_prms = { 0 };
-       struct mlx5_hca_attr attr = { 0 };
        struct rte_cryptodev_pmd_init_params init_params = {
                .name = "",
                .private_data_size = sizeof(struct mlx5_crypto_priv),
@@ -929,7 +896,6 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *cdev)
                                RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS,
        };
        const char *ibdev_name = mlx5_os_get_ctx_device_name(cdev->ctx);
-       uint16_t rdmw_wqe_size;
        int ret;
 
        if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
@@ -937,24 +903,17 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *cdev)
                rte_errno = ENOTSUP;
                return -rte_errno;
        }
-       if (mlx5_devx_cmd_query_hca_attr(cdev->ctx, &attr) != 0 ||
-           attr.crypto == 0 || attr.aes_xts == 0) {
+       if (!cdev->config.hca_attr.crypto || !cdev->config.hca_attr.aes_xts) {
                DRV_LOG(ERR, "Not enough capabilities to support crypto "
                        "operations, maybe old FW/OFED version?");
                rte_errno = ENOTSUP;
                return -ENOTSUP;
        }
-       ret = mlx5_crypto_parse_devargs(cdev->dev->devargs, &devarg_prms);
+       ret = mlx5_crypto_parse_devargs(mkvlist, &devarg_prms);
        if (ret) {
                DRV_LOG(ERR, "Failed to parse devargs.");
                return -rte_errno;
        }
-       login = mlx5_devx_cmd_create_crypto_login_obj(cdev->ctx,
-                                                     &devarg_prms.login_attr);
-       if (login == NULL) {
-               DRV_LOG(ERR, "Failed to configure login.");
-               return -rte_errno;
-       }
        crypto_dev = rte_cryptodev_pmd_create(ibdev_name, cdev->dev,
                                              &init_params);
        if (crypto_dev == NULL) {
@@ -970,44 +929,38 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *cdev)
        crypto_dev->driver_id = mlx5_crypto_driver_id;
        priv = crypto_dev->data->dev_private;
        priv->cdev = cdev;
-       priv->login_obj = login;
        priv->crypto_dev = crypto_dev;
-       priv->qp_ts_format = attr.qp_ts_format;
-       if (mlx5_crypto_uar_prepare(priv) != 0) {
+       if (mlx5_devx_uar_prepare(cdev, &priv->uar) != 0) {
                rte_cryptodev_pmd_destroy(priv->crypto_dev);
                return -1;
        }
-       if (mlx5_mr_btree_init(&priv->mr_scache.cache,
-                            MLX5_MR_BTREE_CACHE_N * 2, rte_socket_id()) != 0) {
-               DRV_LOG(ERR, "Failed to allocate shared cache MR memory.");
-               mlx5_crypto_uar_release(priv);
+       login = mlx5_devx_cmd_create_crypto_login_obj(cdev->ctx,
+                                                     &devarg_prms.login_attr);
+       if (login == NULL) {
+               DRV_LOG(ERR, "Failed to configure login.");
+               mlx5_devx_uar_release(&priv->uar);
                rte_cryptodev_pmd_destroy(priv->crypto_dev);
-               rte_errno = ENOMEM;
                return -rte_errno;
        }
-       priv->mr_scache.reg_mr_cb = mlx5_common_verbs_reg_mr;
-       priv->mr_scache.dereg_mr_cb = mlx5_common_verbs_dereg_mr;
+       priv->login_obj = login;
        priv->keytag = rte_cpu_to_be_64(devarg_prms.keytag);
-       priv->max_segs_num = devarg_prms.max_segs_num;
-       priv->umr_wqe_size = sizeof(struct mlx5_wqe_umr_bsf_seg) +
-                            sizeof(struct mlx5_umr_wqe) +
-                            RTE_ALIGN(priv->max_segs_num, 4) *
-                            sizeof(struct mlx5_wqe_dseg);
-       rdmw_wqe_size = sizeof(struct mlx5_rdma_write_wqe) +
-                             sizeof(struct mlx5_wqe_dseg) *
-                             (priv->max_segs_num <= 2 ? 2 : 2 +
-                              RTE_ALIGN(priv->max_segs_num - 2, 4));
-       priv->wqe_set_size = priv->umr_wqe_size + rdmw_wqe_size;
-       priv->umr_wqe_stride = priv->umr_wqe_size / MLX5_SEND_WQE_BB;
-       priv->max_rdmar_ds = rdmw_wqe_size / sizeof(struct mlx5_wqe_dseg);
-       /* Register callback function for global shared MR cache management. */
-       if (TAILQ_EMPTY(&mlx5_crypto_priv_list))
-               rte_mem_event_callback_register("MLX5_MEM_EVENT_CB",
-                                               mlx5_crypto_mr_mem_event_cb,
-                                               NULL);
+       ret = mlx5_crypto_configure_wqe_size(priv,
+               cdev->config.hca_attr.max_wqe_sz_sq, devarg_prms.max_segs_num);
+       if (ret) {
+               mlx5_devx_uar_release(&priv->uar);
+               rte_cryptodev_pmd_destroy(priv->crypto_dev);
+               return -1;
+       }
+       DRV_LOG(INFO, "Max number of segments: %u.",
+               (unsigned int)RTE_MIN(
+                       MLX5_CRYPTO_KLM_SEGS_NUM(priv->umr_wqe_size),
+                       (uint16_t)(priv->max_rdmar_ds - 2)));
        pthread_mutex_lock(&priv_list_lock);
        TAILQ_INSERT_TAIL(&mlx5_crypto_priv_list, priv, next);
        pthread_mutex_unlock(&priv_list_lock);
+
+       rte_cryptodev_pmd_probing_finish(crypto_dev);
+
        return 0;
 }
 
@@ -1024,13 +977,9 @@ mlx5_crypto_dev_remove(struct mlx5_common_device *cdev)
                TAILQ_REMOVE(&mlx5_crypto_priv_list, priv, next);
        pthread_mutex_unlock(&priv_list_lock);
        if (priv) {
-               if (TAILQ_EMPTY(&mlx5_crypto_priv_list))
-                       rte_mem_event_callback_unregister("MLX5_MEM_EVENT_CB",
-                                                         NULL);
-               mlx5_mr_release_cache(&priv->mr_scache);
-               mlx5_crypto_uar_release(priv);
-               rte_cryptodev_pmd_destroy(priv->crypto_dev);
                claim_zero(mlx5_devx_cmd_destroy(priv->login_obj));
+               mlx5_devx_uar_release(&priv->uar);
+               rte_cryptodev_pmd_destroy(priv->crypto_dev);
        }
        return 0;
 }
@@ -1040,6 +989,14 @@ static const struct rte_pci_id mlx5_crypto_pci_id_map[] = {
                        RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
                                        PCI_DEVICE_ID_MELLANOX_CONNECTX6)
                },
+               {
+                       RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+                                       PCI_DEVICE_ID_MELLANOX_CONNECTX6DX)
+               },
+               {
+                       RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+                                       PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
+               },
                {
                        .vendor_id = 0
                }
@@ -1055,6 +1012,7 @@ static struct mlx5_class_driver mlx5_crypto_driver = {
 
 RTE_INIT(rte_mlx5_crypto_init)
 {
+       pthread_mutex_init(&priv_list_lock, NULL);
        mlx5_common_init();
        if (mlx5_glue != NULL)
                mlx5_class_driver_register(&mlx5_crypto_driver);