net/af_packet: prefer snprintf against strncpy
[dpdk.git] / drivers / crypto / scheduler / scheduler_pmd.c
index b189fbd..0b63c20 100644 (file)
 struct scheduler_init_params {
        struct rte_crypto_vdev_init_params def_p;
        uint32_t nb_slaves;
-       uint8_t slaves[RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES];
        enum rte_cryptodev_scheduler_mode mode;
        uint32_t enable_ordering;
+       char slave_names[RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES]
+                       [RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN];
 };
 
 #define RTE_CRYPTODEV_VDEV_NAME                        ("name")
@@ -86,55 +87,21 @@ const struct scheduler_parse_map scheduler_ordering_map[] = {
                {"disable", 0}
 };
 
-static int
-attach_init_slaves(uint8_t scheduler_id,
-               const uint8_t *slaves, const uint8_t nb_slaves)
-{
-       uint8_t i;
-
-       for (i = 0; i < nb_slaves; i++) {
-               struct rte_cryptodev *dev =
-                               rte_cryptodev_pmd_get_dev(slaves[i]);
-               int status = rte_cryptodev_scheduler_slave_attach(
-                               scheduler_id, slaves[i]);
-
-               if (status < 0 || !dev) {
-                       CS_LOG_ERR("Failed to attach slave cryptodev "
-                                       "%u.\n", slaves[i]);
-                       return status;
-               }
-
-               RTE_LOG(INFO, PMD, "  Attached Slave %s\n", dev->data->name);
-       }
-
-       return 0;
-}
-
 static int
 cryptodev_scheduler_create(const char *name,
        struct scheduler_init_params *init_params)
 {
-       char crypto_dev_name[RTE_CRYPTODEV_NAME_MAX_LEN] = {0};
        struct rte_cryptodev *dev;
        struct scheduler_ctx *sched_ctx;
        uint32_t i;
        int ret;
 
-       if (init_params->def_p.name[0] == '\0') {
-               ret = rte_cryptodev_pmd_create_dev_name(
-                               crypto_dev_name,
-                               RTE_STR(CRYPTODEV_NAME_SCHEDULER_PMD));
+       if (init_params->def_p.name[0] == '\0')
+               snprintf(init_params->def_p.name,
+                               sizeof(init_params->def_p.name),
+                               "%s", name);
 
-               if (ret < 0) {
-                       CS_LOG_ERR("failed to create unique name");
-                       return ret;
-               }
-       } else {
-               strncpy(crypto_dev_name, init_params->def_p.name,
-                               RTE_CRYPTODEV_NAME_MAX_LEN - 1);
-       }
-
-       dev = rte_cryptodev_pmd_virtual_dev_init(crypto_dev_name,
+       dev = rte_cryptodev_pmd_virtual_dev_init(init_params->def_p.name,
                        sizeof(struct scheduler_ctx),
                        init_params->def_p.socket_id);
        if (dev == NULL) {
@@ -150,13 +117,6 @@ cryptodev_scheduler_create(const char *name,
        sched_ctx->max_nb_queue_pairs =
                        init_params->def_p.max_nb_queue_pairs;
 
-       ret = attach_init_slaves(dev->data->dev_id, init_params->slaves,
-                       init_params->nb_slaves);
-       if (ret < 0) {
-               rte_cryptodev_pmd_release_device(dev);
-               return ret;
-       }
-
        if (init_params->mode > CDEV_SCHED_MODE_USERDEFINED &&
                        init_params->mode < CDEV_SCHED_MODE_COUNT) {
                ret = rte_cryptodev_scheduler_mode_set(dev->data->dev_id,
@@ -189,18 +149,56 @@ cryptodev_scheduler_create(const char *name,
                break;
        }
 
+       for (i = 0; i < init_params->nb_slaves; i++) {
+               sched_ctx->init_slave_names[sched_ctx->nb_init_slaves] =
+                       rte_zmalloc_socket(
+                               NULL,
+                               RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN, 0,
+                               SOCKET_ID_ANY);
+
+               if (!sched_ctx->init_slave_names[
+                               sched_ctx->nb_init_slaves]) {
+                       CS_LOG_ERR("driver %s: Insufficient memory",
+                                       name);
+                       return -ENOMEM;
+               }
+
+               strncpy(sched_ctx->init_slave_names[
+                                       sched_ctx->nb_init_slaves],
+                               init_params->slave_names[i],
+                               RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN - 1);
+
+               sched_ctx->nb_init_slaves++;
+       }
+
+       /*
+        * Initialize capabilities structure as an empty structure,
+        * in case device information is requested when no slaves are attached
+        */
+       sched_ctx->capabilities = rte_zmalloc_socket(NULL,
+                       sizeof(struct rte_cryptodev_capabilities),
+                       0, SOCKET_ID_ANY);
+
+       if (!sched_ctx->capabilities) {
+               RTE_LOG(ERR, PMD, "Not enough memory for capability "
+                               "information\n");
+               return -ENOMEM;
+       }
+
        return 0;
 }
 
 static int
-cryptodev_scheduler_remove(const char *name)
+cryptodev_scheduler_remove(struct rte_vdev_device *vdev)
 {
+       const char *name;
        struct rte_cryptodev *dev;
        struct scheduler_ctx *sched_ctx;
 
-       if (name == NULL)
+       if (vdev == NULL)
                return -EINVAL;
 
+       name = rte_vdev_device_name(vdev);
        dev = rte_cryptodev_pmd_get_named_dev(name);
        if (dev == NULL)
                return -EINVAL;
@@ -278,21 +276,14 @@ parse_slave_arg(const char *key __rte_unused,
                const char *value, void *extra_args)
 {
        struct scheduler_init_params *param = extra_args;
-       struct rte_cryptodev *dev =
-                       rte_cryptodev_pmd_get_named_dev(value);
-
-       if (!dev) {
-               RTE_LOG(ERR, PMD, "Invalid slave name %s.\n", value);
-               return -EINVAL;
-       }
 
        if (param->nb_slaves >= RTE_CRYPTODEV_SCHEDULER_MAX_NB_SLAVES - 1) {
                CS_LOG_ERR("Too many slaves.\n");
                return -ENOMEM;
        }
 
-       param->slaves[param->nb_slaves] = dev->data->dev_id;
-       param->nb_slaves++;
+       strncpy(param->slave_names[param->nb_slaves++], value,
+                       RTE_CRYPTODEV_SCHEDULER_NAME_MAX_LEN - 1);
 
        return 0;
 }
@@ -413,7 +404,7 @@ free_kvlist:
 }
 
 static int
-cryptodev_scheduler_probe(const char *name, const char *input_args)
+cryptodev_scheduler_probe(struct rte_vdev_device *vdev)
 {
        struct scheduler_init_params init_params = {
                .def_p = {
@@ -423,14 +414,21 @@ cryptodev_scheduler_probe(const char *name, const char *input_args)
                        ""
                },
                .nb_slaves = 0,
-               .slaves = {0},
                .mode = CDEV_SCHED_MODE_NOT_SET,
-               .enable_ordering = 0
+               .enable_ordering = 0,
+               .slave_names = { {0} }
        };
+       const char *name;
+
+       name = rte_vdev_device_name(vdev);
+       if (name == NULL)
+               return -EINVAL;
 
-       scheduler_parse_init_params(&init_params, input_args);
+       scheduler_parse_init_params(&init_params,
+                                   rte_vdev_device_args(vdev));
 
-       RTE_LOG(INFO, PMD, "Initialising %s on NUMA node %d\n", name,
+       RTE_LOG(INFO, PMD, "Initialising %s on NUMA node %d\n",
+                       name,
                        init_params.def_p.socket_id);
        RTE_LOG(INFO, PMD, "  Max number of queue pairs = %d\n",
                        init_params.def_p.max_nb_queue_pairs);
@@ -440,7 +438,8 @@ cryptodev_scheduler_probe(const char *name, const char *input_args)
                RTE_LOG(INFO, PMD, "  User defined name = %s\n",
                        init_params.def_p.name);
 
-       return cryptodev_scheduler_create(name, &init_params);
+       return cryptodev_scheduler_create(name,
+                                       &init_params);
 }
 
 static struct rte_vdev_driver cryptodev_scheduler_pmd_drv = {