net/octeontx: handle port reconfiguration
[dpdk.git] / drivers / net / ark / ark_ethdev.c
index 4f52e2b..e8e4092 100644 (file)
@@ -7,7 +7,7 @@
 #include <dlfcn.h>
 
 #include <rte_bus_pci.h>
-#include <rte_ethdev_pci.h>
+#include <ethdev_pci.h>
 #include <rte_kvargs.h>
 
 #include "ark_global.h"
@@ -29,21 +29,21 @@ static int ark_config_device(struct rte_eth_dev *dev);
 static int eth_ark_dev_uninit(struct rte_eth_dev *eth_dev);
 static int eth_ark_dev_configure(struct rte_eth_dev *dev);
 static int eth_ark_dev_start(struct rte_eth_dev *dev);
-static void eth_ark_dev_stop(struct rte_eth_dev *dev);
-static void eth_ark_dev_close(struct rte_eth_dev *dev);
-static void eth_ark_dev_info_get(struct rte_eth_dev *dev,
-                                struct rte_eth_dev_info *dev_info);
+static int eth_ark_dev_stop(struct rte_eth_dev *dev);
+static int eth_ark_dev_close(struct rte_eth_dev *dev);
+static int eth_ark_dev_info_get(struct rte_eth_dev *dev,
+                               struct rte_eth_dev_info *dev_info);
 static int eth_ark_dev_link_update(struct rte_eth_dev *dev,
                                   int wait_to_complete);
 static int eth_ark_dev_set_link_up(struct rte_eth_dev *dev);
 static int eth_ark_dev_set_link_down(struct rte_eth_dev *dev);
 static int eth_ark_dev_stats_get(struct rte_eth_dev *dev,
                                  struct rte_eth_stats *stats);
-static void eth_ark_dev_stats_reset(struct rte_eth_dev *dev);
+static int eth_ark_dev_stats_reset(struct rte_eth_dev *dev);
 static int eth_ark_set_default_mac_addr(struct rte_eth_dev *dev,
-                                        struct ether_addr *mac_addr);
+                                        struct rte_ether_addr *mac_addr);
 static int eth_ark_macaddr_add(struct rte_eth_dev *dev,
-                              struct ether_addr *mac_addr,
+                              struct rte_ether_addr *mac_addr,
                               uint32_t index,
                               uint32_t pool);
 static void eth_ark_macaddr_remove(struct rte_eth_dev *dev,
@@ -85,12 +85,60 @@ static const char * const valid_arguments[] = {
        NULL
 };
 
+#define AR_VENDOR_ID 0x1d6c
 static const struct rte_pci_id pci_id_ark_map[] = {
-       {RTE_PCI_DEVICE(0x1d6c, 0x100d)},
-       {RTE_PCI_DEVICE(0x1d6c, 0x100e)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100d)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100e)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x100f)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1010)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1017)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1018)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1019)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101a)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101b)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
+       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
        {.vendor_id = 0, /* sentinel */ },
 };
 
+/*
+ * This structure is used to statically define the capabilities
+ * of supported devices.
+ * Capabilities:
+ *  rqpacing -
+ * Some HW variants require that PCIe read-requests be correctly throttled.
+ * This is called "rqpacing" and has to do with credit and flow control
+ * on certain Arkville implementations.
+ */
+struct ark_caps {
+       bool rqpacing;
+       bool isvf;
+};
+struct ark_dev_caps {
+       uint32_t  device_id;
+       struct ark_caps  caps;
+};
+#define SET_DEV_CAPS(id, rqp, vf)                      \
+       {id, {.rqpacing = rqp, .isvf = vf} }
+
+static const struct ark_dev_caps
+ark_device_caps[] = {
+                    SET_DEV_CAPS(0x100d, true, false),
+                    SET_DEV_CAPS(0x100e, true, false),
+                    SET_DEV_CAPS(0x100f, true, false),
+                    SET_DEV_CAPS(0x1010, false, false),
+                    SET_DEV_CAPS(0x1017, true, false),
+                    SET_DEV_CAPS(0x1018, true, false),
+                    SET_DEV_CAPS(0x1019, true, false),
+                    SET_DEV_CAPS(0x101a, true, false),
+                    SET_DEV_CAPS(0x101b, true, false),
+                    SET_DEV_CAPS(0x101c, true, true),
+                    SET_DEV_CAPS(0x101e, false, false),
+                    SET_DEV_CAPS(0x101f, false, false),
+                    {.device_id = 0,}
+};
+
 static int
 eth_ark_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
                struct rte_pci_device *pci_dev)
@@ -105,7 +153,7 @@ eth_ark_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 
        ret = eth_ark_dev_init(eth_dev);
        if (ret)
-               rte_eth_dev_pci_release(eth_dev);
+               rte_eth_dev_release_port(eth_dev);
 
        return ret;
 }
@@ -132,7 +180,6 @@ static const struct eth_dev_ops ark_eth_dev_ops = {
        .dev_infos_get = eth_ark_dev_info_get,
 
        .rx_queue_setup = eth_ark_dev_rx_queue_setup,
-       .rx_queue_count = eth_ark_dev_rx_queue_count,
        .tx_queue_setup = eth_ark_tx_queue_setup,
 
        .link_update = eth_ark_dev_link_update,
@@ -164,76 +211,82 @@ check_for_ext(struct ark_adapter *ark)
        const char *dllpath = getenv("ARK_EXT_PATH");
 
        if (dllpath == NULL) {
-               PMD_DEBUG_LOG(DEBUG, "ARK EXT NO dll path specified\n");
+               ARK_PMD_LOG(DEBUG, "EXT NO dll path specified\n");
                return 0;
        }
-       PMD_DRV_LOG(INFO, "ARK EXT found dll path at %s\n", dllpath);
+       ARK_PMD_LOG(NOTICE, "EXT found dll path at %s\n", dllpath);
 
        /* Open and load the .so */
        ark->d_handle = dlopen(dllpath, RTLD_LOCAL | RTLD_LAZY);
        if (ark->d_handle == NULL) {
-               PMD_DRV_LOG(ERR, "Could not load user extension %s\n",
+               ARK_PMD_LOG(ERR, "Could not load user extension %s\n",
                            dllpath);
                return -1;
        }
-       PMD_DRV_LOG(INFO, "SUCCESS: loaded user extension %s\n",
+       ARK_PMD_LOG(DEBUG, "SUCCESS: loaded user extension %s\n",
                            dllpath);
 
        /* Get the entry points */
        ark->user_ext.dev_init =
                (void *(*)(struct rte_eth_dev *, void *, int))
-               dlsym(ark->d_handle, "dev_init");
-       PMD_DEBUG_LOG(DEBUG, "device ext init pointer = %p\n",
+               dlsym(ark->d_handle, "rte_pmd_ark_dev_init");
+       ARK_PMD_LOG(DEBUG, "device ext init pointer = %p\n",
                      ark->user_ext.dev_init);
        ark->user_ext.dev_get_port_count =
                (int (*)(struct rte_eth_dev *, void *))
-               dlsym(ark->d_handle, "dev_get_port_count");
+               dlsym(ark->d_handle, "rte_pmd_ark_dev_get_port_count");
        ark->user_ext.dev_uninit =
                (void (*)(struct rte_eth_dev *, void *))
-               dlsym(ark->d_handle, "dev_uninit");
+               dlsym(ark->d_handle, "rte_pmd_ark_dev_uninit");
        ark->user_ext.dev_configure =
                (int (*)(struct rte_eth_dev *, void *))
-               dlsym(ark->d_handle, "dev_configure");
+               dlsym(ark->d_handle, "rte_pmd_ark_dev_configure");
        ark->user_ext.dev_start =
                (int (*)(struct rte_eth_dev *, void *))
-               dlsym(ark->d_handle, "dev_start");
+               dlsym(ark->d_handle, "rte_pmd_ark_dev_start");
        ark->user_ext.dev_stop =
                (void (*)(struct rte_eth_dev *, void *))
-               dlsym(ark->d_handle, "dev_stop");
+               dlsym(ark->d_handle, "rte_pmd_ark_dev_stop");
        ark->user_ext.dev_close =
                (void (*)(struct rte_eth_dev *, void *))
-               dlsym(ark->d_handle, "dev_close");
+               dlsym(ark->d_handle, "rte_pmd_ark_dev_close");
        ark->user_ext.link_update =
                (int (*)(struct rte_eth_dev *, int, void *))
-               dlsym(ark->d_handle, "link_update");
+               dlsym(ark->d_handle, "rte_pmd_ark_link_update");
        ark->user_ext.dev_set_link_up =
                (int (*)(struct rte_eth_dev *, void *))
-               dlsym(ark->d_handle, "dev_set_link_up");
+               dlsym(ark->d_handle, "rte_pmd_ark_dev_set_link_up");
        ark->user_ext.dev_set_link_down =
                (int (*)(struct rte_eth_dev *, void *))
-               dlsym(ark->d_handle, "dev_set_link_down");
+               dlsym(ark->d_handle, "rte_pmd_ark_dev_set_link_down");
        ark->user_ext.stats_get =
                (int (*)(struct rte_eth_dev *, struct rte_eth_stats *,
                          void *))
-               dlsym(ark->d_handle, "stats_get");
+               dlsym(ark->d_handle, "rte_pmd_ark_stats_get");
        ark->user_ext.stats_reset =
                (void (*)(struct rte_eth_dev *, void *))
-               dlsym(ark->d_handle, "stats_reset");
+               dlsym(ark->d_handle, "rte_pmd_ark_stats_reset");
        ark->user_ext.mac_addr_add =
-               (void (*)(struct rte_eth_dev *, struct ether_addr *, uint32_t,
-                         uint32_t, void *))
-               dlsym(ark->d_handle, "mac_addr_add");
+               (void (*)(struct rte_eth_dev *, struct rte_ether_addr *,
+                       uint32_t, uint32_t, void *))
+               dlsym(ark->d_handle, "rte_pmd_ark_mac_addr_add");
        ark->user_ext.mac_addr_remove =
                (void (*)(struct rte_eth_dev *, uint32_t, void *))
-               dlsym(ark->d_handle, "mac_addr_remove");
+               dlsym(ark->d_handle, "rte_pmd_ark_mac_addr_remove");
        ark->user_ext.mac_addr_set =
-               (void (*)(struct rte_eth_dev *, struct ether_addr *,
+               (void (*)(struct rte_eth_dev *, struct rte_ether_addr *,
                          void *))
-               dlsym(ark->d_handle, "mac_addr_set");
+               dlsym(ark->d_handle, "rte_pmd_ark_mac_addr_set");
        ark->user_ext.set_mtu =
                (int (*)(struct rte_eth_dev *, uint16_t,
                          void *))
-               dlsym(ark->d_handle, "set_mtu");
+               dlsym(ark->d_handle, "rte_pmd_ark_set_mtu");
+       ark->user_ext.rx_user_meta_hook =
+               (rx_user_meta_hook_fn)dlsym(ark->d_handle,
+                                           "rte_pmd_ark_rx_user_meta_hook");
+       ark->user_ext.tx_user_meta_hook =
+               (tx_user_meta_hook_fn)dlsym(ark->d_handle,
+                                           "rte_pmd_ark_tx_user_meta_hook");
 
        return found;
 }
@@ -241,27 +294,39 @@ check_for_ext(struct ark_adapter *ark)
 static int
 eth_ark_dev_init(struct rte_eth_dev *dev)
 {
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
        struct rte_pci_device *pci_dev;
        int ret;
        int port_count = 1;
        int p;
+       bool rqpacing = false;
 
        ark->eth_dev = dev;
 
-       PMD_FUNC_LOG(DEBUG, "\n");
+       ARK_PMD_LOG(DEBUG, "\n");
 
        /* Check to see if there is an extension that we need to load */
        ret = check_for_ext(ark);
        if (ret)
                return ret;
+
        pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        rte_eth_copy_pci_info(dev, pci_dev);
+       dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
+
+       p = 0;
+       while (ark_device_caps[p].device_id != 0) {
+               if (pci_dev->id.device_id == ark_device_caps[p].device_id) {
+                       rqpacing = ark_device_caps[p].caps.rqpacing;
+                       ark->isvf = ark_device_caps[p].caps.isvf;
+                       break;
+               }
+               p++;
+       }
 
        /* Use dummy function until setup */
-       dev->rx_pkt_burst = &eth_ark_recv_pkts_noop;
-       dev->tx_pkt_burst = &eth_ark_xmit_pkts_noop;
+       dev->rx_pkt_burst = rte_eth_pkt_burst_dummy;
+       dev->tx_pkt_burst = rte_eth_pkt_burst_dummy;
 
        ark->bar0 = (uint8_t *)pci_dev->mem_resource[0].addr;
        ark->a_bar = (uint8_t *)pci_dev->mem_resource[2].addr;
@@ -277,19 +342,24 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
        ark->pktgen.v  = (void *)&ark->bar0[ARK_PKTGEN_BASE];
        ark->pktchkr.v  = (void *)&ark->bar0[ARK_PKTCHKR_BASE];
 
-       ark->rqpacing =
-               (struct ark_rqpace_t *)(ark->bar0 + ARK_RCPACING_BASE);
+       if (rqpacing) {
+               ark->rqpacing =
+                       (struct ark_rqpace_t *)(ark->bar0 + ARK_RCPACING_BASE);
+       } else {
+               ark->rqpacing = NULL;
+       }
        ark->started = 0;
+       ark->pkt_dir_v = ARK_PKT_DIR_INIT_VAL;
 
-       PMD_DEBUG_LOG(INFO, "Sys Ctrl Const = 0x%x  HW Commit_ID: %08x\n",
+       ARK_PMD_LOG(INFO, "Sys Ctrl Const = 0x%x  HW Commit_ID: %08x\n",
                      ark->sysctrl.t32[4],
                      rte_be_to_cpu_32(ark->sysctrl.t32[0x20 / 4]));
-       PMD_DRV_LOG(INFO, "Arkville HW Commit_ID: %08x\n",
+       ARK_PMD_LOG(NOTICE, "Arkville HW Commit_ID: %08x\n",
                    rte_be_to_cpu_32(ark->sysctrl.t32[0x20 / 4]));
 
        /* If HW sanity test fails, return an error */
        if (ark->sysctrl.t32[4] != 0xcafef00d) {
-               PMD_DRV_LOG(ERR,
+               ARK_PMD_LOG(ERR,
                            "HW Sanity test has failed, expected constant"
                            " 0x%x, read 0x%x (%s)\n",
                            0xcafef00d,
@@ -297,16 +367,18 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
                return -1;
        }
        if (ark->sysctrl.t32[3] != 0) {
-               if (ark_rqp_lasped(ark->rqpacing)) {
-                       PMD_DRV_LOG(ERR, "Arkville Evaluation System - "
-                                   "Timer has Expired\n");
-                       return -1;
+               if (ark->rqpacing) {
+                       if (ark_rqp_lasped(ark->rqpacing)) {
+                               ARK_PMD_LOG(ERR, "Arkville Evaluation System - "
+                                           "Timer has Expired\n");
+                               return -1;
+                       }
+                       ARK_PMD_LOG(WARNING, "Arkville Evaluation System - "
+                                   "Timer is Running\n");
                }
-               PMD_DRV_LOG(WARNING, "Arkville Evaluation System - "
-                           "Timer is Running\n");
        }
 
-       PMD_DRV_LOG(INFO,
+       ARK_PMD_LOG(DEBUG,
                    "HW Sanity test has PASSED, expected constant"
                    " 0x%x, read 0x%x (%s)\n",
                    0xcafef00d, ark->sysctrl.t32[4], __func__);
@@ -317,10 +389,11 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
                return -1;
 
        dev->dev_ops = &ark_eth_dev_ops;
+       dev->rx_queue_count = eth_ark_dev_rx_queue_count;
 
-       dev->data->mac_addrs = rte_zmalloc("ark", ETHER_ADDR_LEN, 0);
+       dev->data->mac_addrs = rte_zmalloc("ark", RTE_ETHER_ADDR_LEN, 0);
        if (!dev->data->mac_addrs) {
-               PMD_DRV_LOG(ERR,
+               ARK_PMD_LOG(ERR,
                            "Failed to allocated memory for storing mac address"
                            );
        }
@@ -329,7 +402,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
                ark->user_data[dev->data->port_id] =
                        ark->user_ext.dev_init(dev, ark->a_bar, 0);
                if (!ark->user_data[dev->data->port_id]) {
-                       PMD_DRV_LOG(INFO,
+                       ARK_PMD_LOG(WARNING,
                                    "Failed to initialize PMD extension!"
                                    " continuing without it\n");
                        memset(&ark->user_ext, 0, sizeof(struct ark_user_ext));
@@ -340,7 +413,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
        if (pci_dev->device.devargs)
                ret = eth_ark_check_args(ark, pci_dev->device.devargs->args);
        else
-               PMD_DRV_LOG(INFO, "No Device args found\n");
+               ARK_PMD_LOG(INFO, "No Device args found\n");
 
        if (ret)
                goto error;
@@ -371,7 +444,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
                /* reserve an ethdev entry */
                eth_dev = rte_eth_dev_allocate(name);
                if (!eth_dev) {
-                       PMD_DRV_LOG(ERR,
+                       ARK_PMD_LOG(ERR,
                                    "Could not allocate eth_dev for port %d\n",
                                    p);
                        goto error;
@@ -384,10 +457,12 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
                eth_dev->rx_pkt_burst = ark->eth_dev->rx_pkt_burst;
 
                rte_eth_copy_pci_info(eth_dev, pci_dev);
+               eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
 
-               eth_dev->data->mac_addrs = rte_zmalloc(name, ETHER_ADDR_LEN, 0);
+               eth_dev->data->mac_addrs = rte_zmalloc(name,
+                                               RTE_ETHER_ADDR_LEN, 0);
                if (!eth_dev->data->mac_addrs) {
-                       PMD_DRV_LOG(ERR,
+                       ARK_PMD_LOG(ERR,
                                    "Memory allocation for MAC failed!"
                                    " Exiting.\n");
                        goto error;
@@ -403,9 +478,9 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
 
        return ret;
 
- error:
-       if (dev->data->mac_addrs)
-               rte_free(dev->data->mac_addrs);
+error:
+       rte_free(dev->data->mac_addrs);
+       dev->data->mac_addrs = NULL;
        return -1;
 }
 
@@ -417,8 +492,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)
 static int
 ark_config_device(struct rte_eth_dev *dev)
 {
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
        uint16_t num_q, i;
        struct ark_mpu_t *mpu;
 
@@ -426,66 +500,44 @@ ark_config_device(struct rte_eth_dev *dev)
         * Make sure that the packet director, generator and checker are in a
         * known state
         */
-       ark->start_pg = 0;
-       ark->pg = ark_pktgen_init(ark->pktgen.v, 0, 1);
-       if (ark->pg == NULL)
-               return -1;
-       ark_pktgen_reset(ark->pg);
-       ark->pc = ark_pktchkr_init(ark->pktchkr.v, 0, 1);
-       if (ark->pc == NULL)
-               return -1;
-       ark_pktchkr_stop(ark->pc);
-       ark->pd = ark_pktdir_init(ark->pktdir.v);
-       if (ark->pd == NULL)
-               return -1;
-
+       if (!ark->isvf) {
+               ark->start_pg = 0;
+               ark->pg_running = 0;
+               ark->pg = ark_pktgen_init(ark->pktgen.v, 0, 1);
+               if (ark->pg == NULL)
+                       return -1;
+               ark_pktgen_reset(ark->pg);
+               ark->pc = ark_pktchkr_init(ark->pktchkr.v, 0, 1);
+               if (ark->pc == NULL)
+                       return -1;
+               ark_pktchkr_stop(ark->pc);
+               ark->pd = ark_pktdir_init(ark->pktdir.v);
+               if (ark->pd == NULL)
+                       return -1;
+       }
        /* Verify HW */
        if (ark_udm_verify(ark->udm.v))
                return -1;
        if (ark_ddm_verify(ark->ddm.v))
                return -1;
 
-       /* UDM */
-       if (ark_udm_reset(ark->udm.v)) {
-               PMD_DRV_LOG(ERR, "Unable to stop and reset UDM\n");
-               return -1;
-       }
-       /* Keep in reset until the MPU are cleared */
-
        /* MPU reset */
        mpu = ark->mpurx.v;
        num_q = ark_api_num_queues(mpu);
        ark->rx_queues = num_q;
        for (i = 0; i < num_q; i++) {
-               ark_mpu_reset(mpu);
                mpu = RTE_PTR_ADD(mpu, ARK_MPU_QOFFSET);
        }
 
-       ark_udm_stop(ark->udm.v, 0);
-       ark_udm_configure(ark->udm.v,
-                         RTE_PKTMBUF_HEADROOM,
-                         RTE_MBUF_DEFAULT_DATAROOM,
-                         ARK_RX_WRITE_TIME_NS);
-       ark_udm_stats_reset(ark->udm.v);
-       ark_udm_stop(ark->udm.v, 0);
-
-       /* TX -- DDM */
-       if (ark_ddm_stop(ark->ddm.v, 1))
-               PMD_DRV_LOG(ERR, "Unable to stop DDM\n");
-
        mpu = ark->mputx.v;
        num_q = ark_api_num_queues(mpu);
        ark->tx_queues = num_q;
        for (i = 0; i < num_q; i++) {
-               ark_mpu_reset(mpu);
                mpu = RTE_PTR_ADD(mpu, ARK_MPU_QOFFSET);
        }
 
-       ark_ddm_reset(ark->ddm.v);
-       ark_ddm_stats_reset(ark->ddm.v);
-
-       ark_ddm_stop(ark->ddm.v, 0);
-       ark_rqp_stats_reset(ark->rqpacing);
+       if (!ark->isvf && ark->rqpacing)
+               ark_rqp_stats_reset(ark->rqpacing);
 
        return 0;
 }
@@ -493,8 +545,7 @@ ark_config_device(struct rte_eth_dev *dev)
 static int
 eth_ark_dev_uninit(struct rte_eth_dev *dev)
 {
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        if (rte_eal_process_type() != RTE_PROC_PRIMARY)
                return 0;
@@ -503,21 +554,18 @@ eth_ark_dev_uninit(struct rte_eth_dev *dev)
                ark->user_ext.dev_uninit(dev,
                         ark->user_data[dev->data->port_id]);
 
-       ark_pktgen_uninit(ark->pg);
-       ark_pktchkr_uninit(ark->pc);
+       if (!ark->isvf) {
+               ark_pktgen_uninit(ark->pg);
+               ark_pktchkr_uninit(ark->pc);
+       }
 
-       dev->dev_ops = NULL;
-       dev->rx_pkt_burst = NULL;
-       dev->tx_pkt_burst = NULL;
        return 0;
 }
 
 static int
 eth_ark_dev_configure(struct rte_eth_dev *dev)
 {
-       PMD_FUNC_LOG(DEBUG, "\n");
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        eth_ark_dev_set_link_up(dev);
        if (ark->user_ext.dev_configure)
@@ -526,33 +574,13 @@ eth_ark_dev_configure(struct rte_eth_dev *dev)
        return 0;
 }
 
-static void *
-delay_pg_start(void *arg)
-{
-       struct ark_adapter *ark = (struct ark_adapter *)arg;
-
-       /* This function is used exclusively for regression testing, We
-        * perform a blind sleep here to ensure that the external test
-        * application has time to setup the test before we generate packets
-        */
-       usleep(100000);
-       ark_pktgen_run(ark->pg);
-       return NULL;
-}
-
 static int
 eth_ark_dev_start(struct rte_eth_dev *dev)
 {
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
        int i;
 
-       PMD_FUNC_LOG(DEBUG, "\n");
-
        /* RX Side */
-       /* start UDM */
-       ark_udm_start(ark->udm.v);
-
        for (i = 0; i < dev->data->nb_rx_queues; i++)
                eth_ark_rx_start_queue(dev, i);
 
@@ -560,28 +588,31 @@ eth_ark_dev_start(struct rte_eth_dev *dev)
        for (i = 0; i < dev->data->nb_tx_queues; i++)
                eth_ark_tx_queue_start(dev, i);
 
-       /* start DDM */
-       ark_ddm_start(ark->ddm.v);
-
        ark->started = 1;
        /* set xmit and receive function */
        dev->rx_pkt_burst = &eth_ark_recv_pkts;
        dev->tx_pkt_burst = &eth_ark_xmit_pkts;
 
-       if (ark->start_pg)
+       if (!ark->isvf && ark->start_pg)
                ark_pktchkr_run(ark->pc);
 
-       if (ark->start_pg && (dev->data->port_id == 0)) {
+       if (!ark->isvf && ark->start_pg && !ark->pg_running) {
                pthread_t thread;
 
                /* Delay packet generatpr start allow the hardware to be ready
                 * This is only used for sanity checking with internal generator
                 */
-               if (pthread_create(&thread, NULL, delay_pg_start, ark)) {
-                       PMD_DRV_LOG(ERR, "Could not create pktgen "
+               char tname[32];
+               snprintf(tname, sizeof(tname), "ark-delay-pg-%d",
+                        dev->data->port_id);
+
+               if (rte_ctrl_thread_create(&thread, tname, NULL,
+                                          ark_pktgen_delay_start, ark->pg)) {
+                       ARK_PMD_LOG(ERR, "Could not create pktgen "
                                    "starter thread\n");
                        return -1;
                }
+               ark->pg_running = 1;
        }
 
        if (ark->user_ext.dev_start)
@@ -591,20 +622,17 @@ eth_ark_dev_start(struct rte_eth_dev *dev)
        return 0;
 }
 
-static void
+static int
 eth_ark_dev_stop(struct rte_eth_dev *dev)
 {
        uint16_t i;
        int status;
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
-       struct ark_mpu_t *mpu;
-
-       PMD_FUNC_LOG(DEBUG, "\n");
+       struct ark_adapter *ark = dev->data->dev_private;
 
        if (ark->started == 0)
-               return;
+               return 0;
        ark->started = 0;
+       dev->data->dev_started = 0;
 
        /* Stop the extension first */
        if (ark->user_ext.dev_stop)
@@ -612,96 +640,68 @@ eth_ark_dev_stop(struct rte_eth_dev *dev)
                       ark->user_data[dev->data->port_id]);
 
        /* Stop the packet generator */
-       if (ark->start_pg)
+       if (!ark->isvf && ark->start_pg && ark->pg_running) {
                ark_pktgen_pause(ark->pg);
+               ark->pg_running = 0;
+       }
 
-       dev->rx_pkt_burst = &eth_ark_recv_pkts_noop;
-       dev->tx_pkt_burst = &eth_ark_xmit_pkts_noop;
+       dev->rx_pkt_burst = rte_eth_pkt_burst_dummy;
+       dev->tx_pkt_burst = rte_eth_pkt_burst_dummy;
+
+       /* Stop RX Side */
+       for (i = 0; i < dev->data->nb_rx_queues; i++)
+               eth_ark_rx_stop_queue(dev, i);
 
        /* STOP TX Side */
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
                status = eth_ark_tx_queue_stop(dev, i);
                if (status != 0) {
                        uint16_t port = dev->data->port_id;
-                       PMD_DRV_LOG(ERR,
+                       ARK_PMD_LOG(ERR,
                                    "tx_queue stop anomaly"
                                    " port %u, queue %u\n",
                                    port, i);
                }
        }
 
-       /* Stop DDM */
-       /* Wait up to 0.1 second.  each stop is up to 1000 * 10 useconds */
-       for (i = 0; i < 10; i++) {
-               status = ark_ddm_stop(ark->ddm.v, 1);
-               if (status == 0)
-                       break;
-       }
-       if (status || i != 0) {
-               PMD_DRV_LOG(ERR, "DDM stop anomaly. status:"
-                           " %d iter: %u. (%s)\n",
-                           status,
-                           i,
-                           __func__);
-               ark_ddm_dump(ark->ddm.v, "Stop anomaly");
-
-               mpu = ark->mputx.v;
-               for (i = 0; i < ark->tx_queues; i++) {
-                       ark_mpu_dump(mpu, "DDM failure dump", i);
-                       mpu = RTE_PTR_ADD(mpu, ARK_MPU_QOFFSET);
-               }
-       }
-
-       /* STOP RX Side */
-       /* Stop UDM  multiple tries attempted */
-       for (i = 0; i < 10; i++) {
-               status = ark_udm_stop(ark->udm.v, 1);
-               if (status == 0)
-                       break;
-       }
-       if (status || i != 0) {
-               PMD_DRV_LOG(ERR, "UDM stop anomaly. status %d iter: %u. (%s)\n",
-                           status, i, __func__);
-               ark_udm_dump(ark->udm.v, "Stop anomaly");
-
-               mpu = ark->mpurx.v;
-               for (i = 0; i < ark->rx_queues; i++) {
-                       ark_mpu_dump(mpu, "UDM Stop anomaly", i);
-                       mpu = RTE_PTR_ADD(mpu, ARK_MPU_QOFFSET);
-               }
-       }
-
        ark_udm_dump_stats(ark->udm.v, "Post stop");
-       ark_udm_dump_perf(ark->udm.v, "Post stop");
 
        for (i = 0; i < dev->data->nb_rx_queues; i++)
                eth_ark_rx_dump_queue(dev, i, __func__);
 
        /* Stop the packet checker if it is running */
-       if (ark->start_pg) {
+       if (!ark->isvf && ark->start_pg) {
                ark_pktchkr_dump_stats(ark->pc);
                ark_pktchkr_stop(ark->pc);
        }
+
+       return 0;
 }
 
-static void
+static int
 eth_ark_dev_close(struct rte_eth_dev *dev)
 {
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
        uint16_t i;
 
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
+
        if (ark->user_ext.dev_close)
                ark->user_ext.dev_close(dev,
                 ark->user_data[dev->data->port_id]);
 
        eth_ark_dev_stop(dev);
-       eth_ark_udm_force_close(dev);
 
        /*
-        * TODO This should only be called once for the device during shutdown
+        * This should only be called once for the device during shutdown
         */
-       ark_rqp_dump(ark->rqpacing);
+       if (ark->rqpacing)
+               ark_rqp_dump(ark->rqpacing);
+
+       /* return to power-on state */
+       if (ark->pd)
+               ark_pktdir_setup(ark->pd, ARK_PKT_DIR_INIT_VAL);
 
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
                eth_ark_tx_queue_release(dev->data->tx_queues[i]);
@@ -712,14 +712,15 @@ eth_ark_dev_close(struct rte_eth_dev *dev)
                eth_ark_dev_rx_queue_release(dev->data->rx_queues[i]);
                dev->data->rx_queues[i] = 0;
        }
+
+       return 0;
 }
 
-static void
+static int
 eth_ark_dev_info_get(struct rte_eth_dev *dev,
                     struct rte_eth_dev_info *dev_info)
 {
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
        struct ark_mpu_t *tx_mpu = RTE_PTR_ADD(ark->bar0, ARK_MPU_TX_BASE);
        struct ark_mpu_t *rx_mpu = RTE_PTR_ADD(ark->bar0, ARK_MPU_RX_BASE);
        uint16_t ports = ark->num_ports;
@@ -741,21 +742,24 @@ eth_ark_dev_info_get(struct rte_eth_dev *dev,
                .nb_align = ARK_TX_MIN_QUEUE}; /* power of 2 */
 
        /* ARK PMD supports all line rates, how do we indicate that here ?? */
-       dev_info->speed_capa = (ETH_LINK_SPEED_1G |
-                               ETH_LINK_SPEED_10G |
-                               ETH_LINK_SPEED_25G |
-                               ETH_LINK_SPEED_40G |
-                               ETH_LINK_SPEED_50G |
-                               ETH_LINK_SPEED_100G);
+       dev_info->speed_capa = (RTE_ETH_LINK_SPEED_1G |
+                               RTE_ETH_LINK_SPEED_10G |
+                               RTE_ETH_LINK_SPEED_25G |
+                               RTE_ETH_LINK_SPEED_40G |
+                               RTE_ETH_LINK_SPEED_50G |
+                               RTE_ETH_LINK_SPEED_100G);
+
+       dev_info->rx_offload_capa = RTE_ETH_RX_OFFLOAD_TIMESTAMP;
+
+       return 0;
 }
 
 static int
 eth_ark_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
 {
-       PMD_DEBUG_LOG(DEBUG, "link status = %d\n",
+       ARK_PMD_LOG(DEBUG, "link status = %d\n",
                        dev->data->dev_link.link_status);
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        if (ark->user_ext.link_update) {
                return ark->user_ext.link_update
@@ -769,8 +773,7 @@ static int
 eth_ark_dev_set_link_up(struct rte_eth_dev *dev)
 {
        dev->data->dev_link.link_status = 1;
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        if (ark->user_ext.dev_set_link_up)
                return ark->user_ext.dev_set_link_up(dev,
@@ -782,8 +785,7 @@ static int
 eth_ark_dev_set_link_down(struct rte_eth_dev *dev)
 {
        dev->data->dev_link.link_status = 0;
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        if (ark->user_ext.dev_set_link_down)
                return ark->user_ext.dev_set_link_down(dev,
@@ -795,8 +797,7 @@ static int
 eth_ark_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
        uint16_t i;
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        stats->ipackets = 0;
        stats->ibytes = 0;
@@ -815,12 +816,11 @@ eth_ark_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
        return 0;
 }
 
-static void
+static int
 eth_ark_dev_stats_reset(struct rte_eth_dev *dev)
 {
        uint16_t i;
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        for (i = 0; i < dev->data->nb_tx_queues; i++)
                eth_tx_queue_stats_reset(dev->data->tx_queues[i]);
@@ -829,16 +829,17 @@ eth_ark_dev_stats_reset(struct rte_eth_dev *dev)
        if (ark->user_ext.stats_reset)
                ark->user_ext.stats_reset(dev,
                          ark->user_data[dev->data->port_id]);
+
+       return 0;
 }
 
 static int
 eth_ark_macaddr_add(struct rte_eth_dev *dev,
-                   struct ether_addr *mac_addr,
+                   struct rte_ether_addr *mac_addr,
                    uint32_t index,
                    uint32_t pool)
 {
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        if (ark->user_ext.mac_addr_add) {
                ark->user_ext.mac_addr_add(dev,
@@ -854,8 +855,7 @@ eth_ark_macaddr_add(struct rte_eth_dev *dev,
 static void
 eth_ark_macaddr_remove(struct rte_eth_dev *dev, uint32_t index)
 {
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        if (ark->user_ext.mac_addr_remove)
                ark->user_ext.mac_addr_remove(dev, index,
@@ -864,10 +864,9 @@ eth_ark_macaddr_remove(struct rte_eth_dev *dev, uint32_t index)
 
 static int
 eth_ark_set_default_mac_addr(struct rte_eth_dev *dev,
-                            struct ether_addr *mac_addr)
+                            struct rte_ether_addr *mac_addr)
 {
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        if (ark->user_ext.mac_addr_set) {
                ark->user_ext.mac_addr_set(dev, mac_addr,
@@ -880,8 +879,7 @@ eth_ark_set_default_mac_addr(struct rte_eth_dev *dev,
 static int
 eth_ark_set_mtu(struct rte_eth_dev *dev, uint16_t  size)
 {
-       struct ark_adapter *ark =
-               (struct ark_adapter *)dev->data->dev_private;
+       struct ark_adapter *ark = dev->data->dev_private;
 
        if (ark->user_ext.set_mtu)
                return ark->user_ext.set_mtu(dev, size,
@@ -894,20 +892,20 @@ static inline int
 process_pktdir_arg(const char *key, const char *value,
                   void *extra_args)
 {
-       PMD_FUNC_LOG(DEBUG, "key = %s, value = %s\n",
+       ARK_PMD_LOG(DEBUG, "key = %s, value = %s\n",
                    key, value);
        struct ark_adapter *ark =
                (struct ark_adapter *)extra_args;
 
        ark->pkt_dir_v = strtol(value, NULL, 16);
-       PMD_FUNC_LOG(DEBUG, "pkt_dir_v = 0x%x\n", ark->pkt_dir_v);
+       ARK_PMD_LOG(DEBUG, "pkt_dir_v = 0x%x\n", ark->pkt_dir_v);
        return 0;
 }
 
 static inline int
 process_file_args(const char *key, const char *value, void *extra_args)
 {
-       PMD_FUNC_LOG(DEBUG, "key = %s, value = %s\n",
+       ARK_PMD_LOG(DEBUG, "key = %s, value = %s\n",
                    key, value);
        char *args = (char *)extra_args;
 
@@ -918,7 +916,7 @@ process_file_args(const char *key, const char *value, void *extra_args)
        int first = 1;
 
        if (file == NULL) {
-               PMD_DRV_LOG(ERR, "Unable to open "
+               ARK_PMD_LOG(ERR, "Unable to open "
                            "config file %s\n", value);
                return -1;
        }
@@ -926,7 +924,7 @@ process_file_args(const char *key, const char *value, void *extra_args)
        while (fgets(line, sizeof(line), file)) {
                size += strlen(line);
                if (size >= ARK_MAX_ARG_LEN) {
-                       PMD_DRV_LOG(ERR, "Unable to parse file %s args, "
+                       ARK_PMD_LOG(ERR, "Unable to parse file %s args, "
                                    "parameter list is too long\n", value);
                        fclose(file);
                        return -1;
@@ -938,7 +936,7 @@ process_file_args(const char *key, const char *value, void *extra_args)
                        strncat(args, line, ARK_MAX_ARG_LEN);
                }
        }
-       PMD_FUNC_LOG(DEBUG, "file = %s\n", args);
+       ARK_PMD_LOG(DEBUG, "file = %s\n", args);
        fclose(file);
        return 0;
 }
@@ -960,7 +958,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params)
 
        for (k_idx = 0; k_idx < kvlist->count; k_idx++) {
                pair = &kvlist->pairs[k_idx];
-               PMD_FUNC_LOG(DEBUG, "**** Arg passed to PMD = %s:%s\n",
+               ARK_PMD_LOG(DEBUG, "**** Arg passed to PMD = %s:%s\n",
                             pair->key,
                             pair->value);
        }
@@ -969,7 +967,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params)
                               ARK_PKTDIR_ARG,
                               &process_pktdir_arg,
                               ark) != 0) {
-               PMD_DRV_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTDIR_ARG);
+               ARK_PMD_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTDIR_ARG);
                goto free_kvlist;
        }
 
@@ -977,7 +975,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params)
                               ARK_PKTGEN_ARG,
                               &process_file_args,
                               ark->pkt_gen_args) != 0) {
-               PMD_DRV_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTGEN_ARG);
+               ARK_PMD_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTGEN_ARG);
                goto free_kvlist;
        }
 
@@ -985,17 +983,21 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params)
                               ARK_PKTCHKR_ARG,
                               &process_file_args,
                               ark->pkt_chkr_args) != 0) {
-               PMD_DRV_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTCHKR_ARG);
+               ARK_PMD_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTCHKR_ARG);
                goto free_kvlist;
        }
 
-       PMD_DRV_LOG(INFO, "packet director set to 0x%x\n", ark->pkt_dir_v);
+       if (ark->isvf) {
+               ret = 0;
+               goto free_kvlist;
+       }
+       ARK_PMD_LOG(INFO, "packet director set to 0x%x\n", ark->pkt_dir_v);
        /* Setup the packet director */
        ark_pktdir_setup(ark->pd, ark->pkt_dir_v);
 
        /* Setup the packet generator */
        if (ark->pkt_gen_args[0]) {
-               PMD_DRV_LOG(INFO, "Setting up the packet generator\n");
+               ARK_PMD_LOG(DEBUG, "Setting up the packet generator\n");
                ark_pktgen_parse(ark->pkt_gen_args);
                ark_pktgen_reset(ark->pg);
                ark_pktgen_setup(ark->pg);
@@ -1023,3 +1025,4 @@ RTE_PMD_REGISTER_PARAM_STRING(net_ark,
                              ARK_PKTGEN_ARG "=<filename> "
                              ARK_PKTCHKR_ARG "=<filename> "
                              ARK_PKTDIR_ARG "=<bitmap>");
+RTE_LOG_REGISTER_DEFAULT(ark_logtype, NOTICE);