net/ice/base: fix null pointer dereferences for parser
[dpdk.git] / drivers / net / bnx2x / bnx2x_ethdev.c
index 0057843..8b08060 100644 (file)
@@ -8,17 +8,16 @@
 #include "bnx2x.h"
 #include "bnx2x_rxtx.h"
 
+#include <rte_string_fns.h>
 #include <rte_dev.h>
-#include <rte_ethdev_pci.h>
+#include <ethdev_pci.h>
 #include <rte_alarm.h>
 
-int bnx2x_logtype_init;
-int bnx2x_logtype_driver;
-
 /*
  * The set of PCI devices this driver supports
  */
 #define BROADCOM_PCI_VENDOR_ID 0x14E4
+#define QLOGIC_PCI_VENDOR_ID 0x1077
 static const struct rte_pci_id pci_id_bnx2x_map[] = {
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) },
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) },
@@ -26,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = {
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) },
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) },
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) },
+       { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) },
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) },
 #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) },
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) },
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) },
+       { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) },
 #endif
        { .vendor_id = 0, }
 };
@@ -40,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = {
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) },
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) },
        { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) },
+       { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) },
        { .vendor_id = 0, }
 };
 
@@ -87,7 +89,6 @@ bnx2x_link_update(struct rte_eth_dev *dev)
 
        PMD_INIT_FUNC_TRACE(sc);
 
-       bnx2x_link_status_update(sc);
        memset(&link, 0, sizeof(link));
        mb();
        link.link_speed = sc->link_vars.line_speed;
@@ -107,14 +108,15 @@ bnx2x_link_update(struct rte_eth_dev *dev)
 }
 
 static void
-bnx2x_interrupt_action(struct rte_eth_dev *dev)
+bnx2x_interrupt_action(struct rte_eth_dev *dev, int intr_cxt)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
        uint32_t link_status;
 
-       bnx2x_intr_legacy(sc, 0);
+       bnx2x_intr_legacy(sc);
 
-       if (sc->periodic_flags & PERIODIC_GO)
+       if ((atomic_load_acq_long(&sc->periodic_flags) == PERIODIC_GO) &&
+           !intr_cxt)
                bnx2x_periodic_callout(sc);
        link_status = REG_RD(sc, sc->link_params.shmem_base +
                        offsetof(struct shmem_region,
@@ -131,10 +133,8 @@ bnx2x_interrupt_handler(void *param)
 
        PMD_DEBUG_PERIODIC_LOG(INFO, sc, "Interrupt handled");
 
-       atomic_store_rel_long(&sc->periodic_flags, PERIODIC_STOP);
-       bnx2x_interrupt_action(dev);
-       atomic_store_rel_long(&sc->periodic_flags, PERIODIC_GO);
-       rte_intr_enable(&sc->pci_dev->intr_handle);
+       bnx2x_interrupt_action(dev, 1);
+       rte_intr_ack(&sc->pci_dev->intr_handle);
 }
 
 static void bnx2x_periodic_start(void *param)
@@ -144,14 +144,13 @@ static void bnx2x_periodic_start(void *param)
        int ret = 0;
 
        atomic_store_rel_long(&sc->periodic_flags, PERIODIC_GO);
-       bnx2x_interrupt_action(dev);
+       bnx2x_interrupt_action(dev, 0);
        if (IS_PF(sc)) {
                ret = rte_eal_alarm_set(BNX2X_SP_TIMER_PERIOD,
                                        bnx2x_periodic_start, (void *)dev);
                if (ret) {
                        PMD_DRV_LOG(ERR, sc, "Unable to start periodic"
                                             " timer rc %d", ret);
-                       assert(false && "Unable to start periodic timer");
                }
        }
 }
@@ -164,6 +163,8 @@ void bnx2x_periodic_stop(void *param)
        atomic_store_rel_long(&sc->periodic_flags, PERIODIC_STOP);
 
        rte_eal_alarm_cancel(bnx2x_periodic_start, (void *)dev);
+
+       PMD_DRV_LOG(DEBUG, sc, "Periodic poll stopped");
 }
 
 /*
@@ -180,8 +181,10 @@ bnx2x_dev_configure(struct rte_eth_dev *dev)
 
        PMD_INIT_FUNC_TRACE(sc);
 
-       if (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME)
+       if (rxmode->offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {
                sc->mtu = dev->data->dev_conf.rxmode.max_rx_pkt_len;
+               dev->data->mtu = sc->mtu;
+       }
 
        if (dev->data->nb_tx_queues > dev->data->nb_rx_queues) {
                PMD_DRV_LOG(ERR, sc, "The number of TX queues is greater than number of RX queues");
@@ -203,13 +206,7 @@ bnx2x_dev_configure(struct rte_eth_dev *dev)
                return -ENXIO;
        }
 
-       /* allocate the host hardware/software hsi structures */
-       if (bnx2x_alloc_hsi_mem(sc) != 0) {
-               PMD_DRV_LOG(ERR, sc, "bnx2x_alloc_hsi_mem was failed");
-               bnx2x_free_ilt_mem(sc);
-               return -ENXIO;
-       }
-
+       bnx2x_dev_rxtx_init_dummy(dev);
        return 0;
 }
 
@@ -222,8 +219,13 @@ bnx2x_dev_start(struct rte_eth_dev *dev)
        PMD_INIT_FUNC_TRACE(sc);
 
        /* start the periodic callout */
-       if (sc->periodic_flags & PERIODIC_STOP)
-               bnx2x_periodic_start(dev);
+       if (IS_PF(sc)) {
+               if (atomic_load_acq_long(&sc->periodic_flags) ==
+                   PERIODIC_STOP) {
+                       bnx2x_periodic_start(dev);
+                       PMD_DRV_LOG(DEBUG, sc, "Periodic poll re-started");
+               }
+       }
 
        ret = bnx2x_init(sc);
        if (ret) {
@@ -239,19 +241,17 @@ bnx2x_dev_start(struct rte_eth_dev *dev)
                        PMD_DRV_LOG(ERR, sc, "rte_intr_enable failed");
        }
 
-       ret = bnx2x_dev_rx_init(dev);
-       if (ret != 0) {
-               PMD_DRV_LOG(DEBUG, sc, "bnx2x_dev_rx_init returned error code");
-               return -3;
-       }
+       /* Configure the previously stored Multicast address list */
+       if (IS_VF(sc))
+               bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num);
+       bnx2x_dev_rxtx_init(dev);
 
-       /* Print important adapter info for the user. */
-       bnx2x_print_adapter_info(sc);
+       bnx2x_print_device_info(sc);
 
        return ret;
 }
 
-static void
+static int
 bnx2x_dev_stop(struct rte_eth_dev *dev)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
@@ -259,45 +259,58 @@ bnx2x_dev_stop(struct rte_eth_dev *dev)
 
        PMD_INIT_FUNC_TRACE(sc);
 
+       bnx2x_dev_rxtx_init_dummy(dev);
+
        if (IS_PF(sc)) {
                rte_intr_disable(&sc->pci_dev->intr_handle);
                rte_intr_callback_unregister(&sc->pci_dev->intr_handle,
                                bnx2x_interrupt_handler, (void *)dev);
-       }
-
-       /* stop the periodic callout */
-       bnx2x_periodic_stop(dev);
 
+               /* stop the periodic callout */
+               bnx2x_periodic_stop(dev);
+       }
+       /* Remove the configured Multicast list
+        * Sending NULL for the list of address and the
+        * Number is set to 0 denoting DEL_CMD
+        */
+       if (IS_VF(sc))
+               bnx2x_vfpf_set_mcast(sc, NULL, 0);
        ret = bnx2x_nic_unload(sc, UNLOAD_NORMAL, FALSE);
        if (ret) {
                PMD_DRV_LOG(DEBUG, sc, "bnx2x_nic_unload failed (%d)", ret);
-               return;
+               return ret;
        }
 
-       return;
+       return 0;
 }
 
-static void
+static int
 bnx2x_dev_close(struct rte_eth_dev *dev)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
 
        PMD_INIT_FUNC_TRACE(sc);
 
+       /* only close in case of the primary process */
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
+
        if (IS_VF(sc))
                bnx2x_vf_close(sc);
 
        bnx2x_dev_clear_queues(dev);
        memset(&(dev->data->dev_link), 0 , sizeof(struct rte_eth_link));
 
-       /* free the host hardware/software hsi structures */
-       bnx2x_free_hsi_mem(sc);
-
        /* free ilt */
        bnx2x_free_ilt_mem(sc);
+
+       /* mac_addrs must not be freed alone because part of dev_private */
+       dev->data->mac_addrs = NULL;
+
+       return 0;
 }
 
-static void
+static int
 bnx2x_promisc_enable(struct rte_eth_dev *dev)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
@@ -307,9 +320,11 @@ bnx2x_promisc_enable(struct rte_eth_dev *dev)
        if (rte_eth_allmulticast_get(dev->data->port_id) == 1)
                sc->rx_mode = BNX2X_RX_MODE_ALLMULTI_PROMISC;
        bnx2x_set_rx_mode(sc);
+
+       return 0;
 }
 
-static void
+static int
 bnx2x_promisc_disable(struct rte_eth_dev *dev)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
@@ -319,9 +334,11 @@ bnx2x_promisc_disable(struct rte_eth_dev *dev)
        if (rte_eth_allmulticast_get(dev->data->port_id) == 1)
                sc->rx_mode = BNX2X_RX_MODE_ALLMULTI;
        bnx2x_set_rx_mode(sc);
+
+       return 0;
 }
 
-static void
+static int
 bnx2x_dev_allmulticast_enable(struct rte_eth_dev *dev)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
@@ -331,9 +348,11 @@ bnx2x_dev_allmulticast_enable(struct rte_eth_dev *dev)
        if (rte_eth_promiscuous_get(dev->data->port_id) == 1)
                sc->rx_mode = BNX2X_RX_MODE_ALLMULTI_PROMISC;
        bnx2x_set_rx_mode(sc);
+
+       return 0;
 }
 
-static void
+static int
 bnx2x_dev_allmulticast_disable(struct rte_eth_dev *dev)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
@@ -343,6 +362,32 @@ bnx2x_dev_allmulticast_disable(struct rte_eth_dev *dev)
        if (rte_eth_promiscuous_get(dev->data->port_id) == 1)
                sc->rx_mode = BNX2X_RX_MODE_PROMISC;
        bnx2x_set_rx_mode(sc);
+
+       return 0;
+}
+
+static int
+bnx2x_dev_set_mc_addr_list(struct rte_eth_dev *dev,
+               struct rte_ether_addr *mc_addrs, uint32_t mc_addrs_num)
+{
+       struct bnx2x_softc *sc = dev->data->dev_private;
+       int err;
+       PMD_INIT_FUNC_TRACE(sc);
+       /* flush previous addresses */
+       err = bnx2x_vfpf_set_mcast(sc, NULL, 0);
+       if (err)
+               return err;
+       sc->mc_addrs_num = 0;
+
+       /* Add new ones */
+       err = bnx2x_vfpf_set_mcast(sc, mc_addrs, mc_addrs_num);
+       if (err)
+               return err;
+
+       sc->mc_addrs_num = mc_addrs_num;
+       memcpy(sc->mc_addrs, mc_addrs, mc_addrs_num * sizeof(*mc_addrs));
+
+       return 0;
 }
 
 static int
@@ -446,10 +491,9 @@ bnx2x_get_xstats_names(__rte_unused struct rte_eth_dev *dev,
 
        if (xstats_names != NULL)
                for (i = 0; i < stat_cnt; i++)
-                       snprintf(xstats_names[i].name,
-                               sizeof(xstats_names[i].name),
-                               "%s",
-                               bnx2x_xstats_strings[i].name);
+                       strlcpy(xstats_names[i].name,
+                               bnx2x_xstats_strings[i].name,
+                               sizeof(xstats_names[i].name));
 
        return stat_cnt;
 }
@@ -484,10 +528,11 @@ bnx2x_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
        return num;
 }
 
-static void
+static int
 bnx2x_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
+
        dev_info->max_rx_queues  = sc->max_rx_queues;
        dev_info->max_tx_queues  = sc->max_tx_queues;
        dev_info->min_rx_bufsize = BNX2X_MIN_RX_BUF_SIZE;
@@ -495,10 +540,17 @@ bnx2x_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        dev_info->max_mac_addrs  = BNX2X_MAX_MAC_ADDRS;
        dev_info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_20G;
        dev_info->rx_offload_capa = DEV_RX_OFFLOAD_JUMBO_FRAME;
+
+       dev_info->rx_desc_lim.nb_max = MAX_RX_AVAIL;
+       dev_info->rx_desc_lim.nb_min = MIN_RX_SIZE_NONTPA;
+       dev_info->rx_desc_lim.nb_mtu_seg_max = 1;
+       dev_info->tx_desc_lim.nb_max = MAX_TX_AVAIL;
+
+       return 0;
 }
 
 static int
-bnx2x_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac_addr,
+bnx2x_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,
                uint32_t index, uint32_t pool)
 {
        struct bnx2x_softc *sc = dev->data->dev_private;
@@ -553,6 +605,7 @@ static const struct eth_dev_ops bnx2xvf_eth_dev_ops = {
        .promiscuous_disable          = bnx2x_promisc_disable,
        .allmulticast_enable          = bnx2x_dev_allmulticast_enable,
        .allmulticast_disable         = bnx2x_dev_allmulticast_disable,
+       .set_mc_addr_list             = bnx2x_dev_set_mc_addr_list,
        .link_update                  = bnx2xvf_dev_link_update,
        .stats_get                    = bnx2x_dev_stats_get,
        .xstats_get                   = bnx2x_dev_xstats_get,
@@ -574,6 +627,7 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)
        struct rte_pci_device *pci_dev;
        struct rte_pci_addr pci_addr;
        struct bnx2x_softc *sc;
+       static bool adapter_info = true;
 
        /* Extract key data structures */
        sc = eth_dev->data->dev_private;
@@ -588,6 +642,11 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)
 
        eth_dev->dev_ops = is_vf ? &bnx2xvf_eth_dev_ops : &bnx2x_eth_dev_ops;
 
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+               PMD_DRV_LOG(ERR, sc, "Skipping device init from secondary process");
+               return 0;
+       }
+
        rte_eth_copy_pci_info(eth_dev, pci_dev);
 
        sc->pcie_bus    = pci_dev->addr.bus;
@@ -632,8 +691,15 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)
                return ret;
        }
 
+       /* Print important adapter info for the user. */
+       if (adapter_info) {
+               bnx2x_print_adapter_info(sc);
+               adapter_info = false;
+       }
+
        /* schedule periodic poll for slowpath link events */
        if (IS_PF(sc)) {
+               PMD_DRV_LOG(DEBUG, sc, "Scheduling periodic poll for slowpath link events");
                ret = rte_eal_alarm_set(BNX2X_SP_TIMER_PERIOD,
                                        bnx2x_periodic_start, (void *)eth_dev);
                if (ret) {
@@ -643,16 +709,8 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)
                }
        }
 
-       eth_dev->data->mac_addrs = (struct ether_addr *)sc->link_params.mac_addr;
-
-       PMD_DRV_LOG(INFO, sc, "pcie_bus=%d, pcie_device=%d",
-                       sc->pcie_bus, sc->pcie_device);
-       PMD_DRV_LOG(INFO, sc, "bar0.addr=%p, bar1.addr=%p",
-                       sc->bar[BAR0].base_addr, sc->bar[BAR1].base_addr);
-       PMD_DRV_LOG(INFO, sc, "port=%d, path=%d, vnic=%d, func=%d",
-                       PORT_ID(sc), PATH_ID(sc), VNIC_ID(sc), FUNC_ID(sc));
-       PMD_DRV_LOG(INFO, sc, "portID=%d vendorID=0x%x deviceID=0x%x",
-                       eth_dev->data->port_id, pci_dev->id.vendor_id, pci_dev->id.device_id);
+       eth_dev->data->mac_addrs =
+               (struct rte_ether_addr *)sc->link_params.mac_addr;
 
        if (IS_VF(sc)) {
                rte_spinlock_init(&sc->vf2pf_lock);
@@ -684,7 +742,9 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)
        return 0;
 
 out:
-       bnx2x_periodic_stop(eth_dev);
+       if (IS_PF(sc))
+               bnx2x_periodic_stop(eth_dev);
+
        return ret;
 }
 
@@ -704,6 +764,14 @@ eth_bnx2xvf_dev_init(struct rte_eth_dev *eth_dev)
        return bnx2x_common_dev_init(eth_dev, 1);
 }
 
+static int eth_bnx2x_dev_uninit(struct rte_eth_dev *eth_dev)
+{
+       struct bnx2x_softc *sc = eth_dev->data->dev_private;
+       PMD_INIT_FUNC_TRACE(sc);
+       bnx2x_dev_close(eth_dev);
+       return 0;
+}
+
 static struct rte_pci_driver rte_bnx2x_pmd;
 static struct rte_pci_driver rte_bnx2xvf_pmd;
 
@@ -722,7 +790,7 @@ static int eth_bnx2x_pci_probe(struct rte_pci_driver *pci_drv,
 
 static int eth_bnx2x_pci_remove(struct rte_pci_device *pci_dev)
 {
-       return rte_eth_dev_pci_generic_remove(pci_dev, NULL);
+       return rte_eth_dev_pci_generic_remove(pci_dev, eth_bnx2x_dev_uninit);
 }
 
 static struct rte_pci_driver rte_bnx2x_pmd = {
@@ -748,13 +816,5 @@ RTE_PMD_REGISTER_KMOD_DEP(net_bnx2x, "* igb_uio | uio_pci_generic | vfio-pci");
 RTE_PMD_REGISTER_PCI(net_bnx2xvf, rte_bnx2xvf_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_bnx2xvf, pci_id_bnx2xvf_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_bnx2xvf, "* igb_uio | vfio-pci");
-
-RTE_INIT(bnx2x_init_log)
-{
-       bnx2x_logtype_init = rte_log_register("pmd.net.bnx2x.init");
-       if (bnx2x_logtype_init >= 0)
-               rte_log_set_level(bnx2x_logtype_init, RTE_LOG_NOTICE);
-       bnx2x_logtype_driver = rte_log_register("pmd.net.bnx2x.driver");
-       if (bnx2x_logtype_driver >= 0)
-               rte_log_set_level(bnx2x_logtype_driver, RTE_LOG_NOTICE);
-}
+RTE_LOG_REGISTER_SUFFIX(bnx2x_logtype_init, init, NOTICE);
+RTE_LOG_REGISTER_SUFFIX(bnx2x_logtype_driver, driver, NOTICE);