net/bnxt: remove unnecessary comment

[dpdk.git] / drivers / net / bnxt / bnxt_cpr.c

diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c
index 464ca8b..2c7fd78 100644 (file)
--- a/drivers/net/bnxt/bnxt_cpr.c
+++ b/drivers/net/bnxt/bnxt_cpr.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2014-2018 Broadcom
+ * Copyright(c) 2014-2021 Broadcom
  * All rights reserved.
  */
 
@@ -50,8 +50,8 @@ static void
 bnxt_process_default_vnic_change(struct bnxt *bp,
                                 struct hwrm_async_event_cmpl *async_cmp)
 {
-       uint16_t fid, vnic_state, parent_id, vf_fid, vf_id;
-       struct bnxt_vf_representor *vf_rep_bp;
+       uint16_t vnic_state, vf_fid, vf_id;
+       struct bnxt_representor *vf_rep_bp;
        struct rte_eth_dev *eth_dev;
        bool vfr_found = false;
        uint32_t event_data;
@@ -67,10 +67,7 @@ bnxt_process_default_vnic_change(struct bnxt *bp,
        if (vnic_state != BNXT_DEFAULT_VNIC_ALLOC)
                return;
 
-       parent_id = (event_data & BNXT_DEFAULT_VNIC_CHANGE_PF_ID_MASK) >>
-                       BNXT_DEFAULT_VNIC_CHANGE_PF_ID_SFT;
-       fid = BNXT_PF(bp) ? bp->fw_fid : bp->parent->fid;
-       if (parent_id != fid || !bp->rep_info)
+       if (!bp->rep_info)
                return;
 
        vf_fid = (event_data & BNXT_DEFAULT_VNIC_CHANGE_VF_ID_MASK) >>
@@ -91,7 +88,7 @@ bnxt_process_default_vnic_change(struct bnxt *bp,
        if (!vfr_found)
                return;
 
-       bnxt_vf_rep_dev_start_op(eth_dev);
+       bnxt_rep_dev_start_op(eth_dev);
 }
 
 /*
@@ -103,15 +100,17 @@ void bnxt_handle_async_event(struct bnxt *bp,
        struct hwrm_async_event_cmpl *async_cmp =
                                (struct hwrm_async_event_cmpl *)cmp;
        uint16_t event_id = rte_le_to_cpu_16(async_cmp->event_id);
+       uint16_t port_id = bp->eth_dev->data->port_id;
        struct bnxt_error_recovery_info *info;
        uint32_t event_data;
+       uint32_t echo_req_data1, echo_req_data2;
 
        switch (event_id) {
        case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_STATUS_CHANGE:
        case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CHANGE:
        case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE:
                /* FALLTHROUGH */
-               bnxt_link_update(bp->eth_dev, 0, ETH_LINK_UP);
+               bnxt_link_update_op(bp->eth_dev, 0);
                break;
        case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PF_DRVR_UNLOAD:
                PMD_DRV_LOG(INFO, "Async event: PF driver unloaded\n");
@@ -124,12 +123,19 @@ void bnxt_handle_async_event(struct bnxt *bp,
                PMD_DRV_LOG(INFO, "Port conn async event\n");
                break;
        case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_RESET_NOTIFY:
+               /*
+                * Avoid any rx/tx packet processing during firmware reset
+                * operation.
+                */
+               bnxt_stop_rxtx(bp);
+
                /* Ignore reset notify async events when stopping the port */
                if (!bp->eth_dev->data->dev_started) {
                        bp->flags |= BNXT_FLAG_FATAL_ERROR;
                        return;
                }
 
+               pthread_mutex_lock(&bp->err_recovery_lock);
                event_data = rte_le_to_cpu_32(async_cmp->event_data1);
                /* timestamp_lo/hi values are in units of 100ms */
                bp->fw_reset_max_msecs = async_cmp->timestamp_hi ?
@@ -141,14 +147,17 @@ void bnxt_handle_async_event(struct bnxt *bp,
                if ((event_data & EVENT_DATA1_REASON_CODE_MASK) ==
                    EVENT_DATA1_REASON_CODE_FW_EXCEPTION_FATAL) {
                        PMD_DRV_LOG(INFO,
-                                   "Firmware fatal reset event received\n");
+                                   "Port %u: Firmware fatal reset event received\n",
+                                   port_id);
                        bp->flags |= BNXT_FLAG_FATAL_ERROR;
                } else {
                        PMD_DRV_LOG(INFO,
-                                   "Firmware non-fatal reset event received\n");
+                                   "Port %u: Firmware non-fatal reset event received\n",
+                                   port_id);
                }
 
                bp->flags |= BNXT_FLAG_FW_RESET;
+               pthread_mutex_unlock(&bp->err_recovery_lock);
                rte_eal_alarm_set(US_PER_MS, bnxt_dev_reset_and_resume,
                                  (void *)bp);
                break;
@@ -158,7 +167,8 @@ void bnxt_handle_async_event(struct bnxt *bp,
                if (!info)
                        return;
 
-               PMD_DRV_LOG(INFO, "Error recovery async event received\n");
+               PMD_DRV_LOG(INFO, "Port %u: Error recovery async event received\n",
+                           port_id);
 
                event_data = rte_le_to_cpu_32(async_cmp->event_data1) &
                                EVENT_DATA1_FLAGS_MASK;
@@ -173,8 +183,8 @@ void bnxt_handle_async_event(struct bnxt *bp,
                else
                        info->flags &= ~BNXT_FLAG_RECOVERY_ENABLED;
 
-               PMD_DRV_LOG(INFO, "recovery enabled(%d), master function(%d)\n",
-                           bnxt_is_recovery_enabled(bp),
+               PMD_DRV_LOG(INFO, "Port %u: recovery enabled(%d), master function(%d)\n",
+                           port_id, bnxt_is_recovery_enabled(bp),
                            bnxt_is_master_func(bp));
 
                if (bp->flags & BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED)
@@ -195,6 +205,16 @@ void bnxt_handle_async_event(struct bnxt *bp,
        case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_DEFAULT_VNIC_CHANGE:
                bnxt_process_default_vnic_change(bp, async_cmp);
                break;
+       case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_ECHO_REQUEST:
+               echo_req_data1 = rte_le_to_cpu_32(async_cmp->event_data1);
+               echo_req_data2 = rte_le_to_cpu_32(async_cmp->event_data2);
+               PMD_DRV_LOG(INFO,
+                           "Port %u: Received fw echo request: data1 %#x data2 %#x\n",
+                           port_id, echo_req_data1, echo_req_data2);
+               if (bp->recovery_info)
+                       bnxt_hwrm_fw_echo_reply(bp, echo_req_data1,
+                                               echo_req_data2);
+               break;
        default:
                PMD_DRV_LOG(DEBUG, "handle_async_event id = 0x%x\n", event_id);
                break;
@@ -239,7 +259,7 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl)
                goto reject;
        }
 
-       if (bnxt_rcv_msg_from_vf(bp, vf_id, fwd_cmd) == true) {
+       if (bnxt_rcv_msg_from_vf(bp, vf_id, fwd_cmd)) {
                /*
                 * In older firmware versions, the MAC had to be all zeros for
                 * the VF to set it's MAC via hwrm_func_vf_cfg. Set to all
@@ -254,6 +274,7 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl)
                                (const uint8_t *)"\x00\x00\x00\x00\x00");
                        }
                }
+
                if (fwd_cmd->req_type == HWRM_CFA_L2_SET_RX_MASK) {
                        struct hwrm_cfa_l2_set_rx_mask_input *srm =
                                                        (void *)fwd_cmd;
@@ -265,6 +286,7 @@ void bnxt_handle_fwd_req(struct bnxt *bp, struct cmpl_base *cmpl)
                            HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_VLAN_NONVLAN |
                            HWRM_CFA_L2_SET_RX_MASK_INPUT_MASK_ANYVLAN_NONVLAN);
                }
+
                /* Forward */
                rc = bnxt_hwrm_exec_fwd_resp(bp, fw_vf_id, fwd_cmd, req_len);
                if (rc) {
@@ -306,7 +328,7 @@ int bnxt_event_hwrm_resp_handler(struct bnxt *bp, struct cmpl_base *cmp)
                bnxt_handle_async_event(bp, cmp);
                evt = 1;
                break;
-       case CMPL_BASE_TYPE_HWRM_FWD_RESP:
+       case CMPL_BASE_TYPE_HWRM_FWD_REQ:
                /* Handle HWRM forwarded responses */
                bnxt_handle_fwd_req(bp, cmp);
                evt = 1;
@@ -338,3 +360,9 @@ bool bnxt_is_recovery_enabled(struct bnxt *bp)
 
        return false;
 }
+
+void bnxt_stop_rxtx(struct bnxt *bp)
+{
+       bp->eth_dev->rx_pkt_burst = &bnxt_dummy_recv_pkts;
+       bp->eth_dev->tx_pkt_burst = &bnxt_dummy_xmit_pkts;
+}