net/hns3: encapsulate DFX stats in datapath
[dpdk.git] / drivers / net / bnxt / bnxt_ethdev.c
index 32318cf..4b76cd5 100644 (file)
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2014-2018 Broadcom
+ * Copyright(c) 2014-2021 Broadcom
  * All rights reserved.
  */
 
@@ -7,8 +7,8 @@
 #include <stdbool.h>
 
 #include <rte_dev.h>
-#include <rte_ethdev_driver.h>
-#include <rte_ethdev_pci.h>
+#include <ethdev_driver.h>
+#include <ethdev_pci.h>
 #include <rte_malloc.h>
 #include <rte_cycles.h>
 #include <rte_alarm.h>
@@ -31,6 +31,7 @@
 #include "bnxt_nvm_defs.h"
 #include "bnxt_tf_common.h"
 #include "ulp_flow_db.h"
+#include "rte_pmd_bnxt.h"
 
 #define DRV_MODULE_NAME                "bnxt"
 static const char bnxt_version[] =
@@ -46,27 +47,13 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
                         BROADCOM_DEV_ID_STRATUS_NIC_VF2) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_STRATUS_NIC) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_VF) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57302) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57304_PF) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57304_VF) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_NS2) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57402) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57404) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57406_PF) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57406_VF) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57402_MF) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57407_RJ45) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57404_MF) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57406_MF) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57407_SFP) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57407_MF) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_5741X_VF) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_5731X_VF) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57314) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57417_MF) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57311) },
-       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57312) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57412) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57416_RJ45) },
@@ -93,6 +80,10 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57508_MF2) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57504_MF2) },
        { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57502_MF2) },
+       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_58812) },
+       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_58814) },
+       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_58818) },
+       { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_58818_VF) },
        { .vendor_id = 0, /* sentinel */ },
 };
 
@@ -163,6 +154,8 @@ static const char *const bnxt_dev_args[] = {
  */
 #define BNXT_DEVARG_REP_FC_F2R_INVALID(rep_fc_f2r)     ((rep_fc_f2r) > 1)
 
+int bnxt_cfa_code_dynfield_offset = -1;
+
 /*
  * max_num_kflows must be >= 32
  * and must be a power-of-2 supported value
@@ -204,20 +197,23 @@ int is_bnxt_in_error(struct bnxt *bp)
 
 static uint16_t bnxt_rss_ctxts(const struct bnxt *bp)
 {
-       if (!BNXT_CHIP_THOR(bp))
+       unsigned int num_rss_rings = RTE_MIN(bp->rx_nr_rings,
+                                            BNXT_RSS_TBL_SIZE_P5);
+
+       if (!BNXT_CHIP_P5(bp))
                return 1;
 
-       return RTE_ALIGN_MUL_CEIL(bp->rx_nr_rings,
-                                 BNXT_RSS_ENTRIES_PER_CTX_THOR) /
-                                   BNXT_RSS_ENTRIES_PER_CTX_THOR;
+       return RTE_ALIGN_MUL_CEIL(num_rss_rings,
+                                 BNXT_RSS_ENTRIES_PER_CTX_P5) /
+                                 BNXT_RSS_ENTRIES_PER_CTX_P5;
 }
 
 uint16_t bnxt_rss_hash_tbl_size(const struct bnxt *bp)
 {
-       if (!BNXT_CHIP_THOR(bp))
+       if (!BNXT_CHIP_P5(bp))
                return HW_HASH_INDEX_SIZE;
 
-       return bnxt_rss_ctxts(bp) * BNXT_RSS_ENTRIES_PER_CTX_THOR;
+       return bnxt_rss_ctxts(bp) * BNXT_RSS_ENTRIES_PER_CTX_P5;
 }
 
 static void bnxt_free_parent_info(struct bnxt *bp)
@@ -421,6 +417,14 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id)
        if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS) {
                int j, nr_ctxs = bnxt_rss_ctxts(bp);
 
+               if (bp->rx_nr_rings > BNXT_RSS_TBL_SIZE_P5) {
+                       PMD_DRV_LOG(ERR, "RxQ cnt %d > reta_size %d\n",
+                                   bp->rx_nr_rings, BNXT_RSS_TBL_SIZE_P5);
+                       PMD_DRV_LOG(ERR,
+                                   "Only queues 0-%d will be in RSS table\n",
+                                   BNXT_RSS_TBL_SIZE_P5 - 1);
+               }
+
                rc = 0;
                for (j = 0; j < nr_ctxs; j++) {
                        rc = bnxt_hwrm_vnic_ctx_alloc(bp, vnic, j);
@@ -675,7 +679,7 @@ static int bnxt_update_phy_setting(struct bnxt *bp)
        return rc;
 }
 
-static int bnxt_init_chip(struct bnxt *bp)
+static int bnxt_start_nic(struct bnxt *bp)
 {
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(bp->eth_dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
@@ -698,8 +702,8 @@ static int bnxt_init_chip(struct bnxt *bp)
        /* THOR does not support ring groups.
         * But we will use the array to save RSS context IDs.
         */
-       if (BNXT_CHIP_THOR(bp))
-               bp->max_ring_grps = BNXT_MAX_RSS_CTXTS_THOR;
+       if (BNXT_CHIP_P5(bp))
+               bp->max_ring_grps = BNXT_MAX_RSS_CTXTS_P5;
 
        rc = bnxt_alloc_all_hwrm_stat_ctxs(bp);
        if (rc) {
@@ -744,11 +748,17 @@ skip_cosq_cfg:
                goto err_out;
        }
 
+       /* default vnic 0 */
+       rc = bnxt_setup_one_vnic(bp, 0);
+       if (rc)
+               goto err_out;
        /* VNIC configuration */
-       for (i = 0; i < bp->nr_vnics; i++) {
-               rc = bnxt_setup_one_vnic(bp, i);
-               if (rc)
-                       goto err_out;
+       if (BNXT_RFS_NEEDS_VNIC(bp)) {
+               for (i = 1; i < bp->nr_vnics; i++) {
+                       rc = bnxt_setup_one_vnic(bp, i);
+                       if (rc)
+                               goto err_out;
+               }
        }
 
        rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL);
@@ -845,6 +855,10 @@ uint32_t bnxt_get_speed_capabilities(struct bnxt *bp)
        uint32_t link_speed = bp->link_info->support_speeds;
        uint32_t speed_capa = 0;
 
+       /* If PAM4 is configured, use PAM4 supported speed */
+       if (link_speed == 0 && bp->link_info->support_pam4_speeds > 0)
+               link_speed = bp->link_info->support_pam4_speeds;
+
        if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_LINK_SPEED_100MB)
                speed_capa |= ETH_LINK_SPEED_100M;
        if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_100MBHD)
@@ -902,7 +916,7 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
        if (BNXT_PF(bp))
                dev_info->max_vfs = pdev->max_vfs;
 
-       max_rx_rings = BNXT_MAX_RINGS(bp);
+       max_rx_rings = bnxt_max_rings(bp);
        /* For the sake of symmetry, max_rx_queues = max_tx_queues */
        dev_info->max_rx_queues = max_rx_rings;
        dev_info->max_tx_queues = max_rx_rings;
@@ -1053,13 +1067,6 @@ static int bnxt_dev_configure_op(struct rte_eth_dev *eth_dev)
                }
 
                pthread_mutex_unlock(&bp->def_cp_lock);
-       } else {
-               /* legacy driver needs to get updated values */
-               rc = bnxt_hwrm_func_qcaps(bp);
-               if (rc) {
-                       PMD_DRV_LOG(ERR, "hwrm func qcaps fail:%d\n", rc);
-                       return rc;
-               }
        }
 
        /* Inherit new configurations */
@@ -1152,6 +1159,12 @@ bnxt_receive_function(struct rte_eth_dev *eth_dev)
 {
        struct bnxt *bp = eth_dev->data->dev_private;
 
+       /* Disable vector mode RX for Stingray2 for now */
+       if (BNXT_CHIP_SR2(bp)) {
+               bp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;
+               return bnxt_recv_pkts;
+       }
+
 #if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
 #ifndef RTE_LIBRTE_IEEE1588
        /*
@@ -1168,6 +1181,7 @@ bnxt_receive_function(struct rte_eth_dev *eth_dev)
                DEV_RX_OFFLOAD_UDP_CKSUM |
                DEV_RX_OFFLOAD_TCP_CKSUM |
                DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
+               DEV_RX_OFFLOAD_OUTER_UDP_CKSUM |
                DEV_RX_OFFLOAD_RSS_HASH |
                DEV_RX_OFFLOAD_VLAN_FILTER)) &&
            !BNXT_TRUFLOW_EN(bp) && BNXT_NUM_ASYNC_CPR(bp) &&
@@ -1191,12 +1205,17 @@ bnxt_receive_function(struct rte_eth_dev *eth_dev)
 }
 
 static eth_tx_burst_t
-bnxt_transmit_function(__rte_unused struct rte_eth_dev *eth_dev)
+bnxt_transmit_function(struct rte_eth_dev *eth_dev)
 {
+       struct bnxt *bp = eth_dev->data->dev_private;
+
+       /* Disable vector mode TX for Stingray2 for now */
+       if (BNXT_CHIP_SR2(bp))
+               return bnxt_xmit_pkts;
+
 #if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
 #ifndef RTE_LIBRTE_IEEE1588
        uint64_t offloads = eth_dev->data->dev_conf.txmode.offloads;
-       struct bnxt *bp = eth_dev->data->dev_private;
 
        /*
         * Vector mode transmit can be enabled only if not using scatter rx
@@ -1241,81 +1260,6 @@ static int bnxt_handle_if_change_status(struct bnxt *bp)
        return rc;
 }
 
-static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
-{
-       struct bnxt *bp = eth_dev->data->dev_private;
-       uint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads;
-       int vlan_mask = 0;
-       int rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT;
-
-       if (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) {
-               PMD_DRV_LOG(ERR, "Queues are not configured yet!\n");
-               return -EINVAL;
-       }
-
-       if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) {
-               PMD_DRV_LOG(ERR,
-                       "RxQ cnt %d > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",
-                       bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);
-       }
-
-       do {
-               rc = bnxt_hwrm_if_change(bp, true);
-               if (rc == 0 || rc != -EAGAIN)
-                       break;
-
-               rte_delay_ms(BNXT_IF_CHANGE_RETRY_INTERVAL);
-       } while (retry_cnt--);
-
-       if (rc)
-               return rc;
-
-       if (bp->flags & BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE) {
-               rc = bnxt_handle_if_change_status(bp);
-               if (rc)
-                       return rc;
-       }
-
-       bnxt_enable_int(bp);
-
-       rc = bnxt_init_chip(bp);
-       if (rc)
-               goto error;
-
-       eth_dev->data->scattered_rx = bnxt_scattered_rx(eth_dev);
-       eth_dev->data->dev_started = 1;
-
-       bnxt_link_update_op(eth_dev, 1);
-
-       if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
-               vlan_mask |= ETH_VLAN_FILTER_MASK;
-       if (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
-               vlan_mask |= ETH_VLAN_STRIP_MASK;
-       rc = bnxt_vlan_offload_set_op(eth_dev, vlan_mask);
-       if (rc)
-               goto error;
-
-       /* Initialize bnxt ULP port details */
-       rc = bnxt_ulp_port_init(bp);
-       if (rc)
-               goto error;
-
-       eth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev);
-       eth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);
-
-       bnxt_schedule_fw_health_check(bp);
-
-       return 0;
-
-error:
-       bnxt_shutdown_nic(bp);
-       bnxt_free_tx_mbufs(bp);
-       bnxt_free_rx_mbufs(bp);
-       bnxt_hwrm_if_change(bp, false);
-       eth_dev->data->dev_started = 0;
-       return rc;
-}
-
 static int bnxt_dev_set_link_up_op(struct rte_eth_dev *eth_dev)
 {
        struct bnxt *bp = eth_dev->data->dev_private;
@@ -1343,12 +1287,17 @@ static int bnxt_dev_set_link_down_op(struct rte_eth_dev *eth_dev)
 
 static void bnxt_free_switch_domain(struct bnxt *bp)
 {
-       if (bp->switch_domain_id)
-               rte_eth_switch_domain_free(bp->switch_domain_id);
+       int rc = 0;
+
+       if (bp->switch_domain_id) {
+               rc = rte_eth_switch_domain_free(bp->switch_domain_id);
+               if (rc)
+                       PMD_DRV_LOG(ERR, "free switch domain:%d fail: %d\n",
+                                   bp->switch_domain_id, rc);
+       }
 }
 
-/* Unload the driver, release resources */
-static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
+static int bnxt_dev_stop(struct rte_eth_dev *eth_dev)
 {
        struct bnxt *bp = eth_dev->data->dev_private;
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
@@ -1416,31 +1365,115 @@ static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
        return 0;
 }
 
-static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)
+/* Unload the driver, release resources */
+static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
 {
        struct bnxt *bp = eth_dev->data->dev_private;
-       int ret = 0;
 
-       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
-               return 0;
+       pthread_mutex_lock(&bp->err_recovery_lock);
+       if (bp->flags & BNXT_FLAG_FW_RESET) {
+               PMD_DRV_LOG(ERR,
+                           "Adapter recovering from error..Please retry\n");
+               pthread_mutex_unlock(&bp->err_recovery_lock);
+               return -EAGAIN;
+       }
+       pthread_mutex_unlock(&bp->err_recovery_lock);
 
-       /* cancel the recovery handler before remove dev */
-       rte_eal_alarm_cancel(bnxt_dev_reset_and_resume, (void *)bp);
-       rte_eal_alarm_cancel(bnxt_dev_recover, (void *)bp);
-       bnxt_cancel_fc_thread(bp);
+       return bnxt_dev_stop(eth_dev);
+}
 
-       if (eth_dev->data->dev_started)
-               ret = bnxt_dev_stop_op(eth_dev);
+static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
+{
+       struct bnxt *bp = eth_dev->data->dev_private;
+       uint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads;
+       int vlan_mask = 0;
+       int rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT;
 
-       bnxt_free_switch_domain(bp);
+       if (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) {
+               PMD_DRV_LOG(ERR, "Queues are not configured yet!\n");
+               return -EINVAL;
+       }
 
-       bnxt_uninit_resources(bp, false);
+       if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS)
+               PMD_DRV_LOG(ERR,
+                           "RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",
+                           bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);
+
+       do {
+               rc = bnxt_hwrm_if_change(bp, true);
+               if (rc == 0 || rc != -EAGAIN)
+                       break;
+
+               rte_delay_ms(BNXT_IF_CHANGE_RETRY_INTERVAL);
+       } while (retry_cnt--);
+
+       if (rc)
+               return rc;
+
+       if (bp->flags & BNXT_FLAG_IF_CHANGE_HOT_FW_RESET_DONE) {
+               rc = bnxt_handle_if_change_status(bp);
+               if (rc)
+                       return rc;
+       }
+
+       bnxt_enable_int(bp);
+
+       rc = bnxt_start_nic(bp);
+       if (rc)
+               goto error;
+
+       eth_dev->data->scattered_rx = bnxt_scattered_rx(eth_dev);
+       eth_dev->data->dev_started = 1;
+
+       bnxt_link_update_op(eth_dev, 1);
+
+       if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
+               vlan_mask |= ETH_VLAN_FILTER_MASK;
+       if (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
+               vlan_mask |= ETH_VLAN_STRIP_MASK;
+       rc = bnxt_vlan_offload_set_op(eth_dev, vlan_mask);
+       if (rc)
+               goto error;
+
+       /* Initialize bnxt ULP port details */
+       rc = bnxt_ulp_port_init(bp);
+       if (rc)
+               goto error;
+
+       eth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev);
+       eth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);
+
+       bnxt_schedule_fw_health_check(bp);
+
+       return 0;
+
+error:
+       bnxt_dev_stop(eth_dev);
+       return rc;
+}
+
+static void
+bnxt_uninit_locks(struct bnxt *bp)
+{
+       pthread_mutex_destroy(&bp->flow_lock);
+       pthread_mutex_destroy(&bp->def_cp_lock);
+       pthread_mutex_destroy(&bp->health_check_lock);
+       pthread_mutex_destroy(&bp->err_recovery_lock);
+       if (bp->rep_info) {
+               pthread_mutex_destroy(&bp->rep_info->vfr_lock);
+               pthread_mutex_destroy(&bp->rep_info->vfr_start_lock);
+       }
+}
 
+static void bnxt_drv_uninit(struct bnxt *bp)
+{
+       bnxt_free_switch_domain(bp);
        bnxt_free_leds_info(bp);
        bnxt_free_cos_queues(bp);
        bnxt_free_link_info(bp);
        bnxt_free_pf_info(bp);
        bnxt_free_parent_info(bp);
+       bnxt_uninit_locks(bp);
 
        rte_memzone_free((const struct rte_memzone *)bp->tx_mem_zone);
        bp->tx_mem_zone = NULL;
@@ -1451,6 +1484,36 @@ static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)
 
        rte_free(bp->grp_info);
        bp->grp_info = NULL;
+}
+
+static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)
+{
+       struct bnxt *bp = eth_dev->data->dev_private;
+       int ret = 0;
+
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
+
+       pthread_mutex_lock(&bp->err_recovery_lock);
+       if (bp->flags & BNXT_FLAG_FW_RESET) {
+               PMD_DRV_LOG(ERR,
+                           "Adapter recovering from error...Please retry\n");
+               pthread_mutex_unlock(&bp->err_recovery_lock);
+               return -EAGAIN;
+       }
+       pthread_mutex_unlock(&bp->err_recovery_lock);
+
+       /* cancel the recovery handler before remove dev */
+       rte_eal_alarm_cancel(bnxt_dev_reset_and_resume, (void *)bp);
+       rte_eal_alarm_cancel(bnxt_dev_recover, (void *)bp);
+       bnxt_cancel_fc_thread(bp);
+
+       if (eth_dev->data->dev_started)
+               ret = bnxt_dev_stop(eth_dev);
+
+       bnxt_uninit_resources(bp, false);
+
+       bnxt_drv_uninit(bp);
 
        return ret;
 }
@@ -1547,7 +1610,7 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev,
        if (rc)
                return rc;
 
-       if (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp)) {
+       if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
                PMD_DRV_LOG(ERR, "Cannot add MAC address to a VF interface\n");
                return -ENOTSUP;
        }
@@ -1605,7 +1668,7 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)
 out:
        /* Timed out or success */
        if (new.link_status != eth_dev->data->dev_link.link_status ||
-       new.link_speed != eth_dev->data->dev_link.link_speed) {
+           new.link_speed != eth_dev->data->dev_link.link_speed) {
                rte_eth_linkstatus_set(eth_dev, &new);
 
                rte_eth_dev_callback_process(eth_dev,
@@ -1808,7 +1871,7 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,
                        return -EINVAL;
                }
 
-               if (BNXT_CHIP_THOR(bp)) {
+               if (BNXT_CHIP_P5(bp)) {
                        vnic->rss_table[i * 2] =
                                rxq->rx_ring->rx_ring_struct->fw_ring_id;
                        vnic->rss_table[i * 2 + 1] =
@@ -1819,8 +1882,8 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,
                }
        }
 
-       bnxt_hwrm_vnic_rss_cfg(bp, vnic);
-       return 0;
+       rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic);
+       return rc;
 }
 
 static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev,
@@ -1857,7 +1920,7 @@ static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev,
                if (reta_conf[idx].mask & (1ULL << sft)) {
                        uint16_t qid;
 
-                       if (BNXT_CHIP_THOR(bp))
+                       if (BNXT_CHIP_P5(bp))
                                qid = bnxt_rss_to_qid(bp,
                                                      vnic->rss_table[i * 2]);
                        else
@@ -1925,8 +1988,8 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev,
        memcpy(vnic->rss_hash_key, rss_conf->rss_key, rss_conf->rss_key_len);
 
 rss_config:
-       bnxt_hwrm_vnic_rss_cfg(bp, vnic);
-       return 0;
+       rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic);
+       return rc;
 }
 
 static int bnxt_rss_hash_conf_get_op(struct rte_eth_dev *eth_dev,
@@ -2990,805 +3053,16 @@ bnxt_tx_descriptor_status_op(void *tx_queue, uint16_t offset)
        return RTE_ETH_TX_DESC_FULL;
 }
 
-static struct bnxt_filter_info *
-bnxt_match_and_validate_ether_filter(struct bnxt *bp,
-                               struct rte_eth_ethertype_filter *efilter,
-                               struct bnxt_vnic_info *vnic0,
-                               struct bnxt_vnic_info *vnic,
-                               int *ret)
-{
-       struct bnxt_filter_info *mfilter = NULL;
-       int match = 0;
-       *ret = 0;
-
-       if (efilter->ether_type == RTE_ETHER_TYPE_IPV4 ||
-               efilter->ether_type == RTE_ETHER_TYPE_IPV6) {
-               PMD_DRV_LOG(ERR, "invalid ether_type(0x%04x) in"
-                       " ethertype filter.", efilter->ether_type);
-               *ret = -EINVAL;
-               goto exit;
-       }
-       if (efilter->queue >= bp->rx_nr_rings) {
-               PMD_DRV_LOG(ERR, "Invalid queue %d\n", efilter->queue);
-               *ret = -EINVAL;
-               goto exit;
-       }
-
-       vnic0 = BNXT_GET_DEFAULT_VNIC(bp);
-       vnic = &bp->vnic_info[efilter->queue];
-       if (vnic == NULL) {
-               PMD_DRV_LOG(ERR, "Invalid queue %d\n", efilter->queue);
-               *ret = -EINVAL;
-               goto exit;
-       }
-
-       if (efilter->flags & RTE_ETHTYPE_FLAGS_DROP) {
-               STAILQ_FOREACH(mfilter, &vnic0->filter, next) {
-                       if ((!memcmp(efilter->mac_addr.addr_bytes,
-                                    mfilter->l2_addr, RTE_ETHER_ADDR_LEN) &&
-                            mfilter->flags ==
-                            HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP &&
-                            mfilter->ethertype == efilter->ether_type)) {
-                               match = 1;
-                               break;
-                       }
-               }
-       } else {
-               STAILQ_FOREACH(mfilter, &vnic->filter, next)
-                       if ((!memcmp(efilter->mac_addr.addr_bytes,
-                                    mfilter->l2_addr, RTE_ETHER_ADDR_LEN) &&
-                            mfilter->ethertype == efilter->ether_type &&
-                            mfilter->flags ==
-                            HWRM_CFA_L2_FILTER_CFG_INPUT_FLAGS_PATH_RX)) {
-                               match = 1;
-                               break;
-                       }
-       }
-
-       if (match)
-               *ret = -EEXIST;
-
-exit:
-       return mfilter;
-}
-
-static int
-bnxt_ethertype_filter(struct rte_eth_dev *dev,
-                       enum rte_filter_op filter_op,
-                       void *arg)
+int
+bnxt_filter_ctrl_op(struct rte_eth_dev *dev,
+                   enum rte_filter_type filter_type,
+                   enum rte_filter_op filter_op, void *arg)
 {
        struct bnxt *bp = dev->data->dev_private;
-       struct rte_eth_ethertype_filter *efilter =
-                       (struct rte_eth_ethertype_filter *)arg;
-       struct bnxt_filter_info *bfilter, *filter1;
-       struct bnxt_vnic_info *vnic, *vnic0;
-       int ret;
-
-       if (filter_op == RTE_ETH_FILTER_NOP)
-               return 0;
-
-       if (arg == NULL) {
-               PMD_DRV_LOG(ERR, "arg shouldn't be NULL for operation %u.",
-                           filter_op);
-               return -EINVAL;
-       }
-
-       vnic0 = BNXT_GET_DEFAULT_VNIC(bp);
-       vnic = &bp->vnic_info[efilter->queue];
-
-       switch (filter_op) {
-       case RTE_ETH_FILTER_ADD:
-               bnxt_match_and_validate_ether_filter(bp, efilter,
-                                                       vnic0, vnic, &ret);
-               if (ret < 0)
-                       return ret;
+       int ret = 0;
 
-               bfilter = bnxt_get_unused_filter(bp);
-               if (bfilter == NULL) {
-                       PMD_DRV_LOG(ERR,
-                               "Not enough resources for a new filter.\n");
-                       return -ENOMEM;
-               }
-               bfilter->filter_type = HWRM_CFA_NTUPLE_FILTER;
-               memcpy(bfilter->l2_addr, efilter->mac_addr.addr_bytes,
-                      RTE_ETHER_ADDR_LEN);
-               memcpy(bfilter->dst_macaddr, efilter->mac_addr.addr_bytes,
-                      RTE_ETHER_ADDR_LEN);
-               bfilter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR;
-               bfilter->ethertype = efilter->ether_type;
-               bfilter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
-
-               filter1 = bnxt_get_l2_filter(bp, bfilter, vnic0);
-               if (filter1 == NULL) {
-                       ret = -EINVAL;
-                       goto cleanup;
-               }
-               bfilter->enables |=
-                       HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
-               bfilter->fw_l2_filter_id = filter1->fw_l2_filter_id;
-
-               bfilter->dst_id = vnic->fw_vnic_id;
-
-               if (efilter->flags & RTE_ETHTYPE_FLAGS_DROP) {
-                       bfilter->flags =
-                               HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;
-               }
-
-               ret = bnxt_hwrm_set_ntuple_filter(bp, bfilter->dst_id, bfilter);
-               if (ret)
-                       goto cleanup;
-               STAILQ_INSERT_TAIL(&vnic->filter, bfilter, next);
-               break;
-       case RTE_ETH_FILTER_DELETE:
-               filter1 = bnxt_match_and_validate_ether_filter(bp, efilter,
-                                                       vnic0, vnic, &ret);
-               if (ret == -EEXIST) {
-                       ret = bnxt_hwrm_clear_ntuple_filter(bp, filter1);
-
-                       STAILQ_REMOVE(&vnic->filter, filter1, bnxt_filter_info,
-                                     next);
-                       bnxt_free_filter(bp, filter1);
-               } else if (ret == 0) {
-                       PMD_DRV_LOG(ERR, "No matching filter found\n");
-               }
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "unsupported operation %u.", filter_op);
-               ret = -EINVAL;
-               goto error;
-       }
-       return ret;
-cleanup:
-       bnxt_free_filter(bp, bfilter);
-error:
-       return ret;
-}
-
-static inline int
-parse_ntuple_filter(struct bnxt *bp,
-                   struct rte_eth_ntuple_filter *nfilter,
-                   struct bnxt_filter_info *bfilter)
-{
-       uint32_t en = 0;
-
-       if (nfilter->queue >= bp->rx_nr_rings) {
-               PMD_DRV_LOG(ERR, "Invalid queue %d\n", nfilter->queue);
-               return -EINVAL;
-       }
-
-       switch (nfilter->dst_port_mask) {
-       case UINT16_MAX:
-               bfilter->dst_port_mask = -1;
-               bfilter->dst_port = nfilter->dst_port;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT |
-                       NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "invalid dst_port mask.");
-               return -EINVAL;
-       }
-
-       bfilter->ip_addr_type = NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
-       en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
-
-       switch (nfilter->proto_mask) {
-       case UINT8_MAX:
-               if (nfilter->proto == 17) /* IPPROTO_UDP */
-                       bfilter->ip_protocol = 17;
-               else if (nfilter->proto == 6) /* IPPROTO_TCP */
-                       bfilter->ip_protocol = 6;
-               else
-                       return -EINVAL;
-               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "invalid protocol mask.");
-               return -EINVAL;
-       }
-
-       switch (nfilter->dst_ip_mask) {
-       case UINT32_MAX:
-               bfilter->dst_ipaddr_mask[0] = -1;
-               bfilter->dst_ipaddr[0] = nfilter->dst_ip;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR |
-                       NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "invalid dst_ip mask.");
-               return -EINVAL;
-       }
-
-       switch (nfilter->src_ip_mask) {
-       case UINT32_MAX:
-               bfilter->src_ipaddr_mask[0] = -1;
-               bfilter->src_ipaddr[0] = nfilter->src_ip;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR |
-                       NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "invalid src_ip mask.");
-               return -EINVAL;
-       }
-
-       switch (nfilter->src_port_mask) {
-       case UINT16_MAX:
-               bfilter->src_port_mask = -1;
-               bfilter->src_port = nfilter->src_port;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT |
-                       NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "invalid src_port mask.");
-               return -EINVAL;
-       }
-
-       bfilter->enables = en;
-       return 0;
-}
-
-static struct bnxt_filter_info*
-bnxt_match_ntuple_filter(struct bnxt *bp,
-                        struct bnxt_filter_info *bfilter,
-                        struct bnxt_vnic_info **mvnic)
-{
-       struct bnxt_filter_info *mfilter = NULL;
-       int i;
-
-       for (i = bp->nr_vnics - 1; i >= 0; i--) {
-               struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
-               STAILQ_FOREACH(mfilter, &vnic->filter, next) {
-                       if (bfilter->src_ipaddr[0] == mfilter->src_ipaddr[0] &&
-                           bfilter->src_ipaddr_mask[0] ==
-                           mfilter->src_ipaddr_mask[0] &&
-                           bfilter->src_port == mfilter->src_port &&
-                           bfilter->src_port_mask == mfilter->src_port_mask &&
-                           bfilter->dst_ipaddr[0] == mfilter->dst_ipaddr[0] &&
-                           bfilter->dst_ipaddr_mask[0] ==
-                           mfilter->dst_ipaddr_mask[0] &&
-                           bfilter->dst_port == mfilter->dst_port &&
-                           bfilter->dst_port_mask == mfilter->dst_port_mask &&
-                           bfilter->flags == mfilter->flags &&
-                           bfilter->enables == mfilter->enables) {
-                               if (mvnic)
-                                       *mvnic = vnic;
-                               return mfilter;
-                       }
-               }
-       }
-       return NULL;
-}
-
-static int
-bnxt_cfg_ntuple_filter(struct bnxt *bp,
-                      struct rte_eth_ntuple_filter *nfilter,
-                      enum rte_filter_op filter_op)
-{
-       struct bnxt_filter_info *bfilter, *mfilter, *filter1;
-       struct bnxt_vnic_info *vnic, *vnic0, *mvnic;
-       int ret;
-
-       if (nfilter->flags != RTE_5TUPLE_FLAGS) {
-               PMD_DRV_LOG(ERR, "only 5tuple is supported.");
-               return -EINVAL;
-       }
-
-       if (nfilter->flags & RTE_NTUPLE_FLAGS_TCP_FLAG) {
-               PMD_DRV_LOG(ERR, "Ntuple filter: TCP flags not supported\n");
-               return -EINVAL;
-       }
-
-       bfilter = bnxt_get_unused_filter(bp);
-       if (bfilter == NULL) {
-               PMD_DRV_LOG(ERR,
-                       "Not enough resources for a new filter.\n");
-               return -ENOMEM;
-       }
-       ret = parse_ntuple_filter(bp, nfilter, bfilter);
-       if (ret < 0)
-               goto free_filter;
-
-       vnic = &bp->vnic_info[nfilter->queue];
-       vnic0 = BNXT_GET_DEFAULT_VNIC(bp);
-       filter1 = STAILQ_FIRST(&vnic0->filter);
-       if (filter1 == NULL) {
-               ret = -EINVAL;
-               goto free_filter;
-       }
-
-       bfilter->dst_id = vnic->fw_vnic_id;
-       bfilter->fw_l2_filter_id = filter1->fw_l2_filter_id;
-       bfilter->enables |=
-               HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
-       bfilter->ethertype = 0x800;
-       bfilter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
-
-       mfilter = bnxt_match_ntuple_filter(bp, bfilter, &mvnic);
-
-       if (mfilter != NULL && filter_op == RTE_ETH_FILTER_ADD &&
-           bfilter->dst_id == mfilter->dst_id) {
-               PMD_DRV_LOG(ERR, "filter exists.\n");
-               ret = -EEXIST;
-               goto free_filter;
-       } else if (mfilter != NULL && filter_op == RTE_ETH_FILTER_ADD &&
-                  bfilter->dst_id != mfilter->dst_id) {
-               mfilter->dst_id = vnic->fw_vnic_id;
-               ret = bnxt_hwrm_set_ntuple_filter(bp, mfilter->dst_id, mfilter);
-               STAILQ_REMOVE(&mvnic->filter, mfilter, bnxt_filter_info, next);
-               STAILQ_INSERT_TAIL(&vnic->filter, mfilter, next);
-               PMD_DRV_LOG(ERR, "filter with matching pattern exists.\n");
-               PMD_DRV_LOG(ERR, " Updated it to the new destination queue\n");
-               goto free_filter;
-       }
-       if (mfilter == NULL && filter_op == RTE_ETH_FILTER_DELETE) {
-               PMD_DRV_LOG(ERR, "filter doesn't exist.");
-               ret = -ENOENT;
-               goto free_filter;
-       }
-
-       if (filter_op == RTE_ETH_FILTER_ADD) {
-               bfilter->filter_type = HWRM_CFA_NTUPLE_FILTER;
-               ret = bnxt_hwrm_set_ntuple_filter(bp, bfilter->dst_id, bfilter);
-               if (ret)
-                       goto free_filter;
-               STAILQ_INSERT_TAIL(&vnic->filter, bfilter, next);
-       } else {
-               if (mfilter == NULL) {
-                       /* This should not happen. But for Coverity! */
-                       ret = -ENOENT;
-                       goto free_filter;
-               }
-               ret = bnxt_hwrm_clear_ntuple_filter(bp, mfilter);
-
-               STAILQ_REMOVE(&vnic->filter, mfilter, bnxt_filter_info, next);
-               bnxt_free_filter(bp, mfilter);
-               bnxt_free_filter(bp, bfilter);
-       }
-
-       return 0;
-free_filter:
-       bnxt_free_filter(bp, bfilter);
-       return ret;
-}
-
-static int
-bnxt_ntuple_filter(struct rte_eth_dev *dev,
-                       enum rte_filter_op filter_op,
-                       void *arg)
-{
-       struct bnxt *bp = dev->data->dev_private;
-       int ret;
-
-       if (filter_op == RTE_ETH_FILTER_NOP)
-               return 0;
-
-       if (arg == NULL) {
-               PMD_DRV_LOG(ERR, "arg shouldn't be NULL for operation %u.",
-                           filter_op);
-               return -EINVAL;
-       }
-
-       switch (filter_op) {
-       case RTE_ETH_FILTER_ADD:
-               ret = bnxt_cfg_ntuple_filter(bp,
-                       (struct rte_eth_ntuple_filter *)arg,
-                       filter_op);
-               break;
-       case RTE_ETH_FILTER_DELETE:
-               ret = bnxt_cfg_ntuple_filter(bp,
-                       (struct rte_eth_ntuple_filter *)arg,
-                       filter_op);
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "unsupported operation %u.", filter_op);
-               ret = -EINVAL;
-               break;
-       }
-       return ret;
-}
-
-static int
-bnxt_parse_fdir_filter(struct bnxt *bp,
-                      struct rte_eth_fdir_filter *fdir,
-                      struct bnxt_filter_info *filter)
-{
-       enum rte_fdir_mode fdir_mode =
-               bp->eth_dev->data->dev_conf.fdir_conf.mode;
-       struct bnxt_vnic_info *vnic0, *vnic;
-       struct bnxt_filter_info *filter1;
-       uint32_t en = 0;
-       int i;
-
-       if (fdir_mode == RTE_FDIR_MODE_PERFECT_TUNNEL)
-               return -EINVAL;
-
-       filter->l2_ovlan = fdir->input.flow_ext.vlan_tci;
-       en |= EM_FLOW_ALLOC_INPUT_EN_OVLAN_VID;
-
-       switch (fdir->input.flow_type) {
-       case RTE_ETH_FLOW_IPV4:
-       case RTE_ETH_FLOW_NONFRAG_IPV4_OTHER:
-               /* FALLTHROUGH */
-               filter->src_ipaddr[0] = fdir->input.flow.ip4_flow.src_ip;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
-               filter->dst_ipaddr[0] = fdir->input.flow.ip4_flow.dst_ip;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
-               filter->ip_protocol = fdir->input.flow.ip4_flow.proto;
-               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
-               filter->ip_addr_type =
-                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
-               filter->src_ipaddr_mask[0] = 0xffffffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
-               filter->dst_ipaddr_mask[0] = 0xffffffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
-               filter->ethertype = 0x800;
-               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
-               break;
-       case RTE_ETH_FLOW_NONFRAG_IPV4_TCP:
-               filter->src_port = fdir->input.flow.tcp4_flow.src_port;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
-               filter->dst_port = fdir->input.flow.tcp4_flow.dst_port;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
-               filter->dst_port_mask = 0xffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
-               filter->src_port_mask = 0xffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
-               filter->src_ipaddr[0] = fdir->input.flow.tcp4_flow.ip.src_ip;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
-               filter->dst_ipaddr[0] = fdir->input.flow.tcp4_flow.ip.dst_ip;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
-               filter->ip_protocol = 6;
-               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
-               filter->ip_addr_type =
-                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
-               filter->src_ipaddr_mask[0] = 0xffffffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
-               filter->dst_ipaddr_mask[0] = 0xffffffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
-               filter->ethertype = 0x800;
-               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
-               break;
-       case RTE_ETH_FLOW_NONFRAG_IPV4_UDP:
-               filter->src_port = fdir->input.flow.udp4_flow.src_port;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
-               filter->dst_port = fdir->input.flow.udp4_flow.dst_port;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
-               filter->dst_port_mask = 0xffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
-               filter->src_port_mask = 0xffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
-               filter->src_ipaddr[0] = fdir->input.flow.udp4_flow.ip.src_ip;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
-               filter->dst_ipaddr[0] = fdir->input.flow.udp4_flow.ip.dst_ip;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
-               filter->ip_protocol = 17;
-               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
-               filter->ip_addr_type =
-                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV4;
-               filter->src_ipaddr_mask[0] = 0xffffffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
-               filter->dst_ipaddr_mask[0] = 0xffffffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
-               filter->ethertype = 0x800;
-               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
-               break;
-       case RTE_ETH_FLOW_IPV6:
-       case RTE_ETH_FLOW_NONFRAG_IPV6_OTHER:
-               /* FALLTHROUGH */
-               filter->ip_addr_type =
-                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
-               filter->ip_protocol = fdir->input.flow.ipv6_flow.proto;
-               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
-               rte_memcpy(filter->src_ipaddr,
-                          fdir->input.flow.ipv6_flow.src_ip, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
-               rte_memcpy(filter->dst_ipaddr,
-                          fdir->input.flow.ipv6_flow.dst_ip, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
-               memset(filter->dst_ipaddr_mask, 0xff, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
-               memset(filter->src_ipaddr_mask, 0xff, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
-               filter->ethertype = 0x86dd;
-               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
-               break;
-       case RTE_ETH_FLOW_NONFRAG_IPV6_TCP:
-               filter->src_port = fdir->input.flow.tcp6_flow.src_port;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
-               filter->dst_port = fdir->input.flow.tcp6_flow.dst_port;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
-               filter->dst_port_mask = 0xffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
-               filter->src_port_mask = 0xffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
-               filter->ip_addr_type =
-                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
-               filter->ip_protocol = fdir->input.flow.tcp6_flow.ip.proto;
-               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
-               rte_memcpy(filter->src_ipaddr,
-                          fdir->input.flow.tcp6_flow.ip.src_ip, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
-               rte_memcpy(filter->dst_ipaddr,
-                          fdir->input.flow.tcp6_flow.ip.dst_ip, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
-               memset(filter->dst_ipaddr_mask, 0xff, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
-               memset(filter->src_ipaddr_mask, 0xff, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
-               filter->ethertype = 0x86dd;
-               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
-               break;
-       case RTE_ETH_FLOW_NONFRAG_IPV6_UDP:
-               filter->src_port = fdir->input.flow.udp6_flow.src_port;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT;
-               filter->dst_port = fdir->input.flow.udp6_flow.dst_port;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT;
-               filter->dst_port_mask = 0xffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_PORT_MASK;
-               filter->src_port_mask = 0xffff;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_PORT_MASK;
-               filter->ip_addr_type =
-                       NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6;
-               filter->ip_protocol = fdir->input.flow.udp6_flow.ip.proto;
-               en |= NTUPLE_FLTR_ALLOC_IN_EN_IP_PROTO;
-               rte_memcpy(filter->src_ipaddr,
-                          fdir->input.flow.udp6_flow.ip.src_ip, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR;
-               rte_memcpy(filter->dst_ipaddr,
-                          fdir->input.flow.udp6_flow.ip.dst_ip, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR;
-               memset(filter->dst_ipaddr_mask, 0xff, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
-               memset(filter->src_ipaddr_mask, 0xff, 16);
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
-               filter->ethertype = 0x86dd;
-               filter->enables |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
-               break;
-       case RTE_ETH_FLOW_L2_PAYLOAD:
-               filter->ethertype = fdir->input.flow.l2_flow.ether_type;
-               en |= NTUPLE_FLTR_ALLOC_INPUT_EN_ETHERTYPE;
-               break;
-       case RTE_ETH_FLOW_VXLAN:
-               if (fdir->action.behavior == RTE_ETH_FDIR_REJECT)
-                       return -EINVAL;
-               filter->vni = fdir->input.flow.tunnel_flow.tunnel_id;
-               filter->tunnel_type =
-                       CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_VXLAN;
-               en |= HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_TUNNEL_TYPE;
-               break;
-       case RTE_ETH_FLOW_NVGRE:
-               if (fdir->action.behavior == RTE_ETH_FDIR_REJECT)
-                       return -EINVAL;
-               filter->vni = fdir->input.flow.tunnel_flow.tunnel_id;
-               filter->tunnel_type =
-                       CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE;
-               en |= HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_TUNNEL_TYPE;
-               break;
-       case RTE_ETH_FLOW_UNKNOWN:
-       case RTE_ETH_FLOW_RAW:
-       case RTE_ETH_FLOW_FRAG_IPV4:
-       case RTE_ETH_FLOW_NONFRAG_IPV4_SCTP:
-       case RTE_ETH_FLOW_FRAG_IPV6:
-       case RTE_ETH_FLOW_NONFRAG_IPV6_SCTP:
-       case RTE_ETH_FLOW_IPV6_EX:
-       case RTE_ETH_FLOW_IPV6_TCP_EX:
-       case RTE_ETH_FLOW_IPV6_UDP_EX:
-       case RTE_ETH_FLOW_GENEVE:
-               /* FALLTHROUGH */
-       default:
-               return -EINVAL;
-       }
-
-       vnic0 = BNXT_GET_DEFAULT_VNIC(bp);
-       vnic = &bp->vnic_info[fdir->action.rx_queue];
-       if (vnic == NULL) {
-               PMD_DRV_LOG(ERR, "Invalid queue %d\n", fdir->action.rx_queue);
-               return -EINVAL;
-       }
-
-       if (fdir_mode == RTE_FDIR_MODE_PERFECT_MAC_VLAN) {
-               rte_memcpy(filter->dst_macaddr,
-                       fdir->input.flow.mac_vlan_flow.mac_addr.addr_bytes, 6);
-                       en |= NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR;
-       }
-
-       if (fdir->action.behavior == RTE_ETH_FDIR_REJECT) {
-               filter->flags = HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;
-               filter1 = STAILQ_FIRST(&vnic0->filter);
-               //filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
-       } else {
-               filter->dst_id = vnic->fw_vnic_id;
-               for (i = 0; i < RTE_ETHER_ADDR_LEN; i++)
-                       if (filter->dst_macaddr[i] == 0x00)
-                               filter1 = STAILQ_FIRST(&vnic0->filter);
-                       else
-                               filter1 = bnxt_get_l2_filter(bp, filter, vnic);
-       }
-
-       if (filter1 == NULL)
-               return -EINVAL;
-
-       en |= HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_ENABLES_L2_FILTER_ID;
-       filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
-
-       filter->enables = en;
-
-       return 0;
-}
-
-static struct bnxt_filter_info *
-bnxt_match_fdir(struct bnxt *bp, struct bnxt_filter_info *nf,
-               struct bnxt_vnic_info **mvnic)
-{
-       struct bnxt_filter_info *mf = NULL;
-       int i;
-
-       for (i = bp->nr_vnics - 1; i >= 0; i--) {
-               struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
-
-               STAILQ_FOREACH(mf, &vnic->filter, next) {
-                       if (mf->filter_type == nf->filter_type &&
-                           mf->flags == nf->flags &&
-                           mf->src_port == nf->src_port &&
-                           mf->src_port_mask == nf->src_port_mask &&
-                           mf->dst_port == nf->dst_port &&
-                           mf->dst_port_mask == nf->dst_port_mask &&
-                           mf->ip_protocol == nf->ip_protocol &&
-                           mf->ip_addr_type == nf->ip_addr_type &&
-                           mf->ethertype == nf->ethertype &&
-                           mf->vni == nf->vni &&
-                           mf->tunnel_type == nf->tunnel_type &&
-                           mf->l2_ovlan == nf->l2_ovlan &&
-                           mf->l2_ovlan_mask == nf->l2_ovlan_mask &&
-                           mf->l2_ivlan == nf->l2_ivlan &&
-                           mf->l2_ivlan_mask == nf->l2_ivlan_mask &&
-                           !memcmp(mf->l2_addr, nf->l2_addr,
-                                   RTE_ETHER_ADDR_LEN) &&
-                           !memcmp(mf->l2_addr_mask, nf->l2_addr_mask,
-                                   RTE_ETHER_ADDR_LEN) &&
-                           !memcmp(mf->src_macaddr, nf->src_macaddr,
-                                   RTE_ETHER_ADDR_LEN) &&
-                           !memcmp(mf->dst_macaddr, nf->dst_macaddr,
-                                   RTE_ETHER_ADDR_LEN) &&
-                           !memcmp(mf->src_ipaddr, nf->src_ipaddr,
-                                   sizeof(nf->src_ipaddr)) &&
-                           !memcmp(mf->src_ipaddr_mask, nf->src_ipaddr_mask,
-                                   sizeof(nf->src_ipaddr_mask)) &&
-                           !memcmp(mf->dst_ipaddr, nf->dst_ipaddr,
-                                   sizeof(nf->dst_ipaddr)) &&
-                           !memcmp(mf->dst_ipaddr_mask, nf->dst_ipaddr_mask,
-                                   sizeof(nf->dst_ipaddr_mask))) {
-                               if (mvnic)
-                                       *mvnic = vnic;
-                               return mf;
-                       }
-               }
-       }
-       return NULL;
-}
-
-static int
-bnxt_fdir_filter(struct rte_eth_dev *dev,
-                enum rte_filter_op filter_op,
-                void *arg)
-{
-       struct bnxt *bp = dev->data->dev_private;
-       struct rte_eth_fdir_filter *fdir  = (struct rte_eth_fdir_filter *)arg;
-       struct bnxt_filter_info *filter, *match;
-       struct bnxt_vnic_info *vnic, *mvnic;
-       int ret = 0, i;
-
-       if (filter_op == RTE_ETH_FILTER_NOP)
-               return 0;
-
-       if (arg == NULL && filter_op != RTE_ETH_FILTER_FLUSH)
-               return -EINVAL;
-
-       switch (filter_op) {
-       case RTE_ETH_FILTER_ADD:
-       case RTE_ETH_FILTER_DELETE:
-               /* FALLTHROUGH */
-               filter = bnxt_get_unused_filter(bp);
-               if (filter == NULL) {
-                       PMD_DRV_LOG(ERR,
-                               "Not enough resources for a new flow.\n");
-                       return -ENOMEM;
-               }
-
-               ret = bnxt_parse_fdir_filter(bp, fdir, filter);
-               if (ret != 0)
-                       goto free_filter;
-               filter->filter_type = HWRM_CFA_NTUPLE_FILTER;
-
-               if (fdir->action.behavior == RTE_ETH_FDIR_REJECT)
-                       vnic = &bp->vnic_info[0];
-               else
-                       vnic = &bp->vnic_info[fdir->action.rx_queue];
-
-               match = bnxt_match_fdir(bp, filter, &mvnic);
-               if (match != NULL && filter_op == RTE_ETH_FILTER_ADD) {
-                       if (match->dst_id == vnic->fw_vnic_id) {
-                               PMD_DRV_LOG(ERR, "Flow already exists.\n");
-                               ret = -EEXIST;
-                               goto free_filter;
-                       } else {
-                               match->dst_id = vnic->fw_vnic_id;
-                               ret = bnxt_hwrm_set_ntuple_filter(bp,
-                                                                 match->dst_id,
-                                                                 match);
-                               STAILQ_REMOVE(&mvnic->filter, match,
-                                             bnxt_filter_info, next);
-                               STAILQ_INSERT_TAIL(&vnic->filter, match, next);
-                               PMD_DRV_LOG(ERR,
-                                       "Filter with matching pattern exist\n");
-                               PMD_DRV_LOG(ERR,
-                                       "Updated it to new destination q\n");
-                               goto free_filter;
-                       }
-               }
-               if (match == NULL && filter_op == RTE_ETH_FILTER_DELETE) {
-                       PMD_DRV_LOG(ERR, "Flow does not exist.\n");
-                       ret = -ENOENT;
-                       goto free_filter;
-               }
-
-               if (filter_op == RTE_ETH_FILTER_ADD) {
-                       ret = bnxt_hwrm_set_ntuple_filter(bp,
-                                                         filter->dst_id,
-                                                         filter);
-                       if (ret)
-                               goto free_filter;
-                       STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
-               } else {
-                       ret = bnxt_hwrm_clear_ntuple_filter(bp, match);
-                       STAILQ_REMOVE(&vnic->filter, match,
-                                     bnxt_filter_info, next);
-                       bnxt_free_filter(bp, match);
-                       bnxt_free_filter(bp, filter);
-               }
-               break;
-       case RTE_ETH_FILTER_FLUSH:
-               for (i = bp->nr_vnics - 1; i >= 0; i--) {
-                       struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
-
-                       STAILQ_FOREACH(filter, &vnic->filter, next) {
-                               if (filter->filter_type ==
-                                   HWRM_CFA_NTUPLE_FILTER) {
-                                       ret =
-                                       bnxt_hwrm_clear_ntuple_filter(bp,
-                                                                     filter);
-                                       STAILQ_REMOVE(&vnic->filter, filter,
-                                                     bnxt_filter_info, next);
-                               }
-                       }
-               }
-               return ret;
-       case RTE_ETH_FILTER_UPDATE:
-       case RTE_ETH_FILTER_STATS:
-       case RTE_ETH_FILTER_INFO:
-               PMD_DRV_LOG(ERR, "operation %u not implemented", filter_op);
-               break;
-       default:
-               PMD_DRV_LOG(ERR, "unknown operation %u", filter_op);
-               ret = -EINVAL;
-               break;
-       }
-       return ret;
-
-free_filter:
-       bnxt_free_filter(bp, filter);
-       return ret;
-}
-
-int
-bnxt_filter_ctrl_op(struct rte_eth_dev *dev,
-                   enum rte_filter_type filter_type,
-                   enum rte_filter_op filter_op, void *arg)
-{
-       struct bnxt *bp = dev->data->dev_private;
-       int ret = 0;
-
-       if (!bp)
-               return -EIO;
+       if (!bp)
+               return -EIO;
 
        if (BNXT_ETH_DEV_IS_REPRESENTOR(dev)) {
                struct bnxt_representor *vfr = dev->data->dev_private;
@@ -3808,22 +3082,15 @@ bnxt_filter_ctrl_op(struct rte_eth_dev *dev,
                return ret;
 
        switch (filter_type) {
-       case RTE_ETH_FILTER_TUNNEL:
-               PMD_DRV_LOG(ERR,
-                       "filter type: %d: To be implemented\n", filter_type);
-               break;
-       case RTE_ETH_FILTER_FDIR:
-               ret = bnxt_fdir_filter(dev, filter_op, arg);
-               break;
-       case RTE_ETH_FILTER_NTUPLE:
-               ret = bnxt_ntuple_filter(dev, filter_op, arg);
-               break;
-       case RTE_ETH_FILTER_ETHERTYPE:
-               ret = bnxt_ethertype_filter(dev, filter_op, arg);
-               break;
        case RTE_ETH_FILTER_GENERIC:
                if (filter_op != RTE_ETH_FILTER_GET)
                        return -EINVAL;
+
+               /* PMD supports thread-safe flow operations.  rte_flow API
+                * functions can avoid mutex for multi-thread safety.
+                */
+               dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE;
+
                if (BNXT_TRUFLOW_EN(bp))
                        *(const void **)arg = &bnxt_ulp_rte_flow_ops;
                else
@@ -4004,7 +3271,7 @@ bnxt_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts)
        if (!ptp)
                return 0;
 
-       if (BNXT_CHIP_THOR(bp))
+       if (BNXT_CHIP_P5(bp))
                rc = bnxt_hwrm_port_ts_query(bp, BNXT_PTP_FLAGS_CURRENT_TIME,
                                             &systime_cycles);
        else
@@ -4050,7 +3317,7 @@ bnxt_timesync_enable(struct rte_eth_dev *dev)
        ptp->tx_tstamp_tc.cc_shift = shift;
        ptp->tx_tstamp_tc.nsec_mask = (1ULL << shift) - 1;
 
-       if (!BNXT_CHIP_THOR(bp))
+       if (!BNXT_CHIP_P5(bp))
                bnxt_map_ptp_regs(bp);
 
        return 0;
@@ -4071,7 +3338,7 @@ bnxt_timesync_disable(struct rte_eth_dev *dev)
 
        bnxt_hwrm_ptp_cfg(bp);
 
-       if (!BNXT_CHIP_THOR(bp))
+       if (!BNXT_CHIP_P5(bp))
                bnxt_unmap_ptp_regs(bp);
 
        return 0;
@@ -4090,7 +3357,7 @@ bnxt_timesync_read_rx_timestamp(struct rte_eth_dev *dev,
        if (!ptp)
                return 0;
 
-       if (BNXT_CHIP_THOR(bp))
+       if (BNXT_CHIP_P5(bp))
                rx_tstamp_cycles = ptp->rx_timestamp;
        else
                bnxt_get_rx_ts(bp, &rx_tstamp_cycles);
@@ -4113,7 +3380,7 @@ bnxt_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
        if (!ptp)
                return 0;
 
-       if (BNXT_CHIP_THOR(bp))
+       if (BNXT_CHIP_P5(bp))
                rc = bnxt_hwrm_port_ts_query(bp, BNXT_PTP_FLAGS_PATH_TX,
                                             &tx_tstamp_cycles);
        else
@@ -4341,8 +3608,6 @@ static const struct eth_dev_ops bnxt_dev_ops = {
        .tx_burst_mode_get = bnxt_tx_burst_mode_get,
        .dev_led_on = bnxt_dev_led_on_op,
        .dev_led_off = bnxt_dev_led_off_op,
-       .xstats_get_by_id = bnxt_dev_xstats_get_by_id_op,
-       .xstats_get_names_by_id = bnxt_dev_xstats_get_names_by_id_op,
        .rx_queue_start = bnxt_rx_queue_start,
        .rx_queue_stop = bnxt_rx_queue_stop,
        .tx_queue_start = bnxt_tx_queue_start,
@@ -4441,7 +3706,7 @@ static void bnxt_dev_cleanup(struct bnxt *bp)
        bp->eth_dev->data->dev_link.link_status = 0;
        bp->link_info->link_up = 0;
        if (bp->eth_dev->data->dev_started)
-               bnxt_dev_stop_op(bp->eth_dev);
+               bnxt_dev_stop(bp->eth_dev);
 
        bnxt_uninit_resources(bp, true);
 }
@@ -4542,6 +3807,7 @@ static void bnxt_dev_recover(void *arg)
        int timeout = bp->fw_reset_max_msecs;
        int rc = 0;
 
+       pthread_mutex_lock(&bp->err_recovery_lock);
        /* Clear Error flag so that device re-init should happen */
        bp->flags &= ~BNXT_FLAG_FATAL_ERROR;
 
@@ -4578,12 +3844,15 @@ static void bnxt_dev_recover(void *arg)
                goto err_start;
 
        PMD_DRV_LOG(INFO, "Recovered from FW reset\n");
+       pthread_mutex_unlock(&bp->err_recovery_lock);
+
        return;
 err_start:
-       bnxt_dev_stop_op(bp->eth_dev);
+       bnxt_dev_stop(bp->eth_dev);
 err:
        bp->flags |= BNXT_FLAG_FATAL_ERROR;
        bnxt_uninit_resources(bp, false);
+       pthread_mutex_unlock(&bp->err_recovery_lock);
        PMD_DRV_LOG(ERR, "Failed to recover from FW reset\n");
 }
 
@@ -4774,6 +4043,7 @@ static bool bnxt_vf_pciid(uint16_t device_id)
        case BROADCOM_DEV_ID_58802_VF:
        case BROADCOM_DEV_ID_57500_VF1:
        case BROADCOM_DEV_ID_57500_VF2:
+       case BROADCOM_DEV_ID_58818_VF:
                /* FALLTHROUGH */
                return true;
        default:
@@ -4781,7 +4051,8 @@ static bool bnxt_vf_pciid(uint16_t device_id)
        }
 }
 
-static bool bnxt_thor_device(uint16_t device_id)
+/* Phase 5 device */
+static bool bnxt_p5_device(uint16_t device_id)
 {
        switch (device_id) {
        case BROADCOM_DEV_ID_57508:
@@ -4795,6 +4066,10 @@ static bool bnxt_thor_device(uint16_t device_id)
        case BROADCOM_DEV_ID_57502_MF2:
        case BROADCOM_DEV_ID_57500_VF1:
        case BROADCOM_DEV_ID_57500_VF2:
+       case BROADCOM_DEV_ID_58812:
+       case BROADCOM_DEV_ID_58814:
+       case BROADCOM_DEV_ID_58818:
+       case BROADCOM_DEV_ID_58818_VF:
                /* FALLTHROUGH */
                return true;
        default:
@@ -4817,7 +4092,7 @@ bool bnxt_stratus_device(struct bnxt *bp)
        }
 }
 
-static int bnxt_init_board(struct rte_eth_dev *eth_dev)
+static int bnxt_map_pci_bars(struct rte_eth_dev *eth_dev)
 {
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
        struct bnxt *bp = eth_dev->data->dev_private;
@@ -4991,39 +4266,49 @@ int bnxt_alloc_ctx_mem(struct bnxt *bp)
 
        ctx_pg = &ctx->qp_mem;
        ctx_pg->entries = ctx->qp_min_qp1_entries + ctx->qp_max_l2_entries;
-       mem_size = ctx->qp_entry_size * ctx_pg->entries;
-       rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "qp_mem", 0);
-       if (rc)
-               return rc;
+       if (ctx->qp_entry_size) {
+               mem_size = ctx->qp_entry_size * ctx_pg->entries;
+               rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "qp_mem", 0);
+               if (rc)
+                       return rc;
+       }
 
        ctx_pg = &ctx->srq_mem;
        ctx_pg->entries = ctx->srq_max_l2_entries;
-       mem_size = ctx->srq_entry_size * ctx_pg->entries;
-       rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "srq_mem", 0);
-       if (rc)
-               return rc;
+       if (ctx->srq_entry_size) {
+               mem_size = ctx->srq_entry_size * ctx_pg->entries;
+               rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "srq_mem", 0);
+               if (rc)
+                       return rc;
+       }
 
        ctx_pg = &ctx->cq_mem;
        ctx_pg->entries = ctx->cq_max_l2_entries;
-       mem_size = ctx->cq_entry_size * ctx_pg->entries;
-       rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "cq_mem", 0);
-       if (rc)
-               return rc;
+       if (ctx->cq_entry_size) {
+               mem_size = ctx->cq_entry_size * ctx_pg->entries;
+               rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "cq_mem", 0);
+               if (rc)
+                       return rc;
+       }
 
        ctx_pg = &ctx->vnic_mem;
        ctx_pg->entries = ctx->vnic_max_vnic_entries +
                ctx->vnic_max_ring_table_entries;
-       mem_size = ctx->vnic_entry_size * ctx_pg->entries;
-       rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "vnic_mem", 0);
-       if (rc)
-               return rc;
+       if (ctx->vnic_entry_size) {
+               mem_size = ctx->vnic_entry_size * ctx_pg->entries;
+               rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "vnic_mem", 0);
+               if (rc)
+                       return rc;
+       }
 
        ctx_pg = &ctx->stat_mem;
        ctx_pg->entries = ctx->stat_max_entries;
-       mem_size = ctx->stat_entry_size * ctx_pg->entries;
-       rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "stat_mem", 0);
-       if (rc)
-               return rc;
+       if (ctx->stat_entry_size) {
+               mem_size = ctx->stat_entry_size * ctx_pg->entries;
+               rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "stat_mem", 0);
+               if (rc)
+                       return rc;
+       }
 
        min = ctx->tqm_min_entries_per_ring;
 
@@ -5039,10 +4324,12 @@ int bnxt_alloc_ctx_mem(struct bnxt *bp)
        for (i = 0, ena = 0; i < ctx->tqm_fp_rings_count + 1; i++) {
                ctx_pg = ctx->tqm_mem[i];
                ctx_pg->entries = i ? entries : entries_sp;
-               mem_size = ctx->tqm_entry_size * ctx_pg->entries;
-               rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "tqm_mem", i);
-               if (rc)
-                       return rc;
+               if (ctx->tqm_entry_size) {
+                       mem_size = ctx->tqm_entry_size * ctx_pg->entries;
+                       rc = bnxt_alloc_ctx_mem_blk(bp, ctx_pg, mem_size, "tqm_mem", i);
+                       if (rc)
+                               return rc;
+               }
                ena |= HWRM_FUNC_BACKING_STORE_CFG_INPUT_ENABLES_TQM_SP << i;
        }
 
@@ -5442,7 +4729,11 @@ static int bnxt_map_hcomm_fw_status_reg(struct bnxt *bp)
        return 0;
 }
 
-static int bnxt_init_fw(struct bnxt *bp)
+/* This function gets the FW version along with the
+ * capabilities(MAX and current) of the function, vnic,
+ * error recovery, phy and other chip related info
+ */
+static int bnxt_get_config(struct bnxt *bp)
 {
        uint16_t mtu;
        int rc = 0;
@@ -5483,6 +4774,10 @@ static int bnxt_init_fw(struct bnxt *bp)
        if (rc)
                return rc;
 
+       rc = bnxt_hwrm_cfa_adv_flow_mgmt_qcaps(bp);
+       if (rc)
+               return rc;
+
        bnxt_hwrm_port_mac_qcfg(bp);
 
        bnxt_hwrm_parent_pf_qcfg(bp);
@@ -5512,12 +4807,21 @@ bnxt_init_locks(struct bnxt *bp)
        }
 
        err = pthread_mutex_init(&bp->def_cp_lock, NULL);
-       if (err)
+       if (err) {
                PMD_DRV_LOG(ERR, "Unable to initialize def_cp_lock\n");
+               return err;
+       }
 
        err = pthread_mutex_init(&bp->health_check_lock, NULL);
-       if (err)
+       if (err) {
                PMD_DRV_LOG(ERR, "Unable to initialize health_check_lock\n");
+               return err;
+       }
+
+       err = pthread_mutex_init(&bp->err_recovery_lock, NULL);
+       if (err)
+               PMD_DRV_LOG(ERR, "Unable to initialize err_recovery_lock\n");
+
        return err;
 }
 
@@ -5525,7 +4829,7 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)
 {
        int rc = 0;
 
-       rc = bnxt_init_fw(bp);
+       rc = bnxt_get_config(bp);
        if (rc)
                return rc;
 
@@ -5582,10 +4886,6 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)
                return rc;
        }
 
-       rc = bnxt_init_locks(bp);
-       if (rc)
-               return rc;
-
        return 0;
 }
 
@@ -5767,6 +5067,8 @@ bnxt_parse_devarg_rep_based_pf(__rte_unused const char *key,
        }
 
        vfr_bp->rep_based_pf = rep_based_pf;
+       vfr_bp->flags |= BNXT_REP_BASED_PF_VALID;
+
        PMD_DRV_LOG(INFO, "rep-based-pf = %d\n", vfr_bp->rep_based_pf);
 
        return 0;
@@ -5934,21 +5236,21 @@ bnxt_parse_dev_args(struct bnxt *bp, struct rte_devargs *devargs)
 
        /*
         * Handler for "truflow" devarg.
-        * Invoked as for ex: "-w 0000:00:0d.0,host-based-truflow=1"
+        * Invoked as for ex: "-a 0000:00:0d.0,host-based-truflow=1"
         */
        rte_kvargs_process(kvlist, BNXT_DEVARG_TRUFLOW,
                           bnxt_parse_devarg_truflow, bp);
 
        /*
         * Handler for "flow_xstat" devarg.
-        * Invoked as for ex: "-w 0000:00:0d.0,flow_xstat=1"
+        * Invoked as for ex: "-a 0000:00:0d.0,flow_xstat=1"
         */
        rte_kvargs_process(kvlist, BNXT_DEVARG_FLOW_XSTAT,
                           bnxt_parse_devarg_flow_xstat, bp);
 
        /*
         * Handler for "max_num_kflows" devarg.
-        * Invoked as for ex: "-w 000:00:0d.0,max_num_kflows=32"
+        * Invoked as for ex: "-a 000:00:0d.0,max_num_kflows=32"
         */
        rte_kvargs_process(kvlist, BNXT_DEVARG_MAX_NUM_KFLOWS,
                           bnxt_parse_devarg_max_num_kflows, bp);
@@ -5974,46 +5276,22 @@ static int bnxt_alloc_switch_domain(struct bnxt *bp)
        return rc;
 }
 
-static int
-bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
+/* Allocate and initialize various fields in bnxt struct that
+ * need to be allocated/destroyed only once in the lifetime of the driver
+ */
+static int bnxt_drv_init(struct rte_eth_dev *eth_dev)
 {
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
-       static int version_printed;
-       struct bnxt *bp;
-       int rc;
-
-       if (version_printed++ == 0)
-               PMD_DRV_LOG(INFO, "%s\n", bnxt_version);
-
-       eth_dev->dev_ops = &bnxt_dev_ops;
-       eth_dev->rx_queue_count = bnxt_rx_queue_count_op;
-       eth_dev->rx_descriptor_status = bnxt_rx_descriptor_status_op;
-       eth_dev->tx_descriptor_status = bnxt_tx_descriptor_status_op;
-       eth_dev->rx_pkt_burst = &bnxt_recv_pkts;
-       eth_dev->tx_pkt_burst = &bnxt_xmit_pkts;
-
-       /*
-        * For secondary processes, we don't initialise any further
-        * as primary has already done this work.
-        */
-       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
-               return 0;
-
-       rte_eth_copy_pci_info(eth_dev, pci_dev);
-       eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
-
-       bp = eth_dev->data->dev_private;
-
-       /* Parse dev arguments passed on when starting the DPDK application. */
-       bnxt_parse_dev_args(bp, pci_dev->device.devargs);
+       struct bnxt *bp = eth_dev->data->dev_private;
+       int rc = 0;
 
        bp->flags &= ~BNXT_FLAG_RX_VECTOR_PKT_MODE;
 
        if (bnxt_vf_pciid(pci_dev->id.device_id))
                bp->flags |= BNXT_FLAG_VF;
 
-       if (bnxt_thor_device(pci_dev->id.device_id))
-               bp->flags |= BNXT_FLAG_THOR_CHIP;
+       if (bnxt_p5_device(pci_dev->id.device_id))
+               bp->flags |= BNXT_FLAG_CHIP_P5;
 
        if (pci_dev->id.device_id == BROADCOM_DEV_ID_58802 ||
            pci_dev->id.device_id == BROADCOM_DEV_ID_58804 ||
@@ -6021,7 +5299,23 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
            pci_dev->id.device_id == BROADCOM_DEV_ID_58802_VF)
                bp->flags |= BNXT_FLAG_STINGRAY;
 
-       rc = bnxt_init_board(eth_dev);
+       if (BNXT_TRUFLOW_EN(bp)) {
+               /* extra mbuf field is required to store CFA code from mark */
+               static const struct rte_mbuf_dynfield bnxt_cfa_code_dynfield_desc = {
+                       .name = RTE_PMD_BNXT_CFA_CODE_DYNFIELD_NAME,
+                       .size = sizeof(bnxt_cfa_code_dynfield_t),
+                       .align = __alignof__(bnxt_cfa_code_dynfield_t),
+               };
+               bnxt_cfa_code_dynfield_offset =
+                       rte_mbuf_dynfield_register(&bnxt_cfa_code_dynfield_desc);
+               if (bnxt_cfa_code_dynfield_offset < 0) {
+                       PMD_DRV_LOG(ERR,
+                           "Failed to register mbuf field for TruFlow mark\n");
+                       return -rte_errno;
+               }
+       }
+
+       rc = bnxt_map_pci_bars(eth_dev);
        if (rc) {
                PMD_DRV_LOG(ERR,
                            "Failed to initialize board rc: %x\n", rc);
@@ -6030,27 +5324,75 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
 
        rc = bnxt_alloc_pf_info(bp);
        if (rc)
-               goto error_free;
+               return rc;
 
        rc = bnxt_alloc_link_info(bp);
        if (rc)
-               goto error_free;
+               return rc;
 
        rc = bnxt_alloc_parent_info(bp);
        if (rc)
-               goto error_free;
+               return rc;
 
        rc = bnxt_alloc_hwrm_resources(bp);
        if (rc) {
                PMD_DRV_LOG(ERR,
                            "Failed to allocate hwrm resource rc: %x\n", rc);
-               goto error_free;
+               return rc;
        }
        rc = bnxt_alloc_leds_info(bp);
        if (rc)
-               goto error_free;
+               return rc;
 
        rc = bnxt_alloc_cos_queues(bp);
+       if (rc)
+               return rc;
+
+       rc = bnxt_init_locks(bp);
+       if (rc)
+               return rc;
+
+       rc = bnxt_alloc_switch_domain(bp);
+       if (rc)
+               return rc;
+
+       return rc;
+}
+
+static int
+bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
+{
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
+       static int version_printed;
+       struct bnxt *bp;
+       int rc;
+
+       if (version_printed++ == 0)
+               PMD_DRV_LOG(INFO, "%s\n", bnxt_version);
+
+       eth_dev->dev_ops = &bnxt_dev_ops;
+       eth_dev->rx_queue_count = bnxt_rx_queue_count_op;
+       eth_dev->rx_descriptor_status = bnxt_rx_descriptor_status_op;
+       eth_dev->tx_descriptor_status = bnxt_tx_descriptor_status_op;
+       eth_dev->rx_pkt_burst = &bnxt_recv_pkts;
+       eth_dev->tx_pkt_burst = &bnxt_xmit_pkts;
+
+       /*
+        * For secondary processes, we don't initialise any further
+        * as primary has already done this work.
+        */
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
+
+       rte_eth_copy_pci_info(eth_dev, pci_dev);
+       eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;
+
+       bp = eth_dev->data->dev_private;
+
+       /* Parse dev arguments passed on when starting the DPDK application. */
+       bnxt_parse_dev_args(bp, pci_dev->device.devargs);
+
+       rc = bnxt_drv_init(eth_dev);
        if (rc)
                goto error_free;
 
@@ -6062,8 +5404,6 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
        if (rc)
                goto error_free;
 
-       bnxt_alloc_switch_domain(bp);
-
        PMD_DRV_LOG(INFO,
                    DRV_MODULE_NAME "found at mem %" PRIX64 ", node addr %pM\n",
                    pci_dev->mem_resource[0].phys_addr,
@@ -6145,18 +5485,6 @@ bnxt_free_error_recovery_info(struct bnxt *bp)
        bp->fw_cap &= ~BNXT_FW_CAP_ERROR_RECOVERY;
 }
 
-static void
-bnxt_uninit_locks(struct bnxt *bp)
-{
-       pthread_mutex_destroy(&bp->flow_lock);
-       pthread_mutex_destroy(&bp->def_cp_lock);
-       pthread_mutex_destroy(&bp->health_check_lock);
-       if (bp->rep_info) {
-               pthread_mutex_destroy(&bp->rep_info->vfr_lock);
-               pthread_mutex_destroy(&bp->rep_info->vfr_start_lock);
-       }
-}
-
 static int
 bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev)
 {
@@ -6178,7 +5506,6 @@ bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev)
 
        bnxt_uninit_ctx_mem(bp);
 
-       bnxt_uninit_locks(bp);
        bnxt_free_flow_stats_info(bp);
        bnxt_free_rep_info(bp);
        rte_free(bp->ptp_cfg);
@@ -6276,7 +5603,7 @@ static int bnxt_init_rep_info(struct bnxt *bp)
 }
 
 static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,
-                              struct rte_eth_devargs eth_da,
+                              struct rte_eth_devargs *eth_da,
                               struct rte_eth_dev *backing_eth_dev,
                               const char *dev_args)
 {
@@ -6285,9 +5612,9 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,
        struct bnxt *backing_bp;
        uint16_t num_rep;
        int i, ret = 0;
-       struct rte_kvargs *kvlist;
+       struct rte_kvargs *kvlist = NULL;
 
-       num_rep = eth_da.nb_representor_ports;
+       num_rep = eth_da->nb_representor_ports;
        if (num_rep > BNXT_MAX_VF_REPS) {
                PMD_DRV_LOG(ERR, "nb_representor_ports = %d > %d MAX VF REPS\n",
                            num_rep, BNXT_MAX_VF_REPS);
@@ -6317,7 +5644,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,
 
        for (i = 0; i < num_rep; i++) {
                struct bnxt_representor representor = {
-                       .vf_id = eth_da.representor_ports[i],
+                       .vf_id = eth_da->representor_ports[i],
                        .switch_domain_id = backing_bp->switch_domain_id,
                        .parent_dev = backing_eth_dev
                };
@@ -6330,58 +5657,83 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,
 
                /* representor port net_bdf_port */
                snprintf(name, sizeof(name), "net_%s_representor_%d",
-                        pci_dev->device.name, eth_da.representor_ports[i]);
+                        pci_dev->device.name, eth_da->representor_ports[i]);
 
                kvlist = rte_kvargs_parse(dev_args, bnxt_dev_args);
                if (kvlist) {
                        /*
                         * Handler for "rep_is_pf" devarg.
-                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * Invoked as for ex: "-a 000:00:0d.0,
                         * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
                         */
-                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_IS_PF,
-                                          bnxt_parse_devarg_rep_is_pf,
-                                          (void *)&representor);
+                       ret = rte_kvargs_process(kvlist, BNXT_DEVARG_REP_IS_PF,
+                                                bnxt_parse_devarg_rep_is_pf,
+                                                (void *)&representor);
+                       if (ret) {
+                               ret = -EINVAL;
+                               goto err;
+                       }
                        /*
                         * Handler for "rep_based_pf" devarg.
-                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * Invoked as for ex: "-a 000:00:0d.0,
                         * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
                         */
-                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_BASED_PF,
-                                          bnxt_parse_devarg_rep_based_pf,
-                                          (void *)&representor);
+                       ret = rte_kvargs_process(kvlist,
+                                                BNXT_DEVARG_REP_BASED_PF,
+                                                bnxt_parse_devarg_rep_based_pf,
+                                                (void *)&representor);
+                       if (ret) {
+                               ret = -EINVAL;
+                               goto err;
+                       }
                        /*
                         * Handler for "rep_based_pf" devarg.
-                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * Invoked as for ex: "-a 000:00:0d.0,
                         * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
                         */
-                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_Q_R2F,
-                                          bnxt_parse_devarg_rep_q_r2f,
-                                          (void *)&representor);
+                       ret = rte_kvargs_process(kvlist, BNXT_DEVARG_REP_Q_R2F,
+                                                bnxt_parse_devarg_rep_q_r2f,
+                                                (void *)&representor);
+                       if (ret) {
+                               ret = -EINVAL;
+                               goto err;
+                       }
                        /*
                         * Handler for "rep_based_pf" devarg.
-                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * Invoked as for ex: "-a 000:00:0d.0,
                         * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
                         */
-                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_Q_F2R,
-                                          bnxt_parse_devarg_rep_q_f2r,
-                                          (void *)&representor);
+                       ret = rte_kvargs_process(kvlist, BNXT_DEVARG_REP_Q_F2R,
+                                                bnxt_parse_devarg_rep_q_f2r,
+                                                (void *)&representor);
+                       if (ret) {
+                               ret = -EINVAL;
+                               goto err;
+                       }
                        /*
                         * Handler for "rep_based_pf" devarg.
-                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * Invoked as for ex: "-a 000:00:0d.0,
                         * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
                         */
-                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_FC_R2F,
-                                          bnxt_parse_devarg_rep_fc_r2f,
-                                          (void *)&representor);
+                       ret = rte_kvargs_process(kvlist, BNXT_DEVARG_REP_FC_R2F,
+                                                bnxt_parse_devarg_rep_fc_r2f,
+                                                (void *)&representor);
+                       if (ret) {
+                               ret = -EINVAL;
+                               goto err;
+                       }
                        /*
                         * Handler for "rep_based_pf" devarg.
-                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * Invoked as for ex: "-a 000:00:0d.0,
                         * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
                         */
-                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_FC_F2R,
-                                          bnxt_parse_devarg_rep_fc_f2r,
-                                          (void *)&representor);
+                       ret = rte_kvargs_process(kvlist, BNXT_DEVARG_REP_FC_F2R,
+                                                bnxt_parse_devarg_rep_fc_f2r,
+                                                (void *)&representor);
+                       if (ret) {
+                               ret = -EINVAL;
+                               goto err;
+                       }
                }
 
                ret = rte_eth_dev_create(&pci_dev->device, name,
@@ -6411,6 +5763,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,
 
        }
 
+       rte_kvargs_free(kvlist);
        return 0;
 
 err:
@@ -6419,6 +5772,8 @@ err:
         */
        if (num_rep > 1)
                bnxt_pci_remove_dev_with_reps(backing_eth_dev);
+       rte_errno = -ret;
+       rte_kvargs_free(kvlist);
 
        return ret;
 }
@@ -6465,7 +5820,7 @@ static int bnxt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
                return ret;
 
        /* probe representor ports now */
-       ret = bnxt_rep_port_probe(pci_dev, eth_da, backing_eth_dev,
+       ret = bnxt_rep_port_probe(pci_dev, &eth_da, backing_eth_dev,
                                  pci_dev->device.devargs->args);
 
        return ret;