drivers/net: check process type in close operation
[dpdk.git] / drivers / net / bnxt / bnxt_ethdev.c
index 445c408..a6812c1 100644 (file)
@@ -99,12 +99,24 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
 #define BNXT_DEVARG_FLOW_XSTAT "flow-xstat"
 #define BNXT_DEVARG_MAX_NUM_KFLOWS  "max-num-kflows"
 #define BNXT_DEVARG_REPRESENTOR        "representor"
+#define BNXT_DEVARG_REP_BASED_PF  "rep-based-pf"
+#define BNXT_DEVARG_REP_IS_PF  "rep-is-pf"
+#define BNXT_DEVARG_REP_Q_R2F  "rep-q-r2f"
+#define BNXT_DEVARG_REP_Q_F2R  "rep-q-f2r"
+#define BNXT_DEVARG_REP_FC_R2F  "rep-fc-r2f"
+#define BNXT_DEVARG_REP_FC_F2R  "rep-fc-f2r"
 
 static const char *const bnxt_dev_args[] = {
        BNXT_DEVARG_REPRESENTOR,
        BNXT_DEVARG_TRUFLOW,
        BNXT_DEVARG_FLOW_XSTAT,
        BNXT_DEVARG_MAX_NUM_KFLOWS,
+       BNXT_DEVARG_REP_BASED_PF,
+       BNXT_DEVARG_REP_IS_PF,
+       BNXT_DEVARG_REP_Q_R2F,
+       BNXT_DEVARG_REP_Q_F2R,
+       BNXT_DEVARG_REP_FC_R2F,
+       BNXT_DEVARG_REP_FC_F2R,
        NULL
 };
 
@@ -120,6 +132,36 @@ static const char *const bnxt_dev_args[] = {
  */
 #define        BNXT_DEVARG_FLOW_XSTAT_INVALID(flow_xstat)      ((flow_xstat) > 1)
 
+/*
+ * rep_is_pf == false to indicate VF representor
+ * rep_is_pf == true to indicate PF representor
+ */
+#define        BNXT_DEVARG_REP_IS_PF_INVALID(rep_is_pf)        ((rep_is_pf) > 1)
+
+/*
+ * rep_based_pf == Physical index of the PF
+ */
+#define        BNXT_DEVARG_REP_BASED_PF_INVALID(rep_based_pf)  ((rep_based_pf) > 15)
+/*
+ * rep_q_r2f == Logical COS Queue index for the rep to endpoint direction
+ */
+#define        BNXT_DEVARG_REP_Q_R2F_INVALID(rep_q_r2f)        ((rep_q_r2f) > 3)
+
+/*
+ * rep_q_f2r == Logical COS Queue index for the endpoint to rep direction
+ */
+#define        BNXT_DEVARG_REP_Q_F2R_INVALID(rep_q_f2r)        ((rep_q_f2r) > 3)
+
+/*
+ * rep_fc_r2f == Flow control for the representor to endpoint direction
+ */
+#define BNXT_DEVARG_REP_FC_R2F_INVALID(rep_fc_r2f)     ((rep_fc_r2f) > 1)
+
+/*
+ * rep_fc_f2r == Flow control for the endpoint to representor direction
+ */
+#define BNXT_DEVARG_REP_FC_F2R_INVALID(rep_fc_f2r)     ((rep_fc_f2r) > 1)
+
 /*
  * max_num_kflows must be >= 32
  * and must be a power-of-2 supported value
@@ -822,7 +864,11 @@ uint32_t bnxt_get_speed_capabilities(struct bnxt *bp)
                speed_capa |= ETH_LINK_SPEED_50G;
        if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_100GB)
                speed_capa |= ETH_LINK_SPEED_100G;
-       if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_SPEEDS_200GB)
+       if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_50G)
+               speed_capa |= ETH_LINK_SPEED_50G;
+       if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_100G)
+               speed_capa |= ETH_LINK_SPEED_100G;
+       if (link_speed & HWRM_PORT_PHY_QCFG_OUTPUT_SUPPORT_PAM4_SPEEDS_200G)
                speed_capa |= ETH_LINK_SPEED_200G;
 
        if (bp->link_info->auto_mode ==
@@ -887,8 +933,7 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
                        .wthresh = 0,
                },
                .rx_free_thresh = 32,
-               /* If no descriptors available, pkts are dropped by default */
-               .rx_drop_en = 1,
+               .rx_drop_en = BNXT_DEFAULT_RX_DROP_EN,
        };
 
        dev_info->default_txconf = (struct rte_eth_txconf) {
@@ -908,6 +953,14 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
        dev_info->tx_desc_lim.nb_min = BNXT_MIN_RING_DESC;
        dev_info->tx_desc_lim.nb_max = BNXT_MAX_TX_RING_DESC;
 
+       if (BNXT_PF(bp) || BNXT_VF_IS_TRUSTED(bp)) {
+               dev_info->switch_info.name = eth_dev->device->name;
+               dev_info->switch_info.domain_id = bp->switch_domain_id;
+               dev_info->switch_info.port_id =
+                               BNXT_PF(bp) ? BNXT_SWITCH_PORT_ID_PF :
+                                   BNXT_SWITCH_PORT_ID_TRUSTED_VF;
+       }
+
        /* *INDENT-ON* */
 
        /*
@@ -1244,9 +1297,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)
        eth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev);
        eth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);
 
-       pthread_mutex_lock(&bp->def_cp_lock);
        bnxt_schedule_fw_health_check(bp);
-       pthread_mutex_unlock(&bp->def_cp_lock);
 
        return 0;
 
@@ -1309,12 +1360,17 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
        /* disable uio/vfio intr/eventfd mapping */
        rte_intr_disable(intr_handle);
 
+       /* Stop the child representors for this device */
+       bnxt_rep_stop_all(bp);
+
        /* delete the bnxt ULP port details */
        bnxt_ulp_port_deinit(bp);
 
        bnxt_cancel_fw_health_check(bp);
 
-       bnxt_dev_set_link_down_op(eth_dev);
+       /* Do not bring link down during reset recovery */
+       if (!is_bnxt_in_error(bp))
+               bnxt_dev_set_link_down_op(eth_dev);
 
        /* Wait for link to be reset and the async notification to process.
         * During reset recovery, there is no need to wait and
@@ -1348,10 +1404,13 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
                bp->flow_stat->flow_count = 0;
 }
 
-static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)
+static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev)
 {
        struct bnxt *bp = eth_dev->data->dev_private;
 
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
+
        /* cancel the recovery handler before remove dev */
        rte_eal_alarm_cancel(bnxt_dev_reset_and_resume, (void *)bp);
        rte_eal_alarm_cancel(bnxt_dev_recover, (void *)bp);
@@ -1383,6 +1442,8 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)
 
        rte_free(bp->grp_info);
        bp->grp_info = NULL;
+
+       return 0;
 }
 
 static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,
@@ -2591,8 +2652,9 @@ bnxt_rxq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id,
        qinfo->nb_desc = rxq->nb_rx_desc;
 
        qinfo->conf.rx_free_thresh = rxq->rx_free_thresh;
-       qinfo->conf.rx_drop_en = 0;
+       qinfo->conf.rx_drop_en = rxq->drop_en;
        qinfo->conf.rx_deferred_start = rxq->rx_deferred_start;
+       qinfo->conf.offloads = dev->data->dev_conf.rxmode.offloads;
 }
 
 static void
@@ -2616,6 +2678,7 @@ bnxt_txq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id,
        qinfo->conf.tx_free_thresh = txq->tx_free_thresh;
        qinfo->conf.tx_rs_thresh = 0;
        qinfo->conf.tx_deferred_start = txq->tx_deferred_start;
+       qinfo->conf.offloads = dev->data->dev_conf.txmode.offloads;
 }
 
 static const struct {
@@ -3721,11 +3784,16 @@ bnxt_filter_ctrl_op(struct rte_eth_dev *dev,
                return -EIO;
 
        if (BNXT_ETH_DEV_IS_REPRESENTOR(dev)) {
-               struct bnxt_vf_representor *vfr = dev->data->dev_private;
+               struct bnxt_representor *vfr = dev->data->dev_private;
                bp = vfr->parent_dev->data->dev_private;
                /* parent is deleted while children are still valid */
-               if (!bp)
+               if (!bp) {
+                       PMD_DRV_LOG(DEBUG, "BNXT Port:%d VFR Error %d:%d\n",
+                                   dev->data->port_id,
+                                   filter_type,
+                                   filter_op);
                        return -EIO;
+               }
        }
 
        ret = is_bnxt_in_error(bp);
@@ -4363,7 +4431,7 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp, uint32_t index)
 
 static void bnxt_dev_cleanup(struct bnxt *bp)
 {
-       bnxt_set_hwrm_link_config(bp, false);
+       bp->eth_dev->data->dev_link.link_status = 0;
        bp->link_info->link_up = 0;
        if (bp->eth_dev->data->dev_started)
                bnxt_dev_stop_op(bp->eth_dev);
@@ -4659,17 +4727,22 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp)
 {
        uint32_t polling_freq;
 
+       pthread_mutex_lock(&bp->health_check_lock);
+
        if (!bnxt_is_recovery_enabled(bp))
-               return;
+               goto done;
 
        if (bp->flags & BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED)
-               return;
+               goto done;
 
        polling_freq = bp->recovery_info->driver_polling_freq;
 
        rte_eal_alarm_set(US_PER_MS * polling_freq,
                          bnxt_check_fw_health, (void *)bp);
        bp->flags |= BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED;
+
+done:
+       pthread_mutex_unlock(&bp->health_check_lock);
 }
 
 static void bnxt_cancel_fw_health_check(struct bnxt *bp)
@@ -5167,7 +5240,7 @@ bnxt_get_svif(uint16_t port_id, bool func_svif,
 
        eth_dev = &rte_eth_devices[port_id];
        if (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {
-               struct bnxt_vf_representor *vfr = eth_dev->data->dev_private;
+               struct bnxt_representor *vfr = eth_dev->data->dev_private;
                if (!vfr)
                        return 0;
 
@@ -5191,7 +5264,7 @@ bnxt_get_vnic_id(uint16_t port, enum bnxt_ulp_intf_type type)
 
        eth_dev = &rte_eth_devices[port];
        if (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {
-               struct bnxt_vf_representor *vfr = eth_dev->data->dev_private;
+               struct bnxt_representor *vfr = eth_dev->data->dev_private;
                if (!vfr)
                        return 0;
 
@@ -5216,7 +5289,7 @@ bnxt_get_fw_func_id(uint16_t port, enum bnxt_ulp_intf_type type)
 
        eth_dev = &rte_eth_devices[port];
        if (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {
-               struct bnxt_vf_representor *vfr = eth_dev->data->dev_private;
+               struct bnxt_representor *vfr = eth_dev->data->dev_private;
                if (!vfr)
                        return 0;
 
@@ -5255,7 +5328,7 @@ bnxt_get_interface_type(uint16_t port)
 uint16_t
 bnxt_get_phy_port_id(uint16_t port_id)
 {
-       struct bnxt_vf_representor *vfr;
+       struct bnxt_representor *vfr;
        struct rte_eth_dev *eth_dev;
        struct bnxt *bp;
 
@@ -5281,7 +5354,7 @@ bnxt_get_parif(uint16_t port_id, enum bnxt_ulp_intf_type type)
 
        eth_dev = &rte_eth_devices[port_id];
        if (BNXT_ETH_DEV_IS_REPRESENTOR(eth_dev)) {
-               struct bnxt_vf_representor *vfr = eth_dev->data->dev_private;
+               struct bnxt_representor *vfr = eth_dev->data->dev_private;
                if (!vfr)
                        return 0;
 
@@ -5457,6 +5530,10 @@ bnxt_init_locks(struct bnxt *bp)
        err = pthread_mutex_init(&bp->def_cp_lock, NULL);
        if (err)
                PMD_DRV_LOG(ERR, "Unable to initialize def_cp_lock\n");
+
+       err = pthread_mutex_init(&bp->health_check_lock, NULL);
+       if (err)
+               PMD_DRV_LOG(ERR, "Unable to initialize health_check_lock\n");
        return err;
 }
 
@@ -5556,9 +5633,13 @@ bnxt_parse_devarg_truflow(__rte_unused const char *key,
                return -EINVAL;
        }
 
-       bp->flags |= BNXT_FLAG_TRUFLOW_EN;
-       if (BNXT_TRUFLOW_EN(bp))
+       if (truflow) {
+               bp->flags |= BNXT_FLAG_TRUFLOW_EN;
                PMD_DRV_LOG(INFO, "Host-based truflow feature enabled.\n");
+       } else {
+               bp->flags &= ~BNXT_FLAG_TRUFLOW_EN;
+               PMD_DRV_LOG(INFO, "Host-based truflow feature disabled.\n");
+       }
 
        return 0;
 }
@@ -5634,6 +5715,227 @@ bnxt_parse_devarg_max_num_kflows(__rte_unused const char *key,
        return 0;
 }
 
+static int
+bnxt_parse_devarg_rep_is_pf(__rte_unused const char *key,
+                           const char *value, void *opaque_arg)
+{
+       struct bnxt_representor *vfr_bp = opaque_arg;
+       unsigned long rep_is_pf;
+       char *end = NULL;
+
+       if (!value || !opaque_arg) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_is_pf devargs.\n");
+               return -EINVAL;
+       }
+
+       rep_is_pf = strtoul(value, &end, 10);
+       if (end == NULL || *end != '\0' ||
+           (rep_is_pf == ULONG_MAX && errno == ERANGE)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_is_pf devargs.\n");
+               return -EINVAL;
+       }
+
+       if (BNXT_DEVARG_REP_IS_PF_INVALID(rep_is_pf)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid value passed to rep_is_pf devargs.\n");
+               return -EINVAL;
+       }
+
+       vfr_bp->flags |= rep_is_pf;
+       if (BNXT_REP_PF(vfr_bp))
+               PMD_DRV_LOG(INFO, "PF representor\n");
+       else
+               PMD_DRV_LOG(INFO, "VF representor\n");
+
+       return 0;
+}
+
+static int
+bnxt_parse_devarg_rep_based_pf(__rte_unused const char *key,
+                              const char *value, void *opaque_arg)
+{
+       struct bnxt_representor *vfr_bp = opaque_arg;
+       unsigned long rep_based_pf;
+       char *end = NULL;
+
+       if (!value || !opaque_arg) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_based_pf "
+                           "devargs.\n");
+               return -EINVAL;
+       }
+
+       rep_based_pf = strtoul(value, &end, 10);
+       if (end == NULL || *end != '\0' ||
+           (rep_based_pf == ULONG_MAX && errno == ERANGE)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_based_pf "
+                           "devargs.\n");
+               return -EINVAL;
+       }
+
+       if (BNXT_DEVARG_REP_BASED_PF_INVALID(rep_based_pf)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid value passed to rep_based_pf devargs.\n");
+               return -EINVAL;
+       }
+
+       vfr_bp->rep_based_pf = rep_based_pf;
+       PMD_DRV_LOG(INFO, "rep-based-pf = %d\n", vfr_bp->rep_based_pf);
+
+       return 0;
+}
+
+static int
+bnxt_parse_devarg_rep_q_r2f(__rte_unused const char *key,
+                           const char *value, void *opaque_arg)
+{
+       struct bnxt_representor *vfr_bp = opaque_arg;
+       unsigned long rep_q_r2f;
+       char *end = NULL;
+
+       if (!value || !opaque_arg) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_q_r2f "
+                           "devargs.\n");
+               return -EINVAL;
+       }
+
+       rep_q_r2f = strtoul(value, &end, 10);
+       if (end == NULL || *end != '\0' ||
+           (rep_q_r2f == ULONG_MAX && errno == ERANGE)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_q_r2f "
+                           "devargs.\n");
+               return -EINVAL;
+       }
+
+       if (BNXT_DEVARG_REP_Q_R2F_INVALID(rep_q_r2f)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid value passed to rep_q_r2f devargs.\n");
+               return -EINVAL;
+       }
+
+       vfr_bp->rep_q_r2f = rep_q_r2f;
+       vfr_bp->flags |= BNXT_REP_Q_R2F_VALID;
+       PMD_DRV_LOG(INFO, "rep-q-r2f = %d\n", vfr_bp->rep_q_r2f);
+
+       return 0;
+}
+
+static int
+bnxt_parse_devarg_rep_q_f2r(__rte_unused const char *key,
+                           const char *value, void *opaque_arg)
+{
+       struct bnxt_representor *vfr_bp = opaque_arg;
+       unsigned long rep_q_f2r;
+       char *end = NULL;
+
+       if (!value || !opaque_arg) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_q_f2r "
+                           "devargs.\n");
+               return -EINVAL;
+       }
+
+       rep_q_f2r = strtoul(value, &end, 10);
+       if (end == NULL || *end != '\0' ||
+           (rep_q_f2r == ULONG_MAX && errno == ERANGE)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_q_f2r "
+                           "devargs.\n");
+               return -EINVAL;
+       }
+
+       if (BNXT_DEVARG_REP_Q_F2R_INVALID(rep_q_f2r)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid value passed to rep_q_f2r devargs.\n");
+               return -EINVAL;
+       }
+
+       vfr_bp->rep_q_f2r = rep_q_f2r;
+       vfr_bp->flags |= BNXT_REP_Q_F2R_VALID;
+       PMD_DRV_LOG(INFO, "rep-q-f2r = %d\n", vfr_bp->rep_q_f2r);
+
+       return 0;
+}
+
+static int
+bnxt_parse_devarg_rep_fc_r2f(__rte_unused const char *key,
+                            const char *value, void *opaque_arg)
+{
+       struct bnxt_representor *vfr_bp = opaque_arg;
+       unsigned long rep_fc_r2f;
+       char *end = NULL;
+
+       if (!value || !opaque_arg) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_fc_r2f "
+                           "devargs.\n");
+               return -EINVAL;
+       }
+
+       rep_fc_r2f = strtoul(value, &end, 10);
+       if (end == NULL || *end != '\0' ||
+           (rep_fc_r2f == ULONG_MAX && errno == ERANGE)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_fc_r2f "
+                           "devargs.\n");
+               return -EINVAL;
+       }
+
+       if (BNXT_DEVARG_REP_FC_R2F_INVALID(rep_fc_r2f)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid value passed to rep_fc_r2f devargs.\n");
+               return -EINVAL;
+       }
+
+       vfr_bp->flags |= BNXT_REP_FC_R2F_VALID;
+       vfr_bp->rep_fc_r2f = rep_fc_r2f;
+       PMD_DRV_LOG(INFO, "rep-fc-r2f = %lu\n", rep_fc_r2f);
+
+       return 0;
+}
+
+static int
+bnxt_parse_devarg_rep_fc_f2r(__rte_unused const char *key,
+                            const char *value, void *opaque_arg)
+{
+       struct bnxt_representor *vfr_bp = opaque_arg;
+       unsigned long rep_fc_f2r;
+       char *end = NULL;
+
+       if (!value || !opaque_arg) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_fc_f2r "
+                           "devargs.\n");
+               return -EINVAL;
+       }
+
+       rep_fc_f2r = strtoul(value, &end, 10);
+       if (end == NULL || *end != '\0' ||
+           (rep_fc_f2r == ULONG_MAX && errno == ERANGE)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid parameter passed to rep_fc_f2r "
+                           "devargs.\n");
+               return -EINVAL;
+       }
+
+       if (BNXT_DEVARG_REP_FC_F2R_INVALID(rep_fc_f2r)) {
+               PMD_DRV_LOG(ERR,
+                           "Invalid value passed to rep_fc_f2r devargs.\n");
+               return -EINVAL;
+       }
+
+       vfr_bp->flags |= BNXT_REP_FC_F2R_VALID;
+       vfr_bp->rep_fc_f2r = rep_fc_f2r;
+       PMD_DRV_LOG(INFO, "rep-fc-f2r = %lu\n", rep_fc_f2r);
+
+       return 0;
+}
+
 static void
 bnxt_parse_dev_args(struct bnxt *bp, struct rte_devargs *devargs)
 {
@@ -5777,11 +6079,6 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)
 
        bnxt_alloc_switch_domain(bp);
 
-       /* Pass the information to the rte_eth_dev_close() that it should also
-        * release the private port resources.
-        */
-       eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
-
        PMD_DRV_LOG(INFO,
                    DRV_MODULE_NAME "found at mem %" PRIX64 ", node addr %pM\n",
                    pci_dev->mem_resource[0].phys_addr,
@@ -5868,6 +6165,7 @@ bnxt_uninit_locks(struct bnxt *bp)
 {
        pthread_mutex_destroy(&bp->flow_lock);
        pthread_mutex_destroy(&bp->def_cp_lock);
+       pthread_mutex_destroy(&bp->health_check_lock);
        if (bp->rep_info) {
                pthread_mutex_destroy(&bp->rep_info->vfr_lock);
                pthread_mutex_destroy(&bp->rep_info->vfr_start_lock);
@@ -5927,8 +6225,12 @@ static int bnxt_pci_remove_dev_with_reps(struct rte_eth_dev *eth_dev)
                vf_rep_eth_dev = bp->rep_info[i].vfr_eth_dev;
                if (!vf_rep_eth_dev)
                        continue;
-               rte_eth_dev_destroy(vf_rep_eth_dev, bnxt_vf_representor_uninit);
+               PMD_DRV_LOG(DEBUG, "BNXT Port:%d VFR pci remove\n",
+                           vf_rep_eth_dev->data->port_id);
+               rte_eth_dev_destroy(vf_rep_eth_dev, bnxt_representor_uninit);
        }
+       PMD_DRV_LOG(DEBUG, "BNXT Port:%d pci remove\n",
+                   eth_dev->data->port_id);
        ret = rte_eth_dev_destroy(eth_dev, bnxt_dev_uninit);
 
        return ret;
@@ -5987,13 +6289,15 @@ static int bnxt_init_rep_info(struct bnxt *bp)
 
 static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,
                               struct rte_eth_devargs eth_da,
-                              struct rte_eth_dev *backing_eth_dev)
+                              struct rte_eth_dev *backing_eth_dev,
+                              const char *dev_args)
 {
        struct rte_eth_dev *vf_rep_eth_dev;
        char name[RTE_ETH_NAME_MAX_LEN];
        struct bnxt *backing_bp;
        uint16_t num_rep;
        int i, ret = 0;
+       struct rte_kvargs *kvlist;
 
        num_rep = eth_da.nb_representor_ports;
        if (num_rep > BNXT_MAX_VF_REPS) {
@@ -6002,7 +6306,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,
                return -EINVAL;
        }
 
-       if (num_rep > RTE_MAX_ETHPORTS) {
+       if (num_rep >= RTE_MAX_ETHPORTS) {
                PMD_DRV_LOG(ERR,
                            "nb_representor_ports = %d > %d MAX ETHPORTS\n",
                            num_rep, RTE_MAX_ETHPORTS);
@@ -6024,7 +6328,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,
                return 0;
 
        for (i = 0; i < num_rep; i++) {
-               struct bnxt_vf_representor representor = {
+               struct bnxt_representor representor = {
                        .vf_id = eth_da.representor_ports[i],
                        .switch_domain_id = backing_bp->switch_domain_id,
                        .parent_dev = backing_eth_dev
@@ -6040,31 +6344,94 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev,
                snprintf(name, sizeof(name), "net_%s_representor_%d",
                         pci_dev->device.name, eth_da.representor_ports[i]);
 
+               kvlist = rte_kvargs_parse(dev_args, bnxt_dev_args);
+               if (kvlist) {
+                       /*
+                        * Handler for "rep_is_pf" devarg.
+                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
+                        */
+                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_IS_PF,
+                                          bnxt_parse_devarg_rep_is_pf,
+                                          (void *)&representor);
+                       /*
+                        * Handler for "rep_based_pf" devarg.
+                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
+                        */
+                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_BASED_PF,
+                                          bnxt_parse_devarg_rep_based_pf,
+                                          (void *)&representor);
+                       /*
+                        * Handler for "rep_based_pf" devarg.
+                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
+                        */
+                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_Q_R2F,
+                                          bnxt_parse_devarg_rep_q_r2f,
+                                          (void *)&representor);
+                       /*
+                        * Handler for "rep_based_pf" devarg.
+                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
+                        */
+                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_Q_F2R,
+                                          bnxt_parse_devarg_rep_q_f2r,
+                                          (void *)&representor);
+                       /*
+                        * Handler for "rep_based_pf" devarg.
+                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
+                        */
+                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_FC_R2F,
+                                          bnxt_parse_devarg_rep_fc_r2f,
+                                          (void *)&representor);
+                       /*
+                        * Handler for "rep_based_pf" devarg.
+                        * Invoked as for ex: "-w 000:00:0d.0,
+                        * rep-based-pf=<pf index> rep-is-pf=<VF=0 or PF=1>"
+                        */
+                       rte_kvargs_process(kvlist, BNXT_DEVARG_REP_FC_F2R,
+                                          bnxt_parse_devarg_rep_fc_f2r,
+                                          (void *)&representor);
+               }
+
                ret = rte_eth_dev_create(&pci_dev->device, name,
-                                        sizeof(struct bnxt_vf_representor),
+                                        sizeof(struct bnxt_representor),
                                         NULL, NULL,
-                                        bnxt_vf_representor_init,
+                                        bnxt_representor_init,
                                         &representor);
-
-               if (!ret) {
-                       vf_rep_eth_dev = rte_eth_dev_allocated(name);
-                       if (!vf_rep_eth_dev) {
-                               PMD_DRV_LOG(ERR, "Failed to find the eth_dev"
-                                           " for VF-Rep: %s.", name);
-                               bnxt_pci_remove_dev_with_reps(backing_eth_dev);
-                               ret = -ENODEV;
-                               return ret;
-                       }
-                       backing_bp->rep_info[representor.vf_id].vfr_eth_dev =
-                               vf_rep_eth_dev;
-                       backing_bp->num_reps++;
-               } else {
+               if (ret) {
                        PMD_DRV_LOG(ERR, "failed to create bnxt vf "
                                    "representor %s.", name);
-                       bnxt_pci_remove_dev_with_reps(backing_eth_dev);
+                       goto err;
+               }
+
+               vf_rep_eth_dev = rte_eth_dev_allocated(name);
+               if (!vf_rep_eth_dev) {
+                       PMD_DRV_LOG(ERR, "Failed to find the eth_dev"
+                                   " for VF-Rep: %s.", name);
+                       ret = -ENODEV;
+                       goto err;
                }
+
+               PMD_DRV_LOG(DEBUG, "BNXT Port:%d VFR pci probe\n",
+                           backing_eth_dev->data->port_id);
+               backing_bp->rep_info[representor.vf_id].vfr_eth_dev =
+                                                        vf_rep_eth_dev;
+               backing_bp->num_reps++;
+
        }
 
+       return 0;
+
+err:
+       /* If num_rep > 1, then rollback already created
+        * ports, since we'll be failing the probe anyway
+        */
+       if (num_rep > 1)
+               bnxt_pci_remove_dev_with_reps(backing_eth_dev);
+
        return ret;
 }
 
@@ -6103,9 +6470,15 @@ static int bnxt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 
                backing_eth_dev = rte_eth_dev_allocated(pci_dev->device.name);
        }
+       PMD_DRV_LOG(DEBUG, "BNXT Port:%d pci probe\n",
+                   backing_eth_dev->data->port_id);
+
+       if (!num_rep)
+               return ret;
 
        /* probe representor ports now */
-       ret = bnxt_rep_port_probe(pci_dev, eth_da, backing_eth_dev);
+       ret = bnxt_rep_port_probe(pci_dev, eth_da, backing_eth_dev,
+                                 pci_dev->device.devargs->args);
 
        return ret;
 }
@@ -6122,10 +6495,11 @@ static int bnxt_pci_remove(struct rte_pci_device *pci_dev)
                           * +ve value will at least help in proper cleanup
                           */
 
+       PMD_DRV_LOG(DEBUG, "BNXT Port:%d pci remove\n", eth_dev->data->port_id);
        if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
                if (eth_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR)
                        return rte_eth_dev_destroy(eth_dev,
-                                                  bnxt_vf_representor_uninit);
+                                                  bnxt_representor_uninit);
                else
                        return rte_eth_dev_destroy(eth_dev,
                                                   bnxt_dev_uninit);