net/bnxt: fix Rx configuration
[dpdk.git] / drivers / net / bnxt / bnxt_rxq.c
index 38ec4aa..8977138 100644 (file)
  * RX Queues
  */
 
+uint64_t bnxt_get_rx_port_offloads(struct bnxt *bp)
+{
+       uint64_t rx_offload_capa;
+
+       rx_offload_capa = RTE_ETH_RX_OFFLOAD_IPV4_CKSUM  |
+                         RTE_ETH_RX_OFFLOAD_UDP_CKSUM   |
+                         RTE_ETH_RX_OFFLOAD_TCP_CKSUM   |
+                         RTE_ETH_RX_OFFLOAD_KEEP_CRC    |
+                         RTE_ETH_RX_OFFLOAD_VLAN_FILTER |
+                         RTE_ETH_RX_OFFLOAD_VLAN_EXTEND |
+                         RTE_ETH_RX_OFFLOAD_TCP_LRO |
+                         RTE_ETH_RX_OFFLOAD_SCATTER |
+                         RTE_ETH_RX_OFFLOAD_RSS_HASH;
+
+       rx_offload_capa |= RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM |
+                          RTE_ETH_RX_OFFLOAD_OUTER_UDP_CKSUM;
+
+       if (bp->flags & BNXT_FLAG_PTP_SUPPORTED)
+               rx_offload_capa |= RTE_ETH_RX_OFFLOAD_TIMESTAMP;
+       if (bp->vnic_cap_flags & BNXT_VNIC_CAP_VLAN_RX_STRIP)
+               rx_offload_capa |= RTE_ETH_RX_OFFLOAD_VLAN_STRIP;
+
+       return rx_offload_capa;
+}
+
 /* Determine whether the current configuration needs aggregation ring in HW. */
 int bnxt_need_agg_ring(struct rte_eth_dev *eth_dev)
 {
@@ -40,6 +65,7 @@ void bnxt_free_rxq_stats(struct bnxt_rx_queue *rxq)
 int bnxt_mq_rx_configure(struct bnxt *bp)
 {
        struct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;
+       struct rte_eth_rss_conf *rss = &bp->rss_conf;
        const struct rte_eth_vmdq_rx_conf *conf =
                    &dev_conf->rx_adv_conf.vmdq_rx_conf;
        unsigned int i, j, nb_q_per_grp = 1, ring_idx = 0;
@@ -52,13 +78,13 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
        bp->nr_vnics = 0;
 
        /* Multi-queue mode */
-       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB_RSS) {
+       if (dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_VMDQ_DCB_RSS) {
                /* VMDq ONLY, VMDq+RSS, VMDq+DCB, VMDq+DCB+RSS */
 
                switch (dev_conf->rxmode.mq_mode) {
-               case ETH_MQ_RX_VMDQ_RSS:
-               case ETH_MQ_RX_VMDQ_ONLY:
-               case ETH_MQ_RX_VMDQ_DCB_RSS:
+               case RTE_ETH_MQ_RX_VMDQ_RSS:
+               case RTE_ETH_MQ_RX_VMDQ_ONLY:
+               case RTE_ETH_MQ_RX_VMDQ_DCB_RSS:
                        /* FALLTHROUGH */
                        /* ETH_8/64_POOLs */
                        pools = conf->nb_queue_pools;
@@ -66,14 +92,14 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
                        max_pools = RTE_MIN(bp->max_vnics,
                                            RTE_MIN(bp->max_l2_ctx,
                                            RTE_MIN(bp->max_rsscos_ctx,
-                                                   ETH_64_POOLS)));
+                                                   RTE_ETH_64_POOLS)));
                        PMD_DRV_LOG(DEBUG,
                                    "pools = %u max_pools = %u\n",
                                    pools, max_pools);
                        if (pools > max_pools)
                                pools = max_pools;
                        break;
-               case ETH_MQ_RX_RSS:
+               case RTE_ETH_MQ_RX_RSS:
                        pools = bp->rx_cosq_cnt ? bp->rx_cosq_cnt : 1;
                        break;
                default:
@@ -111,7 +137,7 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
                                    ring_idx, rxq, i, vnic);
                }
                if (i == 0) {
-                       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB) {
+                       if (dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_VMDQ_DCB) {
                                bp->eth_dev->data->promiscuous = 1;
                                vnic->flags |= BNXT_VNIC_INFO_PROMISC;
                        }
@@ -121,8 +147,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
                vnic->end_grp_id = end_grp_id;
 
                if (i) {
-                       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB ||
-                           !(dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS))
+                       if (dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_VMDQ_DCB ||
+                           !(dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_RSS))
                                vnic->rss_dflt_cr = true;
                        goto skip_filter_allocation;
                }
@@ -147,32 +173,19 @@ skip_filter_allocation:
 
        bp->rx_num_qs_per_vnic = nb_q_per_grp;
 
-       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
-               struct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf;
-
-               if (bp->flags & BNXT_FLAG_UPDATE_HASH)
-                       bp->flags &= ~BNXT_FLAG_UPDATE_HASH;
-
-               for (i = 0; i < bp->nr_vnics; i++) {
-                       uint32_t lvl = ETH_RSS_LEVEL(rss->rss_hf);
-
-                       vnic = &bp->vnic_info[i];
-                       vnic->hash_type =
-                               bnxt_rte_to_hwrm_hash_types(rss->rss_hf);
-                       vnic->hash_mode =
-                               bnxt_rte_to_hwrm_hash_level(bp,
-                                                           rss->rss_hf,
-                                                           lvl);
-
-                       /*
-                        * Use the supplied key if the key length is
-                        * acceptable and the rss_key is not NULL
-                        */
-                       if (rss->rss_key &&
-                           rss->rss_key_len <= HW_HASH_KEY_SIZE)
-                               memcpy(vnic->rss_hash_key,
-                                      rss->rss_key, rss->rss_key_len);
-               }
+       for (i = 0; i < bp->nr_vnics; i++) {
+               uint32_t lvl = RTE_ETH_RSS_LEVEL(rss->rss_hf);
+
+               vnic = &bp->vnic_info[i];
+               vnic->hash_type = bnxt_rte_to_hwrm_hash_types(rss->rss_hf);
+               vnic->hash_mode = bnxt_rte_to_hwrm_hash_level(bp, rss->rss_hf, lvl);
+
+               /*
+                * Use the supplied key if the key length is
+                * acceptable and the rss_key is not NULL
+                */
+               if (rss->rss_key && rss->rss_key_len <= HW_HASH_KEY_SIZE)
+                       memcpy(vnic->rss_hash_key, rss->rss_key, rss->rss_key_len);
        }
 
        return rc;
@@ -214,7 +227,9 @@ void bnxt_rx_queue_release_mbufs(struct bnxt_rx_queue *rxq)
                }
        }
        /* Free up mbufs in Agg ring */
-       if (!bnxt_need_agg_ring(rxq->bp->eth_dev))
+       if (rxq->bp == NULL ||
+           rxq->bp->eth_dev == NULL ||
+           !bnxt_need_agg_ring(rxq->bp->eth_dev))
                return;
 
        sw_ring = rxq->rx_ring->ag_buf_ring;
@@ -363,7 +378,7 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,
        PMD_DRV_LOG(DEBUG, "RX Buf size is %d\n", rxq->rx_buf_size);
        rxq->queue_id = queue_idx;
        rxq->port_id = eth_dev->data->port_id;
-       if (rx_offloads & DEV_RX_OFFLOAD_KEEP_CRC)
+       if (rx_offloads & RTE_ETH_RX_OFFLOAD_KEEP_CRC)
                rxq->crc_len = RTE_ETHER_CRC_LEN;
        else
                rxq->crc_len = 0;
@@ -478,7 +493,7 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
        }
        PMD_DRV_LOG(INFO, "Rx queue started %d\n", rx_queue_id);
 
-       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
+       if (dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) {
                vnic = rxq->vnic;
 
                if (BNXT_HAS_RING_GRPS(bp)) {
@@ -549,7 +564,7 @@ int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
        rxq->rx_started = false;
        PMD_DRV_LOG(DEBUG, "Rx queue stopped\n");
 
-       if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
+       if (dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) {
                if (BNXT_HAS_RING_GRPS(bp))
                        vnic->fw_grp_ids[rx_queue_id] = INVALID_HW_RING_ID;
 
@@ -574,6 +589,9 @@ int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)
                if (active_queue_cnt == 0) {
                        uint16_t saved_mru = vnic->mru;
 
+                       /* clear RSS setting on vnic. */
+                       bnxt_vnic_rss_clear_p5(bp, vnic);
+
                        vnic->mru = 0;
                        /* Reconfigure default receive ring and MRU. */
                        bnxt_hwrm_vnic_cfg(bp, vnic);