fix typos using codespell utility
[dpdk.git] / drivers / net / bonding / rte_eth_bond_pmd.c
index 77d3bee..37f3d43 100644 (file)
@@ -36,6 +36,7 @@
 #include <rte_mbuf.h>
 #include <rte_malloc.h>
 #include <rte_ethdev.h>
+#include <rte_ethdev_vdev.h>
 #include <rte_tcp.h>
 #include <rte_udp.h>
 #include <rte_ip.h>
@@ -51,6 +52,7 @@
 #include "rte_eth_bond_8023ad_private.h"
 
 #define REORDER_PERIOD_MS 10
+#define DEFAULT_POLLING_INTERVAL_10_MS (10)
 
 #define HASH_L4_PORTS(h) ((h)->src_port ^ (h)->dst_port)
 
@@ -791,8 +793,8 @@ bond_ethdev_tx_burst_alb(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        uint16_t slave_bufs_pkts[RTE_MAX_ETHPORTS + 1] = { 0 };
 
        /*
-        * We create separate transmit buffers for update packets as they wont be
-        * counted in num_tx_total.
+        * We create separate transmit buffers for update packets as they won't
+        * be counted in num_tx_total.
         */
        struct rte_mbuf *update_bufs[RTE_MAX_ETHPORTS][ALB_HASH_TABLE_SIZE];
        uint16_t update_bufs_pkts[RTE_MAX_ETHPORTS] = { 0 };
@@ -1433,9 +1435,11 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
        }
 
        /* If lsc interrupt is set, check initial slave's link status */
-       if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
+       if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) {
+               slave_eth_dev->dev_ops->link_update(slave_eth_dev, 0);
                bond_ethdev_lsc_event_callback(slave_eth_dev->data->port_id,
                        RTE_ETH_EVENT_INTR_LSC, &bonded_eth_dev->data->port_id);
+       }
 
        return 0;
 }
@@ -1659,7 +1663,22 @@ void
 bond_ethdev_close(struct rte_eth_dev *dev)
 {
        struct bond_dev_private *internals = dev->data->dev_private;
+       uint8_t bond_port_id = internals->port_id;
+       int skipped = 0;
+
+       RTE_LOG(INFO, EAL, "Closing bonded device %s\n", dev->data->name);
+       while (internals->slave_count != skipped) {
+               uint8_t port_id = internals->slaves[skipped].port_id;
+
+               rte_eth_dev_stop(port_id);
 
+               if (rte_eth_bond_slave_remove(bond_port_id, port_id) != 0) {
+                       RTE_LOG(ERR, EAL,
+                               "Failed to remove port %d from bonded device "
+                               "%s\n", port_id, dev->data->name);
+                       skipped++;
+               }
+       }
        bond_ethdev_free_queues(dev);
        rte_bitmap_reset(internals->vlan_filter_bmp);
 }
@@ -1674,8 +1693,9 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 
        dev_info->max_mac_addrs = 1;
 
-       dev_info->max_rx_pktlen = internals->candidate_max_rx_pktlen ?
-                                 internals->candidate_max_rx_pktlen : 2048;
+       dev_info->max_rx_pktlen = internals->candidate_max_rx_pktlen
+                                 ? internals->candidate_max_rx_pktlen
+                                 : ETHER_MAX_JUMBO_FRAME_LEN;
 
        dev_info->max_rx_queues = (uint16_t)128;
        dev_info->max_tx_queues = (uint16_t)512;
@@ -2240,16 +2260,133 @@ const struct eth_dev_ops default_dev_ops = {
 };
 
 static int
-bond_probe(const char *name, const char *params)
+bond_alloc(struct rte_vdev_device *dev, uint8_t mode)
 {
+       const char *name = rte_vdev_device_name(dev);
+       uint8_t socket_id = dev->device.numa_node;
+       struct bond_dev_private *internals = NULL;
+       struct rte_eth_dev *eth_dev = NULL;
+       uint32_t vlan_filter_bmp_size;
+
+       /* now do all data allocation - for eth_dev structure, dummy pci driver
+        * and internal (private) data
+        */
+
+       if (socket_id >= number_of_sockets()) {
+               RTE_BOND_LOG(ERR,
+                               "Invalid socket id specified to create bonded device on.");
+               goto err;
+       }
+
+       /* reserve an ethdev entry */
+       eth_dev = rte_eth_vdev_allocate(dev, sizeof(*internals));
+       if (eth_dev == NULL) {
+               RTE_BOND_LOG(ERR, "Unable to allocate rte_eth_dev");
+               goto err;
+       }
+
+       internals = eth_dev->data->dev_private;
+       eth_dev->data->nb_rx_queues = (uint16_t)1;
+       eth_dev->data->nb_tx_queues = (uint16_t)1;
+
+       eth_dev->data->mac_addrs = rte_zmalloc_socket(name, ETHER_ADDR_LEN, 0,
+                       socket_id);
+       if (eth_dev->data->mac_addrs == NULL) {
+               RTE_BOND_LOG(ERR, "Unable to malloc mac_addrs");
+               goto err;
+       }
+
+       eth_dev->dev_ops = &default_dev_ops;
+       eth_dev->data->dev_flags = RTE_ETH_DEV_INTR_LSC |
+               RTE_ETH_DEV_DETACHABLE;
+
+       rte_spinlock_init(&internals->lock);
+
+       internals->port_id = eth_dev->data->port_id;
+       internals->mode = BONDING_MODE_INVALID;
+       internals->current_primary_port = RTE_MAX_ETHPORTS + 1;
+       internals->balance_xmit_policy = BALANCE_XMIT_POLICY_LAYER2;
+       internals->xmit_hash = xmit_l2_hash;
+       internals->user_defined_mac = 0;
+       internals->link_props_set = 0;
+
+       internals->link_status_polling_enabled = 0;
+
+       internals->link_status_polling_interval_ms =
+               DEFAULT_POLLING_INTERVAL_10_MS;
+       internals->link_down_delay_ms = 0;
+       internals->link_up_delay_ms = 0;
+
+       internals->slave_count = 0;
+       internals->active_slave_count = 0;
+       internals->rx_offload_capa = 0;
+       internals->tx_offload_capa = 0;
+       internals->candidate_max_rx_pktlen = 0;
+       internals->max_rx_pktlen = 0;
+
+       /* Initially allow to choose any offload type */
+       internals->flow_type_rss_offloads = ETH_RSS_PROTO_MASK;
+
+       memset(internals->active_slaves, 0, sizeof(internals->active_slaves));
+       memset(internals->slaves, 0, sizeof(internals->slaves));
+
+       /* Set mode 4 default configuration */
+       bond_mode_8023ad_setup(eth_dev, NULL);
+       if (bond_ethdev_mode_set(eth_dev, mode)) {
+               RTE_BOND_LOG(ERR, "Failed to set bonded device %d mode too %d",
+                                eth_dev->data->port_id, mode);
+               goto err;
+       }
+
+       vlan_filter_bmp_size =
+               rte_bitmap_get_memory_footprint(ETHER_MAX_VLAN_ID + 1);
+       internals->vlan_filter_bmpmem = rte_malloc(name, vlan_filter_bmp_size,
+                                                  RTE_CACHE_LINE_SIZE);
+       if (internals->vlan_filter_bmpmem == NULL) {
+               RTE_BOND_LOG(ERR,
+                            "Failed to allocate vlan bitmap for bonded device %u\n",
+                            eth_dev->data->port_id);
+               goto err;
+       }
+
+       internals->vlan_filter_bmp = rte_bitmap_init(ETHER_MAX_VLAN_ID + 1,
+                       internals->vlan_filter_bmpmem, vlan_filter_bmp_size);
+       if (internals->vlan_filter_bmp == NULL) {
+               RTE_BOND_LOG(ERR,
+                            "Failed to init vlan bitmap for bonded device %u\n",
+                            eth_dev->data->port_id);
+               rte_free(internals->vlan_filter_bmpmem);
+               goto err;
+       }
+
+       return eth_dev->data->port_id;
+
+err:
+       rte_free(internals);
+       if (eth_dev != NULL) {
+               rte_free(eth_dev->data->mac_addrs);
+               rte_eth_dev_release_port(eth_dev);
+       }
+       return -1;
+}
+
+static int
+bond_probe(struct rte_vdev_device *dev)
+{
+       const char *name;
        struct bond_dev_private *internals;
        struct rte_kvargs *kvlist;
        uint8_t bonding_mode, socket_id;
        int  arg_count, port_id;
 
+       if (!dev)
+               return -EINVAL;
+
+       name = rte_vdev_device_name(dev);
        RTE_LOG(INFO, EAL, "Initializing pmd_bond for %s\n", name);
 
-       kvlist = rte_kvargs_parse(params, pmd_bond_init_valid_arguments);
+       kvlist = rte_kvargs_parse(rte_vdev_device_args(dev),
+               pmd_bond_init_valid_arguments);
        if (kvlist == NULL)
                return -1;
 
@@ -2286,8 +2423,10 @@ bond_probe(const char *name, const char *params)
                socket_id = rte_socket_id();
        }
 
+       dev->device.numa_node = socket_id;
+
        /* Create link bonding eth device */
-       port_id = rte_eth_bond_create(name, bonding_mode, socket_id);
+       port_id = bond_alloc(dev, bonding_mode);
        if (port_id < 0) {
                RTE_LOG(ERR, EAL, "Failed to create socket %s in mode %u on "
                                "socket %u.\n", name, bonding_mode, socket_id);
@@ -2307,21 +2446,51 @@ parse_error:
 }
 
 static int
-bond_remove(const char *name)
+bond_remove(struct rte_vdev_device *dev)
 {
-       int  ret;
+       struct rte_eth_dev *eth_dev;
+       struct bond_dev_private *internals;
+       const char *name;
 
-       if (name == NULL)
+       if (!dev)
                return -EINVAL;
 
+       name = rte_vdev_device_name(dev);
        RTE_LOG(INFO, EAL, "Uninitializing pmd_bond for %s\n", name);
 
-       /* free link bonding eth device */
-       ret = rte_eth_bond_free(name);
-       if (ret < 0)
-               RTE_LOG(ERR, EAL, "Failed to free %s\n", name);
+       /* now free all data allocation - for eth_dev structure,
+        * dummy pci driver and internal (private) data
+        */
+
+       /* find an ethdev entry */
+       eth_dev = rte_eth_dev_allocated(name);
+       if (eth_dev == NULL)
+               return -ENODEV;
+
+       RTE_ASSERT(eth_dev->device == &dev->device);
+
+       internals = eth_dev->data->dev_private;
+       if (internals->slave_count != 0)
+               return -EBUSY;
+
+       if (eth_dev->data->dev_started == 1) {
+               bond_ethdev_stop(eth_dev);
+               bond_ethdev_close(eth_dev);
+       }
+
+       eth_dev->dev_ops = NULL;
+       eth_dev->rx_pkt_burst = NULL;
+       eth_dev->tx_pkt_burst = NULL;
+
+       internals = eth_dev->data->dev_private;
+       rte_bitmap_free(internals->vlan_filter_bmp);
+       rte_free(internals->vlan_filter_bmpmem);
+       rte_free(eth_dev->data->dev_private);
+       rte_free(eth_dev->data->mac_addrs);
+
+       rte_eth_dev_release_port(eth_dev);
 
-       return ret;
+       return 0;
 }
 
 /* this part will resolve the slave portids after all the other pdev and vdev