net/dpaa2: fix congestion ID for multiple traffic classes
[dpdk.git] / drivers / net / dpaa2 / dpaa2_ethdev.c
index 47b11c0..d9960b0 100644 (file)
@@ -26,6 +26,7 @@
 #include <dpaa2_hw_dpio.h>
 #include <mc/fsl_dpmng.h>
 #include "dpaa2_ethdev.h"
+#include "dpaa2_sparser.h"
 #include <fsl_qbman_debug.h>
 
 #define DRIVER_LOOPBACK_MODE "drv_loopback"
@@ -44,6 +45,7 @@ static uint64_t dev_rx_offloads_sup =
 
 /* Rx offloads which cannot be disabled */
 static uint64_t dev_rx_offloads_nodis =
+               DEV_RX_OFFLOAD_RSS_HASH |
                DEV_RX_OFFLOAD_SCATTER;
 
 /* Supported Tx offloads */
@@ -117,7 +119,7 @@ dpaa2_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = priv->hw;
+       struct fsl_mc_io *dpni = dev->process_private;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -127,8 +129,8 @@ dpaa2_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
        }
 
        if (on)
-               ret = dpni_add_vlan_id(dpni, CMD_PRI_LOW,
-                                      priv->token, vlan_id);
+               ret = dpni_add_vlan_id(dpni, CMD_PRI_LOW, priv->token,
+                                      vlan_id, 0, 0, 0);
        else
                ret = dpni_remove_vlan_id(dpni, CMD_PRI_LOW,
                                          priv->token, vlan_id);
@@ -144,7 +146,7 @@ static int
 dpaa2_vlan_offload_set(struct rte_eth_dev *dev, int mask)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = priv->hw;
+       struct fsl_mc_io *dpni = dev->process_private;
        int ret;
 
        PMD_INIT_FUNC_TRACE();
@@ -182,7 +184,7 @@ dpaa2_vlan_tpid_set(struct rte_eth_dev *dev,
                      uint16_t tpid)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = priv->hw;
+       struct fsl_mc_io *dpni = dev->process_private;
        int ret = -ENOTSUP;
 
        PMD_INIT_FUNC_TRACE();
@@ -220,8 +222,7 @@ dpaa2_fw_version_get(struct rte_eth_dev *dev,
                     size_t fw_size)
 {
        int ret;
-       struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = priv->hw;
+       struct fsl_mc_io *dpni = dev->process_private;
        struct mc_soc_version mc_plat_info = {0};
        struct mc_version mc_ver_info = {0};
 
@@ -274,6 +275,15 @@ dpaa2_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        dev_info->max_vmdq_pools = ETH_16_POOLS;
        dev_info->flow_type_rss_offloads = DPAA2_RSS_OFFLOAD_ALL;
 
+       dev_info->default_rxportconf.burst_size = dpaa2_dqrr_size;
+       /* same is rx size for best perf */
+       dev_info->default_txportconf.burst_size = dpaa2_dqrr_size;
+
+       dev_info->default_rxportconf.nb_queues = 1;
+       dev_info->default_txportconf.nb_queues = 1;
+       dev_info->default_txportconf.ring_size = CONG_ENTER_TX_THRESHOLD;
+       dev_info->default_rxportconf.ring_size = DPAA2_RX_DEFAULT_NBDESC;
+
        return 0;
 }
 
@@ -430,7 +440,7 @@ static int
 dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = priv->hw;
+       struct fsl_mc_io *dpni = dev->process_private;
        struct rte_eth_conf *eth_conf = &dev->data->dev_conf;
        uint64_t rx_offloads = eth_conf->rxmode.offloads;
        uint64_t tx_offloads = eth_conf->txmode.offloads;
@@ -552,9 +562,6 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
        if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
                dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK);
 
-       /* update the current status */
-       dpaa2_dev_link_update(dev, 0);
-
        return 0;
 }
 
@@ -570,7 +577,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
                         struct rte_mempool *mb_pool)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        struct dpaa2_queue *dpaa2_q;
        struct dpni_queue cfg;
        uint8_t options = 0;
@@ -662,7 +669,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
                                                DPNI_CP_CONGESTION_GROUP,
                                                DPNI_QUEUE_RX,
                                                dpaa2_q->tc_index,
-                                               flow_id, &taildrop);
+                                               dpaa2_q->cgid, &taildrop);
                } else {
                        /*enabling per rx queue congestion control */
                        taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q;
@@ -689,7 +696,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
                        ret = dpni_set_taildrop(dpni, CMD_PRI_LOW, priv->token,
                                        DPNI_CP_CONGESTION_GROUP, DPNI_QUEUE_RX,
                                        dpaa2_q->tc_index,
-                                       flow_id, &taildrop);
+                                       dpaa2_q->cgid, &taildrop);
                } else {
                        ret = dpni_set_taildrop(dpni, CMD_PRI_LOW, priv->token,
                                        DPNI_CP_QUEUE, DPNI_QUEUE_RX,
@@ -718,7 +725,7 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,
                priv->tx_vq[tx_queue_id];
        struct dpaa2_queue *dpaa2_tx_conf_q = (struct dpaa2_queue *)
                priv->tx_conf_vq[tx_queue_id];
-       struct fsl_mc_io *dpni = priv->hw;
+       struct fsl_mc_io *dpni = dev->process_private;
        struct dpni_queue tx_conf_cfg;
        struct dpni_queue tx_flow_cfg;
        uint8_t options = 0, flow_id;
@@ -844,7 +851,8 @@ dpaa2_dev_rx_queue_release(void *q __rte_unused)
 {
        struct dpaa2_queue *dpaa2_q = (struct dpaa2_queue *)q;
        struct dpaa2_dev_priv *priv = dpaa2_q->eth_data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni =
+               (struct fsl_mc_io *)priv->eth_dev->process_private;
        uint8_t options = 0;
        int ret;
        struct dpni_queue cfg;
@@ -883,12 +891,12 @@ dpaa2_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
        struct qbman_fq_query_np_rslt state;
        uint32_t frame_cnt = 0;
 
-       PMD_INIT_FUNC_TRACE();
-
        if (unlikely(!DPAA2_PER_LCORE_DPIO)) {
                ret = dpaa2_affine_qbman_swp();
                if (ret) {
-                       DPAA2_PMD_ERR("Failure in affining portal");
+                       DPAA2_PMD_ERR(
+                               "Failed to allocate IO portal, tid: %d\n",
+                               rte_gettid());
                        return -EINVAL;
                }
        }
@@ -898,7 +906,7 @@ dpaa2_dev_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 
        if (qbman_fq_query_state(swp, dpaa2_q->fqid, &state) == 0) {
                frame_cnt = qbman_fq_state_frame_count(&state);
-               DPAA2_PMD_DEBUG("RX frame count for q(%d) is %u",
+               DPAA2_PMD_DP_DEBUG("RX frame count for q(%d) is %u",
                                rx_queue_id, frame_cnt);
        }
        return frame_cnt;
@@ -942,7 +950,7 @@ dpaa2_interrupt_handler(void *param)
 {
        struct rte_eth_dev *dev = param;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        int ret;
        int irq_index = DPNI_IRQ_INDEX;
        unsigned int status = 0, clear = 0;
@@ -981,7 +989,7 @@ dpaa2_eth_setup_irqs(struct rte_eth_dev *dev, int enable)
 {
        int err = 0;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        int irq_index = DPNI_IRQ_INDEX;
        unsigned int mask = DPNI_IRQ_EVENT_LINK_CHANGED;
 
@@ -1011,7 +1019,7 @@ dpaa2_dev_start(struct rte_eth_dev *dev)
        struct rte_dpaa2_device *dpaa2_dev;
        struct rte_eth_dev_data *data = dev->data;
        struct dpaa2_dev_priv *priv = data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        struct dpni_queue cfg;
        struct dpni_error_cfg   err_cfg;
        uint16_t qdid;
@@ -1104,7 +1112,7 @@ static void
 dpaa2_dev_stop(struct rte_eth_dev *dev)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        int ret;
        struct rte_eth_link link;
        struct rte_intr_handle *intr_handle = dev->intr_handle;
@@ -1144,7 +1152,7 @@ static void
 dpaa2_dev_close(struct rte_eth_dev *dev)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        int ret;
        struct rte_eth_link link;
 
@@ -1169,7 +1177,7 @@ dpaa2_dev_promiscuous_enable(
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -1195,7 +1203,7 @@ dpaa2_dev_promiscuous_disable(
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -1225,7 +1233,7 @@ dpaa2_dev_allmulticast_enable(
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -1246,7 +1254,7 @@ dpaa2_dev_allmulticast_disable(struct rte_eth_dev *dev)
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -1271,7 +1279,7 @@ dpaa2_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        uint32_t frame_size = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN
                                + VLAN_TAG_SIZE;
 
@@ -1287,7 +1295,7 @@ dpaa2_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
                return -EINVAL;
 
        if (frame_size > RTE_ETHER_MAX_LEN)
-               dev->data->dev_conf.rxmode.offloads &=
+               dev->data->dev_conf.rxmode.offloads |=
                                                DEV_RX_OFFLOAD_JUMBO_FRAME;
        else
                dev->data->dev_conf.rxmode.offloads &=
@@ -1316,7 +1324,7 @@ dpaa2_dev_add_mac_addr(struct rte_eth_dev *dev,
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -1325,8 +1333,8 @@ dpaa2_dev_add_mac_addr(struct rte_eth_dev *dev,
                return -1;
        }
 
-       ret = dpni_add_mac_addr(dpni, CMD_PRI_LOW,
-                               priv->token, addr->addr_bytes);
+       ret = dpni_add_mac_addr(dpni, CMD_PRI_LOW, priv->token,
+                               addr->addr_bytes, 0, 0, 0);
        if (ret)
                DPAA2_PMD_ERR(
                        "error: Adding the MAC ADDR failed: err = %d", ret);
@@ -1339,7 +1347,7 @@ dpaa2_dev_remove_mac_addr(struct rte_eth_dev *dev,
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        struct rte_eth_dev_data *data = dev->data;
        struct rte_ether_addr *macaddr;
 
@@ -1365,7 +1373,7 @@ dpaa2_dev_set_mac_addr(struct rte_eth_dev *dev,
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -1389,7 +1397,7 @@ int dpaa2_dev_stats_get(struct rte_eth_dev *dev,
                         struct rte_eth_stats *stats)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        int32_t  retcode;
        uint8_t page0 = 0, page1 = 1, page2 = 2;
        union dpni_statistics value;
@@ -1469,7 +1477,7 @@ dpaa2_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
                     unsigned int n)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        int32_t  retcode;
        union dpni_statistics value[5] = {};
        unsigned int i = 0, num = RTE_DIM(dpaa2_xstats_strings);
@@ -1549,7 +1557,8 @@ dpaa2_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
 
        if (!ids) {
                struct dpaa2_dev_priv *priv = dev->data->dev_private;
-               struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+               struct fsl_mc_io *dpni =
+                       (struct fsl_mc_io *)dev->process_private;
                int32_t  retcode;
                union dpni_statistics value[5] = {};
 
@@ -1631,7 +1640,7 @@ static int
 dpaa2_dev_stats_reset(struct rte_eth_dev *dev)
 {
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        int retcode;
        int i;
        struct dpaa2_queue *dpaa2_q;
@@ -1674,7 +1683,7 @@ dpaa2_dev_link_update(struct rte_eth_dev *dev,
 {
        int ret;
        struct dpaa2_dev_priv *priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        struct rte_eth_link link;
        struct dpni_link_state state = {0};
 
@@ -1722,7 +1731,7 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
        struct dpni_link_state state = {0};
 
        priv = dev->data->dev_private;
-       dpni = (struct fsl_mc_io *)priv->hw;
+       dpni = (struct fsl_mc_io *)dev->process_private;
 
        if (dpni == NULL) {
                DPAA2_PMD_ERR("dpni is NULL");
@@ -1754,6 +1763,7 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
        /* changing tx burst function to start enqueues */
        dev->tx_pkt_burst = dpaa2_dev_tx;
        dev->data->dev_link.link_status = state.up;
+       dev->data->dev_link.link_speed = state.rate;
 
        if (state.up)
                DPAA2_PMD_INFO("Port %d Link is Up", dev->data->port_id);
@@ -1778,7 +1788,7 @@ dpaa2_dev_set_link_down(struct rte_eth_dev *dev)
        PMD_INIT_FUNC_TRACE();
 
        priv = dev->data->dev_private;
-       dpni = (struct fsl_mc_io *)priv->hw;
+       dpni = (struct fsl_mc_io *)dev->process_private;
 
        if (dpni == NULL) {
                DPAA2_PMD_ERR("Device has not yet been configured");
@@ -1832,7 +1842,7 @@ dpaa2_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        PMD_INIT_FUNC_TRACE();
 
        priv = dev->data->dev_private;
-       dpni = (struct fsl_mc_io *)priv->hw;
+       dpni = (struct fsl_mc_io *)dev->process_private;
 
        if (dpni == NULL || fc_conf == NULL) {
                DPAA2_PMD_ERR("device not configured");
@@ -1888,7 +1898,7 @@ dpaa2_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        PMD_INIT_FUNC_TRACE();
 
        priv = dev->data->dev_private;
-       dpni = (struct fsl_mc_io *)priv->hw;
+       dpni = (struct fsl_mc_io *)dev->process_private;
 
        if (dpni == NULL) {
                DPAA2_PMD_ERR("dpni is NULL");
@@ -2004,15 +2014,15 @@ dpaa2_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
 
 int dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev,
                int eth_rx_queue_id,
-               uint16_t dpcon_id,
+               struct dpaa2_dpcon_dev *dpcon,
                const struct rte_event_eth_rx_adapter_queue_conf *queue_conf)
 {
        struct dpaa2_dev_priv *eth_priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)eth_priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        struct dpaa2_queue *dpaa2_ethq = eth_priv->rx_vq[eth_rx_queue_id];
        uint8_t flow_id = dpaa2_ethq->flow_id;
        struct dpni_queue cfg;
-       uint8_t options;
+       uint8_t options, priority;
        int ret;
 
        if (queue_conf->ev.sched_type == RTE_SCHED_TYPE_PARALLEL)
@@ -2024,11 +2034,14 @@ int dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev,
        else
                return -EINVAL;
 
+       priority = (RTE_EVENT_DEV_PRIORITY_LOWEST / queue_conf->ev.priority) *
+                  (dpcon->num_priorities - 1);
+
        memset(&cfg, 0, sizeof(struct dpni_queue));
        options = DPNI_QUEUE_OPT_DEST;
        cfg.destination.type = DPNI_DEST_DPCON;
-       cfg.destination.id = dpcon_id;
-       cfg.destination.priority = queue_conf->ev.priority;
+       cfg.destination.id = dpcon->dpcon_id;
+       cfg.destination.priority = priority;
 
        if (queue_conf->ev.sched_type == RTE_SCHED_TYPE_ATOMIC) {
                options |= DPNI_QUEUE_OPT_HOLD_ACTIVE;
@@ -2089,7 +2102,7 @@ int dpaa2_eth_eventq_detach(const struct rte_eth_dev *dev,
                int eth_rx_queue_id)
 {
        struct dpaa2_dev_priv *eth_priv = dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)eth_priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)dev->process_private;
        struct dpaa2_queue *dpaa2_ethq = eth_priv->rx_vq[eth_rx_queue_id];
        uint8_t flow_id = dpaa2_ethq->flow_id;
        struct dpni_queue cfg;
@@ -2188,6 +2201,15 @@ static struct eth_dev_ops dpaa2_ethdev_ops = {
        .rss_hash_update      = dpaa2_dev_rss_hash_update,
        .rss_hash_conf_get    = dpaa2_dev_rss_hash_conf_get,
        .filter_ctrl          = dpaa2_dev_flow_ctrl,
+#if defined(RTE_LIBRTE_IEEE1588)
+       .timesync_enable      = dpaa2_timesync_enable,
+       .timesync_disable     = dpaa2_timesync_disable,
+       .timesync_read_time   = dpaa2_timesync_read_time,
+       .timesync_write_time  = dpaa2_timesync_write_time,
+       .timesync_adjust_time = dpaa2_timesync_adjust_time,
+       .timesync_read_rx_timestamp = dpaa2_timesync_read_rx_timestamp,
+       .timesync_read_tx_timestamp = dpaa2_timesync_read_tx_timestamp,
+#endif
 };
 
 /* Populate the mac address from physically available (u-boot/firmware) and/or
@@ -2309,6 +2331,14 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
 
        PMD_INIT_FUNC_TRACE();
 
+       dpni_dev = rte_malloc(NULL, sizeof(struct fsl_mc_io), 0);
+       if (!dpni_dev) {
+               DPAA2_PMD_ERR("Memory allocation failed for dpni device");
+               return -1;
+       }
+       dpni_dev->regs = rte_mcp_ptr_list[0];
+       eth_dev->process_private = (void *)dpni_dev;
+
        /* For secondary processes, the primary has done all the work */
        if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
                /* In case of secondary, only burst and ops API need to be
@@ -2329,14 +2359,6 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
        dpaa2_dev = container_of(dev, struct rte_dpaa2_device, device);
 
        hw_id = dpaa2_dev->object_id;
-
-       dpni_dev = rte_malloc(NULL, sizeof(struct fsl_mc_io), 0);
-       if (!dpni_dev) {
-               DPAA2_PMD_ERR("Memory allocation failed for dpni device");
-               return -1;
-       }
-
-       dpni_dev->regs = rte_mcp_ptr_list[0];
        ret = dpni_open(dpni_dev, CMD_PRI_LOW, hw_id, &priv->token);
        if (ret) {
                DPAA2_PMD_ERR(
@@ -2499,6 +2521,29 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
                goto init_err;
        }
 
+       /*TODO To enable soft parser support DPAA2 driver needs to integrate
+        * with external entity to receive byte code for software sequence
+        * and same will be offload to the H/W using MC interface.
+        * Currently it is assumed that DPAA2 driver has byte code by some
+        * mean and same if offloaded to H/W.
+        */
+       if (getenv("DPAA2_ENABLE_SOFT_PARSER")) {
+               WRIOP_SS_INITIALIZER(priv);
+               ret = dpaa2_eth_load_wriop_soft_parser(priv, DPNI_SS_INGRESS);
+               if (ret < 0) {
+                       DPAA2_PMD_ERR(" Error(%d) in loading softparser\n",
+                                     ret);
+                       return ret;
+               }
+
+               ret = dpaa2_eth_enable_wriop_soft_parser(priv,
+                                                        DPNI_SS_INGRESS);
+               if (ret < 0) {
+                       DPAA2_PMD_ERR(" Error(%d) in enabling softparser\n",
+                                     ret);
+                       return ret;
+               }
+       }
        RTE_LOG(INFO, PMD, "%s: netdev created\n", eth_dev->data->name);
        return 0;
 init_err:
@@ -2510,7 +2555,7 @@ static int
 dpaa2_dev_uninit(struct rte_eth_dev *eth_dev)
 {
        struct dpaa2_dev_priv *priv = eth_dev->data->dev_private;
-       struct fsl_mc_io *dpni = (struct fsl_mc_io *)priv->hw;
+       struct fsl_mc_io *dpni = (struct fsl_mc_io *)eth_dev->process_private;
        int i, ret;
 
        PMD_INIT_FUNC_TRACE();
@@ -2537,6 +2582,7 @@ dpaa2_dev_uninit(struct rte_eth_dev *eth_dev)
 
        /* Free the allocated memory for ethernet private data and dpni*/
        priv->hw = NULL;
+       eth_dev->process_private = NULL;
        rte_free(dpni);
 
        for (i = 0; i < MAX_TCS; i++) {
@@ -2560,7 +2606,7 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv,
                struct rte_dpaa2_device *dpaa2_dev)
 {
        struct rte_eth_dev *eth_dev;
-       struct dpaa2_dev_priv *priv;
+       struct dpaa2_dev_priv *dev_priv;
        int diag;
 
        if ((DPAA2_MBUF_HW_ANNOTATION + DPAA2_FD_PTA_SIZE) >
@@ -2577,20 +2623,25 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv,
                eth_dev = rte_eth_dev_allocate(dpaa2_dev->device.name);
                if (!eth_dev)
                        return -ENODEV;
-               eth_dev->data->dev_private = rte_zmalloc(
-                                               "ethdev private structure",
-                                               sizeof(struct dpaa2_dev_priv),
-                                               RTE_CACHE_LINE_SIZE);
-               if (eth_dev->data->dev_private == NULL) {
+               dev_priv = rte_zmalloc("ethdev private structure",
+                                      sizeof(struct dpaa2_dev_priv),
+                                      RTE_CACHE_LINE_SIZE);
+               if (dev_priv == NULL) {
                        DPAA2_PMD_CRIT(
                                "Unable to allocate memory for private data");
                        rte_eth_dev_release_port(eth_dev);
                        return -ENOMEM;
                }
+               eth_dev->data->dev_private = (void *)dev_priv;
+               /* Store a pointer to eth_dev in dev_private */
+               dev_priv->eth_dev = eth_dev;
+               dev_priv->tx_conf_en = 0;
        } else {
                eth_dev = rte_eth_dev_attach_secondary(dpaa2_dev->device.name);
-               if (!eth_dev)
+               if (!eth_dev) {
+                       DPAA2_PMD_DEBUG("returning enodev");
                        return -ENODEV;
+               }
        }
 
        eth_dev->device = &dpaa2_dev->device;
@@ -2608,9 +2659,6 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv,
                return 0;
        }
 
-       priv = eth_dev->data->dev_private;
-       priv->tx_conf_en = 0;
-
        rte_eth_dev_release_port(eth_dev);
        return diag;
 }