net/ixgbe: check driver type in MACsec API
[dpdk.git] / drivers / net / ena / base / ena_eth_com.c
index 459e0bb..80d3555 100644 (file)
@@ -1,39 +1,11 @@
-/*-
-* BSD LICENSE
-*
-* Copyright (c) 2015-2016 Amazon.com, Inc. or its affiliates.
-* All rights reserved.
-*
-* Redistribution and use in source and binary forms, with or without
-* modification, are permitted provided that the following conditions
-* are met:
-*
-* * Redistributions of source code must retain the above copyright
-* notice, this list of conditions and the following disclaimer.
-* * Redistributions in binary form must reproduce the above copyright
-* notice, this list of conditions and the following disclaimer in
-* the documentation and/or other materials provided with the
-* distribution.
-* * Neither the name of copyright holder nor the names of its
-* contributors may be used to endorse or promote products derived
-* from this software without specific prior written permission.
-*
-* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-*/
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2015-2020 Amazon.com, Inc. or its affiliates.
+ * All rights reserved.
+ */
 
 #include "ena_eth_com.h"
 
-static inline struct ena_eth_io_rx_cdesc_base *ena_com_get_next_rx_cdesc(
+static struct ena_eth_io_rx_cdesc_base *ena_com_get_next_rx_cdesc(
        struct ena_com_io_cq *io_cq)
 {
        struct ena_eth_io_rx_cdesc_base *cdesc;
@@ -43,29 +15,24 @@ static inline struct ena_eth_io_rx_cdesc_base *ena_com_get_next_rx_cdesc(
        head_masked = io_cq->head & (io_cq->q_depth - 1);
        expected_phase = io_cq->phase;
 
-       cdesc = (struct ena_eth_io_rx_cdesc_base *)
-               ((unsigned char *)io_cq->cdesc_addr.virt_addr
+       cdesc = (struct ena_eth_io_rx_cdesc_base *)(io_cq->cdesc_addr.virt_addr
                        + (head_masked * io_cq->cdesc_entry_size_in_bytes));
 
-       desc_phase = (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_PHASE_MASK) >>
+       desc_phase = (READ_ONCE32(cdesc->status) & ENA_ETH_IO_RX_CDESC_BASE_PHASE_MASK) >>
                        ENA_ETH_IO_RX_CDESC_BASE_PHASE_SHIFT;
 
        if (desc_phase != expected_phase)
                return NULL;
 
-       return cdesc;
-}
-
-static inline void ena_com_cq_inc_head(struct ena_com_io_cq *io_cq)
-{
-       io_cq->head++;
+       /* Make sure we read the rest of the descriptor after the phase bit
+        * has been read
+        */
+       dma_rmb();
 
-       /* Switch phase bit in case of wrap around */
-       if (unlikely((io_cq->head & (io_cq->q_depth - 1)) == 0))
-               io_cq->phase = 1 - io_cq->phase;
+       return cdesc;
 }
 
-static inline void *get_sq_desc(struct ena_com_io_sq *io_sq)
+static void *get_sq_desc_regular_queue(struct ena_com_io_sq *io_sq)
 {
        u16 tail_masked;
        u32 offset;
@@ -74,61 +41,192 @@ static inline void *get_sq_desc(struct ena_com_io_sq *io_sq)
 
        offset = tail_masked * io_sq->desc_entry_size;
 
-       return (unsigned char *)io_sq->desc_addr.virt_addr + offset;
+       return (void *)((uintptr_t)io_sq->desc_addr.virt_addr + offset);
 }
 
-static inline void ena_com_copy_curr_sq_desc_to_dev(struct ena_com_io_sq *io_sq)
+static int ena_com_write_bounce_buffer_to_dev(struct ena_com_io_sq *io_sq,
+                                                    u8 *bounce_buffer)
 {
-       u16 tail_masked = io_sq->tail & (io_sq->q_depth - 1);
-       u32 offset = tail_masked * io_sq->desc_entry_size;
+       struct ena_com_llq_info *llq_info = &io_sq->llq_info;
 
-       /* In case this queue isn't a LLQ */
-       if (io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_HOST)
-               return;
+       u16 dst_tail_mask;
+       u32 dst_offset;
 
-       memcpy_toio((unsigned char *)io_sq->desc_addr.pbuf_dev_addr + offset,
-                   (unsigned char *)io_sq->desc_addr.virt_addr + offset,
-                   io_sq->desc_entry_size);
-}
+       dst_tail_mask = io_sq->tail & (io_sq->q_depth - 1);
+       dst_offset = dst_tail_mask * llq_info->desc_list_entry_size;
+
+       if (is_llq_max_tx_burst_exists(io_sq)) {
+               if (unlikely(!io_sq->entries_in_tx_burst_left)) {
+                       ena_trc_err("Error: trying to send more packets than tx burst allows\n");
+                       return ENA_COM_NO_SPACE;
+               }
+
+               io_sq->entries_in_tx_burst_left--;
+               ena_trc_dbg("decreasing entries_in_tx_burst_left of queue %d to %d\n",
+                           io_sq->qid, io_sq->entries_in_tx_burst_left);
+       }
+
+       /* Make sure everything was written into the bounce buffer before
+        * writing the bounce buffer to the device
+        */
+       wmb();
+
+       /* The line is completed. Copy it to dev */
+       ENA_MEMCPY_TO_DEVICE_64(io_sq->desc_addr.pbuf_dev_addr + dst_offset,
+                               bounce_buffer,
+                               llq_info->desc_list_entry_size);
 
-static inline void ena_com_sq_update_tail(struct ena_com_io_sq *io_sq)
-{
        io_sq->tail++;
 
        /* Switch phase bit in case of wrap around */
        if (unlikely((io_sq->tail & (io_sq->q_depth - 1)) == 0))
-               io_sq->phase = 1 - io_sq->phase;
+               io_sq->phase ^= 1;
+
+       return ENA_COM_OK;
 }
 
-static inline int ena_com_write_header(struct ena_com_io_sq *io_sq,
-                                      u8 *head_src, u16 header_len)
+static int ena_com_write_header_to_bounce(struct ena_com_io_sq *io_sq,
+                                                u8 *header_src,
+                                                u16 header_len)
 {
-       u16 tail_masked = io_sq->tail & (io_sq->q_depth - 1);
-       u8 __iomem *dev_head_addr =
-               io_sq->header_addr + (tail_masked * io_sq->tx_max_header_size);
+       struct ena_com_llq_pkt_ctrl *pkt_ctrl = &io_sq->llq_buf_ctrl;
+       struct ena_com_llq_info *llq_info = &io_sq->llq_info;
+       u8 *bounce_buffer = pkt_ctrl->curr_bounce_buf;
+       u16 header_offset;
 
-       if (io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_HOST)
+       if (unlikely(io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_HOST))
                return 0;
 
-       ENA_ASSERT(io_sq->header_addr, "header address is NULL\n");
+       header_offset =
+               llq_info->descs_num_before_header * io_sq->desc_entry_size;
+
+       if (unlikely((header_offset + header_len) >  llq_info->desc_list_entry_size)) {
+               ena_trc_err("trying to write header larger than llq entry can accommodate\n");
+               return ENA_COM_FAULT;
+       }
 
-       memcpy_toio(dev_head_addr, head_src, header_len);
+       if (unlikely(!bounce_buffer)) {
+               ena_trc_err("bounce buffer is NULL\n");
+               return ENA_COM_FAULT;
+       }
+
+       memcpy(bounce_buffer + header_offset, header_src, header_len);
 
        return 0;
 }
 
-static inline struct ena_eth_io_rx_cdesc_base *
+static void *get_sq_desc_llq(struct ena_com_io_sq *io_sq)
+{
+       struct ena_com_llq_pkt_ctrl *pkt_ctrl = &io_sq->llq_buf_ctrl;
+       u8 *bounce_buffer;
+       void *sq_desc;
+
+       bounce_buffer = pkt_ctrl->curr_bounce_buf;
+
+       if (unlikely(!bounce_buffer)) {
+               ena_trc_err("bounce buffer is NULL\n");
+               return NULL;
+       }
+
+       sq_desc = bounce_buffer + pkt_ctrl->idx * io_sq->desc_entry_size;
+       pkt_ctrl->idx++;
+       pkt_ctrl->descs_left_in_line--;
+
+       return sq_desc;
+}
+
+static int ena_com_close_bounce_buffer(struct ena_com_io_sq *io_sq)
+{
+       struct ena_com_llq_pkt_ctrl *pkt_ctrl = &io_sq->llq_buf_ctrl;
+       struct ena_com_llq_info *llq_info = &io_sq->llq_info;
+       int rc;
+
+       if (unlikely(io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_HOST))
+               return ENA_COM_OK;
+
+       /* bounce buffer was used, so write it and get a new one */
+       if (pkt_ctrl->idx) {
+               rc = ena_com_write_bounce_buffer_to_dev(io_sq,
+                                                       pkt_ctrl->curr_bounce_buf);
+               if (unlikely(rc)) {
+                       ena_trc_err("failed to write bounce buffer to device\n");
+                       return rc;
+               }
+
+               pkt_ctrl->curr_bounce_buf =
+                       ena_com_get_next_bounce_buffer(&io_sq->bounce_buf_ctrl);
+               memset(io_sq->llq_buf_ctrl.curr_bounce_buf,
+                      0x0, llq_info->desc_list_entry_size);
+       }
+
+       pkt_ctrl->idx = 0;
+       pkt_ctrl->descs_left_in_line = llq_info->descs_num_before_header;
+       return ENA_COM_OK;
+}
+
+static void *get_sq_desc(struct ena_com_io_sq *io_sq)
+{
+       if (io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV)
+               return get_sq_desc_llq(io_sq);
+
+       return get_sq_desc_regular_queue(io_sq);
+}
+
+static int ena_com_sq_update_llq_tail(struct ena_com_io_sq *io_sq)
+{
+       struct ena_com_llq_pkt_ctrl *pkt_ctrl = &io_sq->llq_buf_ctrl;
+       struct ena_com_llq_info *llq_info = &io_sq->llq_info;
+       int rc;
+
+       if (!pkt_ctrl->descs_left_in_line) {
+               rc = ena_com_write_bounce_buffer_to_dev(io_sq,
+                                                       pkt_ctrl->curr_bounce_buf);
+               if (unlikely(rc)) {
+                       ena_trc_err("failed to write bounce buffer to device\n");
+                       return rc;
+               }
+
+               pkt_ctrl->curr_bounce_buf =
+                       ena_com_get_next_bounce_buffer(&io_sq->bounce_buf_ctrl);
+                       memset(io_sq->llq_buf_ctrl.curr_bounce_buf,
+                              0x0, llq_info->desc_list_entry_size);
+
+               pkt_ctrl->idx = 0;
+               if (unlikely(llq_info->desc_stride_ctrl == ENA_ADMIN_SINGLE_DESC_PER_ENTRY))
+                       pkt_ctrl->descs_left_in_line = 1;
+               else
+                       pkt_ctrl->descs_left_in_line =
+                       llq_info->desc_list_entry_size / io_sq->desc_entry_size;
+       }
+
+       return ENA_COM_OK;
+}
+
+static int ena_com_sq_update_tail(struct ena_com_io_sq *io_sq)
+{
+       if (io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV)
+               return ena_com_sq_update_llq_tail(io_sq);
+
+       io_sq->tail++;
+
+       /* Switch phase bit in case of wrap around */
+       if (unlikely((io_sq->tail & (io_sq->q_depth - 1)) == 0))
+               io_sq->phase ^= 1;
+
+       return ENA_COM_OK;
+}
+
+static struct ena_eth_io_rx_cdesc_base *
        ena_com_rx_cdesc_idx_to_ptr(struct ena_com_io_cq *io_cq, u16 idx)
 {
        idx &= (io_cq->q_depth - 1);
        return (struct ena_eth_io_rx_cdesc_base *)
-               ((unsigned char *)io_cq->cdesc_addr.virt_addr +
-                       idx * io_cq->cdesc_entry_size_in_bytes);
+               ((uintptr_t)io_cq->cdesc_addr.virt_addr +
+               idx * io_cq->cdesc_entry_size_in_bytes);
 }
 
-static inline int ena_com_cdesc_rx_pkt_get(struct ena_com_io_cq *io_cq,
-                                          u16 *first_cdesc_idx,
-                                          u16 *nb_hw_desc)
+static u16 ena_com_cdesc_rx_pkt_get(struct ena_com_io_cq *io_cq,
+                                          u16 *first_cdesc_idx)
 {
        struct ena_eth_io_rx_cdesc_base *cdesc;
        u16 count = 0, head_masked;
@@ -141,7 +239,7 @@ static inline int ena_com_cdesc_rx_pkt_get(struct ena_com_io_cq *io_cq,
 
                ena_com_cq_inc_head(io_cq);
                count++;
-               last = (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_LAST_MASK) >>
+               last = (READ_ONCE32(cdesc->status) & ENA_ETH_IO_RX_CDESC_BASE_LAST_MASK) >>
                        ENA_ETH_IO_RX_CDESC_BASE_LAST_SHIFT;
        } while (!last);
 
@@ -161,33 +259,13 @@ static inline int ena_com_cdesc_rx_pkt_get(struct ena_com_io_cq *io_cq,
                count = 0;
        }
 
-       *nb_hw_desc = count;
-       return 0;
+       return count;
 }
 
-static inline bool ena_com_meta_desc_changed(struct ena_com_io_sq *io_sq,
-                                            struct ena_com_tx_ctx *ena_tx_ctx)
-{
-       int rc;
-
-       if (ena_tx_ctx->meta_valid) {
-               rc = memcmp(&io_sq->cached_tx_meta,
-                           &ena_tx_ctx->ena_meta,
-                           sizeof(struct ena_com_tx_meta));
-
-               if (unlikely(rc != 0))
-                       return true;
-       }
-
-       return false;
-}
-
-static inline void ena_com_create_and_store_tx_meta_desc(
-       struct ena_com_io_sq *io_sq,
-       struct ena_com_tx_ctx *ena_tx_ctx)
+static int ena_com_create_meta(struct ena_com_io_sq *io_sq,
+                              struct ena_com_tx_meta *ena_meta)
 {
        struct ena_eth_io_tx_meta_desc *meta_desc = NULL;
-       struct ena_com_tx_meta *ena_meta = &ena_tx_ctx->ena_meta;
 
        meta_desc = get_sq_desc(io_sq);
        memset(meta_desc, 0x0, sizeof(struct ena_eth_io_tx_meta_desc));
@@ -202,17 +280,18 @@ static inline void ena_com_create_and_store_tx_meta_desc(
                ENA_ETH_IO_TX_META_DESC_MSS_LO_MASK;
        /* bits 10-13 of the mss */
        meta_desc->len_ctrl |= ((ena_meta->mss >> 10) <<
-               ENA_ETH_IO_TX_META_DESC_MSS_HI_PTP_SHIFT) &
-               ENA_ETH_IO_TX_META_DESC_MSS_HI_PTP_MASK;
+               ENA_ETH_IO_TX_META_DESC_MSS_HI_SHIFT) &
+               ENA_ETH_IO_TX_META_DESC_MSS_HI_MASK;
 
        /* Extended meta desc */
        meta_desc->len_ctrl |= ENA_ETH_IO_TX_META_DESC_ETH_META_TYPE_MASK;
-       meta_desc->len_ctrl |= ENA_ETH_IO_TX_META_DESC_META_STORE_MASK;
        meta_desc->len_ctrl |= (io_sq->phase <<
                ENA_ETH_IO_TX_META_DESC_PHASE_SHIFT) &
                ENA_ETH_IO_TX_META_DESC_PHASE_MASK;
 
        meta_desc->len_ctrl |= ENA_ETH_IO_TX_META_DESC_FIRST_MASK;
+       meta_desc->len_ctrl |= ENA_ETH_IO_TX_META_DESC_META_STORE_MASK;
+
        meta_desc->word2 |= ena_meta->l3_hdr_len &
                ENA_ETH_IO_TX_META_DESC_L3_HDR_LEN_MASK;
        meta_desc->word2 |= (ena_meta->l3_hdr_offset <<
@@ -223,30 +302,53 @@ static inline void ena_com_create_and_store_tx_meta_desc(
                ENA_ETH_IO_TX_META_DESC_L4_HDR_LEN_IN_WORDS_SHIFT) &
                ENA_ETH_IO_TX_META_DESC_L4_HDR_LEN_IN_WORDS_MASK;
 
-       meta_desc->len_ctrl |= ENA_ETH_IO_TX_META_DESC_META_STORE_MASK;
+       return ena_com_sq_update_tail(io_sq);
+}
 
-       /* Cached the meta desc */
-       memcpy(&io_sq->cached_tx_meta, ena_meta,
-              sizeof(struct ena_com_tx_meta));
+static int ena_com_create_and_store_tx_meta_desc(struct ena_com_io_sq *io_sq,
+                                                struct ena_com_tx_ctx *ena_tx_ctx,
+                                                bool *have_meta)
+{
+       struct ena_com_tx_meta *ena_meta = &ena_tx_ctx->ena_meta;
 
-       ena_com_copy_curr_sq_desc_to_dev(io_sq);
-       ena_com_sq_update_tail(io_sq);
+       /* When disable meta caching is set, don't bother to save the meta and
+        * compare it to the stored version, just create the meta
+        */
+       if (io_sq->disable_meta_caching) {
+               if (unlikely(!ena_tx_ctx->meta_valid))
+                       return ENA_COM_INVAL;
+
+               *have_meta = true;
+               return ena_com_create_meta(io_sq, ena_meta);
+       } else if (ena_com_meta_desc_changed(io_sq, ena_tx_ctx)) {
+               *have_meta = true;
+               /* Cache the meta desc */
+               memcpy(&io_sq->cached_tx_meta, ena_meta,
+                      sizeof(struct ena_com_tx_meta));
+               return ena_com_create_meta(io_sq, ena_meta);
+       } else {
+               *have_meta = false;
+               return ENA_COM_OK;
+       }
 }
 
-static inline void ena_com_rx_set_flags(struct ena_com_rx_ctx *ena_rx_ctx,
+static void ena_com_rx_set_flags(struct ena_com_rx_ctx *ena_rx_ctx,
                                        struct ena_eth_io_rx_cdesc_base *cdesc)
 {
-       ena_rx_ctx->l3_proto = (enum ena_eth_io_l3_proto_index)(cdesc->status &
-               ENA_ETH_IO_RX_CDESC_BASE_L3_PROTO_IDX_MASK);
-       ena_rx_ctx->l4_proto = (enum ena_eth_io_l4_proto_index)
-               ((cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L4_PROTO_IDX_MASK) >>
-               ENA_ETH_IO_RX_CDESC_BASE_L4_PROTO_IDX_SHIFT);
+       ena_rx_ctx->l3_proto = cdesc->status &
+               ENA_ETH_IO_RX_CDESC_BASE_L3_PROTO_IDX_MASK;
+       ena_rx_ctx->l4_proto =
+               (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L4_PROTO_IDX_MASK) >>
+               ENA_ETH_IO_RX_CDESC_BASE_L4_PROTO_IDX_SHIFT;
        ena_rx_ctx->l3_csum_err =
-               (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L3_CSUM_ERR_MASK) >>
-               ENA_ETH_IO_RX_CDESC_BASE_L3_CSUM_ERR_SHIFT;
+               !!((cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L3_CSUM_ERR_MASK) >>
+               ENA_ETH_IO_RX_CDESC_BASE_L3_CSUM_ERR_SHIFT);
        ena_rx_ctx->l4_csum_err =
-               (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_ERR_MASK) >>
-               ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_ERR_SHIFT;
+               !!((cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_ERR_MASK) >>
+               ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_ERR_SHIFT);
+       ena_rx_ctx->l4_csum_checked =
+               !!((cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_CHECKED_MASK) >>
+               ENA_ETH_IO_RX_CDESC_BASE_L4_CSUM_CHECKED_SHIFT);
        ena_rx_ctx->hash = cdesc->hash;
        ena_rx_ctx->frag =
                (cdesc->status & ENA_ETH_IO_RX_CDESC_BASE_IPV4_FRAG_MASK) >>
@@ -272,19 +374,20 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,
 {
        struct ena_eth_io_tx_desc *desc = NULL;
        struct ena_com_buf *ena_bufs = ena_tx_ctx->ena_bufs;
-       void *push_header = ena_tx_ctx->push_header;
+       void *buffer_to_push = ena_tx_ctx->push_header;
        u16 header_len = ena_tx_ctx->header_len;
        u16 num_bufs = ena_tx_ctx->num_bufs;
-       int total_desc, i, rc;
+       u16 start_tail = io_sq->tail;
+       int i, rc;
        bool have_meta;
        u64 addr_hi;
 
-       ENA_ASSERT(io_sq->direction == ENA_COM_IO_QUEUE_DIRECTION_TX,
-                  "wrong Q type");
+       ENA_WARN(io_sq->direction != ENA_COM_IO_QUEUE_DIRECTION_TX,
+                "wrong Q type");
 
        /* num_bufs +1 for potential meta desc */
-       if (ena_com_sq_empty_space(io_sq) < (num_bufs + 1)) {
-               ena_trc_err("Not enough space in the tx queue\n");
+       if (unlikely(!ena_com_sq_have_enough_space(io_sq, num_bufs + 1))) {
+               ena_trc_dbg("Not enough space in the tx queue\n");
                return ENA_COM_NO_MEM;
        }
 
@@ -294,23 +397,34 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,
                return ENA_COM_INVAL;
        }
 
-       /* start with pushing the header (if needed) */
-       rc = ena_com_write_header(io_sq, push_header, header_len);
+       if (unlikely(io_sq->mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV
+                    && !buffer_to_push)) {
+               ena_trc_err("push header wasn't provided on LLQ mode\n");
+               return ENA_COM_INVAL;
+       }
+
+       rc = ena_com_write_header_to_bounce(io_sq, buffer_to_push, header_len);
        if (unlikely(rc))
                return rc;
 
-       have_meta = ena_tx_ctx->meta_valid && ena_com_meta_desc_changed(io_sq,
-                       ena_tx_ctx);
-       if (have_meta)
-               ena_com_create_and_store_tx_meta_desc(io_sq, ena_tx_ctx);
+       rc = ena_com_create_and_store_tx_meta_desc(io_sq, ena_tx_ctx, &have_meta);
+       if (unlikely(rc)) {
+               ena_trc_err("failed to create and store tx meta desc\n");
+               return rc;
+       }
 
-       /* If the caller doesn't want send packets */
+       /* If the caller doesn't want to send packets */
        if (unlikely(!num_bufs && !header_len)) {
-               *nb_hw_desc = have_meta ? 0 : 1;
-               return 0;
+               rc = ena_com_close_bounce_buffer(io_sq);
+               if (rc)
+                       ena_trc_err("failed to write buffers to LLQ\n");
+               *nb_hw_desc = io_sq->tail - start_tail;
+               return rc;
        }
 
        desc = get_sq_desc(io_sq);
+       if (unlikely(!desc))
+               return ENA_COM_FAULT;
        memset(desc, 0x0, sizeof(struct ena_eth_io_tx_desc));
 
        /* Set first desc when we don't have meta descriptor */
@@ -362,10 +476,16 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,
        for (i = 0; i < num_bufs; i++) {
                /* The first desc share the same desc as the header */
                if (likely(i != 0)) {
-                       ena_com_copy_curr_sq_desc_to_dev(io_sq);
-                       ena_com_sq_update_tail(io_sq);
+                       rc = ena_com_sq_update_tail(io_sq);
+                       if (unlikely(rc)) {
+                               ena_trc_err("failed to update sq tail\n");
+                               return rc;
+                       }
 
                        desc = get_sq_desc(io_sq);
+                       if (unlikely(!desc))
+                               return ENA_COM_FAULT;
+
                        memset(desc, 0x0, sizeof(struct ena_eth_io_tx_desc));
 
                        desc->len_ctrl |= (io_sq->phase <<
@@ -388,15 +508,18 @@ int ena_com_prepare_tx(struct ena_com_io_sq *io_sq,
        /* set the last desc indicator */
        desc->len_ctrl |= ENA_ETH_IO_TX_DESC_LAST_MASK;
 
-       ena_com_copy_curr_sq_desc_to_dev(io_sq);
-
-       ena_com_sq_update_tail(io_sq);
+       rc = ena_com_sq_update_tail(io_sq);
+       if (unlikely(rc)) {
+               ena_trc_err("failed to update sq tail of the last descriptor\n");
+               return rc;
+       }
 
-       total_desc = ENA_MAX16(num_bufs, 1);
-       total_desc += have_meta ? 1 : 0;
+       rc = ena_com_close_bounce_buffer(io_sq);
+       if (rc)
+               ena_trc_err("failed when closing bounce buffer\n");
 
-       *nb_hw_desc = total_desc;
-       return 0;
+       *nb_hw_desc = io_sq->tail - start_tail;
+       return rc;
 }
 
 int ena_com_rx_pkt(struct ena_com_io_cq *io_cq,
@@ -407,34 +530,34 @@ int ena_com_rx_pkt(struct ena_com_io_cq *io_cq,
        struct ena_eth_io_rx_cdesc_base *cdesc = NULL;
        u16 cdesc_idx = 0;
        u16 nb_hw_desc;
-       u16 i;
-       int rc;
+       u16 i = 0;
 
-       ENA_ASSERT(io_cq->direction == ENA_COM_IO_QUEUE_DIRECTION_RX,
-                  "wrong Q type");
+       ENA_WARN(io_cq->direction != ENA_COM_IO_QUEUE_DIRECTION_RX,
+                "wrong Q type");
 
-       rc = ena_com_cdesc_rx_pkt_get(io_cq, &cdesc_idx, &nb_hw_desc);
-       if (rc || (nb_hw_desc == 0)) {
+       nb_hw_desc = ena_com_cdesc_rx_pkt_get(io_cq, &cdesc_idx);
+       if (nb_hw_desc == 0) {
                ena_rx_ctx->descs = nb_hw_desc;
-               return rc;
+               return 0;
        }
 
        ena_trc_dbg("fetch rx packet: queue %d completed desc: %d\n",
                    io_cq->qid, nb_hw_desc);
 
-       if (unlikely(nb_hw_desc >= ena_rx_ctx->max_bufs)) {
+       if (unlikely(nb_hw_desc > ena_rx_ctx->max_bufs)) {
                ena_trc_err("Too many RX cdescs (%d) > MAX(%d)\n",
                            nb_hw_desc, ena_rx_ctx->max_bufs);
                return ENA_COM_NO_SPACE;
        }
 
-       for (i = 0; i < nb_hw_desc; i++) {
-               cdesc = ena_com_rx_cdesc_idx_to_ptr(io_cq, cdesc_idx + i);
+       cdesc = ena_com_rx_cdesc_idx_to_ptr(io_cq, cdesc_idx);
+       ena_rx_ctx->pkt_offset = cdesc->offset;
 
+       do {
                ena_buf->len = cdesc->length;
                ena_buf->req_id = cdesc->req_id;
                ena_buf++;
-       }
+       } while ((++i < nb_hw_desc) && (cdesc = ena_com_rx_cdesc_idx_to_ptr(io_cq, cdesc_idx + i)));
 
        /* Update SQ head ptr */
        io_sq->next_to_comp += nb_hw_desc;
@@ -455,54 +578,41 @@ int ena_com_add_single_rx_desc(struct ena_com_io_sq *io_sq,
 {
        struct ena_eth_io_rx_desc *desc;
 
-       ENA_ASSERT(io_sq->direction == ENA_COM_IO_QUEUE_DIRECTION_RX,
-                  "wrong Q type");
+       ENA_WARN(io_sq->direction != ENA_COM_IO_QUEUE_DIRECTION_RX,
+                "wrong Q type");
 
-       if (unlikely(ena_com_sq_empty_space(io_sq) == 0))
-               return -1;
+       if (unlikely(!ena_com_sq_have_enough_space(io_sq, 1)))
+               return ENA_COM_NO_SPACE;
 
        desc = get_sq_desc(io_sq);
+       if (unlikely(!desc))
+               return ENA_COM_FAULT;
+
        memset(desc, 0x0, sizeof(struct ena_eth_io_rx_desc));
 
        desc->length = ena_buf->len;
 
-       desc->ctrl |= ENA_ETH_IO_RX_DESC_FIRST_MASK;
-       desc->ctrl |= ENA_ETH_IO_RX_DESC_LAST_MASK;
-       desc->ctrl |= io_sq->phase & ENA_ETH_IO_RX_DESC_PHASE_MASK;
-       desc->ctrl |= ENA_ETH_IO_RX_DESC_COMP_REQ_MASK;
+       desc->ctrl = ENA_ETH_IO_RX_DESC_FIRST_MASK |
+               ENA_ETH_IO_RX_DESC_LAST_MASK |
+               (io_sq->phase & ENA_ETH_IO_RX_DESC_PHASE_MASK) |
+               ENA_ETH_IO_RX_DESC_COMP_REQ_MASK;
 
        desc->req_id = req_id;
 
        desc->buff_addr_lo = (u32)ena_buf->paddr;
        desc->buff_addr_hi =
-               ((ena_buf->paddr &
-                 GENMASK_ULL(io_sq->dma_addr_bits - 1, 32)) >> 32);
-
-       ena_com_sq_update_tail(io_sq);
+               ((ena_buf->paddr & GENMASK_ULL(io_sq->dma_addr_bits - 1, 32)) >> 32);
 
-       return 0;
+       return ena_com_sq_update_tail(io_sq);
 }
 
-int ena_com_tx_comp_req_id_get(struct ena_com_io_cq *io_cq, u16 *req_id)
+bool ena_com_cq_empty(struct ena_com_io_cq *io_cq)
 {
-       u8 expected_phase, cdesc_phase;
-       struct ena_eth_io_tx_cdesc *cdesc;
-       u16 masked_head;
-
-       masked_head = io_cq->head & (io_cq->q_depth - 1);
-       expected_phase = io_cq->phase;
-
-       cdesc = (struct ena_eth_io_tx_cdesc *)
-               ((unsigned char *)io_cq->cdesc_addr.virt_addr
-               + (masked_head * io_cq->cdesc_entry_size_in_bytes));
-
-       cdesc_phase = cdesc->flags & ENA_ETH_IO_TX_CDESC_PHASE_MASK;
-       if (cdesc_phase != expected_phase)
-               return -1;
-
-       ena_com_cq_inc_head(io_cq);
-
-       *req_id = cdesc->req_id;
+       struct ena_eth_io_rx_cdesc_base *cdesc;
 
-       return 0;
+       cdesc = ena_com_get_next_rx_cdesc(io_cq);
+       if (cdesc)
+               return false;
+       else
+               return true;
 }