net/qede: fix few log messages
[dpdk.git] / drivers / net / enic / enic_flow.c
index 44efe4b..28923b0 100644 (file)
@@ -1,37 +1,10 @@
-/*
- * Copyright (c) 2017, Cisco Systems, Inc.
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- *
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in
- * the documentation and/or other materials provided with the
- * distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
- * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
- * COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
- * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
- * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
- * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
- * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
- * POSSIBILITY OF SUCH DAMAGE.
- *
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2008-2017 Cisco Systems, Inc.  All rights reserved.
  */
 
 #include <errno.h>
 #include <rte_log.h>
-#include <rte_ethdev.h>
+#include <rte_ethdev_driver.h>
 #include <rte_flow_driver.h>
 #include <rte_ether.h>
 #include <rte_ip.h>
 #include "vnic_dev.h"
 #include "vnic_nic.h"
 
-#ifdef RTE_LIBRTE_ENIC_DEBUG_FLOW
 #define FLOW_TRACE() \
-       RTE_LOG(DEBUG, PMD, "%s()\n", __func__)
+       rte_log(RTE_LOG_DEBUG, enicpmd_logtype_flow, \
+               "%s()\n", __func__)
 #define FLOW_LOG(level, fmt, args...) \
-       RTE_LOG(level, PMD, fmt, ## args)
-#else
-#define FLOW_TRACE() do { } while (0)
-#define FLOW_LOG(level, fmt, args...) do { } while (0)
-#endif
+       rte_log(RTE_LOG_ ## level, enicpmd_logtype_flow, \
+               fmt "\n", ##args)
 
 /** Info about how to copy items into enic filters. */
 struct enic_items {
@@ -89,6 +59,9 @@ struct enic_action_cap {
 };
 
 /* Forward declarations */
+static enic_copy_item_fn enic_copy_item_ipv4_v1;
+static enic_copy_item_fn enic_copy_item_udp_v1;
+static enic_copy_item_fn enic_copy_item_tcp_v1;
 static enic_copy_item_fn enic_copy_item_eth_v2;
 static enic_copy_item_fn enic_copy_item_vlan_v2;
 static enic_copy_item_fn enic_copy_item_ipv4_v2;
@@ -98,8 +71,115 @@ static enic_copy_item_fn enic_copy_item_tcp_v2;
 static enic_copy_item_fn enic_copy_item_sctp_v2;
 static enic_copy_item_fn enic_copy_item_sctp_v2;
 static enic_copy_item_fn enic_copy_item_vxlan_v2;
+static copy_action_fn enic_copy_action_v1;
 static copy_action_fn enic_copy_action_v2;
 
+/**
+ * Legacy NICs or NICs with outdated firmware. Only 5-tuple perfect match
+ * is supported.
+ */
+static const struct enic_items enic_items_v1[] = {
+       [RTE_FLOW_ITEM_TYPE_IPV4] = {
+               .copy_item = enic_copy_item_ipv4_v1,
+               .valid_start_item = 1,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+       [RTE_FLOW_ITEM_TYPE_UDP] = {
+               .copy_item = enic_copy_item_udp_v1,
+               .valid_start_item = 0,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_IPV4,
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+       [RTE_FLOW_ITEM_TYPE_TCP] = {
+               .copy_item = enic_copy_item_tcp_v1,
+               .valid_start_item = 0,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_IPV4,
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+};
+
+/**
+ * NICs have Advanced Filters capability but they are disabled. This means
+ * that layer 3 must be specified.
+ */
+static const struct enic_items enic_items_v2[] = {
+       [RTE_FLOW_ITEM_TYPE_ETH] = {
+               .copy_item = enic_copy_item_eth_v2,
+               .valid_start_item = 1,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_VXLAN,
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+       [RTE_FLOW_ITEM_TYPE_VLAN] = {
+               .copy_item = enic_copy_item_vlan_v2,
+               .valid_start_item = 1,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_ETH,
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+       [RTE_FLOW_ITEM_TYPE_IPV4] = {
+               .copy_item = enic_copy_item_ipv4_v2,
+               .valid_start_item = 1,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_ETH,
+                              RTE_FLOW_ITEM_TYPE_VLAN,
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+       [RTE_FLOW_ITEM_TYPE_IPV6] = {
+               .copy_item = enic_copy_item_ipv6_v2,
+               .valid_start_item = 1,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_ETH,
+                              RTE_FLOW_ITEM_TYPE_VLAN,
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+       [RTE_FLOW_ITEM_TYPE_UDP] = {
+               .copy_item = enic_copy_item_udp_v2,
+               .valid_start_item = 0,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_IPV4,
+                              RTE_FLOW_ITEM_TYPE_IPV6,
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+       [RTE_FLOW_ITEM_TYPE_TCP] = {
+               .copy_item = enic_copy_item_tcp_v2,
+               .valid_start_item = 0,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_IPV4,
+                              RTE_FLOW_ITEM_TYPE_IPV6,
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+       [RTE_FLOW_ITEM_TYPE_SCTP] = {
+               .copy_item = enic_copy_item_sctp_v2,
+               .valid_start_item = 0,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_IPV4,
+                              RTE_FLOW_ITEM_TYPE_IPV6,
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+       [RTE_FLOW_ITEM_TYPE_VXLAN] = {
+               .copy_item = enic_copy_item_vxlan_v2,
+               .valid_start_item = 0,
+               .prev_items = (const enum rte_flow_item_type[]) {
+                              RTE_FLOW_ITEM_TYPE_UDP,
+                              RTE_FLOW_ITEM_TYPE_END,
+               },
+       },
+};
+
 /** NICs with Advanced filters enabled */
 static const struct enic_items enic_items_v3[] = {
        [RTE_FLOW_ITEM_TYPE_ETH] = {
@@ -175,11 +255,23 @@ static const struct enic_items enic_items_v3[] = {
 
 /** Filtering capabilities indexed this NICs supported filter type. */
 static const struct enic_filter_cap enic_filter_cap[] = {
+       [FILTER_IPV4_5TUPLE] = {
+               .item_info = enic_items_v1,
+       },
+       [FILTER_USNIC_IP] = {
+               .item_info = enic_items_v2,
+       },
        [FILTER_DPDK_1] = {
                .item_info = enic_items_v3,
        },
 };
 
+/** Supported actions for older NICs */
+static const enum rte_flow_action_type enic_supported_actions_v1[] = {
+       RTE_FLOW_ACTION_TYPE_QUEUE,
+       RTE_FLOW_ACTION_TYPE_END,
+};
+
 /** Supported actions for newer NICs */
 static const enum rte_flow_action_type enic_supported_actions_v2[] = {
        RTE_FLOW_ACTION_TYPE_QUEUE,
@@ -190,11 +282,180 @@ static const enum rte_flow_action_type enic_supported_actions_v2[] = {
 
 /** Action capabilities indexed by NIC version information */
 static const struct enic_action_cap enic_action_cap[] = {
+       [FILTER_ACTION_RQ_STEERING_FLAG] = {
+               .actions = enic_supported_actions_v1,
+               .copy_fn = enic_copy_action_v1,
+       },
        [FILTER_ACTION_V2_ALL] = {
                .actions = enic_supported_actions_v2,
                .copy_fn = enic_copy_action_v2,
        },
 };
+
+static int
+mask_exact_match(const u8 *supported, const u8 *supplied,
+                unsigned int size)
+{
+       unsigned int i;
+       for (i = 0; i < size; i++) {
+               if (supported[i] != supplied[i])
+                       return 0;
+       }
+       return 1;
+}
+
+/**
+ * Copy IPv4 item into version 1 NIC filter.
+ *
+ * @param item[in]
+ *   Item specification.
+ * @param enic_filter[out]
+ *   Partially filled in NIC filter structure.
+ * @param inner_ofst[in]
+ *   Should always be 0 for version 1.
+ */
+static int
+enic_copy_item_ipv4_v1(const struct rte_flow_item *item,
+                      struct filter_v2 *enic_filter, u8 *inner_ofst)
+{
+       const struct rte_flow_item_ipv4 *spec = item->spec;
+       const struct rte_flow_item_ipv4 *mask = item->mask;
+       struct filter_ipv4_5tuple *enic_5tup = &enic_filter->u.ipv4;
+       struct ipv4_hdr supported_mask = {
+               .src_addr = 0xffffffff,
+               .dst_addr = 0xffffffff,
+       };
+
+       FLOW_TRACE();
+
+       if (*inner_ofst)
+               return ENOTSUP;
+
+       if (!mask)
+               mask = &rte_flow_item_ipv4_mask;
+
+       /* This is an exact match filter, both fields must be set */
+       if (!spec || !spec->hdr.src_addr || !spec->hdr.dst_addr) {
+               FLOW_LOG(ERR, "IPv4 exact match src/dst addr");
+               return ENOTSUP;
+       }
+
+       /* check that the suppied mask exactly matches capabilty */
+       if (!mask_exact_match((const u8 *)&supported_mask,
+                             (const u8 *)item->mask, sizeof(*mask))) {
+               FLOW_LOG(ERR, "IPv4 exact match mask");
+               return ENOTSUP;
+       }
+
+       enic_filter->u.ipv4.flags = FILTER_FIELDS_IPV4_5TUPLE;
+       enic_5tup->src_addr = spec->hdr.src_addr;
+       enic_5tup->dst_addr = spec->hdr.dst_addr;
+
+       return 0;
+}
+
+/**
+ * Copy UDP item into version 1 NIC filter.
+ *
+ * @param item[in]
+ *   Item specification.
+ * @param enic_filter[out]
+ *   Partially filled in NIC filter structure.
+ * @param inner_ofst[in]
+ *   Should always be 0 for version 1.
+ */
+static int
+enic_copy_item_udp_v1(const struct rte_flow_item *item,
+                     struct filter_v2 *enic_filter, u8 *inner_ofst)
+{
+       const struct rte_flow_item_udp *spec = item->spec;
+       const struct rte_flow_item_udp *mask = item->mask;
+       struct filter_ipv4_5tuple *enic_5tup = &enic_filter->u.ipv4;
+       struct udp_hdr supported_mask = {
+               .src_port = 0xffff,
+               .dst_port = 0xffff,
+       };
+
+       FLOW_TRACE();
+
+       if (*inner_ofst)
+               return ENOTSUP;
+
+       if (!mask)
+               mask = &rte_flow_item_udp_mask;
+
+       /* This is an exact match filter, both ports must be set */
+       if (!spec || !spec->hdr.src_port || !spec->hdr.dst_port) {
+               FLOW_LOG(ERR, "UDP exact match src/dst addr");
+               return ENOTSUP;
+       }
+
+       /* check that the suppied mask exactly matches capabilty */
+       if (!mask_exact_match((const u8 *)&supported_mask,
+                             (const u8 *)item->mask, sizeof(*mask))) {
+               FLOW_LOG(ERR, "UDP exact match mask");
+               return ENOTSUP;
+       }
+
+       enic_filter->u.ipv4.flags = FILTER_FIELDS_IPV4_5TUPLE;
+       enic_5tup->src_port = spec->hdr.src_port;
+       enic_5tup->dst_port = spec->hdr.dst_port;
+       enic_5tup->protocol = PROTO_UDP;
+
+       return 0;
+}
+
+/**
+ * Copy TCP item into version 1 NIC filter.
+ *
+ * @param item[in]
+ *   Item specification.
+ * @param enic_filter[out]
+ *   Partially filled in NIC filter structure.
+ * @param inner_ofst[in]
+ *   Should always be 0 for version 1.
+ */
+static int
+enic_copy_item_tcp_v1(const struct rte_flow_item *item,
+                     struct filter_v2 *enic_filter, u8 *inner_ofst)
+{
+       const struct rte_flow_item_tcp *spec = item->spec;
+       const struct rte_flow_item_tcp *mask = item->mask;
+       struct filter_ipv4_5tuple *enic_5tup = &enic_filter->u.ipv4;
+       struct tcp_hdr supported_mask = {
+               .src_port = 0xffff,
+               .dst_port = 0xffff,
+       };
+
+       FLOW_TRACE();
+
+       if (*inner_ofst)
+               return ENOTSUP;
+
+       if (!mask)
+               mask = &rte_flow_item_tcp_mask;
+
+       /* This is an exact match filter, both ports must be set */
+       if (!spec || !spec->hdr.src_port || !spec->hdr.dst_port) {
+               FLOW_LOG(ERR, "TCPIPv4 exact match src/dst addr");
+               return ENOTSUP;
+       }
+
+       /* check that the suppied mask exactly matches capabilty */
+       if (!mask_exact_match((const u8 *)&supported_mask,
+                            (const u8 *)item->mask, sizeof(*mask))) {
+               FLOW_LOG(ERR, "TCP exact match mask");
+               return ENOTSUP;
+       }
+
+       enic_filter->u.ipv4.flags = FILTER_FIELDS_IPV4_5TUPLE;
+       enic_5tup->src_port = spec->hdr.src_port;
+       enic_5tup->dst_port = spec->hdr.dst_port;
+       enic_5tup->protocol = PROTO_TCP;
+
+       return 0;
+}
+
 /**
  * Copy ETH item into version 2 NIC filter.
  *
@@ -640,7 +901,6 @@ enic_copy_filter(const struct rte_flow_item pattern[],
        enum rte_flow_item_type prev_item;
        const struct enic_items *item_info;
 
-       enic_filter->type = FILTER_DPDK_1;
        u8 is_first_item = 1;
 
        FLOW_TRACE();
@@ -678,6 +938,44 @@ stacking_error:
                           item, "stacking error");
        return -rte_errno;
 }
+
+/**
+ * Build the intenal version 1 NIC action structure from the provided pattern.
+ * The pattern is validated as the items are copied.
+ *
+ * @param actions[in]
+ * @param enic_action[out]
+ *   NIC specfilc actions derived from the actions.
+ * @param error[out]
+ */
+static int
+enic_copy_action_v1(const struct rte_flow_action actions[],
+                   struct filter_action_v2 *enic_action)
+{
+       FLOW_TRACE();
+
+       for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
+               if (actions->type == RTE_FLOW_ACTION_TYPE_VOID)
+                       continue;
+
+               switch (actions->type) {
+               case RTE_FLOW_ACTION_TYPE_QUEUE: {
+                       const struct rte_flow_action_queue *queue =
+                               (const struct rte_flow_action_queue *)
+                               actions->conf;
+                       enic_action->rq_idx =
+                               enic_rte_rq_idx_to_sop_idx(queue->index);
+                       break;
+               }
+               default:
+                       RTE_ASSERT(0);
+                       break;
+               }
+       }
+       enic_action->type = FILTER_ACTION_RQ_STEERING;
+       return 0;
+}
+
 /**
  * Build the intenal version 2 NIC action structure from the provided pattern.
  * The pattern is validated as the items are copied.
@@ -751,10 +1049,6 @@ enic_match_action(const struct rte_flow_action *action,
 static const struct enic_filter_cap *
 enic_get_filter_cap(struct enic *enic)
 {
-       /* FIXME: only support advanced filters for now */
-       if (enic->flow_filter_mode != FILTER_DPDK_1)
-               return (const struct enic_filter_cap *)NULL;
-
        if (enic->flow_filter_mode)
                return &enic_filter_cap[enic->flow_filter_mode];
 
@@ -769,8 +1063,146 @@ enic_get_action_cap(struct enic *enic)
 
        if (enic->filter_tags)
                ea = &enic_action_cap[FILTER_ACTION_V2_ALL];
+       else
+               ea = &enic_action_cap[FILTER_ACTION_RQ_STEERING_FLAG];
        return ea;
 }
+
+/* Debug function to dump internal NIC action structure. */
+static void
+enic_dump_actions(const struct filter_action_v2 *ea)
+{
+       if (ea->type == FILTER_ACTION_RQ_STEERING) {
+               FLOW_LOG(INFO, "Action(V1), queue: %u\n", ea->rq_idx);
+       } else if (ea->type == FILTER_ACTION_V2) {
+               FLOW_LOG(INFO, "Actions(V2)\n");
+               if (ea->flags & FILTER_ACTION_RQ_STEERING_FLAG)
+                       FLOW_LOG(INFO, "\tqueue: %u\n",
+                              enic_sop_rq_idx_to_rte_idx(ea->rq_idx));
+               if (ea->flags & FILTER_ACTION_FILTER_ID_FLAG)
+                       FLOW_LOG(INFO, "\tfilter_id: %u\n", ea->filter_id);
+       }
+}
+
+/* Debug function to dump internal NIC filter structure. */
+static void
+enic_dump_filter(const struct filter_v2 *filt)
+{
+       const struct filter_generic_1 *gp;
+       int i, j, mbyte;
+       char buf[128], *bp;
+       char ip4[16], ip6[16], udp[16], tcp[16], tcpudp[16], ip4csum[16];
+       char l4csum[16], ipfrag[16];
+
+       switch (filt->type) {
+       case FILTER_IPV4_5TUPLE:
+               FLOW_LOG(INFO, "FILTER_IPV4_5TUPLE\n");
+               break;
+       case FILTER_USNIC_IP:
+       case FILTER_DPDK_1:
+               /* FIXME: this should be a loop */
+               gp = &filt->u.generic_1;
+               FLOW_LOG(INFO, "Filter: vlan: 0x%04x, mask: 0x%04x\n",
+                      gp->val_vlan, gp->mask_vlan);
+
+               if (gp->mask_flags & FILTER_GENERIC_1_IPV4)
+                       sprintf(ip4, "%s ",
+                               (gp->val_flags & FILTER_GENERIC_1_IPV4)
+                                ? "ip4(y)" : "ip4(n)");
+               else
+                       sprintf(ip4, "%s ", "ip4(x)");
+
+               if (gp->mask_flags & FILTER_GENERIC_1_IPV6)
+                       sprintf(ip6, "%s ",
+                               (gp->val_flags & FILTER_GENERIC_1_IPV4)
+                                ? "ip6(y)" : "ip6(n)");
+               else
+                       sprintf(ip6, "%s ", "ip6(x)");
+
+               if (gp->mask_flags & FILTER_GENERIC_1_UDP)
+                       sprintf(udp, "%s ",
+                               (gp->val_flags & FILTER_GENERIC_1_UDP)
+                                ? "udp(y)" : "udp(n)");
+               else
+                       sprintf(udp, "%s ", "udp(x)");
+
+               if (gp->mask_flags & FILTER_GENERIC_1_TCP)
+                       sprintf(tcp, "%s ",
+                               (gp->val_flags & FILTER_GENERIC_1_TCP)
+                                ? "tcp(y)" : "tcp(n)");
+               else
+                       sprintf(tcp, "%s ", "tcp(x)");
+
+               if (gp->mask_flags & FILTER_GENERIC_1_TCP_OR_UDP)
+                       sprintf(tcpudp, "%s ",
+                               (gp->val_flags & FILTER_GENERIC_1_TCP_OR_UDP)
+                                ? "tcpudp(y)" : "tcpudp(n)");
+               else
+                       sprintf(tcpudp, "%s ", "tcpudp(x)");
+
+               if (gp->mask_flags & FILTER_GENERIC_1_IP4SUM_OK)
+                       sprintf(ip4csum, "%s ",
+                               (gp->val_flags & FILTER_GENERIC_1_IP4SUM_OK)
+                                ? "ip4csum(y)" : "ip4csum(n)");
+               else
+                       sprintf(ip4csum, "%s ", "ip4csum(x)");
+
+               if (gp->mask_flags & FILTER_GENERIC_1_L4SUM_OK)
+                       sprintf(l4csum, "%s ",
+                               (gp->val_flags & FILTER_GENERIC_1_L4SUM_OK)
+                                ? "l4csum(y)" : "l4csum(n)");
+               else
+                       sprintf(l4csum, "%s ", "l4csum(x)");
+
+               if (gp->mask_flags & FILTER_GENERIC_1_IPFRAG)
+                       sprintf(ipfrag, "%s ",
+                               (gp->val_flags & FILTER_GENERIC_1_IPFRAG)
+                                ? "ipfrag(y)" : "ipfrag(n)");
+               else
+                       sprintf(ipfrag, "%s ", "ipfrag(x)");
+               FLOW_LOG(INFO, "\tFlags: %s%s%s%s%s%s%s%s\n", ip4, ip6, udp,
+                        tcp, tcpudp, ip4csum, l4csum, ipfrag);
+
+               for (i = 0; i < FILTER_GENERIC_1_NUM_LAYERS; i++) {
+                       mbyte = FILTER_GENERIC_1_KEY_LEN - 1;
+                       while (mbyte && !gp->layer[i].mask[mbyte])
+                               mbyte--;
+                       if (mbyte == 0)
+                               continue;
+
+                       bp = buf;
+                       for (j = 0; j <= mbyte; j++) {
+                               sprintf(bp, "%02x",
+                                       gp->layer[i].mask[j]);
+                               bp += 2;
+                       }
+                       *bp = '\0';
+                       FLOW_LOG(INFO, "\tL%u mask: %s\n", i + 2, buf);
+                       bp = buf;
+                       for (j = 0; j <= mbyte; j++) {
+                               sprintf(bp, "%02x",
+                                       gp->layer[i].val[j]);
+                               bp += 2;
+                       }
+                       *bp = '\0';
+                       FLOW_LOG(INFO, "\tL%u  val: %s\n", i + 2, buf);
+               }
+               break;
+       default:
+               FLOW_LOG(INFO, "FILTER UNKNOWN\n");
+               break;
+       }
+}
+
+/* Debug function to dump internal NIC flow structures. */
+static void
+enic_dump_flow(const struct filter_action_v2 *ea, const struct filter_v2 *filt)
+{
+       enic_dump_filter(filt);
+       enic_dump_actions(ea);
+}
+
+
 /**
  * Internal flow parse/validate function.
  *
@@ -881,6 +1313,7 @@ enic_flow_parse(struct rte_eth_dev *dev,
                           NULL, "Flow API not available");
                return -rte_errno;
        }
+       enic_filter->type = enic->flow_filter_mode;
        ret = enic_copy_filter(pattern, enic_filter_cap->item_info,
                                       enic_filter, error);
        return ret;
@@ -981,6 +1414,8 @@ enic_flow_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attrs,
 
        ret = enic_flow_parse(dev, attrs, pattern, actions, error,
                               &enic_filter, &enic_action);
+       if (!ret)
+               enic_dump_flow(&enic_action, &enic_filter);
        return ret;
 }