net/mlx5: fix vport index in port action
[dpdk.git] / drivers / net / enic / enic_flow.c
index d188e58..6cd3640 100644 (file)
 #include "vnic_dev.h"
 #include "vnic_nic.h"
 
-#define FLOW_TRACE() \
-       rte_log(RTE_LOG_DEBUG, enicpmd_logtype_flow, \
-               "%s()\n", __func__)
-#define FLOW_LOG(level, fmt, args...) \
-       rte_log(RTE_LOG_ ## level, enicpmd_logtype_flow, \
-               fmt "\n", ##args)
-
 /*
  * Common arguments passed to copy_item functions. Use this structure
  * so we can easily add new arguments.
@@ -360,17 +353,6 @@ static const enum rte_flow_action_type enic_supported_actions_v2_drop[] = {
        RTE_FLOW_ACTION_TYPE_END,
 };
 
-static const enum rte_flow_action_type enic_supported_actions_v2_count[] = {
-       RTE_FLOW_ACTION_TYPE_QUEUE,
-       RTE_FLOW_ACTION_TYPE_MARK,
-       RTE_FLOW_ACTION_TYPE_FLAG,
-       RTE_FLOW_ACTION_TYPE_DROP,
-       RTE_FLOW_ACTION_TYPE_COUNT,
-       RTE_FLOW_ACTION_TYPE_RSS,
-       RTE_FLOW_ACTION_TYPE_PASSTHRU,
-       RTE_FLOW_ACTION_TYPE_END,
-};
-
 /** Action capabilities indexed by NIC version information */
 static const struct enic_action_cap enic_action_cap[] = {
        [FILTER_ACTION_RQ_STEERING_FLAG] = {
@@ -385,10 +367,6 @@ static const struct enic_action_cap enic_action_cap[] = {
                .actions = enic_supported_actions_v2_drop,
                .copy_fn = enic_copy_action_v2,
        },
-       [FILTER_ACTION_COUNTER_FLAG] = {
-               .actions = enic_supported_actions_v2_count,
-               .copy_fn = enic_copy_action_v2,
-       },
 };
 
 static int
@@ -416,21 +394,21 @@ enic_copy_item_ipv4_v1(struct copy_item_args *arg)
                .dst_addr = 0xffffffff,
        };
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        if (!mask)
                mask = &rte_flow_item_ipv4_mask;
 
        /* This is an exact match filter, both fields must be set */
        if (!spec || !spec->hdr.src_addr || !spec->hdr.dst_addr) {
-               FLOW_LOG(ERR, "IPv4 exact match src/dst addr");
+               ENICPMD_LOG(ERR, "IPv4 exact match src/dst addr");
                return ENOTSUP;
        }
 
        /* check that the suppied mask exactly matches capabilty */
        if (!mask_exact_match((const u8 *)&supported_mask,
                              (const u8 *)item->mask, sizeof(*mask))) {
-               FLOW_LOG(ERR, "IPv4 exact match mask");
+               ENICPMD_LOG(ERR, "IPv4 exact match mask");
                return ENOTSUP;
        }
 
@@ -454,21 +432,21 @@ enic_copy_item_udp_v1(struct copy_item_args *arg)
                .dst_port = 0xffff,
        };
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        if (!mask)
                mask = &rte_flow_item_udp_mask;
 
        /* This is an exact match filter, both ports must be set */
        if (!spec || !spec->hdr.src_port || !spec->hdr.dst_port) {
-               FLOW_LOG(ERR, "UDP exact match src/dst addr");
+               ENICPMD_LOG(ERR, "UDP exact match src/dst addr");
                return ENOTSUP;
        }
 
        /* check that the suppied mask exactly matches capabilty */
        if (!mask_exact_match((const u8 *)&supported_mask,
                              (const u8 *)item->mask, sizeof(*mask))) {
-               FLOW_LOG(ERR, "UDP exact match mask");
+               ENICPMD_LOG(ERR, "UDP exact match mask");
                return ENOTSUP;
        }
 
@@ -493,21 +471,21 @@ enic_copy_item_tcp_v1(struct copy_item_args *arg)
                .dst_port = 0xffff,
        };
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        if (!mask)
                mask = &rte_flow_item_tcp_mask;
 
        /* This is an exact match filter, both ports must be set */
        if (!spec || !spec->hdr.src_port || !spec->hdr.dst_port) {
-               FLOW_LOG(ERR, "TCPIPv4 exact match src/dst addr");
+               ENICPMD_LOG(ERR, "TCPIPv4 exact match src/dst addr");
                return ENOTSUP;
        }
 
        /* check that the suppied mask exactly matches capabilty */
        if (!mask_exact_match((const u8 *)&supported_mask,
                             (const u8 *)item->mask, sizeof(*mask))) {
-               FLOW_LOG(ERR, "TCP exact match mask");
+               ENICPMD_LOG(ERR, "TCP exact match mask");
                return ENOTSUP;
        }
 
@@ -569,7 +547,7 @@ enic_copy_item_inner_eth_v2(struct copy_item_args *arg)
        const void *mask = arg->item->mask;
        uint8_t *off = arg->inner_ofst;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
        if (!mask)
                mask = &rte_flow_item_eth_mask;
        arg->l2_proto_off = *off + offsetof(struct rte_ether_hdr, ether_type);
@@ -585,7 +563,7 @@ enic_copy_item_inner_vlan_v2(struct copy_item_args *arg)
        uint8_t *off = arg->inner_ofst;
        uint8_t eth_type_off;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
        if (!mask)
                mask = &rte_flow_item_vlan_mask;
        /* Append vlan header to L5 and set ether type = TPID */
@@ -602,14 +580,14 @@ enic_copy_item_inner_ipv4_v2(struct copy_item_args *arg)
        const void *mask = arg->item->mask;
        uint8_t *off = arg->inner_ofst;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
        if (!mask)
                mask = &rte_flow_item_ipv4_mask;
        /* Append ipv4 header to L5 and set ether type = ipv4 */
        arg->l3_proto_off = *off + offsetof(struct rte_ipv4_hdr, next_proto_id);
        return copy_inner_common(&arg->filter->u.generic_1, off,
                arg->item->spec, mask, sizeof(struct rte_ipv4_hdr),
-               arg->l2_proto_off, rte_cpu_to_be_16(RTE_ETHER_TYPE_IPv4), 2);
+               arg->l2_proto_off, rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4), 2);
 }
 
 static int
@@ -618,14 +596,14 @@ enic_copy_item_inner_ipv6_v2(struct copy_item_args *arg)
        const void *mask = arg->item->mask;
        uint8_t *off = arg->inner_ofst;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
        if (!mask)
                mask = &rte_flow_item_ipv6_mask;
        /* Append ipv6 header to L5 and set ether type = ipv6 */
        arg->l3_proto_off = *off + offsetof(struct rte_ipv6_hdr, proto);
        return copy_inner_common(&arg->filter->u.generic_1, off,
                arg->item->spec, mask, sizeof(struct rte_ipv6_hdr),
-               arg->l2_proto_off, rte_cpu_to_be_16(RTE_ETHER_TYPE_IPv6), 2);
+               arg->l2_proto_off, rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV6), 2);
 }
 
 static int
@@ -634,7 +612,7 @@ enic_copy_item_inner_udp_v2(struct copy_item_args *arg)
        const void *mask = arg->item->mask;
        uint8_t *off = arg->inner_ofst;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
        if (!mask)
                mask = &rte_flow_item_udp_mask;
        /* Append udp header to L5 and set ip proto = udp */
@@ -649,7 +627,7 @@ enic_copy_item_inner_tcp_v2(struct copy_item_args *arg)
        const void *mask = arg->item->mask;
        uint8_t *off = arg->inner_ofst;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
        if (!mask)
                mask = &rte_flow_item_tcp_mask;
        /* Append tcp header to L5 and set ip proto = tcp */
@@ -669,7 +647,7 @@ enic_copy_item_eth_v2(struct copy_item_args *arg)
        const struct rte_flow_item_eth *mask = item->mask;
        struct filter_generic_1 *gp = &enic_filter->u.generic_1;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        /* Match all if no spec */
        if (!spec)
@@ -709,7 +687,7 @@ enic_copy_item_vlan_v2(struct copy_item_args *arg)
        struct rte_ether_hdr *eth_mask;
        struct rte_ether_hdr *eth_val;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        /* Match all if no spec */
        if (!spec)
@@ -759,7 +737,7 @@ enic_copy_item_ipv4_v2(struct copy_item_args *arg)
        const struct rte_flow_item_ipv4 *mask = item->mask;
        struct filter_generic_1 *gp = &enic_filter->u.generic_1;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        /* Match IPv4 */
        gp->mask_flags |= FILTER_GENERIC_1_IPV4;
@@ -788,7 +766,7 @@ enic_copy_item_ipv6_v2(struct copy_item_args *arg)
        const struct rte_flow_item_ipv6 *mask = item->mask;
        struct filter_generic_1 *gp = &enic_filter->u.generic_1;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        /* Match IPv6 */
        gp->mask_flags |= FILTER_GENERIC_1_IPV6;
@@ -817,7 +795,7 @@ enic_copy_item_udp_v2(struct copy_item_args *arg)
        const struct rte_flow_item_udp *mask = item->mask;
        struct filter_generic_1 *gp = &enic_filter->u.generic_1;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        /* Match UDP */
        gp->mask_flags |= FILTER_GENERIC_1_UDP;
@@ -846,7 +824,7 @@ enic_copy_item_tcp_v2(struct copy_item_args *arg)
        const struct rte_flow_item_tcp *mask = item->mask;
        struct filter_generic_1 *gp = &enic_filter->u.generic_1;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        /* Match TCP */
        gp->mask_flags |= FILTER_GENERIC_1_TCP;
@@ -877,7 +855,7 @@ enic_copy_item_sctp_v2(struct copy_item_args *arg)
        uint8_t *ip_proto_mask = NULL;
        uint8_t *ip_proto = NULL;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        /*
         * The NIC filter API has no flags for "match sctp", so explicitly set
@@ -927,7 +905,7 @@ enic_copy_item_vxlan_v2(struct copy_item_args *arg)
        struct filter_generic_1 *gp = &enic_filter->u.generic_1;
        struct rte_udp_hdr *udp;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        /*
         * The NIC filter API has no flags for "match vxlan". Set UDP port to
@@ -970,7 +948,7 @@ enic_copy_item_raw_v2(struct copy_item_args *arg)
        const struct rte_flow_item_raw *mask = item->mask;
        struct filter_generic_1 *gp = &enic_filter->u.generic_1;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        /* Cannot be used for inner packet */
        if (*inner_ofst)
@@ -1021,7 +999,7 @@ item_stacking_valid(enum rte_flow_item_type prev_item,
 {
        enum rte_flow_item_type const *allowed_items = item_info->prev_items;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        for (; *allowed_items != RTE_FLOW_ITEM_TYPE_END; allowed_items++) {
                if (prev_item == *allowed_items)
@@ -1050,7 +1028,7 @@ fixup_l5_layer(struct enic *enic, struct filter_generic_1 *gp,
 
        if (!(inner_ofst > 0 && enic->vxlan))
                return;
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
        vxlan = sizeof(struct rte_vxlan_hdr);
        memcpy(gp->layer[FILTER_GENERIC_1_L4].mask + sizeof(struct rte_udp_hdr),
               gp->layer[FILTER_GENERIC_1_L5].mask, vxlan);
@@ -1092,7 +1070,7 @@ enic_copy_filter(const struct rte_flow_item pattern[],
        enic_copy_item_fn *copy_fn;
        u8 is_first_item = 1;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        prev_item = 0;
 
@@ -1161,7 +1139,7 @@ enic_copy_action_v1(__rte_unused struct enic *enic,
        enum { FATE = 1, };
        uint32_t overlap = 0;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
                if (actions->type == RTE_FLOW_ACTION_TYPE_VOID)
@@ -1209,7 +1187,7 @@ enic_copy_action_v2(struct enic *enic,
        uint32_t overlap = 0;
        bool passthru = false;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
                switch (actions->type) {
@@ -1265,10 +1243,6 @@ enic_copy_action_v2(struct enic *enic,
                        enic_action->flags |= FILTER_ACTION_DROP_FLAG;
                        break;
                }
-               case RTE_FLOW_ACTION_TYPE_COUNT: {
-                       enic_action->flags |= FILTER_ACTION_COUNTER_FLAG;
-                       break;
-               }
                case RTE_FLOW_ACTION_TYPE_RSS: {
                        const struct rte_flow_action_rss *rss =
                                (const struct rte_flow_action_rss *)
@@ -1360,9 +1334,7 @@ enic_get_action_cap(struct enic *enic)
        uint8_t actions;
 
        actions = enic->filter_actions;
-       if (actions & FILTER_ACTION_COUNTER_FLAG)
-               ea = &enic_action_cap[FILTER_ACTION_COUNTER_FLAG];
-       else if (actions & FILTER_ACTION_DROP_FLAG)
+       if (actions & FILTER_ACTION_DROP_FLAG)
                ea = &enic_action_cap[FILTER_ACTION_DROP_FLAG];
        else if (actions & FILTER_ACTION_FILTER_ID_FLAG)
                ea = &enic_action_cap[FILTER_ACTION_FILTER_ID_FLAG];
@@ -1376,14 +1348,14 @@ static void
 enic_dump_actions(const struct filter_action_v2 *ea)
 {
        if (ea->type == FILTER_ACTION_RQ_STEERING) {
-               FLOW_LOG(INFO, "Action(V1), queue: %u\n", ea->rq_idx);
+               ENICPMD_LOG(INFO, "Action(V1), queue: %u\n", ea->rq_idx);
        } else if (ea->type == FILTER_ACTION_V2) {
-               FLOW_LOG(INFO, "Actions(V2)\n");
+               ENICPMD_LOG(INFO, "Actions(V2)\n");
                if (ea->flags & FILTER_ACTION_RQ_STEERING_FLAG)
-                       FLOW_LOG(INFO, "\tqueue: %u\n",
+                       ENICPMD_LOG(INFO, "\tqueue: %u\n",
                               enic_sop_rq_idx_to_rte_idx(ea->rq_idx));
                if (ea->flags & FILTER_ACTION_FILTER_ID_FLAG)
-                       FLOW_LOG(INFO, "\tfilter_id: %u\n", ea->filter_id);
+                       ENICPMD_LOG(INFO, "\tfilter_id: %u\n", ea->filter_id);
        }
 }
 
@@ -1399,13 +1371,13 @@ enic_dump_filter(const struct filter_v2 *filt)
 
        switch (filt->type) {
        case FILTER_IPV4_5TUPLE:
-               FLOW_LOG(INFO, "FILTER_IPV4_5TUPLE\n");
+               ENICPMD_LOG(INFO, "FILTER_IPV4_5TUPLE\n");
                break;
        case FILTER_USNIC_IP:
        case FILTER_DPDK_1:
                /* FIXME: this should be a loop */
                gp = &filt->u.generic_1;
-               FLOW_LOG(INFO, "Filter: vlan: 0x%04x, mask: 0x%04x\n",
+               ENICPMD_LOG(INFO, "Filter: vlan: 0x%04x, mask: 0x%04x\n",
                       gp->val_vlan, gp->mask_vlan);
 
                if (gp->mask_flags & FILTER_GENERIC_1_IPV4)
@@ -1463,7 +1435,7 @@ enic_dump_filter(const struct filter_v2 *filt)
                                 ? "ipfrag(y)" : "ipfrag(n)");
                else
                        sprintf(ipfrag, "%s ", "ipfrag(x)");
-               FLOW_LOG(INFO, "\tFlags: %s%s%s%s%s%s%s%s\n", ip4, ip6, udp,
+               ENICPMD_LOG(INFO, "\tFlags: %s%s%s%s%s%s%s%s\n", ip4, ip6, udp,
                         tcp, tcpudp, ip4csum, l4csum, ipfrag);
 
                for (i = 0; i < FILTER_GENERIC_1_NUM_LAYERS; i++) {
@@ -1480,7 +1452,7 @@ enic_dump_filter(const struct filter_v2 *filt)
                                bp += 2;
                        }
                        *bp = '\0';
-                       FLOW_LOG(INFO, "\tL%u mask: %s\n", i + 2, buf);
+                       ENICPMD_LOG(INFO, "\tL%u mask: %s\n", i + 2, buf);
                        bp = buf;
                        for (j = 0; j <= mbyte; j++) {
                                sprintf(bp, "%02x",
@@ -1488,11 +1460,11 @@ enic_dump_filter(const struct filter_v2 *filt)
                                bp += 2;
                        }
                        *bp = '\0';
-                       FLOW_LOG(INFO, "\tL%u  val: %s\n", i + 2, buf);
+                       ENICPMD_LOG(INFO, "\tL%u  val: %s\n", i + 2, buf);
                }
                break;
        default:
-               FLOW_LOG(INFO, "FILTER UNKNOWN\n");
+               ENICPMD_LOG(INFO, "FILTER UNKNOWN\n");
                break;
        }
 }
@@ -1534,7 +1506,7 @@ enic_flow_parse(struct rte_eth_dev *dev,
        const struct enic_action_cap *enic_action_cap;
        const struct rte_flow_action *action;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        memset(enic_filter, 0, sizeof(*enic_filter));
        memset(enic_action, 0, sizeof(*enic_action));
@@ -1646,11 +1618,9 @@ enic_flow_add_filter(struct enic *enic, struct filter_v2 *enic_filter,
 {
        struct rte_flow *flow;
        int err;
-       uint16_t entry;
-       int ctr_idx;
-       int last_max_flow_ctr;
+       u16 entry;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        flow = rte_calloc(__func__, 1, sizeof(*flow), 0);
        if (!flow) {
@@ -1659,34 +1629,6 @@ enic_flow_add_filter(struct enic *enic, struct filter_v2 *enic_filter,
                return NULL;
        }
 
-       flow->counter_idx = -1;
-       last_max_flow_ctr = -1;
-       if (enic_action->flags & FILTER_ACTION_COUNTER_FLAG) {
-               if (!vnic_dev_counter_alloc(enic->vdev, (uint32_t *)&ctr_idx)) {
-                       rte_flow_error_set(error, ENOMEM,
-                                          RTE_FLOW_ERROR_TYPE_ACTION_CONF,
-                                          NULL, "cannot allocate counter");
-                       goto unwind_flow_alloc;
-               }
-               flow->counter_idx = ctr_idx;
-               enic_action->counter_index = ctr_idx;
-
-               /* If index is the largest, increase the counter DMA size */
-               if (ctr_idx > enic->max_flow_counter) {
-                       err = vnic_dev_counter_dma_cfg(enic->vdev,
-                                                VNIC_FLOW_COUNTER_UPDATE_MSECS,
-                                                ctr_idx + 1);
-                       if (err) {
-                               rte_flow_error_set(error, -err,
-                                          RTE_FLOW_ERROR_TYPE_ACTION_CONF,
-                                          NULL, "counter DMA config failed");
-                               goto unwind_ctr_alloc;
-                       }
-                       last_max_flow_ctr = enic->max_flow_counter;
-                       enic->max_flow_counter = ctr_idx;
-               }
-       }
-
        /* entry[in] is the queue id, entry[out] is the filter Id for delete */
        entry = enic_action->rq_idx;
        err = vnic_dev_classifier(enic->vdev, CLSF_ADD, &entry, enic_filter,
@@ -1694,29 +1636,13 @@ enic_flow_add_filter(struct enic *enic, struct filter_v2 *enic_filter,
        if (err) {
                rte_flow_error_set(error, -err, RTE_FLOW_ERROR_TYPE_HANDLE,
                                   NULL, "vnic_dev_classifier error");
-               goto unwind_ctr_dma_cfg;
+               rte_free(flow);
+               return NULL;
        }
 
        flow->enic_filter_id = entry;
        flow->enic_filter = *enic_filter;
-
        return flow;
-
-/* unwind if there are errors */
-unwind_ctr_dma_cfg:
-       if (last_max_flow_ctr != -1) {
-               /* reduce counter DMA size */
-               vnic_dev_counter_dma_cfg(enic->vdev,
-                                        VNIC_FLOW_COUNTER_UPDATE_MSECS,
-                                        last_max_flow_ctr + 1);
-               enic->max_flow_counter = last_max_flow_ctr;
-       }
-unwind_ctr_alloc:
-       if (flow->counter_idx != -1)
-               vnic_dev_counter_free(enic->vdev, ctr_idx);
-unwind_flow_alloc:
-       rte_free(flow);
-       return NULL;
 }
 
 /**
@@ -1737,7 +1663,7 @@ enic_flow_del_filter(struct enic *enic, struct rte_flow *flow,
        u16 filter_id;
        int err;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        filter_id = flow->enic_filter_id;
        err = vnic_dev_classifier(enic->vdev, CLSF_DEL, &filter_id, NULL, NULL);
@@ -1746,13 +1672,6 @@ enic_flow_del_filter(struct enic *enic, struct rte_flow *flow,
                                   NULL, "vnic_dev_classifier failed");
                return -err;
        }
-
-       if (flow->counter_idx != -1) {
-               if (!vnic_dev_counter_free(enic->vdev, flow->counter_idx))
-                       dev_err(enic, "counter free failed, idx: %d\n",
-                               flow->counter_idx);
-               flow->counter_idx = -1;
-       }
        return 0;
 }
 
@@ -1776,7 +1695,7 @@ enic_flow_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attrs,
        struct filter_action_v2 enic_action;
        int ret;
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        ret = enic_flow_parse(dev, attrs, pattern, actions, error,
                               &enic_filter, &enic_action);
@@ -1804,19 +1723,17 @@ enic_flow_create(struct rte_eth_dev *dev,
        struct rte_flow *flow;
        struct enic *enic = pmd_priv(dev);
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
        ret = enic_flow_parse(dev, attrs, pattern, actions, error, &enic_filter,
                              &enic_action);
        if (ret < 0)
                return NULL;
 
-       rte_spinlock_lock(&enic->flows_lock);
        flow = enic_flow_add_filter(enic, &enic_filter, &enic_action,
                                    error);
        if (flow)
                LIST_INSERT_HEAD(&enic->flows, flow, next);
-       rte_spinlock_unlock(&enic->flows_lock);
 
        return flow;
 }
@@ -1833,12 +1750,10 @@ enic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,
 {
        struct enic *enic = pmd_priv(dev);
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
-       rte_spinlock_lock(&enic->flows_lock);
        enic_flow_del_filter(enic, flow, error);
        LIST_REMOVE(flow, next);
-       rte_spinlock_unlock(&enic->flows_lock);
        rte_free(flow);
        return 0;
 }
@@ -1855,9 +1770,8 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
        struct rte_flow *flow;
        struct enic *enic = pmd_priv(dev);
 
-       FLOW_TRACE();
+       ENICPMD_FUNC_TRACE();
 
-       rte_spinlock_lock(&enic->flows_lock);
 
        while (!LIST_EMPTY(&enic->flows)) {
                flow = LIST_FIRST(&enic->flows);
@@ -1865,70 +1779,6 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
                LIST_REMOVE(flow, next);
                rte_free(flow);
        }
-       rte_spinlock_unlock(&enic->flows_lock);
-       return 0;
-}
-
-static int
-enic_flow_query_count(struct rte_eth_dev *dev,
-                     struct rte_flow *flow, void *data,
-                     struct rte_flow_error *error)
-{
-       struct enic *enic = pmd_priv(dev);
-       struct rte_flow_query_count *query;
-       uint64_t packets, bytes;
-
-       FLOW_TRACE();
-
-       if (flow->counter_idx == -1) {
-               return rte_flow_error_set(error, ENOTSUP,
-                                         RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
-                                         NULL,
-                                         "flow does not have counter");
-       }
-       query = (struct rte_flow_query_count *)data;
-       if (!vnic_dev_counter_query(enic->vdev, flow->counter_idx,
-                                   !!query->reset, &packets, &bytes)) {
-               return rte_flow_error_set
-                       (error, EINVAL,
-                        RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
-                        NULL,
-                        "cannot read counter");
-       }
-       query->hits_set = 1;
-       query->bytes_set = 1;
-       query->hits = packets;
-       query->bytes = bytes;
-       return 0;
-}
-
-static int
-enic_flow_query(struct rte_eth_dev *dev,
-               struct rte_flow *flow,
-               const struct rte_flow_action *actions,
-               void *data,
-               struct rte_flow_error *error)
-{
-       int ret = 0;
-
-       FLOW_TRACE();
-
-       for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
-               switch (actions->type) {
-               case RTE_FLOW_ACTION_TYPE_VOID:
-                       break;
-               case RTE_FLOW_ACTION_TYPE_COUNT:
-                       ret = enic_flow_query_count(dev, flow, data, error);
-                       break;
-               default:
-                       return rte_flow_error_set(error, ENOTSUP,
-                                                 RTE_FLOW_ERROR_TYPE_ACTION,
-                                                 actions,
-                                                 "action not supported");
-               }
-               if (ret < 0)
-                       return ret;
-       }
        return 0;
 }
 
@@ -1942,5 +1792,4 @@ const struct rte_flow_ops enic_flow_ops = {
        .create = enic_flow_create,
        .destroy = enic_flow_destroy,
        .flush = enic_flow_flush,
-       .query = enic_flow_query,
 };