#include <errno.h>
#include <stdint.h>
#include <rte_log.h>
-#include <rte_ethdev_driver.h>
+#include <ethdev_driver.h>
#include <rte_flow_driver.h>
#include <rte_ether.h>
#include <rte_ip.h>
#include "vnic_dev.h"
#include "vnic_nic.h"
-#define FLOW_TRACE() \
- rte_log(RTE_LOG_DEBUG, enicpmd_logtype_flow, \
- "%s()\n", __func__)
-#define FLOW_LOG(level, fmt, args...) \
- rte_log(RTE_LOG_ ## level, enicpmd_logtype_flow, \
- fmt "\n", ##args)
-
/*
* Common arguments passed to copy_item functions. Use this structure
* so we can easily add new arguments.
/** True if it's OK for this item to be the first item. For some NIC
* versions, it's invalid to start the stack above layer 3.
*/
- const u8 valid_start_item;
+ const uint8_t valid_start_item;
/* Inner packet version of copy_item. */
enic_copy_item_fn *inner_copy_item;
};
RTE_FLOW_ACTION_TYPE_END,
};
-static const enum rte_flow_action_type enic_supported_actions_v2_count[] = {
- RTE_FLOW_ACTION_TYPE_QUEUE,
- RTE_FLOW_ACTION_TYPE_MARK,
- RTE_FLOW_ACTION_TYPE_FLAG,
- RTE_FLOW_ACTION_TYPE_DROP,
- RTE_FLOW_ACTION_TYPE_COUNT,
- RTE_FLOW_ACTION_TYPE_RSS,
- RTE_FLOW_ACTION_TYPE_PASSTHRU,
- RTE_FLOW_ACTION_TYPE_END,
-};
-
/** Action capabilities indexed by NIC version information */
static const struct enic_action_cap enic_action_cap[] = {
[FILTER_ACTION_RQ_STEERING_FLAG] = {
.actions = enic_supported_actions_v2_drop,
.copy_fn = enic_copy_action_v2,
},
- [FILTER_ACTION_COUNTER_FLAG] = {
- .actions = enic_supported_actions_v2_count,
- .copy_fn = enic_copy_action_v2,
- },
};
static int
-mask_exact_match(const u8 *supported, const u8 *supplied,
+mask_exact_match(const uint8_t *supported, const uint8_t *supplied,
unsigned int size)
{
unsigned int i;
.dst_addr = 0xffffffff,
};
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
if (!mask)
mask = &rte_flow_item_ipv4_mask;
/* This is an exact match filter, both fields must be set */
if (!spec || !spec->hdr.src_addr || !spec->hdr.dst_addr) {
- FLOW_LOG(ERR, "IPv4 exact match src/dst addr");
+ ENICPMD_LOG(ERR, "IPv4 exact match src/dst addr");
return ENOTSUP;
}
- /* check that the suppied mask exactly matches capabilty */
- if (!mask_exact_match((const u8 *)&supported_mask,
- (const u8 *)item->mask, sizeof(*mask))) {
- FLOW_LOG(ERR, "IPv4 exact match mask");
+ /* check that the supplied mask exactly matches capability */
+ if (!mask_exact_match((const uint8_t *)&supported_mask,
+ (const uint8_t *)item->mask, sizeof(*mask))) {
+ ENICPMD_LOG(ERR, "IPv4 exact match mask");
return ENOTSUP;
}
const struct rte_flow_item_udp *spec = item->spec;
const struct rte_flow_item_udp *mask = item->mask;
struct filter_ipv4_5tuple *enic_5tup = &enic_filter->u.ipv4;
- struct udp_hdr supported_mask = {
+ struct rte_udp_hdr supported_mask = {
.src_port = 0xffff,
.dst_port = 0xffff,
};
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
if (!mask)
mask = &rte_flow_item_udp_mask;
/* This is an exact match filter, both ports must be set */
if (!spec || !spec->hdr.src_port || !spec->hdr.dst_port) {
- FLOW_LOG(ERR, "UDP exact match src/dst addr");
+ ENICPMD_LOG(ERR, "UDP exact match src/dst addr");
return ENOTSUP;
}
- /* check that the suppied mask exactly matches capabilty */
- if (!mask_exact_match((const u8 *)&supported_mask,
- (const u8 *)item->mask, sizeof(*mask))) {
- FLOW_LOG(ERR, "UDP exact match mask");
+ /* check that the supplied mask exactly matches capability */
+ if (!mask_exact_match((const uint8_t *)&supported_mask,
+ (const uint8_t *)item->mask, sizeof(*mask))) {
+ ENICPMD_LOG(ERR, "UDP exact match mask");
return ENOTSUP;
}
.dst_port = 0xffff,
};
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
if (!mask)
mask = &rte_flow_item_tcp_mask;
/* This is an exact match filter, both ports must be set */
if (!spec || !spec->hdr.src_port || !spec->hdr.dst_port) {
- FLOW_LOG(ERR, "TCPIPv4 exact match src/dst addr");
+ ENICPMD_LOG(ERR, "TCPIPv4 exact match src/dst addr");
return ENOTSUP;
}
- /* check that the suppied mask exactly matches capabilty */
- if (!mask_exact_match((const u8 *)&supported_mask,
- (const u8 *)item->mask, sizeof(*mask))) {
- FLOW_LOG(ERR, "TCP exact match mask");
+ /* check that the supplied mask exactly matches capability */
+ if (!mask_exact_match((const uint8_t *)&supported_mask,
+ (const uint8_t *)item->mask, sizeof(*mask))) {
+ ENICPMD_LOG(ERR, "TCP exact match mask");
return ENOTSUP;
}
const void *mask = arg->item->mask;
uint8_t *off = arg->inner_ofst;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
if (!mask)
mask = &rte_flow_item_eth_mask;
arg->l2_proto_off = *off + offsetof(struct rte_ether_hdr, ether_type);
uint8_t *off = arg->inner_ofst;
uint8_t eth_type_off;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
if (!mask)
mask = &rte_flow_item_vlan_mask;
/* Append vlan header to L5 and set ether type = TPID */
const void *mask = arg->item->mask;
uint8_t *off = arg->inner_ofst;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
if (!mask)
mask = &rte_flow_item_ipv4_mask;
/* Append ipv4 header to L5 and set ether type = ipv4 */
arg->l3_proto_off = *off + offsetof(struct rte_ipv4_hdr, next_proto_id);
return copy_inner_common(&arg->filter->u.generic_1, off,
arg->item->spec, mask, sizeof(struct rte_ipv4_hdr),
- arg->l2_proto_off, rte_cpu_to_be_16(RTE_ETHER_TYPE_IPv4), 2);
+ arg->l2_proto_off, rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4), 2);
}
static int
const void *mask = arg->item->mask;
uint8_t *off = arg->inner_ofst;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
if (!mask)
mask = &rte_flow_item_ipv6_mask;
/* Append ipv6 header to L5 and set ether type = ipv6 */
arg->l3_proto_off = *off + offsetof(struct rte_ipv6_hdr, proto);
return copy_inner_common(&arg->filter->u.generic_1, off,
arg->item->spec, mask, sizeof(struct rte_ipv6_hdr),
- arg->l2_proto_off, rte_cpu_to_be_16(RTE_ETHER_TYPE_IPv6), 2);
+ arg->l2_proto_off, rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV6), 2);
}
static int
const void *mask = arg->item->mask;
uint8_t *off = arg->inner_ofst;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
if (!mask)
mask = &rte_flow_item_udp_mask;
/* Append udp header to L5 and set ip proto = udp */
return copy_inner_common(&arg->filter->u.generic_1, off,
- arg->item->spec, mask, sizeof(struct udp_hdr),
+ arg->item->spec, mask, sizeof(struct rte_udp_hdr),
arg->l3_proto_off, IPPROTO_UDP, 1);
}
const void *mask = arg->item->mask;
uint8_t *off = arg->inner_ofst;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
if (!mask)
mask = &rte_flow_item_tcp_mask;
/* Append tcp header to L5 and set ip proto = tcp */
const struct rte_flow_item_eth *mask = item->mask;
struct filter_generic_1 *gp = &enic_filter->u.generic_1;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
/* Match all if no spec */
if (!spec)
if (!mask)
mask = &rte_flow_item_eth_mask;
- memcpy(enic_spec.d_addr.addr_bytes, spec->dst.addr_bytes,
+ memcpy(enic_spec.dst_addr.addr_bytes, spec->dst.addr_bytes,
RTE_ETHER_ADDR_LEN);
- memcpy(enic_spec.s_addr.addr_bytes, spec->src.addr_bytes,
+ memcpy(enic_spec.src_addr.addr_bytes, spec->src.addr_bytes,
RTE_ETHER_ADDR_LEN);
- memcpy(enic_mask.d_addr.addr_bytes, mask->dst.addr_bytes,
+ memcpy(enic_mask.dst_addr.addr_bytes, mask->dst.addr_bytes,
RTE_ETHER_ADDR_LEN);
- memcpy(enic_mask.s_addr.addr_bytes, mask->src.addr_bytes,
+ memcpy(enic_mask.src_addr.addr_bytes, mask->src.addr_bytes,
RTE_ETHER_ADDR_LEN);
enic_spec.ether_type = spec->type;
enic_mask.ether_type = mask->type;
struct rte_ether_hdr *eth_mask;
struct rte_ether_hdr *eth_val;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
/* Match all if no spec */
if (!spec)
const struct rte_flow_item_ipv4 *mask = item->mask;
struct filter_generic_1 *gp = &enic_filter->u.generic_1;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
/* Match IPv4 */
gp->mask_flags |= FILTER_GENERIC_1_IPV4;
const struct rte_flow_item_ipv6 *mask = item->mask;
struct filter_generic_1 *gp = &enic_filter->u.generic_1;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
/* Match IPv6 */
gp->mask_flags |= FILTER_GENERIC_1_IPV6;
const struct rte_flow_item_udp *mask = item->mask;
struct filter_generic_1 *gp = &enic_filter->u.generic_1;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
/* Match UDP */
gp->mask_flags |= FILTER_GENERIC_1_UDP;
mask = &rte_flow_item_udp_mask;
memcpy(gp->layer[FILTER_GENERIC_1_L4].mask, &mask->hdr,
- sizeof(struct udp_hdr));
+ sizeof(struct rte_udp_hdr));
memcpy(gp->layer[FILTER_GENERIC_1_L4].val, &spec->hdr,
- sizeof(struct udp_hdr));
+ sizeof(struct rte_udp_hdr));
return 0;
}
const struct rte_flow_item_tcp *mask = item->mask;
struct filter_generic_1 *gp = &enic_filter->u.generic_1;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
/* Match TCP */
gp->mask_flags |= FILTER_GENERIC_1_TCP;
uint8_t *ip_proto_mask = NULL;
uint8_t *ip_proto = NULL;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
/*
* The NIC filter API has no flags for "match sctp", so explicitly set
const struct rte_flow_item_vxlan *spec = item->spec;
const struct rte_flow_item_vxlan *mask = item->mask;
struct filter_generic_1 *gp = &enic_filter->u.generic_1;
- struct udp_hdr *udp;
+ struct rte_udp_hdr *udp;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
/*
* The NIC filter API has no flags for "match vxlan". Set UDP port to
*/
gp->mask_flags |= FILTER_GENERIC_1_UDP;
gp->val_flags |= FILTER_GENERIC_1_UDP;
- udp = (struct udp_hdr *)gp->layer[FILTER_GENERIC_1_L4].mask;
+ udp = (struct rte_udp_hdr *)gp->layer[FILTER_GENERIC_1_L4].mask;
udp->dst_port = 0xffff;
- udp = (struct udp_hdr *)gp->layer[FILTER_GENERIC_1_L4].val;
+ udp = (struct rte_udp_hdr *)gp->layer[FILTER_GENERIC_1_L4].val;
udp->dst_port = RTE_BE16(4789);
/* Match all if no spec */
if (!spec)
const struct rte_flow_item_raw *mask = item->mask;
struct filter_generic_1 *gp = &enic_filter->u.generic_1;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
/* Cannot be used for inner packet */
if (*inner_ofst)
return EINVAL;
/* Need non-null pattern that fits within the NIC's filter pattern */
if (spec->length == 0 ||
- spec->length + sizeof(struct udp_hdr) > FILTER_GENERIC_1_KEY_LEN ||
+ spec->length + sizeof(struct rte_udp_hdr) > FILTER_GENERIC_1_KEY_LEN ||
!spec->pattern || !mask->pattern)
return EINVAL;
/*
*/
if (mask->length != 0 && mask->length < spec->length)
return EINVAL;
- memcpy(gp->layer[FILTER_GENERIC_1_L4].mask + sizeof(struct udp_hdr),
+ memcpy(gp->layer[FILTER_GENERIC_1_L4].mask + sizeof(struct rte_udp_hdr),
mask->pattern, spec->length);
- memcpy(gp->layer[FILTER_GENERIC_1_L4].val + sizeof(struct udp_hdr),
+ memcpy(gp->layer[FILTER_GENERIC_1_L4].val + sizeof(struct rte_udp_hdr),
spec->pattern, spec->length);
return 0;
*/
static int
item_stacking_valid(enum rte_flow_item_type prev_item,
- const struct enic_items *item_info, u8 is_first_item)
+ const struct enic_items *item_info, uint8_t is_first_item)
{
enum rte_flow_item_type const *allowed_items = item_info->prev_items;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
for (; *allowed_items != RTE_FLOW_ITEM_TYPE_END; allowed_items++) {
if (prev_item == *allowed_items)
if (!(inner_ofst > 0 && enic->vxlan))
return;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
vxlan = sizeof(struct rte_vxlan_hdr);
- memcpy(gp->layer[FILTER_GENERIC_1_L4].mask + sizeof(struct udp_hdr),
+ memcpy(gp->layer[FILTER_GENERIC_1_L4].mask + sizeof(struct rte_udp_hdr),
gp->layer[FILTER_GENERIC_1_L5].mask, vxlan);
- memcpy(gp->layer[FILTER_GENERIC_1_L4].val + sizeof(struct udp_hdr),
+ memcpy(gp->layer[FILTER_GENERIC_1_L4].val + sizeof(struct rte_udp_hdr),
gp->layer[FILTER_GENERIC_1_L5].val, vxlan);
inner = inner_ofst - vxlan;
memset(layer, 0, sizeof(layer));
}
/**
- * Build the intenal enic filter structure from the provided pattern. The
+ * Build the internal enic filter structure from the provided pattern. The
* pattern is validated as the items are copied.
*
* @param pattern[in]
* @param items_info[in]
* Info about this NICs item support, like valid previous items.
* @param enic_filter[out]
- * NIC specfilc filters derived from the pattern.
+ * NIC specific filters derived from the pattern.
* @param error[out]
*/
static int
{
int ret;
const struct rte_flow_item *item = pattern;
- u8 inner_ofst = 0; /* If encapsulated, ofst into L5 */
+ uint8_t inner_ofst = 0; /* If encapsulated, ofst into L5 */
enum rte_flow_item_type prev_item;
const struct enic_items *item_info;
struct copy_item_args args;
enic_copy_item_fn *copy_fn;
- u8 is_first_item = 1;
+ uint8_t is_first_item = 1;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
prev_item = 0;
}
/**
- * Build the intenal version 1 NIC action structure from the provided pattern.
+ * Build the internal version 1 NIC action structure from the provided pattern.
* The pattern is validated as the items are copied.
*
* @param actions[in]
* @param enic_action[out]
- * NIC specfilc actions derived from the actions.
+ * NIC specific actions derived from the actions.
* @param error[out]
*/
static int
enum { FATE = 1, };
uint32_t overlap = 0;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
if (actions->type == RTE_FLOW_ACTION_TYPE_VOID)
}
/**
- * Build the intenal version 2 NIC action structure from the provided pattern.
+ * Build the internal version 2 NIC action structure from the provided pattern.
* The pattern is validated as the items are copied.
*
* @param actions[in]
* @param enic_action[out]
- * NIC specfilc actions derived from the actions.
+ * NIC specific actions derived from the actions.
* @param error[out]
*/
static int
uint32_t overlap = 0;
bool passthru = false;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
switch (actions->type) {
const struct rte_flow_action_mark *mark =
(const struct rte_flow_action_mark *)
actions->conf;
-
+ if (enic->use_noscatter_vec_rx_handler)
+ return ENOTSUP;
if (overlap & MARK)
return ENOTSUP;
overlap |= MARK;
break;
}
case RTE_FLOW_ACTION_TYPE_FLAG: {
+ if (enic->use_noscatter_vec_rx_handler)
+ return ENOTSUP;
if (overlap & MARK)
return ENOTSUP;
overlap |= MARK;
enic_action->flags |= FILTER_ACTION_DROP_FLAG;
break;
}
- case RTE_FLOW_ACTION_TYPE_COUNT: {
- enic_action->flags |= FILTER_ACTION_COUNTER_FLAG;
- break;
- }
case RTE_FLOW_ACTION_TYPE_RSS: {
const struct rte_flow_action_rss *rss =
(const struct rte_flow_action_rss *)
uint8_t actions;
actions = enic->filter_actions;
- if (actions & FILTER_ACTION_COUNTER_FLAG)
- ea = &enic_action_cap[FILTER_ACTION_COUNTER_FLAG];
- else if (actions & FILTER_ACTION_DROP_FLAG)
+ if (actions & FILTER_ACTION_DROP_FLAG)
ea = &enic_action_cap[FILTER_ACTION_DROP_FLAG];
else if (actions & FILTER_ACTION_FILTER_ID_FLAG)
ea = &enic_action_cap[FILTER_ACTION_FILTER_ID_FLAG];
enic_dump_actions(const struct filter_action_v2 *ea)
{
if (ea->type == FILTER_ACTION_RQ_STEERING) {
- FLOW_LOG(INFO, "Action(V1), queue: %u\n", ea->rq_idx);
+ ENICPMD_LOG(INFO, "Action(V1), queue: %u\n", ea->rq_idx);
} else if (ea->type == FILTER_ACTION_V2) {
- FLOW_LOG(INFO, "Actions(V2)\n");
+ ENICPMD_LOG(INFO, "Actions(V2)\n");
if (ea->flags & FILTER_ACTION_RQ_STEERING_FLAG)
- FLOW_LOG(INFO, "\tqueue: %u\n",
+ ENICPMD_LOG(INFO, "\tqueue: %u\n",
enic_sop_rq_idx_to_rte_idx(ea->rq_idx));
if (ea->flags & FILTER_ACTION_FILTER_ID_FLAG)
- FLOW_LOG(INFO, "\tfilter_id: %u\n", ea->filter_id);
+ ENICPMD_LOG(INFO, "\tfilter_id: %u\n", ea->filter_id);
}
}
switch (filt->type) {
case FILTER_IPV4_5TUPLE:
- FLOW_LOG(INFO, "FILTER_IPV4_5TUPLE\n");
+ ENICPMD_LOG(INFO, "FILTER_IPV4_5TUPLE\n");
break;
case FILTER_USNIC_IP:
case FILTER_DPDK_1:
/* FIXME: this should be a loop */
gp = &filt->u.generic_1;
- FLOW_LOG(INFO, "Filter: vlan: 0x%04x, mask: 0x%04x\n",
+ ENICPMD_LOG(INFO, "Filter: vlan: 0x%04x, mask: 0x%04x\n",
gp->val_vlan, gp->mask_vlan);
if (gp->mask_flags & FILTER_GENERIC_1_IPV4)
if (gp->mask_flags & FILTER_GENERIC_1_IPV6)
sprintf(ip6, "%s ",
- (gp->val_flags & FILTER_GENERIC_1_IPV4)
+ (gp->val_flags & FILTER_GENERIC_1_IPV6)
? "ip6(y)" : "ip6(n)");
else
sprintf(ip6, "%s ", "ip6(x)");
? "ipfrag(y)" : "ipfrag(n)");
else
sprintf(ipfrag, "%s ", "ipfrag(x)");
- FLOW_LOG(INFO, "\tFlags: %s%s%s%s%s%s%s%s\n", ip4, ip6, udp,
+ ENICPMD_LOG(INFO, "\tFlags: %s%s%s%s%s%s%s%s\n", ip4, ip6, udp,
tcp, tcpudp, ip4csum, l4csum, ipfrag);
for (i = 0; i < FILTER_GENERIC_1_NUM_LAYERS; i++) {
bp += 2;
}
*bp = '\0';
- FLOW_LOG(INFO, "\tL%u mask: %s\n", i + 2, buf);
+ ENICPMD_LOG(INFO, "\tL%u mask: %s\n", i + 2, buf);
bp = buf;
for (j = 0; j <= mbyte; j++) {
sprintf(bp, "%02x",
bp += 2;
}
*bp = '\0';
- FLOW_LOG(INFO, "\tL%u val: %s\n", i + 2, buf);
+ ENICPMD_LOG(INFO, "\tL%u val: %s\n", i + 2, buf);
}
break;
default:
- FLOW_LOG(INFO, "FILTER UNKNOWN\n");
+ ENICPMD_LOG(INFO, "FILTER UNKNOWN\n");
break;
}
}
const struct enic_action_cap *enic_action_cap;
const struct rte_flow_action *action;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
memset(enic_filter, 0, sizeof(*enic_filter));
memset(enic_action, 0, sizeof(*enic_action));
return -rte_errno;
}
enic_filter->type = enic->flow_filter_mode;
+ if (enic->adv_filters)
+ enic_filter->type = FILTER_DPDK_1;
ret = enic_copy_filter(pattern, enic_filter_cap, enic,
enic_filter, error);
return ret;
struct rte_flow *flow;
int err;
uint16_t entry;
- int ctr_idx;
- int last_max_flow_ctr;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
flow = rte_calloc(__func__, 1, sizeof(*flow), 0);
if (!flow) {
return NULL;
}
- flow->counter_idx = -1;
- last_max_flow_ctr = -1;
- if (enic_action->flags & FILTER_ACTION_COUNTER_FLAG) {
- if (!vnic_dev_counter_alloc(enic->vdev, (uint32_t *)&ctr_idx)) {
- rte_flow_error_set(error, ENOMEM,
- RTE_FLOW_ERROR_TYPE_ACTION_CONF,
- NULL, "cannot allocate counter");
- goto unwind_flow_alloc;
- }
- flow->counter_idx = ctr_idx;
- enic_action->counter_index = ctr_idx;
-
- /* If index is the largest, increase the counter DMA size */
- if (ctr_idx > enic->max_flow_counter) {
- err = vnic_dev_counter_dma_cfg(enic->vdev,
- VNIC_FLOW_COUNTER_UPDATE_MSECS,
- ctr_idx + 1);
- if (err) {
- rte_flow_error_set(error, -err,
- RTE_FLOW_ERROR_TYPE_ACTION_CONF,
- NULL, "counter DMA config failed");
- goto unwind_ctr_alloc;
- }
- last_max_flow_ctr = enic->max_flow_counter;
- enic->max_flow_counter = ctr_idx;
- }
- }
-
/* entry[in] is the queue id, entry[out] is the filter Id for delete */
entry = enic_action->rq_idx;
err = vnic_dev_classifier(enic->vdev, CLSF_ADD, &entry, enic_filter,
if (err) {
rte_flow_error_set(error, -err, RTE_FLOW_ERROR_TYPE_HANDLE,
NULL, "vnic_dev_classifier error");
- goto unwind_ctr_dma_cfg;
+ rte_free(flow);
+ return NULL;
}
flow->enic_filter_id = entry;
flow->enic_filter = *enic_filter;
-
return flow;
-
-/* unwind if there are errors */
-unwind_ctr_dma_cfg:
- if (last_max_flow_ctr != -1) {
- /* reduce counter DMA size */
- vnic_dev_counter_dma_cfg(enic->vdev,
- VNIC_FLOW_COUNTER_UPDATE_MSECS,
- last_max_flow_ctr + 1);
- enic->max_flow_counter = last_max_flow_ctr;
- }
-unwind_ctr_alloc:
- if (flow->counter_idx != -1)
- vnic_dev_counter_free(enic->vdev, ctr_idx);
-unwind_flow_alloc:
- rte_free(flow);
- return NULL;
}
/**
enic_flow_del_filter(struct enic *enic, struct rte_flow *flow,
struct rte_flow_error *error)
{
- u16 filter_id;
+ uint16_t filter_id;
int err;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
filter_id = flow->enic_filter_id;
err = vnic_dev_classifier(enic->vdev, CLSF_DEL, &filter_id, NULL, NULL);
NULL, "vnic_dev_classifier failed");
return -err;
}
-
- if (flow->counter_idx != -1) {
- if (!vnic_dev_counter_free(enic->vdev, flow->counter_idx))
- dev_err(enic, "counter free failed, idx: %d\n",
- flow->counter_idx);
- flow->counter_idx = -1;
- }
return 0;
}
struct filter_action_v2 enic_action;
int ret;
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
ret = enic_flow_parse(dev, attrs, pattern, actions, error,
&enic_filter, &enic_action);
struct rte_flow *flow;
struct enic *enic = pmd_priv(dev);
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
ret = enic_flow_parse(dev, attrs, pattern, actions, error, &enic_filter,
&enic_action);
if (ret < 0)
return NULL;
- rte_spinlock_lock(&enic->flows_lock);
flow = enic_flow_add_filter(enic, &enic_filter, &enic_action,
error);
if (flow)
LIST_INSERT_HEAD(&enic->flows, flow, next);
- rte_spinlock_unlock(&enic->flows_lock);
return flow;
}
{
struct enic *enic = pmd_priv(dev);
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
- rte_spinlock_lock(&enic->flows_lock);
enic_flow_del_filter(enic, flow, error);
LIST_REMOVE(flow, next);
- rte_spinlock_unlock(&enic->flows_lock);
rte_free(flow);
return 0;
}
struct rte_flow *flow;
struct enic *enic = pmd_priv(dev);
- FLOW_TRACE();
+ ENICPMD_FUNC_TRACE();
- rte_spinlock_lock(&enic->flows_lock);
while (!LIST_EMPTY(&enic->flows)) {
flow = LIST_FIRST(&enic->flows);
LIST_REMOVE(flow, next);
rte_free(flow);
}
- rte_spinlock_unlock(&enic->flows_lock);
- return 0;
-}
-
-static int
-enic_flow_query_count(struct rte_eth_dev *dev,
- struct rte_flow *flow, void *data,
- struct rte_flow_error *error)
-{
- struct enic *enic = pmd_priv(dev);
- struct rte_flow_query_count *query;
- uint64_t packets, bytes;
-
- FLOW_TRACE();
-
- if (flow->counter_idx == -1) {
- return rte_flow_error_set(error, ENOTSUP,
- RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
- NULL,
- "flow does not have counter");
- }
- query = (struct rte_flow_query_count *)data;
- if (!vnic_dev_counter_query(enic->vdev, flow->counter_idx,
- !!query->reset, &packets, &bytes)) {
- return rte_flow_error_set
- (error, EINVAL,
- RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
- NULL,
- "cannot read counter");
- }
- query->hits_set = 1;
- query->bytes_set = 1;
- query->hits = packets;
- query->bytes = bytes;
- return 0;
-}
-
-static int
-enic_flow_query(struct rte_eth_dev *dev,
- struct rte_flow *flow,
- const struct rte_flow_action *actions,
- void *data,
- struct rte_flow_error *error)
-{
- int ret = 0;
-
- FLOW_TRACE();
-
- for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
- switch (actions->type) {
- case RTE_FLOW_ACTION_TYPE_VOID:
- break;
- case RTE_FLOW_ACTION_TYPE_COUNT:
- ret = enic_flow_query_count(dev, flow, data, error);
- break;
- default:
- return rte_flow_error_set(error, ENOTSUP,
- RTE_FLOW_ERROR_TYPE_ACTION,
- actions,
- "action not supported");
- }
- if (ret < 0)
- return ret;
- }
return 0;
}
.create = enic_flow_create,
.destroy = enic_flow_destroy,
.flush = enic_flow_flush,
- .query = enic_flow_query,
};