fm10k: update vlan offload features
[dpdk.git] / drivers / net / fm10k / fm10k_ethdev.c
index 19d821e..2c6ea12 100644 (file)
@@ -59,6 +59,10 @@ static void fm10k_dev_promiscuous_disable(struct rte_eth_dev *dev);
 static void fm10k_dev_allmulticast_enable(struct rte_eth_dev *dev);
 static void fm10k_dev_allmulticast_disable(struct rte_eth_dev *dev);
 static inline int fm10k_glort_valid(struct fm10k_hw *hw);
+static int
+fm10k_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on);
+static void
+fm10k_MAC_filter_set(struct rte_eth_dev *dev, const u8 *mac, bool add);
 
 static void
 fm10k_mbx_initlock(struct fm10k_hw *hw)
@@ -786,14 +790,11 @@ fm10k_dev_start(struct rte_eth_dev *dev)
        }
 
        if (hw->mac.default_vid && hw->mac.default_vid <= ETHER_MAX_VLAN_ID) {
-               fm10k_mbx_lock(hw);
                /* Update default vlan */
-               hw->mac.ops.update_vlan(hw, hw->mac.default_vid, 0, true);
+               fm10k_vlan_filter_set(dev, hw->mac.default_vid, true);
 
                /* Add default mac/vlan filter to PF/Switch manager */
-               hw->mac.ops.update_uc_addr(hw, hw->mac.dglort_map, hw->mac.addr,
-                               hw->mac.default_vid, true, 0);
-               fm10k_mbx_unlock(hw);
+               fm10k_MAC_filter_set(dev, hw->mac.addr, true);
        }
 
        return 0;
@@ -899,15 +900,17 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
        dev_info->max_rx_pktlen      = FM10K_MAX_PKT_SIZE;
        dev_info->max_rx_queues      = hw->mac.max_queues;
        dev_info->max_tx_queues      = hw->mac.max_queues;
-       dev_info->max_mac_addrs      = 1;
+       dev_info->max_mac_addrs      = FM10K_MAX_MACADDR_NUM;
        dev_info->max_hash_mac_addrs = 0;
        dev_info->max_vfs            = dev->pci_dev->max_vfs;
        dev_info->max_vmdq_pools     = ETH_64_POOLS;
        dev_info->rx_offload_capa =
+               DEV_RX_OFFLOAD_VLAN_STRIP |
                DEV_RX_OFFLOAD_IPV4_CKSUM |
                DEV_RX_OFFLOAD_UDP_CKSUM  |
                DEV_RX_OFFLOAD_TCP_CKSUM;
-       dev_info->tx_offload_capa    = 0;
+       dev_info->tx_offload_capa =
+               DEV_TX_OFFLOAD_VLAN_INSERT;
        dev_info->reta_size = FM10K_MAX_RSS_INDICES;
 
        dev_info->default_rxconf = (struct rte_eth_rxconf) {
@@ -937,15 +940,163 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
 static int
 fm10k_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
 {
-       struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       s32 result;
+       uint16_t mac_num = 0;
+       uint32_t vid_idx, vid_bit, mac_index;
+       struct fm10k_hw *hw;
+       struct fm10k_macvlan_filter_info *macvlan;
+       struct rte_eth_dev_data *data = dev->data;
 
-       PMD_INIT_FUNC_TRACE();
+       hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
 
        /* @todo - add support for the VF */
-       if (hw->mac.type != fm10k_mac_pf)
+       if (hw->mac.type != fm10k_mac_pf) {
+               PMD_INIT_LOG(ERR, "VLAN filter not available on VF");
                return -ENOTSUP;
+       }
+
+       if (vlan_id > ETH_VLAN_ID_MAX) {
+               PMD_INIT_LOG(ERR, "Invalid vlan_id: must be < 4096");
+               return (-EINVAL);
+       }
+
+       vid_idx = FM10K_VFTA_IDX(vlan_id);
+       vid_bit = FM10K_VFTA_BIT(vlan_id);
+       /* this VLAN ID is already in the VLAN filter table, return SUCCESS */
+       if (on && (macvlan->vfta[vid_idx] & vid_bit))
+               return 0;
+       /* this VLAN ID is NOT in the VLAN filter table, cannot remove */
+       if (!on && !(macvlan->vfta[vid_idx] & vid_bit)) {
+               PMD_INIT_LOG(ERR, "Invalid vlan_id: not existing "
+                       "in the VLAN filter table");
+               return (-EINVAL);
+       }
+
+       fm10k_mbx_lock(hw);
+       result = fm10k_update_vlan(hw, vlan_id, 0, on);
+       fm10k_mbx_unlock(hw);
+       if (result != FM10K_SUCCESS) {
+               PMD_INIT_LOG(ERR, "VLAN update failed: %d", result);
+               return (-EIO);
+       }
+
+       for (mac_index = 0; (mac_index < FM10K_MAX_MACADDR_NUM) &&
+                       (result == FM10K_SUCCESS); mac_index++) {
+               if (is_zero_ether_addr(&data->mac_addrs[mac_index]))
+                       continue;
+               if (mac_num > macvlan->mac_num - 1) {
+                       PMD_INIT_LOG(ERR, "MAC address number "
+                                       "not match");
+                       break;
+               }
+               fm10k_mbx_lock(hw);
+               result = fm10k_update_uc_addr(hw, hw->mac.dglort_map,
+                       data->mac_addrs[mac_index].addr_bytes,
+                       vlan_id, on, 0);
+               fm10k_mbx_unlock(hw);
+               mac_num++;
+       }
+       if (result != FM10K_SUCCESS) {
+               PMD_INIT_LOG(ERR, "MAC address update failed: %d", result);
+               return (-EIO);
+       }
+
+       if (on) {
+               macvlan->vlan_num++;
+               macvlan->vfta[vid_idx] |= vid_bit;
+       } else {
+               macvlan->vlan_num--;
+               macvlan->vfta[vid_idx] &= ~vid_bit;
+       }
+       return 0;
+}
+
+static void
+fm10k_vlan_offload_set(__rte_unused struct rte_eth_dev *dev, int mask)
+{
+       if (mask & ETH_VLAN_STRIP_MASK) {
+               if (!dev->data->dev_conf.rxmode.hw_vlan_strip)
+                       PMD_INIT_LOG(ERR, "VLAN stripping is "
+                                       "always on in fm10k");
+       }
+
+       if (mask & ETH_VLAN_EXTEND_MASK) {
+               if (dev->data->dev_conf.rxmode.hw_vlan_extend)
+                       PMD_INIT_LOG(ERR, "VLAN QinQ is not "
+                                       "supported in fm10k");
+       }
+
+       if (mask & ETH_VLAN_FILTER_MASK) {
+               if (!dev->data->dev_conf.rxmode.hw_vlan_filter)
+                       PMD_INIT_LOG(ERR, "VLAN filter is always on in fm10k");
+       }
+}
+
+/* Add/Remove a MAC address, and update filters */
+static void
+fm10k_MAC_filter_set(struct rte_eth_dev *dev, const u8 *mac, bool add)
+{
+       uint32_t i, j, k;
+       struct fm10k_hw *hw;
+       struct fm10k_macvlan_filter_info *macvlan;
+
+       hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
+
+       /* @todo - add support for the VF */
+       if (hw->mac.type != fm10k_mac_pf) {
+               PMD_INIT_LOG(ERR, "MAC filter not available on VF");
+               return;
+       }
+
+       i = 0;
+       for (j = 0; j < FM10K_VFTA_SIZE; j++) {
+               if (macvlan->vfta[j]) {
+                       for (k = 0; k < FM10K_UINT32_BIT_SIZE; k++) {
+                               if (macvlan->vfta[j] & (1 << k)) {
+                                       if (i + 1 > macvlan->vlan_num) {
+                                               PMD_INIT_LOG(ERR, "vlan number "
+                                                               "not match");
+                                               return;
+                                       }
+                                       fm10k_mbx_lock(hw);
+                                       fm10k_update_uc_addr(hw,
+                                               hw->mac.dglort_map, mac,
+                                               j * FM10K_UINT32_BIT_SIZE + k,
+                                               add, 0);
+                                       fm10k_mbx_unlock(hw);
+                                       i++;
+                               }
+                       }
+               }
+       }
+
+       if (add)
+               macvlan->mac_num++;
+       else
+               macvlan->mac_num--;
+}
+
+/* Add a MAC address, and update filters */
+static void
+fm10k_macaddr_add(struct rte_eth_dev *dev,
+                struct ether_addr *mac_addr,
+                __rte_unused uint32_t index,
+                __rte_unused uint32_t pool)
+{
+       fm10k_MAC_filter_set(dev, mac_addr->addr_bytes, TRUE);
+}
+
+/* Remove a MAC address, and update filters */
+static void
+fm10k_macaddr_remove(struct rte_eth_dev *dev, uint32_t index)
+{
+       struct rte_eth_dev_data *data = dev->data;
 
-       return fm10k_update_vlan(hw, vlan_id, 0, on);
+       if (index < FM10K_MAX_MACADDR_NUM)
+               fm10k_MAC_filter_set(dev, data->mac_addrs[index].addr_bytes,
+                               FALSE);
 }
 
 static inline int
@@ -1799,6 +1950,9 @@ static const struct eth_dev_ops fm10k_eth_dev_ops = {
        .link_update            = fm10k_link_update,
        .dev_infos_get          = fm10k_dev_infos_get,
        .vlan_filter_set        = fm10k_vlan_filter_set,
+       .vlan_offload_set       = fm10k_vlan_offload_set,
+       .mac_addr_add           = fm10k_macaddr_add,
+       .mac_addr_remove        = fm10k_macaddr_remove,
        .rx_queue_start         = fm10k_dev_rx_queue_start,
        .rx_queue_stop          = fm10k_dev_rx_queue_stop,
        .tx_queue_start         = fm10k_dev_tx_queue_start,
@@ -1818,6 +1972,7 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)
 {
        struct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        int diag;
+       struct fm10k_macvlan_filter_info *macvlan;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -1832,6 +1987,8 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)
        if (rte_eal_process_type() != RTE_PROC_PRIMARY)
                return 0;
 
+       macvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);
+       memset(macvlan, 0, sizeof(*macvlan));
        /* Vendor and Device ID need to be set before init of shared code */
        memset(hw, 0, sizeof(*hw));
        hw->device_id = dev->pci_dev->id.device_id;
@@ -1877,7 +2034,8 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)
        }
 
        /* Initialize MAC address(es) */
-       dev->data->mac_addrs = rte_zmalloc("fm10k", ETHER_ADDR_LEN, 0);
+       dev->data->mac_addrs = rte_zmalloc("fm10k",
+                       ETHER_ADDR_LEN * FM10K_MAX_MACADDR_NUM, 0);
        if (dev->data->mac_addrs == NULL) {
                PMD_INIT_LOG(ERR, "Cannot allocate memory for MAC addresses");
                return -ENOMEM;