net/hns3: remove unnecessary assignment
[dpdk.git] / drivers / net / hns3 / hns3_ethdev_vf.c
index 71f3f95..5015fe0 100644 (file)
 #include <rte_vfio.h>
 
 #include "hns3_ethdev.h"
+#include "hns3_common.h"
 #include "hns3_logs.h"
 #include "hns3_rxtx.h"
 #include "hns3_regs.h"
 #include "hns3_intr.h"
 #include "hns3_dcb.h"
 #include "hns3_mp.h"
+#include "hns3_flow.h"
 
 #define HNS3VF_KEEP_ALIVE_INTERVAL     2000000 /* us */
 #define HNS3VF_SERVICE_INTERVAL                1000000 /* us */
@@ -204,98 +206,6 @@ hns3vf_remove_uc_mac_addr(struct hns3_hw *hw, struct rte_ether_addr *mac_addr)
        return ret;
 }
 
-static int
-hns3vf_add_mc_addr_common(struct hns3_hw *hw, struct rte_ether_addr *mac_addr)
-{
-       char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
-       struct rte_ether_addr *addr;
-       int ret;
-       int i;
-
-       for (i = 0; i < hw->mc_addrs_num; i++) {
-               addr = &hw->mc_addrs[i];
-               /* Check if there are duplicate addresses */
-               if (rte_is_same_ether_addr(addr, mac_addr)) {
-                       hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
-                                             addr);
-                       hns3_err(hw, "failed to add mc mac addr, same addrs"
-                                "(%s) is added by the set_mc_mac_addr_list "
-                                "API", mac_str);
-                       return -EINVAL;
-               }
-       }
-
-       ret = hns3vf_add_mc_mac_addr(hw, mac_addr);
-       if (ret) {
-               hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
-                                     mac_addr);
-               hns3_err(hw, "failed to add mc mac addr(%s), ret = %d",
-                        mac_str, ret);
-       }
-       return ret;
-}
-
-static int
-hns3vf_add_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,
-                   __rte_unused uint32_t idx,
-                   __rte_unused uint32_t pool)
-{
-       struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
-       int ret;
-
-       rte_spinlock_lock(&hw->lock);
-
-       /*
-        * In hns3 network engine adding UC and MC mac address with different
-        * commands with firmware. We need to determine whether the input
-        * address is a UC or a MC address to call different commands.
-        * By the way, it is recommended calling the API function named
-        * rte_eth_dev_set_mc_addr_list to set the MC mac address, because
-        * using the rte_eth_dev_mac_addr_add API function to set MC mac address
-        * may affect the specifications of UC mac addresses.
-        */
-       if (rte_is_multicast_ether_addr(mac_addr))
-               ret = hns3vf_add_mc_addr_common(hw, mac_addr);
-       else
-               ret = hns3vf_add_uc_mac_addr(hw, mac_addr);
-
-       rte_spinlock_unlock(&hw->lock);
-       if (ret) {
-               hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
-                                     mac_addr);
-               hns3_err(hw, "failed to add mac addr(%s), ret = %d", mac_str,
-                        ret);
-       }
-
-       return ret;
-}
-
-static void
-hns3vf_remove_mac_addr(struct rte_eth_dev *dev, uint32_t idx)
-{
-       struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       /* index will be checked by upper level rte interface */
-       struct rte_ether_addr *mac_addr = &dev->data->mac_addrs[idx];
-       char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
-       int ret;
-
-       rte_spinlock_lock(&hw->lock);
-
-       if (rte_is_multicast_ether_addr(mac_addr))
-               ret = hns3vf_remove_mc_mac_addr(hw, mac_addr);
-       else
-               ret = hns3vf_remove_uc_mac_addr(hw, mac_addr);
-
-       rte_spinlock_unlock(&hw->lock);
-       if (ret) {
-               hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
-                                     mac_addr);
-               hns3_err(hw, "failed to remove mac addr(%s), ret = %d",
-                        mac_str, ret);
-       }
-}
-
 static int
 hns3vf_set_default_mac_addr(struct rte_eth_dev *dev,
                            struct rte_ether_addr *mac_addr)
@@ -322,7 +232,7 @@ hns3vf_set_default_mac_addr(struct rte_eth_dev *dev,
                                HNS3_TWO_ETHER_ADDR_LEN, true, NULL, 0);
        if (ret) {
                /*
-                * The hns3 VF PMD driver depends on the hns3 PF kernel ethdev
+                * The hns3 VF PMD depends on the hns3 PF kernel ethdev
                 * driver. When user has configured a MAC address for VF device
                 * by "ip link set ..." command based on the PF device, the hns3
                 * PF kernel ethdev driver does not allow VF driver to request
@@ -332,7 +242,7 @@ hns3vf_set_default_mac_addr(struct rte_eth_dev *dev,
                if (ret == -EPERM) {
                        hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
                                              old_addr);
-                       hns3_warn(hw, "Has permanet mac addr(%s) for vf",
+                       hns3_warn(hw, "Has permanent mac addr(%s) for vf",
                                  mac_str);
                } else {
                        hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
@@ -349,39 +259,6 @@ hns3vf_set_default_mac_addr(struct rte_eth_dev *dev,
        return ret;
 }
 
-static int
-hns3vf_configure_mac_addr(struct hns3_adapter *hns, bool del)
-{
-       struct hns3_hw *hw = &hns->hw;
-       struct rte_ether_addr *addr;
-       char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
-       int err = 0;
-       int ret;
-       int i;
-
-       for (i = 0; i < HNS3_VF_UC_MACADDR_NUM; i++) {
-               addr = &hw->data->mac_addrs[i];
-               if (rte_is_zero_ether_addr(addr))
-                       continue;
-               if (rte_is_multicast_ether_addr(addr))
-                       ret = del ? hns3vf_remove_mc_mac_addr(hw, addr) :
-                             hns3vf_add_mc_mac_addr(hw, addr);
-               else
-                       ret = del ? hns3vf_remove_uc_mac_addr(hw, addr) :
-                             hns3vf_add_uc_mac_addr(hw, addr);
-
-               if (ret) {
-                       err = ret;
-                       hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
-                                             addr);
-                       hns3_err(hw, "failed to %s mac addr(%s) index:%d "
-                                "ret = %d.", del ? "remove" : "restore",
-                                mac_str, i, ret);
-               }
-       }
-       return err;
-}
-
 static int
 hns3vf_add_mc_mac_addr(struct hns3_hw *hw,
                       struct rte_ether_addr *mac_addr)
@@ -424,147 +301,6 @@ hns3vf_remove_mc_mac_addr(struct hns3_hw *hw,
        return ret;
 }
 
-static int
-hns3vf_set_mc_addr_chk_param(struct hns3_hw *hw,
-                            struct rte_ether_addr *mc_addr_set,
-                            uint32_t nb_mc_addr)
-{
-       char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
-       struct rte_ether_addr *addr;
-       uint32_t i;
-       uint32_t j;
-
-       if (nb_mc_addr > HNS3_MC_MACADDR_NUM) {
-               hns3_err(hw, "failed to set mc mac addr, nb_mc_addr(%u) "
-                        "invalid. valid range: 0~%d",
-                        nb_mc_addr, HNS3_MC_MACADDR_NUM);
-               return -EINVAL;
-       }
-
-       /* Check if input mac addresses are valid */
-       for (i = 0; i < nb_mc_addr; i++) {
-               addr = &mc_addr_set[i];
-               if (!rte_is_multicast_ether_addr(addr)) {
-                       hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
-                                             addr);
-                       hns3_err(hw,
-                                "failed to set mc mac addr, addr(%s) invalid.",
-                                mac_str);
-                       return -EINVAL;
-               }
-
-               /* Check if there are duplicate addresses */
-               for (j = i + 1; j < nb_mc_addr; j++) {
-                       if (rte_is_same_ether_addr(addr, &mc_addr_set[j])) {
-                               hns3_ether_format_addr(mac_str,
-                                                     RTE_ETHER_ADDR_FMT_SIZE,
-                                                     addr);
-                               hns3_err(hw, "failed to set mc mac addr, "
-                                        "addrs invalid. two same addrs(%s).",
-                                        mac_str);
-                               return -EINVAL;
-                       }
-               }
-
-               /*
-                * Check if there are duplicate addresses between mac_addrs
-                * and mc_addr_set
-                */
-               for (j = 0; j < HNS3_VF_UC_MACADDR_NUM; j++) {
-                       if (rte_is_same_ether_addr(addr,
-                                                  &hw->data->mac_addrs[j])) {
-                               hns3_ether_format_addr(mac_str,
-                                                     RTE_ETHER_ADDR_FMT_SIZE,
-                                                     addr);
-                               hns3_err(hw, "failed to set mc mac addr, "
-                                        "addrs invalid. addrs(%s) has already "
-                                        "configured in mac_addr add API",
-                                        mac_str);
-                               return -EINVAL;
-                       }
-               }
-       }
-
-       return 0;
-}
-
-static int
-hns3vf_set_mc_mac_addr_list(struct rte_eth_dev *dev,
-                           struct rte_ether_addr *mc_addr_set,
-                           uint32_t nb_mc_addr)
-{
-       struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       struct rte_ether_addr *addr;
-       int cur_addr_num;
-       int set_addr_num;
-       int num;
-       int ret;
-       int i;
-
-       ret = hns3vf_set_mc_addr_chk_param(hw, mc_addr_set, nb_mc_addr);
-       if (ret)
-               return ret;
-
-       rte_spinlock_lock(&hw->lock);
-       cur_addr_num = hw->mc_addrs_num;
-       for (i = 0; i < cur_addr_num; i++) {
-               num = cur_addr_num - i - 1;
-               addr = &hw->mc_addrs[num];
-               ret = hns3vf_remove_mc_mac_addr(hw, addr);
-               if (ret) {
-                       rte_spinlock_unlock(&hw->lock);
-                       return ret;
-               }
-
-               hw->mc_addrs_num--;
-       }
-
-       set_addr_num = (int)nb_mc_addr;
-       for (i = 0; i < set_addr_num; i++) {
-               addr = &mc_addr_set[i];
-               ret = hns3vf_add_mc_mac_addr(hw, addr);
-               if (ret) {
-                       rte_spinlock_unlock(&hw->lock);
-                       return ret;
-               }
-
-               rte_ether_addr_copy(addr, &hw->mc_addrs[hw->mc_addrs_num]);
-               hw->mc_addrs_num++;
-       }
-       rte_spinlock_unlock(&hw->lock);
-
-       return 0;
-}
-
-static int
-hns3vf_configure_all_mc_mac_addr(struct hns3_adapter *hns, bool del)
-{
-       char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
-       struct hns3_hw *hw = &hns->hw;
-       struct rte_ether_addr *addr;
-       int err = 0;
-       int ret;
-       int i;
-
-       for (i = 0; i < hw->mc_addrs_num; i++) {
-               addr = &hw->mc_addrs[i];
-               if (!rte_is_multicast_ether_addr(addr))
-                       continue;
-               if (del)
-                       ret = hns3vf_remove_mc_mac_addr(hw, addr);
-               else
-                       ret = hns3vf_add_mc_mac_addr(hw, addr);
-               if (ret) {
-                       err = ret;
-                       hns3_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
-                                             addr);
-                       hns3_err(hw, "Failed to %s mc mac addr: %s for vf: %d",
-                                del ? "Remove" : "Restore", mac_str, ret);
-               }
-       }
-       return err;
-}
-
 static int
 hns3vf_set_promisc_mode(struct hns3_hw *hw, bool en_bc_pmc,
                        bool en_uc_pmc, bool en_mc_pmc)
@@ -576,25 +312,25 @@ hns3vf_set_promisc_mode(struct hns3_hw *hw, bool en_bc_pmc,
        req = (struct hns3_mbx_vf_to_pf_cmd *)desc.data;
 
        /*
-        * The hns3 VF PMD driver depends on the hns3 PF kernel ethdev driver,
+        * The hns3 VF PMD depends on the hns3 PF kernel ethdev driver,
         * so there are some features for promiscuous/allmulticast mode in hns3
-        * VF PMD driver as below:
+        * VF PMD as below:
         * 1. The promiscuous/allmulticast mode can be configured successfully
         *    only based on the trusted VF device. If based on the non trusted
         *    VF device, configuring promiscuous/allmulticast mode will fail.
-        *    The hns3 VF device can be confiruged as trusted device by hns3 PF
+        *    The hns3 VF device can be configured as trusted device by hns3 PF
         *    kernel ethdev driver on the host by the following command:
         *      "ip link set <eth num> vf <vf id> turst on"
         * 2. After the promiscuous mode is configured successfully, hns3 VF PMD
-        *    driver can receive the ingress and outgoing traffic. In the words,
+        *    can receive the ingress and outgoing traffic. This includes
         *    all the ingress packets, all the packets sent from the PF and
         *    other VFs on the same physical port.
         * 3. Note: Because of the hardware constraints, By default vlan filter
         *    is enabled and couldn't be turned off based on VF device, so vlan
         *    filter is still effective even in promiscuous mode. If upper
         *    applications don't call rte_eth_dev_vlan_filter API function to
-        *    set vlan based on VF device, hns3 VF PMD driver will can't receive
-        *    the packets with vlan tag in promiscuoue mode.
+        *    set vlan based on VF device, hns3 VF PMD will can't receive
+        *    the packets with vlan tag in promiscuous mode.
         */
        hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_MBX_VF_TO_PF, false);
        req->msg[0] = HNS3_MBX_SET_PROMISC_MODE;
@@ -686,7 +422,7 @@ hns3vf_restore_promisc(struct hns3_adapter *hns)
 }
 
 static int
-hns3vf_bind_ring_with_vector(struct hns3_hw *hw, uint8_t vector_id,
+hns3vf_bind_ring_with_vector(struct hns3_hw *hw, uint16_t vector_id,
                             bool mmap, enum hns3_ring_type queue_type,
                             uint16_t queue_id)
 {
@@ -698,7 +434,7 @@ hns3vf_bind_ring_with_vector(struct hns3_hw *hw, uint8_t vector_id,
        memset(&bind_msg, 0, sizeof(bind_msg));
        code = mmap ? HNS3_MBX_MAP_RING_TO_VECTOR :
                HNS3_MBX_UNMAP_RING_TO_VECTOR;
-       bind_msg.vector_id = vector_id;
+       bind_msg.vector_id = (uint8_t)vector_id;
 
        if (queue_type == HNS3_RING_TYPE_RX)
                bind_msg.param[0].int_gl_index = HNS3_RING_GL_RX;
@@ -718,62 +454,6 @@ hns3vf_bind_ring_with_vector(struct hns3_hw *hw, uint8_t vector_id,
        return ret;
 }
 
-static int
-hns3vf_init_ring_with_vector(struct hns3_hw *hw)
-{
-       uint16_t vec;
-       int ret;
-       int i;
-
-       /*
-        * In hns3 network engine, vector 0 is always the misc interrupt of this
-        * function, vector 1~N can be used respectively for the queues of the
-        * function. Tx and Rx queues with the same number share the interrupt
-        * vector. In the initialization clearing the all hardware mapping
-        * relationship configurations between queues and interrupt vectors is
-        * needed, so some error caused by the residual configurations, such as
-        * the unexpected Tx interrupt, can be avoid.
-        */
-       vec = hw->num_msi - 1; /* vector 0 for misc interrupt, not for queue */
-       if (hw->intr.mapping_mode == HNS3_INTR_MAPPING_VEC_RSV_ONE)
-               vec = vec - 1; /* the last interrupt is reserved */
-       hw->intr_tqps_num = RTE_MIN(vec, hw->tqps_num);
-       for (i = 0; i < hw->intr_tqps_num; i++) {
-               /*
-                * Set gap limiter/rate limiter/quanity limiter algorithm
-                * configuration for interrupt coalesce of queue's interrupt.
-                */
-               hns3_set_queue_intr_gl(hw, i, HNS3_RING_GL_RX,
-                                      HNS3_TQP_INTR_GL_DEFAULT);
-               hns3_set_queue_intr_gl(hw, i, HNS3_RING_GL_TX,
-                                      HNS3_TQP_INTR_GL_DEFAULT);
-               hns3_set_queue_intr_rl(hw, i, HNS3_TQP_INTR_RL_DEFAULT);
-               /*
-                * QL(quantity limiter) is not used currently, just set 0 to
-                * close it.
-                */
-               hns3_set_queue_intr_ql(hw, i, HNS3_TQP_INTR_QL_DEFAULT);
-
-               ret = hns3vf_bind_ring_with_vector(hw, vec, false,
-                                                  HNS3_RING_TYPE_TX, i);
-               if (ret) {
-                       PMD_INIT_LOG(ERR, "VF fail to unbind TX ring(%d) with "
-                                         "vector: %u, ret=%d", i, vec, ret);
-                       return ret;
-               }
-
-               ret = hns3vf_bind_ring_with_vector(hw, vec, false,
-                                                  HNS3_RING_TYPE_RX, i);
-               if (ret) {
-                       PMD_INIT_LOG(ERR, "VF fail to unbind RX ring(%d) with "
-                                         "vector: %u, ret=%d", i, vec, ret);
-                       return ret;
-               }
-       }
-
-       return 0;
-}
-
 static int
 hns3vf_dev_configure(struct rte_eth_dev *dev)
 {
@@ -784,8 +464,6 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)
        uint16_t nb_rx_q = dev->data->nb_rx_queues;
        uint16_t nb_tx_q = dev->data->nb_tx_queues;
        struct rte_eth_rss_conf rss_conf;
-       uint32_t max_rx_pkt_len;
-       uint16_t mtu;
        bool gro_en;
        int ret;
 
@@ -801,25 +479,23 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)
         * work as usual. But these fake queues are imperceptible, and can not
         * be used by upper applications.
         */
-       if (!hns3_dev_indep_txrx_supported(hw)) {
-               ret = hns3_set_fake_rx_or_tx_queues(dev, nb_rx_q, nb_tx_q);
-               if (ret) {
-                       hns3_err(hw, "fail to set Rx/Tx fake queues, ret = %d.",
-                                ret);
-                       return ret;
-               }
+       ret = hns3_set_fake_rx_or_tx_queues(dev, nb_rx_q, nb_tx_q);
+       if (ret) {
+               hns3_err(hw, "fail to set Rx/Tx fake queues, ret = %d.", ret);
+               hw->cfg_max_queues = 0;
+               return ret;
        }
 
        hw->adapter_state = HNS3_NIC_CONFIGURING;
-       if (conf->link_speeds & ETH_LINK_SPEED_FIXED) {
+       if (conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) {
                hns3_err(hw, "setting link speed/duplex not supported");
                ret = -EINVAL;
                goto cfg_err;
        }
 
        /* When RSS is not configured, redirect the packet queue 0 */
-       if ((uint32_t)mq_mode & ETH_MQ_RX_RSS_FLAG) {
-               conf->rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
+       if ((uint32_t)mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) {
+               conf->rxmode.offloads |= RTE_ETH_RX_OFFLOAD_RSS_HASH;
                hw->rss_dis_flag = false;
                rss_conf = conf->rx_adv_conf.rss_conf;
                ret = hns3_dev_rss_hash_update(dev, &rss_conf);
@@ -827,35 +503,16 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)
                        goto cfg_err;
        }
 
-       /*
-        * If jumbo frames are enabled, MTU needs to be refreshed
-        * according to the maximum RX packet length.
-        */
-       if (conf->rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {
-               max_rx_pkt_len = conf->rxmode.max_rx_pkt_len;
-               if (max_rx_pkt_len > HNS3_MAX_FRAME_LEN ||
-                   max_rx_pkt_len <= HNS3_DEFAULT_FRAME_LEN) {
-                       hns3_err(hw, "maximum Rx packet length must be greater "
-                                "than %u and less than %u when jumbo frame enabled.",
-                                (uint16_t)HNS3_DEFAULT_FRAME_LEN,
-                                (uint16_t)HNS3_MAX_FRAME_LEN);
-                       ret = -EINVAL;
-                       goto cfg_err;
-               }
-
-               mtu = (uint16_t)HNS3_PKTLEN_TO_MTU(max_rx_pkt_len);
-               ret = hns3vf_dev_mtu_set(dev, mtu);
-               if (ret)
-                       goto cfg_err;
-               dev->data->mtu = mtu;
-       }
+       ret = hns3vf_dev_mtu_set(dev, conf->rxmode.mtu);
+       if (ret != 0)
+               goto cfg_err;
 
        ret = hns3vf_dev_configure_vlan(dev);
        if (ret)
                goto cfg_err;
 
        /* config hardware GRO */
-       gro_en = conf->rxmode.offloads & DEV_RX_OFFLOAD_TCP_LRO ? true : false;
+       gro_en = conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO ? true : false;
        ret = hns3_config_gro(hw, gro_en);
        if (ret)
                goto cfg_err;
@@ -866,6 +523,7 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)
        return 0;
 
 cfg_err:
+       hw->cfg_max_queues = 0;
        (void)hns3_set_fake_rx_or_tx_queues(dev, 0, 0);
        hw->adapter_state = HNS3_NIC_INITIALIZED;
 
@@ -895,9 +553,9 @@ hns3vf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
        /*
         * The hns3 PF/VF devices on the same port share the hardware MTU
         * configuration. Currently, we send mailbox to inform hns3 PF kernel
-        * ethdev driver to finish hardware MTU configuration in hns3 VF PMD
-        * driver, there is no need to stop the port for hns3 VF device, and the
-        * MTU value issued by hns3 VF PMD driver must be less than or equal to
+        * ethdev driver to finish hardware MTU configuration in hns3 VF PMD,
+        * there is no need to stop the port for hns3 VF device, and the
+        * MTU value issued by hns3 VF PMD must be less than or equal to
         * PF's MTU.
         */
        if (__atomic_load_n(&hw->reset.resetting, __ATOMIC_RELAXED)) {
@@ -907,8 +565,8 @@ hns3vf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 
        /*
         * when Rx of scattered packets is off, we have some possibility of
-        * using vector Rx process function or simple Rx functions in hns3 PMD
-        * driver. If the input MTU is increased and the maximum length of
+        * using vector Rx process function or simple Rx functions in hns3 PMD.
+        * If the input MTU is increased and the maximum length of
         * received packets is greater than the length of a buffer for Rx
         * packet, the hardware network engine needs to use multiple BDs and
         * buffers to store these packets. This will cause problems when still
@@ -930,115 +588,11 @@ hns3vf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
                rte_spinlock_unlock(&hw->lock);
                return ret;
        }
-       if (mtu > RTE_ETHER_MTU)
-               dev->data->dev_conf.rxmode.offloads |=
-                                               DEV_RX_OFFLOAD_JUMBO_FRAME;
-       else
-               dev->data->dev_conf.rxmode.offloads &=
-                                               ~DEV_RX_OFFLOAD_JUMBO_FRAME;
-       dev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;
        rte_spinlock_unlock(&hw->lock);
 
        return 0;
 }
 
-static int
-hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
-{
-       struct hns3_adapter *hns = eth_dev->data->dev_private;
-       struct hns3_hw *hw = &hns->hw;
-       uint16_t q_num = hw->tqps_num;
-
-       /*
-        * In interrupt mode, 'max_rx_queues' is set based on the number of
-        * MSI-X interrupt resources of the hardware.
-        */
-       if (hw->data->dev_conf.intr_conf.rxq == 1)
-               q_num = hw->intr_tqps_num;
-
-       info->max_rx_queues = q_num;
-       info->max_tx_queues = hw->tqps_num;
-       info->max_rx_pktlen = HNS3_MAX_FRAME_LEN; /* CRC included */
-       info->min_rx_bufsize = HNS3_MIN_BD_BUF_SIZE;
-       info->max_mac_addrs = HNS3_VF_UC_MACADDR_NUM;
-       info->max_mtu = info->max_rx_pktlen - HNS3_ETH_OVERHEAD;
-       info->max_lro_pkt_size = HNS3_MAX_LRO_SIZE;
-
-       info->rx_offload_capa = (DEV_RX_OFFLOAD_IPV4_CKSUM |
-                                DEV_RX_OFFLOAD_UDP_CKSUM |
-                                DEV_RX_OFFLOAD_TCP_CKSUM |
-                                DEV_RX_OFFLOAD_SCTP_CKSUM |
-                                DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
-                                DEV_RX_OFFLOAD_OUTER_UDP_CKSUM |
-                                DEV_RX_OFFLOAD_SCATTER |
-                                DEV_RX_OFFLOAD_VLAN_STRIP |
-                                DEV_RX_OFFLOAD_VLAN_FILTER |
-                                DEV_RX_OFFLOAD_JUMBO_FRAME |
-                                DEV_RX_OFFLOAD_RSS_HASH |
-                                DEV_RX_OFFLOAD_TCP_LRO);
-       info->tx_offload_capa = (DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
-                                DEV_TX_OFFLOAD_IPV4_CKSUM |
-                                DEV_TX_OFFLOAD_TCP_CKSUM |
-                                DEV_TX_OFFLOAD_UDP_CKSUM |
-                                DEV_TX_OFFLOAD_SCTP_CKSUM |
-                                DEV_TX_OFFLOAD_MULTI_SEGS |
-                                DEV_TX_OFFLOAD_TCP_TSO |
-                                DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
-                                DEV_TX_OFFLOAD_GRE_TNL_TSO |
-                                DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
-                                DEV_TX_OFFLOAD_MBUF_FAST_FREE |
-                                hns3_txvlan_cap_get(hw));
-
-       if (hns3_dev_outer_udp_cksum_supported(hw))
-               info->tx_offload_capa |= DEV_TX_OFFLOAD_OUTER_UDP_CKSUM;
-
-       if (hns3_dev_indep_txrx_supported(hw))
-               info->dev_capa = RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |
-                                RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;
-
-       info->rx_desc_lim = (struct rte_eth_desc_lim) {
-               .nb_max = HNS3_MAX_RING_DESC,
-               .nb_min = HNS3_MIN_RING_DESC,
-               .nb_align = HNS3_ALIGN_RING_DESC,
-       };
-
-       info->tx_desc_lim = (struct rte_eth_desc_lim) {
-               .nb_max = HNS3_MAX_RING_DESC,
-               .nb_min = HNS3_MIN_RING_DESC,
-               .nb_align = HNS3_ALIGN_RING_DESC,
-               .nb_seg_max = HNS3_MAX_TSO_BD_PER_PKT,
-               .nb_mtu_seg_max = hw->max_non_tso_bd_num,
-       };
-
-       info->default_rxconf = (struct rte_eth_rxconf) {
-               .rx_free_thresh = HNS3_DEFAULT_RX_FREE_THRESH,
-               /*
-                * If there are no available Rx buffer descriptors, incoming
-                * packets are always dropped by hardware based on hns3 network
-                * engine.
-                */
-               .rx_drop_en = 1,
-               .offloads = 0,
-       };
-       info->default_txconf = (struct rte_eth_txconf) {
-               .tx_rs_thresh = HNS3_DEFAULT_TX_RS_THRESH,
-               .offloads = 0,
-       };
-
-       info->reta_size = hw->rss_ind_tbl_size;
-       info->hash_key_size = HNS3_RSS_KEY_SIZE;
-       info->flow_type_rss_offloads = HNS3_ETH_RSS_SUPPORT;
-
-       info->default_rxportconf.burst_size = HNS3_DEFAULT_PORT_CONF_BURST_SIZE;
-       info->default_txportconf.burst_size = HNS3_DEFAULT_PORT_CONF_BURST_SIZE;
-       info->default_rxportconf.nb_queues = HNS3_DEFAULT_PORT_CONF_QUEUES_NUM;
-       info->default_txportconf.nb_queues = HNS3_DEFAULT_PORT_CONF_QUEUES_NUM;
-       info->default_rxportconf.ring_size = HNS3_DEFAULT_RING_DESC;
-       info->default_txportconf.ring_size = HNS3_DEFAULT_RING_DESC;
-
-       return 0;
-}
-
 static void
 hns3vf_clear_event_cause(struct hns3_hw *hw, uint32_t regclr)
 {
@@ -1117,6 +671,8 @@ hns3vf_interrupt_handler(void *param)
 
        /* Read out interrupt causes */
        event_cause = hns3vf_check_event_cause(hns, &clearval);
+       /* Clear interrupt causes */
+       hns3vf_clear_event_cause(hw, clearval);
 
        switch (event_cause) {
        case HNS3VF_VECTOR0_EVENT_RST:
@@ -1129,9 +685,6 @@ hns3vf_interrupt_handler(void *param)
                break;
        }
 
-       /* Clear interrupt causes */
-       hns3vf_clear_event_cause(hw, clearval);
-
        /* Enable interrupt */
        hns3vf_enable_irq0(hw);
 }
@@ -1409,28 +962,48 @@ hns3vf_get_queue_depth(struct hns3_hw *hw)
        return 0;
 }
 
+static void
+hns3vf_update_caps(struct hns3_hw *hw, uint32_t caps)
+{
+       if (hns3_get_bit(caps, HNS3VF_CAPS_VLAN_FLT_MOD_B))
+               hns3_set_bit(hw->capability,
+                               HNS3_DEV_SUPPORT_VF_VLAN_FLT_MOD_B, 1);
+}
+
 static int
-hns3vf_get_tc_info(struct hns3_hw *hw)
+hns3vf_get_num_tc(struct hns3_hw *hw)
 {
-       uint8_t resp_msg;
-       int ret;
+       uint8_t num_tc = 0;
        uint32_t i;
 
-       ret = hns3_send_mbx_msg(hw, HNS3_MBX_GET_TCINFO, 0, NULL, 0,
-                               true, &resp_msg, sizeof(resp_msg));
-       if (ret) {
-               hns3_err(hw, "VF request to get TC info from PF failed %d",
-                        ret);
-               return ret;
+       for (i = 0; i < HNS3_MAX_TC_NUM; i++) {
+               if (hw->hw_tc_map & BIT(i))
+                       num_tc++;
        }
+       return num_tc;
+}
 
-       hw->hw_tc_map = resp_msg;
+static int
+hns3vf_get_basic_info(struct hns3_hw *hw)
+{
+       uint8_t resp_msg[HNS3_MBX_MAX_RESP_DATA_SIZE];
+       struct hns3_basic_info *basic_info;
+       int ret;
 
-       for (i = 0; i < HNS3_MAX_TC_NUM; i++) {
-               if (hw->hw_tc_map & BIT(i))
-                       hw->num_tc++;
+       ret = hns3_send_mbx_msg(hw, HNS3_MBX_GET_BASIC_INFO, 0, NULL, 0,
+                               true, resp_msg, sizeof(resp_msg));
+       if (ret) {
+               hns3_err(hw, "failed to get basic info from PF, ret = %d.",
+                               ret);
+               return ret;
        }
 
+       basic_info = (struct hns3_basic_info *)resp_msg;
+       hw->hw_tc_map = basic_info->hw_tc_map;
+       hw->num_tc = hns3vf_get_num_tc(hw);
+       hw->pf_vf_if_version = basic_info->pf_vf_if_version;
+       hns3vf_update_caps(hw, basic_info->caps);
+
        return 0;
 }
 
@@ -1469,6 +1042,11 @@ hns3vf_get_configuration(struct hns3_hw *hw)
 
        hns3vf_get_push_lsc_cap(hw);
 
+       /* Get basic info from PF */
+       ret = hns3vf_get_basic_info(hw);
+       if (ret)
+               return ret;
+
        /* Get queue configuration from PF */
        ret = hns3vf_get_queue_info(hw);
        if (ret)
@@ -1484,12 +1062,7 @@ hns3vf_get_configuration(struct hns3_hw *hw)
        if (ret)
                return ret;
 
-       ret = hns3vf_get_port_base_vlan_filter_state(hw);
-       if (ret)
-               return ret;
-
-       /* Get tc configuration from PF */
-       return hns3vf_get_tc_info(hw);
+       return hns3vf_get_port_base_vlan_filter_state(hw);
 }
 
 static int
@@ -1498,18 +1071,6 @@ hns3vf_set_tc_queue_mapping(struct hns3_adapter *hns, uint16_t nb_rx_q,
 {
        struct hns3_hw *hw = &hns->hw;
 
-       if (nb_rx_q < hw->num_tc) {
-               hns3_err(hw, "number of Rx queues(%u) is less than tcs(%u).",
-                        nb_rx_q, hw->num_tc);
-               return -EINVAL;
-       }
-
-       if (nb_tx_q < hw->num_tc) {
-               hns3_err(hw, "number of Tx queues(%u) is less than tcs(%u).",
-                        nb_tx_q, hw->num_tc);
-               return -EINVAL;
-       }
-
        return hns3_queue_to_tc_mapping(hw, nb_rx_q, nb_tx_q);
 }
 
@@ -1611,6 +1172,26 @@ hns3vf_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
        return ret;
 }
 
+static int
+hns3vf_en_vlan_filter(struct hns3_hw *hw, bool enable)
+{
+       uint8_t msg_data;
+       int ret;
+
+       if (!hns3_dev_get_support(hw, VF_VLAN_FLT_MOD))
+               return 0;
+
+       msg_data = enable ? 1 : 0;
+       ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_VLAN,
+                       HNS3_MBX_ENABLE_VLAN_FILTER, &msg_data,
+                       sizeof(msg_data), true, NULL, 0);
+       if (ret)
+               hns3_err(hw, "%s vlan filter failed, ret = %d.",
+                               enable ? "enable" : "disable", ret);
+
+       return ret;
+}
+
 static int
 hns3vf_en_hw_strip_rxvtag(struct hns3_hw *hw, bool enable)
 {
@@ -1621,7 +1202,8 @@ hns3vf_en_hw_strip_rxvtag(struct hns3_hw *hw, bool enable)
        ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_VLAN, HNS3_MBX_VLAN_RX_OFF_CFG,
                                &msg_data, sizeof(msg_data), false, NULL, 0);
        if (ret)
-               hns3_err(hw, "vf enable strip failed, ret =%d", ret);
+               hns3_err(hw, "vf %s strip failed, ret = %d.",
+                               enable ? "enable" : "disable", ret);
 
        return ret;
 }
@@ -1641,11 +1223,24 @@ hns3vf_vlan_offload_set(struct rte_eth_dev *dev, int mask)
        }
 
        tmp_mask = (unsigned int)mask;
+
+       if (tmp_mask & RTE_ETH_VLAN_FILTER_MASK) {
+               rte_spinlock_lock(&hw->lock);
+               /* Enable or disable VLAN filter */
+               if (dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_VLAN_FILTER)
+                       ret = hns3vf_en_vlan_filter(hw, true);
+               else
+                       ret = hns3vf_en_vlan_filter(hw, false);
+               rte_spinlock_unlock(&hw->lock);
+               if (ret)
+                       return ret;
+       }
+
        /* Vlan stripping setting */
-       if (tmp_mask & ETH_VLAN_STRIP_MASK) {
+       if (tmp_mask & RTE_ETH_VLAN_STRIP_MASK) {
                rte_spinlock_lock(&hw->lock);
                /* Enable or disable VLAN stripping */
-               if (dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_VLAN_STRIP)
+               if (dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)
                        ret = hns3vf_en_hw_strip_rxvtag(hw, true);
                else
                        ret = hns3vf_en_hw_strip_rxvtag(hw, false);
@@ -1713,7 +1308,7 @@ hns3vf_restore_vlan_conf(struct hns3_adapter *hns)
        int ret;
 
        dev_conf = &hw->data->dev_conf;
-       en = dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_VLAN_STRIP ? true
+       en = dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP ? true
                                                                   : false;
        ret = hns3vf_en_hw_strip_rxvtag(hw, en);
        if (ret)
@@ -1738,9 +1333,10 @@ hns3vf_dev_configure_vlan(struct rte_eth_dev *dev)
        }
 
        /* Apply vlan offload setting */
-       ret = hns3vf_vlan_offload_set(dev, ETH_VLAN_STRIP_MASK);
+       ret = hns3vf_vlan_offload_set(dev, RTE_ETH_VLAN_STRIP_MASK |
+                                       RTE_ETH_VLAN_FILTER_MASK);
        if (ret)
-               hns3_err(hw, "dev config vlan offload failed, ret =%d", ret);
+               hns3_err(hw, "dev config vlan offload failed, ret = %d.", ret);
 
        return ret;
 }
@@ -1885,18 +1481,12 @@ hns3vf_init_hardware(struct hns3_adapter *hns)
         * some error caused by the residual configurations, such as the
         * unexpected interrupt, can be avoid.
         */
-       ret = hns3vf_init_ring_with_vector(hw);
+       ret = hns3_init_ring_with_vector(hw);
        if (ret) {
                PMD_INIT_LOG(ERR, "Failed to init ring intr vector: %d", ret);
                goto err_init_hardware;
        }
 
-       ret = hns3vf_set_alive(hw, true);
-       if (ret) {
-               PMD_INIT_LOG(ERR, "Failed to VF send alive to PF: %d", ret);
-               goto err_init_hardware;
-       }
-
        return 0;
 
 err_init_hardware:
@@ -1939,6 +1529,8 @@ hns3vf_init_vf(struct rte_eth_dev *eth_dev)
                goto err_cmd_init;
        }
 
+       hns3_tx_push_init(eth_dev);
+
        /* Get VF resource */
        ret = hns3_query_vf_resource(hw);
        if (ret)
@@ -1948,7 +1540,7 @@ hns3vf_init_vf(struct rte_eth_dev *eth_dev)
 
        hns3vf_clear_event_cause(hw, 0);
 
-       ret = rte_intr_callback_register(&pci_dev->intr_handle,
+       ret = rte_intr_callback_register(pci_dev->intr_handle,
                                         hns3vf_interrupt_handler, eth_dev);
        if (ret) {
                PMD_INIT_LOG(ERR, "Failed to register intr: %d", ret);
@@ -1956,7 +1548,7 @@ hns3vf_init_vf(struct rte_eth_dev *eth_dev)
        }
 
        /* Enable interrupt */
-       rte_intr_enable(&pci_dev->intr_handle);
+       rte_intr_enable(pci_dev->intr_handle);
        hns3vf_enable_irq0(hw);
 
        /* Get configuration from PF */
@@ -1995,6 +1587,12 @@ hns3vf_init_vf(struct rte_eth_dev *eth_dev)
 
        hns3_rss_set_default_args(hw);
 
+       ret = hns3vf_set_alive(hw, true);
+       if (ret) {
+               PMD_INIT_LOG(ERR, "Failed to VF send alive to PF: %d", ret);
+               goto err_set_tc_queue;
+       }
+
        return 0;
 
 err_set_tc_queue:
@@ -2002,8 +1600,8 @@ err_set_tc_queue:
 
 err_get_config:
        hns3vf_disable_irq0(hw);
-       rte_intr_disable(&pci_dev->intr_handle);
-       hns3_intr_unregister(&pci_dev->intr_handle, hns3vf_interrupt_handler,
+       rte_intr_disable(pci_dev->intr_handle);
+       hns3_intr_unregister(pci_dev->intr_handle, hns3vf_interrupt_handler,
                             eth_dev);
 err_intr_callback_register:
 err_cmd_init:
@@ -2028,10 +1626,11 @@ hns3vf_uninit_vf(struct rte_eth_dev *eth_dev)
        (void)hns3_config_gro(hw, false);
        (void)hns3vf_set_alive(hw, false);
        (void)hns3vf_set_promisc_mode(hw, false, false, false);
+       hns3_flow_uninit(eth_dev);
        hns3_tqp_stats_uninit(hw);
        hns3vf_disable_irq0(hw);
-       rte_intr_disable(&pci_dev->intr_handle);
-       hns3_intr_unregister(&pci_dev->intr_handle, hns3vf_interrupt_handler,
+       rte_intr_disable(pci_dev->intr_handle);
+       hns3_intr_unregister(pci_dev->intr_handle, hns3vf_interrupt_handler,
                             eth_dev);
        hns3_cmd_uninit(hw);
        hns3_cmd_destroy_queue(hw);
@@ -2044,7 +1643,7 @@ hns3vf_do_stop(struct hns3_adapter *hns)
        struct hns3_hw *hw = &hns->hw;
        int ret;
 
-       hw->mac.link_status = ETH_LINK_DOWN;
+       hw->mac.link_status = RTE_ETH_LINK_DOWN;
 
        /*
         * The "hns3vf_do_stop" function will also be called by .stop_service to
@@ -2058,7 +1657,7 @@ hns3vf_do_stop(struct hns3_adapter *hns)
                hns3_dev_release_mbufs(hns);
 
        if (__atomic_load_n(&hw->reset.disable_cmd, __ATOMIC_RELAXED) == 0) {
-               hns3vf_configure_mac_addr(hns, true);
+               hns3_configure_all_mac_addr(hns, true);
                ret = hns3_reset_all_tqps(hns);
                if (ret) {
                        hns3_err(hw, "failed to reset all queues ret = %d",
@@ -2069,41 +1668,6 @@ hns3vf_do_stop(struct hns3_adapter *hns)
        return 0;
 }
 
-static void
-hns3vf_unmap_rx_interrupt(struct rte_eth_dev *dev)
-{
-       struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
-       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
-       uint8_t base = RTE_INTR_VEC_ZERO_OFFSET;
-       uint8_t vec = RTE_INTR_VEC_ZERO_OFFSET;
-       uint16_t q_id;
-
-       if (dev->data->dev_conf.intr_conf.rxq == 0)
-               return;
-
-       /* unmap the ring with vector */
-       if (rte_intr_allow_others(intr_handle)) {
-               vec = RTE_INTR_VEC_RXTX_OFFSET;
-               base = RTE_INTR_VEC_RXTX_OFFSET;
-       }
-       if (rte_intr_dp_is_en(intr_handle)) {
-               for (q_id = 0; q_id < hw->used_rx_queues; q_id++) {
-                       (void)hns3vf_bind_ring_with_vector(hw, vec, false,
-                                                          HNS3_RING_TYPE_RX,
-                                                          q_id);
-                       if (vec < base + intr_handle->nb_efd - 1)
-                               vec++;
-               }
-       }
-       /* Clean datapath event and queue/vec mapping */
-       rte_intr_efd_disable(intr_handle);
-       if (intr_handle->intr_vec) {
-               rte_free(intr_handle->intr_vec);
-               intr_handle->intr_vec = NULL;
-       }
-}
-
 static int
 hns3vf_dev_stop(struct rte_eth_dev *dev)
 {
@@ -2119,13 +1683,13 @@ hns3vf_dev_stop(struct rte_eth_dev *dev)
        /* Disable datapath on secondary process. */
        hns3_mp_req_stop_rxtx(dev);
        /* Prevent crashes when queues are still in use. */
-       rte_delay_ms(hw->tqps_num);
+       rte_delay_ms(hw->cfg_max_queues);
 
        rte_spinlock_lock(&hw->lock);
        if (__atomic_load_n(&hw->reset.resetting, __ATOMIC_RELAXED) == 0) {
                hns3_stop_tqps(hw);
                hns3vf_do_stop(hns);
-               hns3vf_unmap_rx_interrupt(dev);
+               hns3_unmap_rx_interrupt(dev);
                hw->adapter_state = HNS3_NIC_CONFIGURED;
        }
        hns3_rx_scattered_reset(dev);
@@ -2144,8 +1708,7 @@ hns3vf_dev_close(struct rte_eth_dev *eth_dev)
        int ret = 0;
 
        if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
-               rte_free(eth_dev->process_private);
-               eth_dev->process_private = NULL;
+               hns3_mp_uninit(eth_dev);
                return 0;
        }
 
@@ -2156,47 +1719,17 @@ hns3vf_dev_close(struct rte_eth_dev *eth_dev)
        hns3_reset_abort(hns);
        hw->adapter_state = HNS3_NIC_CLOSED;
        rte_eal_alarm_cancel(hns3vf_keep_alive_handler, eth_dev);
-       hns3vf_configure_all_mc_mac_addr(hns, true);
+       hns3_configure_all_mc_mac_addr(hns, true);
        hns3vf_remove_all_vlan_table(hns);
        hns3vf_uninit_vf(eth_dev);
        hns3_free_all_queues(eth_dev);
        rte_free(hw->reset.wait_data);
-       rte_free(eth_dev->process_private);
-       eth_dev->process_private = NULL;
-       hns3_mp_uninit_primary();
+       hns3_mp_uninit(eth_dev);
        hns3_warn(hw, "Close port %u finished", hw->data->port_id);
 
        return ret;
 }
 
-static int
-hns3vf_fw_version_get(struct rte_eth_dev *eth_dev, char *fw_version,
-                     size_t fw_size)
-{
-       struct hns3_adapter *hns = eth_dev->data->dev_private;
-       struct hns3_hw *hw = &hns->hw;
-       uint32_t version = hw->fw_version;
-       int ret;
-
-       ret = snprintf(fw_version, fw_size, "%lu.%lu.%lu.%lu",
-                      hns3_get_field(version, HNS3_FW_VERSION_BYTE3_M,
-                                     HNS3_FW_VERSION_BYTE3_S),
-                      hns3_get_field(version, HNS3_FW_VERSION_BYTE2_M,
-                                     HNS3_FW_VERSION_BYTE2_S),
-                      hns3_get_field(version, HNS3_FW_VERSION_BYTE1_M,
-                                     HNS3_FW_VERSION_BYTE1_S),
-                      hns3_get_field(version, HNS3_FW_VERSION_BYTE0_M,
-                                     HNS3_FW_VERSION_BYTE0_S));
-       if (ret < 0)
-               return -EINVAL;
-
-       ret += 1; /* add the size of '\0' */
-       if (fw_size < (size_t)ret)
-               return ret;
-       else
-               return 0;
-}
-
 static int
 hns3vf_dev_link_update(struct rte_eth_dev *eth_dev,
                       __rte_unused int wait_to_complete)
@@ -2208,29 +1741,31 @@ hns3vf_dev_link_update(struct rte_eth_dev *eth_dev,
 
        memset(&new_link, 0, sizeof(new_link));
        switch (mac->link_speed) {
-       case ETH_SPEED_NUM_10M:
-       case ETH_SPEED_NUM_100M:
-       case ETH_SPEED_NUM_1G:
-       case ETH_SPEED_NUM_10G:
-       case ETH_SPEED_NUM_25G:
-       case ETH_SPEED_NUM_40G:
-       case ETH_SPEED_NUM_50G:
-       case ETH_SPEED_NUM_100G:
-       case ETH_SPEED_NUM_200G:
-               new_link.link_speed = mac->link_speed;
+       case RTE_ETH_SPEED_NUM_10M:
+       case RTE_ETH_SPEED_NUM_100M:
+       case RTE_ETH_SPEED_NUM_1G:
+       case RTE_ETH_SPEED_NUM_10G:
+       case RTE_ETH_SPEED_NUM_25G:
+       case RTE_ETH_SPEED_NUM_40G:
+       case RTE_ETH_SPEED_NUM_50G:
+       case RTE_ETH_SPEED_NUM_100G:
+       case RTE_ETH_SPEED_NUM_200G:
+               if (mac->link_status)
+                       new_link.link_speed = mac->link_speed;
                break;
        default:
                if (mac->link_status)
-                       new_link.link_speed = ETH_SPEED_NUM_UNKNOWN;
-               else
-                       new_link.link_speed = ETH_SPEED_NUM_NONE;
+                       new_link.link_speed = RTE_ETH_SPEED_NUM_UNKNOWN;
                break;
        }
 
+       if (!mac->link_status)
+               new_link.link_speed = RTE_ETH_SPEED_NUM_NONE;
+
        new_link.link_duplex = mac->link_duplex;
-       new_link.link_status = mac->link_status ? ETH_LINK_UP : ETH_LINK_DOWN;
+       new_link.link_status = mac->link_status ? RTE_ETH_LINK_UP : RTE_ETH_LINK_DOWN;
        new_link.link_autoneg =
-           !(eth_dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED);
+           !(eth_dev->data->dev_conf.link_speeds & RTE_ETH_LINK_SPEED_FIXED);
 
        return rte_eth_linkstatus_set(eth_dev, &new_link);
 }
@@ -2256,99 +1791,6 @@ hns3vf_do_start(struct hns3_adapter *hns, bool reset_queue)
        return ret;
 }
 
-static int
-hns3vf_map_rx_interrupt(struct rte_eth_dev *dev)
-{
-       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
-       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
-       struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       uint8_t base = RTE_INTR_VEC_ZERO_OFFSET;
-       uint8_t vec = RTE_INTR_VEC_ZERO_OFFSET;
-       uint32_t intr_vector;
-       uint16_t q_id;
-       int ret;
-
-       /*
-        * hns3 needs a separate interrupt to be used as event interrupt which
-        * could not be shared with task queue pair, so KERNEL drivers need
-        * support multiple interrupt vectors.
-        */
-       if (dev->data->dev_conf.intr_conf.rxq == 0 ||
-           !rte_intr_cap_multiple(intr_handle))
-               return 0;
-
-       rte_intr_disable(intr_handle);
-       intr_vector = hw->used_rx_queues;
-       /* It creates event fd for each intr vector when MSIX is used */
-       if (rte_intr_efd_enable(intr_handle, intr_vector))
-               return -EINVAL;
-
-       if (intr_handle->intr_vec == NULL) {
-               intr_handle->intr_vec =
-                       rte_zmalloc("intr_vec",
-                                   hw->used_rx_queues * sizeof(int), 0);
-               if (intr_handle->intr_vec == NULL) {
-                       hns3_err(hw, "Failed to allocate %u rx_queues"
-                                    " intr_vec", hw->used_rx_queues);
-                       ret = -ENOMEM;
-                       goto vf_alloc_intr_vec_error;
-               }
-       }
-
-       if (rte_intr_allow_others(intr_handle)) {
-               vec = RTE_INTR_VEC_RXTX_OFFSET;
-               base = RTE_INTR_VEC_RXTX_OFFSET;
-       }
-
-       for (q_id = 0; q_id < hw->used_rx_queues; q_id++) {
-               ret = hns3vf_bind_ring_with_vector(hw, vec, true,
-                                                  HNS3_RING_TYPE_RX, q_id);
-               if (ret)
-                       goto vf_bind_vector_error;
-               intr_handle->intr_vec[q_id] = vec;
-               /*
-                * If there are not enough efds (e.g. not enough interrupt),
-                * remaining queues will be bond to the last interrupt.
-                */
-               if (vec < base + intr_handle->nb_efd - 1)
-                       vec++;
-       }
-       rte_intr_enable(intr_handle);
-       return 0;
-
-vf_bind_vector_error:
-       free(intr_handle->intr_vec);
-       intr_handle->intr_vec = NULL;
-vf_alloc_intr_vec_error:
-       rte_intr_efd_disable(intr_handle);
-       return ret;
-}
-
-static int
-hns3vf_restore_rx_interrupt(struct hns3_hw *hw)
-{
-       struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
-       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
-       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
-       uint16_t q_id;
-       int ret;
-
-       if (dev->data->dev_conf.intr_conf.rxq == 0)
-               return 0;
-
-       if (rte_intr_dp_is_en(intr_handle)) {
-               for (q_id = 0; q_id < hw->used_rx_queues; q_id++) {
-                       ret = hns3vf_bind_ring_with_vector(hw,
-                                       intr_handle->intr_vec[q_id], true,
-                                       HNS3_RING_TYPE_RX, q_id);
-                       if (ret)
-                               return ret;
-               }
-       }
-
-       return 0;
-}
-
 static void
 hns3vf_restore_filter(struct rte_eth_dev *dev)
 {
@@ -2374,7 +1816,7 @@ hns3vf_dev_start(struct rte_eth_dev *dev)
                rte_spinlock_unlock(&hw->lock);
                return ret;
        }
-       ret = hns3vf_map_rx_interrupt(dev);
+       ret = hns3_map_rx_interrupt(dev);
        if (ret)
                goto map_rx_inter_err;
 
@@ -2558,17 +2000,17 @@ hns3vf_stop_service(struct hns3_adapter *hns)
                 * Make sure call update link status before hns3vf_stop_poll_job
                 * because update link status depend on polling job exist.
                 */
-               hns3vf_update_link_status(hw, ETH_LINK_DOWN, hw->mac.link_speed,
+               hns3vf_update_link_status(hw, RTE_ETH_LINK_DOWN, hw->mac.link_speed,
                                          hw->mac.link_duplex);
                hns3vf_stop_poll_job(eth_dev);
        }
-       hw->mac.link_status = ETH_LINK_DOWN;
+       hw->mac.link_status = RTE_ETH_LINK_DOWN;
 
        hns3_set_rxtx_function(eth_dev);
        rte_wmb();
        /* Disable datapath on secondary process. */
        hns3_mp_req_stop_rxtx(eth_dev);
-       rte_delay_ms(hw->tqps_num);
+       rte_delay_ms(hw->cfg_max_queues);
 
        rte_spinlock_lock(&hw->lock);
        if (hw->adapter_state == HNS3_NIC_STARTED ||
@@ -2585,7 +2027,7 @@ hns3vf_stop_service(struct hns3_adapter *hns)
         * required to delete the entries.
         */
        if (__atomic_load_n(&hw->reset.disable_cmd, __ATOMIC_RELAXED) == 0)
-               hns3vf_configure_all_mc_mac_addr(hns, true);
+               hns3_configure_all_mc_mac_addr(hns, true);
        rte_spinlock_unlock(&hw->lock);
 
        return 0;
@@ -2633,7 +2075,7 @@ hns3vf_check_default_mac_change(struct hns3_hw *hw)
         * ethdev driver sets the MAC address for VF device after the
         * initialization of the related VF device, the PF driver will notify
         * VF driver to reset VF device to make the new MAC address effective
-        * immediately. The hns3 VF PMD driver should check whether the MAC
+        * immediately. The hns3 VF PMD should check whether the MAC
         * address has been changed by the PF kernel ethdev driver, if changed
         * VF driver should configure hardware using the new MAC address in the
         * recovering hardware configuration stage of the reset process.
@@ -2671,11 +2113,11 @@ hns3vf_restore_conf(struct hns3_adapter *hns)
        if (ret)
                return ret;
 
-       ret = hns3vf_configure_mac_addr(hns, false);
+       ret = hns3_configure_all_mac_addr(hns, false);
        if (ret)
                return ret;
 
-       ret = hns3vf_configure_all_mc_mac_addr(hns, false);
+       ret = hns3_configure_all_mc_mac_addr(hns, false);
        if (ret)
                goto err_mc_mac;
 
@@ -2691,7 +2133,7 @@ hns3vf_restore_conf(struct hns3_adapter *hns)
        if (ret)
                goto err_vlan_table;
 
-       ret = hns3vf_restore_rx_interrupt(hw);
+       ret = hns3_restore_rx_interrupt(hw);
        if (ret)
                goto err_vlan_table;
 
@@ -2706,12 +2148,19 @@ hns3vf_restore_conf(struct hns3_adapter *hns)
                hns3_info(hw, "hns3vf dev restart successful!");
        } else if (hw->adapter_state == HNS3_NIC_STOPPING)
                hw->adapter_state = HNS3_NIC_CONFIGURED;
+
+       ret = hns3vf_set_alive(hw, true);
+       if (ret) {
+               hns3_err(hw, "failed to VF send alive to PF: %d", ret);
+               goto err_vlan_table;
+       }
+
        return 0;
 
 err_vlan_table:
-       hns3vf_configure_all_mc_mac_addr(hns, true);
+       hns3_configure_all_mc_mac_addr(hns, true);
 err_mc_mac:
-       hns3vf_configure_mac_addr(hns, true);
+       hns3_configure_all_mac_addr(hns, true);
        return ret;
 }
 
@@ -2797,7 +2246,7 @@ hns3vf_reinit_dev(struct hns3_adapter *hns)
        int ret;
 
        if (hw->reset.level == HNS3_VF_FULL_RESET) {
-               rte_intr_disable(&pci_dev->intr_handle);
+               rte_intr_disable(pci_dev->intr_handle);
                ret = hns3vf_set_bus_master(pci_dev, true);
                if (ret < 0) {
                        hns3_err(hw, "failed to set pci bus, ret = %d", ret);
@@ -2823,7 +2272,7 @@ hns3vf_reinit_dev(struct hns3_adapter *hns)
                                hns3_err(hw, "Failed to enable msix");
                }
 
-               rte_intr_enable(&pci_dev->intr_handle);
+               rte_intr_enable(pci_dev->intr_handle);
        }
 
        ret = hns3_reset_all_tqps(hns);
@@ -2858,8 +2307,8 @@ static const struct eth_dev_ops hns3vf_eth_dev_ops = {
        .xstats_reset       = hns3_dev_xstats_reset,
        .xstats_get_by_id   = hns3_dev_xstats_get_by_id,
        .xstats_get_names_by_id = hns3_dev_xstats_get_names_by_id,
-       .dev_infos_get      = hns3vf_dev_infos_get,
-       .fw_version_get     = hns3vf_fw_version_get,
+       .dev_infos_get      = hns3_dev_infos_get,
+       .fw_version_get     = hns3_fw_version_get,
        .rx_queue_setup     = hns3_rx_queue_setup,
        .tx_queue_setup     = hns3_tx_queue_setup,
        .rx_queue_release   = hns3_dev_rx_queue_release,
@@ -2874,10 +2323,10 @@ static const struct eth_dev_ops hns3vf_eth_dev_ops = {
        .txq_info_get       = hns3_txq_info_get,
        .rx_burst_mode_get  = hns3_rx_burst_mode_get,
        .tx_burst_mode_get  = hns3_tx_burst_mode_get,
-       .mac_addr_add       = hns3vf_add_mac_addr,
-       .mac_addr_remove    = hns3vf_remove_mac_addr,
+       .mac_addr_add       = hns3_add_mac_addr,
+       .mac_addr_remove    = hns3_remove_mac_addr,
        .mac_addr_set       = hns3vf_set_default_mac_addr,
-       .set_mc_addr_list   = hns3vf_set_mc_mac_addr_list,
+       .set_mc_addr_list   = hns3_set_mc_mac_addr_list,
        .link_update        = hns3vf_dev_link_update,
        .rss_hash_update    = hns3_dev_rss_hash_update,
        .rss_hash_conf_get  = hns3_dev_rss_hash_conf_get,
@@ -2901,6 +2350,16 @@ static const struct hns3_reset_ops hns3vf_reset_ops = {
        .start_service       = hns3vf_start_service,
 };
 
+static void
+hns3vf_init_hw_ops(struct hns3_hw *hw)
+{
+       hw->ops.add_mc_mac_addr = hns3vf_add_mc_mac_addr;
+       hw->ops.del_mc_mac_addr = hns3vf_remove_mc_mac_addr;
+       hw->ops.add_uc_mac_addr = hns3vf_add_uc_mac_addr;
+       hw->ops.del_uc_mac_addr = hns3vf_remove_uc_mac_addr;
+       hw->ops.bind_ring_with_vector = hns3vf_bind_ring_with_vector;
+}
+
 static int
 hns3vf_dev_init(struct rte_eth_dev *eth_dev)
 {
@@ -2910,40 +2369,20 @@ hns3vf_dev_init(struct rte_eth_dev *eth_dev)
 
        PMD_INIT_FUNC_TRACE();
 
-       eth_dev->process_private = (struct hns3_process_private *)
-           rte_zmalloc_socket("hns3_filter_list",
-                              sizeof(struct hns3_process_private),
-                              RTE_CACHE_LINE_SIZE, eth_dev->device->numa_node);
-       if (eth_dev->process_private == NULL) {
-               PMD_INIT_LOG(ERR, "Failed to alloc memory for process private");
-               return -ENOMEM;
-       }
-
        hns3_flow_init(eth_dev);
 
        hns3_set_rxtx_function(eth_dev);
        eth_dev->dev_ops = &hns3vf_eth_dev_ops;
        eth_dev->rx_queue_count = hns3_rx_queue_count;
-       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
-               ret = hns3_mp_init_secondary();
-               if (ret) {
-                       PMD_INIT_LOG(ERR, "Failed to init for secondary "
-                                         "process, ret = %d", ret);
-                       goto err_mp_init_secondary;
-               }
+       ret = hns3_mp_init(eth_dev);
+       if (ret)
+               goto err_mp_init;
 
-               hw->secondary_cnt++;
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+               hns3_tx_push_init(eth_dev);
                return 0;
        }
 
-       ret = hns3_mp_init_primary();
-       if (ret) {
-               PMD_INIT_LOG(ERR,
-                            "Failed to init for primary process, ret = %d",
-                            ret);
-               goto err_mp_init_primary;
-       }
-
        hw->adapter_state = HNS3_NIC_UNINITIALIZED;
        hns->is_vf = true;
        hw->data = eth_dev->data;
@@ -2954,6 +2393,7 @@ hns3vf_dev_init(struct rte_eth_dev *eth_dev)
                goto err_init_reset;
        hw->reset.ops = &hns3vf_reset_ops;
 
+       hns3vf_init_hw_ops(hw);
        ret = hns3vf_init_vf(eth_dev);
        if (ret) {
                PMD_INIT_LOG(ERR, "Failed to init vf: %d", ret);
@@ -2976,12 +2416,12 @@ hns3vf_dev_init(struct rte_eth_dev *eth_dev)
        /*
         * The hns3 PF ethdev driver in kernel support setting VF MAC address
         * on the host by "ip link set ..." command. To avoid some incorrect
-        * scenes, for example, hns3 VF PMD driver fails to receive and send
+        * scenes, for example, hns3 VF PMD fails to receive and send
         * packets after user configure the MAC address by using the
-        * "ip link set ..." command, hns3 VF PMD driver keep the same MAC
+        * "ip link set ..." command, hns3 VF PMD keep the same MAC
         * address strategy as the hns3 kernel ethdev driver in the
         * initialization. If user configure a MAC address by the ip command
-        * for VF device, then hns3 VF PMD driver will start with it, otherwise
+        * for VF device, then hns3 VF PMD will start with it, otherwise
         * start with a random MAC address in the initialization.
         */
        if (rte_is_zero_ether_addr((struct rte_ether_addr *)hw->mac.mac_addr))
@@ -3010,18 +2450,15 @@ err_init_vf:
        rte_free(hw->reset.wait_data);
 
 err_init_reset:
-       hns3_mp_uninit_primary();
+       hns3_mp_uninit(eth_dev);
 
-err_mp_init_primary:
-err_mp_init_secondary:
+err_mp_init:
        eth_dev->dev_ops = NULL;
        eth_dev->rx_pkt_burst = NULL;
        eth_dev->rx_descriptor_status = NULL;
        eth_dev->tx_pkt_burst = NULL;
        eth_dev->tx_pkt_prepare = NULL;
        eth_dev->tx_descriptor_status = NULL;
-       rte_free(eth_dev->process_private);
-       eth_dev->process_private = NULL;
 
        return ret;
 }
@@ -3035,8 +2472,8 @@ hns3vf_dev_uninit(struct rte_eth_dev *eth_dev)
        PMD_INIT_FUNC_TRACE();
 
        if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
-               rte_free(eth_dev->process_private);
-               eth_dev->process_private = NULL;
+               __atomic_fetch_sub(&hw->secondary_cnt, 1, __ATOMIC_RELAXED);
+               hns3_mp_uninit(eth_dev);
                return 0;
        }
 
@@ -3081,4 +2518,5 @@ RTE_PMD_REGISTER_KMOD_DEP(net_hns3_vf, "* igb_uio | vfio-pci");
 RTE_PMD_REGISTER_PARAM_STRING(net_hns3_vf,
                HNS3_DEVARG_RX_FUNC_HINT "=vec|sve|simple|common "
                HNS3_DEVARG_TX_FUNC_HINT "=vec|sve|simple|common "
-               HNS3_DEVARG_DEV_CAPS_MASK "=<1-65535> ");
+               HNS3_DEVARG_DEV_CAPS_MASK "=<1-65535> "
+               HNS3_DEVARG_MBX_TIME_LIMIT_MS "=<uint16_t> ");