net/hns3: check multi-process action register result
[dpdk.git] / drivers / net / hns3 / hns3_ethdev_vf.c
index eca585d..54e5dac 100644 (file)
@@ -59,6 +59,10 @@ static enum hns3_reset_level hns3vf_get_reset_level(struct hns3_hw *hw,
 static int hns3vf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
 static int hns3vf_dev_configure_vlan(struct rte_eth_dev *dev);
 
+static int hns3vf_add_mc_mac_addr(struct hns3_hw *hw,
+                                 struct rte_ether_addr *mac_addr);
+static int hns3vf_remove_mc_mac_addr(struct hns3_hw *hw,
+                                    struct rte_ether_addr *mac_addr);
 /* set PCI bus mastering */
 static void
 hns3vf_set_bus_master(const struct rte_pci_device *device, bool op)
@@ -134,6 +138,76 @@ hns3vf_enable_msix(const struct rte_pci_device *device, bool op)
        return -ENXIO;
 }
 
+static int
+hns3vf_add_uc_mac_addr(struct hns3_hw *hw, struct rte_ether_addr *mac_addr)
+{
+       /* mac address was checked by upper level interface */
+       char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
+       int ret;
+
+       ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_UNICAST,
+                               HNS3_MBX_MAC_VLAN_UC_ADD, mac_addr->addr_bytes,
+                               RTE_ETHER_ADDR_LEN, false, NULL, 0);
+       if (ret) {
+               rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
+                                     mac_addr);
+               hns3_err(hw, "failed to add uc mac addr(%s), ret = %d",
+                        mac_str, ret);
+       }
+       return ret;
+}
+
+static int
+hns3vf_remove_uc_mac_addr(struct hns3_hw *hw, struct rte_ether_addr *mac_addr)
+{
+       /* mac address was checked by upper level interface */
+       char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
+       int ret;
+
+       ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_UNICAST,
+                               HNS3_MBX_MAC_VLAN_UC_REMOVE,
+                               mac_addr->addr_bytes, RTE_ETHER_ADDR_LEN,
+                               false, NULL, 0);
+       if (ret) {
+               rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
+                                     mac_addr);
+               hns3_err(hw, "failed to add uc mac addr(%s), ret = %d",
+                        mac_str, ret);
+       }
+       return ret;
+}
+
+static int
+hns3vf_add_mc_addr_common(struct hns3_hw *hw, struct rte_ether_addr *mac_addr)
+{
+       char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
+       struct rte_ether_addr *addr;
+       int ret;
+       int i;
+
+       for (i = 0; i < hw->mc_addrs_num; i++) {
+               addr = &hw->mc_addrs[i];
+               /* Check if there are duplicate addresses */
+               if (rte_is_same_ether_addr(addr, mac_addr)) {
+                       rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
+                                             addr);
+                       hns3_err(hw, "failed to add mc mac addr, same addrs"
+                                "(%s) is added by the set_mc_mac_addr_list "
+                                "API", mac_str);
+                       return -EINVAL;
+               }
+       }
+
+       ret = hns3vf_add_mc_mac_addr(hw, mac_addr);
+       if (ret) {
+               rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
+                                     mac_addr);
+               hns3_err(hw, "failed to add mc mac addr(%s), ret = %d",
+                        mac_str, ret);
+       }
+       return ret;
+}
+
 static int
 hns3vf_add_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,
                    __rte_unused uint32_t idx,
@@ -144,14 +218,26 @@ hns3vf_add_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,
        int ret;
 
        rte_spinlock_lock(&hw->lock);
-       ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_UNICAST,
-                               HNS3_MBX_MAC_VLAN_UC_ADD, mac_addr->addr_bytes,
-                               RTE_ETHER_ADDR_LEN, false, NULL, 0);
+
+       /*
+        * In hns3 network engine adding UC and MC mac address with different
+        * commands with firmware. We need to determine whether the input
+        * address is a UC or a MC address to call different commands.
+        * By the way, it is recommended calling the API function named
+        * rte_eth_dev_set_mc_addr_list to set the MC mac address, because
+        * using the rte_eth_dev_mac_addr_add API function to set MC mac address
+        * may affect the specifications of UC mac addresses.
+        */
+       if (rte_is_multicast_ether_addr(mac_addr))
+               ret = hns3vf_add_mc_addr_common(hw, mac_addr);
+       else
+               ret = hns3vf_add_uc_mac_addr(hw, mac_addr);
+
        rte_spinlock_unlock(&hw->lock);
        if (ret) {
                rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
                                      mac_addr);
-               hns3_err(hw, "Failed to add mac addr(%s) for vf: %d", mac_str,
+               hns3_err(hw, "failed to add mac addr(%s), ret = %d", mac_str,
                         ret);
        }
 
@@ -168,15 +254,17 @@ hns3vf_remove_mac_addr(struct rte_eth_dev *dev, uint32_t idx)
        int ret;
 
        rte_spinlock_lock(&hw->lock);
-       ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_UNICAST,
-                               HNS3_MBX_MAC_VLAN_UC_REMOVE,
-                               mac_addr->addr_bytes, RTE_ETHER_ADDR_LEN, false,
-                               NULL, 0);
+
+       if (rte_is_multicast_ether_addr(mac_addr))
+               ret = hns3vf_remove_mc_mac_addr(hw, mac_addr);
+       else
+               ret = hns3vf_remove_uc_mac_addr(hw, mac_addr);
+
        rte_spinlock_unlock(&hw->lock);
        if (ret) {
                rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
                                      mac_addr);
-               hns3_err(hw, "Failed to remove mac addr(%s) for vf: %d",
+               hns3_err(hw, "failed to remove mac addr(%s), ret = %d",
                         mac_str, ret);
        }
 }
@@ -239,39 +327,39 @@ hns3vf_configure_mac_addr(struct hns3_adapter *hns, bool del)
 {
        struct hns3_hw *hw = &hns->hw;
        struct rte_ether_addr *addr;
-       enum hns3_mbx_mac_vlan_subcode opcode;
        char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
-       int ret = 0;
+       int err = 0;
+       int ret;
        int i;
 
-       if (del)
-               opcode = HNS3_MBX_MAC_VLAN_UC_REMOVE;
-       else
-               opcode = HNS3_MBX_MAC_VLAN_UC_ADD;
        for (i = 0; i < HNS3_VF_UC_MACADDR_NUM; i++) {
                addr = &hw->data->mac_addrs[i];
-               if (!rte_is_valid_assigned_ether_addr(addr))
+               if (rte_is_zero_ether_addr(addr))
                        continue;
-               rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, addr);
-               hns3_dbg(hw, "rm mac addr: %s", mac_str);
-               ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_UNICAST, opcode,
-                                       addr->addr_bytes, RTE_ETHER_ADDR_LEN,
-                                       false, NULL, 0);
+               if (rte_is_multicast_ether_addr(addr))
+                       ret = del ? hns3vf_remove_mc_mac_addr(hw, addr) :
+                             hns3vf_add_mc_mac_addr(hw, addr);
+               else
+                       ret = del ? hns3vf_remove_uc_mac_addr(hw, addr) :
+                             hns3vf_add_uc_mac_addr(hw, addr);
+
                if (ret) {
-                       hns3_err(hw, "Failed to remove mac addr for vf: %d",
-                                ret);
-                       break;
+                       err = ret;
+                       rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
+                                             addr);
+                       hns3_err(hw, "failed to %s mac addr(%s) index:%d "
+                                "ret = %d.", del ? "remove" : "restore",
+                                mac_str, i, ret);
                }
        }
-       return ret;
+       return err;
 }
 
 static int
-hns3vf_add_mc_mac_addr(struct hns3_adapter *hns,
+hns3vf_add_mc_mac_addr(struct hns3_hw *hw,
                       struct rte_ether_addr *mac_addr)
 {
        char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
-       struct hns3_hw *hw = &hns->hw;
        int ret;
 
        ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_MULTICAST,
@@ -289,11 +377,10 @@ hns3vf_add_mc_mac_addr(struct hns3_adapter *hns,
 }
 
 static int
-hns3vf_remove_mc_mac_addr(struct hns3_adapter *hns,
+hns3vf_remove_mc_mac_addr(struct hns3_hw *hw,
                          struct rte_ether_addr *mac_addr)
 {
        char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
-       struct hns3_hw *hw = &hns->hw;
        int ret;
 
        ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_MULTICAST,
@@ -311,45 +398,92 @@ hns3vf_remove_mc_mac_addr(struct hns3_adapter *hns,
 }
 
 static int
-hns3vf_set_mc_mac_addr_list(struct rte_eth_dev *dev,
-                           struct rte_ether_addr *mc_addr_set,
-                           uint32_t nb_mc_addr)
+hns3vf_set_mc_addr_chk_param(struct hns3_hw *hw,
+                            struct rte_ether_addr *mc_addr_set,
+                            uint32_t nb_mc_addr)
 {
-       struct hns3_adapter *hns = dev->data->dev_private;
-       struct hns3_hw *hw = &hns->hw;
-       struct rte_ether_addr *addr;
        char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
-       int cur_addr_num;
-       int set_addr_num;
-       int num;
-       int ret;
-       int i;
+       struct rte_ether_addr *addr;
+       uint32_t i;
+       uint32_t j;
 
        if (nb_mc_addr > HNS3_MC_MACADDR_NUM) {
-               hns3_err(hw, "Failed to set mc mac addr, nb_mc_addr(%d) "
+               hns3_err(hw, "failed to set mc mac addr, nb_mc_addr(%d) "
                         "invalid. valid range: 0~%d",
                         nb_mc_addr, HNS3_MC_MACADDR_NUM);
                return -EINVAL;
        }
 
-       set_addr_num = (int)nb_mc_addr;
-       for (i = 0; i < set_addr_num; i++) {
+       /* Check if input mac addresses are valid */
+       for (i = 0; i < nb_mc_addr; i++) {
                addr = &mc_addr_set[i];
                if (!rte_is_multicast_ether_addr(addr)) {
                        rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
                                              addr);
                        hns3_err(hw,
-                                "Failed to set mc mac addr, addr(%s) invalid.",
+                                "failed to set mc mac addr, addr(%s) invalid.",
                                 mac_str);
                        return -EINVAL;
                }
+
+               /* Check if there are duplicate addresses */
+               for (j = i + 1; j < nb_mc_addr; j++) {
+                       if (rte_is_same_ether_addr(addr, &mc_addr_set[j])) {
+                               rte_ether_format_addr(mac_str,
+                                                     RTE_ETHER_ADDR_FMT_SIZE,
+                                                     addr);
+                               hns3_err(hw, "failed to set mc mac addr, "
+                                        "addrs invalid. two same addrs(%s).",
+                                        mac_str);
+                               return -EINVAL;
+                       }
+               }
+
+               /*
+                * Check if there are duplicate addresses between mac_addrs
+                * and mc_addr_set
+                */
+               for (j = 0; j < HNS3_VF_UC_MACADDR_NUM; j++) {
+                       if (rte_is_same_ether_addr(addr,
+                                                  &hw->data->mac_addrs[j])) {
+                               rte_ether_format_addr(mac_str,
+                                                     RTE_ETHER_ADDR_FMT_SIZE,
+                                                     addr);
+                               hns3_err(hw, "failed to set mc mac addr, "
+                                        "addrs invalid. addrs(%s) has already "
+                                        "configured in mac_addr add API",
+                                        mac_str);
+                               return -EINVAL;
+                       }
+               }
        }
+
+       return 0;
+}
+
+static int
+hns3vf_set_mc_mac_addr_list(struct rte_eth_dev *dev,
+                           struct rte_ether_addr *mc_addr_set,
+                           uint32_t nb_mc_addr)
+{
+       struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct rte_ether_addr *addr;
+       int cur_addr_num;
+       int set_addr_num;
+       int num;
+       int ret;
+       int i;
+
+       ret = hns3vf_set_mc_addr_chk_param(hw, mc_addr_set, nb_mc_addr);
+       if (ret)
+               return ret;
+
        rte_spinlock_lock(&hw->lock);
        cur_addr_num = hw->mc_addrs_num;
        for (i = 0; i < cur_addr_num; i++) {
                num = cur_addr_num - i - 1;
                addr = &hw->mc_addrs[num];
-               ret = hns3vf_remove_mc_mac_addr(hns, addr);
+               ret = hns3vf_remove_mc_mac_addr(hw, addr);
                if (ret) {
                        rte_spinlock_unlock(&hw->lock);
                        return ret;
@@ -358,9 +492,10 @@ hns3vf_set_mc_mac_addr_list(struct rte_eth_dev *dev,
                hw->mc_addrs_num--;
        }
 
+       set_addr_num = (int)nb_mc_addr;
        for (i = 0; i < set_addr_num; i++) {
                addr = &mc_addr_set[i];
-               ret = hns3vf_add_mc_mac_addr(hns, addr);
+               ret = hns3vf_add_mc_mac_addr(hw, addr);
                if (ret) {
                        rte_spinlock_unlock(&hw->lock);
                        return ret;
@@ -389,9 +524,9 @@ hns3vf_configure_all_mc_mac_addr(struct hns3_adapter *hns, bool del)
                if (!rte_is_multicast_ether_addr(addr))
                        continue;
                if (del)
-                       ret = hns3vf_remove_mc_mac_addr(hns, addr);
+                       ret = hns3vf_remove_mc_mac_addr(hw, addr);
                else
-                       ret = hns3vf_add_mc_mac_addr(hns, addr);
+                       ret = hns3vf_add_mc_mac_addr(hw, addr);
                if (ret) {
                        err = ret;
                        rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE,
@@ -578,7 +713,8 @@ hns3vf_init_ring_with_vector(struct hns3_hw *hw)
         * Rx interrupt.
         */
        vec = hw->num_msi - 1; /* vector 0 for misc interrupt, not for queue */
-       hw->intr_tqps_num = vec - 1; /* the last interrupt is reserved */
+       /* vec - 1: the last interrupt is reserved */
+       hw->intr_tqps_num = vec > hw->tqps_num ? hw->tqps_num : vec - 1;
        for (i = 0; i < hw->intr_tqps_num; i++) {
                /*
                 * Set gap limiter and rate limiter configuration of queue's
@@ -621,6 +757,7 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)
        uint16_t nb_tx_q = dev->data->nb_tx_queues;
        struct rte_eth_rss_conf rss_conf;
        uint16_t mtu;
+       bool gro_en;
        int ret;
 
        /*
@@ -648,6 +785,7 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)
 
        /* When RSS is not configured, redirect the packet queue 0 */
        if ((uint32_t)mq_mode & ETH_MQ_RX_RSS_FLAG) {
+               conf->rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
                rss_conf = conf->rx_adv_conf.rss_conf;
                if (rss_conf.rss_key == NULL) {
                        rss_conf.rss_key = rss_cfg->key;
@@ -680,6 +818,12 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)
        if (ret)
                goto cfg_err;
 
+       /* config hardware GRO */
+       gro_en = conf->rxmode.offloads & DEV_RX_OFFLOAD_TCP_LRO ? true : false;
+       ret = hns3_config_gro(hw, gro_en);
+       if (ret)
+               goto cfg_err;
+
        hw->adapter_state = HNS3_NIC_CONFIGURED;
        return 0;
 
@@ -758,9 +902,10 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
        info->max_rx_queues = q_num;
        info->max_tx_queues = hw->tqps_num;
        info->max_rx_pktlen = HNS3_MAX_FRAME_LEN; /* CRC included */
-       info->min_rx_bufsize = hw->rx_buf_len;
+       info->min_rx_bufsize = HNS3_MIN_BD_BUF_SIZE;
        info->max_mac_addrs = HNS3_VF_UC_MACADDR_NUM;
        info->max_mtu = info->max_rx_pktlen - HNS3_ETH_OVERHEAD;
+       info->max_lro_pkt_size = HNS3_MAX_LRO_SIZE;
 
        info->rx_offload_capa = (DEV_RX_OFFLOAD_IPV4_CKSUM |
                                 DEV_RX_OFFLOAD_UDP_CKSUM |
@@ -771,23 +916,23 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
                                 DEV_RX_OFFLOAD_KEEP_CRC |
                                 DEV_RX_OFFLOAD_SCATTER |
                                 DEV_RX_OFFLOAD_VLAN_STRIP |
-                                DEV_RX_OFFLOAD_QINQ_STRIP |
                                 DEV_RX_OFFLOAD_VLAN_FILTER |
-                                DEV_RX_OFFLOAD_JUMBO_FRAME);
+                                DEV_RX_OFFLOAD_JUMBO_FRAME |
+                                DEV_RX_OFFLOAD_RSS_HASH |
+                                DEV_RX_OFFLOAD_TCP_LRO);
        info->tx_queue_offload_capa = DEV_TX_OFFLOAD_MBUF_FAST_FREE;
        info->tx_offload_capa = (DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
                                 DEV_TX_OFFLOAD_IPV4_CKSUM |
                                 DEV_TX_OFFLOAD_TCP_CKSUM |
                                 DEV_TX_OFFLOAD_UDP_CKSUM |
                                 DEV_TX_OFFLOAD_SCTP_CKSUM |
-                                DEV_TX_OFFLOAD_VLAN_INSERT |
-                                DEV_TX_OFFLOAD_QINQ_INSERT |
                                 DEV_TX_OFFLOAD_MULTI_SEGS |
                                 DEV_TX_OFFLOAD_TCP_TSO |
                                 DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
                                 DEV_TX_OFFLOAD_GRE_TNL_TSO |
                                 DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
-                                info->tx_queue_offload_capa);
+                                info->tx_queue_offload_capa |
+                                hns3_txvlan_cap_get(hw));
 
        info->rx_desc_lim = (struct rte_eth_desc_lim) {
                .nb_max = HNS3_MAX_RING_DESC,
@@ -799,6 +944,8 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
                .nb_max = HNS3_MAX_RING_DESC,
                .nb_min = HNS3_MIN_RING_DESC,
                .nb_align = HNS3_ALIGN_RING_DESC,
+               .nb_seg_max = HNS3_MAX_TSO_BD_PER_PKT,
+               .nb_mtu_seg_max = HNS3_MAX_NON_TSO_BD_PER_PKT,
        };
 
        info->vmdq_queue_num = 0;
@@ -913,6 +1060,29 @@ hns3vf_interrupt_handler(void *param)
        hns3vf_enable_irq0(hw);
 }
 
+static int
+hns3vf_get_capability(struct hns3_hw *hw)
+{
+       struct rte_pci_device *pci_dev;
+       struct rte_eth_dev *eth_dev;
+       uint8_t revision;
+       int ret;
+
+       eth_dev = &rte_eth_devices[hw->data->port_id];
+       pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
+
+       /* Get PCI revision id */
+       ret = rte_pci_read_config(pci_dev, &revision, HNS3_PCI_REVISION_ID_LEN,
+                                 HNS3_PCI_REVISION_ID);
+       if (ret != HNS3_PCI_REVISION_ID_LEN) {
+               PMD_INIT_LOG(ERR, "failed to read pci revision id: %d", ret);
+               return -EIO;
+       }
+       hw->revision = revision;
+
+       return 0;
+}
+
 static int
 hns3vf_check_tqp_info(struct hns3_hw *hw)
 {
@@ -926,12 +1096,53 @@ hns3vf_check_tqp_info(struct hns3_hw *hw)
                return -EINVAL;
        }
 
-       if (hw->rx_buf_len == 0)
-               hw->rx_buf_len = HNS3_DEFAULT_RX_BUF_LEN;
        hw->alloc_rss_size = RTE_MIN(hw->rss_size_max, hw->tqps_num);
 
        return 0;
 }
+static int
+hns3vf_get_port_base_vlan_filter_state(struct hns3_hw *hw)
+{
+       uint8_t resp_msg;
+       int ret;
+
+       ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_VLAN,
+                               HNS3_MBX_GET_PORT_BASE_VLAN_STATE, NULL, 0,
+                               true, &resp_msg, sizeof(resp_msg));
+       if (ret) {
+               if (ret == -ETIME) {
+                       /*
+                        * Getting current port based VLAN state from PF driver
+                        * will not affect VF driver's basic function. Because
+                        * the VF driver relies on hns3 PF kernel ether driver,
+                        * to avoid introducing compatibility issues with older
+                        * version of PF driver, no failure will be returned
+                        * when the return value is ETIME. This return value has
+                        * the following scenarios:
+                        * 1) Firmware didn't return the results in time
+                        * 2) the result return by firmware is timeout
+                        * 3) the older version of kernel side PF driver does
+                        *    not support this mailbox message.
+                        * For scenarios 1 and 2, it is most likely that a
+                        * hardware error has occurred, or a hardware reset has
+                        * occurred. In this case, these errors will be caught
+                        * by other functions.
+                        */
+                       PMD_INIT_LOG(WARNING,
+                               "failed to get PVID state for timeout, maybe "
+                               "kernel side PF driver doesn't support this "
+                               "mailbox message, or firmware didn't respond.");
+                       resp_msg = HNS3_PORT_BASE_VLAN_DISABLE;
+               } else {
+                       PMD_INIT_LOG(ERR, "failed to get port based VLAN state,"
+                               " ret = %d", ret);
+                       return ret;
+               }
+       }
+       hw->port_base_vlan_cfg.state = resp_msg ?
+               HNS3_PORT_BASE_VLAN_ENABLE : HNS3_PORT_BASE_VLAN_DISABLE;
+       return 0;
+}
 
 static int
 hns3vf_get_queue_info(struct hns3_hw *hw)
@@ -949,7 +1160,6 @@ hns3vf_get_queue_info(struct hns3_hw *hw)
 
        memcpy(&hw->tqps_num, &resp_msg[0], sizeof(uint16_t));
        memcpy(&hw->rss_size_max, &resp_msg[2], sizeof(uint16_t));
-       memcpy(&hw->rx_buf_len, &resp_msg[4], sizeof(uint16_t));
 
        return hns3vf_check_tqp_info(hw);
 }
@@ -1020,6 +1230,13 @@ hns3vf_get_configuration(struct hns3_hw *hw)
        hw->mac.media_type = HNS3_MEDIA_TYPE_NONE;
        hw->rss_dis_flag = false;
 
+       /* Get device capability */
+       ret = hns3vf_get_capability(hw);
+       if (ret) {
+               PMD_INIT_LOG(ERR, "failed to get device capability: %d.", ret);
+               return ret;
+       }
+
        /* Get queue configuration from PF */
        ret = hns3vf_get_queue_info(hw);
        if (ret)
@@ -1035,6 +1252,10 @@ hns3vf_get_configuration(struct hns3_hw *hw)
        if (ret)
                return ret;
 
+       ret = hns3vf_get_port_base_vlan_filter_state(hw);
+       if (ret)
+               return ret;
+
        /* Get tc configuration from PF */
        return hns3vf_get_tc_info(hw);
 }
@@ -1337,7 +1558,7 @@ hns3_query_vf_resource(struct hns3_hw *hw)
                return -EINVAL;
        }
 
-       hw->num_msi = (num_msi > hw->tqps_num + 1) ? hw->tqps_num + 1 : num_msi;
+       hw->num_msi = num_msi;
 
        return 0;
 }
@@ -1369,6 +1590,18 @@ hns3vf_init_hardware(struct hns3_adapter *hns)
                goto err_init_hardware;
        }
 
+       /*
+        * In the initialization clearing the all hardware mapping relationship
+        * configurations between queues and interrupt vectors is needed, so
+        * some error caused by the residual configurations, such as the
+        * unexpected interrupt, can be avoid.
+        */
+       ret = hns3vf_init_ring_with_vector(hw);
+       if (ret) {
+               PMD_INIT_LOG(ERR, "Failed to init ring intr vector: %d", ret);
+               goto err_init_hardware;
+       }
+
        ret = hns3vf_set_alive(hw, true);
        if (ret) {
                PMD_INIT_LOG(ERR, "Failed to VF send alive to PF: %d", ret);
@@ -1472,16 +1705,6 @@ hns3vf_init_vf(struct rte_eth_dev *eth_dev)
 
        hns3_set_default_rss_args(hw);
 
-       /*
-        * In the initialization clearing the all hardware mapping relationship
-        * configurations between queues and interrupt vectors is needed, so
-        * some error caused by the residual configurations, such as the
-        * unexpected interrupt, can be avoid.
-        */
-       ret = hns3vf_init_ring_with_vector(hw);
-       if (ret)
-               goto err_get_config;
-
        return 0;
 
 err_get_config:
@@ -1509,6 +1732,7 @@ hns3vf_uninit_vf(struct rte_eth_dev *eth_dev)
        PMD_INIT_FUNC_TRACE();
 
        hns3_rss_uninit(hns);
+       (void)hns3_config_gro(hw, false);
        (void)hns3vf_set_alive(hw, false);
        (void)hns3vf_set_promisc_mode(hw, false, false, false);
        hns3vf_disable_irq0(hw);
@@ -1542,8 +1766,8 @@ hns3vf_unmap_rx_interrupt(struct rte_eth_dev *dev)
        struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
-       uint8_t base = 0;
-       uint8_t vec = 0;
+       uint8_t base = RTE_INTR_VEC_ZERO_OFFSET;
+       uint8_t vec = RTE_INTR_VEC_ZERO_OFFSET;
        uint16_t q_id;
 
        if (dev->data->dev_conf.intr_conf.rxq == 0)
@@ -1590,13 +1814,12 @@ hns3vf_dev_stop(struct rte_eth_dev *dev)
        rte_spinlock_lock(&hw->lock);
        if (rte_atomic16_read(&hw->reset.resetting) == 0) {
                hns3vf_do_stop(hns);
+               hns3vf_unmap_rx_interrupt(dev);
                hns3_dev_release_mbufs(hns);
                hw->adapter_state = HNS3_NIC_CONFIGURED;
        }
        rte_eal_alarm_cancel(hns3vf_service_handler, dev);
        rte_spinlock_unlock(&hw->lock);
-
-       hns3vf_unmap_rx_interrupt(dev);
 }
 
 static void
@@ -1626,6 +1849,31 @@ hns3vf_dev_close(struct rte_eth_dev *eth_dev)
        hns3_warn(hw, "Close port %d finished", hw->data->port_id);
 }
 
+static int
+hns3vf_fw_version_get(struct rte_eth_dev *eth_dev, char *fw_version,
+                     size_t fw_size)
+{
+       struct hns3_adapter *hns = eth_dev->data->dev_private;
+       struct hns3_hw *hw = &hns->hw;
+       uint32_t version = hw->fw_version;
+       int ret;
+
+       ret = snprintf(fw_version, fw_size, "%lu.%lu.%lu.%lu",
+                      hns3_get_field(version, HNS3_FW_VERSION_BYTE3_M,
+                                     HNS3_FW_VERSION_BYTE3_S),
+                      hns3_get_field(version, HNS3_FW_VERSION_BYTE2_M,
+                                     HNS3_FW_VERSION_BYTE2_S),
+                      hns3_get_field(version, HNS3_FW_VERSION_BYTE1_M,
+                                     HNS3_FW_VERSION_BYTE1_S),
+                      hns3_get_field(version, HNS3_FW_VERSION_BYTE0_M,
+                                     HNS3_FW_VERSION_BYTE0_S));
+       ret += 1; /* add the size of '\0' */
+       if (fw_size < (uint32_t)ret)
+               return ret;
+       else
+               return 0;
+}
+
 static int
 hns3vf_dev_link_update(struct rte_eth_dev *eth_dev,
                       __rte_unused int wait_to_complete)
@@ -1683,9 +1931,9 @@ hns3vf_map_rx_interrupt(struct rte_eth_dev *dev)
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
        struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       uint8_t base = RTE_INTR_VEC_ZERO_OFFSET;
+       uint8_t vec = RTE_INTR_VEC_ZERO_OFFSET;
        uint32_t intr_vector;
-       uint8_t base = 0;
-       uint8_t vec = 0;
        uint16_t q_id;
        int ret;
 
@@ -1746,6 +1994,31 @@ vf_alloc_intr_vec_error:
        return ret;
 }
 
+static int
+hns3vf_restore_rx_interrupt(struct hns3_hw *hw)
+{
+       struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
+       struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+       struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
+       uint16_t q_id;
+       int ret;
+
+       if (dev->data->dev_conf.intr_conf.rxq == 0)
+               return 0;
+
+       if (rte_intr_dp_is_en(intr_handle)) {
+               for (q_id = 0; q_id < hw->used_rx_queues; q_id++) {
+                       ret = hns3vf_bind_ring_with_vector(hw,
+                                       intr_handle->intr_vec[q_id], true,
+                                       HNS3_RING_TYPE_RX, q_id);
+                       if (ret)
+                               return ret;
+               }
+       }
+
+       return 0;
+}
+
 static void
 hns3vf_restore_filter(struct rte_eth_dev *dev)
 {
@@ -1771,18 +2044,29 @@ hns3vf_dev_start(struct rte_eth_dev *dev)
                rte_spinlock_unlock(&hw->lock);
                return ret;
        }
+       ret = hns3vf_map_rx_interrupt(dev);
+       if (ret) {
+               hw->adapter_state = HNS3_NIC_CONFIGURED;
+               rte_spinlock_unlock(&hw->lock);
+               return ret;
+       }
        hw->adapter_state = HNS3_NIC_STARTED;
        rte_spinlock_unlock(&hw->lock);
 
-       ret = hns3vf_map_rx_interrupt(dev);
-       if (ret)
-               return ret;
        hns3_set_rxtx_function(dev);
        hns3_mp_req_start_rxtx(dev);
        rte_eal_alarm_set(HNS3VF_SERVICE_INTERVAL, hns3vf_service_handler, dev);
 
        hns3vf_restore_filter(dev);
 
+       /* Enable interrupt of all rx queues before enabling queues */
+       hns3_dev_all_rx_queue_intr_enable(hw, true);
+       /*
+        * When finished the initialization, enable queues to receive/transmit
+        * packets.
+        */
+       hns3_enable_all_queues(hw, true);
+
        return ret;
 }
 
@@ -1934,9 +2218,18 @@ hns3vf_start_service(struct hns3_adapter *hns)
        eth_dev = &rte_eth_devices[hw->data->port_id];
        hns3_set_rxtx_function(eth_dev);
        hns3_mp_req_start_rxtx(eth_dev);
-       if (hw->adapter_state == HNS3_NIC_STARTED)
+       if (hw->adapter_state == HNS3_NIC_STARTED) {
                hns3vf_service_handler(eth_dev);
 
+               /* Enable interrupt of all rx queues before enabling queues */
+               hns3_dev_all_rx_queue_intr_enable(hw, true);
+               /*
+                * When finished the initialization, enable queues to receive
+                * and transmit packets.
+                */
+               hns3_enable_all_queues(hw, true);
+       }
+
        return 0;
 }
 
@@ -2007,6 +2300,18 @@ hns3vf_restore_conf(struct hns3_adapter *hns)
        if (ret)
                goto err_vlan_table;
 
+       ret = hns3vf_get_port_base_vlan_filter_state(hw);
+       if (ret)
+               goto err_vlan_table;
+
+       ret = hns3vf_restore_rx_interrupt(hw);
+       if (ret)
+               goto err_vlan_table;
+
+       ret = hns3_restore_gro_conf(hw);
+       if (ret)
+               goto err_vlan_table;
+
        if (hw->adapter_state == HNS3_NIC_STARTED) {
                ret = hns3vf_do_start(hns, false);
                if (ret)
@@ -2161,6 +2466,7 @@ static const struct eth_dev_ops hns3vf_eth_dev_ops = {
        .xstats_get_by_id   = hns3_dev_xstats_get_by_id,
        .xstats_get_names_by_id = hns3_dev_xstats_get_names_by_id,
        .dev_infos_get      = hns3vf_dev_infos_get,
+       .fw_version_get     = hns3vf_fw_version_get,
        .rx_queue_setup     = hns3_rx_queue_setup,
        .tx_queue_setup     = hns3_tx_queue_setup,
        .rx_queue_release   = hns3_dev_rx_queue_release,
@@ -2218,12 +2524,24 @@ hns3vf_dev_init(struct rte_eth_dev *eth_dev)
        hns3_set_rxtx_function(eth_dev);
        eth_dev->dev_ops = &hns3vf_eth_dev_ops;
        if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
-               hns3_mp_init_secondary();
+               ret = hns3_mp_init_secondary();
+               if (ret) {
+                       PMD_INIT_LOG(ERR, "Failed to init for secondary "
+                                         "process, ret = %d", ret);
+                       goto err_mp_init_secondary;
+               }
+
                hw->secondary_cnt++;
                return 0;
        }
 
-       hns3_mp_init_primary();
+       ret = hns3_mp_init_primary();
+       if (ret) {
+               PMD_INIT_LOG(ERR,
+                            "Failed to init for primary process, ret = %d",
+                            ret);
+               goto err_mp_init_primary;
+       }
 
        hw->adapter_state = HNS3_NIC_UNINITIALIZED;
        hns->is_vf = true;
@@ -2280,6 +2598,10 @@ err_init_vf:
        rte_free(hw->reset.wait_data);
 
 err_init_reset:
+       hns3_mp_uninit_primary();
+
+err_mp_init_primary:
+err_mp_init_secondary:
        eth_dev->dev_ops = NULL;
        eth_dev->rx_pkt_burst = NULL;
        eth_dev->tx_pkt_burst = NULL;