net/hns3: remove unused VMDq code
[dpdk.git] / drivers / net / hns3 / hns3_ethdev_vf.c
index 5f8a460..6aa8a9b 100644 (file)
@@ -44,6 +44,9 @@ static int hns3vf_add_mc_mac_addr(struct hns3_hw *hw,
                                  struct rte_ether_addr *mac_addr);
 static int hns3vf_remove_mc_mac_addr(struct hns3_hw *hw,
                                     struct rte_ether_addr *mac_addr);
+static int hns3vf_dev_link_update(struct rte_eth_dev *eth_dev,
+                                  __rte_unused int wait_to_complete);
+
 /* set PCI bus mastering */
 static int
 hns3vf_set_bus_master(const struct rte_pci_device *device, bool op)
@@ -854,11 +857,6 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)
        if (ret)
                goto cfg_err;
 
-       hns->rx_simple_allowed = true;
-       hns->rx_vec_allowed = true;
-       hns->tx_simple_allowed = true;
-       hns->tx_vec_allowed = true;
-
        hns3_init_rx_ptype_tble(dev);
 
        hw->adapter_state = HNS3_NIC_CONFIGURED;
@@ -1024,11 +1022,14 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
                .offloads = 0,
        };
 
-       info->vmdq_queue_num = 0;
-
        info->reta_size = hw->rss_ind_tbl_size;
        info->hash_key_size = HNS3_RSS_KEY_SIZE;
        info->flow_type_rss_offloads = HNS3_ETH_RSS_SUPPORT;
+
+       info->default_rxportconf.burst_size = HNS3_DEFAULT_PORT_CONF_BURST_SIZE;
+       info->default_txportconf.burst_size = HNS3_DEFAULT_PORT_CONF_BURST_SIZE;
+       info->default_rxportconf.nb_queues = HNS3_DEFAULT_PORT_CONF_QUEUES_NUM;
+       info->default_txportconf.nb_queues = HNS3_DEFAULT_PORT_CONF_QUEUES_NUM;
        info->default_rxportconf.ring_size = HNS3_DEFAULT_RING_DESC;
        info->default_txportconf.ring_size = HNS3_DEFAULT_RING_DESC;
 
@@ -1191,6 +1192,65 @@ hns3vf_query_dev_specifications(struct hns3_hw *hw)
        return hns3vf_check_dev_specifications(hw);
 }
 
+void
+hns3vf_update_push_lsc_cap(struct hns3_hw *hw, bool supported)
+{
+       uint16_t val = supported ? HNS3_PF_PUSH_LSC_CAP_SUPPORTED :
+                                  HNS3_PF_PUSH_LSC_CAP_NOT_SUPPORTED;
+       uint16_t exp = HNS3_PF_PUSH_LSC_CAP_UNKNOWN;
+       struct hns3_vf *vf = HNS3_DEV_HW_TO_VF(hw);
+
+       if (vf->pf_push_lsc_cap == HNS3_PF_PUSH_LSC_CAP_UNKNOWN)
+               __atomic_compare_exchange(&vf->pf_push_lsc_cap, &exp, &val, 0,
+                                         __ATOMIC_ACQUIRE, __ATOMIC_ACQUIRE);
+}
+
+static void
+hns3vf_get_push_lsc_cap(struct hns3_hw *hw)
+{
+#define HNS3_CHECK_PUSH_LSC_CAP_TIMEOUT_MS     500
+
+       struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
+       int32_t remain_ms = HNS3_CHECK_PUSH_LSC_CAP_TIMEOUT_MS;
+       uint16_t val = HNS3_PF_PUSH_LSC_CAP_NOT_SUPPORTED;
+       uint16_t exp = HNS3_PF_PUSH_LSC_CAP_UNKNOWN;
+       struct hns3_vf *vf = HNS3_DEV_HW_TO_VF(hw);
+
+       __atomic_store_n(&vf->pf_push_lsc_cap, HNS3_PF_PUSH_LSC_CAP_UNKNOWN,
+                        __ATOMIC_RELEASE);
+
+       (void)hns3_send_mbx_msg(hw, HNS3_MBX_GET_LINK_STATUS, 0, NULL, 0, false,
+                               NULL, 0);
+
+       while (remain_ms > 0) {
+               rte_delay_ms(HNS3_POLL_RESPONE_MS);
+               if (__atomic_load_n(&vf->pf_push_lsc_cap, __ATOMIC_ACQUIRE) !=
+                       HNS3_PF_PUSH_LSC_CAP_UNKNOWN)
+                       break;
+               remain_ms--;
+       }
+
+       /*
+        * When exit above loop, the pf_push_lsc_cap could be one of the three
+        * state: unknown (means pf not ack), not_supported, supported.
+        * Here config it as 'not_supported' when it's 'unknown' state.
+        */
+       __atomic_compare_exchange(&vf->pf_push_lsc_cap, &exp, &val, 0,
+                                 __ATOMIC_ACQUIRE, __ATOMIC_ACQUIRE);
+
+       if (__atomic_load_n(&vf->pf_push_lsc_cap, __ATOMIC_ACQUIRE) ==
+               HNS3_PF_PUSH_LSC_CAP_SUPPORTED) {
+               hns3_info(hw, "detect PF support push link status change!");
+       } else {
+               /*
+                * Framework already set RTE_ETH_DEV_INTR_LSC bit because driver
+                * declared RTE_PCI_DRV_INTR_LSC in drv_flags. So here cleared
+                * the RTE_ETH_DEV_INTR_LSC capability.
+                */
+               dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC;
+       }
+}
+
 static int
 hns3vf_get_capability(struct hns3_hw *hw)
 {
@@ -1404,6 +1464,8 @@ hns3vf_get_configuration(struct hns3_hw *hw)
                return ret;
        }
 
+       hns3vf_get_push_lsc_cap(hw);
+
        /* Get queue configuration from PF */
        ret = hns3vf_get_queue_info(hw);
        if (ret)
@@ -1451,15 +1513,27 @@ hns3vf_set_tc_queue_mapping(struct hns3_adapter *hns, uint16_t nb_rx_q,
 static void
 hns3vf_request_link_info(struct hns3_hw *hw)
 {
-       uint8_t resp_msg;
+       struct hns3_vf *vf = HNS3_DEV_HW_TO_VF(hw);
+       bool send_req;
        int ret;
 
        if (__atomic_load_n(&hw->reset.resetting, __ATOMIC_RELAXED))
                return;
+
+       send_req = vf->pf_push_lsc_cap == HNS3_PF_PUSH_LSC_CAP_NOT_SUPPORTED ||
+                  vf->req_link_info_cnt > 0;
+       if (!send_req)
+               return;
+
        ret = hns3_send_mbx_msg(hw, HNS3_MBX_GET_LINK_STATUS, 0, NULL, 0, false,
-                               &resp_msg, sizeof(resp_msg));
-       if (ret)
-               hns3_err(hw, "Failed to fetch link status from PF: %d", ret);
+                               NULL, 0);
+       if (ret) {
+               hns3_err(hw, "failed to fetch link status, ret = %d", ret);
+               return;
+       }
+
+       if (vf->req_link_info_cnt > 0)
+               vf->req_link_info_cnt--;
 }
 
 void
@@ -1467,34 +1541,30 @@ hns3vf_update_link_status(struct hns3_hw *hw, uint8_t link_status,
                          uint32_t link_speed, uint8_t link_duplex)
 {
        struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
+       struct hns3_vf *vf = HNS3_DEV_HW_TO_VF(hw);
        struct hns3_mac *mac = &hw->mac;
-       bool report_lse;
-       bool changed;
-
-       changed = mac->link_status != link_status ||
-                 mac->link_speed != link_speed ||
-                 mac->link_duplex != link_duplex;
-       if (!changed)
-               return;
+       int ret;
 
        /*
-        * VF's link status/speed/duplex were updated by polling from PF driver,
-        * because the link status/speed/duplex may be changed in the polling
-        * interval, so driver will report lse (lsc event) once any of the above
-        * thress variables changed.
-        * But if the PF's link status is down and driver saved link status is
-        * also down, there are no need to report lse.
+        * PF kernel driver may push link status when VF driver is in resetting,
+        * driver will stop polling job in this case, after resetting done
+        * driver will start polling job again.
+        * When polling job started, driver will get initial link status by
+        * sending request to PF kernel driver, then could update link status by
+        * process PF kernel driver's link status mailbox message.
         */
-       report_lse = true;
-       if (link_status == ETH_LINK_DOWN && link_status == mac->link_status)
-               report_lse = false;
+       if (!__atomic_load_n(&vf->poll_job_started, __ATOMIC_RELAXED))
+               return;
+
+       if (hw->adapter_state != HNS3_NIC_STARTED)
+               return;
 
        mac->link_status = link_status;
        mac->link_speed = link_speed;
        mac->link_duplex = link_duplex;
-
-       if (report_lse)
-               rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL);
+       ret = hns3vf_dev_link_update(dev, 0);
+       if (ret == 0 && dev->data->dev_conf.intr_conf.lsc != 0)
+               hns3_start_report_lse(dev);
 }
 
 static int
@@ -1688,11 +1758,10 @@ hns3vf_keep_alive_handler(void *param)
        struct rte_eth_dev *eth_dev = (struct rte_eth_dev *)param;
        struct hns3_adapter *hns = eth_dev->data->dev_private;
        struct hns3_hw *hw = &hns->hw;
-       uint8_t respmsg;
        int ret;
 
        ret = hns3_send_mbx_msg(hw, HNS3_MBX_KEEP_ALIVE, 0, NULL, 0,
-                               false, &respmsg, sizeof(uint8_t));
+                               false, NULL, 0);
        if (ret)
                hns3_err(hw, "VF sends keeping alive cmd failed(=%d)",
                         ret);
@@ -1710,8 +1779,8 @@ hns3vf_service_handler(void *param)
 
        /*
         * The query link status and reset processing are executed in the
-        * interrupt thread.When the IMP reset occurs, IMP will not respond,
-        * and the query operation will time out after 30ms. In the case of
+        * interrupt thread. When the IMP reset occurs, IMP will not respond,
+        * and the query operation will timeout after 30ms. In the case of
         * multiple PF/VFs, each query failure timeout causes the IMP reset
         * interrupt to fail to respond within 100ms.
         * Before querying the link status, check whether there is a reset
@@ -1726,6 +1795,31 @@ hns3vf_service_handler(void *param)
                          eth_dev);
 }
 
+static void
+hns3vf_start_poll_job(struct rte_eth_dev *dev)
+{
+#define HNS3_REQUEST_LINK_INFO_REMAINS_CNT     3
+
+       struct hns3_vf *vf = HNS3_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+
+       if (vf->pf_push_lsc_cap == HNS3_PF_PUSH_LSC_CAP_SUPPORTED)
+               vf->req_link_info_cnt = HNS3_REQUEST_LINK_INFO_REMAINS_CNT;
+
+       __atomic_store_n(&vf->poll_job_started, 1, __ATOMIC_RELAXED);
+
+       hns3vf_service_handler(dev);
+}
+
+static void
+hns3vf_stop_poll_job(struct rte_eth_dev *dev)
+{
+       struct hns3_vf *vf = HNS3_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+
+       rte_eal_alarm_cancel(hns3vf_service_handler, dev);
+
+       __atomic_store_n(&vf->poll_job_started, 0, __ATOMIC_RELAXED);
+}
+
 static int
 hns3_query_vf_resource(struct hns3_hw *hw)
 {
@@ -2032,7 +2126,8 @@ hns3vf_dev_stop(struct rte_eth_dev *dev)
                hw->adapter_state = HNS3_NIC_CONFIGURED;
        }
        hns3_rx_scattered_reset(dev);
-       rte_eal_alarm_cancel(hns3vf_service_handler, dev);
+       hns3vf_stop_poll_job(dev);
+       hns3_stop_report_lse(dev);
        rte_spinlock_unlock(&hw->lock);
 
        return 0;
@@ -2089,8 +2184,11 @@ hns3vf_fw_version_get(struct rte_eth_dev *eth_dev, char *fw_version,
                                      HNS3_FW_VERSION_BYTE1_S),
                       hns3_get_field(version, HNS3_FW_VERSION_BYTE0_M,
                                      HNS3_FW_VERSION_BYTE0_S));
+       if (ret < 0)
+               return -EINVAL;
+
        ret += 1; /* add the size of '\0' */
-       if (fw_size < (uint32_t)ret)
+       if (fw_size < (size_t)ret)
                return ret;
        else
                return 0;
@@ -2302,19 +2400,17 @@ hns3vf_dev_start(struct rte_eth_dev *dev)
        hns3_rx_scattered_calc(dev);
        hns3_set_rxtx_function(dev);
        hns3_mp_req_start_rxtx(dev);
-       hns3vf_service_handler(dev);
 
        hns3vf_restore_filter(dev);
 
        /* Enable interrupt of all rx queues before enabling queues */
        hns3_dev_all_rx_queue_intr_enable(hw, true);
-
-       /*
-        * After finished the initialization, start all tqps to receive/transmit
-        * packets and refresh all queue status.
-        */
        hns3_start_tqps(hw);
 
+       if (dev->data->dev_conf.intr_conf.lsc != 0)
+               hns3vf_dev_link_update(dev, 0);
+       hns3vf_start_poll_job(dev);
+
        return ret;
 
 start_all_rxqs_fail:
@@ -2373,7 +2469,8 @@ hns3vf_is_reset_pending(struct hns3_adapter *hns)
        /* Check the registers to confirm whether there is reset pending */
        hns3vf_check_event_cause(hns, NULL);
        reset = hns3vf_get_reset_level(hw, &hw->reset.pending);
-       if (hw->reset.level != HNS3_NONE_RESET && hw->reset.level < reset) {
+       if (hw->reset.level != HNS3_NONE_RESET && reset != HNS3_NONE_RESET &&
+           hw->reset.level < reset) {
                hns3_warn(hw, "High level reset %d is pending", reset);
                return true;
        }
@@ -2411,7 +2508,7 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns)
                hns3_warn(hw, "hardware is ready, delay 1 sec for PF reset complete");
                return -EAGAIN;
        } else if (wait_data->result == HNS3_WAIT_TIMEOUT) {
-               gettimeofday(&tv, NULL);
+               hns3_clock_gettime(&tv);
                hns3_warn(hw, "Reset step4 hardware not ready after reset time=%ld.%.6ld",
                          tv.tv_sec, tv.tv_usec);
                return -ETIME;
@@ -2421,7 +2518,7 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns)
        wait_data->hns = hns;
        wait_data->check_completion = is_vf_reset_done;
        wait_data->end_ms = (uint64_t)HNS3VF_RESET_WAIT_CNT *
-                                     HNS3VF_RESET_WAIT_MS + get_timeofday_ms();
+                               HNS3VF_RESET_WAIT_MS + hns3_clock_gettime_ms();
        wait_data->interval = HNS3VF_RESET_WAIT_MS * USEC_PER_MSEC;
        wait_data->count = HNS3VF_RESET_WAIT_CNT;
        wait_data->result = HNS3_WAIT_REQUEST;
@@ -2454,9 +2551,13 @@ hns3vf_stop_service(struct hns3_adapter *hns)
 
        eth_dev = &rte_eth_devices[hw->data->port_id];
        if (hw->adapter_state == HNS3_NIC_STARTED) {
-               rte_eal_alarm_cancel(hns3vf_service_handler, eth_dev);
+               /*
+                * Make sure call update link status before hns3vf_stop_poll_job
+                * because update link status depend on polling job exist.
+                */
                hns3vf_update_link_status(hw, ETH_LINK_DOWN, hw->mac.link_speed,
-                       hw->mac.link_duplex);
+                                         hw->mac.link_duplex);
+               hns3vf_stop_poll_job(eth_dev);
        }
        hw->mac.link_status = ETH_LINK_DOWN;
 
@@ -2497,7 +2598,7 @@ hns3vf_start_service(struct hns3_adapter *hns)
        hns3_set_rxtx_function(eth_dev);
        hns3_mp_req_start_rxtx(eth_dev);
        if (hw->adapter_state == HNS3_NIC_STARTED) {
-               hns3vf_service_handler(eth_dev);
+               hns3vf_start_poll_job(eth_dev);
 
                /* Enable interrupt of all rx queues before enabling queues */
                hns3_dev_all_rx_queue_intr_enable(hw, true);
@@ -2672,14 +2773,13 @@ hns3vf_reset_service(void *param)
         */
        reset_level = hns3vf_get_reset_level(hw, &hw->reset.pending);
        if (reset_level != HNS3_NONE_RESET) {
-               gettimeofday(&tv_start, NULL);
+               hns3_clock_gettime(&tv_start);
                hns3_reset_process(hns, reset_level);
-               gettimeofday(&tv, NULL);
+               hns3_clock_gettime(&tv);
                timersub(&tv, &tv_start, &tv_delta);
-               msec = tv_delta.tv_sec * MSEC_PER_SEC +
-                      tv_delta.tv_usec / USEC_PER_MSEC;
+               msec = hns3_clock_calctime_ms(&tv_delta);
                if (msec > HNS3_RESET_PROCESS_MS)
-                       hns3_err(hw, "%d handle long time delta %" PRIx64
+                       hns3_err(hw, "%d handle long time delta %" PRIu64
                                 " ms time=%ld.%.6ld",
                                 hw->reset.level, msec, tv.tv_sec, tv.tv_usec);
        }
@@ -2816,8 +2916,7 @@ hns3vf_dev_init(struct rte_eth_dev *eth_dev)
                return -ENOMEM;
        }
 
-       /* initialize flow filter lists */
-       hns3_filterlist_init(eth_dev);
+       hns3_flow_init(eth_dev);
 
        hns3_set_rxtx_function(eth_dev);
        eth_dev->dev_ops = &hns3vf_eth_dev_ops;
@@ -2968,7 +3067,7 @@ static const struct rte_pci_id pci_id_hns3vf_map[] = {
 
 static struct rte_pci_driver rte_hns3vf_pmd = {
        .id_table = pci_id_hns3vf_map,
-       .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
+       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
        .probe = eth_hns3vf_pci_probe,
        .remove = eth_hns3vf_pci_remove,
 };
@@ -2978,4 +3077,5 @@ RTE_PMD_REGISTER_PCI_TABLE(net_hns3_vf, pci_id_hns3vf_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_hns3_vf, "* igb_uio | vfio-pci");
 RTE_PMD_REGISTER_PARAM_STRING(net_hns3_vf,
                HNS3_DEVARG_RX_FUNC_HINT "=vec|sve|simple|common "
-               HNS3_DEVARG_TX_FUNC_HINT "=vec|sve|simple|common ");
+               HNS3_DEVARG_TX_FUNC_HINT "=vec|sve|simple|common "
+               HNS3_DEVARG_DEV_CAPS_MASK "=<1-65535> ");