#include <ethdev_driver.h>
#include <rte_io.h>
-#include "hns3_ethdev.h"
+#include "hns3_common.h"
#include "hns3_regs.h"
#include "hns3_logs.h"
#include "hns3_intr.h"
hns3_get_mbx_resp(struct hns3_hw *hw, uint16_t code, uint16_t subcode,
uint8_t *resp_data, uint16_t resp_len)
{
-#define HNS3_MAX_RETRY_MS 500
#define HNS3_WAIT_RESP_US 100
+#define US_PER_MS 1000
+ uint32_t mbx_time_limit;
struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
struct hns3_mbx_resp_status *mbx_resp;
+ uint32_t wait_time = 0;
bool received;
- uint64_t now;
- uint64_t end;
if (resp_len > HNS3_MBX_MAX_RESP_DATA_SIZE) {
hns3_err(hw, "VF mbx response len(=%u) exceeds maximum(=%d)",
return -EINVAL;
}
- now = get_timeofday_ms();
- end = now + HNS3_MAX_RETRY_MS;
- while (now < end) {
+ mbx_time_limit = (uint32_t)hns->mbx_time_limit_ms * US_PER_MS;
+ while (wait_time < mbx_time_limit) {
if (__atomic_load_n(&hw->reset.disable_cmd, __ATOMIC_RELAXED)) {
- hns3_err(hw, "Don't wait for mbx respone because of "
+ hns3_err(hw, "Don't wait for mbx response because of "
"disable_cmd");
return -EBUSY;
}
if (is_reset_pending(hns)) {
hw->mbx_resp.req_msg_data = 0;
- hns3_err(hw, "Don't wait for mbx respone because of "
+ hns3_err(hw, "Don't wait for mbx response because of "
"reset pending");
return -EIO;
}
if (received)
break;
- now = get_timeofday_ms();
+ wait_time += HNS3_WAIT_RESP_US;
}
hw->mbx_resp.req_msg_data = 0;
- if (now >= end) {
+ if (wait_time >= mbx_time_limit) {
hns3_mbx_proc_timeout(hw, code, subcode);
return -ETIME;
}
static void
hns3pf_handle_link_change_event(struct hns3_hw *hw,
- struct hns3_mbx_pf_to_vf_cmd *req)
+ struct hns3_mbx_vf_to_pf_cmd *req)
{
#define LINK_STATUS_OFFSET 1
#define LINK_FAIL_CODE_OFFSET 2
}
}
+static void
+hns3_handle_mbx_msg_out_intr(struct hns3_hw *hw)
+{
+ struct hns3_cmq_ring *crq = &hw->cmq.crq;
+ struct hns3_mbx_pf_to_vf_cmd *req;
+ struct hns3_cmd_desc *desc;
+ uint32_t tail, next_to_use;
+ uint8_t opcode;
+ uint16_t flag;
+
+ tail = hns3_read_dev(hw, HNS3_CMDQ_RX_TAIL_REG);
+ next_to_use = crq->next_to_use;
+ while (next_to_use != tail) {
+ desc = &crq->desc[next_to_use];
+ req = (struct hns3_mbx_pf_to_vf_cmd *)desc->data;
+ opcode = req->msg[0] & 0xff;
+
+ flag = rte_le_to_cpu_16(crq->desc[next_to_use].flag);
+ if (!hns3_get_bit(flag, HNS3_CMDQ_RX_OUTVLD_B))
+ goto scan_next;
+
+ if (crq->desc[next_to_use].opcode == 0)
+ goto scan_next;
+
+ if (opcode == HNS3_MBX_PF_VF_RESP) {
+ hns3_handle_mbx_response(hw, req);
+ /*
+ * Clear opcode to inform intr thread don't process
+ * again.
+ */
+ crq->desc[crq->next_to_use].opcode = 0;
+ }
+
+scan_next:
+ next_to_use = (next_to_use + 1) % hw->cmq.crq.desc_num;
+ }
+
+ crq->next_to_use = next_to_use;
+ hns3_write_dev(hw, HNS3_CMDQ_RX_HEAD_REG, crq->next_to_use);
+}
+
void
hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
{
+ struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
struct hns3_cmq_ring *crq = &hw->cmq.crq;
struct hns3_mbx_pf_to_vf_cmd *req;
struct hns3_cmd_desc *desc;
+ bool handle_out;
uint8_t opcode;
uint16_t flag;
rte_spinlock_lock(&hw->cmq.crq.lock);
+ handle_out = (rte_eal_process_type() != RTE_PROC_PRIMARY ||
+ !rte_thread_is_intr()) && hns->is_vf;
+ if (handle_out) {
+ /*
+ * Currently, any threads in the primary and secondary processes
+ * could send mailbox sync request, so it will need to process
+ * the crq message (which is the HNS3_MBX_PF_VF_RESP) in there
+ * own thread context. It may also process other messages
+ * because it uses the policy of processing all pending messages
+ * at once.
+ * But some messages such as HNS3_MBX_PUSH_LINK_STATUS could
+ * only process within the intr thread in primary process,
+ * otherwise it may lead to report lsc event in secondary
+ * process.
+ * So the threads other than intr thread in primary process
+ * could only process HNS3_MBX_PF_VF_RESP message, if the
+ * message processed, its opcode will rewrite with zero, then
+ * the intr thread in primary process will not process again.
+ */
+ hns3_handle_mbx_msg_out_intr(hw);
+ rte_spinlock_unlock(&hw->cmq.crq.lock);
+ return;
+ }
+
while (!hns3_cmd_crq_empty(hw)) {
if (__atomic_load_n(&hw->reset.disable_cmd, __ATOMIC_RELAXED)) {
rte_spinlock_unlock(&hw->cmq.crq.lock);
continue;
}
+ handle_out = hns->is_vf && desc->opcode == 0;
+ if (handle_out) {
+ /* Message already processed by other thread */
+ crq->desc[crq->next_to_use].flag = 0;
+ hns3_mbx_ring_ptr_move_crq(crq);
+ continue;
+ }
+
switch (opcode) {
case HNS3_MBX_PF_VF_RESP:
hns3_handle_mbx_response(hw, req);
hns3_handle_asserting_reset(hw, req);
break;
case HNS3_MBX_PUSH_LINK_STATUS:
- hns3pf_handle_link_change_event(hw, req);
+ /*
+ * This message is reported by the firmware and is
+ * reported in 'struct hns3_mbx_vf_to_pf_cmd' format.
+ * Therefore, we should cast the req variable to
+ * 'struct hns3_mbx_vf_to_pf_cmd' and then process it.
+ */
+ hns3pf_handle_link_change_event(hw,
+ (struct hns3_mbx_vf_to_pf_cmd *)req);
break;
case HNS3_MBX_PUSH_VLAN_INFO:
/*
hns3_handle_promisc_info(hw, req->msg[1]);
break;
default:
- hns3_err(hw,
- "VF received unsupported(%u) mbx msg from PF",
- req->msg[0]);
+ hns3_err(hw, "received unsupported(%u) mbx msg",
+ opcode);
break;
}