net/ice: refactor input set config
[dpdk.git] / drivers / net / hns3 / hns3_mbx.c
index 34c8c68..61d1584 100644 (file)
@@ -2,27 +2,14 @@
  * Copyright(c) 2018-2019 Hisilicon Limited.
  */
 
-#include <errno.h>
-#include <stdbool.h>
-#include <stdint.h>
-#include <stdio.h>
-#include <string.h>
-#include <inttypes.h>
-#include <unistd.h>
-#include <rte_byteorder.h>
-#include <rte_common.h>
-#include <rte_cycles.h>
-#include <rte_dev.h>
-#include <rte_ethdev_driver.h>
+#include <ethdev_driver.h>
 #include <rte_io.h>
-#include <rte_spinlock.h>
-#include <rte_pci.h>
-#include <rte_bus_pci.h>
 
 #include "hns3_ethdev.h"
 #include "hns3_regs.h"
 #include "hns3_logs.h"
 #include "hns3_intr.h"
+#include "hns3_rxtx.h"
 
 #define HNS3_CMD_CODE_OFFSET           2
 
@@ -87,7 +74,7 @@ hns3_get_mbx_resp(struct hns3_hw *hw, uint16_t code0, uint16_t code1,
        uint64_t end;
 
        if (resp_len > HNS3_MBX_MAX_RESP_DATA_SIZE) {
-               hns3_err(hw, "VF mbx response len(=%d) exceeds maximum(=%d)",
+               hns3_err(hw, "VF mbx response len(=%u) exceeds maximum(=%d)",
                         resp_len, HNS3_MBX_MAX_RESP_DATA_SIZE);
                return -EINVAL;
        }
@@ -96,7 +83,7 @@ hns3_get_mbx_resp(struct hns3_hw *hw, uint16_t code0, uint16_t code1,
        end = now + HNS3_MAX_RETRY_MS;
        while ((hw->mbx_resp.head != hw->mbx_resp.tail + hw->mbx_resp.lost) &&
               (now < end)) {
-               if (rte_atomic16_read(&hw->reset.disable_cmd)) {
+               if (__atomic_load_n(&hw->reset.disable_cmd, __ATOMIC_RELAXED)) {
                        hns3_err(hw, "Don't wait for mbx respone because of "
                                 "disable_cmd");
                        return -EBUSY;
@@ -126,7 +113,7 @@ hns3_get_mbx_resp(struct hns3_hw *hw, uint16_t code0, uint16_t code1,
        if (now >= end) {
                hw->mbx_resp.lost++;
                hns3_err(hw,
-                        "VF could not get mbx(%d,%d) head(%d) tail(%d) lost(%d) from PF in_irq:%d",
+                        "VF could not get mbx(%u,%u) head(%u) tail(%u) lost(%u) from PF in_irq:%d",
                         code0, code1, hw->mbx_resp.head, hw->mbx_resp.tail,
                         hw->mbx_resp.lost, in_irq);
                return -ETIME;
@@ -159,7 +146,7 @@ hns3_send_mbx_msg(struct hns3_hw *hw, uint16_t code, uint16_t subcode,
        /* first two bytes are reserved for code & subcode */
        if (msg_len > (HNS3_MBX_MAX_MSG_SIZE - HNS3_CMD_CODE_OFFSET)) {
                hns3_err(hw,
-                        "VF send mbx msg fail, msg len %d exceeds max payload len %d",
+                        "VF send mbx msg fail, msg len %u exceeds max payload len %d",
                         msg_len, HNS3_MBX_MAX_MSG_SIZE - HNS3_CMD_CODE_OFFSET);
                return -EINVAL;
        }
@@ -216,8 +203,9 @@ hns3_cmd_crq_empty(struct hns3_hw *hw)
 static void
 hns3_mbx_handler(struct hns3_hw *hw)
 {
-       struct hns3_mac *mac = &hw->mac;
        enum hns3_reset_level reset_level;
+       uint8_t link_status, link_duplex;
+       uint32_t link_speed;
        uint16_t *msg_q;
        uint8_t opcode;
        uint32_t tail;
@@ -231,10 +219,11 @@ hns3_mbx_handler(struct hns3_hw *hw)
                opcode = msg_q[0] & 0xff;
                switch (opcode) {
                case HNS3_MBX_LINK_STAT_CHANGE:
-                       memcpy(&mac->link_speed, &msg_q[2],
-                                  sizeof(mac->link_speed));
-                       mac->link_status = rte_le_to_cpu_16(msg_q[1]);
-                       mac->link_duplex = (uint8_t)rte_le_to_cpu_16(msg_q[4]);
+                       memcpy(&link_speed, &msg_q[2], sizeof(link_speed));
+                       link_status = rte_le_to_cpu_16(msg_q[1]);
+                       link_duplex = (uint8_t)rte_le_to_cpu_16(msg_q[4]);
+                       hns3vf_update_link_status(hw, link_status, link_speed,
+                                                 link_duplex);
                        break;
                case HNS3_MBX_ASSERTING_RESET:
                        /* PF has asserted reset hence VF should go in pending
@@ -250,7 +239,7 @@ hns3_mbx_handler(struct hns3_hw *hw)
                        hns3_schedule_reset(HNS3_DEV_HW_TO_ADAPTER(hw));
                        break;
                default:
-                       hns3_err(hw, "Fetched unsupported(%d) message from arq",
+                       hns3_err(hw, "Fetched unsupported(%u) message from arq",
                                 opcode);
                        break;
                }
@@ -279,13 +268,13 @@ hns3_update_resp_position(struct hns3_hw *hw, uint32_t resp_msg)
                if (resp->lost)
                        resp->lost--;
                hns3_warn(hw, "Received a mismatched response req_msg(%x) "
-                         "resp_msg(%x) head(%d) tail(%d) lost(%d)",
+                         "resp_msg(%x) head(%u) tail(%u) lost(%u)",
                          resp->req_msg_data, resp_msg, resp->head, tail,
                          resp->lost);
        } else if (tail + resp->lost > resp->head) {
                resp->lost--;
                hns3_warn(hw, "Received a new response again resp_msg(%x) "
-                         "head(%d) tail(%d) lost(%d)", resp_msg,
+                         "head(%u) tail(%u) lost(%u)", resp_msg,
                          resp->head, tail, resp->lost);
        }
        rte_io_wmb();
@@ -323,7 +312,31 @@ hns3_handle_link_change_event(struct hns3_hw *hw,
        if (!req->msg[LINK_STATUS_OFFSET])
                hns3_link_fail_parse(hw, req->msg[LINK_FAIL_CODE_OFFSET]);
 
-       hns3_update_link_status(hw);
+       hns3_update_link_status_and_event(hw);
+}
+
+static void
+hns3_update_port_base_vlan_info(struct hns3_hw *hw,
+                               struct hns3_mbx_pf_to_vf_cmd *req)
+{
+#define PVID_STATE_OFFSET      1
+       uint16_t new_pvid_state = req->msg[PVID_STATE_OFFSET] ?
+               HNS3_PORT_BASE_VLAN_ENABLE : HNS3_PORT_BASE_VLAN_DISABLE;
+       /*
+        * Currently, hardware doesn't support more than two layers VLAN offload
+        * based on hns3 network engine, which would cause packets loss or wrong
+        * packets for these types of packets. If the hns3 PF kernel ethdev
+        * driver sets the PVID for VF device after initialization of the
+        * related VF device, the PF driver will notify VF driver to update the
+        * PVID configuration state. The VF driver will update the PVID
+        * configuration state immediately to ensure that the VLAN process in Tx
+        * and Rx is correct. But in the window period of this state transition,
+        * packets loss or packets with wrong VLAN may occur.
+        */
+       if (hw->port_base_vlan_cfg.state != new_pvid_state) {
+               hw->port_base_vlan_cfg.state = new_pvid_state;
+               hns3_update_all_queues_pvid_proc_en(hw);
+       }
 }
 
 static void
@@ -356,7 +369,7 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
        int i;
 
        while (!hns3_cmd_crq_empty(hw)) {
-               if (rte_atomic16_read(&hw->reset.disable_cmd))
+               if (__atomic_load_n(&hw->reset.disable_cmd, __ATOMIC_RELAXED))
                        return;
 
                desc = &crq->desc[crq->next_to_use];
@@ -366,7 +379,7 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
                flag = rte_le_to_cpu_16(crq->desc[crq->next_to_use].flag);
                if (unlikely(!hns3_get_bit(flag, HNS3_CMDQ_RX_OUTVLD_B))) {
                        hns3_warn(hw,
-                                 "dropped invalid mailbox message, code = %d",
+                                 "dropped invalid mailbox message, code = %u",
                                  opcode);
 
                        /* dropping/not processing this invalid message */
@@ -399,6 +412,14 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
                case HNS3_MBX_PUSH_LINK_STATUS:
                        hns3_handle_link_change_event(hw, req);
                        break;
+               case HNS3_MBX_PUSH_VLAN_INFO:
+                       /*
+                        * When the PVID configuration status of VF device is
+                        * changed by the hns3 PF kernel driver, VF driver will
+                        * receive this mailbox message from PF driver.
+                        */
+                       hns3_update_port_base_vlan_info(hw, req);
+                       break;
                case HNS3_MBX_PUSH_PROMISC_INFO:
                        /*
                         * When the trust status of VF device changed by the
@@ -409,7 +430,7 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
                        break;
                default:
                        hns3_err(hw,
-                                "VF received unsupported(%d) mbx msg from PF",
+                                "VF received unsupported(%u) mbx msg from PF",
                                 req->msg[0]);
                        break;
                }