net/mlx5: fix Tx stats error counter logic
[dpdk.git] / drivers / net / i40e / i40e_ethdev_vf.c
index 62dea59..38c3adc 100644 (file)
@@ -119,9 +119,8 @@ static void i40evf_dev_xstats_reset(struct rte_eth_dev *dev);
 static int i40evf_vlan_filter_set(struct rte_eth_dev *dev,
                                  uint16_t vlan_id, int on);
 static void i40evf_vlan_offload_set(struct rte_eth_dev *dev, int mask);
-static int i40evf_vlan_pvid_set(struct rte_eth_dev *dev, uint16_t pvid,
-                               int on);
 static void i40evf_dev_close(struct rte_eth_dev *dev);
+static int  i40evf_dev_reset(struct rte_eth_dev *dev);
 static void i40evf_dev_promiscuous_enable(struct rte_eth_dev *dev);
 static void i40evf_dev_promiscuous_disable(struct rte_eth_dev *dev);
 static void i40evf_dev_allmulticast_enable(struct rte_eth_dev *dev);
@@ -203,11 +202,11 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = {
        .xstats_get_names     = i40evf_dev_xstats_get_names,
        .xstats_reset         = i40evf_dev_xstats_reset,
        .dev_close            = i40evf_dev_close,
+       .dev_reset            = i40evf_dev_reset,
        .dev_infos_get        = i40evf_dev_info_get,
        .dev_supported_ptypes_get = i40e_dev_supported_ptypes_get,
        .vlan_filter_set      = i40evf_vlan_filter_set,
        .vlan_offload_set     = i40evf_vlan_offload_set,
-       .vlan_pvid_set        = i40evf_vlan_pvid_set,
        .rx_queue_start       = i40evf_dev_rx_queue_start,
        .rx_queue_stop        = i40evf_dev_rx_queue_stop,
        .tx_queue_start       = i40evf_dev_tx_queue_start,
@@ -431,9 +430,7 @@ i40evf_check_api_version(struct rte_eth_dev *dev)
        pver = (struct virtchnl_version_info *)args.out_buffer;
        vf->version_major = pver->major;
        vf->version_minor = pver->minor;
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               PMD_DRV_LOG(INFO, "Peer is DPDK PF host");
-       else if ((vf->version_major == VIRTCHNL_VERSION_MAJOR) &&
+       if ((vf->version_major == VIRTCHNL_VERSION_MAJOR) &&
                (vf->version_minor <= VIRTCHNL_VERSION_MINOR))
                PMD_DRV_LOG(INFO, "Peer is Linux PF host");
        else {
@@ -481,7 +478,7 @@ i40evf_get_vf_resource(struct rte_eth_dev *dev)
        len =  sizeof(struct virtchnl_vf_resource) +
                I40E_MAX_VF_VSI * sizeof(struct virtchnl_vsi_resource);
 
-       (void)rte_memcpy(vf->vf_res, args.out_buffer,
+       rte_memcpy(vf->vf_res, args.out_buffer,
                        RTE_MIN(args.out_size, len));
        i40e_vf_parse_hw_config(hw, vf->vf_res);
 
@@ -563,37 +560,6 @@ i40evf_disable_vlan_strip(struct rte_eth_dev *dev)
        return ret;
 }
 
-static int
-i40evf_config_vlan_pvid(struct rte_eth_dev *dev,
-                               struct i40e_vsi_vlan_pvid_info *info)
-{
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       int err;
-       struct vf_cmd_info args;
-       struct virtchnl_pvid_info tpid_info;
-
-       if (info == NULL) {
-               PMD_DRV_LOG(ERR, "invalid parameters");
-               return I40E_ERR_PARAM;
-       }
-
-       memset(&tpid_info, 0, sizeof(tpid_info));
-       tpid_info.vsi_id = vf->vsi_res->vsi_id;
-       (void)rte_memcpy(&tpid_info.info, info, sizeof(*info));
-
-       args.ops = (enum virtchnl_ops)I40E_VIRTCHNL_OP_CFG_VLAN_PVID;
-       args.in_args = (uint8_t *)&tpid_info;
-       args.in_args_size = sizeof(tpid_info);
-       args.out_buffer = vf->aq_resp;
-       args.out_size = I40E_AQ_BUF_SZ;
-
-       err = i40evf_execute_vf_cmd(dev, &args);
-       if (err)
-               PMD_DRV_LOG(ERR, "fail to execute command CFG_VLAN_PVID");
-
-       return err;
-}
-
 static void
 i40evf_fill_virtchnl_vsi_txq_info(struct virtchnl_txq_info *txq_info,
                                  uint16_t vsi_id,
@@ -629,7 +595,6 @@ i40evf_fill_virtchnl_vsi_rxq_info(struct virtchnl_rxq_info *rxq_info,
        }
 }
 
-/* It configures VSI queues to co-work with Linux PF host */
 static int
 i40evf_configure_vsi_queues(struct rte_eth_dev *dev)
 {
@@ -673,72 +638,6 @@ i40evf_configure_vsi_queues(struct rte_eth_dev *dev)
        return ret;
 }
 
-/* It configures VSI queues to co-work with DPDK PF host */
-static int
-i40evf_configure_vsi_queues_ext(struct rte_eth_dev *dev)
-{
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       struct i40e_rx_queue **rxq =
-               (struct i40e_rx_queue **)dev->data->rx_queues;
-       struct i40e_tx_queue **txq =
-               (struct i40e_tx_queue **)dev->data->tx_queues;
-       struct virtchnl_vsi_queue_config_ext_info *vc_vqcei;
-       struct virtchnl_queue_pair_ext_info *vc_qpei;
-       struct vf_cmd_info args;
-       uint16_t i, nb_qp = vf->num_queue_pairs;
-       const uint32_t size =
-               I40E_VIRTCHNL_CONFIG_VSI_QUEUES_SIZE(vc_vqcei, nb_qp);
-       uint8_t buff[size];
-       int ret;
-
-       memset(buff, 0, sizeof(buff));
-       vc_vqcei = (struct virtchnl_vsi_queue_config_ext_info *)buff;
-       vc_vqcei->vsi_id = vf->vsi_res->vsi_id;
-       vc_vqcei->num_queue_pairs = nb_qp;
-       vc_qpei = vc_vqcei->qpair;
-       for (i = 0; i < nb_qp; i++, vc_qpei++) {
-               i40evf_fill_virtchnl_vsi_txq_info(&vc_qpei->txq,
-                       vc_vqcei->vsi_id, i, dev->data->nb_tx_queues, txq[i]);
-               i40evf_fill_virtchnl_vsi_rxq_info(&vc_qpei->rxq,
-                       vc_vqcei->vsi_id, i, dev->data->nb_rx_queues,
-                                       vf->max_pkt_len, rxq[i]);
-               if (i < dev->data->nb_rx_queues)
-                       /*
-                        * It adds extra info for configuring VSI queues, which
-                        * is needed to enable the configurable crc stripping
-                        * in VF.
-                        */
-                       vc_qpei->rxq_ext.crcstrip =
-                               dev->data->dev_conf.rxmode.hw_strip_crc;
-       }
-       memset(&args, 0, sizeof(args));
-       args.ops =
-               (enum virtchnl_ops)VIRTCHNL_OP_CONFIG_VSI_QUEUES_EXT;
-       args.in_args = (uint8_t *)vc_vqcei;
-       args.in_args_size = size;
-       args.out_buffer = vf->aq_resp;
-       args.out_size = I40E_AQ_BUF_SZ;
-       ret = i40evf_execute_vf_cmd(dev, &args);
-       if (ret)
-               PMD_DRV_LOG(ERR, "Failed to execute command of "
-                       "VIRTCHNL_OP_CONFIG_VSI_QUEUES_EXT");
-
-       return ret;
-}
-
-static int
-i40evf_configure_queues(struct rte_eth_dev *dev)
-{
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               /* To support DPDK PF host */
-               return i40evf_configure_vsi_queues_ext(dev);
-       else
-               /* To support Linux PF host */
-               return i40evf_configure_vsi_queues(dev);
-}
-
 static int
 i40evf_config_irq_map(struct rte_eth_dev *dev)
 {
@@ -752,14 +651,10 @@ i40evf_config_irq_map(struct rte_eth_dev *dev)
        uint32_t vector_id;
        int i, err;
 
-       if (rte_intr_allow_others(intr_handle)) {
-               if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-                       vector_id = I40EVF_VSI_DEFAULT_MSIX_INTR;
-               else
-                       vector_id = I40EVF_VSI_DEFAULT_MSIX_INTR_LNX;
-       } else {
+       if (rte_intr_allow_others(intr_handle))
+               vector_id = I40EVF_VSI_DEFAULT_MSIX_INTR_LNX;
+       else
                vector_id = I40E_MISC_VEC_ID;
-       }
 
        map_info = (struct virtchnl_irq_map_info *)cmd_buffer;
        map_info->num_vectors = 1;
@@ -888,7 +783,7 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,
        int err;
        struct vf_cmd_info args;
 
-       if (i40e_validate_mac_addr(addr->addr_bytes) != I40E_SUCCESS) {
+       if (is_zero_ether_addr(addr)) {
                PMD_DRV_LOG(ERR, "Invalid mac:%x:%x:%x:%x:%x:%x",
                            addr->addr_bytes[0], addr->addr_bytes[1],
                            addr->addr_bytes[2], addr->addr_bytes[3],
@@ -899,7 +794,7 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,
        list = (struct virtchnl_ether_addr_list *)cmd_buffer;
        list->vsi_id = vf->vsi_res->vsi_id;
        list->num_elements = 1;
-       (void)rte_memcpy(list->list[0].addr, addr->addr_bytes,
+       rte_memcpy(list->list[0].addr, addr->addr_bytes,
                                        sizeof(addr->addr_bytes));
 
        args.ops = VIRTCHNL_OP_ADD_ETH_ADDR;
@@ -911,6 +806,8 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,
        if (err)
                PMD_DRV_LOG(ERR, "fail to execute command "
                            "OP_ADD_ETHER_ADDRESS");
+       else
+               vf->vsi.mac_num++;
 
        return err;
 }
@@ -937,7 +834,7 @@ i40evf_del_mac_addr_by_addr(struct rte_eth_dev *dev,
        list = (struct virtchnl_ether_addr_list *)cmd_buffer;
        list->vsi_id = vf->vsi_res->vsi_id;
        list->num_elements = 1;
-       (void)rte_memcpy(list->list[0].addr, addr->addr_bytes,
+       rte_memcpy(list->list[0].addr, addr->addr_bytes,
                        sizeof(addr->addr_bytes));
 
        args.ops = VIRTCHNL_OP_DEL_ETH_ADDR;
@@ -949,6 +846,8 @@ i40evf_del_mac_addr_by_addr(struct rte_eth_dev *dev,
        if (err)
                PMD_DRV_LOG(ERR, "fail to execute command "
                            "OP_DEL_ETHER_ADDRESS");
+       else
+               vf->vsi.mac_num--;
        return;
 }
 
@@ -1245,29 +1144,29 @@ i40evf_init_vf(struct rte_eth_dev *dev)
        /* VF reset, shutdown admin queue and initialize again */
        if (i40e_shutdown_adminq(hw) != I40E_SUCCESS) {
                PMD_INIT_LOG(ERR, "i40e_shutdown_adminq failed");
-               return -1;
+               goto err;
        }
 
        i40e_init_adminq_parameter(hw);
        if (i40e_init_adminq(hw) != I40E_SUCCESS) {
                PMD_INIT_LOG(ERR, "init_adminq failed");
-               return -1;
+               goto err;
        }
        vf->aq_resp = rte_zmalloc("vf_aq_resp", I40E_AQ_BUF_SZ, 0);
        if (!vf->aq_resp) {
                PMD_INIT_LOG(ERR, "unable to allocate vf_aq_resp memory");
-                       goto err_aq;
+               goto err_aq;
        }
        if (i40evf_check_api_version(dev) != 0) {
                PMD_INIT_LOG(ERR, "check_api version failed");
-               goto err_aq;
+               goto err_api;
        }
        bufsz = sizeof(struct virtchnl_vf_resource) +
                (I40E_MAX_VF_VSI * sizeof(struct virtchnl_vsi_resource));
        vf->vf_res = rte_zmalloc("vf_res", bufsz, 0);
        if (!vf->vf_res) {
                PMD_INIT_LOG(ERR, "unable to allocate vf_res memory");
-                       goto err_aq;
+               goto err_api;
        }
 
        if (i40evf_get_vf_resource(dev) != 0) {
@@ -1299,20 +1198,20 @@ i40evf_init_vf(struct rte_eth_dev *dev)
        else
                eth_random_addr(hw->mac.addr); /* Generate a random one */
 
-       /* If the PF host is not DPDK, set the interval of ITR0 to max*/
-       if (vf->version_major != I40E_DPDK_VERSION_MAJOR) {
-               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
-                              (I40E_ITR_INDEX_DEFAULT <<
-                               I40E_VFINT_DYN_CTL0_ITR_INDX_SHIFT) |
-                              (interval <<
-                               I40E_VFINT_DYN_CTL0_INTERVAL_SHIFT));
-               I40EVF_WRITE_FLUSH(hw);
-       }
+       I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
+                      (I40E_ITR_INDEX_DEFAULT <<
+                       I40E_VFINT_DYN_CTL0_ITR_INDX_SHIFT) |
+                      (interval <<
+                       I40E_VFINT_DYN_CTL0_INTERVAL_SHIFT));
+       I40EVF_WRITE_FLUSH(hw);
 
        return 0;
 
 err_alloc:
        rte_free(vf->vf_res);
+       vf->vsi_res = NULL;
+err_api:
+       rte_free(vf->aq_resp);
 err_aq:
        i40e_shutdown_adminq(hw); /* ignore error */
 err:
@@ -1626,16 +1525,10 @@ i40evf_dev_configure(struct rte_eth_dev *dev)
 static int
 i40evf_init_vlan(struct rte_eth_dev *dev)
 {
-       struct rte_eth_dev_data *data = dev->data;
-       int ret;
-
        /* Apply vlan offload setting */
        i40evf_vlan_offload_set(dev, ETH_VLAN_STRIP_MASK);
 
-       /* Apply pvid setting */
-       ret = i40evf_vlan_pvid_set(dev, data->dev_conf.txmode.pvid,
-                               data->dev_conf.txmode.hw_vlan_insert_pvid);
-       return ret;
+       return I40E_SUCCESS;
 }
 
 static void
@@ -1653,32 +1546,6 @@ i40evf_vlan_offload_set(struct rte_eth_dev *dev, int mask)
        }
 }
 
-static int
-i40evf_vlan_pvid_set(struct rte_eth_dev *dev, uint16_t pvid, int on)
-{
-       struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
-       struct i40e_vsi_vlan_pvid_info info;
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-
-       memset(&info, 0, sizeof(info));
-       info.on = on;
-
-       /* Linux pf host don't support vlan offload yet */
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR) {
-               if (info.on)
-                       info.config.pvid = pvid;
-               else {
-                       info.config.reject.tagged =
-                               dev_conf->txmode.hw_vlan_reject_tagged;
-                       info.config.reject.untagged =
-                               dev_conf->txmode.hw_vlan_reject_untagged;
-               }
-               return i40evf_config_vlan_pvid(dev, &info);
-       }
-
-       return 0;
-}
-
 static int
 i40evf_dev_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 {
@@ -1895,7 +1762,6 @@ i40evf_tx_init(struct rte_eth_dev *dev)
 static inline void
 i40evf_enable_queues_intr(struct rte_eth_dev *dev)
 {
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
@@ -1910,25 +1776,12 @@ i40evf_enable_queues_intr(struct rte_eth_dev *dev)
                return;
        }
 
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               /* To support DPDK PF host */
-               I40E_WRITE_REG(hw,
-                       I40E_VFINT_DYN_CTLN1(I40EVF_VSI_DEFAULT_MSIX_INTR - 1),
-                       I40E_VFINT_DYN_CTLN1_INTENA_MASK |
-                       I40E_VFINT_DYN_CTLN_CLEARPBA_MASK);
-       /* If host driver is kernel driver, do nothing.
-        * Interrupt 0 is used for rx packets, but don't set
-        * I40E_VFINT_DYN_CTL01,
-        * because it is already done in i40evf_enable_irq0.
-        */
-
        I40EVF_WRITE_FLUSH(hw);
 }
 
 static inline void
 i40evf_disable_queues_intr(struct rte_eth_dev *dev)
 {
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
@@ -1940,17 +1793,6 @@ i40evf_disable_queues_intr(struct rte_eth_dev *dev)
                return;
        }
 
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               I40E_WRITE_REG(hw,
-                              I40E_VFINT_DYN_CTLN1(I40EVF_VSI_DEFAULT_MSIX_INTR
-                                                   - 1),
-                              0);
-       /* If host driver is kernel driver, do nothing.
-        * Interrupt 0 is used for rx packets, but don't zero
-        * I40E_VFINT_DYN_CTL01,
-        * because interrupt 0 is also used for adminq processing.
-        */
-
        I40EVF_WRITE_FLUSH(hw);
 }
 
@@ -2046,7 +1888,7 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add)
                        addr = &dev->data->mac_addrs[i];
                        if (is_zero_ether_addr(addr))
                                continue;
-                       (void)rte_memcpy(list->list[j].addr, addr->addr_bytes,
+                       rte_memcpy(list->list[j].addr, addr->addr_bytes,
                                         sizeof(addr->addr_bytes));
                        PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x",
                                    addr->addr_bytes[0], addr->addr_bytes[1],
@@ -2063,10 +1905,16 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add)
                args.out_buffer = vf->aq_resp;
                args.out_size = I40E_AQ_BUF_SZ;
                err = i40evf_execute_vf_cmd(dev, &args);
-               if (err)
+               if (err) {
                        PMD_DRV_LOG(ERR, "fail to execute command %s",
                                    add ? "OP_ADD_ETHER_ADDRESS" :
                                    "OP_DEL_ETHER_ADDRESS");
+               } else {
+                       if (add)
+                               vf->vsi.mac_num++;
+                       else
+                               vf->vsi.mac_num--;
+               }
                rte_free(list);
                begin = next_begin;
        } while (begin < I40E_NUM_MACADDR_MAX);
@@ -2114,7 +1962,7 @@ i40evf_dev_start(struct rte_eth_dev *dev)
 
        i40evf_tx_init(dev);
 
-       if (i40evf_configure_queues(dev) != 0) {
+       if (i40evf_configure_vsi_queues(dev) != 0) {
                PMD_DRV_LOG(ERR, "configure queues failed");
                goto err_queue;
        }
@@ -2145,9 +1993,12 @@ i40evf_dev_stop(struct rte_eth_dev *dev)
 {
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
+       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
        PMD_INIT_FUNC_TRACE();
 
+       if (hw->adapter_stopped == 1)
+               return;
        i40evf_stop_queues(dev);
        i40evf_disable_queues_intr(dev);
        i40e_dev_clear_queues(dev);
@@ -2160,6 +2011,7 @@ i40evf_dev_stop(struct rte_eth_dev *dev)
        }
        /* remove all mac addrs */
        i40evf_add_del_all_mac_addr(dev, FALSE);
+       hw->adapter_stopped = 1;
 
 }
 
@@ -2347,7 +2199,6 @@ i40evf_dev_close(struct rte_eth_dev *dev)
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
 
        i40evf_dev_stop(dev);
-       hw->adapter_stopped = 1;
        i40e_dev_free_queues(dev);
        i40evf_reset_vf(hw);
        i40e_shutdown_adminq(hw);
@@ -2360,6 +2211,23 @@ i40evf_dev_close(struct rte_eth_dev *dev)
        i40evf_disable_irq0(hw);
 }
 
+/*
+ * Reset VF device only to re-initialize resources in PMD layer
+ */
+static int
+i40evf_dev_reset(struct rte_eth_dev *dev)
+{
+       int ret;
+
+       ret = i40evf_dev_uninit(dev);
+       if (ret)
+               return ret;
+
+       ret = i40evf_dev_init(dev);
+
+       return ret;
+}
+
 static int
 i40evf_get_rss_lut(struct i40e_vsi *vsi, uint8_t *lut, uint16_t lut_size)
 {