net/mlx5: fix Tx stats error counter logic
[dpdk.git] / drivers / net / i40e / i40e_ethdev_vf.c
index 7c2fc85..38c3adc 100644 (file)
@@ -430,9 +430,7 @@ i40evf_check_api_version(struct rte_eth_dev *dev)
        pver = (struct virtchnl_version_info *)args.out_buffer;
        vf->version_major = pver->major;
        vf->version_minor = pver->minor;
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               PMD_DRV_LOG(INFO, "Peer is DPDK PF host");
-       else if ((vf->version_major == VIRTCHNL_VERSION_MAJOR) &&
+       if ((vf->version_major == VIRTCHNL_VERSION_MAJOR) &&
                (vf->version_minor <= VIRTCHNL_VERSION_MINOR))
                PMD_DRV_LOG(INFO, "Peer is Linux PF host");
        else {
@@ -480,7 +478,7 @@ i40evf_get_vf_resource(struct rte_eth_dev *dev)
        len =  sizeof(struct virtchnl_vf_resource) +
                I40E_MAX_VF_VSI * sizeof(struct virtchnl_vsi_resource);
 
-       (void)rte_memcpy(vf->vf_res, args.out_buffer,
+       rte_memcpy(vf->vf_res, args.out_buffer,
                        RTE_MIN(args.out_size, len));
        i40e_vf_parse_hw_config(hw, vf->vf_res);
 
@@ -653,14 +651,10 @@ i40evf_config_irq_map(struct rte_eth_dev *dev)
        uint32_t vector_id;
        int i, err;
 
-       if (rte_intr_allow_others(intr_handle)) {
-               if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-                       vector_id = I40EVF_VSI_DEFAULT_MSIX_INTR;
-               else
-                       vector_id = I40EVF_VSI_DEFAULT_MSIX_INTR_LNX;
-       } else {
+       if (rte_intr_allow_others(intr_handle))
+               vector_id = I40EVF_VSI_DEFAULT_MSIX_INTR_LNX;
+       else
                vector_id = I40E_MISC_VEC_ID;
-       }
 
        map_info = (struct virtchnl_irq_map_info *)cmd_buffer;
        map_info->num_vectors = 1;
@@ -789,7 +783,7 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,
        int err;
        struct vf_cmd_info args;
 
-       if (i40e_validate_mac_addr(addr->addr_bytes) != I40E_SUCCESS) {
+       if (is_zero_ether_addr(addr)) {
                PMD_DRV_LOG(ERR, "Invalid mac:%x:%x:%x:%x:%x:%x",
                            addr->addr_bytes[0], addr->addr_bytes[1],
                            addr->addr_bytes[2], addr->addr_bytes[3],
@@ -800,7 +794,7 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,
        list = (struct virtchnl_ether_addr_list *)cmd_buffer;
        list->vsi_id = vf->vsi_res->vsi_id;
        list->num_elements = 1;
-       (void)rte_memcpy(list->list[0].addr, addr->addr_bytes,
+       rte_memcpy(list->list[0].addr, addr->addr_bytes,
                                        sizeof(addr->addr_bytes));
 
        args.ops = VIRTCHNL_OP_ADD_ETH_ADDR;
@@ -840,7 +834,7 @@ i40evf_del_mac_addr_by_addr(struct rte_eth_dev *dev,
        list = (struct virtchnl_ether_addr_list *)cmd_buffer;
        list->vsi_id = vf->vsi_res->vsi_id;
        list->num_elements = 1;
-       (void)rte_memcpy(list->list[0].addr, addr->addr_bytes,
+       rte_memcpy(list->list[0].addr, addr->addr_bytes,
                        sizeof(addr->addr_bytes));
 
        args.ops = VIRTCHNL_OP_DEL_ETH_ADDR;
@@ -1150,29 +1144,29 @@ i40evf_init_vf(struct rte_eth_dev *dev)
        /* VF reset, shutdown admin queue and initialize again */
        if (i40e_shutdown_adminq(hw) != I40E_SUCCESS) {
                PMD_INIT_LOG(ERR, "i40e_shutdown_adminq failed");
-               return -1;
+               goto err;
        }
 
        i40e_init_adminq_parameter(hw);
        if (i40e_init_adminq(hw) != I40E_SUCCESS) {
                PMD_INIT_LOG(ERR, "init_adminq failed");
-               return -1;
+               goto err;
        }
        vf->aq_resp = rte_zmalloc("vf_aq_resp", I40E_AQ_BUF_SZ, 0);
        if (!vf->aq_resp) {
                PMD_INIT_LOG(ERR, "unable to allocate vf_aq_resp memory");
-                       goto err_aq;
+               goto err_aq;
        }
        if (i40evf_check_api_version(dev) != 0) {
                PMD_INIT_LOG(ERR, "check_api version failed");
-               goto err_aq;
+               goto err_api;
        }
        bufsz = sizeof(struct virtchnl_vf_resource) +
                (I40E_MAX_VF_VSI * sizeof(struct virtchnl_vsi_resource));
        vf->vf_res = rte_zmalloc("vf_res", bufsz, 0);
        if (!vf->vf_res) {
                PMD_INIT_LOG(ERR, "unable to allocate vf_res memory");
-                       goto err_aq;
+               goto err_api;
        }
 
        if (i40evf_get_vf_resource(dev) != 0) {
@@ -1204,20 +1198,20 @@ i40evf_init_vf(struct rte_eth_dev *dev)
        else
                eth_random_addr(hw->mac.addr); /* Generate a random one */
 
-       /* If the PF host is not DPDK, set the interval of ITR0 to max*/
-       if (vf->version_major != I40E_DPDK_VERSION_MAJOR) {
-               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
-                              (I40E_ITR_INDEX_DEFAULT <<
-                               I40E_VFINT_DYN_CTL0_ITR_INDX_SHIFT) |
-                              (interval <<
-                               I40E_VFINT_DYN_CTL0_INTERVAL_SHIFT));
-               I40EVF_WRITE_FLUSH(hw);
-       }
+       I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
+                      (I40E_ITR_INDEX_DEFAULT <<
+                       I40E_VFINT_DYN_CTL0_ITR_INDX_SHIFT) |
+                      (interval <<
+                       I40E_VFINT_DYN_CTL0_INTERVAL_SHIFT));
+       I40EVF_WRITE_FLUSH(hw);
 
        return 0;
 
 err_alloc:
        rte_free(vf->vf_res);
+       vf->vsi_res = NULL;
+err_api:
+       rte_free(vf->aq_resp);
 err_aq:
        i40e_shutdown_adminq(hw); /* ignore error */
 err:
@@ -1768,7 +1762,6 @@ i40evf_tx_init(struct rte_eth_dev *dev)
 static inline void
 i40evf_enable_queues_intr(struct rte_eth_dev *dev)
 {
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
@@ -1783,25 +1776,12 @@ i40evf_enable_queues_intr(struct rte_eth_dev *dev)
                return;
        }
 
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               /* To support DPDK PF host */
-               I40E_WRITE_REG(hw,
-                       I40E_VFINT_DYN_CTLN1(I40EVF_VSI_DEFAULT_MSIX_INTR - 1),
-                       I40E_VFINT_DYN_CTLN1_INTENA_MASK |
-                       I40E_VFINT_DYN_CTLN_CLEARPBA_MASK);
-       /* If host driver is kernel driver, do nothing.
-        * Interrupt 0 is used for rx packets, but don't set
-        * I40E_VFINT_DYN_CTL01,
-        * because it is already done in i40evf_enable_irq0.
-        */
-
        I40EVF_WRITE_FLUSH(hw);
 }
 
 static inline void
 i40evf_disable_queues_intr(struct rte_eth_dev *dev)
 {
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
@@ -1813,17 +1793,6 @@ i40evf_disable_queues_intr(struct rte_eth_dev *dev)
                return;
        }
 
-       if (vf->version_major == I40E_DPDK_VERSION_MAJOR)
-               I40E_WRITE_REG(hw,
-                              I40E_VFINT_DYN_CTLN1(I40EVF_VSI_DEFAULT_MSIX_INTR
-                                                   - 1),
-                              0);
-       /* If host driver is kernel driver, do nothing.
-        * Interrupt 0 is used for rx packets, but don't zero
-        * I40E_VFINT_DYN_CTL01,
-        * because interrupt 0 is also used for adminq processing.
-        */
-
        I40EVF_WRITE_FLUSH(hw);
 }
 
@@ -1919,7 +1888,7 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add)
                        addr = &dev->data->mac_addrs[i];
                        if (is_zero_ether_addr(addr))
                                continue;
-                       (void)rte_memcpy(list->list[j].addr, addr->addr_bytes,
+                       rte_memcpy(list->list[j].addr, addr->addr_bytes,
                                         sizeof(addr->addr_bytes));
                        PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x",
                                    addr->addr_bytes[0], addr->addr_bytes[1],
@@ -2024,7 +1993,7 @@ i40evf_dev_stop(struct rte_eth_dev *dev)
 {
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
-       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev);
+       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
        PMD_INIT_FUNC_TRACE();