ethdev: use constants for link state
[dpdk.git] / drivers / net / i40e / i40e_ethdev_vf.c
index 6b7b350..91df13b 100644 (file)
@@ -74,8 +74,6 @@
 #define I40EVF_BUSY_WAIT_DELAY 10
 #define I40EVF_BUSY_WAIT_COUNT 50
 #define MAX_RESET_WAIT_CNT     20
-/*ITR index for NOITR*/
-#define I40E_QINT_RQCTL_MSIX_INDX_NOITR     3
 
 struct i40evf_arq_msg_info {
        enum i40e_virtchnl_ops ops;
@@ -103,9 +101,6 @@ enum i40evf_aq_result {
        I40EVF_MSG_CMD,      /* Read async command result */
 };
 
-/* A share buffer to store the command result from PF driver */
-static uint8_t cmd_result_buffer[I40E_AQ_BUF_SZ];
-
 static int i40evf_dev_configure(struct rte_eth_dev *dev);
 static int i40evf_dev_start(struct rte_eth_dev *dev);
 static void i40evf_dev_stop(struct rte_eth_dev *dev);
@@ -159,6 +154,9 @@ static int
 i40evf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id);
 static int
 i40evf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id);
+static void i40evf_handle_pf_event(__rte_unused struct rte_eth_dev *dev,
+                                  uint8_t *msg,
+                                  uint16_t msglen);
 
 /* Default hash key buffer for RSS */
 static uint32_t rss_key_default[I40E_VFQF_HKEY_MAX_INDEX + 1];
@@ -201,6 +199,7 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = {
        .xstats_reset         = i40evf_dev_xstats_reset,
        .dev_close            = i40evf_dev_close,
        .dev_infos_get        = i40evf_dev_info_get,
+       .dev_supported_ptypes_get = i40e_dev_supported_ptypes_get,
        .vlan_filter_set      = i40evf_vlan_filter_set,
        .vlan_offload_set     = i40evf_vlan_offload_set,
        .vlan_pvid_set        = i40evf_vlan_pvid_set,
@@ -224,31 +223,37 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = {
 };
 
 /*
- * Parse admin queue message.
- *
- * return value:
- *  < 0: meet error
- *  0: read sys msg
- *  > 0: read cmd result
+ * Read data in admin queue to get msg from pf driver
  */
 static enum i40evf_aq_result
-i40evf_parse_pfmsg(struct i40e_vf *vf,
-                  struct i40e_arq_event_info *event,
-                  struct i40evf_arq_msg_info *data)
+i40evf_read_pfmsg(struct rte_eth_dev *dev, struct i40evf_arq_msg_info *data)
 {
-       enum i40e_virtchnl_ops opcode = (enum i40e_virtchnl_ops)\
-                       rte_le_to_cpu_32(event->desc.cookie_high);
-       enum i40e_status_code retval = (enum i40e_status_code)\
-                       rte_le_to_cpu_32(event->desc.cookie_low);
-       enum i40evf_aq_result ret = I40EVF_MSG_CMD;
+       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       struct i40e_arq_event_info event;
+       enum i40e_virtchnl_ops opcode;
+       enum i40e_status_code retval;
+       int ret;
+       enum i40evf_aq_result result = I40EVF_MSG_NON;
 
+       event.buf_len = data->buf_len;
+       event.msg_buf = data->msg;
+       ret = i40e_clean_arq_element(hw, &event, NULL);
+       /* Can't read any msg from adminQ */
+       if (ret) {
+               if (ret != I40E_ERR_ADMIN_QUEUE_NO_WORK)
+                       result = I40EVF_MSG_ERR;
+               return result;
+       }
+
+       opcode = (enum i40e_virtchnl_ops)rte_le_to_cpu_32(event.desc.cookie_high);
+       retval = (enum i40e_status_code)rte_le_to_cpu_32(event.desc.cookie_low);
        /* pf sys event */
        if (opcode == I40E_VIRTCHNL_OP_EVENT) {
                struct i40e_virtchnl_pf_event *vpe =
-                       (struct i40e_virtchnl_pf_event *)event->msg_buf;
+                       (struct i40e_virtchnl_pf_event *)event.msg_buf;
 
-               /* Initialize ret to sys event */
-               ret = I40EVF_MSG_SYS;
+               result = I40EVF_MSG_SYS;
                switch (vpe->event) {
                case I40E_VIRTCHNL_EVENT_LINK_CHANGE:
                        vf->link_up =
@@ -273,74 +278,17 @@ i40evf_parse_pfmsg(struct i40e_vf *vf,
                }
        } else {
                /* async reply msg on command issued by vf previously */
-               ret = I40EVF_MSG_CMD;
+               result = I40EVF_MSG_CMD;
                /* Actual data length read from PF */
-               data->msg_len = event->msg_len;
+               data->msg_len = event.msg_len;
        }
-       /* fill the ops and result to notify VF */
+
        data->result = retval;
        data->ops = opcode;
 
-       return ret;
-}
-
-/*
- * Read data in admin queue to get msg from pf driver
- */
-static enum i40evf_aq_result
-i40evf_read_pfmsg(struct rte_eth_dev *dev, struct i40evf_arq_msg_info *data)
-{
-       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       struct i40e_arq_event_info event;
-       int ret;
-       enum i40evf_aq_result result = I40EVF_MSG_NON;
-
-       event.buf_len = data->buf_len;
-       event.msg_buf = data->msg;
-       ret = i40e_clean_arq_element(hw, &event, NULL);
-       /* Can't read any msg from adminQ */
-       if (ret) {
-               if (ret == I40E_ERR_ADMIN_QUEUE_NO_WORK)
-                       result = I40EVF_MSG_NON;
-               else
-                       result = I40EVF_MSG_ERR;
-               return result;
-       }
-
-       /* Parse the event */
-       result = i40evf_parse_pfmsg(vf, &event, data);
-
        return result;
 }
 
-/*
- * Polling read until command result return from pf driver or meet error.
- */
-static int
-i40evf_wait_cmd_done(struct rte_eth_dev *dev,
-                    struct i40evf_arq_msg_info *data)
-{
-       int i = 0;
-       enum i40evf_aq_result ret;
-
-#define MAX_TRY_TIMES 20
-#define ASQ_DELAY_MS  100
-       do {
-               /* Delay some time first */
-               rte_delay_ms(ASQ_DELAY_MS);
-               ret = i40evf_read_pfmsg(dev, data);
-               if (ret == I40EVF_MSG_CMD)
-                       return 0;
-               else if (ret == I40EVF_MSG_ERR)
-                       return -1;
-
-               /* If don't read msg or read sys event, continue */
-       } while(i++ < MAX_TRY_TIMES);
-
-       return -1;
-}
-
 /**
  * clear current command. Only call in case execute
  * _atomic_set_cmd successfully.
@@ -367,13 +315,18 @@ _atomic_set_cmd(struct i40e_vf *vf, enum i40e_virtchnl_ops ops)
        return !ret;
 }
 
+#define MAX_TRY_TIMES 200
+#define ASQ_DELAY_MS  10
+
 static int
 i40evf_execute_vf_cmd(struct rte_eth_dev *dev, struct vf_cmd_info *args)
 {
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
-       int err = -1;
        struct i40evf_arq_msg_info info;
+       enum i40evf_aq_result ret;
+       int err = -1;
+       int i = 0;
 
        if (_atomic_set_cmd(vf, args->ops))
                return -1;
@@ -391,19 +344,42 @@ i40evf_execute_vf_cmd(struct rte_eth_dev *dev, struct vf_cmd_info *args)
                return err;
        }
 
-       err = i40evf_wait_cmd_done(dev, &info);
-       /* read message and it's expected one */
-       if (!err && args->ops == info.ops)
-               _clear_cmd(vf);
-       else if (err) {
-               PMD_DRV_LOG(ERR, "Failed to read message from AdminQ");
+       switch (args->ops) {
+       case I40E_VIRTCHNL_OP_RESET_VF:
+               /*no need to process in this function */
+               break;
+       case I40E_VIRTCHNL_OP_VERSION:
+       case I40E_VIRTCHNL_OP_GET_VF_RESOURCES:
+               /* for init adminq commands, need to poll the response */
+               do {
+                       ret = i40evf_read_pfmsg(dev, &info);
+                       if (ret == I40EVF_MSG_CMD) {
+                               err = 0;
+                               break;
+                       } else if (ret == I40EVF_MSG_ERR) {
+                               err = -1;
+                               break;
+                       }
+                       rte_delay_ms(ASQ_DELAY_MS);
+                       /* If don't read msg or read sys event, continue */
+               } while (i++ < MAX_TRY_TIMES);
                _clear_cmd(vf);
+               break;
+
+       default:
+               /* for other adminq in running time, waiting the cmd done flag */
+               do {
+                       if (vf->pend_cmd == I40E_VIRTCHNL_OP_UNKNOWN) {
+                               err = 0;
+                               break;
+                       }
+                       rte_delay_ms(ASQ_DELAY_MS);
+                       /* If don't read msg or read sys event, continue */
+               } while (i++ < MAX_TRY_TIMES);
+               break;
        }
-       else if (args->ops != info.ops)
-               PMD_DRV_LOG(ERR, "command mismatch, expect %u, get %u",
-                           args->ops, info.ops);
 
-       return err | info.result;
+       return err | vf->cmd_retval;
 }
 
 /*
@@ -423,7 +399,7 @@ i40evf_check_api_version(struct rte_eth_dev *dev)
        args.ops = I40E_VIRTCHNL_OP_VERSION;
        args.in_args = (uint8_t *)&version;
        args.in_args_size = sizeof(version);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
 
        err = i40evf_execute_vf_cmd(dev, &args);
@@ -461,7 +437,7 @@ i40evf_get_vf_resource(struct rte_eth_dev *dev)
        uint32_t caps, len;
 
        args.ops = I40E_VIRTCHNL_OP_GET_VF_RESOURCES;
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        if (PF_IS_V11(vf)) {
                caps = I40E_VIRTCHNL_VF_OFFLOAD_L2 |
@@ -514,7 +490,7 @@ i40evf_config_promisc(struct rte_eth_dev *dev,
        args.ops = I40E_VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE;
        args.in_args = (uint8_t *)&promisc;
        args.in_args_size = sizeof(promisc);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
 
        err = i40evf_execute_vf_cmd(dev, &args);
@@ -541,7 +517,7 @@ i40evf_config_vlan_offload(struct rte_eth_dev *dev,
        args.ops = (enum i40e_virtchnl_ops)I40E_VIRTCHNL_OP_CFG_VLAN_OFFLOAD;
        args.in_args = (uint8_t *)&offload;
        args.in_args_size = sizeof(offload);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
 
        err = i40evf_execute_vf_cmd(dev, &args);
@@ -572,7 +548,7 @@ i40evf_config_vlan_pvid(struct rte_eth_dev *dev,
        args.ops = (enum i40e_virtchnl_ops)I40E_VIRTCHNL_OP_CFG_VLAN_PVID;
        args.in_args = (uint8_t *)&tpid_info;
        args.in_args_size = sizeof(tpid_info);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
 
        err = i40evf_execute_vf_cmd(dev, &args);
@@ -651,7 +627,7 @@ i40evf_configure_vsi_queues(struct rte_eth_dev *dev)
        args.ops = I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES;
        args.in_args = (uint8_t *)vc_vqci;
        args.in_args_size = size;
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        ret = i40evf_execute_vf_cmd(dev, &args);
        if (ret)
@@ -704,7 +680,7 @@ i40evf_configure_vsi_queues_ext(struct rte_eth_dev *dev)
                (enum i40e_virtchnl_ops)I40E_VIRTCHNL_OP_CONFIG_VSI_QUEUES_EXT;
        args.in_args = (uint8_t *)vc_vqcei;
        args.in_args_size = size;
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        ret = i40evf_execute_vf_cmd(dev, &args);
        if (ret)
@@ -750,7 +726,7 @@ i40evf_config_irq_map(struct rte_eth_dev *dev)
 
        map_info = (struct i40e_virtchnl_irq_map_info *)cmd_buffer;
        map_info->num_vectors = 1;
-       map_info->vecmap[0].rxitr_idx = I40E_QINT_RQCTL_MSIX_INDX_NOITR;
+       map_info->vecmap[0].rxitr_idx = I40E_ITR_INDEX_DEFAULT;
        map_info->vecmap[0].vsi_id = vf->vsi_res->vsi_id;
        /* Alway use default dynamic MSIX interrupt */
        map_info->vecmap[0].vector_id = vector_id;
@@ -766,7 +742,7 @@ i40evf_config_irq_map(struct rte_eth_dev *dev)
        args.ops = I40E_VIRTCHNL_OP_CONFIG_IRQ_MAP;
        args.in_args = (u8 *)cmd_buffer;
        args.in_args_size = sizeof(cmd_buffer);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
@@ -797,7 +773,7 @@ i40evf_switch_queue(struct rte_eth_dev *dev, bool isrx, uint16_t qid,
                args.ops = I40E_VIRTCHNL_OP_DISABLE_QUEUES;
        args.in_args = (u8 *)&queue_select;
        args.in_args_size = sizeof(queue_select);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
@@ -892,7 +868,7 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,
        args.ops = I40E_VIRTCHNL_OP_ADD_ETHER_ADDRESS;
        args.in_args = cmd_buffer;
        args.in_args_size = sizeof(cmd_buffer);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
@@ -933,7 +909,7 @@ i40evf_del_mac_addr(struct rte_eth_dev *dev, uint32_t index)
        args.ops = I40E_VIRTCHNL_OP_DEL_ETHER_ADDRESS;
        args.in_args = cmd_buffer;
        args.in_args_size = sizeof(cmd_buffer);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
@@ -955,7 +931,7 @@ i40evf_update_stats(struct rte_eth_dev *dev, struct i40e_eth_stats **pstats)
        args.ops = I40E_VIRTCHNL_OP_GET_STATS;
        args.in_args = (u8 *)&q_stats;
        args.in_args_size = sizeof(q_stats);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
 
        err = i40evf_execute_vf_cmd(dev, &args);
@@ -1049,7 +1025,7 @@ i40evf_add_vlan(struct rte_eth_dev *dev, uint16_t vlanid)
        args.ops = I40E_VIRTCHNL_OP_ADD_VLAN;
        args.in_args = (u8 *)&cmd_buffer;
        args.in_args_size = sizeof(cmd_buffer);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
@@ -1076,7 +1052,7 @@ i40evf_del_vlan(struct rte_eth_dev *dev, uint16_t vlanid)
        args.ops = I40E_VIRTCHNL_OP_DEL_VLAN;
        args.in_args = (u8 *)&cmd_buffer;
        args.in_args_size = sizeof(cmd_buffer);
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err)
@@ -1088,6 +1064,7 @@ i40evf_del_vlan(struct rte_eth_dev *dev, uint16_t vlanid)
 static int
 i40evf_get_link_status(struct rte_eth_dev *dev, struct rte_eth_link *link)
 {
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        int err;
        struct vf_cmd_info args;
        struct rte_eth_link *new_link;
@@ -1095,7 +1072,7 @@ i40evf_get_link_status(struct rte_eth_dev *dev, struct rte_eth_link *link)
        args.ops = (enum i40e_virtchnl_ops)I40E_VIRTCHNL_OP_GET_LINK_STAT;
        args.in_args = NULL;
        args.in_args_size = 0;
-       args.out_buffer = cmd_result_buffer;
+       args.out_buffer = vf->aq_resp;
        args.out_size = I40E_AQ_BUF_SZ;
        err = i40evf_execute_vf_cmd(dev, &args);
        if (err) {
@@ -1129,6 +1106,38 @@ i40evf_dev_atomic_write_link_status(struct rte_eth_dev *dev,
        return 0;
 }
 
+/* Disable IRQ0 */
+static inline void
+i40evf_disable_irq0(struct i40e_hw *hw)
+{
+       /* Disable all interrupt types */
+       I40E_WRITE_REG(hw, I40E_VFINT_ICR0_ENA1, 0);
+       I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
+                      I40E_VFINT_DYN_CTL01_ITR_INDX_MASK);
+       I40EVF_WRITE_FLUSH(hw);
+}
+
+/* Enable IRQ0 */
+static inline void
+i40evf_enable_irq0(struct i40e_hw *hw)
+{
+       /* Enable admin queue interrupt trigger */
+       uint32_t val;
+
+       i40evf_disable_irq0(hw);
+       val = I40E_READ_REG(hw, I40E_VFINT_ICR0_ENA1);
+       val |= I40E_VFINT_ICR0_ENA1_ADMINQ_MASK |
+               I40E_VFINT_ICR0_ENA1_LINK_STAT_CHANGE_MASK;
+       I40E_WRITE_REG(hw, I40E_VFINT_ICR0_ENA1, val);
+
+       I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
+               I40E_VFINT_DYN_CTL01_INTENA_MASK |
+               I40E_VFINT_DYN_CTL01_CLEARPBA_MASK |
+               I40E_VFINT_DYN_CTL01_ITR_INDX_MASK);
+
+       I40EVF_WRITE_FLUSH(hw);
+}
+
 static int
 i40evf_reset_vf(struct i40e_hw *hw)
 {
@@ -1174,6 +1183,8 @@ i40evf_init_vf(struct rte_eth_dev *dev)
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
        struct ether_addr *p_mac_addr;
+       uint16_t interval =
+               i40e_calc_itr_interval(I40E_QUEUE_ITR_INTERVAL_MAX);
 
        vf->adapter = I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
        vf->dev_data = dev->data;
@@ -1190,7 +1201,6 @@ i40evf_init_vf(struct rte_eth_dev *dev)
                goto err;
        }
 
-
        /* Reset VF and wait until it's complete */
        if (i40evf_reset_vf(hw)) {
                PMD_INIT_LOG(ERR, "reset NIC failed");
@@ -1208,6 +1218,11 @@ i40evf_init_vf(struct rte_eth_dev *dev)
                PMD_INIT_LOG(ERR, "init_adminq failed");
                return -1;
        }
+       vf->aq_resp = rte_zmalloc("vf_aq_resp", I40E_AQ_BUF_SZ, 0);
+       if (!vf->aq_resp) {
+               PMD_INIT_LOG(ERR, "unable to allocate vf_aq_resp memory");
+                       goto err_aq;
+       }
        if (i40evf_check_api_version(dev) != 0) {
                PMD_INIT_LOG(ERR, "check_api version failed");
                goto err_aq;
@@ -1250,6 +1265,16 @@ i40evf_init_vf(struct rte_eth_dev *dev)
        else
                eth_random_addr(hw->mac.addr); /* Generate a random one */
 
+       /* If the PF host is not DPDK, set the interval of ITR0 to max*/
+       if (vf->version_major != I40E_DPDK_VERSION_MAJOR) {
+               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
+                              (I40E_ITR_INDEX_DEFAULT <<
+                               I40E_VFINT_DYN_CTL0_ITR_INDX_SHIFT) |
+                              (interval <<
+                               I40E_VFINT_DYN_CTL0_INTERVAL_SHIFT));
+               I40EVF_WRITE_FLUSH(hw);
+       }
+
        return 0;
 
 err_alloc:
@@ -1272,15 +1297,147 @@ i40evf_uninit_vf(struct rte_eth_dev *dev)
                i40evf_dev_close(dev);
        rte_free(vf->vf_res);
        vf->vf_res = NULL;
+       rte_free(vf->aq_resp);
+       vf->aq_resp = NULL;
 
        return 0;
 }
 
+static void
+i40evf_handle_pf_event(__rte_unused struct rte_eth_dev *dev,
+                          uint8_t *msg,
+                          __rte_unused uint16_t msglen)
+{
+       struct i40e_virtchnl_pf_event *pf_msg =
+                       (struct i40e_virtchnl_pf_event *)msg;
+
+       switch (pf_msg->event) {
+       case I40E_VIRTCHNL_EVENT_RESET_IMPENDING:
+               PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_RESET_IMPENDING event\n");
+               _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RESET);
+               break;
+       case I40E_VIRTCHNL_EVENT_LINK_CHANGE:
+               PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_LINK_CHANGE event\n");
+               break;
+       case I40E_VIRTCHNL_EVENT_PF_DRIVER_CLOSE:
+               PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_PF_DRIVER_CLOSE event\n");
+               break;
+       default:
+               PMD_DRV_LOG(ERR, " unknown event received %u", pf_msg->event);
+               break;
+       }
+}
+
+static void
+i40evf_handle_aq_msg(struct rte_eth_dev *dev)
+{
+       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+       struct i40e_arq_event_info info;
+       struct i40e_virtchnl_msg *v_msg;
+       uint16_t pending, opcode;
+       int ret;
+
+       info.buf_len = I40E_AQ_BUF_SZ;
+       if (!vf->aq_resp) {
+               PMD_DRV_LOG(ERR, "Buffer for adminq resp should not be NULL");
+               return;
+       }
+       info.msg_buf = vf->aq_resp;
+       v_msg = (struct i40e_virtchnl_msg *)&info.desc;
+
+       pending = 1;
+       while (pending) {
+               ret = i40e_clean_arq_element(hw, &info, &pending);
+
+               if (ret != I40E_SUCCESS) {
+                       PMD_DRV_LOG(INFO, "Failed to read msg from AdminQ,"
+                                   "ret: %d", ret);
+                       break;
+               }
+               opcode = rte_le_to_cpu_16(info.desc.opcode);
+
+               switch (opcode) {
+               case i40e_aqc_opc_send_msg_to_vf:
+                       if (v_msg->v_opcode == I40E_VIRTCHNL_OP_EVENT)
+                               /* process event*/
+                               i40evf_handle_pf_event(dev, info.msg_buf,
+                                                      info.msg_len);
+                       else {
+                               /* read message and it's expected one */
+                               if (v_msg->v_opcode == vf->pend_cmd) {
+                                       vf->cmd_retval = v_msg->v_retval;
+                                       /* prevent compiler reordering */
+                                       rte_compiler_barrier();
+                                       _clear_cmd(vf);
+                               } else
+                                       PMD_DRV_LOG(ERR, "command mismatch,"
+                                               "expect %u, get %u",
+                                               vf->pend_cmd, v_msg->v_opcode);
+                               PMD_DRV_LOG(DEBUG, "adminq response is received,"
+                                            " opcode = %d\n", v_msg->v_opcode);
+                       }
+                       break;
+               default:
+                       PMD_DRV_LOG(ERR, "Request %u is not supported yet",
+                                   opcode);
+                       break;
+               }
+       }
+}
+
+/**
+ * Interrupt handler triggered by NIC  for handling
+ * specific interrupt. Only adminq interrupt is processed in VF.
+ *
+ * @param handle
+ *  Pointer to interrupt handle.
+ * @param param
+ *  The address of parameter (struct rte_eth_dev *) regsitered before.
+ *
+ * @return
+ *  void
+ */
+static void
+i40evf_dev_interrupt_handler(__rte_unused struct rte_intr_handle *handle,
+                            void *param)
+{
+       struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
+       struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       uint32_t icr0;
+
+       i40evf_disable_irq0(hw);
+
+       /* read out interrupt causes */
+       icr0 = I40E_READ_REG(hw, I40E_VFINT_ICR01);
+
+       /* No interrupt event indicated */
+       if (!(icr0 & I40E_VFINT_ICR01_INTEVENT_MASK)) {
+               PMD_DRV_LOG(DEBUG, "No interrupt event, nothing to do\n");
+               goto done;
+       }
+
+       if (icr0 & I40E_VFINT_ICR01_ADMINQ_MASK) {
+               PMD_DRV_LOG(DEBUG, "ICR01_ADMINQ is reported\n");
+               i40evf_handle_aq_msg(dev);
+       }
+
+       /* Link Status Change interrupt */
+       if (icr0 & I40E_VFINT_ICR01_LINK_STAT_CHANGE_MASK)
+               PMD_DRV_LOG(DEBUG, "LINK_STAT_CHANGE is reported,"
+                                  " do nothing\n");
+
+done:
+       i40evf_enable_irq0(hw);
+       rte_intr_enable(&dev->pci_dev->intr_handle);
+}
+
 static int
 i40evf_dev_init(struct rte_eth_dev *eth_dev)
 {
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(\
                        eth_dev->data->dev_private);
+       struct rte_pci_device *pci_dev = eth_dev->pci_dev;
 
        PMD_INIT_FUNC_TRACE();
 
@@ -1315,7 +1472,17 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev)
                return -1;
        }
 
-       /* allocate memory for mac addr storage */
+       /* register callback func to eal lib */
+       rte_intr_callback_register(&pci_dev->intr_handle,
+               i40evf_dev_interrupt_handler, (void *)eth_dev);
+
+       /* enable uio intr after callback register */
+       rte_intr_enable(&pci_dev->intr_handle);
+
+       /* configure and enable device interrupt */
+       i40evf_enable_irq0(hw);
+
+       /* copy mac addr */
        eth_dev->data->mac_addrs = rte_zmalloc("i40evf_mac",
                                        ETHER_ADDR_LEN * I40E_NUM_MACADDR_MAX,
                                        0);
@@ -1694,7 +1861,8 @@ i40evf_enable_queues_intr(struct rte_eth_dev *dev)
                I40E_WRITE_REG(hw,
                               I40E_VFINT_DYN_CTL01,
                               I40E_VFINT_DYN_CTL01_INTENA_MASK |
-                              I40E_VFINT_DYN_CTL01_CLEARPBA_MASK);
+                              I40E_VFINT_DYN_CTL01_CLEARPBA_MASK |
+                              I40E_VFINT_DYN_CTL01_ITR_INDX_MASK);
                I40EVF_WRITE_FLUSH(hw);
                return;
        }
@@ -1705,11 +1873,11 @@ i40evf_enable_queues_intr(struct rte_eth_dev *dev)
                        I40E_VFINT_DYN_CTLN1(I40EVF_VSI_DEFAULT_MSIX_INTR - 1),
                        I40E_VFINT_DYN_CTLN1_INTENA_MASK |
                        I40E_VFINT_DYN_CTLN_CLEARPBA_MASK);
-       else
-               /* To support Linux PF host */
-               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
-                               I40E_VFINT_DYN_CTL01_INTENA_MASK |
-                               I40E_VFINT_DYN_CTL01_CLEARPBA_MASK);
+       /* If host driver is kernel driver, do nothing.
+        * Interrupt 0 is used for rx packets, but don't set
+        * I40E_VFINT_DYN_CTL01,
+        * because it is already done in i40evf_enable_irq0.
+        */
 
        I40EVF_WRITE_FLUSH(hw);
 }
@@ -1722,7 +1890,8 @@ i40evf_disable_queues_intr(struct rte_eth_dev *dev)
        struct rte_intr_handle *intr_handle = &dev->pci_dev->intr_handle;
 
        if (!rte_intr_allow_others(intr_handle)) {
-               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01, 0);
+               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01,
+                              I40E_VFINT_DYN_CTL01_ITR_INDX_MASK);
                I40EVF_WRITE_FLUSH(hw);
                return;
        }
@@ -1732,8 +1901,11 @@ i40evf_disable_queues_intr(struct rte_eth_dev *dev)
                               I40E_VFINT_DYN_CTLN1(I40EVF_VSI_DEFAULT_MSIX_INTR
                                                    - 1),
                               0);
-       else
-               I40E_WRITE_REG(hw, I40E_VFINT_DYN_CTL01, 0);
+       /* If host driver is kernel driver, do nothing.
+        * Interrupt 0 is used for rx packets, but don't zero
+        * I40E_VFINT_DYN_CTL01,
+        * because interrupt 0 is also used for adminq processing.
+        */
 
        I40EVF_WRITE_FLUSH(hw);
 }
@@ -1838,7 +2010,7 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add)
                           I40E_VIRTCHNL_OP_DEL_ETHER_ADDRESS;
                args.in_args = (uint8_t *)list;
                args.in_args_size = len;
-               args.out_buffer = cmd_result_buffer;
+               args.out_buffer = vf->aq_resp;
                args.out_size = I40E_AQ_BUF_SZ;
                err = i40evf_execute_vf_cmd(dev, &args);
                if (err)
@@ -1908,10 +2080,6 @@ i40evf_dev_start(struct rte_eth_dev *dev)
                goto err_mac;
        }
 
-       /* vf don't allow intr except for rxq intr */
-       if (dev->data->dev_conf.intr_conf.rxq != 0)
-               rte_intr_enable(intr_handle);
-
        i40evf_enable_queues_intr(dev);
        return 0;
 
@@ -1959,7 +2127,7 @@ i40evf_dev_link_update(struct rte_eth_dev *dev,
                /* Always assume it's up, for Linux driver PF host */
                new_link.link_duplex = ETH_LINK_AUTONEG_DUPLEX;
                new_link.link_speed  = ETH_LINK_SPEED_10000;
-               new_link.link_status = 1;
+               new_link.link_status = ETH_LINK_UP;
        }
        i40evf_dev_atomic_write_link_status(dev, &new_link);
 
@@ -2100,12 +2268,20 @@ static void
 i40evf_dev_close(struct rte_eth_dev *dev)
 {
        struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct rte_pci_device *pci_dev = dev->pci_dev;
 
        i40evf_dev_stop(dev);
        hw->adapter_stopped = 1;
        i40e_dev_free_queues(dev);
        i40evf_reset_vf(hw);
        i40e_shutdown_adminq(hw);
+       /* disable uio intr before callback unregister */
+       rte_intr_disable(&pci_dev->intr_handle);
+
+       /* unregister callback func from eal lib */
+       rte_intr_callback_unregister(&pci_dev->intr_handle,
+               i40evf_dev_interrupt_handler, (void *)dev);
+       i40evf_disable_irq0(hw);
 }
 
 static int