net/i40e: fix Rx packet statistics
[dpdk.git] / drivers / net / iavf / iavf_ethdev.c
index 887b8b0..5a5a7f5 100644 (file)
@@ -16,6 +16,7 @@
 #include <rte_interrupts.h>
 #include <rte_debug.h>
 #include <rte_pci.h>
+#include <rte_alarm.h>
 #include <rte_atomic.h>
 #include <rte_eal.h>
 #include <rte_ether.h>
@@ -675,7 +676,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
        if (!qv_map) {
                PMD_DRV_LOG(ERR, "Failed to allocate %d queue-vector map",
                                dev->data->nb_rx_queues);
-               return -1;
+               goto qv_map_alloc_err;
        }
 
        if (!dev->data->dev_conf.intr_conf.rxq ||
@@ -705,9 +706,9 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
                         */
                        vf->msix_base = IAVF_MISC_VEC_ID;
 
-                       /* set ITR to max */
+                       /* set ITR to default */
                        interval = iavf_calc_itr_interval(
-                                       IAVF_QUEUE_ITR_INTERVAL_MAX);
+                                       IAVF_QUEUE_ITR_INTERVAL_DEFAULT);
                        IAVF_WRITE_REG(hw, IAVF_VFINT_DYN_CTL01,
                                       IAVF_VFINT_DYN_CTL01_INTENA_MASK |
                                       (IAVF_ITR_INDEX_DEFAULT <<
@@ -760,7 +761,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
        if (!vf->lv_enabled) {
                if (iavf_config_irq_map(adapter)) {
                        PMD_DRV_LOG(ERR, "config interrupt mapping failed");
-                       return -1;
+                       goto config_irq_map_err;
                }
        } else {
                uint16_t num_qv_maps = dev->data->nb_rx_queues;
@@ -770,7 +771,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
                        if (iavf_config_irq_map_lv(adapter,
                                        IAVF_IRQ_MAP_NUM_PER_BUF, index)) {
                                PMD_DRV_LOG(ERR, "config interrupt mapping for large VF failed");
-                               return -1;
+                               goto config_irq_map_err;
                        }
                        num_qv_maps -= IAVF_IRQ_MAP_NUM_PER_BUF;
                        index += IAVF_IRQ_MAP_NUM_PER_BUF;
@@ -778,10 +779,20 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 
                if (iavf_config_irq_map_lv(adapter, num_qv_maps, index)) {
                        PMD_DRV_LOG(ERR, "config interrupt mapping for large VF failed");
-                       return -1;
+                       goto config_irq_map_err;
                }
        }
        return 0;
+
+config_irq_map_err:
+       rte_free(vf->qv_map);
+       vf->qv_map = NULL;
+
+qv_map_alloc_err:
+       rte_free(intr_handle->intr_vec);
+       intr_handle->intr_vec = NULL;
+
+       return -1;
 }
 
 static int
@@ -868,7 +879,8 @@ iavf_dev_start(struct rte_eth_dev *dev)
        }
        /* re-enable intr again, because efd assign may change */
        if (dev->data->dev_conf.intr_conf.rxq != 0) {
-               rte_intr_disable(intr_handle);
+               if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR)
+                       rte_intr_disable(intr_handle);
                rte_intr_enable(intr_handle);
        }
 
@@ -902,6 +914,10 @@ iavf_dev_stop(struct rte_eth_dev *dev)
 
        PMD_INIT_FUNC_TRACE();
 
+       if (!(vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) &&
+           dev->data->dev_conf.intr_conf.rxq != 0)
+               rte_intr_disable(intr_handle);
+
        if (adapter->stopped == 1)
                return 0;
 
@@ -1650,6 +1666,7 @@ iavf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
                IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct iavf_hw *hw = IAVF_DEV_PRIVATE_TO_HW(adapter);
+       struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);
        uint16_t msix_intr;
 
        msix_intr = pci_dev->intr_handle.intr_vec[queue_id];
@@ -1670,7 +1687,8 @@ iavf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
 
        IAVF_WRITE_FLUSH(hw);
 
-       rte_intr_ack(&pci_dev->intr_handle);
+       if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR)
+               rte_intr_ack(&pci_dev->intr_handle);
 
        return 0;
 }
@@ -2176,6 +2194,30 @@ err:
        return -1;
 }
 
+static void
+iavf_uninit_vf(struct rte_eth_dev *dev)
+{
+       struct iavf_hw *hw = IAVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
+
+       iavf_shutdown_adminq(hw);
+
+       rte_free(vf->vf_res);
+       vf->vsi_res = NULL;
+       vf->vf_res = NULL;
+
+       rte_free(vf->aq_resp);
+       vf->aq_resp = NULL;
+
+       rte_free(vf->qos_cap);
+       vf->qos_cap = NULL;
+
+       rte_free(vf->rss_lut);
+       vf->rss_lut = NULL;
+       rte_free(vf->rss_key);
+       vf->rss_key = NULL;
+}
+
 /* Enable default admin queue interrupt setting */
 static inline void
 iavf_enable_irq0(struct iavf_hw *hw)
@@ -2215,6 +2257,29 @@ iavf_dev_interrupt_handler(void *param)
        iavf_enable_irq0(hw);
 }
 
+void
+iavf_dev_alarm_handler(void *param)
+{
+       struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
+       struct iavf_hw *hw = IAVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+       uint32_t icr0;
+
+       iavf_disable_irq0(hw);
+
+       /* read out interrupt causes */
+       icr0 = IAVF_READ_REG(hw, IAVF_VFINT_ICR01);
+
+       if (icr0 & IAVF_VFINT_ICR01_ADMINQ_MASK) {
+               PMD_DRV_LOG(DEBUG, "ICR01_ADMINQ is reported");
+               iavf_handle_virtchnl_msg(dev);
+       }
+
+       iavf_enable_irq0(hw);
+
+       rte_eal_alarm_set(IAVF_ALARM_INTERVAL,
+                         iavf_dev_alarm_handler, dev);
+}
+
 static int
 iavf_dev_flow_ops_get(struct rte_eth_dev *dev,
                      const struct rte_flow_ops **ops)
@@ -2251,6 +2316,7 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
        struct iavf_adapter *adapter =
                IAVF_DEV_PRIVATE_TO_ADAPTER(eth_dev->data->dev_private);
        struct iavf_hw *hw = IAVF_DEV_PRIVATE_TO_HW(adapter);
+       struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
        int ret = 0;
 
@@ -2304,7 +2370,8 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
                PMD_INIT_LOG(ERR, "Failed to allocate %d bytes needed to"
                             " store MAC addresses",
                             RTE_ETHER_ADDR_LEN * IAVF_NUM_MACADDR_MAX);
-               return -ENOMEM;
+               ret = -ENOMEM;
+               goto init_vf_err;
        }
        /* If the MAC address is not configured by host,
         * generate a random one.
@@ -2315,13 +2382,18 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
        rte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr,
                        &eth_dev->data->mac_addrs[0]);
 
-       /* register callback func to eal lib */
-       rte_intr_callback_register(&pci_dev->intr_handle,
-                                  iavf_dev_interrupt_handler,
-                                  (void *)eth_dev);
+       if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) {
+               /* register callback func to eal lib */
+               rte_intr_callback_register(&pci_dev->intr_handle,
+                                          iavf_dev_interrupt_handler,
+                                          (void *)eth_dev);
 
-       /* enable uio intr after callback register */
-       rte_intr_enable(&pci_dev->intr_handle);
+               /* enable uio intr after callback register */
+               rte_intr_enable(&pci_dev->intr_handle);
+       } else {
+               rte_eal_alarm_set(IAVF_ALARM_INTERVAL,
+                                 iavf_dev_alarm_handler, eth_dev);
+       }
 
        /* configure and enable device interrupt */
        iavf_enable_irq0(hw);
@@ -2329,12 +2401,21 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
        ret = iavf_flow_init(adapter);
        if (ret) {
                PMD_INIT_LOG(ERR, "Failed to initialize flow");
-               return ret;
+               goto flow_init_err;
        }
 
        iavf_default_rss_disable(adapter);
 
        return 0;
+
+flow_init_err:
+       rte_free(eth_dev->data->mac_addrs);
+       eth_dev->data->mac_addrs = NULL;
+
+init_vf_err:
+       iavf_uninit_vf(eth_dev);
+
+       return ret;
 }
 
 static int
@@ -2365,12 +2446,16 @@ iavf_dev_close(struct rte_eth_dev *dev)
                iavf_config_promisc(adapter, false, false);
 
        iavf_shutdown_adminq(hw);
-       /* disable uio intr before callback unregister */
-       rte_intr_disable(intr_handle);
+       if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) {
+               /* disable uio intr before callback unregister */
+               rte_intr_disable(intr_handle);
 
-       /* unregister callback func from eal lib */
-       rte_intr_callback_unregister(intr_handle,
-                                    iavf_dev_interrupt_handler, dev);
+               /* unregister callback func from eal lib */
+               rte_intr_callback_unregister(intr_handle,
+                                            iavf_dev_interrupt_handler, dev);
+       } else {
+               rte_eal_alarm_cancel(iavf_dev_alarm_handler, dev);
+       }
        iavf_disable_irq0(hw);
 
        if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_QOS)
@@ -2472,58 +2557,10 @@ exit:
        return ret;
 }
 
-static int
-iavf_drv_i40evf_check_handler(__rte_unused const char *key,
-                             const char *value, __rte_unused void *opaque)
-{
-       if (strcmp(value, "i40evf"))
-               return -1;
-
-       return 0;
-}
-
-static int
-iavf_drv_i40evf_selected(struct rte_devargs *devargs, uint16_t device_id)
-{
-       struct rte_kvargs *kvlist;
-       int ret = 0;
-
-       if (device_id != IAVF_DEV_ID_VF &&
-           device_id != IAVF_DEV_ID_VF_HV &&
-           device_id != IAVF_DEV_ID_X722_VF &&
-           device_id != IAVF_DEV_ID_X722_A0_VF)
-               return 0;
-
-       if (devargs == NULL)
-               return 0;
-
-       kvlist = rte_kvargs_parse(devargs->args, NULL);
-       if (kvlist == NULL)
-               return 0;
-
-       if (!rte_kvargs_count(kvlist, RTE_DEVARGS_KEY_DRIVER))
-               goto exit;
-
-       /* i40evf driver selected when there's a key-value pair:
-        * driver=i40evf
-        */
-       if (rte_kvargs_process(kvlist, RTE_DEVARGS_KEY_DRIVER,
-                              iavf_drv_i40evf_check_handler, NULL) < 0)
-               goto exit;
-
-       ret = 1;
-
-exit:
-       rte_kvargs_free(kvlist);
-       return ret;
-}
-
 static int eth_iavf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
                             struct rte_pci_device *pci_dev)
 {
-       if (iavf_dcf_cap_selected(pci_dev->device.devargs) ||
-           iavf_drv_i40evf_selected(pci_dev->device.devargs,
-                                    pci_dev->id.device_id))
+       if (iavf_dcf_cap_selected(pci_dev->device.devargs))
                return 1;
 
        return rte_eth_dev_pci_generic_probe(pci_dev,
@@ -2546,7 +2583,7 @@ static struct rte_pci_driver rte_iavf_pmd = {
 RTE_PMD_REGISTER_PCI(net_iavf, rte_iavf_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_iavf, pci_id_iavf_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_iavf, "* igb_uio | vfio-pci");
-RTE_PMD_REGISTER_PARAM_STRING(net_iavf, "cap=dcf driver=i40evf");
+RTE_PMD_REGISTER_PARAM_STRING(net_iavf, "cap=dcf");
 RTE_LOG_REGISTER_SUFFIX(iavf_logtype_init, init, NOTICE);
 RTE_LOG_REGISTER_SUFFIX(iavf_logtype_driver, driver, NOTICE);
 #ifdef RTE_ETHDEV_DEBUG_RX