net/iavf: fix VLAN extraction in AVX512 path
[dpdk.git] / drivers / net / iavf / iavf_hash.c
index 780ec27..5d3d628 100644 (file)
@@ -12,7 +12,7 @@
 
 #include <rte_debug.h>
 #include <rte_ether.h>
-#include <rte_ethdev_driver.h>
+#include <ethdev_driver.h>
 #include <rte_log.h>
 #include <rte_malloc.h>
 #include <rte_eth_ctrl.h>
 #define IAVF_PHINT_GTPU_EH                     BIT_ULL(1)
 #define        IAVF_PHINT_GTPU_EH_DWN                  BIT_ULL(2)
 #define        IAVF_PHINT_GTPU_EH_UP                   BIT_ULL(3)
+#define IAVF_PHINT_OUTER_IPV4                  BIT_ULL(4)
+#define IAVF_PHINT_OUTER_IPV6                  BIT_ULL(5)
 
 #define IAVF_PHINT_GTPU_MSK    (IAVF_PHINT_GTPU        | \
                                 IAVF_PHINT_GTPU_EH     | \
                                 IAVF_PHINT_GTPU_EH_DWN | \
                                 IAVF_PHINT_GTPU_EH_UP)
 
+#define IAVF_PHINT_LAYERS_MSK  (IAVF_PHINT_OUTER_IPV4  | \
+                                IAVF_PHINT_OUTER_IPV6)
+
 #define IAVF_GTPU_EH_DWNLINK   0
 #define IAVF_GTPU_EH_UPLINK    1
 
@@ -96,11 +101,27 @@ iavf_hash_parse_pattern_action(struct iavf_adapter *ad,
        FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) | \
        FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST), {BUFF_NOUSED} }
 
+#define proto_hdr_ipv4_with_prot { \
+       VIRTCHNL_PROTO_HDR_IPV4, \
+       FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) | \
+       FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) | \
+       FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT), {BUFF_NOUSED} }
+
 #define proto_hdr_ipv6 { \
        VIRTCHNL_PROTO_HDR_IPV6, \
        FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) | \
        FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST), {BUFF_NOUSED} }
 
+#define proto_hdr_ipv6_frag { \
+       VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG, \
+       FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG_PKID), {BUFF_NOUSED} }
+
+#define proto_hdr_ipv6_with_prot { \
+       VIRTCHNL_PROTO_HDR_IPV6, \
+       FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) | \
+       FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) | \
+       FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT), {BUFF_NOUSED} }
+
 #define proto_hdr_udp { \
        VIRTCHNL_PROTO_HDR_UDP, \
        FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT) | \
@@ -135,6 +156,10 @@ iavf_hash_parse_pattern_action(struct iavf_adapter *ad,
 #define proto_hdr_gtpc { \
        VIRTCHNL_PROTO_HDR_GTPC, 0, {BUFF_NOUSED} }
 
+#define proto_hdr_ecpri { \
+       VIRTCHNL_PROTO_HDR_ECPRI, \
+       FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ECPRI_PC_RTC_ID), {BUFF_NOUSED} }
+
 #define TUNNEL_LEVEL_OUTER             0
 #define TUNNEL_LEVEL_INNER             1
 
@@ -146,13 +171,15 @@ struct virtchnl_proto_hdrs outer_ipv4_tmplt = {
 
 struct virtchnl_proto_hdrs outer_ipv4_udp_tmplt = {
        TUNNEL_LEVEL_OUTER, 5,
-       {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv4,
+       {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
+        proto_hdr_ipv4_with_prot,
         proto_hdr_udp}
 };
 
 struct virtchnl_proto_hdrs outer_ipv4_tcp_tmplt = {
        TUNNEL_LEVEL_OUTER, 5,
-       {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv4,
+       {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
+        proto_hdr_ipv4_with_prot,
         proto_hdr_tcp}
 };
 
@@ -167,15 +194,23 @@ struct virtchnl_proto_hdrs outer_ipv6_tmplt = {
        {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv6}
 };
 
+struct virtchnl_proto_hdrs outer_ipv6_frag_tmplt = {
+       TUNNEL_LEVEL_OUTER, 5,
+       {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
+        proto_hdr_ipv6, proto_hdr_ipv6_frag}
+};
+
 struct virtchnl_proto_hdrs outer_ipv6_udp_tmplt = {
        TUNNEL_LEVEL_OUTER, 5,
-       {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv6,
+       {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
+        proto_hdr_ipv6_with_prot,
         proto_hdr_udp}
 };
 
 struct virtchnl_proto_hdrs outer_ipv6_tcp_tmplt = {
        TUNNEL_LEVEL_OUTER, 5,
-       {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv6,
+       {proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
+        proto_hdr_ipv6_with_prot,
         proto_hdr_tcp}
 };
 
@@ -190,11 +225,11 @@ struct virtchnl_proto_hdrs inner_ipv4_tmplt = {
 };
 
 struct virtchnl_proto_hdrs inner_ipv4_udp_tmplt = {
-       TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4, proto_hdr_udp}
+       TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4_with_prot, proto_hdr_udp}
 };
 
 struct virtchnl_proto_hdrs inner_ipv4_tcp_tmplt = {
-       TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4, proto_hdr_tcp}
+       TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4_with_prot, proto_hdr_tcp}
 };
 
 struct virtchnl_proto_hdrs inner_ipv4_sctp_tmplt = {
@@ -206,11 +241,11 @@ struct virtchnl_proto_hdrs inner_ipv6_tmplt = {
 };
 
 struct virtchnl_proto_hdrs inner_ipv6_udp_tmplt = {
-       TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6, proto_hdr_udp}
+       TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6_with_prot, proto_hdr_udp}
 };
 
 struct virtchnl_proto_hdrs inner_ipv6_tcp_tmplt = {
-       TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6, proto_hdr_tcp}
+       TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6_with_prot, proto_hdr_tcp}
 };
 
 struct virtchnl_proto_hdrs inner_ipv6_sctp_tmplt = {
@@ -267,10 +302,19 @@ struct virtchnl_proto_hdrs ipv6_udp_gtpc_tmplt = {
        TUNNEL_LEVEL_OUTER, 3, {proto_hdr_ipv6, proto_hdr_udp, proto_hdr_gtpc}
 };
 
+struct virtchnl_proto_hdrs eth_ecpri_tmplt = {
+       TUNNEL_LEVEL_OUTER, 2, {proto_hdr_eth, proto_hdr_ecpri}
+};
+
+struct virtchnl_proto_hdrs ipv4_ecpri_tmplt = {
+       TUNNEL_LEVEL_OUTER, 3, {proto_hdr_ipv4, proto_hdr_udp, proto_hdr_ecpri}
+};
+
 /* rss type super set */
 
 /* IPv4 outer */
-#define IAVF_RSS_TYPE_OUTER_IPV4       (ETH_RSS_ETH | ETH_RSS_IPV4)
+#define IAVF_RSS_TYPE_OUTER_IPV4       (ETH_RSS_ETH | ETH_RSS_IPV4 | \
+                                        ETH_RSS_FRAG_IPV4)
 #define IAVF_RSS_TYPE_OUTER_IPV4_UDP   (IAVF_RSS_TYPE_OUTER_IPV4 | \
                                         ETH_RSS_NONFRAG_IPV4_UDP)
 #define IAVF_RSS_TYPE_OUTER_IPV4_TCP   (IAVF_RSS_TYPE_OUTER_IPV4 | \
@@ -279,6 +323,8 @@ struct virtchnl_proto_hdrs ipv6_udp_gtpc_tmplt = {
                                         ETH_RSS_NONFRAG_IPV4_SCTP)
 /* IPv6 outer */
 #define IAVF_RSS_TYPE_OUTER_IPV6       (ETH_RSS_ETH | ETH_RSS_IPV6)
+#define IAVF_RSS_TYPE_OUTER_IPV6_FRAG  (IAVF_RSS_TYPE_OUTER_IPV6 | \
+                                        ETH_RSS_FRAG_IPV6)
 #define IAVF_RSS_TYPE_OUTER_IPV6_UDP   (IAVF_RSS_TYPE_OUTER_IPV6 | \
                                         ETH_RSS_NONFRAG_IPV6_UDP)
 #define IAVF_RSS_TYPE_OUTER_IPV6_TCP   (IAVF_RSS_TYPE_OUTER_IPV6 | \
@@ -297,6 +343,8 @@ struct virtchnl_proto_hdrs ipv6_udp_gtpc_tmplt = {
 /* VLAN IPv6 */
 #define IAVF_RSS_TYPE_VLAN_IPV6                (IAVF_RSS_TYPE_OUTER_IPV6 | \
                                         ETH_RSS_S_VLAN | ETH_RSS_C_VLAN)
+#define IAVF_RSS_TYPE_VLAN_IPV6_FRAG   (IAVF_RSS_TYPE_OUTER_IPV6_FRAG | \
+                                        ETH_RSS_S_VLAN | ETH_RSS_C_VLAN)
 #define IAVF_RSS_TYPE_VLAN_IPV6_UDP    (IAVF_RSS_TYPE_OUTER_IPV6_UDP | \
                                         ETH_RSS_S_VLAN | ETH_RSS_C_VLAN)
 #define IAVF_RSS_TYPE_VLAN_IPV6_TCP    (IAVF_RSS_TYPE_OUTER_IPV6_TCP | \
@@ -359,6 +407,7 @@ static struct iavf_pattern_match_item iavf_hash_pattern_list[] = {
        {iavf_pattern_eth_vlan_ipv4_udp,                IAVF_RSS_TYPE_VLAN_IPV4_UDP,    &outer_ipv4_udp_tmplt},
        {iavf_pattern_eth_vlan_ipv4_tcp,                IAVF_RSS_TYPE_VLAN_IPV4_TCP,    &outer_ipv4_tcp_tmplt},
        {iavf_pattern_eth_vlan_ipv4_sctp,               IAVF_RSS_TYPE_VLAN_IPV4_SCTP,   &outer_ipv4_sctp_tmplt},
+       {iavf_pattern_eth_ipv4_gtpu,                    ETH_RSS_IPV4,                   &outer_ipv4_udp_tmplt},
        {iavf_pattern_eth_ipv4_gtpu_ipv4,               IAVF_RSS_TYPE_GTPU_IPV4,        &inner_ipv4_tmplt},
        {iavf_pattern_eth_ipv4_gtpu_ipv4_udp,           IAVF_RSS_TYPE_GTPU_IPV4_UDP,    &inner_ipv4_udp_tmplt},
        {iavf_pattern_eth_ipv4_gtpu_ipv4_tcp,           IAVF_RSS_TYPE_GTPU_IPV4_TCP,    &inner_ipv4_tcp_tmplt},
@@ -377,15 +426,20 @@ static struct iavf_pattern_match_item iavf_hash_pattern_list[] = {
        {iavf_pattern_eth_ipv4_l2tpv3,                  IAVF_RSS_TYPE_IPV4_L2TPV3,      &ipv4_l2tpv3_tmplt},
        {iavf_pattern_eth_ipv4_pfcp,                    IAVF_RSS_TYPE_IPV4_PFCP,        &ipv4_pfcp_tmplt},
        {iavf_pattern_eth_ipv4_gtpc,                    ETH_RSS_IPV4,                   &ipv4_udp_gtpc_tmplt},
+       {iavf_pattern_eth_ecpri,                        ETH_RSS_ECPRI,                  &eth_ecpri_tmplt},
+       {iavf_pattern_eth_ipv4_ecpri,                   ETH_RSS_ECPRI,                  &ipv4_ecpri_tmplt},
        /* IPv6 */
        {iavf_pattern_eth_ipv6,                         IAVF_RSS_TYPE_OUTER_IPV6,       &outer_ipv6_tmplt},
+       {iavf_pattern_eth_ipv6_frag_ext,                IAVF_RSS_TYPE_OUTER_IPV6_FRAG,  &outer_ipv6_frag_tmplt},
        {iavf_pattern_eth_ipv6_udp,                     IAVF_RSS_TYPE_OUTER_IPV6_UDP,   &outer_ipv6_udp_tmplt},
        {iavf_pattern_eth_ipv6_tcp,                     IAVF_RSS_TYPE_OUTER_IPV6_TCP,   &outer_ipv6_tcp_tmplt},
        {iavf_pattern_eth_ipv6_sctp,                    IAVF_RSS_TYPE_OUTER_IPV6_SCTP,  &outer_ipv6_sctp_tmplt},
        {iavf_pattern_eth_vlan_ipv6,                    IAVF_RSS_TYPE_VLAN_IPV6,        &outer_ipv6_tmplt},
+       {iavf_pattern_eth_vlan_ipv6_frag_ext,           IAVF_RSS_TYPE_OUTER_IPV6_FRAG,  &outer_ipv6_frag_tmplt},
        {iavf_pattern_eth_vlan_ipv6_udp,                IAVF_RSS_TYPE_VLAN_IPV6_UDP,    &outer_ipv6_udp_tmplt},
        {iavf_pattern_eth_vlan_ipv6_tcp,                IAVF_RSS_TYPE_VLAN_IPV6_TCP,    &outer_ipv6_tcp_tmplt},
        {iavf_pattern_eth_vlan_ipv6_sctp,               IAVF_RSS_TYPE_VLAN_IPV6_SCTP,   &outer_ipv6_sctp_tmplt},
+       {iavf_pattern_eth_ipv6_gtpu,                    ETH_RSS_IPV6,                   &outer_ipv6_udp_tmplt},
        {iavf_pattern_eth_ipv4_gtpu_ipv6,               IAVF_RSS_TYPE_GTPU_IPV6,        &inner_ipv6_tmplt},
        {iavf_pattern_eth_ipv4_gtpu_ipv6_udp,           IAVF_RSS_TYPE_GTPU_IPV6_UDP,    &inner_ipv6_udp_tmplt},
        {iavf_pattern_eth_ipv4_gtpu_ipv6_tcp,           IAVF_RSS_TYPE_GTPU_IPV6_TCP,    &inner_ipv6_tcp_tmplt},
@@ -406,17 +460,6 @@ static struct iavf_pattern_match_item iavf_hash_pattern_list[] = {
        {iavf_pattern_eth_ipv6_gtpc,                    ETH_RSS_IPV6,                   &ipv6_udp_gtpc_tmplt},
 };
 
-struct virtchnl_proto_hdrs *iavf_hash_default_hdrs[] = {
-       &inner_ipv4_tmplt,
-       &inner_ipv4_udp_tmplt,
-       &inner_ipv4_tcp_tmplt,
-       &inner_ipv4_sctp_tmplt,
-       &inner_ipv6_tmplt,
-       &inner_ipv6_udp_tmplt,
-       &inner_ipv6_tcp_tmplt,
-       &inner_ipv6_sctp_tmplt,
-};
-
 static struct iavf_flow_engine iavf_hash_engine = {
        .init = iavf_hash_init,
        .create = iavf_hash_create,
@@ -435,24 +478,64 @@ static struct iavf_flow_parser iavf_hash_parser = {
        .stage = IAVF_FLOW_STAGE_RSS,
 };
 
-static int
-iavf_hash_default_set(struct iavf_adapter *ad, bool add)
+int
+iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add)
 {
-       struct virtchnl_rss_cfg *rss_cfg;
-       uint16_t i;
+       struct iavf_info *vf =  IAVF_DEV_PRIVATE_TO_VF(ad);
+       struct virtchnl_rss_cfg rss_cfg;
+
+#define IAVF_RSS_HF_ALL ( \
+       ETH_RSS_IPV4 | \
+       ETH_RSS_IPV6 | \
+       ETH_RSS_NONFRAG_IPV4_UDP | \
+       ETH_RSS_NONFRAG_IPV6_UDP | \
+       ETH_RSS_NONFRAG_IPV4_TCP | \
+       ETH_RSS_NONFRAG_IPV6_TCP | \
+       ETH_RSS_NONFRAG_IPV4_SCTP | \
+       ETH_RSS_NONFRAG_IPV6_SCTP)
+
+       rss_cfg.rss_algorithm = VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC;
+       if (rss_hf & ETH_RSS_IPV4) {
+               rss_cfg.proto_hdrs = inner_ipv4_tmplt;
+               iavf_add_del_rss_cfg(ad, &rss_cfg, add);
+       }
 
-       rss_cfg = rte_zmalloc("iavf rss rule",
-                             sizeof(struct virtchnl_rss_cfg), 0);
-       if (!rss_cfg)
-               return -ENOMEM;
+       if (rss_hf & ETH_RSS_NONFRAG_IPV4_UDP) {
+               rss_cfg.proto_hdrs = inner_ipv4_udp_tmplt;
+               iavf_add_del_rss_cfg(ad, &rss_cfg, add);
+       }
+
+       if (rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) {
+               rss_cfg.proto_hdrs = inner_ipv4_tcp_tmplt;
+               iavf_add_del_rss_cfg(ad, &rss_cfg, add);
+       }
+
+       if (rss_hf & ETH_RSS_NONFRAG_IPV4_SCTP) {
+               rss_cfg.proto_hdrs = inner_ipv4_sctp_tmplt;
+               iavf_add_del_rss_cfg(ad, &rss_cfg, add);
+       }
+
+       if (rss_hf & ETH_RSS_IPV6) {
+               rss_cfg.proto_hdrs = inner_ipv6_tmplt;
+               iavf_add_del_rss_cfg(ad, &rss_cfg, add);
+       }
+
+       if (rss_hf & ETH_RSS_NONFRAG_IPV6_UDP) {
+               rss_cfg.proto_hdrs = inner_ipv6_udp_tmplt;
+               iavf_add_del_rss_cfg(ad, &rss_cfg, add);
+       }
 
-       for (i = 0; i < RTE_DIM(iavf_hash_default_hdrs); i++) {
-               rss_cfg->proto_hdrs = *iavf_hash_default_hdrs[i];
-               rss_cfg->rss_algorithm = VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC;
+       if (rss_hf & ETH_RSS_NONFRAG_IPV6_TCP) {
+               rss_cfg.proto_hdrs = inner_ipv6_tcp_tmplt;
+               iavf_add_del_rss_cfg(ad, &rss_cfg, add);
+       }
 
-               iavf_add_del_rss_cfg(ad, rss_cfg, add);
+       if (rss_hf & ETH_RSS_NONFRAG_IPV6_SCTP) {
+               rss_cfg.proto_hdrs = inner_ipv6_sctp_tmplt;
+               iavf_add_del_rss_cfg(ad, &rss_cfg, add);
        }
 
+       vf->rss_hf = rss_hf & IAVF_RSS_HF_ALL;
        return 0;
 }
 
@@ -487,22 +570,17 @@ iavf_hash_init(struct iavf_adapter *ad)
                return ret;
        }
 
-       ret = iavf_hash_default_set(ad, true);
-       if (ret) {
-               PMD_DRV_LOG(ERR, "fail to set default RSS");
-               iavf_unregister_parser(parser, ad);
-       }
-
        return ret;
 }
 
 static int
-iavf_hash_parse_pattern(struct iavf_pattern_match_item *pattern_match_item,
-                       const struct rte_flow_item pattern[], uint64_t *phint,
+iavf_hash_parse_pattern(const struct rte_flow_item pattern[], uint64_t *phint,
                        struct rte_flow_error *error)
 {
        const struct rte_flow_item *item = pattern;
        const struct rte_flow_item_gtp_psc *psc;
+       const struct rte_flow_item_ecpri *ecpri;
+       struct rte_ecpri_common_hdr ecpri_common;
 
        for (item = pattern; item->type != RTE_FLOW_ITEM_TYPE_END; item++) {
                if (item->last) {
@@ -513,6 +591,14 @@ iavf_hash_parse_pattern(struct iavf_pattern_match_item *pattern_match_item,
                }
 
                switch (item->type) {
+               case RTE_FLOW_ITEM_TYPE_IPV4:
+                       if (!(*phint & IAVF_PHINT_GTPU_MSK))
+                               *phint |= IAVF_PHINT_OUTER_IPV4;
+                       break;
+               case RTE_FLOW_ITEM_TYPE_IPV6:
+                       if (!(*phint & IAVF_PHINT_GTPU_MSK))
+                               *phint |= IAVF_PHINT_OUTER_IPV6;
+                       break;
                case RTE_FLOW_ITEM_TYPE_GTPU:
                        *phint |= IAVF_PHINT_GTPU;
                        break;
@@ -526,17 +612,60 @@ iavf_hash_parse_pattern(struct iavf_pattern_match_item *pattern_match_item,
                        else if (psc->pdu_type == IAVF_GTPU_EH_DWNLINK)
                                *phint |= IAVF_PHINT_GTPU_EH_DWN;
                        break;
+               case RTE_FLOW_ITEM_TYPE_ECPRI:
+                       ecpri = item->spec;
+                       if (!ecpri)
+                               break;
+
+                       ecpri_common.u32 = rte_be_to_cpu_32(ecpri->hdr.common.u32);
+
+                       if (ecpri_common.type !=
+                                RTE_ECPRI_MSG_TYPE_IQ_DATA) {
+                               rte_flow_error_set(error, EINVAL,
+                                       RTE_FLOW_ERROR_TYPE_ITEM, item,
+                                       "Unsupported common type.");
+                               return -rte_errno;
+                       }
+                       break;
                default:
                        break;
                }
        }
 
-       /* update and restore pattern hint */
-       *phint |= *(uint64_t *)(pattern_match_item->meta);
-
        return 0;
 }
 
+#define REFINE_PROTO_FLD(op, fld) \
+       VIRTCHNL_##op##_PROTO_HDR_FIELD(hdr, VIRTCHNL_PROTO_HDR_##fld)
+#define REPALCE_PROTO_FLD(fld_1, fld_2) \
+do { \
+       REFINE_PROTO_FLD(DEL, fld_1);   \
+       REFINE_PROTO_FLD(ADD, fld_2);   \
+} while (0)
+
+static void
+iavf_hash_add_fragment_hdr(struct virtchnl_proto_hdrs *hdrs, int layer)
+{
+       struct virtchnl_proto_hdr *hdr1;
+       struct virtchnl_proto_hdr *hdr2;
+       int i;
+
+       if (layer < 0 || layer > hdrs->count)
+               return;
+
+       /* shift headers layer */
+       for (i = hdrs->count; i >= layer; i--) {
+               hdr1 = &hdrs->proto_hdr[i];
+               hdr2 = &hdrs->proto_hdr[i - 1];
+               *hdr1 = *hdr2;
+       }
+
+       /* adding dummy fragment header */
+       hdr1 = &hdrs->proto_hdr[layer];
+       VIRTCHNL_SET_PROTO_HDR_TYPE(hdr1, IPV4_FRAG);
+       hdrs->count = ++layer;
+}
+
 /* refine proto hdrs base on l2, l3, l4 rss type */
 static void
 iavf_refine_proto_hdrs_l234(struct virtchnl_proto_hdrs *proto_hdrs,
@@ -552,62 +681,87 @@ iavf_refine_proto_hdrs_l234(struct virtchnl_proto_hdrs *proto_hdrs,
                        if (!(rss_type & ETH_RSS_ETH))
                                hdr->field_selector = 0;
                        else if (rss_type & ETH_RSS_L2_SRC_ONLY)
-                               VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                       VIRTCHNL_PROTO_HDR_ETH_DST);
+                               REFINE_PROTO_FLD(DEL, ETH_DST);
                        else if (rss_type & ETH_RSS_L2_DST_ONLY)
-                               VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                       VIRTCHNL_PROTO_HDR_ETH_SRC);
+                               REFINE_PROTO_FLD(DEL, ETH_SRC);
                        break;
                case VIRTCHNL_PROTO_HDR_IPV4:
                        if (rss_type &
-                           (ETH_RSS_IPV4 |
+                           (ETH_RSS_IPV4 | ETH_RSS_FRAG_IPV4 |
                             ETH_RSS_NONFRAG_IPV4_UDP |
                             ETH_RSS_NONFRAG_IPV4_TCP |
                             ETH_RSS_NONFRAG_IPV4_SCTP)) {
-                               if (rss_type & ETH_RSS_L3_SRC_ONLY)
-                                       VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                               VIRTCHNL_PROTO_HDR_IPV4_DST);
-                               else if (rss_type & ETH_RSS_L3_DST_ONLY)
-                                       VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                               VIRTCHNL_PROTO_HDR_IPV4_SRC);
-                               else if (rss_type &
-                                        (ETH_RSS_L4_SRC_ONLY |
-                                         ETH_RSS_L4_DST_ONLY))
-                                       hdr->field_selector = 0;
+                               if (rss_type & ETH_RSS_FRAG_IPV4) {
+                                       iavf_hash_add_fragment_hdr(proto_hdrs, i + 1);
+                               } else if (rss_type & ETH_RSS_L3_SRC_ONLY) {
+                                       REFINE_PROTO_FLD(DEL, IPV4_DST);
+                               } else if (rss_type & ETH_RSS_L3_DST_ONLY) {
+                                       REFINE_PROTO_FLD(DEL, IPV4_SRC);
+                               } else if (rss_type &
+                                          (ETH_RSS_L4_SRC_ONLY |
+                                           ETH_RSS_L4_DST_ONLY)) {
+                                       REFINE_PROTO_FLD(DEL, IPV4_DST);
+                                       REFINE_PROTO_FLD(DEL, IPV4_SRC);
+                               }
+                       } else {
+                               hdr->field_selector = 0;
+                       }
+                       break;
+               case VIRTCHNL_PROTO_HDR_IPV4_FRAG:
+                       if (rss_type &
+                           (ETH_RSS_IPV4 | ETH_RSS_FRAG_IPV4 |
+                            ETH_RSS_NONFRAG_IPV4_UDP |
+                            ETH_RSS_NONFRAG_IPV4_TCP |
+                            ETH_RSS_NONFRAG_IPV4_SCTP)) {
+                               if (rss_type & ETH_RSS_FRAG_IPV4)
+                                       REFINE_PROTO_FLD(ADD, IPV4_FRAG_PKID);
                        } else {
                                hdr->field_selector = 0;
                        }
                        break;
                case VIRTCHNL_PROTO_HDR_IPV6:
                        if (rss_type &
-                           (ETH_RSS_IPV6 |
+                           (ETH_RSS_IPV6 | ETH_RSS_FRAG_IPV6 |
                             ETH_RSS_NONFRAG_IPV6_UDP |
                             ETH_RSS_NONFRAG_IPV6_TCP |
                             ETH_RSS_NONFRAG_IPV6_SCTP)) {
-                               if (rss_type & ETH_RSS_L3_SRC_ONLY)
-                                       VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                               VIRTCHNL_PROTO_HDR_IPV6_DST);
-                               else if (rss_type & ETH_RSS_L3_DST_ONLY)
-                                       VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                               VIRTCHNL_PROTO_HDR_IPV6_SRC);
-                               else if (rss_type &
-                                        (ETH_RSS_L4_SRC_ONLY |
-                                         ETH_RSS_L4_DST_ONLY))
-                                       hdr->field_selector = 0;
+                               if (rss_type & ETH_RSS_L3_SRC_ONLY) {
+                                       REFINE_PROTO_FLD(DEL, IPV6_DST);
+                               } else if (rss_type & ETH_RSS_L3_DST_ONLY) {
+                                       REFINE_PROTO_FLD(DEL, IPV6_SRC);
+                               } else if (rss_type &
+                                          (ETH_RSS_L4_SRC_ONLY |
+                                           ETH_RSS_L4_DST_ONLY)) {
+                                       REFINE_PROTO_FLD(DEL, IPV6_DST);
+                                       REFINE_PROTO_FLD(DEL, IPV6_SRC);
+                               }
                        } else {
                                hdr->field_selector = 0;
                        }
+                       if (rss_type & RTE_ETH_RSS_L3_PRE64) {
+                               if (REFINE_PROTO_FLD(TEST, IPV6_SRC))
+                                       REPALCE_PROTO_FLD(IPV6_SRC,
+                                                         IPV6_PREFIX64_SRC);
+                               if (REFINE_PROTO_FLD(TEST, IPV6_DST))
+                                       REPALCE_PROTO_FLD(IPV6_DST,
+                                                         IPV6_PREFIX64_DST);
+                       }
+                       break;
+               case VIRTCHNL_PROTO_HDR_IPV6_EH_FRAG:
+                       if (rss_type & ETH_RSS_FRAG_IPV6)
+                               REFINE_PROTO_FLD(ADD, IPV6_EH_FRAG_PKID);
+                       else
+                               hdr->field_selector = 0;
+
                        break;
                case VIRTCHNL_PROTO_HDR_UDP:
                        if (rss_type &
                            (ETH_RSS_NONFRAG_IPV4_UDP |
                             ETH_RSS_NONFRAG_IPV6_UDP)) {
                                if (rss_type & ETH_RSS_L4_SRC_ONLY)
-                                       VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                           VIRTCHNL_PROTO_HDR_UDP_DST_PORT);
+                                       REFINE_PROTO_FLD(DEL, UDP_DST_PORT);
                                else if (rss_type & ETH_RSS_L4_DST_ONLY)
-                                       VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                           VIRTCHNL_PROTO_HDR_UDP_SRC_PORT);
+                                       REFINE_PROTO_FLD(DEL, UDP_SRC_PORT);
                                else if (rss_type &
                                         (ETH_RSS_L3_SRC_ONLY |
                                          ETH_RSS_L3_DST_ONLY))
@@ -621,11 +775,9 @@ iavf_refine_proto_hdrs_l234(struct virtchnl_proto_hdrs *proto_hdrs,
                            (ETH_RSS_NONFRAG_IPV4_TCP |
                             ETH_RSS_NONFRAG_IPV6_TCP)) {
                                if (rss_type & ETH_RSS_L4_SRC_ONLY)
-                                       VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                           VIRTCHNL_PROTO_HDR_TCP_DST_PORT);
+                                       REFINE_PROTO_FLD(DEL, TCP_DST_PORT);
                                else if (rss_type & ETH_RSS_L4_DST_ONLY)
-                                       VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                           VIRTCHNL_PROTO_HDR_TCP_SRC_PORT);
+                                       REFINE_PROTO_FLD(DEL, TCP_SRC_PORT);
                                else if (rss_type &
                                         (ETH_RSS_L3_SRC_ONLY |
                                          ETH_RSS_L3_DST_ONLY))
@@ -639,11 +791,9 @@ iavf_refine_proto_hdrs_l234(struct virtchnl_proto_hdrs *proto_hdrs,
                            (ETH_RSS_NONFRAG_IPV4_SCTP |
                             ETH_RSS_NONFRAG_IPV6_SCTP)) {
                                if (rss_type & ETH_RSS_L4_SRC_ONLY)
-                                       VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                           VIRTCHNL_PROTO_HDR_SCTP_DST_PORT);
+                                       REFINE_PROTO_FLD(DEL, SCTP_DST_PORT);
                                else if (rss_type & ETH_RSS_L4_DST_ONLY)
-                                       VIRTCHNL_DEL_PROTO_HDR_FIELD(hdr,
-                                           VIRTCHNL_PROTO_HDR_TCP_SRC_PORT);
+                                       REFINE_PROTO_FLD(DEL, SCTP_SRC_PORT);
                                else if (rss_type &
                                         (ETH_RSS_L3_SRC_ONLY |
                                          ETH_RSS_L3_DST_ONLY))
@@ -676,6 +826,10 @@ iavf_refine_proto_hdrs_l234(struct virtchnl_proto_hdrs *proto_hdrs,
                        if (!(rss_type & ETH_RSS_PFCP))
                                hdr->field_selector = 0;
                        break;
+               case VIRTCHNL_PROTO_HDR_ECPRI:
+                       if (!(rss_type & ETH_RSS_ECPRI))
+                               hdr->field_selector = 0;
+                       break;
                default:
                        break;
                }
@@ -697,8 +851,7 @@ iavf_refine_proto_hdrs_gtpu(struct virtchnl_proto_hdrs *proto_hdrs,
                hdr = &proto_hdrs->proto_hdr[i];
                switch (hdr->type) {
                case VIRTCHNL_PROTO_HDR_GTPU_IP:
-                       VIRTCHNL_ADD_PROTO_HDR_FIELD(hdr,
-                               VIRTCHNL_PROTO_HDR_GTPU_IP_TEID);
+                       REFINE_PROTO_FLD(ADD, GTPU_IP_TEID);
                        break;
                default:
                        break;
@@ -712,24 +865,45 @@ iavf_refine_proto_hdrs_by_pattern(struct virtchnl_proto_hdrs *proto_hdrs,
 {
        struct virtchnl_proto_hdr *hdr1;
        struct virtchnl_proto_hdr *hdr2;
-       int i;
+       int i, shift_count = 1;
 
-       if (!(phint & IAVF_PHINT_GTPU_MSK) ||
-           proto_hdrs->tunnel_level == 0)
+       if (!(phint & IAVF_PHINT_GTPU_MSK))
                return;
 
-       /* shift headers 1 layer */
-       for (i = proto_hdrs->count; i > 0; i--) {
-               hdr1 = &proto_hdrs->proto_hdr[i];
-               hdr2 = &proto_hdrs->proto_hdr[i - 1];
+       if (phint & IAVF_PHINT_LAYERS_MSK)
+               shift_count++;
 
-               *hdr1 = *hdr2;
+       if (proto_hdrs->tunnel_level == TUNNEL_LEVEL_INNER) {
+               /* shift headers layer */
+               for (i = proto_hdrs->count - 1 + shift_count;
+                    i > shift_count - 1; i--) {
+                       hdr1 = &proto_hdrs->proto_hdr[i];
+                       hdr2 = &proto_hdrs->proto_hdr[i - shift_count];
+                       *hdr1 = *hdr2;
+               }
+
+               if (shift_count == 1) {
+                       /* adding gtpu header at layer 0 */
+                       hdr1 = &proto_hdrs->proto_hdr[0];
+               } else {
+                       /* adding gtpu header and outer ip header */
+                       hdr1 = &proto_hdrs->proto_hdr[1];
+                       hdr2 = &proto_hdrs->proto_hdr[0];
+                       hdr2->field_selector = 0;
+                       proto_hdrs->count++;
+                       proto_hdrs->tunnel_level = TUNNEL_LEVEL_OUTER;
+
+                       if (phint & IAVF_PHINT_OUTER_IPV4)
+                               VIRTCHNL_SET_PROTO_HDR_TYPE(hdr2, IPV4);
+                       else if (phint & IAVF_PHINT_OUTER_IPV6)
+                               VIRTCHNL_SET_PROTO_HDR_TYPE(hdr2, IPV6);
+               }
+       } else {
+               hdr1 = &proto_hdrs->proto_hdr[proto_hdrs->count];
        }
 
-       /* adding gtpu header at layer 0 */
-       proto_hdrs->count++;
-       hdr1 = &proto_hdrs->proto_hdr[0];
        hdr1->field_selector = 0;
+       proto_hdrs->count++;
 
        if (phint & IAVF_PHINT_GTPU_EH_DWN)
                VIRTCHNL_SET_PROTO_HDR_TYPE(hdr1, GTPU_EH_PDU_DWN);
@@ -751,38 +925,96 @@ static void iavf_refine_proto_hdrs(struct virtchnl_proto_hdrs *proto_hdrs,
 
 static uint64_t invalid_rss_comb[] = {
        ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_UDP,
+       ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP,
        ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_UDP,
+       ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP,
        RTE_ETH_RSS_L3_PRE32 | RTE_ETH_RSS_L3_PRE40 |
        RTE_ETH_RSS_L3_PRE48 | RTE_ETH_RSS_L3_PRE56 |
        RTE_ETH_RSS_L3_PRE96
 };
 
+struct rss_attr_type {
+       uint64_t attr;
+       uint64_t type;
+};
+
+#define VALID_RSS_IPV4_L4      (ETH_RSS_NONFRAG_IPV4_UDP       | \
+                                ETH_RSS_NONFRAG_IPV4_TCP       | \
+                                ETH_RSS_NONFRAG_IPV4_SCTP)
+
+#define VALID_RSS_IPV6_L4      (ETH_RSS_NONFRAG_IPV6_UDP       | \
+                                ETH_RSS_NONFRAG_IPV6_TCP       | \
+                                ETH_RSS_NONFRAG_IPV6_SCTP)
+
+#define VALID_RSS_IPV4         (ETH_RSS_IPV4 | ETH_RSS_FRAG_IPV4 | \
+                                VALID_RSS_IPV4_L4)
+#define VALID_RSS_IPV6         (ETH_RSS_IPV6 | ETH_RSS_FRAG_IPV6 | \
+                                VALID_RSS_IPV6_L4)
+#define VALID_RSS_L3           (VALID_RSS_IPV4 | VALID_RSS_IPV6)
+#define VALID_RSS_L4           (VALID_RSS_IPV4_L4 | VALID_RSS_IPV6_L4)
+
+#define VALID_RSS_ATTR         (ETH_RSS_L3_SRC_ONLY    | \
+                                ETH_RSS_L3_DST_ONLY    | \
+                                ETH_RSS_L4_SRC_ONLY    | \
+                                ETH_RSS_L4_DST_ONLY    | \
+                                ETH_RSS_L2_SRC_ONLY    | \
+                                ETH_RSS_L2_DST_ONLY    | \
+                                RTE_ETH_RSS_L3_PRE64)
+
+#define INVALID_RSS_ATTR       (RTE_ETH_RSS_L3_PRE32   | \
+                                RTE_ETH_RSS_L3_PRE40   | \
+                                RTE_ETH_RSS_L3_PRE48   | \
+                                RTE_ETH_RSS_L3_PRE56   | \
+                                RTE_ETH_RSS_L3_PRE96)
+
+static struct rss_attr_type rss_attr_to_valid_type[] = {
+       {ETH_RSS_L2_SRC_ONLY | ETH_RSS_L2_DST_ONLY,     ETH_RSS_ETH},
+       {ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY,     VALID_RSS_L3},
+       {ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY,     VALID_RSS_L4},
+       /* current ipv6 prefix only supports prefix 64 bits*/
+       {RTE_ETH_RSS_L3_PRE64,                          VALID_RSS_IPV6},
+       {INVALID_RSS_ATTR,                              0}
+};
+
 static bool
-iavf_any_invalid_rss_type(uint64_t rss_type, uint64_t allow_rss_type)
+iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func,
+                         uint64_t rss_type, uint64_t allow_rss_type)
 {
        uint32_t i;
 
+       /**
+        * Check if l3/l4 SRC/DST_ONLY is set for SYMMETRIC_TOEPLITZ
+        * hash function.
+        */
+       if (rss_func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {
+               if (rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY |
+                   ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY))
+                       return true;
+
+               if (!(rss_type &
+                  (ETH_RSS_IPV4 | ETH_RSS_IPV6 |
+                   ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP |
+                   ETH_RSS_NONFRAG_IPV4_TCP | ETH_RSS_NONFRAG_IPV6_TCP |
+                   ETH_RSS_NONFRAG_IPV4_SCTP | ETH_RSS_NONFRAG_IPV6_SCTP)))
+                       return true;
+       }
+
        /* check invalid combination */
        for (i = 0; i < RTE_DIM(invalid_rss_comb); i++) {
                if (__builtin_popcountll(rss_type & invalid_rss_comb[i]) > 1)
                        return true;
        }
 
+       /* check invalid RSS attribute */
+       for (i = 0; i < RTE_DIM(rss_attr_to_valid_type); i++) {
+               struct rss_attr_type *rat = &rss_attr_to_valid_type[i];
+
+               if (rat->attr & rss_type && !(rat->type & rss_type))
+                       return true;
+       }
+
        /* check not allowed RSS type */
-#define _RSS_ATTR_ (ETH_RSS_L3_SRC_ONLY                | \
-                   ETH_RSS_L3_DST_ONLY         | \
-                   ETH_RSS_L4_SRC_ONLY         | \
-                   ETH_RSS_L4_DST_ONLY         | \
-                   ETH_RSS_L2_SRC_ONLY         | \
-                   ETH_RSS_L2_DST_ONLY         | \
-                   RTE_ETH_RSS_L3_PRE32        | \
-                   RTE_ETH_RSS_L3_PRE40        | \
-                   RTE_ETH_RSS_L3_PRE48        | \
-                   RTE_ETH_RSS_L3_PRE56        | \
-                   RTE_ETH_RSS_L3_PRE64        | \
-                   RTE_ETH_RSS_L3_PRE96)
-
-       rss_type &= ~_RSS_ATTR_;
+       rss_type &= ~VALID_RSS_ATTR;
 
        return ((rss_type & allow_rss_type) != rss_type);
 }
@@ -846,7 +1078,7 @@ iavf_hash_parse_action(struct iavf_pattern_match_item *match_item,
                         */
                        rss_type = rte_eth_rss_hf_refine(rss_type);
 
-                       if (iavf_any_invalid_rss_type(rss_type,
+                       if (iavf_any_invalid_rss_type(rss->func, rss_type,
                                        match_item->input_set_mask))
                                return rte_flow_error_set(error, ENOTSUP,
                                                RTE_FLOW_ERROR_TYPE_ACTION,
@@ -902,8 +1134,7 @@ iavf_hash_parse_pattern_action(__rte_unused struct iavf_adapter *ad,
                goto error;
        }
 
-       ret = iavf_hash_parse_pattern(pattern_match_item, pattern, &phint,
-                                     error);
+       ret = iavf_hash_parse_pattern(pattern, &phint, error);
        if (ret)
                goto error;
 
@@ -964,9 +1195,13 @@ iavf_hash_destroy(__rte_unused struct iavf_adapter *ad,
                  struct rte_flow *flow,
                  __rte_unused struct rte_flow_error *error)
 {
+       struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(ad);
        struct virtchnl_rss_cfg *rss_cfg;
        int ret = 0;
 
+       if (vf->vf_reset)
+               return 0;
+
        rss_cfg = (struct virtchnl_rss_cfg *)flow->rule;
 
        ret = iavf_add_del_rss_cfg(ad, rss_cfg, false);
@@ -984,11 +1219,19 @@ static void
 iavf_hash_uninit(struct iavf_adapter *ad)
 {
        struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(ad);
+       struct rte_eth_rss_conf *rss_conf;
 
        if (vf->vf_reset)
                return;
 
-       if (iavf_hash_default_set(ad, false))
+       if (!vf->vf_res)
+               return;
+
+       if (!(vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF))
+               return;
+
+       rss_conf = &ad->eth_dev->data->dev_conf.rx_adv_conf.rss_conf;
+       if (iavf_rss_hash_set(ad, rss_conf->rss_hf, false))
                PMD_DRV_LOG(ERR, "fail to delete default RSS");
 
        iavf_unregister_parser(&iavf_hash_parser, ad);