net/ice/base: update profile to recipe bitmap array
[dpdk.git] / drivers / net / ice / base / ice_switch.c
index 5388297..59da7ea 100644 (file)
@@ -59,38 +59,95 @@ struct ice_dummy_pkt_offsets {
 };
 
 static const
-struct ice_dummy_pkt_offsets dummy_gre_packet_offsets[] = {
+struct ice_dummy_pkt_offsets dummy_gre_tcp_packet_offsets[] = {
        { ICE_MAC_OFOS,         0 },
        { ICE_ETYPE_OL,         12 },
        { ICE_IPV4_OFOS,        14 },
        { ICE_NVGRE,            34 },
        { ICE_MAC_IL,           42 },
-       { ICE_IPV4_IL,          54 },
+       { ICE_IPV4_IL,          56 },
+       { ICE_TCP_IL,           76 },
        { ICE_PROTOCOL_LAST,    0 },
 };
 
 static const
-u8 dummy_gre_packet[] = { 0, 0, 0, 0,          /* ICE_MAC_OFOS 0 */
-                         0, 0, 0, 0,
-                         0, 0, 0, 0,
-                         0x08, 0,              /* ICE_ETYPE_OL 12 */
-                         0x45, 0, 0, 0x3E,     /* ICE_IPV4_OFOS 14 */
-                         0, 0, 0, 0,
-                         0, 0x2F, 0, 0,
-                         0, 0, 0, 0,
-                         0, 0, 0, 0,
-                         0x80, 0, 0x65, 0x58,  /* ICE_NVGRE 34 */
-                         0, 0, 0, 0,
-                         0, 0, 0, 0,           /* ICE_MAC_IL 42 */
-                         0, 0, 0, 0,
-                         0, 0, 0, 0,
-                         0x08, 0,
-                         0x45, 0, 0, 0x14,     /* ICE_IPV4_IL 54 */
-                         0, 0, 0, 0,
-                         0, 0, 0, 0,
-                         0, 0, 0, 0,
-                         0, 0, 0, 0
-                       };
+u8 dummy_gre_tcp_packet[] = {
+       0x00, 0x00, 0x00, 0x00, /* ICE_MAC_OFOS 0 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+
+       0x08, 0x00,             /* ICE_ETYPE_OL 12 */
+
+       0x45, 0x00, 0x00, 0x3E, /* ICE_IPV4_OFOS 14 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x2F, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+
+       0x80, 0x00, 0x65, 0x58, /* ICE_NVGRE 34 */
+       0x00, 0x00, 0x00, 0x00,
+
+       0x00, 0x00, 0x00, 0x00, /* ICE_MAC_IL 42 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x08, 0x00,
+
+       0x45, 0x00, 0x00, 0x14, /* ICE_IPV4_IL 56 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+
+       0x00, 0x00, 0x00, 0x00, /* ICE_TCP_IL 76 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x50, 0x02, 0x20, 0x00,
+       0x00, 0x00, 0x00, 0x00
+};
+
+static const
+struct ice_dummy_pkt_offsets dummy_gre_udp_packet_offsets[] = {
+       { ICE_MAC_OFOS,         0 },
+       { ICE_ETYPE_OL,         12 },
+       { ICE_IPV4_OFOS,        14 },
+       { ICE_NVGRE,            34 },
+       { ICE_MAC_IL,           42 },
+       { ICE_IPV4_IL,          56 },
+       { ICE_UDP_ILOS,         76 },
+       { ICE_PROTOCOL_LAST,    0 },
+};
+
+static const
+u8 dummy_gre_udp_packet[] = {
+       0x00, 0x00, 0x00, 0x00, /* ICE_MAC_OFOS 0 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+
+       0x08, 0x00,             /* ICE_ETYPE_OL 12 */
+
+       0x45, 0x00, 0x00, 0x3E, /* ICE_IPV4_OFOS 14 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x2F, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+
+       0x80, 0x00, 0x65, 0x58, /* ICE_NVGRE 34 */
+       0x00, 0x00, 0x00, 0x00,
+
+       0x00, 0x00, 0x00, 0x00, /* ICE_MAC_IL 42 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x08, 0x00,
+
+       0x45, 0x00, 0x00, 0x14, /* ICE_IPV4_IL 56 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+
+       0x00, 0x00, 0x00, 0x00, /* ICE_UDP_ILOS 76 */
+       0x00, 0x08, 0x00, 0x00,
+};
 
 static const
 struct ice_dummy_pkt_offsets dummy_udp_tun_tcp_packet_offsets[] = {
@@ -99,6 +156,7 @@ struct ice_dummy_pkt_offsets dummy_udp_tun_tcp_packet_offsets[] = {
        { ICE_IPV4_OFOS,        14 },
        { ICE_UDP_OF,           34 },
        { ICE_VXLAN,            42 },
+       { ICE_GENEVE,           42 },
        { ICE_MAC_IL,           50 },
        { ICE_IPV4_IL,          64 },
        { ICE_TCP_IL,           84 },
@@ -122,7 +180,7 @@ u8 dummy_udp_tun_tcp_packet[] = {
        0x00, 0x00, 0x12, 0xb5, /* ICE_UDP_OF 34 */
        0x00, 0x46, 0x00, 0x00,
 
-       0x04, 0x00, 0x00, 0x03, /* ICE_VXLAN 42 */
+       0x00, 0x00, 0x65, 0x58, /* ICE_VXLAN 42 */
        0x00, 0x00, 0x00, 0x00,
 
        0x00, 0x00, 0x00, 0x00, /* ICE_MAC_IL 50 */
@@ -150,6 +208,7 @@ struct ice_dummy_pkt_offsets dummy_udp_tun_udp_packet_offsets[] = {
        { ICE_IPV4_OFOS,        14 },
        { ICE_UDP_OF,           34 },
        { ICE_VXLAN,            42 },
+       { ICE_GENEVE,           42 },
        { ICE_MAC_IL,           50 },
        { ICE_IPV4_IL,          64 },
        { ICE_UDP_ILOS,         84 },
@@ -173,7 +232,7 @@ u8 dummy_udp_tun_udp_packet[] = {
        0x00, 0x00, 0x12, 0xb5, /* ICE_UDP_OF 34 */
        0x00, 0x3a, 0x00, 0x00,
 
-       0x0c, 0x00, 0x00, 0x03, /* ICE_VXLAN 42 */
+       0x00, 0x00, 0x65, 0x58, /* ICE_VXLAN 42 */
        0x00, 0x00, 0x00, 0x00,
 
        0x00, 0x00, 0x00, 0x00, /* ICE_MAC_IL 50 */
@@ -323,13 +382,101 @@ dummy_udp_ipv6_packet[] = {
        0x00, 0x00, /* 2 bytes for 4 byte alignment */
 };
 
-/* this is a recipe to profile bitmap association */
+static const
+struct ice_dummy_pkt_offsets dummy_udp_gtp_packet_offsets[] = {
+       { ICE_MAC_OFOS,         0 },
+       { ICE_IPV4_OFOS,        14 },
+       { ICE_UDP_OF,           34 },
+       { ICE_GTP,              42 },
+       { ICE_PROTOCOL_LAST,    0 },
+};
+
+static const u8
+dummy_udp_gtp_packet[] = {
+       0x00, 0x00, 0x00, 0x00, /* ICE_MAC_OFOS 0 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x08, 0x00,
+
+       0x45, 0x00, 0x00, 0x30, /* ICE_IPV4_OFOS 14 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x11, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+
+       0x00, 0x00, 0x08, 0x68, /* ICE_UDP_OF 34 */
+       0x00, 0x1c, 0x00, 0x00,
+
+       0x34, 0xff, 0x00, 0x0c, /* ICE_GTP 42 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x85,
+
+       0x02, 0x00, 0x00, 0x00, /* PDU Session extension header */
+       0x00, 0x00, 0x00, 0x00,
+};
+
+static const
+struct ice_dummy_pkt_offsets dummy_pppoe_packet_offsets[] = {
+       { ICE_MAC_OFOS,                 0 },
+       { ICE_PPPOE,                    14 },
+       { ICE_PROTOCOL_LAST,    0 },
+};
+
+static const u8
+dummy_pppoe_packet[] = {
+       0x00, 0x00, 0x00, 0x00, /* ICE_MAC_OFOS 0 */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x88, 0x64,
+
+       0x11, 0x00, 0x00, 0x01, /* ICE_PPPOE 14 */
+       0x00, 0x4e, 0x00, 0x21,
+
+       0x45, 0x00, 0x00, 0x30, /* PDU */
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x11, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+       0x00, 0x00, 0x00, 0x00,
+};
+
+/* this is a recipe to profile association bitmap */
 static ice_declare_bitmap(recipe_to_profile[ICE_MAX_NUM_RECIPES],
                          ICE_MAX_NUM_PROFILES);
-static ice_declare_bitmap(available_result_ids, ICE_CHAIN_FV_INDEX_START + 1);
+
+/* this is a profile to recipe association bitmap */
+static ice_declare_bitmap(profile_to_recipe[ICE_MAX_NUM_PROFILES],
+                         ICE_MAX_NUM_RECIPES);
 
 static void ice_get_recp_to_prof_map(struct ice_hw *hw);
 
+/**
+ * ice_collect_result_idx - copy result index values
+ * @buf: buffer that contains the result index
+ * @recp: the recipe struct to copy data into
+ */
+static void ice_collect_result_idx(struct ice_aqc_recipe_data_elem *buf,
+                                  struct ice_sw_recipe *recp)
+{
+       if (buf->content.result_indx & ICE_AQ_RECIPE_RESULT_EN)
+               ice_set_bit(buf->content.result_indx &
+                           ~ICE_AQ_RECIPE_RESULT_EN, recp->res_idxs);
+}
+
+/**
+ * ice_init_possible_res_bm - initialize possible result bitmap
+ * @pos_result_bm: pointer to the bitmap to initialize
+ */
+static void ice_init_possible_res_bm(ice_bitmap_t *pos_result_bm)
+{
+       u16 bit;
+
+       ice_zero_bitmap(pos_result_bm, ICE_MAX_FV_WORDS);
+
+       for (bit = 0; bit < ICE_MAX_FV_WORDS; bit++)
+               if (ICE_POSSIBLE_RES_IDX & BIT_ULL(bit))
+                       ice_set_bit(bit, pos_result_bm);
+}
+
 /**
  * ice_get_recp_frm_fw - update SW bookkeeping from FW recipe entries
  * @hw: pointer to hardware structure
@@ -345,14 +492,17 @@ static enum ice_status
 ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid,
                    bool *refresh_required)
 {
-       u16 i, sub_recps, fv_word_idx = 0, result_idx = 0;
-       ice_declare_bitmap(r_bitmap, ICE_MAX_NUM_PROFILES);
-       u16 result_idxs[ICE_MAX_CHAIN_RECIPE] = { 0 };
+       ice_declare_bitmap(possible_idx, ICE_MAX_FV_WORDS);
+       ice_declare_bitmap(result_bm, ICE_MAX_FV_WORDS);
        struct ice_aqc_recipe_data_elem *tmp;
        u16 num_recps = ICE_MAX_NUM_RECIPES;
        struct ice_prot_lkup_ext *lkup_exts;
+       u16 i, sub_recps, fv_word_idx = 0;
        enum ice_status status;
 
+       ice_zero_bitmap(result_bm, ICE_MAX_FV_WORDS);
+       ice_init_possible_res_bm(possible_idx);
+
        /* we need a buffer big enough to accommodate all the recipes */
        tmp = (struct ice_aqc_recipe_data_elem *)ice_calloc(hw,
                ICE_MAX_NUM_RECIPES, sizeof(*tmp));
@@ -377,14 +527,18 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid,
                ice_get_recp_to_prof_map(hw);
                *refresh_required = false;
        }
-       lkup_exts = &recps[rid].lkup_exts;
-       /* start populating all the entries for recps[rid] based on lkups from
-        * firmware
+
+       /* Start populating all the entries for recps[rid] based on lkups from
+        * firmware. Note that we are only creating the root recipe in our
+        * database.
         */
+       lkup_exts = &recps[rid].lkup_exts;
+
        for (sub_recps = 0; sub_recps < num_recps; sub_recps++) {
                struct ice_aqc_recipe_data_elem root_bufs = tmp[sub_recps];
                struct ice_recp_grp_entry *rg_entry;
-               u8 prof_id, prot = 0;
+               u8 prof_id, idx, prot = 0;
+               bool is_root;
                u16 off = 0;
 
                rg_entry = (struct ice_recp_grp_entry *)
@@ -393,19 +547,18 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid,
                        status = ICE_ERR_NO_MEMORY;
                        goto err_unroll;
                }
-               /* Avoid 8th bit since its result enable bit */
-               result_idxs[result_idx] = root_bufs.content.result_indx &
-                       ~ICE_AQ_RECIPE_RESULT_EN;
-               /* Check if result enable bit is set */
+
+               idx = root_bufs.recipe_indx;
+               is_root = root_bufs.content.rid & ICE_AQ_RECIPE_ID_IS_ROOT;
+
+               /* Mark all result indices in this chain */
                if (root_bufs.content.result_indx & ICE_AQ_RECIPE_RESULT_EN)
-                       ice_clear_bit(ICE_CHAIN_FV_INDEX_START -
-                                     result_idxs[result_idx++],
-                                     available_result_ids);
-               ice_memcpy(r_bitmap,
-                          recipe_to_profile[tmp[sub_recps].recipe_indx],
-                          sizeof(r_bitmap), ICE_NONDMA_TO_NONDMA);
+                       ice_set_bit(root_bufs.content.result_indx &
+                                   ~ICE_AQ_RECIPE_RESULT_EN, result_bm);
+
                /* get the first profile that is associated with rid */
-               prof_id = ice_find_first_bit(r_bitmap, ICE_MAX_NUM_PROFILES);
+               prof_id = ice_find_first_bit(recipe_to_profile[idx],
+                                            ICE_MAX_NUM_PROFILES);
                for (i = 0; i < ICE_NUM_WORDS_RECIPE; i++) {
                        u8 lkup_indx = root_bufs.content.lkup_indx[i + 1];
 
@@ -422,12 +575,8 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid,
                         * has ICE_AQ_RECIPE_LKUP_IGNORE or 0 since it isn't a
                         * valid offset value.
                         */
-                       if (result_idxs[0] == rg_entry->fv_idx[i] ||
-                           result_idxs[1] == rg_entry->fv_idx[i] ||
-                           result_idxs[2] == rg_entry->fv_idx[i] ||
-                           result_idxs[3] == rg_entry->fv_idx[i] ||
-                           result_idxs[4] == rg_entry->fv_idx[i] ||
-                           rg_entry->fv_idx[i] == ICE_AQ_RECIPE_LKUP_IGNORE ||
+                       if (ice_is_bit_set(possible_idx, rg_entry->fv_idx[i]) ||
+                           rg_entry->fv_idx[i] & ICE_AQ_RECIPE_LKUP_IGNORE ||
                            rg_entry->fv_idx[i] == 0)
                                continue;
 
@@ -441,8 +590,33 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid,
                 * recipe
                 */
                LIST_ADD(&rg_entry->l_entry, &recps[rid].rg_list);
+
+               /* Propagate some data to the recipe database */
+               recps[idx].is_root = is_root;
+               recps[idx].priority = root_bufs.content.act_ctrl_fwd_priority;
+               ice_zero_bitmap(recps[idx].res_idxs, ICE_MAX_FV_WORDS);
+               if (root_bufs.content.result_indx & ICE_AQ_RECIPE_RESULT_EN) {
+                       recps[idx].chain_idx = root_bufs.content.result_indx &
+                               ~ICE_AQ_RECIPE_RESULT_EN;
+                       ice_set_bit(recps[idx].chain_idx, recps[idx].res_idxs);
+               } else {
+                       recps[idx].chain_idx = ICE_INVAL_CHAIN_IND;
+               }
+
+               if (!is_root)
+                       continue;
+
+               /* Only do the following for root recipes entries */
+               ice_memcpy(recps[idx].r_bitmap, root_bufs.recipe_bitmap,
+                          sizeof(recps[idx].r_bitmap), ICE_NONDMA_TO_NONDMA);
+               recps[idx].root_rid = root_bufs.content.rid &
+                       ~ICE_AQ_RECIPE_ID_IS_ROOT;
+               recps[idx].priority = root_bufs.content.act_ctrl_fwd_priority;
        }
+
+       /* Complete initialization of the root recipe entry */
        lkup_exts->n_val_words = fv_word_idx;
+       recps[rid].big_recp = (num_recps > 1);
        recps[rid].n_grp_count = num_recps;
        recps[rid].root_buf = (struct ice_aqc_recipe_data_elem *)
                ice_calloc(hw, recps[rid].n_grp_count,
@@ -452,9 +626,12 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid,
 
        ice_memcpy(recps[rid].root_buf, tmp, recps[rid].n_grp_count *
                   sizeof(*recps[rid].root_buf), ICE_NONDMA_TO_NONDMA);
+
+       /* Copy result indexes */
+       ice_memcpy(recps[rid].res_idxs, result_bm, sizeof(recps[rid].res_idxs),
+                  ICE_NONDMA_TO_NONDMA);
        recps[rid].recp_created = true;
-       if (tmp[sub_recps].content.rid & ICE_AQ_RECIPE_ID_IS_ROOT)
-               recps[rid].root_rid = rid;
+
 err_unroll:
        ice_free(hw, tmp);
        return status;
@@ -477,10 +654,12 @@ ice_get_recp_to_prof_map(struct ice_hw *hw)
        for (i = 0; i < ICE_MAX_NUM_PROFILES; i++) {
                u16 j;
 
+               ice_zero_bitmap(profile_to_recipe[i], ICE_MAX_NUM_RECIPES);
                ice_zero_bitmap(r_bitmap, ICE_MAX_NUM_RECIPES);
                if (ice_aq_get_recipe_to_profile(hw, i, (u8 *)r_bitmap, NULL))
                        continue;
-
+               ice_memcpy(profile_to_recipe[i], r_bitmap,
+                          sizeof(profile_to_recipe[i]), ICE_NONDMA_TO_NONDMA);
                for (j = 0; j < ICE_MAX_NUM_RECIPES; j++)
                        if (ice_is_bit_set(r_bitmap, j))
                                ice_set_bit(i, recipe_to_profile[j]);
@@ -971,8 +1150,7 @@ ice_add_vsi(struct ice_hw *hw, u16 vsi_handle, struct ice_vsi_ctx *vsi_ctx,
                ice_save_vsi_ctx(hw, vsi_handle, tmp_vsi_ctx);
        } else {
                /* update with new HW VSI num */
-               if (tmp_vsi_ctx->vsi_num != vsi_ctx->vsi_num)
-                       tmp_vsi_ctx->vsi_num = vsi_ctx->vsi_num;
+               tmp_vsi_ctx->vsi_num = vsi_ctx->vsi_num;
        }
 
        return ICE_SUCCESS;
@@ -1329,7 +1507,7 @@ ice_aq_sw_rules(struct ice_hw *hw, void *rule_list, u16 rule_list_sz,
 {
        struct ice_aq_desc desc;
 
-       ice_debug(hw, ICE_DBG_TRACE, "ice_aq_sw_rules");
+       ice_debug(hw, ICE_DBG_TRACE, "%s\n", __func__);
 
        if (opc != ice_aqc_opc_add_sw_rules &&
            opc != ice_aqc_opc_update_sw_rules &&
@@ -1362,7 +1540,7 @@ ice_aq_add_recipe(struct ice_hw *hw,
        struct ice_aq_desc desc;
        u16 buf_size;
 
-       ice_debug(hw, ICE_DBG_TRACE, "ice_aq_add_recipe");
+       ice_debug(hw, ICE_DBG_TRACE, "%s\n", __func__);
        cmd = &desc.params.add_get_recipe;
        ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_add_recipe);
 
@@ -1404,7 +1582,7 @@ ice_aq_get_recipe(struct ice_hw *hw,
        if (*num_recipes != ICE_MAX_NUM_RECIPES)
                return ICE_ERR_PARAM;
 
-       ice_debug(hw, ICE_DBG_TRACE, "ice_aq_get_recipe");
+       ice_debug(hw, ICE_DBG_TRACE, "%s\n", __func__);
        cmd = &desc.params.add_get_recipe;
        ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_get_recipe);
 
@@ -1435,7 +1613,7 @@ ice_aq_map_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u8 *r_bitmap,
        struct ice_aqc_recipe_to_profile *cmd;
        struct ice_aq_desc desc;
 
-       ice_debug(hw, ICE_DBG_TRACE, "ice_aq_assoc_recipe_to_prof");
+       ice_debug(hw, ICE_DBG_TRACE, "%s\n", __func__);
        cmd = &desc.params.recipe_to_profile;
        ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_recipe_to_profile);
        cmd->profile_id = CPU_TO_LE16(profile_id);
@@ -1464,7 +1642,7 @@ ice_aq_get_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u8 *r_bitmap,
        struct ice_aq_desc desc;
        enum ice_status status;
 
-       ice_debug(hw, ICE_DBG_TRACE, "ice_aq_get_recipe_to_prof");
+       ice_debug(hw, ICE_DBG_TRACE, "%s\n", __func__);
        cmd = &desc.params.recipe_to_profile;
        ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_get_recipe_to_profile);
        cmd->profile_id = CPU_TO_LE16(profile_id);
@@ -1674,21 +1852,6 @@ static void ice_fill_sw_info(struct ice_hw *hw, struct ice_fltr_info *fi)
        }
 }
 
-/**
- * ice_ilog2 - Calculates integer log base 2 of a number
- * @n: number on which to perform operation
- */
-static int ice_ilog2(u64 n)
-{
-       int i;
-
-       for (i = 63; i >= 0; i--)
-               if (((u64)1 << i) & n)
-                       return i;
-
-       return -1;
-}
-
 /**
  * ice_fill_sw_rule - Helper function to fill switch rule structure
  * @hw: pointer to the hardware structure
@@ -2730,12 +2893,13 @@ ice_remove_rule_internal(struct ice_hw *hw, u8 recp_id,
                status = ice_aq_sw_rules(hw, s_rule,
                                         ICE_SW_RULE_RX_TX_NO_HDR_SIZE, 1,
                                         ice_aqc_opc_remove_sw_rules, NULL);
-               if (status)
-                       goto exit;
 
                /* Remove a book keeping from the list */
                ice_free(hw, s_rule);
 
+               if (status)
+                       goto exit;
+
                LIST_DEL(&list_elem->list_entry);
                ice_free(hw, list_elem);
        }
@@ -2802,7 +2966,7 @@ ice_aq_get_res_descs(struct ice_hw *hw, u16 num_entries,
        struct ice_aq_desc desc;
        enum ice_status status;
 
-       ice_debug(hw, ICE_DBG_TRACE, "ice_aq_get_res_descs");
+       ice_debug(hw, ICE_DBG_TRACE, "%s\n", __func__);
 
        cmd = &desc.params.get_res_desc;
 
@@ -2819,8 +2983,6 @@ ice_aq_get_res_descs(struct ice_hw *hw, u16 num_entries,
                                        ICE_AQC_RES_TYPE_FLAG_SHARED : 0));
        cmd->ops.cmd.first_desc = CPU_TO_LE16(*desc_id);
 
-       desc.flags |= CPU_TO_LE16(ICE_AQ_FLAG_RD);
-
        status = ice_aq_send_cmd(hw, &desc, buf, buf_size, cd);
        if (!status)
                *desc_id = LE16_TO_CPU(cmd->ops.resp.next_desc);
@@ -3820,7 +3982,7 @@ ice_clear_vsi_promisc(struct ice_hw *hw, u16 vsi_handle, u8 promisc_mask,
        if (!ice_is_vsi_valid(hw, vsi_handle))
                return ICE_ERR_PARAM;
 
-       if (vid)
+       if (promisc_mask & (ICE_PROMISC_VLAN_RX | ICE_PROMISC_VLAN_TX))
                recipe_id = ICE_SW_LKUP_PROMISC_VLAN;
        else
                recipe_id = ICE_SW_LKUP_PROMISC;
@@ -3833,13 +3995,18 @@ ice_clear_vsi_promisc(struct ice_hw *hw, u16 vsi_handle, u8 promisc_mask,
        ice_acquire_lock(rule_lock);
        LIST_FOR_EACH_ENTRY(itr, rule_head,
                            ice_fltr_mgmt_list_entry, list_entry) {
+               struct ice_fltr_info *fltr_info;
                u8 fltr_promisc_mask = 0;
 
                if (!ice_vsi_uses_fltr(itr, vsi_handle))
                        continue;
+               fltr_info = &itr->fltr_info;
+
+               if (recipe_id == ICE_SW_LKUP_PROMISC_VLAN &&
+                   vid != fltr_info->l_data.mac_vlan.vlan_id)
+                       continue;
 
-               fltr_promisc_mask |=
-                       ice_determine_promisc_mask(&itr->fltr_info);
+               fltr_promisc_mask |= ice_determine_promisc_mask(fltr_info);
 
                /* Skip if filter is not completely specified by given mask */
                if (fltr_promisc_mask & ~promisc_mask)
@@ -3847,7 +4014,7 @@ ice_clear_vsi_promisc(struct ice_hw *hw, u16 vsi_handle, u8 promisc_mask,
 
                status = ice_add_entry_to_vsi_fltr_list(hw, vsi_handle,
                                                        &remove_list_head,
-                                                       &itr->fltr_info);
+                                                       fltr_info);
                if (status) {
                        ice_release_lock(rule_lock);
                        goto free_fltr_list;
@@ -3886,7 +4053,7 @@ ice_set_vsi_promisc(struct ice_hw *hw, u16 vsi_handle, u8 promisc_mask, u16 vid)
        int pkt_type;
        u8 recipe_id;
 
-       ice_debug(hw, ICE_DBG_TRACE, "ice_set_vsi_promisc\n");
+       ice_debug(hw, ICE_DBG_TRACE, "%s\n", __func__);
 
        if (!ice_is_vsi_valid(hw, vsi_handle))
                return ICE_ERR_PARAM;
@@ -4104,7 +4271,7 @@ ice_remove_vsi_lkup_fltr(struct ice_hw *hw, u16 vsi_handle,
  */
 void ice_remove_vsi_fltr(struct ice_hw *hw, u16 vsi_handle)
 {
-       ice_debug(hw, ICE_DBG_TRACE, "ice_remove_vsi_fltr\n");
+       ice_debug(hw, ICE_DBG_TRACE, "%s\n", __func__);
 
        ice_remove_vsi_lkup_fltr(hw, vsi_handle, ICE_SW_LKUP_MAC);
        ice_remove_vsi_lkup_fltr(hw, vsi_handle, ICE_SW_LKUP_MAC_VLAN);
@@ -4481,8 +4648,10 @@ static const struct ice_prot_ext_tbl_entry ice_prot_ext[] = {
        { ICE_SCTP_IL,          { 0, 2 } },
        { ICE_VXLAN,            { 8, 10, 12, 14 } },
        { ICE_GENEVE,           { 8, 10, 12, 14 } },
-       { ICE_VXLAN_GPE,        { 0, 2, 4 } },
+       { ICE_VXLAN_GPE,        { 8, 10, 12, 14 } },
        { ICE_NVGRE,            { 0, 2, 4, 6 } },
+       { ICE_GTP,              { 8, 10, 12, 14, 16, 18, 20 } },
+       { ICE_PPPOE,            { 0, 2, 4, 6 } },
        { ICE_PROTOCOL_LAST,    { 0 } }
 };
 
@@ -4491,17 +4660,6 @@ static const struct ice_prot_ext_tbl_entry ice_prot_ext[] = {
  * following combinations, then the recipe needs to be chained as per the
  * following policy.
  */
-static const struct ice_pref_recipe_group ice_recipe_pack[] = {
-       {3, { { ICE_MAC_OFOS_HW, 0, 0 }, { ICE_MAC_OFOS_HW, 2, 0 },
-             { ICE_MAC_OFOS_HW, 4, 0 } }, { 0xffff, 0xffff, 0xffff, 0xffff } },
-       {4, { { ICE_MAC_IL_HW, 0, 0 }, { ICE_MAC_IL_HW, 2, 0 },
-             { ICE_MAC_IL_HW, 4, 0 }, { ICE_META_DATA_ID_HW, 44, 0 } },
-               { 0xffff, 0xffff, 0xffff, 0xffff } },
-       {2, { { ICE_IPV4_IL_HW, 0, 0 }, { ICE_IPV4_IL_HW, 2, 0 } },
-               { 0xffff, 0xffff, 0xffff, 0xffff } },
-       {2, { { ICE_IPV4_IL_HW, 12, 0 }, { ICE_IPV4_IL_HW, 14, 0 } },
-               { 0xffff, 0xffff, 0xffff, 0xffff } },
-};
 
 static const struct ice_protocol_entry ice_prot_id_tbl[] = {
        { ICE_MAC_OFOS,         ICE_MAC_OFOS_HW },
@@ -4519,6 +4677,8 @@ static const struct ice_protocol_entry ice_prot_id_tbl[] = {
        { ICE_GENEVE,           ICE_UDP_OF_HW },
        { ICE_VXLAN_GPE,        ICE_UDP_OF_HW },
        { ICE_NVGRE,            ICE_GRE_OF_HW },
+       { ICE_GTP,              ICE_UDP_OF_HW },
+       { ICE_PPPOE,            ICE_PPPOE_HW },
        { ICE_PROTOCOL_LAST,    0 }
 };
 
@@ -4535,11 +4695,6 @@ static u16 ice_find_recp(struct ice_hw *hw, struct ice_prot_lkup_ext *lkup_exts)
        struct ice_sw_recipe *recp;
        u16 i;
 
-       /* Initialize available_result_ids which tracks available result idx */
-       for (i = 0; i <= ICE_CHAIN_FV_INDEX_START; i++)
-               ice_set_bit(ICE_CHAIN_FV_INDEX_START - i,
-                           available_result_ids);
-
        /* Walk through existing recipes to find a match */
        recp = hw->switch_info->recp_list;
        for (i = 0; i < ICE_MAX_NUM_RECIPES; i++) {
@@ -4651,75 +4806,7 @@ ice_fill_valid_words(struct ice_adv_lkup_elem *rule,
        return ret_val;
 }
 
-/**
- * ice_find_prot_off_ind - check for specific ID and offset in rule
- * @lkup_exts: an array of protocol header extractions
- * @prot_type: protocol type to check
- * @off: expected offset of the extraction
- *
- * Check if the prot_ext has given protocol ID and offset
- */
-static u8
-ice_find_prot_off_ind(struct ice_prot_lkup_ext *lkup_exts, u8 prot_type,
-                     u16 off)
-{
-       u8 j;
-
-       for (j = 0; j < lkup_exts->n_val_words; j++)
-               if (lkup_exts->fv_words[j].off == off &&
-                   lkup_exts->fv_words[j].prot_id == prot_type)
-                       return j;
-
-       return ICE_MAX_CHAIN_WORDS;
-}
-
-/**
- * ice_is_recipe_subset - check if recipe group policy is a subset of lookup
- * @lkup_exts: an array of protocol header extractions
- * @r_policy: preferred recipe grouping policy
- *
- * Helper function to check if given recipe group is subset we need to check if
- * all the words described by the given recipe group exist in the advanced rule
- * look up information
- */
-static bool
-ice_is_recipe_subset(struct ice_prot_lkup_ext *lkup_exts,
-                    const struct ice_pref_recipe_group *r_policy)
-{
-       u8 ind[ICE_NUM_WORDS_RECIPE];
-       u8 count = 0;
-       u8 i;
-
-       /* check if everything in the r_policy is part of the entire rule */
-       for (i = 0; i < r_policy->n_val_pairs; i++) {
-               u8 j;
-
-               j = ice_find_prot_off_ind(lkup_exts, r_policy->pairs[i].prot_id,
-                                         r_policy->pairs[i].off);
-               if (j >= ICE_MAX_CHAIN_WORDS)
-                       return false;
 
-               /* store the indexes temporarily found by the find function
-                * this will be used to mark the words as 'done'
-                */
-               ind[count++] = j;
-       }
-
-       /* If the entire policy recipe was a true match, then mark the fields
-        * that are covered by the recipe as 'done' meaning that these words
-        * will be clumped together in one recipe.
-        * "Done" here means in our searching if certain recipe group
-        * matches or is subset of the given rule, then we mark all
-        * the corresponding offsets as found. So the remaining recipes should
-        * be created with whatever words that were left.
-        */
-       for (i = 0; i < count; i++) {
-               u8 in = ind[i];
-
-               ice_set_bit(in, lkup_exts->done);
-       }
-       return true;
-}
 
 /**
  * ice_create_first_fit_recp_def - Create a recipe grouping
@@ -4781,7 +4868,7 @@ ice_create_first_fit_recp_def(struct ice_hw *hw,
  * Helper function to fill in the field vector indices for protocol-offset
  * pairs. These indexes are then ultimately programmed into a recipe.
  */
-static void
+static enum ice_status
 ice_fill_fv_word_index(struct ice_hw *hw, struct LIST_HEAD_TYPE *fv_list,
                       struct LIST_HEAD_TYPE *rg_list)
 {
@@ -4790,7 +4877,7 @@ ice_fill_fv_word_index(struct ice_hw *hw, struct LIST_HEAD_TYPE *fv_list,
        struct ice_fv_word *fv_ext;
 
        if (LIST_EMPTY(fv_list))
-               return;
+               return ICE_SUCCESS;
 
        fv = LIST_FIRST_ENTRY(fv_list, struct ice_sw_fv_list_entry, list_entry);
        fv_ext = fv->fv_ptr->ew;
@@ -4800,6 +4887,7 @@ ice_fill_fv_word_index(struct ice_hw *hw, struct LIST_HEAD_TYPE *fv_list,
 
                for (i = 0; i < rg->r_group.n_val_pairs; i++) {
                        struct ice_fv_word *pr;
+                       bool found = false;
                        u16 mask;
                        u8 j;
 
@@ -4809,6 +4897,8 @@ ice_fill_fv_word_index(struct ice_hw *hw, struct LIST_HEAD_TYPE *fv_list,
                        for (j = 0; j < hw->blk[ICE_BLK_SW].es.fvw; j++)
                                if (fv_ext[j].prot_id == pr->prot_id &&
                                    fv_ext[j].off == pr->off) {
+                                       found = true;
+
                                        /* Store index of field vector */
                                        rg->fv_idx[i] = j;
                                        /* Mask is given by caller as big
@@ -4818,8 +4908,96 @@ ice_fill_fv_word_index(struct ice_hw *hw, struct LIST_HEAD_TYPE *fv_list,
                                        rg->fv_mask[i] = mask << 8 | mask >> 8;
                                        break;
                                }
+
+                       /* Protocol/offset could not be found, caller gave an
+                        * invalid pair
+                        */
+                       if (!found)
+                               return ICE_ERR_PARAM;
                }
        }
+
+       return ICE_SUCCESS;
+}
+
+/**
+ * ice_find_free_recp_res_idx - find free result indexes for recipe
+ * @hw: pointer to hardware structure
+ * @profiles: bitmap of profiles that will be associated with the new recipe
+ * @free_idx: pointer to variable to receive the free index bitmap
+ *
+ * The algorithm used here is:
+ *     1. When creating a new recipe, create a set P which contains all
+ *        Profiles that will be associated with our new recipe
+ *
+ *     2. For each Profile p in set P:
+ *         a. Add all recipes associated with Profile p into set R
+ *         b. Optional : PossibleIndexes &= profile[p].possibleIndexes
+ *             [initially PossibleIndexes should be 0xFFFFFFFFFFFFFFFF]
+ *             i. Or just assume they all have the same possible indexes:
+ *                     44, 45, 46, 47
+ *                     i.e., PossibleIndexes = 0x0000F00000000000
+ *
+ *     3. For each Recipe r in set R:
+ *         a. UsedIndexes |= (bitwise or ) recipe[r].res_indexes
+ *         b. FreeIndexes = UsedIndexes ^ PossibleIndexes
+ *
+ *     FreeIndexes will contain the bits indicating the indexes free for use,
+ *      then the code needs to update the recipe[r].used_result_idx_bits to
+ *      indicate which indexes were selected for use by this recipe.
+ */
+static u16
+ice_find_free_recp_res_idx(struct ice_hw *hw, const ice_bitmap_t *profiles,
+                          ice_bitmap_t *free_idx)
+{
+       ice_declare_bitmap(possible_idx, ICE_MAX_FV_WORDS);
+       ice_declare_bitmap(used_idx, ICE_MAX_FV_WORDS);
+       ice_declare_bitmap(recipes, ICE_MAX_NUM_RECIPES);
+       u16 count = 0;
+       u16 bit;
+
+       ice_zero_bitmap(free_idx, ICE_MAX_FV_WORDS);
+       ice_zero_bitmap(used_idx, ICE_MAX_FV_WORDS);
+       ice_zero_bitmap(recipes, ICE_MAX_NUM_RECIPES);
+       ice_init_possible_res_bm(possible_idx);
+
+       for (bit = 0; bit < ICE_MAX_FV_WORDS; bit++)
+               if (ICE_POSSIBLE_RES_IDX & BIT_ULL(bit))
+                       ice_set_bit(bit, possible_idx);
+
+       /* For each profile we are going to associate the recipe with, add the
+        * recipes that are associated with that profile. This will give us
+        * the set of recipes that our recipe may collide with.
+        */
+       bit = 0;
+       while (ICE_MAX_NUM_PROFILES >
+              (bit = ice_find_next_bit(profiles, ICE_MAX_NUM_PROFILES, bit))) {
+               ice_or_bitmap(recipes, recipes, profile_to_recipe[bit],
+                             ICE_MAX_NUM_RECIPES);
+
+               bit++;
+       }
+
+       /* For each recipe that our new recipe may collide with, determine
+        * which indexes have been used.
+        */
+       for (bit = 0; bit < ICE_MAX_NUM_RECIPES; bit++)
+               if (ice_is_bit_set(recipes, bit))
+                       ice_or_bitmap(used_idx, used_idx,
+                                     hw->switch_info->recp_list[bit].res_idxs,
+                                     ICE_MAX_FV_WORDS);
+
+       ice_xor_bitmap(free_idx, used_idx, possible_idx, ICE_MAX_FV_WORDS);
+
+       /* return number of free indexes */
+       bit = 0;
+       while (ICE_MAX_FV_WORDS >
+              (bit = ice_find_next_bit(free_idx, ICE_MAX_FV_WORDS, bit))) {
+               count++;
+               bit++;
+       }
+
+       return count;
 }
 
 /**
@@ -4827,15 +5005,18 @@ ice_fill_fv_word_index(struct ice_hw *hw, struct LIST_HEAD_TYPE *fv_list,
  * @hw: pointer to hardware structure
  * @rm: recipe management list entry
  * @match_tun: if field vector index for tunnel needs to be programmed
+ * @profiles: bitmap of profiles that will be assocated.
  */
 static enum ice_status
 ice_add_sw_recipe(struct ice_hw *hw, struct ice_sw_recipe *rm,
-                 bool match_tun)
+                 bool match_tun, ice_bitmap_t *profiles)
 {
+       ice_declare_bitmap(result_idx_bm, ICE_MAX_FV_WORDS);
        struct ice_aqc_recipe_data_elem *tmp;
        struct ice_aqc_recipe_data_elem *buf;
        struct ice_recp_grp_entry *entry;
        enum ice_status status;
+       u16 free_res_idx;
        u16 recipe_count;
        u8 chain_idx;
        u8 recps = 0;
@@ -4845,11 +5026,16 @@ ice_add_sw_recipe(struct ice_hw *hw, struct ice_sw_recipe *rm,
         * the match fields in the chaining recipe reducing the number of
         * chained recipes by one.
         */
-       if (rm->n_grp_count > 1)
+        /* check number of free result indices */
+       ice_zero_bitmap(result_idx_bm, ICE_MAX_FV_WORDS);
+       free_res_idx = ice_find_free_recp_res_idx(hw, profiles, result_idx_bm);
+
+       if (rm->n_grp_count > 1) {
+               if (rm->n_grp_count > free_res_idx)
+                       return ICE_ERR_MAX_LIMIT;
+
                rm->n_grp_count++;
-       if (rm->n_grp_count > ICE_MAX_CHAIN_RECIPE ||
-           (match_tun && rm->n_grp_count > (ICE_MAX_CHAIN_RECIPE - 1)))
-               return ICE_ERR_MAX_LIMIT;
+       }
 
        tmp = (struct ice_aqc_recipe_data_elem *)ice_calloc(hw,
                                                            ICE_MAX_NUM_RECIPES,
@@ -4874,9 +5060,7 @@ ice_add_sw_recipe(struct ice_hw *hw, struct ice_sw_recipe *rm,
        /* Allocate the recipe resources, and configure them according to the
         * match fields from protocol headers and extracted field vectors.
         */
-       chain_idx = ICE_CHAIN_FV_INDEX_START -
-               ice_find_first_bit(available_result_ids,
-                                  ICE_CHAIN_FV_INDEX_START + 1);
+       chain_idx = ice_find_first_bit(result_idx_bm, ICE_MAX_FV_WORDS);
        LIST_FOR_EACH_ENTRY(entry, &rm->rg_list, ice_recp_grp_entry, l_entry) {
                u8 i;
 
@@ -4918,17 +5102,24 @@ ice_add_sw_recipe(struct ice_hw *hw, struct ice_sw_recipe *rm,
                }
 
                if (rm->n_grp_count > 1) {
+                       /* Checks to see if there really is a valid result index
+                        * that can be used.
+                        */
+                       if (chain_idx >= ICE_MAX_FV_WORDS) {
+                               ice_debug(hw, ICE_DBG_SW,
+                                         "No chain index available\n");
+                               status = ICE_ERR_MAX_LIMIT;
+                               goto err_unroll;
+                       }
+
                        entry->chain_idx = chain_idx;
                        buf[recps].content.result_indx =
                                ICE_AQ_RECIPE_RESULT_EN |
                                ((chain_idx << ICE_AQ_RECIPE_RESULT_DATA_S) &
                                 ICE_AQ_RECIPE_RESULT_DATA_M);
-                       ice_clear_bit(ICE_CHAIN_FV_INDEX_START - chain_idx,
-                                     available_result_ids);
-                       chain_idx = ICE_CHAIN_FV_INDEX_START -
-                               ice_find_first_bit(available_result_ids,
-                                                  ICE_CHAIN_FV_INDEX_START +
-                                                  1);
+                       ice_clear_bit(chain_idx, result_idx_bm);
+                       chain_idx = ice_find_first_bit(result_idx_bm,
+                                                      ICE_MAX_FV_WORDS);
                }
 
                /* fill recipe dependencies */
@@ -5053,19 +5244,56 @@ ice_add_sw_recipe(struct ice_hw *hw, struct ice_sw_recipe *rm,
         */
        LIST_FOR_EACH_ENTRY(entry, &rm->rg_list, ice_recp_grp_entry, l_entry) {
                struct ice_switch_info *sw = hw->switch_info;
+               bool is_root, idx_found = false;
                struct ice_sw_recipe *recp;
+               u16 idx, buf_idx = 0;
+
+               /* find buffer index for copying some data */
+               for (idx = 0; idx < rm->n_grp_count; idx++)
+                       if (buf[idx].recipe_indx == entry->rid) {
+                               buf_idx = idx;
+                               idx_found = true;
+                       }
+
+               if (!idx_found) {
+                       status = ICE_ERR_OUT_OF_RANGE;
+                       goto err_unroll;
+               }
 
                recp = &sw->recp_list[entry->rid];
+               is_root = (rm->root_rid == entry->rid);
+               recp->is_root = is_root;
+
                recp->root_rid = entry->rid;
+               recp->big_recp = (is_root && rm->n_grp_count > 1);
+
                ice_memcpy(&recp->ext_words, entry->r_group.pairs,
                           entry->r_group.n_val_pairs *
                           sizeof(struct ice_fv_word),
                           ICE_NONDMA_TO_NONDMA);
 
+               ice_memcpy(recp->r_bitmap, buf[buf_idx].recipe_bitmap,
+                          sizeof(recp->r_bitmap), ICE_NONDMA_TO_NONDMA);
+
+               /* Copy non-result fv index values and masks to recipe. This
+                * call will also update the result recipe bitmask.
+                */
+               ice_collect_result_idx(&buf[buf_idx], recp);
+
+               /* for non-root recipes, also copy to the root, this allows
+                * easier matching of a complete chained recipe
+                */
+               if (!is_root)
+                       ice_collect_result_idx(&buf[buf_idx],
+                                              &sw->recp_list[rm->root_rid]);
+
                recp->n_ext_words = entry->r_group.n_val_pairs;
                recp->chain_idx = entry->chain_idx;
+               recp->priority = buf[buf_idx].content.act_ctrl_fwd_priority;
+               recp->n_grp_count = rm->n_grp_count;
+               recp->tun_type = rm->tun_type;
                recp->recp_created = true;
-               recp->big_recp = false;
+               recp->adv_rule = 1;
        }
        rm->root_buf = buf;
        ice_free(hw, tmp);
@@ -5088,45 +5316,11 @@ static enum ice_status
 ice_create_recipe_group(struct ice_hw *hw, struct ice_sw_recipe *rm,
                        struct ice_prot_lkup_ext *lkup_exts)
 {
-       struct ice_recp_grp_entry *entry;
-       struct ice_recp_grp_entry *tmp;
        enum ice_status status;
        u8 recp_count = 0;
-       u16 groups, i;
 
        rm->n_grp_count = 0;
 
-       /* Each switch recipe can match up to 5 words or metadata. One word in
-        * each recipe is used to match the switch ID. Four words are left for
-        * matching other values. If the new advanced recipe requires more than
-        * 4 words, it needs to be split into multiple recipes which are chained
-        * together using the intermediate result that each produces as input to
-        * the other recipes in the sequence.
-        */
-       groups = ARRAY_SIZE(ice_recipe_pack);
-
-       /* Check if any of the preferred recipes from the grouping policy
-        * matches.
-        */
-       for (i = 0; i < groups; i++)
-               /* Check if the recipe from the preferred grouping matches
-                * or is a subset of the fields that needs to be looked up.
-                */
-               if (ice_is_recipe_subset(lkup_exts, &ice_recipe_pack[i])) {
-                       /* This recipe can be used by itself or grouped with
-                        * other recipes.
-                        */
-                       entry = (struct ice_recp_grp_entry *)
-                               ice_malloc(hw, sizeof(*entry));
-                       if (!entry) {
-                               status = ICE_ERR_NO_MEMORY;
-                               goto err_unroll;
-                       }
-                       entry->r_group = ice_recipe_pack[i];
-                       LIST_ADD(&entry->l_entry, &rm->rg_list);
-                       rm->n_grp_count++;
-               }
-
        /* Create recipes for words that are marked not done by packing them
         * as best fit.
         */
@@ -5139,17 +5333,8 @@ ice_create_recipe_group(struct ice_hw *hw, struct ice_sw_recipe *rm,
                           sizeof(rm->ext_words), ICE_NONDMA_TO_NONDMA);
                ice_memcpy(rm->word_masks, lkup_exts->field_mask,
                           sizeof(rm->word_masks), ICE_NONDMA_TO_NONDMA);
-               goto out;
-       }
-
-err_unroll:
-       LIST_FOR_EACH_ENTRY_SAFE(entry, tmp, &rm->rg_list, ice_recp_grp_entry,
-                                l_entry) {
-               LIST_DEL(&entry->l_entry);
-               ice_free(hw, entry);
        }
 
-out:
        return status;
 }
 
@@ -5159,11 +5344,12 @@ out:
  * @lkups: lookup elements or match criteria for the advanced recipe, one
  *        structure per protocol header
  * @lkups_cnt: number of protocols
+ * @bm: bitmap of field vectors to consider
  * @fv_list: pointer to a list that holds the returned field vectors
  */
 static enum ice_status
 ice_get_fv(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,
-          struct LIST_HEAD_TYPE *fv_list)
+          ice_bitmap_t *bm, struct LIST_HEAD_TYPE *fv_list)
 {
        enum ice_status status;
        u16 *prot_ids;
@@ -5180,13 +5366,81 @@ ice_get_fv(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,
                }
 
        /* Find field vectors that include all specified protocol types */
-       status = ice_get_sw_fv_list(hw, prot_ids, lkups_cnt, fv_list);
+       status = ice_get_sw_fv_list(hw, prot_ids, lkups_cnt, bm, fv_list);
 
 free_mem:
        ice_free(hw, prot_ids);
        return status;
 }
 
+/**
+ * ice_add_special_words - Add words that are not protocols, such as metadata
+ * @rinfo: other information regarding the rule e.g. priority and action info
+ * @lkup_exts: lookup word structure
+ */
+static enum ice_status
+ice_add_special_words(struct ice_adv_rule_info *rinfo,
+                     struct ice_prot_lkup_ext *lkup_exts)
+{
+       /* If this is a tunneled packet, then add recipe index to match the
+        * tunnel bit in the packet metadata flags.
+        */
+       if (rinfo->tun_type != ICE_NON_TUN) {
+               if (lkup_exts->n_val_words < ICE_MAX_CHAIN_WORDS) {
+                       u8 word = lkup_exts->n_val_words++;
+
+                       lkup_exts->fv_words[word].prot_id = ICE_META_DATA_ID_HW;
+                       lkup_exts->fv_words[word].off = ICE_TUN_FLAG_MDID *
+                               ICE_MDID_SIZE;
+                       lkup_exts->field_mask[word] = ICE_TUN_FLAG_MASK;
+               } else {
+                       return ICE_ERR_MAX_LIMIT;
+               }
+       }
+
+       return ICE_SUCCESS;
+}
+
+/* ice_get_compat_fv_bitmap - Get compatible field vector bitmap for rule
+ * @hw: pointer to hardware structure
+ * @rinfo: other information regarding the rule e.g. priority and action info
+ * @bm: pointer to memory for returning the bitmap of field vectors
+ */
+static void
+ice_get_compat_fv_bitmap(struct ice_hw *hw, struct ice_adv_rule_info *rinfo,
+                        ice_bitmap_t *bm)
+{
+       enum ice_prof_type type;
+
+       switch (rinfo->tun_type) {
+       case ICE_NON_TUN:
+               type = ICE_PROF_NON_TUN;
+               break;
+       case ICE_ALL_TUNNELS:
+               type = ICE_PROF_TUN_ALL;
+               break;
+       case ICE_SW_TUN_VXLAN_GPE:
+       case ICE_SW_TUN_GENEVE:
+       case ICE_SW_TUN_VXLAN:
+       case ICE_SW_TUN_UDP:
+       case ICE_SW_TUN_GTP:
+               type = ICE_PROF_TUN_UDP;
+               break;
+       case ICE_SW_TUN_NVGRE:
+               type = ICE_PROF_TUN_GRE;
+               break;
+       case ICE_SW_TUN_PPPOE:
+               type = ICE_PROF_TUN_PPPOE;
+               break;
+       case ICE_SW_TUN_AND_NON_TUN:
+       default:
+               type = ICE_PROF_ALL;
+               break;
+       }
+
+       ice_get_sw_fv_bitmap(hw, type, bm);
+}
+
 /**
  * ice_add_adv_recipe - Add an advanced recipe that is not part of the default
  * @hw: pointer to hardware structure
@@ -5200,6 +5454,8 @@ static enum ice_status
 ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
                   u16 lkups_cnt, struct ice_adv_rule_info *rinfo, u16 *rid)
 {
+       ice_declare_bitmap(fv_bitmap, ICE_MAX_NUM_PROFILES);
+       ice_declare_bitmap(profiles, ICE_MAX_NUM_PROFILES);
        struct ice_prot_lkup_ext *lkup_exts;
        struct ice_recp_grp_entry *r_entry;
        struct ice_sw_fv_list_entry *fvit;
@@ -5236,13 +5492,6 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
                }
        }
 
-       *rid = ice_find_recp(hw, lkup_exts);
-       if (*rid < ICE_MAX_NUM_RECIPES)
-               /* Success if found a recipe that match the existing criteria */
-               goto err_free_lkup_exts;
-
-       /* Recipe we need does not exist, add a recipe */
-
        rm = (struct ice_sw_recipe *)ice_malloc(hw, sizeof(*rm));
        if (!rm) {
                status = ICE_ERR_NO_MEMORY;
@@ -5255,7 +5504,13 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
        INIT_LIST_HEAD(&rm->fv_list);
        INIT_LIST_HEAD(&rm->rg_list);
 
-       status = ice_get_fv(hw, lkups, lkups_cnt, &rm->fv_list);
+       /* Get bitmap of field vectors (profiles) that are compatible with the
+        * rule request; only these will be searched in the subsequent call to
+        * ice_get_fv.
+        */
+       ice_get_compat_fv_bitmap(hw, rinfo, fv_bitmap);
+
+       status = ice_get_fv(hw, lkups, lkups_cnt, fv_bitmap, &rm->fv_list);
        if (status)
                goto err_unroll;
 
@@ -5281,8 +5536,33 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
        /* Find offsets from the field vector. Pick the first one for all the
         * recipes.
         */
-       ice_fill_fv_word_index(hw, &rm->fv_list, &rm->rg_list);
-       status = ice_add_sw_recipe(hw, rm, match_tun);
+       status = ice_fill_fv_word_index(hw, &rm->fv_list, &rm->rg_list);
+       if (status)
+               goto err_unroll;
+
+       /* get bitmap of all profiles the recipe will be associated with */
+       ice_zero_bitmap(profiles, ICE_MAX_NUM_PROFILES);
+       LIST_FOR_EACH_ENTRY(fvit, &rm->fv_list, ice_sw_fv_list_entry,
+                           list_entry) {
+               ice_debug(hw, ICE_DBG_SW, "profile: %d\n", fvit->profile_id);
+               ice_set_bit((u16)fvit->profile_id, profiles);
+       }
+
+       /* Create any special protocol/offset pairs, such as looking at tunnel
+        * bits by extracting metadata
+        */
+       status = ice_add_special_words(rinfo, lkup_exts);
+       if (status)
+               goto err_free_lkup_exts;
+
+       /* Look for a recipe which matches our requested fv / mask list */
+       *rid = ice_find_recp(hw, lkup_exts);
+       if (*rid < ICE_MAX_NUM_RECIPES)
+               /* Success if found a recipe that match the existing criteria */
+               goto err_unroll;
+
+       /* Recipe we need does not exist, add a recipe */
+       status = ice_add_sw_recipe(hw, rm, match_tun, profiles);
        if (status)
                goto err_unroll;
 
@@ -5292,6 +5572,7 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
        LIST_FOR_EACH_ENTRY(fvit, &rm->fv_list, ice_sw_fv_list_entry,
                            list_entry) {
                ice_declare_bitmap(r_bitmap, ICE_MAX_NUM_RECIPES);
+               u16 j;
 
                status = ice_aq_get_recipe_to_profile(hw, fvit->profile_id,
                                                      (u8 *)r_bitmap, NULL);
@@ -5311,6 +5592,16 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
 
                if (status)
                        goto err_unroll;
+
+               /* Update profile to recipe bitmap array */
+               ice_memcpy(profile_to_recipe[fvit->profile_id], rm->r_bitmap,
+                          sizeof(rm->r_bitmap), ICE_NONDMA_TO_NONDMA);
+
+               /* Update recipe to profile bitmap array */
+               for (j = 0; j < ICE_MAX_NUM_RECIPES; j++)
+                       if (ice_is_bit_set(rm->r_bitmap, j))
+                               ice_set_bit((u16)fvit->profile_id,
+                                           recipe_to_profile[j]);
        }
 
        *rid = rm->root_rid;
@@ -5360,6 +5651,18 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,
        bool tcp = false, udp = false, ipv6 = false;
        u16 i;
 
+       if (tun_type == ICE_SW_TUN_GTP) {
+               *pkt = dummy_udp_gtp_packet;
+               *pkt_len = sizeof(dummy_udp_gtp_packet);
+               *offsets = dummy_udp_gtp_packet_offsets;
+               return;
+       }
+       if (tun_type == ICE_SW_TUN_PPPOE) {
+               *pkt = dummy_pppoe_packet;
+               *pkt_len = sizeof(dummy_pppoe_packet);
+               *offsets = dummy_pppoe_packet_offsets;
+               return;
+       }
        for (i = 0; i < lkups_cnt; i++) {
                if (lkups[i].type == ICE_UDP_ILOS)
                        udp = true;
@@ -5369,10 +5672,24 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,
                        ipv6 = true;
        }
 
-       if (tun_type == ICE_SW_TUN_NVGRE || tun_type == ICE_ALL_TUNNELS) {
-               *pkt = dummy_gre_packet;
-               *pkt_len = sizeof(dummy_gre_packet);
-               *offsets = dummy_gre_packet_offsets;
+       if (tun_type == ICE_ALL_TUNNELS) {
+               *pkt = dummy_gre_udp_packet;
+               *pkt_len = sizeof(dummy_gre_udp_packet);
+               *offsets = dummy_gre_udp_packet_offsets;
+               return;
+       }
+
+       if (tun_type == ICE_SW_TUN_NVGRE) {
+               if (tcp) {
+                       *pkt = dummy_gre_tcp_packet;
+                       *pkt_len = sizeof(dummy_gre_tcp_packet);
+                       *offsets = dummy_gre_tcp_packet_offsets;
+                       return;
+               }
+
+               *pkt = dummy_gre_udp_packet;
+               *pkt_len = sizeof(dummy_gre_udp_packet);
+               *offsets = dummy_gre_udp_packet_offsets;
                return;
        }
 
@@ -5492,6 +5809,10 @@ ice_fill_adv_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,
                case ICE_VXLAN_GPE:
                        len = sizeof(struct ice_udp_tnl_hdr);
                        break;
+
+               case ICE_GTP:
+                       len = sizeof(struct ice_udp_gtp_hdr);
+                       break;
                default:
                        return ICE_ERR_PARAM;
                }
@@ -5521,6 +5842,55 @@ ice_fill_adv_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,
        return ICE_SUCCESS;
 }
 
+/**
+ * ice_fill_adv_packet_tun - fill dummy packet with udp tunnel port
+ * @hw: pointer to the hardware structure
+ * @tun_type: tunnel type
+ * @pkt: dummy packet to fill in
+ * @offsets: offset info for the dummy packet
+ */
+static enum ice_status
+ice_fill_adv_packet_tun(struct ice_hw *hw, enum ice_sw_tunnel_type tun_type,
+                       u8 *pkt, const struct ice_dummy_pkt_offsets *offsets)
+{
+       u16 open_port, i;
+
+       switch (tun_type) {
+       case ICE_SW_TUN_AND_NON_TUN:
+       case ICE_SW_TUN_VXLAN_GPE:
+       case ICE_SW_TUN_VXLAN:
+       case ICE_SW_TUN_UDP:
+               if (!ice_get_open_tunnel_port(hw, TNL_VXLAN, &open_port))
+                       return ICE_ERR_CFG;
+               break;
+
+       case ICE_SW_TUN_GENEVE:
+               if (!ice_get_open_tunnel_port(hw, TNL_GENEVE, &open_port))
+                       return ICE_ERR_CFG;
+               break;
+
+       default:
+               /* Nothing needs to be done for this tunnel type */
+               return ICE_SUCCESS;
+       }
+
+       /* Find the outer UDP protocol header and insert the port number */
+       for (i = 0; offsets[i].type != ICE_PROTOCOL_LAST; i++) {
+               if (offsets[i].type == ICE_UDP_OF) {
+                       struct ice_l4_hdr *hdr;
+                       u16 offset;
+
+                       offset = offsets[i].offset;
+                       hdr = (struct ice_l4_hdr *)&pkt[offset];
+                       hdr->dst_port = open_port << 8 | open_port >> 8;
+
+                       return ICE_SUCCESS;
+               }
+       }
+
+       return ICE_ERR_CFG;
+}
+
 /**
  * ice_find_adv_rule_entry - Search a rule entry
  * @hw: pointer to the hardware structure
@@ -5702,27 +6072,24 @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
        struct ice_switch_info *sw;
        enum ice_status status;
        const u8 *pkt = NULL;
-       bool found = false;
+       u16 word_cnt;
        u32 act = 0;
        u8 q_rgn;
 
        if (!lkups_cnt)
                return ICE_ERR_PARAM;
 
+       /* get # of words we need to match */
+       word_cnt = 0;
        for (i = 0; i < lkups_cnt; i++) {
                u16 j, *ptr;
 
-               /* Validate match masks to make sure that there is something
-                * to match.
-                */
                ptr = (u16 *)&lkups[i].m_u;
                for (j = 0; j < sizeof(lkups->m_u) / sizeof(u16); j++)
-                       if (ptr[j] != 0) {
-                               found = true;
-                               break;
-                       }
+                       if (ptr[j] != 0)
+                               word_cnt++;
        }
-       if (!found)
+       if (!word_cnt || word_cnt > ICE_MAX_CHAIN_WORDS)
                return ICE_ERR_PARAM;
 
        /* make sure that we can locate a dummy packet */
@@ -5828,6 +6195,14 @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
        ice_fill_adv_dummy_packet(lkups, lkups_cnt, s_rule, pkt, pkt_len,
                                  pkt_offsets);
 
+       if (rinfo->tun_type != ICE_NON_TUN) {
+               status = ice_fill_adv_packet_tun(hw, rinfo->tun_type,
+                                                s_rule->pdata.lkup_tx_rx.hdr,
+                                                pkt_offsets);
+               if (status)
+                       goto err_ice_add_adv_rule;
+       }
+
        status = ice_aq_sw_rules(hw, (struct ice_aqc_sw_rules *)s_rule,
                                 rule_buf_sz, 1, ice_aqc_opc_add_sw_rules,
                                 NULL);
@@ -5961,9 +6336,7 @@ ice_adv_rem_update_vsi_list(struct ice_hw *hw, u16 vsi_handle,
                                  tmp_fltr.fwd_id.hw_vsi_id, status);
                        return status;
                }
-       }
 
-       if (fm_list->vsi_count == 1) {
                /* Remove the VSI list since it is no longer used */
                status = ice_remove_vsi_list_rule(hw, vsi_list_id, lkup_type);
                if (status) {
@@ -6002,14 +6375,11 @@ ice_rem_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
                 u16 lkups_cnt, struct ice_adv_rule_info *rinfo)
 {
        struct ice_adv_fltr_mgmt_list_entry *list_elem;
-       const struct ice_dummy_pkt_offsets *offsets;
        struct ice_prot_lkup_ext lkup_exts;
-       u16 rule_buf_sz, pkt_len, i, rid;
        struct ice_lock *rule_lock; /* Lock to protect filter rule list */
        enum ice_status status = ICE_SUCCESS;
        bool remove_rule = false;
-       const u8 *pkt = NULL;
-       u16 vsi_handle;
+       u16 i, rid, vsi_handle;
 
        ice_memset(&lkup_exts, 0, sizeof(lkup_exts), ICE_NONDMA_MEM);
        for (i = 0; i < lkups_cnt; i++) {
@@ -6022,6 +6392,14 @@ ice_rem_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
                if (!count)
                        return ICE_ERR_CFG;
        }
+
+       /* Create any special protocol/offset pairs, such as looking at tunnel
+        * bits by extracting metadata
+        */
+       status = ice_add_special_words(rinfo, &lkup_exts);
+       if (status)
+               return status;
+
        rid = ice_find_recp(hw, &lkup_exts);
        /* If did not find a recipe that match the existing criteria */
        if (rid == ICE_MAX_NUM_RECIPES)
@@ -6053,10 +6431,9 @@ ice_rem_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
        ice_release_lock(rule_lock);
        if (remove_rule) {
                struct ice_aqc_sw_rules_elem *s_rule;
+               u16 rule_buf_sz;
 
-               ice_find_dummy_packet(lkups, lkups_cnt, rinfo->tun_type, &pkt,
-                                     &pkt_len, &offsets);
-               rule_buf_sz = ICE_SW_RULE_RX_TX_NO_HDR_SIZE + pkt_len;
+               rule_buf_sz = ICE_SW_RULE_RX_TX_NO_HDR_SIZE;
                s_rule =
                        (struct ice_aqc_sw_rules_elem *)ice_malloc(hw,
                                                                   rule_buf_sz);