ethdev: change promiscuous callbacks to return status
[dpdk.git] / drivers / net / ice / ice_ethdev.c
index 429c2b6..17867b9 100644 (file)
 #include "base/ice_dcb.h"
 #include "ice_ethdev.h"
 #include "ice_rxtx.h"
+#include "ice_switch_filter.h"
+
+/* devargs */
+#define ICE_SAFE_MODE_SUPPORT_ARG "safe-mode-support"
+
+static const char * const ice_valid_args[] = {
+       ICE_SAFE_MODE_SUPPORT_ARG,
+       NULL
+};
 
-#define ICE_MAX_QP_NUM "max_queue_pair_num"
 #define ICE_DFLT_OUTER_TAG_TYPE ICE_AQ_VSI_OUTER_TAG_VLAN_9100
-#define ICE_DFLT_PKG_FILE "/lib/firmware/intel/ice/ddp/ice.pkg"
+
+/* DDP package search path */
+#define ICE_PKG_FILE_DEFAULT "/lib/firmware/intel/ice/ddp/ice.pkg"
+#define ICE_PKG_FILE_UPDATES "/lib/firmware/updates/intel/ice/ddp/ice.pkg"
+#define ICE_PKG_FILE_SEARCH_PATH_DEFAULT "/lib/firmware/intel/ice/ddp/"
+#define ICE_PKG_FILE_SEARCH_PATH_UPDATES "/lib/firmware/updates/intel/ice/ddp/"
+
+#define ICE_OS_DEFAULT_PKG_NAME                "ICE OS Default Package"
+#define ICE_COMMS_PKG_NAME                     "ICE COMMS Package"
+#define ICE_MAX_PKG_FILENAME_SIZE   256
 
 int ice_logtype_init;
 int ice_logtype_driver;
@@ -28,10 +45,13 @@ static int ice_dev_start(struct rte_eth_dev *dev);
 static void ice_dev_stop(struct rte_eth_dev *dev);
 static void ice_dev_close(struct rte_eth_dev *dev);
 static int ice_dev_reset(struct rte_eth_dev *dev);
-static void ice_dev_info_get(struct rte_eth_dev *dev,
-                            struct rte_eth_dev_info *dev_info);
+static int ice_dev_info_get(struct rte_eth_dev *dev,
+                           struct rte_eth_dev_info *dev_info);
 static int ice_link_update(struct rte_eth_dev *dev,
                           int wait_to_complete);
+static int ice_dev_set_link_up(struct rte_eth_dev *dev);
+static int ice_dev_set_link_down(struct rte_eth_dev *dev);
+
 static int ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
 static int ice_vlan_offload_set(struct rte_eth_dev *dev, int mask);
 static int ice_vlan_tpid_set(struct rte_eth_dev *dev,
@@ -47,17 +67,17 @@ static int ice_rss_hash_update(struct rte_eth_dev *dev,
                               struct rte_eth_rss_conf *rss_conf);
 static int ice_rss_hash_conf_get(struct rte_eth_dev *dev,
                                 struct rte_eth_rss_conf *rss_conf);
-static void ice_promisc_enable(struct rte_eth_dev *dev);
-static void ice_promisc_disable(struct rte_eth_dev *dev);
+static int ice_promisc_enable(struct rte_eth_dev *dev);
+static int ice_promisc_disable(struct rte_eth_dev *dev);
 static void ice_allmulti_enable(struct rte_eth_dev *dev);
 static void ice_allmulti_disable(struct rte_eth_dev *dev);
 static int ice_vlan_filter_set(struct rte_eth_dev *dev,
                               uint16_t vlan_id,
                               int on);
 static int ice_macaddr_set(struct rte_eth_dev *dev,
-                          struct ether_addr *mac_addr);
+                          struct rte_ether_addr *mac_addr);
 static int ice_macaddr_add(struct rte_eth_dev *dev,
-                          struct ether_addr *mac_addr,
+                          struct rte_ether_addr *mac_addr,
                           __rte_unused uint32_t index,
                           uint32_t pool);
 static void ice_macaddr_remove(struct rte_eth_dev *dev, uint32_t index);
@@ -80,6 +100,14 @@ static int ice_xstats_get(struct rte_eth_dev *dev,
 static int ice_xstats_get_names(struct rte_eth_dev *dev,
                                struct rte_eth_xstat_name *xstats_names,
                                unsigned int limit);
+static int ice_dev_filter_ctrl(struct rte_eth_dev *dev,
+                       enum rte_filter_type filter_type,
+                       enum rte_filter_op filter_op,
+                       void *arg);
+static int ice_dev_udp_tunnel_port_add(struct rte_eth_dev *dev,
+                       struct rte_eth_udp_tunnel *udp_tunnel);
+static int ice_dev_udp_tunnel_port_del(struct rte_eth_dev *dev,
+                       struct rte_eth_udp_tunnel *udp_tunnel);
 
 static const struct rte_pci_id pci_id_ice_map[] = {
        { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810C_BACKPLANE) },
@@ -94,6 +122,8 @@ static const struct eth_dev_ops ice_eth_dev_ops = {
        .dev_stop                     = ice_dev_stop,
        .dev_close                    = ice_dev_close,
        .dev_reset                    = ice_dev_reset,
+       .dev_set_link_up              = ice_dev_set_link_up,
+       .dev_set_link_down            = ice_dev_set_link_down,
        .rx_queue_start               = ice_rx_queue_start,
        .rx_queue_stop                = ice_rx_queue_stop,
        .tx_queue_start               = ice_tx_queue_start,
@@ -136,6 +166,9 @@ static const struct eth_dev_ops ice_eth_dev_ops = {
        .xstats_get                   = ice_xstats_get,
        .xstats_get_names             = ice_xstats_get_names,
        .xstats_reset                 = ice_stats_reset,
+       .filter_ctrl                  = ice_dev_filter_ctrl,
+       .udp_tunnel_port_add          = ice_dev_udp_tunnel_port_add,
+       .udp_tunnel_port_del          = ice_dev_udp_tunnel_port_del,
 };
 
 /* store statistics names and its offset in stats structure */
@@ -148,13 +181,13 @@ static const struct ice_xstats_name_off ice_stats_strings[] = {
        {"rx_unicast_packets", offsetof(struct ice_eth_stats, rx_unicast)},
        {"rx_multicast_packets", offsetof(struct ice_eth_stats, rx_multicast)},
        {"rx_broadcast_packets", offsetof(struct ice_eth_stats, rx_broadcast)},
-       {"rx_dropped", offsetof(struct ice_eth_stats, rx_discards)},
+       {"rx_dropped_packets", offsetof(struct ice_eth_stats, rx_discards)},
        {"rx_unknown_protocol_packets", offsetof(struct ice_eth_stats,
                rx_unknown_protocol)},
        {"tx_unicast_packets", offsetof(struct ice_eth_stats, tx_unicast)},
        {"tx_multicast_packets", offsetof(struct ice_eth_stats, tx_multicast)},
        {"tx_broadcast_packets", offsetof(struct ice_eth_stats, tx_broadcast)},
-       {"tx_dropped", offsetof(struct ice_eth_stats, tx_discards)},
+       {"tx_dropped_packets", offsetof(struct ice_eth_stats, tx_discards)},
 };
 
 #define ICE_NB_ETH_XSTATS (sizeof(ice_stats_strings) / \
@@ -233,59 +266,6 @@ ice_init_controlq_parameter(struct ice_hw *hw)
        hw->mailboxq.sq_buf_size = ICE_MAILBOXQ_BUF_SZ;
 }
 
-static int
-ice_check_qp_num(const char *key, const char *qp_value,
-                __rte_unused void *opaque)
-{
-       char *end = NULL;
-       int num = 0;
-
-       while (isblank(*qp_value))
-               qp_value++;
-
-       num = strtoul(qp_value, &end, 10);
-
-       if (!num || (*end == '-') || errno) {
-               PMD_DRV_LOG(WARNING, "invalid value:\"%s\" for key:\"%s\", "
-                           "value must be > 0",
-                           qp_value, key);
-               return -1;
-       }
-
-       return num;
-}
-
-static int
-ice_config_max_queue_pair_num(struct rte_devargs *devargs)
-{
-       struct rte_kvargs *kvlist;
-       const char *queue_num_key = ICE_MAX_QP_NUM;
-       int ret;
-
-       if (!devargs)
-               return 0;
-
-       kvlist = rte_kvargs_parse(devargs->args, NULL);
-       if (!kvlist)
-               return 0;
-
-       if (!rte_kvargs_count(kvlist, queue_num_key)) {
-               rte_kvargs_free(kvlist);
-               return 0;
-       }
-
-       if (rte_kvargs_process(kvlist, queue_num_key,
-                              ice_check_qp_num, NULL) < 0) {
-               rte_kvargs_free(kvlist);
-               return 0;
-       }
-       ret = rte_kvargs_process(kvlist, queue_num_key,
-                                ice_check_qp_num, NULL);
-       rte_kvargs_free(kvlist);
-
-       return ret;
-}
-
 static int
 ice_res_pool_init(struct ice_res_pool_info *pool, uint32_t base,
                  uint32_t num)
@@ -480,35 +460,38 @@ ice_init_mac_address(struct rte_eth_dev *dev)
 {
        struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
-       if (!is_unicast_ether_addr
-               ((struct ether_addr *)hw->port_info[0].mac.lan_addr)) {
+       if (!rte_is_unicast_ether_addr
+               ((struct rte_ether_addr *)hw->port_info[0].mac.lan_addr)) {
                PMD_INIT_LOG(ERR, "Invalid MAC address");
                return -EINVAL;
        }
 
-       ether_addr_copy((struct ether_addr *)hw->port_info[0].mac.lan_addr,
-                       (struct ether_addr *)hw->port_info[0].mac.perm_addr);
+       rte_ether_addr_copy(
+               (struct rte_ether_addr *)hw->port_info[0].mac.lan_addr,
+               (struct rte_ether_addr *)hw->port_info[0].mac.perm_addr);
 
-       dev->data->mac_addrs = rte_zmalloc(NULL, sizeof(struct ether_addr), 0);
+       dev->data->mac_addrs =
+               rte_zmalloc(NULL, sizeof(struct rte_ether_addr), 0);
        if (!dev->data->mac_addrs) {
                PMD_INIT_LOG(ERR,
                             "Failed to allocate memory to store mac address");
                return -ENOMEM;
        }
        /* store it to dev data */
-       ether_addr_copy((struct ether_addr *)hw->port_info[0].mac.perm_addr,
-                       &dev->data->mac_addrs[0]);
+       rte_ether_addr_copy(
+               (struct rte_ether_addr *)hw->port_info[0].mac.perm_addr,
+               &dev->data->mac_addrs[0]);
        return 0;
 }
 
 /* Find out specific MAC filter */
 static struct ice_mac_filter *
-ice_find_mac_filter(struct ice_vsi *vsi, struct ether_addr *macaddr)
+ice_find_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *macaddr)
 {
        struct ice_mac_filter *f;
 
        TAILQ_FOREACH(f, &vsi->mac_list, next) {
-               if (is_same_ether_addr(macaddr, &f->mac_info.mac_addr))
+               if (rte_is_same_ether_addr(macaddr, &f->mac_info.mac_addr))
                        return f;
        }
 
@@ -516,7 +499,7 @@ ice_find_mac_filter(struct ice_vsi *vsi, struct ether_addr *macaddr)
 }
 
 static int
-ice_add_mac_filter(struct ice_vsi *vsi, struct ether_addr *mac_addr)
+ice_add_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *mac_addr)
 {
        struct ice_fltr_list_entry *m_list_itr = NULL;
        struct ice_mac_filter *f;
@@ -575,7 +558,7 @@ DONE:
 }
 
 static int
-ice_remove_mac_filter(struct ice_vsi *vsi, struct ether_addr *mac_addr)
+ice_remove_mac_filter(struct ice_vsi *vsi, struct rte_ether_addr *mac_addr)
 {
        struct ice_fltr_list_entry *m_list_itr = NULL;
        struct ice_mac_filter *f;
@@ -648,7 +631,7 @@ ice_add_vlan_filter(struct ice_vsi *vsi, uint16_t vlan_id)
        struct ice_hw *hw;
        int ret = 0;
 
-       if (!vsi || vlan_id > ETHER_MAX_VLAN_ID)
+       if (!vsi || vlan_id > RTE_ETHER_MAX_VLAN_ID)
                return -EINVAL;
 
        hw = ICE_VSI_TO_HW(vsi);
@@ -719,7 +702,7 @@ ice_remove_vlan_filter(struct ice_vsi *vsi, uint16_t vlan_id)
         * Vlan 0 is the generic filter for untagged packets
         * and can't be removed.
         */
-       if (!vsi || vlan_id == 0 || vlan_id > ETHER_MAX_VLAN_ID)
+       if (!vsi || vlan_id == 0 || vlan_id > RTE_ETHER_MAX_VLAN_ID)
                return -EINVAL;
 
        hw = ICE_VSI_TO_HW(vsi);
@@ -1098,7 +1081,7 @@ ice_interrupt_handler(void *param)
 done:
        /* Enable interrupt */
        ice_pf_enable_irq0(hw);
-       rte_intr_enable(dev->intr_handle);
+       rte_intr_ack(dev->intr_handle);
 }
 
 /*  Initialize SW parameters of PF */
@@ -1108,13 +1091,9 @@ ice_pf_sw_init(struct rte_eth_dev *dev)
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
        struct ice_hw *hw = ICE_PF_TO_HW(pf);
 
-       if (ice_config_max_queue_pair_num(dev->device->devargs) > 0)
-               pf->lan_nb_qp_max =
-                       ice_config_max_queue_pair_num(dev->device->devargs);
-       else
-               pf->lan_nb_qp_max =
-                       (uint16_t)RTE_MIN(hw->func_caps.common_cap.num_txq,
-                                         hw->func_caps.common_cap.num_rxq);
+       pf->lan_nb_qp_max =
+               (uint16_t)RTE_MIN(hw->func_caps.common_cap.num_txq,
+                                 hw->func_caps.common_cap.num_rxq);
 
        pf->lan_nb_qps = pf->lan_nb_qp_max;
 
@@ -1128,9 +1107,9 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
        struct ice_vsi *vsi = NULL;
        struct ice_vsi_ctx vsi_ctx;
        int ret;
-       struct ether_addr broadcast = {
+       struct rte_ether_addr broadcast = {
                .addr_bytes = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff} };
-       struct ether_addr mac_addr;
+       struct rte_ether_addr mac_addr;
        uint16_t max_txqs[ICE_MAX_TRAFFIC_CLASS] = { 0 };
        uint8_t tc_bitmap = 0x1;
 
@@ -1149,6 +1128,12 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
        TAILQ_INIT(&vsi->mac_list);
        TAILQ_INIT(&vsi->vlan_list);
 
+       /* Be sync with ETH_RSS_RETA_SIZE_x maximum value definition */
+       pf->hash_lut_size = hw->func_caps.common_cap.rss_table_size >
+                       ETH_RSS_RETA_SIZE_512 ? ETH_RSS_RETA_SIZE_512 :
+                       hw->func_caps.common_cap.rss_table_size;
+       pf->flags |= ICE_FLAG_RSS_AQ_CAPABLE;
+
        memset(&vsi_ctx, 0, sizeof(vsi_ctx));
        /* base_queue in used in queue mapping of VSI add/update command.
         * Suppose vsi->base_queue is 0 now, don't consider SRIOV, VMDQ
@@ -1221,12 +1206,12 @@ ice_setup_vsi(struct ice_pf *pf, enum ice_vsi_type type)
                   hw->port_info->mac.perm_addr,
                   ETH_ADDR_LEN);
 
-       rte_memcpy(&mac_addr, &pf->dev_addr, ETHER_ADDR_LEN);
+       rte_memcpy(&mac_addr, &pf->dev_addr, RTE_ETHER_ADDR_LEN);
        ret = ice_add_mac_filter(vsi, &mac_addr);
        if (ret != ICE_SUCCESS)
                PMD_INIT_LOG(ERR, "Failed to add dflt MAC filter");
 
-       rte_memcpy(&mac_addr, &broadcast, ETHER_ADDR_LEN);
+       rte_memcpy(&mac_addr, &broadcast, RTE_ETHER_ADDR_LEN);
        ret = ice_add_mac_filter(vsi, &mac_addr);
        if (ret != ICE_SUCCESS)
                PMD_INIT_LOG(ERR, "Failed to add MAC filter");
@@ -1287,15 +1272,132 @@ ice_pf_setup(struct ice_pf *pf)
        return 0;
 }
 
+/* PCIe configuration space setting */
+#define PCI_CFG_SPACE_SIZE          256
+#define PCI_CFG_SPACE_EXP_SIZE      4096
+#define PCI_EXT_CAP_ID(header)      (int)((header) & 0x0000ffff)
+#define PCI_EXT_CAP_NEXT(header)    (((header) >> 20) & 0xffc)
+#define PCI_EXT_CAP_ID_DSN          0x03
+
+static int
+ice_pci_find_next_ext_capability(struct rte_pci_device *dev, int cap)
+{
+       uint32_t header;
+       int ttl;
+       int pos = PCI_CFG_SPACE_SIZE;
+
+       /* minimum 8 bytes per capability */
+       ttl = (PCI_CFG_SPACE_EXP_SIZE - PCI_CFG_SPACE_SIZE) / 8;
+
+       if (rte_pci_read_config(dev, &header, 4, pos) < 0) {
+               PMD_INIT_LOG(ERR, "ice error reading extended capabilities\n");
+               return -1;
+       }
+
+       /*
+        * If we have no capabilities, this is indicated by cap ID,
+        * cap version and next pointer all being 0.
+        */
+       if (header == 0)
+               return 0;
+
+       while (ttl-- > 0) {
+               if (PCI_EXT_CAP_ID(header) == cap)
+                       return pos;
+
+               pos = PCI_EXT_CAP_NEXT(header);
+
+               if (pos < PCI_CFG_SPACE_SIZE)
+                       break;
+
+               if (rte_pci_read_config(dev, &header, 4, pos) < 0) {
+                       PMD_INIT_LOG(ERR, "ice error reading extended capabilities\n");
+                       return -1;
+               }
+       }
+
+       return 0;
+}
+
+/*
+ * Extract device serial number from PCIe Configuration Space and
+ * determine the pkg file path according to the DSN.
+ */
+static int
+ice_pkg_file_search_path(struct rte_pci_device *pci_dev, char *pkg_file)
+{
+       int pos;
+       char opt_ddp_filename[ICE_MAX_PKG_FILENAME_SIZE];
+       uint32_t dsn_low, dsn_high;
+       memset(opt_ddp_filename, 0, ICE_MAX_PKG_FILENAME_SIZE);
+
+       pos = ice_pci_find_next_ext_capability(pci_dev, PCI_EXT_CAP_ID_DSN);
+
+       if (pos) {
+               rte_pci_read_config(pci_dev, &dsn_low, 4, pos + 4);
+               rte_pci_read_config(pci_dev, &dsn_high, 4, pos + 8);
+               snprintf(opt_ddp_filename, ICE_MAX_PKG_FILENAME_SIZE,
+                        "ice-%08x%08x.pkg", dsn_high, dsn_low);
+       } else {
+               PMD_INIT_LOG(ERR, "Failed to read device serial number\n");
+               goto fail_dsn;
+       }
+
+       strncpy(pkg_file, ICE_PKG_FILE_SEARCH_PATH_UPDATES,
+               ICE_MAX_PKG_FILENAME_SIZE);
+       if (!access(strcat(pkg_file, opt_ddp_filename), 0))
+               return 0;
+
+       strncpy(pkg_file, ICE_PKG_FILE_SEARCH_PATH_DEFAULT,
+               ICE_MAX_PKG_FILENAME_SIZE);
+       if (!access(strcat(pkg_file, opt_ddp_filename), 0))
+               return 0;
+
+fail_dsn:
+       strncpy(pkg_file, ICE_PKG_FILE_UPDATES, ICE_MAX_PKG_FILENAME_SIZE);
+       if (!access(pkg_file, 0))
+               return 0;
+       strncpy(pkg_file, ICE_PKG_FILE_DEFAULT, ICE_MAX_PKG_FILENAME_SIZE);
+       return 0;
+}
+
+static enum ice_pkg_type
+ice_load_pkg_type(struct ice_hw *hw)
+{
+       enum ice_pkg_type package_type;
+
+       /* store the activated package type (OS default or Comms) */
+       if (!strncmp((char *)hw->active_pkg_name, ICE_OS_DEFAULT_PKG_NAME,
+               ICE_PKG_NAME_SIZE))
+               package_type = ICE_PKG_TYPE_OS_DEFAULT;
+       else if (!strncmp((char *)hw->active_pkg_name, ICE_COMMS_PKG_NAME,
+               ICE_PKG_NAME_SIZE))
+               package_type = ICE_PKG_TYPE_COMMS;
+       else
+               package_type = ICE_PKG_TYPE_UNKNOWN;
+
+       PMD_INIT_LOG(NOTICE, "Active package is: %d.%d.%d.%d, %s",
+               hw->active_pkg_ver.major, hw->active_pkg_ver.minor,
+               hw->active_pkg_ver.update, hw->active_pkg_ver.draft,
+               hw->active_pkg_name);
+
+       return package_type;
+}
+
 static int ice_load_pkg(struct rte_eth_dev *dev)
 {
        struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       const char *pkg_file = ICE_DFLT_PKG_FILE;
+       char pkg_file[ICE_MAX_PKG_FILENAME_SIZE];
        int err;
        uint8_t *buf;
        int buf_len;
        FILE *file;
        struct stat fstat;
+       struct rte_pci_device *pci_dev = RTE_DEV_TO_PCI(dev->device);
+       struct ice_adapter *ad =
+               ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+
+       ice_pkg_file_search_path(pci_dev, pkg_file);
 
        file = fopen(pkg_file, "rb");
        if (!file)  {
@@ -1335,6 +1437,10 @@ static int ice_load_pkg(struct rte_eth_dev *dev)
                PMD_INIT_LOG(ERR, "ice_copy_and_init_hw failed: %d\n", err);
                goto fail_exit;
        }
+
+       /* store the loaded pkg type info */
+       ad->active_pkg_type = ice_load_pkg_type(hw);
+
        err = ice_init_hw_tbls(hw);
        if (err) {
                PMD_INIT_LOG(ERR, "ice_init_hw_tbls failed: %d\n", err);
@@ -1350,6 +1456,97 @@ fail_exit:
        return err;
 }
 
+static void
+ice_base_queue_get(struct ice_pf *pf)
+{
+       uint32_t reg;
+       struct ice_hw *hw = ICE_PF_TO_HW(pf);
+
+       reg = ICE_READ_REG(hw, PFLAN_RX_QALLOC);
+       if (reg & PFLAN_RX_QALLOC_VALID_M) {
+               pf->base_queue = reg & PFLAN_RX_QALLOC_FIRSTQ_M;
+       } else {
+               PMD_INIT_LOG(WARNING, "Failed to get Rx base queue"
+                                       " index");
+       }
+}
+
+static int
+parse_bool(const char *key, const char *value, void *args)
+{
+       int *i = (int *)args;
+       char *end;
+       int num;
+
+       num = strtoul(value, &end, 10);
+
+       if (num != 0 && num != 1) {
+               PMD_DRV_LOG(WARNING, "invalid value:\"%s\" for key:\"%s\", "
+                       "value must be 0 or 1",
+                       value, key);
+               return -1;
+       }
+
+       *i = num;
+       return 0;
+}
+
+static int ice_parse_devargs(struct rte_eth_dev *dev)
+{
+       struct ice_adapter *ad =
+               ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+       struct rte_devargs *devargs = dev->device->devargs;
+       struct rte_kvargs *kvlist;
+       int ret;
+
+       if (devargs == NULL)
+               return 0;
+
+       kvlist = rte_kvargs_parse(devargs->args, ice_valid_args);
+       if (kvlist == NULL) {
+               PMD_INIT_LOG(ERR, "Invalid kvargs key\n");
+               return -EINVAL;
+       }
+
+       ret = rte_kvargs_process(kvlist, ICE_SAFE_MODE_SUPPORT_ARG,
+                                &parse_bool, &ad->devargs.safe_mode_support);
+
+       rte_kvargs_free(kvlist);
+       return ret;
+}
+
+/* Forward LLDP packets to default VSI by set switch rules */
+static int
+ice_vsi_config_sw_lldp(struct ice_vsi *vsi,  bool on)
+{
+       struct ice_hw *hw = ICE_VSI_TO_HW(vsi);
+       struct ice_fltr_list_entry *s_list_itr = NULL;
+       struct LIST_HEAD_TYPE list_head;
+       int ret = 0;
+
+       INIT_LIST_HEAD(&list_head);
+
+       s_list_itr = (struct ice_fltr_list_entry *)
+                       ice_malloc(hw, sizeof(*s_list_itr));
+       if (!s_list_itr)
+               return -ENOMEM;
+       s_list_itr->fltr_info.lkup_type = ICE_SW_LKUP_ETHERTYPE;
+       s_list_itr->fltr_info.vsi_handle = vsi->idx;
+       s_list_itr->fltr_info.l_data.ethertype_mac.ethertype =
+                       RTE_ETHER_TYPE_LLDP;
+       s_list_itr->fltr_info.fltr_act = ICE_FWD_TO_VSI;
+       s_list_itr->fltr_info.flag = ICE_FLTR_RX;
+       s_list_itr->fltr_info.src_id = ICE_SRC_ID_LPORT;
+       LIST_ADD(&s_list_itr->list_entry, &list_head);
+       if (on)
+               ret = ice_add_eth_mac(hw, &list_head);
+       else
+               ret = ice_remove_eth_mac(hw, &list_head);
+
+       rte_free(s_list_itr);
+       return ret;
+}
+
 static int
 ice_dev_init(struct rte_eth_dev *dev)
 {
@@ -1367,6 +1564,15 @@ ice_dev_init(struct rte_eth_dev *dev)
        dev->tx_pkt_burst = ice_xmit_pkts;
        dev->tx_pkt_prepare = ice_prep_pkts;
 
+       /* for secondary processes, we don't initialise any further as primary
+        * has already done this work.
+        */
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+               ice_set_rx_function(dev);
+               ice_set_tx_function(dev);
+               return 0;
+       }
+
        ice_set_default_ptype_table(dev);
        pci_dev = RTE_DEV_TO_PCI(dev->device);
        intr_handle = &pci_dev->intr_handle;
@@ -1383,6 +1589,12 @@ ice_dev_init(struct rte_eth_dev *dev)
        hw->bus.device = pci_dev->addr.devid;
        hw->bus.func = pci_dev->addr.function;
 
+       ret = ice_parse_devargs(dev);
+       if (ret) {
+               PMD_INIT_LOG(ERR, "Failed to parse devargs");
+               return -EINVAL;
+       }
+
        ice_init_controlq_parameter(hw);
 
        ret = ice_init_hw(hw);
@@ -1393,8 +1605,14 @@ ice_dev_init(struct rte_eth_dev *dev)
 
        ret = ice_load_pkg(dev);
        if (ret) {
+               if (ad->devargs.safe_mode_support == 0) {
+                       PMD_INIT_LOG(ERR, "Failed to load the DDP package,"
+                                       "Use safe-mode-support=1 to enter Safe Mode");
+                       return ret;
+               }
+
                PMD_INIT_LOG(WARNING, "Failed to load the DDP package,"
-                               "Entering Safe Mode");
+                                       "Entering Safe Mode");
                ad->is_safe_mode = 1;
        }
 
@@ -1433,10 +1651,16 @@ ice_dev_init(struct rte_eth_dev *dev)
        /* Disable double vlan by default */
        ice_vsi_config_double_vlan(vsi, FALSE);
 
-       ret = ice_aq_stop_lldp(hw, TRUE, NULL);
+       ret = ice_aq_stop_lldp(hw, TRUE, FALSE, NULL);
        if (ret != ICE_SUCCESS)
                PMD_INIT_LOG(DEBUG, "lldp has already stopped\n");
-
+       ret = ice_init_dcb(hw, TRUE);
+       if (ret != ICE_SUCCESS)
+               PMD_INIT_LOG(DEBUG, "Failed to init DCB\n");
+       /* Forward LLDP packets to default VSI */
+       ret = ice_vsi_config_sw_lldp(vsi, TRUE);
+       if (ret != ICE_SUCCESS)
+               PMD_INIT_LOG(DEBUG, "Failed to cfg lldp\n");
        /* register callback func to eal lib */
        rte_intr_callback_register(intr_handle,
                                   ice_interrupt_handler, dev);
@@ -1446,12 +1670,18 @@ ice_dev_init(struct rte_eth_dev *dev)
        /* enable uio intr after callback register */
        rte_intr_enable(intr_handle);
 
+       /* get base queue pairs index  in the device */
+       ice_base_queue_get(pf);
+
+       TAILQ_INIT(&pf->flow_list);
+
        return 0;
 
 err_pf_setup:
        ice_res_pool_destroy(&pf->msix_pool);
 err_msix_pool_init:
        rte_free(dev->data->mac_addrs);
+       dev->data->mac_addrs = NULL;
 err_init_mac:
        ice_sched_cleanup_all(hw);
        rte_free(hw->port_info);
@@ -1545,6 +1775,8 @@ ice_dev_stop(struct rte_eth_dev *dev)
        /* Clear all queues and release mbufs */
        ice_clear_queues(dev);
 
+       ice_dev_set_link_down(dev);
+
        /* Clean datapath event and queue/vec mapping */
        rte_intr_efd_disable(intr_handle);
        if (intr_handle->intr_vec) {
@@ -1561,6 +1793,13 @@ ice_dev_close(struct rte_eth_dev *dev)
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
        struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
+       /* Since stop will make link down, then the link event will be
+        * triggered, disable the irq firstly to avoid the port_infoe etc
+        * resources deallocation causing the interrupt service thread
+        * crash.
+        */
+       ice_pf_disable_irq0(hw);
+
        ice_dev_stop(dev);
 
        /* release all queue resource */
@@ -1570,6 +1809,7 @@ ice_dev_close(struct rte_eth_dev *dev)
        ice_release_vsi(pf->main_vsi);
        ice_sched_cleanup_all(hw);
        rte_free(hw->port_info);
+       hw->port_info = NULL;
        ice_shutdown_all_ctrlq(hw);
 }
 
@@ -1578,6 +1818,11 @@ ice_dev_uninit(struct rte_eth_dev *dev)
 {
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
+       struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+       struct rte_flow *p_flow;
+
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
 
        ice_dev_close(dev);
 
@@ -1591,15 +1836,22 @@ ice_dev_uninit(struct rte_eth_dev *dev)
        /* disable uio intr before callback unregister */
        rte_intr_disable(intr_handle);
 
-       /* register callback func to eal lib */
+       /* unregister callback func from eal lib */
        rte_intr_callback_unregister(intr_handle,
                                     ice_interrupt_handler, dev);
 
+       /* Remove all flows */
+       while ((p_flow = TAILQ_FIRST(&pf->flow_list))) {
+               TAILQ_REMOVE(&pf->flow_list, p_flow, node);
+               ice_free_switch_filter_rule(p_flow->rule);
+               rte_free(p_flow);
+       }
+
        return 0;
 }
 
 static int
-ice_dev_configure(__rte_unused struct rte_eth_dev *dev)
+ice_dev_configure(struct rte_eth_dev *dev)
 {
        struct ice_adapter *ad =
                ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
@@ -1627,7 +1879,7 @@ static int ice_init_rss(struct ice_pf *pf)
        rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;
        nb_q = dev->data->nb_rx_queues;
        vsi->rss_key_size = ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE;
-       vsi->rss_lut_size = hw->func_caps.common_cap.rss_table_size;
+       vsi->rss_lut_size = pf->hash_lut_size;
 
        if (is_safe_mode) {
                PMD_DRV_LOG(WARNING, "RSS is not supported in safe mode\n");
@@ -1940,6 +2192,8 @@ ice_dev_start(struct rte_eth_dev *dev)
        if (ret != ICE_SUCCESS)
                PMD_DRV_LOG(WARNING, "Fail to set phy mask");
 
+       ice_dev_set_link_up(dev);
+
        /* Call get_link_info aq commond to enable/disable LSE */
        ice_link_update(dev, 0);
 
@@ -1981,7 +2235,7 @@ ice_dev_reset(struct rte_eth_dev *dev)
        return 0;
 }
 
-static void
+static int
 ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 {
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
@@ -1998,6 +2252,8 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        dev_info->max_tx_queues = vsi->nb_qps;
        dev_info->max_mac_addrs = vsi->max_macaddrs;
        dev_info->max_vfs = pci_dev->max_vfs;
+       dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
+       dev_info->min_mtu = RTE_ETHER_MIN_MTU;
 
        dev_info->rx_offload_capa =
                DEV_RX_OFFLOAD_VLAN_STRIP |
@@ -2026,14 +2282,15 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
                        DEV_TX_OFFLOAD_UDP_CKSUM |
                        DEV_TX_OFFLOAD_TCP_CKSUM |
                        DEV_TX_OFFLOAD_SCTP_CKSUM |
-                       DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM;
+                       DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
+                       DEV_TX_OFFLOAD_OUTER_UDP_CKSUM;
                dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
        }
 
        dev_info->rx_queue_offload_capa = 0;
        dev_info->tx_queue_offload_capa = 0;
 
-       dev_info->reta_size = hw->func_caps.common_cap.rss_table_size;
+       dev_info->reta_size = pf->hash_lut_size;
        dev_info->hash_key_size = (VSIQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t);
 
        dev_info->default_rxconf = (struct rte_eth_rxconf) {
@@ -2098,6 +2355,8 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
        dev_info->default_txportconf.nb_queues = 1;
        dev_info->default_rxportconf.ring_size = ICE_BUF_SIZE_MIN;
        dev_info->default_txportconf.ring_size = ICE_BUF_SIZE_MIN;
+
+       return 0;
 }
 
 static inline int
@@ -2129,7 +2388,7 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev,
 }
 
 static int
-ice_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete)
+ice_link_update(struct rte_eth_dev *dev, int wait_to_complete)
 {
 #define CHECK_INTERVAL 100  /* 100ms */
 #define MAX_REPEAT_TIME 10  /* 1s (10 * 100ms) in total */
@@ -2222,6 +2481,74 @@ out:
        return 0;
 }
 
+/* Force the physical link state by getting the current PHY capabilities from
+ * hardware and setting the PHY config based on the determined capabilities. If
+ * link changes, link event will be triggered because both the Enable Automatic
+ * Link Update and LESM Enable bits are set when setting the PHY capabilities.
+ */
+static enum ice_status
+ice_force_phys_link_state(struct ice_hw *hw, bool link_up)
+{
+       struct ice_aqc_set_phy_cfg_data cfg = { 0 };
+       struct ice_aqc_get_phy_caps_data *pcaps;
+       struct ice_port_info *pi;
+       enum ice_status status;
+
+       if (!hw || !hw->port_info)
+               return ICE_ERR_PARAM;
+
+       pi = hw->port_info;
+
+       pcaps = (struct ice_aqc_get_phy_caps_data *)
+               ice_malloc(hw, sizeof(*pcaps));
+       if (!pcaps)
+               return ICE_ERR_NO_MEMORY;
+
+       status = ice_aq_get_phy_caps(pi, false, ICE_AQC_REPORT_SW_CFG, pcaps,
+                                    NULL);
+       if (status)
+               goto out;
+
+       /* No change in link */
+       if (link_up == !!(pcaps->caps & ICE_AQC_PHY_EN_LINK) &&
+           link_up == !!(pi->phy.link_info.link_info & ICE_AQ_LINK_UP))
+               goto out;
+
+       cfg.phy_type_low = pcaps->phy_type_low;
+       cfg.phy_type_high = pcaps->phy_type_high;
+       cfg.caps = pcaps->caps | ICE_AQ_PHY_ENA_AUTO_LINK_UPDT;
+       cfg.low_power_ctrl = pcaps->low_power_ctrl;
+       cfg.eee_cap = pcaps->eee_cap;
+       cfg.eeer_value = pcaps->eeer_value;
+       cfg.link_fec_opt = pcaps->link_fec_options;
+       if (link_up)
+               cfg.caps |= ICE_AQ_PHY_ENA_LINK;
+       else
+               cfg.caps &= ~ICE_AQ_PHY_ENA_LINK;
+
+       status = ice_aq_set_phy_cfg(hw, pi, &cfg, NULL);
+
+out:
+       ice_free(hw, pcaps);
+       return status;
+}
+
+static int
+ice_dev_set_link_up(struct rte_eth_dev *dev)
+{
+       struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       return ice_force_phys_link_state(hw, true);
+}
+
+static int
+ice_dev_set_link_down(struct rte_eth_dev *dev)
+{
+       struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       return ice_force_phys_link_state(hw, false);
+}
+
 static int
 ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 {
@@ -2230,7 +2557,7 @@ ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
        uint32_t frame_size = mtu + ICE_ETH_OVERHEAD;
 
        /* check if mtu is within the allowed range */
-       if (mtu < ETHER_MIN_MTU || frame_size > ICE_FRAME_SIZE_MAX)
+       if (mtu < RTE_ETHER_MIN_MTU || frame_size > ICE_FRAME_SIZE_MAX)
                return -EINVAL;
 
        /* mtu setting is forbidden if port is start */
@@ -2241,7 +2568,7 @@ ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
                return -EBUSY;
        }
 
-       if (frame_size > ETHER_MAX_LEN)
+       if (frame_size > RTE_ETHER_MAX_LEN)
                dev_data->dev_conf.rxmode.offloads |=
                        DEV_RX_OFFLOAD_JUMBO_FRAME;
        else
@@ -2254,7 +2581,7 @@ ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 }
 
 static int ice_macaddr_set(struct rte_eth_dev *dev,
-                          struct ether_addr *mac_addr)
+                          struct rte_ether_addr *mac_addr)
 {
        struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
@@ -2263,13 +2590,13 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,
        uint8_t flags = 0;
        int ret;
 
-       if (!is_valid_assigned_ether_addr(mac_addr)) {
+       if (!rte_is_valid_assigned_ether_addr(mac_addr)) {
                PMD_DRV_LOG(ERR, "Tried to set invalid MAC address.");
                return -EINVAL;
        }
 
        TAILQ_FOREACH(f, &vsi->mac_list, next) {
-               if (is_same_ether_addr(&pf->dev_addr, &f->mac_info.mac_addr))
+               if (rte_is_same_ether_addr(&pf->dev_addr, &f->mac_info.mac_addr))
                        break;
        }
 
@@ -2301,7 +2628,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,
 /* Add a MAC address, and update filters */
 static int
 ice_macaddr_add(struct rte_eth_dev *dev,
-               struct ether_addr *mac_addr,
+               struct rte_ether_addr *mac_addr,
                __rte_unused uint32_t index,
                __rte_unused uint32_t pool)
 {
@@ -2325,7 +2652,7 @@ ice_macaddr_remove(struct rte_eth_dev *dev, uint32_t index)
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
        struct ice_vsi *vsi = pf->main_vsi;
        struct rte_eth_dev_data *data = dev->data;
-       struct ether_addr *macaddr;
+       struct rte_ether_addr *macaddr;
        int ret;
 
        macaddr = &data->mac_addrs[index];
@@ -2506,7 +2833,7 @@ ice_vlan_tpid_set(struct rte_eth_dev *dev,
                        reg_id = 3;
                else
                        reg_id = 5;
-       break;
+               break;
        case ETH_VLAN_TYPE_INNER:
                if (qinq) {
                        reg_id = 5;
@@ -2605,28 +2932,31 @@ ice_rss_reta_update(struct rte_eth_dev *dev,
                    uint16_t reta_size)
 {
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
-       struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       uint16_t i, lut_size = hw->func_caps.common_cap.rss_table_size;
+       uint16_t i, lut_size = pf->hash_lut_size;
        uint16_t idx, shift;
        uint8_t *lut;
        int ret;
 
-       if (reta_size != lut_size ||
-           reta_size > ETH_RSS_RETA_SIZE_512) {
+       if (reta_size != ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_128 &&
+           reta_size != ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_512 &&
+           reta_size != ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_2K) {
                PMD_DRV_LOG(ERR,
                            "The size of hash lookup table configured (%d)"
                            "doesn't match the number hardware can "
-                           "supported (%d)",
-                           reta_size, lut_size);
+                           "supported (128, 512, 2048)",
+                           reta_size);
                return -EINVAL;
        }
 
-       lut = rte_zmalloc(NULL, reta_size, 0);
+       /* It MUST use the current LUT size to get the RSS lookup table,
+        * otherwise if will fail with -100 error code.
+        */
+       lut = rte_zmalloc(NULL,  RTE_MAX(reta_size, lut_size), 0);
        if (!lut) {
                PMD_DRV_LOG(ERR, "No memory can be allocated");
                return -ENOMEM;
        }
-       ret = ice_get_rss_lut(pf->main_vsi, lut, reta_size);
+       ret = ice_get_rss_lut(pf->main_vsi, lut, lut_size);
        if (ret)
                goto out;
 
@@ -2637,6 +2967,12 @@ ice_rss_reta_update(struct rte_eth_dev *dev,
                        lut[i] = reta_conf[idx].reta[shift];
        }
        ret = ice_set_rss_lut(pf->main_vsi, lut, reta_size);
+       if (ret == 0 && lut_size != reta_size) {
+               PMD_DRV_LOG(INFO,
+                           "The size of hash lookup table is changed from (%d) to (%d)",
+                           lut_size, reta_size);
+               pf->hash_lut_size = reta_size;
+       }
 
 out:
        rte_free(lut);
@@ -2650,14 +2986,12 @@ ice_rss_reta_query(struct rte_eth_dev *dev,
                   uint16_t reta_size)
 {
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
-       struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-       uint16_t i, lut_size = hw->func_caps.common_cap.rss_table_size;
+       uint16_t i, lut_size = pf->hash_lut_size;
        uint16_t idx, shift;
        uint8_t *lut;
        int ret;
 
-       if (reta_size != lut_size ||
-           reta_size > ETH_RSS_RETA_SIZE_512) {
+       if (reta_size != lut_size) {
                PMD_DRV_LOG(ERR,
                            "The size of hash lookup table configured (%d)"
                            "doesn't match the number hardware can "
@@ -2769,7 +3103,7 @@ ice_rss_hash_conf_get(struct rte_eth_dev *dev,
        return 0;
 }
 
-static void
+static int
 ice_promisc_enable(struct rte_eth_dev *dev)
 {
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
@@ -2777,18 +3111,26 @@ ice_promisc_enable(struct rte_eth_dev *dev)
        struct ice_vsi *vsi = pf->main_vsi;
        enum ice_status status;
        uint8_t pmask;
+       int ret = 0;
 
        pmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX |
                ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX;
 
        status = ice_set_vsi_promisc(hw, vsi->idx, pmask, 0);
-       if (status == ICE_ERR_ALREADY_EXISTS)
+       switch (status) {
+       case ICE_ERR_ALREADY_EXISTS:
                PMD_DRV_LOG(DEBUG, "Promisc mode has already been enabled");
-       else if (status != ICE_SUCCESS)
+       case ICE_SUCCESS:
+               break;
+       default:
                PMD_DRV_LOG(ERR, "Failed to enable promisc, err=%d", status);
+               ret = -EAGAIN;
+       }
+
+       return ret;
 }
 
-static void
+static int
 ice_promisc_disable(struct rte_eth_dev *dev)
 {
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
@@ -2796,13 +3138,18 @@ ice_promisc_disable(struct rte_eth_dev *dev)
        struct ice_vsi *vsi = pf->main_vsi;
        enum ice_status status;
        uint8_t pmask;
+       int ret = 0;
 
        pmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX |
                ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX;
 
        status = ice_clear_vsi_promisc(hw, vsi->idx, pmask, 0);
-       if (status != ICE_SUCCESS)
+       if (status != ICE_SUCCESS) {
                PMD_DRV_LOG(ERR, "Failed to clear promisc, err=%d", status);
+               ret = -EAGAIN;
+       }
+
+       return ret;
 }
 
 static void
@@ -2856,7 +3203,7 @@ static int ice_rx_queue_intr_enable(struct rte_eth_dev *dev,
        val &= ~GLINT_DYN_CTL_WB_ON_ITR_M;
 
        ICE_WRITE_REG(hw, GLINT_DYN_CTL(msix_intr), val);
-       rte_intr_enable(&pci_dev->intr_handle);
+       rte_intr_ack(&pci_dev->intr_handle);
 
        return 0;
 }
@@ -3009,8 +3356,8 @@ ice_get_eeprom(struct rte_eth_dev *dev,
        last_word = (eeprom->offset + eeprom->length - 1) >> 1;
        nwords = last_word - first_word + 1;
 
-       if (first_word > hw->nvm.sr_words ||
-           last_word > hw->nvm.sr_words) {
+       if (first_word >= hw->nvm.sr_words ||
+           last_word >= hw->nvm.sr_words) {
                PMD_DRV_LOG(ERR, "Requested EEPROM bytes out of range.");
                return -EINVAL;
        }
@@ -3098,7 +3445,7 @@ ice_update_vsi_stats(struct ice_vsi *vsi)
                           &nes->rx_broadcast);
        /* exclude CRC bytes */
        nes->rx_bytes -= (nes->rx_unicast + nes->rx_multicast +
-                         nes->rx_broadcast) * ETHER_CRC_LEN;
+                         nes->rx_broadcast) * RTE_ETHER_CRC_LEN;
 
        ice_stat_update_32(hw, GLV_RDPC(idx), vsi->offset_loaded,
                           &oes->rx_discards, &nes->rx_discards);
@@ -3171,10 +3518,11 @@ ice_read_stats_registers(struct ice_pf *pf, struct ice_hw *hw)
                           &ns->eth.rx_discards);
 
        /* Workaround: CRC size should not be included in byte statistics,
-        * so subtract ETHER_CRC_LEN from the byte counter for each rx packet.
+        * so subtract RTE_ETHER_CRC_LEN from the byte counter for each rx
+        * packet.
         */
        ns->eth.rx_bytes -= (ns->eth.rx_unicast + ns->eth.rx_multicast +
-                            ns->eth.rx_broadcast) * ETHER_CRC_LEN;
+                            ns->eth.rx_broadcast) * RTE_ETHER_CRC_LEN;
 
        /* GLPRT_REPC not supported */
        /* GLPRT_RMPC not supported */
@@ -3199,7 +3547,7 @@ ice_read_stats_registers(struct ice_pf *pf, struct ice_hw *hw)
                           pf->offset_loaded, &os->eth.tx_broadcast,
                           &ns->eth.tx_broadcast);
        ns->eth.tx_bytes -= (ns->eth.tx_unicast + ns->eth.tx_multicast +
-                            ns->eth.tx_broadcast) * ETHER_CRC_LEN;
+                            ns->eth.tx_broadcast) * RTE_ETHER_CRC_LEN;
 
        /* GLPRT_TEPC not supported */
 
@@ -3326,15 +3674,14 @@ ice_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
        /* call read registers - updates values, now write them to struct */
        ice_read_stats_registers(pf, hw);
 
-       stats->ipackets = ns->eth.rx_unicast +
-                         ns->eth.rx_multicast +
-                         ns->eth.rx_broadcast -
-                         ns->eth.rx_discards -
+       stats->ipackets = pf->main_vsi->eth_stats.rx_unicast +
+                         pf->main_vsi->eth_stats.rx_multicast +
+                         pf->main_vsi->eth_stats.rx_broadcast -
                          pf->main_vsi->eth_stats.rx_discards;
        stats->opackets = ns->eth.tx_unicast +
                          ns->eth.tx_multicast +
                          ns->eth.tx_broadcast;
-       stats->ibytes   = ns->eth.rx_bytes;
+       stats->ibytes   = pf->main_vsi->eth_stats.rx_bytes;
        stats->obytes   = ns->eth.tx_bytes;
        stats->oerrors  = ns->eth.tx_errors +
                          pf->main_vsi->eth_stats.tx_errors;
@@ -3499,6 +3846,81 @@ static int ice_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
        return count;
 }
 
+static int
+ice_dev_filter_ctrl(struct rte_eth_dev *dev,
+                    enum rte_filter_type filter_type,
+                    enum rte_filter_op filter_op,
+                    void *arg)
+{
+       int ret = 0;
+
+       if (!dev)
+               return -EINVAL;
+
+       switch (filter_type) {
+       case RTE_ETH_FILTER_GENERIC:
+               if (filter_op != RTE_ETH_FILTER_GET)
+                       return -EINVAL;
+               *(const void **)arg = &ice_flow_ops;
+               break;
+       default:
+               PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
+                                       filter_type);
+               ret = -EINVAL;
+               break;
+       }
+
+       return ret;
+}
+
+/* Add UDP tunneling port */
+static int
+ice_dev_udp_tunnel_port_add(struct rte_eth_dev *dev,
+                            struct rte_eth_udp_tunnel *udp_tunnel)
+{
+       int ret = 0;
+       struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       if (udp_tunnel == NULL)
+               return -EINVAL;
+
+       switch (udp_tunnel->prot_type) {
+       case RTE_TUNNEL_TYPE_VXLAN:
+               ret = ice_create_tunnel(hw, TNL_VXLAN, udp_tunnel->udp_port);
+               break;
+       default:
+               PMD_DRV_LOG(ERR, "Invalid tunnel type");
+               ret = -EINVAL;
+               break;
+       }
+
+       return ret;
+}
+
+/* Delete UDP tunneling port */
+static int
+ice_dev_udp_tunnel_port_del(struct rte_eth_dev *dev,
+                            struct rte_eth_udp_tunnel *udp_tunnel)
+{
+       int ret = 0;
+       struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       if (udp_tunnel == NULL)
+               return -EINVAL;
+
+       switch (udp_tunnel->prot_type) {
+       case RTE_TUNNEL_TYPE_VXLAN:
+               ret = ice_destroy_tunnel(hw, udp_tunnel->udp_port, 0);
+               break;
+       default:
+               PMD_DRV_LOG(ERR, "Invalid tunnel type");
+               ret = -EINVAL;
+               break;
+       }
+
+       return ret;
+}
+
 static int
 ice_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
              struct rte_pci_device *pci_dev)
@@ -3516,8 +3938,7 @@ ice_pci_remove(struct rte_pci_device *pci_dev)
 
 static struct rte_pci_driver rte_ice_pmd = {
        .id_table = pci_id_ice_map,
-       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |
-                    RTE_PCI_DRV_IOVA_AS_VA,
+       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
        .probe = ice_pci_probe,
        .remove = ice_pci_remove,
 };
@@ -3531,7 +3952,7 @@ RTE_PMD_REGISTER_PCI(net_ice, rte_ice_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_ice, pci_id_ice_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_ice, "* igb_uio | uio_pci_generic | vfio-pci");
 RTE_PMD_REGISTER_PARAM_STRING(net_ice,
-                             ICE_MAX_QP_NUM "=<int>");
+                             ICE_SAFE_MODE_SUPPORT_ARG "=<0|1>");
 
 RTE_INIT(ice_init_log)
 {