net/ice: remove unused parameter tag
[dpdk.git] / drivers / net / ice / ice_ethdev.c
index 203d0a9..44a14cb 100644 (file)
 #include "base/ice_dcb.h"
 #include "ice_ethdev.h"
 #include "ice_rxtx.h"
+#include "ice_switch_filter.h"
+
+/* devargs */
+#define ICE_SAFE_MODE_SUPPORT_ARG "safe-mode-support"
+
+static const char * const ice_valid_args[] = {
+       ICE_SAFE_MODE_SUPPORT_ARG,
+       NULL
+};
 
-#define ICE_MAX_QP_NUM "max_queue_pair_num"
 #define ICE_DFLT_OUTER_TAG_TYPE ICE_AQ_VSI_OUTER_TAG_VLAN_9100
 #define ICE_DFLT_PKG_FILE "/lib/firmware/intel/ice/ddp/ice.pkg"
 
@@ -83,6 +91,14 @@ static int ice_xstats_get(struct rte_eth_dev *dev,
 static int ice_xstats_get_names(struct rte_eth_dev *dev,
                                struct rte_eth_xstat_name *xstats_names,
                                unsigned int limit);
+static int ice_dev_filter_ctrl(struct rte_eth_dev *dev,
+                       enum rte_filter_type filter_type,
+                       enum rte_filter_op filter_op,
+                       void *arg);
+static int ice_dev_udp_tunnel_port_add(struct rte_eth_dev *dev,
+                       struct rte_eth_udp_tunnel *udp_tunnel);
+static int ice_dev_udp_tunnel_port_del(struct rte_eth_dev *dev,
+                       struct rte_eth_udp_tunnel *udp_tunnel);
 
 static const struct rte_pci_id pci_id_ice_map[] = {
        { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E810C_BACKPLANE) },
@@ -141,6 +157,9 @@ static const struct eth_dev_ops ice_eth_dev_ops = {
        .xstats_get                   = ice_xstats_get,
        .xstats_get_names             = ice_xstats_get_names,
        .xstats_reset                 = ice_stats_reset,
+       .filter_ctrl                  = ice_dev_filter_ctrl,
+       .udp_tunnel_port_add          = ice_dev_udp_tunnel_port_add,
+       .udp_tunnel_port_del          = ice_dev_udp_tunnel_port_del,
 };
 
 /* store statistics names and its offset in stats structure */
@@ -238,59 +257,6 @@ ice_init_controlq_parameter(struct ice_hw *hw)
        hw->mailboxq.sq_buf_size = ICE_MAILBOXQ_BUF_SZ;
 }
 
-static int
-ice_check_qp_num(const char *key, const char *qp_value,
-                __rte_unused void *opaque)
-{
-       char *end = NULL;
-       int num = 0;
-
-       while (isblank(*qp_value))
-               qp_value++;
-
-       num = strtoul(qp_value, &end, 10);
-
-       if (!num || (*end == '-') || errno) {
-               PMD_DRV_LOG(WARNING, "invalid value:\"%s\" for key:\"%s\", "
-                           "value must be > 0",
-                           qp_value, key);
-               return -1;
-       }
-
-       return num;
-}
-
-static int
-ice_config_max_queue_pair_num(struct rte_devargs *devargs)
-{
-       struct rte_kvargs *kvlist;
-       const char *queue_num_key = ICE_MAX_QP_NUM;
-       int ret;
-
-       if (!devargs)
-               return 0;
-
-       kvlist = rte_kvargs_parse(devargs->args, NULL);
-       if (!kvlist)
-               return 0;
-
-       if (!rte_kvargs_count(kvlist, queue_num_key)) {
-               rte_kvargs_free(kvlist);
-               return 0;
-       }
-
-       if (rte_kvargs_process(kvlist, queue_num_key,
-                              ice_check_qp_num, NULL) < 0) {
-               rte_kvargs_free(kvlist);
-               return 0;
-       }
-       ret = rte_kvargs_process(kvlist, queue_num_key,
-                                ice_check_qp_num, NULL);
-       rte_kvargs_free(kvlist);
-
-       return ret;
-}
-
 static int
 ice_res_pool_init(struct ice_res_pool_info *pool, uint32_t base,
                  uint32_t num)
@@ -1106,7 +1072,7 @@ ice_interrupt_handler(void *param)
 done:
        /* Enable interrupt */
        ice_pf_enable_irq0(hw);
-       rte_intr_enable(dev->intr_handle);
+       rte_intr_ack(dev->intr_handle);
 }
 
 /*  Initialize SW parameters of PF */
@@ -1116,13 +1082,9 @@ ice_pf_sw_init(struct rte_eth_dev *dev)
        struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
        struct ice_hw *hw = ICE_PF_TO_HW(pf);
 
-       if (ice_config_max_queue_pair_num(dev->device->devargs) > 0)
-               pf->lan_nb_qp_max =
-                       ice_config_max_queue_pair_num(dev->device->devargs);
-       else
-               pf->lan_nb_qp_max =
-                       (uint16_t)RTE_MIN(hw->func_caps.common_cap.num_txq,
-                                         hw->func_caps.common_cap.num_rxq);
+       pf->lan_nb_qp_max =
+               (uint16_t)RTE_MIN(hw->func_caps.common_cap.num_txq,
+                                 hw->func_caps.common_cap.num_rxq);
 
        pf->lan_nb_qps = pf->lan_nb_qp_max;
 
@@ -1364,6 +1326,97 @@ fail_exit:
        return err;
 }
 
+static void
+ice_base_queue_get(struct ice_pf *pf)
+{
+       uint32_t reg;
+       struct ice_hw *hw = ICE_PF_TO_HW(pf);
+
+       reg = ICE_READ_REG(hw, PFLAN_RX_QALLOC);
+       if (reg & PFLAN_RX_QALLOC_VALID_M) {
+               pf->base_queue = reg & PFLAN_RX_QALLOC_FIRSTQ_M;
+       } else {
+               PMD_INIT_LOG(WARNING, "Failed to get Rx base queue"
+                                       " index");
+       }
+}
+
+static int
+parse_bool(const char *key, const char *value, void *args)
+{
+       int *i = (int *)args;
+       char *end;
+       int num;
+
+       num = strtoul(value, &end, 10);
+
+       if (num != 0 && num != 1) {
+               PMD_DRV_LOG(WARNING, "invalid value:\"%s\" for key:\"%s\", "
+                       "value must be 0 or 1",
+                       value, key);
+               return -1;
+       }
+
+       *i = num;
+       return 0;
+}
+
+static int ice_parse_devargs(struct rte_eth_dev *dev)
+{
+       struct ice_adapter *ad =
+               ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+       struct rte_devargs *devargs = dev->device->devargs;
+       struct rte_kvargs *kvlist;
+       int ret;
+
+       if (devargs == NULL)
+               return 0;
+
+       kvlist = rte_kvargs_parse(devargs->args, ice_valid_args);
+       if (kvlist == NULL) {
+               PMD_INIT_LOG(ERR, "Invalid kvargs key\n");
+               return -EINVAL;
+       }
+
+       ret = rte_kvargs_process(kvlist, ICE_SAFE_MODE_SUPPORT_ARG,
+                                &parse_bool, &ad->devargs.safe_mode_support);
+
+       rte_kvargs_free(kvlist);
+       return ret;
+}
+
+/* Forward LLDP packets to default VSI by set switch rules */
+static int
+ice_vsi_config_sw_lldp(struct ice_vsi *vsi,  bool on)
+{
+       struct ice_hw *hw = ICE_VSI_TO_HW(vsi);
+       struct ice_fltr_list_entry *s_list_itr = NULL;
+       struct LIST_HEAD_TYPE list_head;
+       int ret = 0;
+
+       INIT_LIST_HEAD(&list_head);
+
+       s_list_itr = (struct ice_fltr_list_entry *)
+                       ice_malloc(hw, sizeof(*s_list_itr));
+       if (!s_list_itr)
+               return -ENOMEM;
+       s_list_itr->fltr_info.lkup_type = ICE_SW_LKUP_ETHERTYPE;
+       s_list_itr->fltr_info.vsi_handle = vsi->idx;
+       s_list_itr->fltr_info.l_data.ethertype_mac.ethertype =
+                       RTE_ETHER_TYPE_LLDP;
+       s_list_itr->fltr_info.fltr_act = ICE_FWD_TO_VSI;
+       s_list_itr->fltr_info.flag = ICE_FLTR_RX;
+       s_list_itr->fltr_info.src_id = ICE_SRC_ID_LPORT;
+       LIST_ADD(&s_list_itr->list_entry, &list_head);
+       if (on)
+               ret = ice_add_eth_mac(hw, &list_head);
+       else
+               ret = ice_remove_eth_mac(hw, &list_head);
+
+       rte_free(s_list_itr);
+       return ret;
+}
+
 static int
 ice_dev_init(struct rte_eth_dev *dev)
 {
@@ -1397,6 +1450,12 @@ ice_dev_init(struct rte_eth_dev *dev)
        hw->bus.device = pci_dev->addr.devid;
        hw->bus.func = pci_dev->addr.function;
 
+       ret = ice_parse_devargs(dev);
+       if (ret) {
+               PMD_INIT_LOG(ERR, "Failed to parse devargs");
+               return -EINVAL;
+       }
+
        ice_init_controlq_parameter(hw);
 
        ret = ice_init_hw(hw);
@@ -1407,8 +1466,14 @@ ice_dev_init(struct rte_eth_dev *dev)
 
        ret = ice_load_pkg(dev);
        if (ret) {
+               if (ad->devargs.safe_mode_support == 0) {
+                       PMD_INIT_LOG(ERR, "Failed to load the DDP package,"
+                                       "Use safe-mode-support=1 to enter Safe Mode");
+                       return ret;
+               }
+
                PMD_INIT_LOG(WARNING, "Failed to load the DDP package,"
-                               "Entering Safe Mode");
+                                       "Entering Safe Mode");
                ad->is_safe_mode = 1;
        }
 
@@ -1450,7 +1515,13 @@ ice_dev_init(struct rte_eth_dev *dev)
        ret = ice_aq_stop_lldp(hw, TRUE, FALSE, NULL);
        if (ret != ICE_SUCCESS)
                PMD_INIT_LOG(DEBUG, "lldp has already stopped\n");
-
+       ret = ice_init_dcb(hw, TRUE);
+       if (ret != ICE_SUCCESS)
+               PMD_INIT_LOG(DEBUG, "Failed to init DCB\n");
+       /* Forward LLDP packets to default VSI */
+       ret = ice_vsi_config_sw_lldp(vsi, TRUE);
+       if (ret != ICE_SUCCESS)
+               PMD_INIT_LOG(DEBUG, "Failed to cfg lldp\n");
        /* register callback func to eal lib */
        rte_intr_callback_register(intr_handle,
                                   ice_interrupt_handler, dev);
@@ -1460,12 +1531,18 @@ ice_dev_init(struct rte_eth_dev *dev)
        /* enable uio intr after callback register */
        rte_intr_enable(intr_handle);
 
+       /* get base queue pairs index  in the device */
+       ice_base_queue_get(pf);
+
+       TAILQ_INIT(&pf->flow_list);
+
        return 0;
 
 err_pf_setup:
        ice_res_pool_destroy(&pf->msix_pool);
 err_msix_pool_init:
        rte_free(dev->data->mac_addrs);
+       dev->data->mac_addrs = NULL;
 err_init_mac:
        ice_sched_cleanup_all(hw);
        rte_free(hw->port_info);
@@ -1602,6 +1679,8 @@ ice_dev_uninit(struct rte_eth_dev *dev)
 {
        struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
        struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
+       struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+       struct rte_flow *p_flow;
 
        ice_dev_close(dev);
 
@@ -1619,11 +1698,18 @@ ice_dev_uninit(struct rte_eth_dev *dev)
        rte_intr_callback_unregister(intr_handle,
                                     ice_interrupt_handler, dev);
 
+       /* Remove all flows */
+       while ((p_flow = TAILQ_FIRST(&pf->flow_list))) {
+               TAILQ_REMOVE(&pf->flow_list, p_flow, node);
+               ice_free_switch_filter_rule(p_flow->rule);
+               rte_free(p_flow);
+       }
+
        return 0;
 }
 
 static int
-ice_dev_configure(__rte_unused struct rte_eth_dev *dev)
+ice_dev_configure(struct rte_eth_dev *dev)
 {
        struct ice_adapter *ad =
                ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
@@ -2960,7 +3046,7 @@ static int ice_rx_queue_intr_enable(struct rte_eth_dev *dev,
        val &= ~GLINT_DYN_CTL_WB_ON_ITR_M;
 
        ICE_WRITE_REG(hw, GLINT_DYN_CTL(msix_intr), val);
-       rte_intr_enable(&pci_dev->intr_handle);
+       rte_intr_ack(&pci_dev->intr_handle);
 
        return 0;
 }
@@ -3603,6 +3689,81 @@ static int ice_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
        return count;
 }
 
+static int
+ice_dev_filter_ctrl(struct rte_eth_dev *dev,
+                    enum rte_filter_type filter_type,
+                    enum rte_filter_op filter_op,
+                    void *arg)
+{
+       int ret = 0;
+
+       if (!dev)
+               return -EINVAL;
+
+       switch (filter_type) {
+       case RTE_ETH_FILTER_GENERIC:
+               if (filter_op != RTE_ETH_FILTER_GET)
+                       return -EINVAL;
+               *(const void **)arg = &ice_flow_ops;
+               break;
+       default:
+               PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
+                                       filter_type);
+               ret = -EINVAL;
+               break;
+       }
+
+       return ret;
+}
+
+/* Add UDP tunneling port */
+static int
+ice_dev_udp_tunnel_port_add(struct rte_eth_dev *dev,
+                            struct rte_eth_udp_tunnel *udp_tunnel)
+{
+       int ret = 0;
+       struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       if (udp_tunnel == NULL)
+               return -EINVAL;
+
+       switch (udp_tunnel->prot_type) {
+       case RTE_TUNNEL_TYPE_VXLAN:
+               ret = ice_create_tunnel(hw, TNL_VXLAN, udp_tunnel->udp_port);
+               break;
+       default:
+               PMD_DRV_LOG(ERR, "Invalid tunnel type");
+               ret = -EINVAL;
+               break;
+       }
+
+       return ret;
+}
+
+/* Delete UDP tunneling port */
+static int
+ice_dev_udp_tunnel_port_del(struct rte_eth_dev *dev,
+                            struct rte_eth_udp_tunnel *udp_tunnel)
+{
+       int ret = 0;
+       struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+       if (udp_tunnel == NULL)
+               return -EINVAL;
+
+       switch (udp_tunnel->prot_type) {
+       case RTE_TUNNEL_TYPE_VXLAN:
+               ret = ice_destroy_tunnel(hw, udp_tunnel->udp_port, 0);
+               break;
+       default:
+               PMD_DRV_LOG(ERR, "Invalid tunnel type");
+               ret = -EINVAL;
+               break;
+       }
+
+       return ret;
+}
+
 static int
 ice_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
              struct rte_pci_device *pci_dev)
@@ -3620,8 +3781,7 @@ ice_pci_remove(struct rte_pci_device *pci_dev)
 
 static struct rte_pci_driver rte_ice_pmd = {
        .id_table = pci_id_ice_map,
-       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |
-                    RTE_PCI_DRV_IOVA_AS_VA,
+       .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
        .probe = ice_pci_probe,
        .remove = ice_pci_remove,
 };
@@ -3635,7 +3795,7 @@ RTE_PMD_REGISTER_PCI(net_ice, rte_ice_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_ice, pci_id_ice_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_ice, "* igb_uio | uio_pci_generic | vfio-pci");
 RTE_PMD_REGISTER_PARAM_STRING(net_ice,
-                             ICE_MAX_QP_NUM "=<int>");
+                             ICE_SAFE_MODE_SUPPORT_ARG "=<0|1>");
 
 RTE_INIT(ice_init_log)
 {