net/ice: support PPPoE RSS
[dpdk.git] / drivers / net / ice / ice_fdir_filter.c
index 42b9628..c3f23a0 100644 (file)
        ICE_FDIR_INSET_VXLAN_IPV4 | \
        ICE_INSET_TUN_SCTP_SRC_PORT | ICE_INSET_TUN_SCTP_DST_PORT)
 
-#define ICE_FDIR_INSET_GTPU_IPV4 (\
-       ICE_INSET_GTPU_TEID)
+#define ICE_FDIR_INSET_GTPU (\
+       ICE_INSET_IPV4_SRC | ICE_INSET_IPV4_DST | ICE_INSET_GTPU_TEID)
 
-#define ICE_FDIR_INSET_GTPU_EH_IPV4 (\
+#define ICE_FDIR_INSET_GTPU_EH (\
+       ICE_INSET_IPV4_SRC | ICE_INSET_IPV4_DST | \
        ICE_INSET_GTPU_TEID | ICE_INSET_GTPU_QFI)
 
 static struct ice_pattern_match_item ice_fdir_pattern_os[] = {
@@ -125,14 +126,16 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
                                       ICE_FDIR_INSET_VXLAN_IPV4_TCP,        ICE_INSET_NONE},
        {pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
                                       ICE_FDIR_INSET_VXLAN_IPV4_SCTP,       ICE_INSET_NONE},
-       {pattern_eth_ipv4_gtpu_ipv4,   ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-       {pattern_eth_ipv4_gtpu_eh_ipv4,
-                                      ICE_FDIR_INSET_GTPU_EH_IPV4,          ICE_INSET_NONE},
+       {pattern_eth_ipv4_gtpu,        ICE_FDIR_INSET_GTPU,                  ICE_INSET_NONE},
+       {pattern_eth_ipv4_gtpu_eh,     ICE_FDIR_INSET_GTPU_EH,               ICE_INSET_NONE},
 };
 
 static struct ice_flow_parser ice_fdir_parser_os;
 static struct ice_flow_parser ice_fdir_parser_comms;
 
+static int
+ice_fdir_is_tunnel_profile(enum ice_fdir_tunnel_type tunnel_type);
+
 static const struct rte_memzone *
 ice_memzone_reserve(const char *name, uint32_t len, int socket_id)
 {
@@ -581,7 +584,7 @@ ice_fdir_prof_rm(struct ice_pf *pf, enum ice_fltr_ptype ptype, bool is_tunnel)
                                                     hw_prof->vsi_h[i]);
                        ice_rem_prof_id_flow(hw, ICE_BLK_FD,
                                             vsi_num, ptype);
-                       ice_flow_rem_entry(hw,
+                       ice_flow_rem_entry(hw, ICE_BLK_FD,
                                           hw_prof->entry_h[i][is_tunnel]);
                        hw_prof->entry_h[i][is_tunnel] = 0;
                }
@@ -873,7 +876,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vsi *vsi,
 err_add_entry:
        vsi_num = ice_get_hw_vsi_num(hw, vsi->idx);
        ice_rem_prof_id_flow(hw, ICE_BLK_FD, vsi_num, prof_id);
-       ice_flow_rem_entry(hw, entry_1);
+       ice_flow_rem_entry(hw, ICE_BLK_FD, entry_1);
 err_add_prof:
        ice_flow_rem_prof(hw, ICE_BLK_FD, prof_id);
 
@@ -915,7 +918,7 @@ ice_fdir_input_set_parse(uint64_t inset, enum ice_flow_field *field)
                {ICE_INSET_TUN_UDP_DST_PORT, ICE_FLOW_FIELD_IDX_UDP_DST_PORT},
                {ICE_INSET_TUN_SCTP_SRC_PORT, ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT},
                {ICE_INSET_TUN_SCTP_DST_PORT, ICE_FLOW_FIELD_IDX_SCTP_DST_PORT},
-               {ICE_INSET_GTPU_TEID, ICE_FLOW_FIELD_IDX_GTPU_EH_TEID},
+               {ICE_INSET_GTPU_TEID, ICE_FLOW_FIELD_IDX_GTPU_IP_TEID},
                {ICE_INSET_GTPU_QFI, ICE_FLOW_FIELD_IDX_GTPU_EH_QFI},
        };
 
@@ -928,11 +931,12 @@ ice_fdir_input_set_parse(uint64_t inset, enum ice_flow_field *field)
 
 static int
 ice_fdir_input_set_conf(struct ice_pf *pf, enum ice_fltr_ptype flow,
-                       uint64_t input_set, bool is_tunnel)
+                       uint64_t input_set, enum ice_fdir_tunnel_type ttype)
 {
        struct ice_flow_seg_info *seg;
        struct ice_flow_seg_info *seg_tun = NULL;
        enum ice_flow_field field[ICE_FLOW_FIELD_IDX_MAX];
+       bool is_tunnel;
        int i, ret;
 
        if (!input_set)
@@ -952,41 +956,57 @@ ice_fdir_input_set_conf(struct ice_pf *pf, enum ice_fltr_ptype flow,
        switch (flow) {
        case ICE_FLTR_PTYPE_NONF_IPV4_UDP:
                ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_UDP |
-                                 ICE_FLOW_SEG_HDR_IPV4);
+                                 ICE_FLOW_SEG_HDR_IPV4 |
+                                 ICE_FLOW_SEG_HDR_IPV_OTHER);
                break;
        case ICE_FLTR_PTYPE_NONF_IPV4_TCP:
                ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_TCP |
-                                 ICE_FLOW_SEG_HDR_IPV4);
+                                 ICE_FLOW_SEG_HDR_IPV4 |
+                                 ICE_FLOW_SEG_HDR_IPV_OTHER);
                break;
        case ICE_FLTR_PTYPE_NONF_IPV4_SCTP:
                ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_SCTP |
-                                 ICE_FLOW_SEG_HDR_IPV4);
+                                 ICE_FLOW_SEG_HDR_IPV4 |
+                                 ICE_FLOW_SEG_HDR_IPV_OTHER);
                break;
        case ICE_FLTR_PTYPE_NONF_IPV4_OTHER:
-               ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV4);
+               ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV4 |
+                                 ICE_FLOW_SEG_HDR_IPV_OTHER);
                break;
        case ICE_FLTR_PTYPE_NONF_IPV6_UDP:
                ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_UDP |
-                                 ICE_FLOW_SEG_HDR_IPV6);
+                                 ICE_FLOW_SEG_HDR_IPV6 |
+                                 ICE_FLOW_SEG_HDR_IPV_OTHER);
                break;
        case ICE_FLTR_PTYPE_NONF_IPV6_TCP:
                ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_TCP |
-                                 ICE_FLOW_SEG_HDR_IPV6);
+                                 ICE_FLOW_SEG_HDR_IPV6 |
+                                 ICE_FLOW_SEG_HDR_IPV_OTHER);
                break;
        case ICE_FLTR_PTYPE_NONF_IPV6_SCTP:
                ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_SCTP |
-                                 ICE_FLOW_SEG_HDR_IPV6);
+                                 ICE_FLOW_SEG_HDR_IPV6 |
+                                 ICE_FLOW_SEG_HDR_IPV_OTHER);
                break;
        case ICE_FLTR_PTYPE_NONF_IPV6_OTHER:
-               ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV6);
+               ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_IPV6 |
+                                 ICE_FLOW_SEG_HDR_IPV_OTHER);
                break;
        case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_UDP:
        case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP:
        case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP:
        case ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER:
-               ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_EH |
-                                      ICE_FLOW_SEG_HDR_GTPU_IP |
-                                 ICE_FLOW_SEG_HDR_IPV4);
+               if (ttype == ICE_FDIR_TUNNEL_TYPE_GTPU)
+                       ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_IP |
+                                         ICE_FLOW_SEG_HDR_IPV4 |
+                                         ICE_FLOW_SEG_HDR_IPV_OTHER);
+               else if (ttype == ICE_FDIR_TUNNEL_TYPE_GTPU_EH)
+                       ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_EH |
+                                         ICE_FLOW_SEG_HDR_GTPU_IP |
+                                         ICE_FLOW_SEG_HDR_IPV4 |
+                                         ICE_FLOW_SEG_HDR_IPV_OTHER);
+               else
+                       PMD_DRV_LOG(ERR, "not supported tunnel type.");
                break;
        default:
                PMD_DRV_LOG(ERR, "not supported filter type.");
@@ -1000,6 +1020,7 @@ ice_fdir_input_set_conf(struct ice_pf *pf, enum ice_fltr_ptype flow,
                                 ICE_FLOW_FLD_OFF_INVAL, false);
        }
 
+       is_tunnel = ice_fdir_is_tunnel_profile(ttype);
        if (!is_tunnel) {
                ret = ice_fdir_hw_tbl_conf(pf, pf->main_vsi, pf->fdir.fdir_vsi,
                                           seg, flow, false);
@@ -1050,6 +1071,9 @@ ice_fdir_init(struct ice_adapter *ad)
        struct ice_flow_parser *parser;
        int ret;
 
+       if (ad->hw.dcf_enabled)
+               return 0;
+
        ret = ice_fdir_setup(pf);
        if (ret)
                return ret;
@@ -1070,6 +1094,9 @@ ice_fdir_uninit(struct ice_adapter *ad)
        struct ice_pf *pf = &ad->pf;
        struct ice_flow_parser *parser;
 
+       if (ad->hw.dcf_enabled)
+               return;
+
        if (ad->active_pkg_type == ICE_PKG_TYPE_COMMS)
                parser = &ice_fdir_parser_comms;
        else
@@ -1103,6 +1130,7 @@ ice_fdir_add_del_filter(struct ice_pf *pf,
        filter->input.dest_vsi = pf->main_vsi->idx;
 
        memset(&desc, 0, sizeof(desc));
+       filter->input.comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW;
        ice_fdir_get_prgm_desc(hw, &filter->input, &desc, add);
 
        is_tun = ice_fdir_is_tunnel_profile(filter->tunnel_type);
@@ -1224,7 +1252,7 @@ ice_fdir_create_filter(struct ice_adapter *ad,
        is_tun = ice_fdir_is_tunnel_profile(filter->tunnel_type);
 
        ret = ice_fdir_input_set_conf(pf, filter->input.flow_type,
-                       filter->input_set, is_tun);
+                       filter->input_set, filter->tunnel_type);
        if (ret) {
                rte_flow_error_set(error, -ret,
                                   RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
@@ -1488,8 +1516,7 @@ ice_fdir_parse_action(struct ice_adapter *ad,
                        dest_num++;
 
                        filter->input.dest_ctl =
-                               ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QINDEX;
-                       filter->input.q_index = 0;
+                               ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER;
                        break;
                case RTE_FLOW_ACTION_TYPE_RSS:
                        dest_num++;
@@ -1523,7 +1550,7 @@ ice_fdir_parse_action(struct ice_adapter *ad,
                }
        }
 
-       if (dest_num == 0 || dest_num >= 2) {
+       if (dest_num >= 2) {
                rte_flow_error_set(error, EINVAL,
                           RTE_FLOW_ERROR_TYPE_ACTION, actions,
                           "Unsupported action combination");
@@ -1544,6 +1571,18 @@ ice_fdir_parse_action(struct ice_adapter *ad,
                return -rte_errno;
        }
 
+       if (dest_num + mark_num + counter_num == 0) {
+               rte_flow_error_set(error, EINVAL,
+                          RTE_FLOW_ERROR_TYPE_ACTION, actions,
+                          "Empty action");
+               return -rte_errno;
+       }
+
+       /* set default action to PASSTHRU mode, in "mark/count only" case. */
+       if (dest_num == 0)
+               filter->input.dest_ctl =
+                       ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER;
+
        return 0;
 }
 
@@ -1648,9 +1687,9 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
                                        input_set |= ICE_INSET_IPV4_PROTO;
 
                                filter->input.ip.v4.dst_ip =
-                                       ipv4_spec->hdr.src_addr;
-                               filter->input.ip.v4.src_ip =
                                        ipv4_spec->hdr.dst_addr;
+                               filter->input.ip.v4.src_ip =
+                                       ipv4_spec->hdr.src_addr;
                                filter->input.ip.v4.tos =
                                        ipv4_spec->hdr.type_of_service;
                                filter->input.ip.v4.ttl =
@@ -1695,9 +1734,9 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
                                        input_set |= ICE_INSET_IPV6_HOP_LIMIT;
 
                                rte_memcpy(filter->input.ip.v6.dst_ip,
-                                          ipv6_spec->hdr.src_addr, 16);
-                               rte_memcpy(filter->input.ip.v6.src_ip,
                                           ipv6_spec->hdr.dst_addr, 16);
+                               rte_memcpy(filter->input.ip.v6.src_ip,
+                                          ipv6_spec->hdr.src_addr, 16);
 
                                vtc_flow_cpu =
                                      rte_be_to_cpu_32(ipv6_spec->hdr.vtc_flow);
@@ -1749,14 +1788,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
                                /* Get filter info */
                                if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) {
                                        filter->input.ip.v4.dst_port =
-                                               tcp_spec->hdr.src_port;
-                                       filter->input.ip.v4.src_port =
                                                tcp_spec->hdr.dst_port;
+                                       filter->input.ip.v4.src_port =
+                                               tcp_spec->hdr.src_port;
                                } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
                                        filter->input.ip.v6.dst_port =
-                                               tcp_spec->hdr.src_port;
-                                       filter->input.ip.v6.src_port =
                                                tcp_spec->hdr.dst_port;
+                                       filter->input.ip.v6.src_port =
+                                               tcp_spec->hdr.src_port;
                                }
                        }
                        break;
@@ -1792,14 +1831,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
                                /* Get filter info */
                                if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) {
                                        filter->input.ip.v4.dst_port =
-                                               udp_spec->hdr.src_port;
-                                       filter->input.ip.v4.src_port =
                                                udp_spec->hdr.dst_port;
+                                       filter->input.ip.v4.src_port =
+                                               udp_spec->hdr.src_port;
                                } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
                                        filter->input.ip.v6.src_port =
-                                               udp_spec->hdr.dst_port;
-                                       filter->input.ip.v6.dst_port =
                                                udp_spec->hdr.src_port;
+                                       filter->input.ip.v6.dst_port =
+                                               udp_spec->hdr.dst_port;
                                }
                        }
                        break;
@@ -1834,14 +1873,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
                                /* Get filter info */
                                if (l3 == RTE_FLOW_ITEM_TYPE_IPV4) {
                                        filter->input.ip.v4.dst_port =
-                                               sctp_spec->hdr.src_port;
-                                       filter->input.ip.v4.src_port =
                                                sctp_spec->hdr.dst_port;
+                                       filter->input.ip.v4.src_port =
+                                               sctp_spec->hdr.src_port;
                                } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
                                        filter->input.ip.v6.dst_port =
-                                               sctp_spec->hdr.src_port;
-                                       filter->input.ip.v6.src_port =
                                                sctp_spec->hdr.dst_port;
+                                       filter->input.ip.v6.src_port =
+                                               sctp_spec->hdr.src_port;
                                }
                        }
                        break;
@@ -1897,6 +1936,7 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
                                filter->input.gtpu_data.qfi =
                                        gtp_psc_spec->qfi;
                        }
+                       tunnel_type = ICE_FDIR_TUNNEL_TYPE_GTPU_EH;
                        break;
                default:
                        rte_flow_error_set(error, EINVAL,
@@ -1907,7 +1947,8 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
                }
        }
 
-       if (tunnel_type == ICE_FDIR_TUNNEL_TYPE_GTPU)
+       if (tunnel_type == ICE_FDIR_TUNNEL_TYPE_GTPU ||
+           tunnel_type == ICE_FDIR_TUNNEL_TYPE_GTPU_EH)
                flow_type = ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER;
 
        filter->tunnel_type = tunnel_type;
@@ -1939,23 +1980,26 @@ ice_fdir_parse(struct ice_adapter *ad,
 
        ret = ice_fdir_parse_pattern(ad, pattern, error, filter);
        if (ret)
-               return ret;
+               goto error;
        input_set = filter->input_set;
        if (!input_set || input_set & ~item->input_set_mask) {
                rte_flow_error_set(error, EINVAL,
                                   RTE_FLOW_ERROR_TYPE_ITEM_SPEC,
                                   pattern,
                                   "Invalid input set");
-               return -rte_errno;
+               ret = -rte_errno;
+               goto error;
        }
 
        ret = ice_fdir_parse_action(ad, actions, error, filter);
        if (ret)
-               return ret;
+               goto error;
 
-       *meta = filter;
-
-       return 0;
+       if (meta)
+               *meta = filter;
+error:
+       rte_free(item);
+       return ret;
 }
 
 static struct ice_flow_parser ice_fdir_parser_os = {