net/ice: fix flow rule checking
[dpdk.git] / drivers / net / ice / ice_switch_filter.c
index c4b00b6..7bac77e 100644 (file)
 #define ICE_SW_INSET_ETHER ( \
        ICE_INSET_DMAC | ICE_INSET_SMAC | ICE_INSET_ETHERTYPE)
 #define ICE_SW_INSET_MAC_VLAN ( \
-               ICE_INSET_DMAC | ICE_INSET_SMAC | ICE_INSET_ETHERTYPE | \
-               ICE_INSET_VLAN_OUTER)
+       ICE_INSET_DMAC | ICE_INSET_SMAC | ICE_INSET_ETHERTYPE | \
+       ICE_INSET_VLAN_INNER)
+#define ICE_SW_INSET_MAC_QINQ  ( \
+       ICE_SW_INSET_MAC_VLAN | ICE_INSET_VLAN_OUTER)
 #define ICE_SW_INSET_MAC_IPV4 ( \
        ICE_INSET_DMAC | ICE_INSET_IPV4_DST | ICE_INSET_IPV4_SRC | \
        ICE_INSET_IPV4_PROTO | ICE_INSET_IPV4_TTL | ICE_INSET_IPV4_TOS)
+#define ICE_SW_INSET_MAC_QINQ_IPV4 ( \
+       ICE_SW_INSET_MAC_QINQ | ICE_SW_INSET_MAC_IPV4)
 #define ICE_SW_INSET_MAC_IPV4_TCP ( \
        ICE_INSET_DMAC | ICE_INSET_IPV4_DST | ICE_INSET_IPV4_SRC | \
        ICE_INSET_IPV4_TTL | ICE_INSET_IPV4_TOS | \
@@ -52,6 +56,8 @@
        ICE_INSET_DMAC | ICE_INSET_IPV6_DST | ICE_INSET_IPV6_SRC | \
        ICE_INSET_IPV6_TC | ICE_INSET_IPV6_HOP_LIMIT | \
        ICE_INSET_IPV6_NEXT_HDR)
+#define ICE_SW_INSET_MAC_QINQ_IPV6 ( \
+       ICE_SW_INSET_MAC_QINQ | ICE_SW_INSET_MAC_IPV6)
 #define ICE_SW_INSET_MAC_IPV6_TCP ( \
        ICE_INSET_DMAC | ICE_INSET_IPV6_DST | ICE_INSET_IPV6_SRC | \
        ICE_INSET_IPV6_HOP_LIMIT | ICE_INSET_IPV6_TC | \
@@ -137,16 +143,19 @@ struct sw_meta {
        struct ice_adv_rule_info rule_info;
 };
 
-static struct ice_flow_parser ice_switch_dist_parser_os;
-static struct ice_flow_parser ice_switch_dist_parser_comms;
+static struct ice_flow_parser ice_switch_dist_parser;
 static struct ice_flow_parser ice_switch_perm_parser;
 
 static struct
-ice_pattern_match_item ice_switch_pattern_dist_comms[] = {
+ice_pattern_match_item ice_switch_pattern_dist_list[] = {
        {pattern_ethertype,
                        ICE_SW_INSET_ETHER, ICE_INSET_NONE},
        {pattern_ethertype_vlan,
                        ICE_SW_INSET_MAC_VLAN, ICE_INSET_NONE},
+       {pattern_ethertype_qinq,
+                       ICE_SW_INSET_MAC_QINQ, ICE_INSET_NONE},
+       {pattern_eth_arp,
+                       ICE_INSET_NONE, ICE_INSET_NONE},
        {pattern_eth_ipv4,
                        ICE_SW_INSET_MAC_IPV4, ICE_INSET_NONE},
        {pattern_eth_ipv4_udp,
@@ -225,48 +234,30 @@ ice_pattern_match_item ice_switch_pattern_dist_comms[] = {
                        ICE_INSET_NONE, ICE_INSET_NONE},
        {pattern_eth_ipv6_pfcp,
                        ICE_INSET_NONE, ICE_INSET_NONE},
+       {pattern_eth_qinq_ipv4,
+                       ICE_SW_INSET_MAC_QINQ_IPV4, ICE_INSET_NONE},
+       {pattern_eth_qinq_ipv6,
+                       ICE_SW_INSET_MAC_QINQ_IPV6, ICE_INSET_NONE},
+       {pattern_eth_qinq_pppoes,
+                       ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
+       {pattern_eth_qinq_pppoes_proto,
+                       ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
+       {pattern_eth_qinq_pppoes_ipv4,
+                       ICE_SW_INSET_MAC_PPPOE_IPV4, ICE_INSET_NONE},
+       {pattern_eth_qinq_pppoes_ipv6,
+                       ICE_SW_INSET_MAC_PPPOE_IPV6, ICE_INSET_NONE},
 };
 
 static struct
-ice_pattern_match_item ice_switch_pattern_dist_os[] = {
+ice_pattern_match_item ice_switch_pattern_perm_list[] = {
        {pattern_ethertype,
                        ICE_SW_INSET_ETHER, ICE_INSET_NONE},
        {pattern_ethertype_vlan,
                        ICE_SW_INSET_MAC_VLAN, ICE_INSET_NONE},
+       {pattern_ethertype_qinq,
+                       ICE_SW_INSET_MAC_QINQ, ICE_INSET_NONE},
        {pattern_eth_arp,
-                       ICE_INSET_NONE, ICE_INSET_NONE},
-       {pattern_eth_ipv4,
-                       ICE_SW_INSET_MAC_IPV4, ICE_INSET_NONE},
-       {pattern_eth_ipv4_udp,
-                       ICE_SW_INSET_MAC_IPV4_UDP, ICE_INSET_NONE},
-       {pattern_eth_ipv4_tcp,
-                       ICE_SW_INSET_MAC_IPV4_TCP, ICE_INSET_NONE},
-       {pattern_eth_ipv6,
-                       ICE_SW_INSET_MAC_IPV6, ICE_INSET_NONE},
-       {pattern_eth_ipv6_udp,
-                       ICE_SW_INSET_MAC_IPV6_UDP, ICE_INSET_NONE},
-       {pattern_eth_ipv6_tcp,
-                       ICE_SW_INSET_MAC_IPV6_TCP, ICE_INSET_NONE},
-       {pattern_eth_ipv4_udp_vxlan_eth_ipv4,
-                       ICE_SW_INSET_DIST_VXLAN_IPV4, ICE_INSET_NONE},
-       {pattern_eth_ipv4_udp_vxlan_eth_ipv4_udp,
-                       ICE_SW_INSET_DIST_VXLAN_IPV4_UDP, ICE_INSET_NONE},
-       {pattern_eth_ipv4_udp_vxlan_eth_ipv4_tcp,
-                       ICE_SW_INSET_DIST_VXLAN_IPV4_TCP, ICE_INSET_NONE},
-       {pattern_eth_ipv4_nvgre_eth_ipv4,
-                       ICE_SW_INSET_DIST_NVGRE_IPV4, ICE_INSET_NONE},
-       {pattern_eth_ipv4_nvgre_eth_ipv4_udp,
-                       ICE_SW_INSET_DIST_NVGRE_IPV4_UDP, ICE_INSET_NONE},
-       {pattern_eth_ipv4_nvgre_eth_ipv4_tcp,
-                       ICE_SW_INSET_DIST_NVGRE_IPV4_TCP, ICE_INSET_NONE},
-};
-
-static struct
-ice_pattern_match_item ice_switch_pattern_perm[] = {
-       {pattern_ethertype,
-                       ICE_SW_INSET_ETHER, ICE_INSET_NONE},
-       {pattern_ethertype_vlan,
-                       ICE_SW_INSET_MAC_VLAN, ICE_INSET_NONE},
+               ICE_INSET_NONE, ICE_INSET_NONE},
        {pattern_eth_ipv4,
                        ICE_SW_INSET_MAC_IPV4, ICE_INSET_NONE},
        {pattern_eth_ipv4_udp,
@@ -345,6 +336,18 @@ ice_pattern_match_item ice_switch_pattern_perm[] = {
                        ICE_INSET_NONE, ICE_INSET_NONE},
        {pattern_eth_ipv6_pfcp,
                        ICE_INSET_NONE, ICE_INSET_NONE},
+       {pattern_eth_qinq_ipv4,
+                       ICE_SW_INSET_MAC_QINQ_IPV4, ICE_INSET_NONE},
+       {pattern_eth_qinq_ipv6,
+                       ICE_SW_INSET_MAC_QINQ_IPV6, ICE_INSET_NONE},
+       {pattern_eth_qinq_pppoes,
+                       ICE_SW_INSET_MAC_PPPOE, ICE_INSET_NONE},
+       {pattern_eth_qinq_pppoes_proto,
+                       ICE_SW_INSET_MAC_PPPOE_PROTO, ICE_INSET_NONE},
+       {pattern_eth_qinq_pppoes_ipv4,
+                       ICE_SW_INSET_MAC_PPPOE_IPV4, ICE_INSET_NONE},
+       {pattern_eth_qinq_pppoes_ipv6,
+                       ICE_SW_INSET_MAC_PPPOE_IPV6, ICE_INSET_NONE},
 };
 
 static int
@@ -477,6 +480,8 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],
        bool pppoe_elem_valid = 0;
        bool pppoe_patt_valid = 0;
        bool pppoe_prot_valid = 0;
+       bool inner_vlan_valid = 0;
+       bool outer_vlan_valid = 0;
        bool tunnel_valid = 0;
        bool profile_rule = 0;
        bool nvgre_valid = 0;
@@ -1023,23 +1028,40 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],
                                           "Invalid VLAN item");
                                return 0;
                        }
+
+                       if (!outer_vlan_valid &&
+                           (*tun_type == ICE_SW_TUN_AND_NON_TUN_QINQ ||
+                            *tun_type == ICE_NON_TUN_QINQ))
+                               outer_vlan_valid = 1;
+                       else if (!inner_vlan_valid &&
+                                (*tun_type == ICE_SW_TUN_AND_NON_TUN_QINQ ||
+                                 *tun_type == ICE_NON_TUN_QINQ))
+                               inner_vlan_valid = 1;
+                       else if (!inner_vlan_valid)
+                               inner_vlan_valid = 1;
+
                        if (vlan_spec && vlan_mask) {
-                               list[t].type = ICE_VLAN_OFOS;
+                               if (outer_vlan_valid && !inner_vlan_valid) {
+                                       list[t].type = ICE_VLAN_EX;
+                                       input_set |= ICE_INSET_VLAN_OUTER;
+                               } else if (inner_vlan_valid) {
+                                       list[t].type = ICE_VLAN_OFOS;
+                                       input_set |= ICE_INSET_VLAN_INNER;
+                               }
+
                                if (vlan_mask->tci) {
                                        list[t].h_u.vlan_hdr.vlan =
                                                vlan_spec->tci;
                                        list[t].m_u.vlan_hdr.vlan =
                                                vlan_mask->tci;
-                                       input_set |= ICE_INSET_VLAN_OUTER;
                                        input_set_byte += 2;
                                }
                                if (vlan_mask->inner_type) {
-                                       list[t].h_u.vlan_hdr.type =
-                                               vlan_spec->inner_type;
-                                       list[t].m_u.vlan_hdr.type =
-                                               vlan_mask->inner_type;
-                                       input_set |= ICE_INSET_ETHERTYPE;
-                                       input_set_byte += 2;
+                                       rte_flow_error_set(error, EINVAL,
+                                               RTE_FLOW_ERROR_TYPE_ITEM,
+                                               item,
+                                               "Invalid VLAN input set.");
+                                       return 0;
                                }
                                t++;
                        }
@@ -1341,8 +1363,27 @@ ice_switch_inset_get(const struct rte_flow_item pattern[],
                }
        }
 
+       if (*tun_type == ICE_SW_TUN_PPPOE_PAY &&
+           inner_vlan_valid && outer_vlan_valid)
+               *tun_type = ICE_SW_TUN_PPPOE_PAY_QINQ;
+       else if (*tun_type == ICE_SW_TUN_PPPOE &&
+                inner_vlan_valid && outer_vlan_valid)
+               *tun_type = ICE_SW_TUN_PPPOE_QINQ;
+       else if (*tun_type == ICE_NON_TUN &&
+                inner_vlan_valid && outer_vlan_valid)
+               *tun_type = ICE_NON_TUN_QINQ;
+       else if (*tun_type == ICE_SW_TUN_AND_NON_TUN &&
+                inner_vlan_valid && outer_vlan_valid)
+               *tun_type = ICE_SW_TUN_AND_NON_TUN_QINQ;
+
        if (pppoe_patt_valid && !pppoe_prot_valid) {
-               if (ipv6_valid && udp_valid)
+               if (inner_vlan_valid && outer_vlan_valid && ipv4_valid)
+                       *tun_type = ICE_SW_TUN_PPPOE_IPV4_QINQ;
+               else if (inner_vlan_valid && outer_vlan_valid && ipv6_valid)
+                       *tun_type = ICE_SW_TUN_PPPOE_IPV6_QINQ;
+               else if (inner_vlan_valid && outer_vlan_valid)
+                       *tun_type = ICE_SW_TUN_PPPOE_QINQ;
+               else if (ipv6_valid && udp_valid)
                        *tun_type = ICE_SW_TUN_PPPOE_IPV6_UDP;
                else if (ipv6_valid && tcp_valid)
                        *tun_type = ICE_SW_TUN_PPPOE_IPV6_TCP;
@@ -1405,17 +1446,32 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
                case RTE_FLOW_ACTION_TYPE_VF:
                        rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI;
                        act_vf = action->conf;
+
+                       if (act_vf->id >= ad->real_hw.num_vfs &&
+                               !act_vf->original) {
+                               rte_flow_error_set(error,
+                                       EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
+                                       actions,
+                                       "Invalid vf id");
+                               return -rte_errno;
+                       }
+
                        if (act_vf->original)
                                rule_info->sw_act.vsi_handle =
                                        ad->real_hw.avf.bus.func;
                        else
                                rule_info->sw_act.vsi_handle = act_vf->id;
                        break;
+
+               case RTE_FLOW_ACTION_TYPE_DROP:
+                       rule_info->sw_act.fltr_act = ICE_DROP_PACKET;
+                       break;
+
                default:
                        rte_flow_error_set(error,
                                           EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
                                           actions,
-                                          "Invalid action type or queue number");
+                                          "Invalid action type");
                        return -rte_errno;
                }
        }
@@ -1467,11 +1523,11 @@ ice_switch_parse_action(struct ice_pf *pf,
                        if ((act_qgrop->queue[0] +
                                act_qgrop->queue_num) >
                                dev->data->nb_rx_queues)
-                               goto error;
+                               goto error1;
                        for (i = 0; i < act_qgrop->queue_num - 1; i++)
                                if (act_qgrop->queue[i + 1] !=
                                        act_qgrop->queue[i] + 1)
-                                       goto error;
+                                       goto error2;
                        rule_info->sw_act.qgrp_size =
                                act_qgrop->queue_num;
                        break;
@@ -1511,6 +1567,20 @@ error:
                actions,
                "Invalid action type or queue number");
        return -rte_errno;
+
+error1:
+       rte_flow_error_set(error,
+               EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
+               actions,
+               "Invalid queue region indexes");
+       return -rte_errno;
+
+error2:
+       rte_flow_error_set(error,
+               EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
+               actions,
+               "Discontinuous queue region");
+       return -rte_errno;
 }
 
 static int
@@ -1591,6 +1661,7 @@ ice_switch_parse_pattern_action(struct ice_adapter *ad,
        uint16_t lkups_num = 0;
        const struct rte_flow_item *item = pattern;
        uint16_t item_num = 0;
+       uint16_t vlan_num = 0;
        enum ice_sw_tunnel_type tun_type =
                        ICE_NON_TUN;
        struct ice_pattern_match_item *pattern_match_item = NULL;
@@ -1606,6 +1677,10 @@ ice_switch_parse_pattern_action(struct ice_adapter *ad,
                        if (eth_mask->type == UINT16_MAX)
                                tun_type = ICE_SW_TUN_AND_NON_TUN;
                }
+
+               if (item->type == RTE_FLOW_ITEM_TYPE_VLAN)
+                       vlan_num++;
+
                /* reserve one more memory slot for ETH which may
                 * consume 2 lookup items.
                 */
@@ -1613,6 +1688,11 @@ ice_switch_parse_pattern_action(struct ice_adapter *ad,
                        item_num++;
        }
 
+       if (vlan_num == 2 && tun_type == ICE_SW_TUN_AND_NON_TUN)
+               tun_type = ICE_SW_TUN_AND_NON_TUN_QINQ;
+       else if (vlan_num == 2)
+               tun_type = ICE_NON_TUN_QINQ;
+
        list = rte_zmalloc(NULL, item_num * sizeof(*list), 0);
        if (!list) {
                rte_flow_error_set(error, EINVAL,
@@ -1631,7 +1711,8 @@ ice_switch_parse_pattern_action(struct ice_adapter *ad,
        }
 
        pattern_match_item =
-               ice_search_pattern_match_item(pattern, array, array_len, error);
+               ice_search_pattern_match_item(ad, pattern, array, array_len,
+                                             error);
        if (!pattern_match_item) {
                rte_flow_error_set(error, EINVAL,
                                   RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
@@ -1654,12 +1735,8 @@ ice_switch_parse_pattern_action(struct ice_adapter *ad,
        rule_info.tun_type = tun_type;
 
        ret = ice_switch_check_action(actions, error);
-       if (ret) {
-               rte_flow_error_set(error, EINVAL,
-                                  RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
-                                  "Invalid input action number");
+       if (ret)
                goto error;
-       }
 
        if (ad->hw.dcf_enabled)
                ret = ice_switch_parse_dcf_action((void *)ad, actions, error,
@@ -1667,12 +1744,8 @@ ice_switch_parse_pattern_action(struct ice_adapter *ad,
        else
                ret = ice_switch_parse_action(pf, actions, error, &rule_info);
 
-       if (ret) {
-               rte_flow_error_set(error, EINVAL,
-                                  RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
-                                  "Invalid input action");
+       if (ret)
                goto error;
-       }
 
        if (meta) {
                *meta = sw_meta_ptr;
@@ -1797,19 +1870,15 @@ ice_switch_init(struct ice_adapter *ad)
 {
        int ret = 0;
        struct ice_flow_parser *dist_parser;
-       struct ice_flow_parser *perm_parser = &ice_switch_perm_parser;
-
-       if (ad->active_pkg_type == ICE_PKG_TYPE_COMMS)
-               dist_parser = &ice_switch_dist_parser_comms;
-       else if (ad->active_pkg_type == ICE_PKG_TYPE_OS_DEFAULT)
-               dist_parser = &ice_switch_dist_parser_os;
-       else
-               return -EINVAL;
+       struct ice_flow_parser *perm_parser;
 
-       if (ad->devargs.pipe_mode_support)
+       if (ad->devargs.pipe_mode_support) {
+               perm_parser = &ice_switch_perm_parser;
                ret = ice_register_parser(perm_parser, ad);
-       else
+       } else {
+               dist_parser = &ice_switch_dist_parser;
                ret = ice_register_parser(dist_parser, ad);
+       }
        return ret;
 }
 
@@ -1817,17 +1886,15 @@ static void
 ice_switch_uninit(struct ice_adapter *ad)
 {
        struct ice_flow_parser *dist_parser;
-       struct ice_flow_parser *perm_parser = &ice_switch_perm_parser;
-
-       if (ad->active_pkg_type == ICE_PKG_TYPE_COMMS)
-               dist_parser = &ice_switch_dist_parser_comms;
-       else
-               dist_parser = &ice_switch_dist_parser_os;
+       struct ice_flow_parser *perm_parser;
 
-       if (ad->devargs.pipe_mode_support)
+       if (ad->devargs.pipe_mode_support) {
+               perm_parser = &ice_switch_perm_parser;
                ice_unregister_parser(perm_parser, ad);
-       else
+       } else {
+               dist_parser = &ice_switch_dist_parser;
                ice_unregister_parser(dist_parser, ad);
+       }
 }
 
 static struct
@@ -1843,19 +1910,10 @@ ice_flow_engine ice_switch_engine = {
 };
 
 static struct
-ice_flow_parser ice_switch_dist_parser_os = {
-       .engine = &ice_switch_engine,
-       .array = ice_switch_pattern_dist_os,
-       .array_len = RTE_DIM(ice_switch_pattern_dist_os),
-       .parse_pattern_action = ice_switch_parse_pattern_action,
-       .stage = ICE_FLOW_STAGE_DISTRIBUTOR,
-};
-
-static struct
-ice_flow_parser ice_switch_dist_parser_comms = {
+ice_flow_parser ice_switch_dist_parser = {
        .engine = &ice_switch_engine,
-       .array = ice_switch_pattern_dist_comms,
-       .array_len = RTE_DIM(ice_switch_pattern_dist_comms),
+       .array = ice_switch_pattern_dist_list,
+       .array_len = RTE_DIM(ice_switch_pattern_dist_list),
        .parse_pattern_action = ice_switch_parse_pattern_action,
        .stage = ICE_FLOW_STAGE_DISTRIBUTOR,
 };
@@ -1863,8 +1921,8 @@ ice_flow_parser ice_switch_dist_parser_comms = {
 static struct
 ice_flow_parser ice_switch_perm_parser = {
        .engine = &ice_switch_engine,
-       .array = ice_switch_pattern_perm,
-       .array_len = RTE_DIM(ice_switch_pattern_perm),
+       .array = ice_switch_pattern_perm_list,
+       .array_len = RTE_DIM(ice_switch_pattern_perm_list),
        .parse_pattern_action = ice_switch_parse_pattern_action,
        .stage = ICE_FLOW_STAGE_PERMISSION,
 };