net/ionic: convert per-queue offloads into queue flags
[dpdk.git] / drivers / net / ionic / ionic_if.h
index ab300be..ba4cc4b 100644 (file)
@@ -1,17 +1,15 @@
 /* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB OR BSD-3-Clause */
-/* Copyright (c) 2017-2019 Pensando Systems, Inc.  All rights reserved. */
+/* Copyright (c) 2017-2020 Pensando Systems, Inc.  All rights reserved. */
 
 #ifndef _IONIC_IF_H_
 #define _IONIC_IF_H_
 
-#pragma pack(push, 1)
-
 #define IONIC_DEV_INFO_SIGNATURE               0x44455649      /* 'DEVI' */
 #define IONIC_DEV_INFO_VERSION                 1
 #define IONIC_IFNAMSIZ                         16
 
 /**
- * Commands
+ * enum ionic_cmd_opcode - Device commands
  */
 enum ionic_cmd_opcode {
        IONIC_CMD_NOP                           = 0,
@@ -42,6 +40,7 @@ enum ionic_cmd_opcode {
        IONIC_CMD_RX_FILTER_DEL                 = 32,
 
        /* Queue commands */
+       IONIC_CMD_Q_IDENTIFY                    = 39,
        IONIC_CMD_Q_INIT                        = 40,
        IONIC_CMD_Q_CONTROL                     = 41,
 
@@ -51,10 +50,17 @@ enum ionic_cmd_opcode {
        IONIC_CMD_RDMA_CREATE_CQ                = 52,
        IONIC_CMD_RDMA_CREATE_ADMINQ            = 53,
 
+       /* SR/IOV commands */
+       IONIC_CMD_VF_GETATTR                    = 60,
+       IONIC_CMD_VF_SETATTR                    = 61,
+
        /* QoS commands */
        IONIC_CMD_QOS_CLASS_IDENTIFY            = 240,
        IONIC_CMD_QOS_CLASS_INIT                = 241,
        IONIC_CMD_QOS_CLASS_RESET               = 242,
+       IONIC_CMD_QOS_CLASS_UPDATE              = 243,
+       IONIC_CMD_QOS_CLEAR_STATS               = 244,
+       IONIC_CMD_QOS_RESET                     = 245,
 
        /* Firmware commands */
        IONIC_CMD_FW_DOWNLOAD                   = 254,
@@ -62,7 +68,7 @@ enum ionic_cmd_opcode {
 };
 
 /**
- * Command Return codes
+ * enum ionic_status_code - Device command return codes
  */
 enum ionic_status_code {
        IONIC_RC_SUCCESS        = 0,    /* Success */
@@ -86,8 +92,8 @@ enum ionic_status_code {
        IONIC_RC_DEV_CMD        = 18,   /* Device cmd attempted on AdminQ */
        IONIC_RC_ENOSUPP        = 19,   /* Operation not supported */
        IONIC_RC_ERROR          = 29,   /* Generic error */
-
        IONIC_RC_ERDMA          = 30,   /* Generic RDMA error */
+       IONIC_RC_EVFID          = 31,   /* VF ID does not exist */
 };
 
 enum ionic_notifyq_opcode {
@@ -95,10 +101,11 @@ enum ionic_notifyq_opcode {
        IONIC_EVENT_RESET               = 2,
        IONIC_EVENT_HEARTBEAT           = 3,
        IONIC_EVENT_LOG                 = 4,
+       IONIC_EVENT_XCVR                = 5,
 };
 
 /**
- * struct cmd - General admin command format
+ * struct ionic_admin_cmd - General admin command format
  * @opcode:     Opcode for the command
  * @lif_index:  LIF index
  * @cmd_data:   Opcode-specific command bytes
@@ -112,12 +119,11 @@ struct ionic_admin_cmd {
 
 /**
  * struct ionic_admin_comp - General admin command completion format
- * @status:     The status of the command (enum status_code)
- * @comp_index: The index in the descriptor ring for which this
- *              is the completion.
- * @cmd_data:   Command-specific bytes.
- * @color:      Color bit.  (Always 0 for commands issued to the
- *              Device Cmd Registers.)
+ * @status:     Status of the command (enum ionic_status_code)
+ * @comp_index: Index in the descriptor ring for which this is the completion
+ * @cmd_data:   Command-specific bytes
+ * @color:      Color bit (Always 0 for commands issued to the
+ *              Device Cmd Registers)
  */
 struct ionic_admin_comp {
        u8     status;
@@ -144,7 +150,7 @@ struct ionic_nop_cmd {
 
 /**
  * struct ionic_nop_comp - NOP command completion
- * @status: The status of the command (enum status_code)
+ * @status: Status of the command (enum ionic_status_code)
  */
 struct ionic_nop_comp {
        u8 status;
@@ -154,7 +160,7 @@ struct ionic_nop_comp {
 /**
  * struct ionic_dev_init_cmd - Device init command
  * @opcode:    opcode
- * @type:      device type
+ * @type:      Device type
  */
 struct ionic_dev_init_cmd {
        u8     opcode;
@@ -163,8 +169,8 @@ struct ionic_dev_init_cmd {
 };
 
 /**
- * struct init_comp - Device init command completion
- * @status: The status of the command (enum status_code)
+ * struct ionic_dev_init_comp - Device init command completion
+ * @status: Status of the command (enum ionic_status_code)
  */
 struct ionic_dev_init_comp {
        u8 status;
@@ -181,8 +187,8 @@ struct ionic_dev_reset_cmd {
 };
 
 /**
- * struct reset_comp - Reset command completion
- * @status: The status of the command (enum status_code)
+ * struct ionic_dev_reset_comp - Reset command completion
+ * @status: Status of the command (enum ionic_status_code)
  */
 struct ionic_dev_reset_comp {
        u8 status;
@@ -203,8 +209,8 @@ struct ionic_dev_identify_cmd {
 };
 
 /**
- * struct dev_identify_comp - Driver/device identify command completion
- * @status: The status of the command (enum status_code)
+ * struct ionic_dev_identify_comp - Driver/device identify command completion
+ * @status: Status of the command (enum ionic_status_code)
  * @ver:    Version of identify returned by device
  */
 struct ionic_dev_identify_comp {
@@ -223,8 +229,8 @@ enum ionic_os_type {
 };
 
 /**
- * union drv_identity - driver identity information
- * @os_type:          OS type (see enum os_type)
+ * union ionic_drv_identity - driver identity information
+ * @os_type:          OS type (see enum ionic_os_type)
  * @os_dist:          OS distribution, numeric format
  * @os_dist_str:      OS distribution, string format
  * @kernel_ver:       Kernel version, numeric format
@@ -240,26 +246,26 @@ union ionic_drv_identity {
                char   kernel_ver_str[32];
                char   driver_ver_str[32];
        };
-       __le32 words[512];
+       __le32 words[478];
 };
 
 /**
- * union dev_identity - device identity information
+ * union ionic_dev_identity - device identity information
  * @version:          Version of device identify
  * @type:             Identify type (0 for now)
  * @nports:           Number of ports provisioned
  * @nlifs:            Number of LIFs provisioned
  * @nintrs:           Number of interrupts provisioned
  * @ndbpgs_per_lif:   Number of doorbell pages per LIF
- * @intr_coal_mult:   Interrupt coalescing multiplication factor.
+ * @intr_coal_mult:   Interrupt coalescing multiplication factor
  *                    Scale user-supplied interrupt coalescing
  *                    value in usecs to device units using:
  *                    device units = usecs * mult / div
- * @intr_coal_div:    Interrupt coalescing division factor.
+ * @intr_coal_div:    Interrupt coalescing division factor
  *                    Scale user-supplied interrupt coalescing
  *                    value in usecs to device units using:
  *                    device units = usecs * mult / div
- *
+ * @eq_count:         Number of shared event queues
  */
 union ionic_dev_identity {
        struct {
@@ -273,8 +279,9 @@ union ionic_dev_identity {
                __le32 ndbpgs_per_lif;
                __le32 intr_coal_mult;
                __le32 intr_coal_div;
+               __le32 eq_count;
        };
-       __le32 words[512];
+       __le32 words[478];
 };
 
 enum ionic_lif_type {
@@ -284,10 +291,10 @@ enum ionic_lif_type {
 };
 
 /**
- * struct ionic_lif_identify_cmd - lif identify command
+ * struct ionic_lif_identify_cmd - LIF identify command
  * @opcode:  opcode
- * @type:    lif type (enum lif_type)
- * @ver:     version of identify returned by device
+ * @type:    LIF type (enum ionic_lif_type)
+ * @ver:     Version of identify returned by device
  */
 struct ionic_lif_identify_cmd {
        u8 opcode;
@@ -297,9 +304,9 @@ struct ionic_lif_identify_cmd {
 };
 
 /**
- * struct ionic_lif_identify_comp - lif identify command completion
- * @status:  status of the command (enum status_code)
- * @ver:     version of identify returned by device
+ * struct ionic_lif_identify_comp - LIF identify command completion
+ * @status:  Status of the command (enum ionic_status_code)
+ * @ver:     Version of identify returned by device
  */
 struct ionic_lif_identify_comp {
        u8 status;
@@ -307,13 +314,24 @@ struct ionic_lif_identify_comp {
        u8 rsvd2[14];
 };
 
+/**
+ * enum ionic_lif_capability - LIF capabilities
+ * @IONIC_LIF_CAP_ETH:     LIF supports Ethernet
+ * @IONIC_LIF_CAP_RDMA:    LIF support RDMA
+ */
 enum ionic_lif_capability {
        IONIC_LIF_CAP_ETH        = BIT(0),
        IONIC_LIF_CAP_RDMA       = BIT(1),
 };
 
 /**
- * Logical Queue Types
+ * enum ionic_logical_qtype - Logical Queue Types
+ * @IONIC_QTYPE_ADMINQ:    Administrative Queue
+ * @IONIC_QTYPE_NOTIFYQ:   Notify Queue
+ * @IONIC_QTYPE_RXQ:       Receive Queue
+ * @IONIC_QTYPE_TXQ:       Transmit Queue
+ * @IONIC_QTYPE_EQ:        Event Queue
+ * @IONIC_QTYPE_MAX:       Max queue type supported
  */
 enum ionic_logical_qtype {
        IONIC_QTYPE_ADMINQ  = 0,
@@ -325,11 +343,10 @@ enum ionic_logical_qtype {
 };
 
 /**
- * struct ionic_lif_logical_qtype - Descriptor of logical to hardware queue
- * type.
- * @qtype:          Hardware Queue Type.
- * @qid_count:      Number of Queue IDs of the logical type.
- * @qid_base:       Minimum Queue ID of the logical type.
+ * struct ionic_lif_logical_qtype - Descriptor of logical to HW queue type
+ * @qtype:          Hardware Queue Type
+ * @qid_count:      Number of Queue IDs of the logical type
+ * @qid_base:       Minimum Queue ID of the logical type
  */
 struct ionic_lif_logical_qtype {
        u8     qtype;
@@ -338,20 +355,27 @@ struct ionic_lif_logical_qtype {
        __le32 qid_base;
 };
 
+/**
+ * enum ionic_lif_state - LIF state
+ * @IONIC_LIF_DISABLE:     LIF disabled
+ * @IONIC_LIF_ENABLE:      LIF enabled
+ * @IONIC_LIF_QUIESCE:     LIF Quiesced
+ */
 enum ionic_lif_state {
-       IONIC_LIF_DISABLE       = 0,
+       IONIC_LIF_QUIESCE       = 0,
        IONIC_LIF_ENABLE        = 1,
-       IONIC_LIF_HANG_RESET    = 2,
+       IONIC_LIF_DISABLE       = 2,
 };
 
 /**
- * LIF configuration
- * @state:          lif state (enum lif_state)
- * @name:           lif name
- * @mtu:            mtu
- * @mac:            station mac address
- * @features:       features (enum ionic_eth_hw_features)
- * @queue_count:    queue counts per queue-type
+ * union ionic_lif_config - LIF configuration
+ * @state:          LIF state (enum ionic_lif_state)
+ * @name:           LIF name
+ * @mtu:            MTU
+ * @mac:            Station MAC address
+ * @vlan:           Default Vlan ID
+ * @features:       Features (enum ionic_eth_hw_features)
+ * @queue_count:    Queue counts per queue-type
  */
 union ionic_lif_config {
        struct {
@@ -360,45 +384,44 @@ union ionic_lif_config {
                char   name[IONIC_IFNAMSIZ];
                __le32 mtu;
                u8     mac[6];
-               u8     rsvd2[2];
+               __le16 vlan;
                __le64 features;
                __le32 queue_count[IONIC_QTYPE_MAX];
-       };
+       } __rte_packed;
        __le32 words[64];
 };
 
 /**
- * struct ionic_lif_identity - lif identity information (type-specific)
+ * struct ionic_lif_identity - LIF identity information (type-specific)
  *
- * @capabilities    LIF capabilities
+ * @capabilities:        LIF capabilities
  *
- * Ethernet:
- *     @version:          Ethernet identify structure version.
- *     @features:         Ethernet features supported on this lif type.
- *     @max_ucast_filters:  Number of perfect unicast addresses supported.
- *     @max_mcast_filters:  Number of perfect multicast addresses supported.
- *     @min_frame_size:   Minimum size of frames to be sent
- *     @max_frame_size:   Maximum size of frames to be sent
- *     @config:           LIF config struct with features, mtu, mac, q counts
+ * @eth:                    Ethernet identify structure
+ *     @version:            Ethernet identify structure version
+ *     @max_ucast_filters:  Number of perfect unicast addresses supported
+ *     @max_mcast_filters:  Number of perfect multicast addresses supported
+ *     @min_frame_size:     Minimum size of frames to be sent
+ *     @max_frame_size:     Maximum size of frames to be sent
+ *     @config:             LIF config struct with features, mtu, mac, q counts
  *
- * RDMA:
- *     @version:         RDMA version of opcodes and queue descriptors.
- *     @qp_opcodes:      Number of rdma queue pair opcodes supported.
- *     @admin_opcodes:   Number of rdma admin opcodes supported.
- *     @npts_per_lif:    Page table size per lif
- *     @nmrs_per_lif:    Number of memory regions per lif
- *     @nahs_per_lif:    Number of address handles per lif
- *     @max_stride:      Max work request stride.
- *     @cl_stride:       Cache line stride.
- *     @pte_stride:      Page table entry stride.
- *     @rrq_stride:      Remote RQ work request stride.
- *     @rsq_stride:      Remote SQ work request stride.
+ * @rdma:                RDMA identify structure
+ *     @version:         RDMA version of opcodes and queue descriptors
+ *     @qp_opcodes:      Number of RDMA queue pair opcodes supported
+ *     @admin_opcodes:   Number of RDMA admin opcodes supported
+ *     @npts_per_lif:    Page table size per LIF
+ *     @nmrs_per_lif:    Number of memory regions per LIF
+ *     @nahs_per_lif:    Number of address handles per LIF
+ *     @max_stride:      Max work request stride
+ *     @cl_stride:       Cache line stride
+ *     @pte_stride:      Page table entry stride
+ *     @rrq_stride:      Remote RQ work request stride
+ *     @rsq_stride:      Remote SQ work request stride
  *     @dcqcn_profiles:  Number of DCQCN profiles
- *     @aq_qtype:        RDMA Admin Qtype.
- *     @sq_qtype:        RDMA Send Qtype.
- *     @rq_qtype:        RDMA Receive Qtype.
- *     @cq_qtype:        RDMA Completion Qtype.
- *     @eq_qtype:        RDMA Event Qtype.
+ *     @aq_qtype:        RDMA Admin Qtype
+ *     @sq_qtype:        RDMA Send Qtype
+ *     @rq_qtype:        RDMA Receive Qtype
+ *     @cq_qtype:        RDMA Completion Qtype
+ *     @eq_qtype:        RDMA Event Qtype
  */
 union ionic_lif_identity {
        struct {
@@ -414,7 +437,7 @@ union ionic_lif_identity {
                        __le32 max_frame_size;
                        u8 rsvd2[106];
                        union ionic_lif_config config;
-               } eth;
+               } __rte_packed eth;
 
                struct {
                        u8 version;
@@ -436,17 +459,17 @@ union ionic_lif_identity {
                        struct ionic_lif_logical_qtype rq_qtype;
                        struct ionic_lif_logical_qtype cq_qtype;
                        struct ionic_lif_logical_qtype eq_qtype;
-               } rdma;
-       };
-       __le32 words[512];
+               } __rte_packed rdma;
+       } __rte_packed;
+       __le32 words[478];
 };
 
 /**
  * struct ionic_lif_init_cmd - LIF init command
- * @opcode:       opcode
- * @type:         LIF type (enum lif_type)
+ * @opcode:       Opcode
+ * @type:         LIF type (enum ionic_lif_type)
  * @index:        LIF index
- * @info_pa:      destination address for lif info (struct ionic_lif_info)
+ * @info_pa:      Destination address for LIF info (struct ionic_lif_info)
  */
 struct ionic_lif_init_cmd {
        u8     opcode;
@@ -459,7 +482,8 @@ struct ionic_lif_init_cmd {
 
 /**
  * struct ionic_lif_init_comp - LIF init command completion
- * @status: The status of the command (enum status_code)
+ * @status:    Status of the command (enum ionic_status_code)
+ * @hw_index:  Hardware index of the initialized LIF
  */
 struct ionic_lif_init_comp {
        u8 status;
@@ -468,14 +492,74 @@ struct ionic_lif_init_comp {
        u8 rsvd2[12];
 };
 
+/**
+ * struct ionic_q_identify_cmd - queue identify command
+ * @opcode:     opcode
+ * @lif_type:   LIF type (enum ionic_lif_type)
+ * @type:       Logical queue type (enum ionic_logical_qtype)
+ * @ver:        Highest queue type version that the driver supports
+ */
+struct ionic_q_identify_cmd {
+       u8     opcode;
+       u8     rsvd;
+       __le16 lif_type;
+       u8     type;
+       u8     ver;
+       u8     rsvd2[58];
+};
+
+/**
+ * struct ionic_q_identify_comp - queue identify command completion
+ * @status:     Status of the command (enum ionic_status_code)
+ * @comp_index: Index in the descriptor ring for which this is the completion
+ * @ver:        Queue type version that can be used with FW
+ */
+struct ionic_q_identify_comp {
+       u8     status;
+       u8     rsvd;
+       __le16 comp_index;
+       u8     ver;
+       u8     rsvd2[11];
+};
+
+/**
+ * union ionic_q_identity - queue identity information
+ *     @version:        Queue type version that can be used with FW
+ *     @supported:      Bitfield of queue versions, first bit = ver 0
+ *     @features:       Queue features
+ *     @desc_sz:        Descriptor size
+ *     @comp_sz:        Completion descriptor size
+ *     @sg_desc_sz:     Scatter/Gather descriptor size
+ *     @max_sg_elems:   Maximum number of Scatter/Gather elements
+ *     @sg_desc_stride: Number of Scatter/Gather elements per descriptor
+ */
+union ionic_q_identity {
+       struct {
+               u8      version;
+               u8      supported;
+               u8      rsvd[6];
+#define IONIC_QIDENT_F_CQ      0x01    /* queue has completion ring */
+#define IONIC_QIDENT_F_SG      0x02    /* queue has scatter/gather ring */
+#define IONIC_QIDENT_F_EQ      0x04    /* queue can use event queue */
+#define IONIC_QIDENT_F_CMB     0x08    /* queue is in cmb bar */
+               __le64  features;
+               __le16  desc_sz;
+               __le16  comp_sz;
+               __le16  sg_desc_sz;
+               __le16  max_sg_elems;
+               __le16  sg_desc_stride;
+       };
+       __le32 words[478];
+};
+
 /**
  * struct ionic_q_init_cmd - Queue init command
  * @opcode:       opcode
  * @type:         Logical queue type
- * @ver:          Queue version (defines opcode/descriptor scope)
+ * @ver:          Queue type version
  * @lif_index:    LIF index
- * @index:        (lif, qtype) relative admin queue index
- * @intr_index:   Interrupt control register index
+ * @index:        (LIF, qtype) relative admin queue index
+ * @intr_index:   Interrupt control register index, or Event queue index
  * @pid:          Process ID
  * @flags:
  *    IRQ:        Interrupt requested on completion
@@ -493,12 +577,11 @@ struct ionic_lif_init_comp {
  *                descriptors.  Values of ring_size <2 and >16 are
  *                reserved.
  *    EQ:         Enable the Event Queue
- * @cos:          Class of service for this queue.
+ * @cos:          Class of service for this queue
  * @ring_size:    Queue ring size, encoded as a log2(size)
  * @ring_base:    Queue ring base address
  * @cq_ring_base: Completion queue ring base address
  * @sg_ring_base: Scatter/Gather ring base address
- * @eq_index:    Event queue index
  */
 struct ionic_q_init_cmd {
        u8     opcode;
@@ -515,29 +598,27 @@ struct ionic_q_init_cmd {
 #define IONIC_QINIT_F_ENA      0x02    /* Enable the queue */
 #define IONIC_QINIT_F_SG       0x04    /* Enable scatter/gather on the queue */
 #define IONIC_QINIT_F_EQ       0x08    /* Enable event queue */
-#define IONIC_QINIT_F_DEBUG 0x80       /* Enable queue debugging */
+#define IONIC_QINIT_F_CMB      0x10    /* Enable cmb-based queue */
+#define IONIC_QINIT_F_DEBUG    0x80    /* Enable queue debugging */
        u8     cos;
        u8     ring_size;
        __le64 ring_base;
        __le64 cq_ring_base;
        __le64 sg_ring_base;
-       __le32 eq_index;
-       u8     rsvd2[16];
-};
+       u8     rsvd2[20];
+} __rte_packed;
 
 /**
  * struct ionic_q_init_comp - Queue init command completion
- * @status:     The status of the command (enum status_code)
- * @ver:        Queue version (defines opcode/descriptor scope)
- * @comp_index: The index in the descriptor ring for which this
- *              is the completion.
+ * @status:     Status of the command (enum ionic_status_code)
+ * @comp_index: Index in the descriptor ring for which this is the completion
  * @hw_index:   Hardware Queue ID
  * @hw_type:    Hardware Queue type
  * @color:      Color
  */
 struct ionic_q_init_comp {
        u8     status;
-       u8     ver;
+       u8     rsvd;
        __le16 comp_index;
        __le32 hw_index;
        u8     hw_type;
@@ -558,10 +639,9 @@ enum ionic_txq_desc_opcode {
 
 /**
  * struct ionic_txq_desc - Ethernet Tx queue descriptor format
- * @opcode:       Tx operation, see TXQ_DESC_OPCODE_*:
+ * @cmd:          Tx operation, see IONIC_TXQ_DESC_OPCODE_*:
  *
  *                   IONIC_TXQ_DESC_OPCODE_CSUM_NONE:
- *
  *                      Non-offload send.  No segmentation,
  *                      fragmentation or checksum calc/insertion is
  *                      performed by device; packet is prepared
@@ -569,7 +649,6 @@ enum ionic_txq_desc_opcode {
  *                      no further manipulation from device.
  *
  *                   IONIC_TXQ_DESC_OPCODE_CSUM_PARTIAL:
- *
  *                      Offload 16-bit L4 checksum
  *                      calculation/insertion.  The device will
  *                      calculate the L4 checksum value and
@@ -578,14 +657,16 @@ enum ionic_txq_desc_opcode {
  *                      is calculated starting at @csum_start bytes
  *                      into the packet to the end of the packet.
  *                      The checksum insertion position is given
- *                      in @csum_offset.  This feature is only
- *                      applicable to protocols such as TCP, UDP
- *                      and ICMP where a standard (i.e. the
- *                      'IP-style' checksum) one's complement
- *                      16-bit checksum is used, using an IP
- *                      pseudo-header to seed the calculation.
- *                      Software will preload the L4 checksum
- *                      field with the IP pseudo-header checksum.
+ *                      in @csum_offset, which is the offset from
+ *                      @csum_start to the checksum field in the L4
+ *                      header.  This feature is only applicable to
+ *                      protocols such as TCP, UDP and ICMP where a
+ *                      standard (i.e. the 'IP-style' checksum)
+ *                      one's complement 16-bit checksum is used,
+ *                      using an IP pseudo-header to seed the
+ *                      calculation.  Software will preload the L4
+ *                      checksum field with the IP pseudo-header
+ *                      checksum.
  *
  *                      For tunnel encapsulation, @csum_start and
  *                      @csum_offset refer to the inner L4
@@ -597,11 +678,10 @@ enum ionic_txq_desc_opcode {
  *                      the @encap is set, the device will
  *                      offload the outer header checksums using
  *                      LCO (local checksum offload) (see
- *                      Documentation/networking/checksum-
- *                      offloads.txt for more info).
+ *                      Documentation/networking/checksum-offloads.rst
+ *                      for more info).
  *
  *                   IONIC_TXQ_DESC_OPCODE_CSUM_HW:
- *
  *                      Offload 16-bit checksum computation to hardware.
  *                      If @csum_l3 is set then the packet's L3 checksum is
  *                      updated. Similarly, if @csum_l4 is set the the L4
@@ -609,7 +689,6 @@ enum ionic_txq_desc_opcode {
  *                      checksums are also updated.
  *
  *                   IONIC_TXQ_DESC_OPCODE_TSO:
- *
  *                      Device performs TCP segmentation offload
  *                      (TSO).  @hdr_len is the number of bytes
  *                      to the end of TCP header (the offset to
@@ -636,40 +715,41 @@ enum ionic_txq_desc_opcode {
  *                      clear CWR in remaining segments.
  * @flags:
  *                vlan:
- *                    Insert an L2 VLAN header using @vlan_tci.
+ *                    Insert an L2 VLAN header using @vlan_tci
  *                encap:
- *                    Calculate encap header checksum.
+ *                    Calculate encap header checksum
  *                csum_l3:
- *                    Compute L3 header checksum.
+ *                    Compute L3 header checksum
  *                csum_l4:
- *                    Compute L4 header checksum.
+ *                    Compute L4 header checksum
  *                tso_sot:
  *                    TSO start
  *                tso_eot:
  *                    TSO end
  * @num_sg_elems: Number of scatter-gather elements in SG
  *                descriptor
- * @addr:         First data buffer's DMA address.
- *                (Subsequent data buffers are on txq_sg_desc).
+ * @addr:         First data buffer's DMA address
+ *                (Subsequent data buffers are on txq_sg_desc)
  * @len:          First data buffer's length, in bytes
  * @vlan_tci:     VLAN tag to insert in the packet (if requested
  *                by @V-bit).  Includes .1p and .1q tags
  * @hdr_len:      Length of packet headers, including
- *                encapsulating outer header, if applicable.
- *                Valid for opcodes TXQ_DESC_OPCODE_CALC_CSUM and
- *                TXQ_DESC_OPCODE_TSO.  Should be set to zero for
+ *                encapsulating outer header, if applicable
+ *                Valid for opcodes IONIC_TXQ_DESC_OPCODE_CALC_CSUM and
+ *                IONIC_TXQ_DESC_OPCODE_TSO.  Should be set to zero for
  *                all other modes.  For
- *                TXQ_DESC_OPCODE_CALC_CSUM, @hdr_len is length
+ *                IONIC_TXQ_DESC_OPCODE_CALC_CSUM, @hdr_len is length
  *                of headers up to inner-most L4 header.  For
- *                TXQ_DESC_OPCODE_TSO, @hdr_len is up to
+ *                IONIC_TXQ_DESC_OPCODE_TSO, @hdr_len is up to
  *                inner-most L4 payload, so inclusive of
  *                inner-most L4 header.
- * @mss:          Desired MSS value for TSO.  Only applicable for
- *                TXQ_DESC_OPCODE_TSO.
- * @csum_start:   Offset into inner-most L3 header of checksum
- * @csum_offset:  Offset into inner-most L4 header of checksum
+ * @mss:          Desired MSS value for TSO; only applicable for
+ *                IONIC_TXQ_DESC_OPCODE_TSO
+ * @csum_start:   Offset from packet to first byte checked in L4 checksum
+ * @csum_offset:  Offset from csum_start to L4 checksum field
  */
-
+struct ionic_txq_desc {
+       __le64  cmd;
 #define IONIC_TXQ_DESC_OPCODE_MASK             0xf
 #define IONIC_TXQ_DESC_OPCODE_SHIFT            4
 #define IONIC_TXQ_DESC_FLAGS_MASK              0xf
@@ -691,8 +771,6 @@ enum ionic_txq_desc_opcode {
 #define IONIC_TXQ_DESC_FLAG_TSO_SOT            0x4
 #define IONIC_TXQ_DESC_FLAG_TSO_EOT            0x8
 
-struct ionic_txq_desc {
-       __le64  cmd;
        __le16  len;
        union {
                __le16  vlan_tci;
@@ -719,45 +797,60 @@ static inline u64 encode_txq_desc_cmd(u8 opcode, u8 flags,
                IONIC_TXQ_DESC_OPCODE_SHIFT;
        cmd |= (flags & IONIC_TXQ_DESC_FLAGS_MASK) <<
                IONIC_TXQ_DESC_FLAGS_SHIFT;
-       cmd |= (nsge & IONIC_TXQ_DESC_NSGE_MASK) << IONIC_TXQ_DESC_NSGE_SHIFT;
-       cmd |= (addr & IONIC_TXQ_DESC_ADDR_MASK) << IONIC_TXQ_DESC_ADDR_SHIFT;
+       cmd |= (nsge & IONIC_TXQ_DESC_NSGE_MASK) <<
+               IONIC_TXQ_DESC_NSGE_SHIFT;
+       cmd |= (addr & IONIC_TXQ_DESC_ADDR_MASK) <<
+               IONIC_TXQ_DESC_ADDR_SHIFT;
 
        return cmd;
 };
 
-static inline void decode_txq_desc_cmd(u64 cmd, u8 *opcode, u8 *flags,
+static inline void
+decode_txq_desc_cmd(u64 cmd, u8 *opcode, u8 *flags,
                                       u8 *nsge, u64 *addr)
 {
        *opcode = (cmd >> IONIC_TXQ_DESC_OPCODE_SHIFT) &
                IONIC_TXQ_DESC_OPCODE_MASK;
        *flags = (cmd >> IONIC_TXQ_DESC_FLAGS_SHIFT) &
                IONIC_TXQ_DESC_FLAGS_MASK;
-       *nsge = (cmd >> IONIC_TXQ_DESC_NSGE_SHIFT) & IONIC_TXQ_DESC_NSGE_MASK;
-       *addr = (cmd >> IONIC_TXQ_DESC_ADDR_SHIFT) & IONIC_TXQ_DESC_ADDR_MASK;
+       *nsge = (cmd >> IONIC_TXQ_DESC_NSGE_SHIFT) &
+               IONIC_TXQ_DESC_NSGE_MASK;
+       *addr = (cmd >> IONIC_TXQ_DESC_ADDR_SHIFT) &
+               IONIC_TXQ_DESC_ADDR_MASK;
 };
 
-#define IONIC_TX_MAX_SG_ELEMS  8
-#define IONIC_RX_MAX_SG_ELEMS  8
-
 /**
- * struct ionic_txq_sg_desc - Transmit scatter-gather (SG) list
+ * struct ionic_txq_sg_elem - Transmit scatter-gather (SG) descriptor element
  * @addr:      DMA address of SG element data buffer
  * @len:       Length of SG element data buffer, in bytes
  */
+struct ionic_txq_sg_elem {
+       __le64 addr;
+       __le16 len;
+       __le16 rsvd[3];
+};
+
+/**
+ * struct ionic_txq_sg_desc - Transmit scatter-gather (SG) list
+ * @elems:     Scatter-gather elements
+ */
 struct ionic_txq_sg_desc {
-       struct ionic_txq_sg_elem {
-               __le64 addr;
-               __le16 len;
-               __le16 rsvd[3];
-       } elems[IONIC_TX_MAX_SG_ELEMS];
+#define IONIC_TX_MAX_SG_ELEMS          8
+#define IONIC_TX_SG_DESC_STRIDE                8
+       struct ionic_txq_sg_elem elems[IONIC_TX_MAX_SG_ELEMS];
+};
+
+struct ionic_txq_sg_desc_v1 {
+#define IONIC_TX_MAX_SG_ELEMS_V1               15
+#define IONIC_TX_SG_DESC_STRIDE_V1             16
+       struct ionic_txq_sg_elem elems[IONIC_TX_SG_DESC_STRIDE_V1];
 };
 
 /**
  * struct ionic_txq_comp - Ethernet transmit queue completion descriptor
- * @status:     The status of the command (enum status_code)
- * @comp_index: The index in the descriptor ring for which this
- *                 is the completion.
- * @color:      Color bit.
+ * @status:     Status of the command (enum ionic_status_code)
+ * @comp_index: Index in the descriptor ring for which this is the completion
+ * @color:      Color bit
  */
 struct ionic_txq_comp {
        u8     status;
@@ -774,16 +867,15 @@ enum ionic_rxq_desc_opcode {
 
 /**
  * struct ionic_rxq_desc - Ethernet Rx queue descriptor format
- * @opcode:       Rx operation, see RXQ_DESC_OPCODE_*:
- *
- *                   RXQ_DESC_OPCODE_SIMPLE:
+ * @opcode:       Rx operation, see IONIC_RXQ_DESC_OPCODE_*:
  *
+ *                   IONIC_RXQ_DESC_OPCODE_SIMPLE:
  *                      Receive full packet into data buffer
  *                      starting at @addr.  Results of
  *                      receive, including actual bytes received,
  *                      are recorded in Rx completion descriptor.
  *
- * @len:          Data buffer's length, in bytes.
+ * @len:          Data buffer's length, in bytes
  * @addr:         Data buffer's DMA address
  */
 struct ionic_rxq_desc {
@@ -794,26 +886,33 @@ struct ionic_rxq_desc {
 };
 
 /**
- * struct ionic_rxq_sg_desc - Receive scatter-gather (SG) list
+ * struct ionic_rxq_sg_elem - Receive scatter-gather (SG) descriptor element
  * @addr:      DMA address of SG element data buffer
  * @len:       Length of SG element data buffer, in bytes
  */
+struct ionic_rxq_sg_elem {
+       __le64 addr;
+       __le16 len;
+       __le16 rsvd[3];
+};
+
+/**
+ * struct ionic_rxq_sg_desc - Receive scatter-gather (SG) list
+ * @elems:     Scatter-gather elements
+ */
 struct ionic_rxq_sg_desc {
-       struct ionic_rxq_sg_elem {
-               __le64 addr;
-               __le16 len;
-               __le16 rsvd[3];
-       } elems[IONIC_RX_MAX_SG_ELEMS];
+#define IONIC_RX_MAX_SG_ELEMS          8
+#define IONIC_RX_SG_DESC_STRIDE                8
+       struct ionic_rxq_sg_elem elems[IONIC_RX_SG_DESC_STRIDE];
 };
 
 /**
  * struct ionic_rxq_comp - Ethernet receive queue completion descriptor
- * @status:       The status of the command (enum status_code)
+ * @status:       Status of the command (enum ionic_status_code)
  * @num_sg_elems: Number of SG elements used by this descriptor
- * @comp_index:   The index in the descriptor ring for which this
- *                is the completion.
+ * @comp_index:   Index in the descriptor ring for which this is the completion
  * @rss_hash:     32-bit RSS hash
- * @csum:         16-bit sum of the packet's L2 payload.
+ * @csum:         16-bit sum of the packet's L2 payload
  *                If the packet's L2 payload is odd length, an extra
  *                zero-value byte is included in the @csum calculation but
  *                not included in @len.
@@ -821,33 +920,51 @@ struct ionic_rxq_sg_desc {
  *                set.  Includes .1p and .1q tags.
  * @len:          Received packet length, in bytes.  Excludes FCS.
  * @csum_calc     L2 payload checksum is computed or not
- * @csum_tcp_ok:  The TCP checksum calculated by the device
- *                matched the checksum in the receive packet's
- *                TCP header
- * @csum_tcp_bad: The TCP checksum calculated by the device did
- *                not match the checksum in the receive packet's
- *                TCP header.
- * @csum_udp_ok:  The UDP checksum calculated by the device
- *                matched the checksum in the receive packet's
- *                UDP header
- * @csum_udp_bad: The UDP checksum calculated by the device did
- *                not match the checksum in the receive packet's
- *                UDP header.
- * @csum_ip_ok:   The IPv4 checksum calculated by the device
- *                matched the checksum in the receive packet's
- *                first IPv4 header.  If the receive packet
- *                contains both a tunnel IPv4 header and a
- *                transport IPv4 header, the device validates the
- *                checksum for the both IPv4 headers.
- * @csum_ip_bad:  The IPv4 checksum calculated by the device did
- *                not match the checksum in the receive packet's
- *                first IPv4 header. If the receive packet
- *                contains both a tunnel IPv4 header and a
- *                transport IPv4 header, the device validates the
- *                checksum for both IP headers.
- * @VLAN:         VLAN header was stripped and placed in @vlan_tci.
- * @pkt_type:     Packet type
- * @color:        Color bit.
+ * @csum_flags:   See IONIC_RXQ_COMP_CSUM_F_*:
+ *
+ *                  IONIC_RXQ_COMP_CSUM_F_TCP_OK:
+ *                    The TCP checksum calculated by the device
+ *                    matched the checksum in the receive packet's
+ *                    TCP header.
+ *
+ *                  IONIC_RXQ_COMP_CSUM_F_TCP_BAD:
+ *                    The TCP checksum calculated by the device did
+ *                    not match the checksum in the receive packet's
+ *                    TCP header.
+ *
+ *                  IONIC_RXQ_COMP_CSUM_F_UDP_OK:
+ *                    The UDP checksum calculated by the device
+ *                    matched the checksum in the receive packet's
+ *                    UDP header
+ *
+ *                  IONIC_RXQ_COMP_CSUM_F_UDP_BAD:
+ *                    The UDP checksum calculated by the device did
+ *                    not match the checksum in the receive packet's
+ *                    UDP header.
+ *
+ *                  IONIC_RXQ_COMP_CSUM_F_IP_OK:
+ *                    The IPv4 checksum calculated by the device
+ *                    matched the checksum in the receive packet's
+ *                    first IPv4 header.  If the receive packet
+ *                    contains both a tunnel IPv4 header and a
+ *                    transport IPv4 header, the device validates the
+ *                    checksum for the both IPv4 headers.
+ *
+ *                  IONIC_RXQ_COMP_CSUM_F_IP_BAD:
+ *                    The IPv4 checksum calculated by the device did
+ *                    not match the checksum in the receive packet's
+ *                    first IPv4 header. If the receive packet
+ *                    contains both a tunnel IPv4 header and a
+ *                    transport IPv4 header, the device validates the
+ *                    checksum for both IP headers.
+ *
+ *                  IONIC_RXQ_COMP_CSUM_F_VLAN:
+ *                    The VLAN header was stripped and placed in @vlan_tci.
+ *
+ *                  IONIC_RXQ_COMP_CSUM_F_CALC:
+ *                    The checksum was calculated by the device.
+ *
+ * @pkt_type_color: Packet type and color bit; see IONIC_RXQ_COMP_PKT_TYPE_MASK
  */
 struct ionic_rxq_comp {
        u8     status;
@@ -867,17 +984,25 @@ struct ionic_rxq_comp {
 #define IONIC_RXQ_COMP_CSUM_F_VLAN     0x40
 #define IONIC_RXQ_COMP_CSUM_F_CALC     0x80
        u8     pkt_type_color;
-#define IONIC_RXQ_COMP_PKT_TYPE_MASK   0x0f
+#define IONIC_RXQ_COMP_PKT_TYPE_MASK   0x7f
 };
 
 enum ionic_pkt_type {
-       IONIC_PKT_TYPE_NON_IP     = 0x000,
-       IONIC_PKT_TYPE_IPV4       = 0x001,
-       IONIC_PKT_TYPE_IPV4_TCP   = 0x003,
-       IONIC_PKT_TYPE_IPV4_UDP   = 0x005,
-       IONIC_PKT_TYPE_IPV6       = 0x008,
-       IONIC_PKT_TYPE_IPV6_TCP   = 0x018,
-       IONIC_PKT_TYPE_IPV6_UDP   = 0x028,
+       IONIC_PKT_TYPE_NON_IP           = 0x00,
+       IONIC_PKT_TYPE_IPV4             = 0x01,
+       IONIC_PKT_TYPE_IPV4_TCP         = 0x03,
+       IONIC_PKT_TYPE_IPV4_UDP         = 0x05,
+       IONIC_PKT_TYPE_IPV6             = 0x08,
+       IONIC_PKT_TYPE_IPV6_TCP         = 0x18,
+       IONIC_PKT_TYPE_IPV6_UDP         = 0x28,
+       /* below types are only used if encap offloads are enabled on lif */
+       IONIC_PKT_TYPE_ENCAP_NON_IP     = 0x40,
+       IONIC_PKT_TYPE_ENCAP_IPV4       = 0x41,
+       IONIC_PKT_TYPE_ENCAP_IPV4_TCP   = 0x43,
+       IONIC_PKT_TYPE_ENCAP_IPV4_UDP   = 0x45,
+       IONIC_PKT_TYPE_ENCAP_IPV6       = 0x48,
+       IONIC_PKT_TYPE_ENCAP_IPV6_TCP   = 0x58,
+       IONIC_PKT_TYPE_ENCAP_IPV6_UDP   = 0x68,
 };
 
 enum ionic_eth_hw_features {
@@ -894,10 +1019,13 @@ enum ionic_eth_hw_features {
        IONIC_ETH_HW_TSO_ECN            = BIT(10),
        IONIC_ETH_HW_TSO_GRE            = BIT(11),
        IONIC_ETH_HW_TSO_GRE_CSUM       = BIT(12),
-       IONIC_ETH_HW_TSO_IPXIP4 = BIT(13),
-       IONIC_ETH_HW_TSO_IPXIP6 = BIT(14),
+       IONIC_ETH_HW_TSO_IPXIP4         = BIT(13),
+       IONIC_ETH_HW_TSO_IPXIP6         = BIT(14),
        IONIC_ETH_HW_TSO_UDP            = BIT(15),
        IONIC_ETH_HW_TSO_UDP_CSUM       = BIT(16),
+       IONIC_ETH_HW_RX_CSUM_GENEVE     = BIT(17),
+       IONIC_ETH_HW_TX_CSUM_GENEVE     = BIT(18),
+       IONIC_ETH_HW_TSO_GENEVE         = BIT(19)
 };
 
 /**
@@ -906,7 +1034,7 @@ enum ionic_eth_hw_features {
  * @type:       Queue type
  * @lif_index:  LIF index
  * @index:      Queue index
- * @oper:       Operation (enum q_control_oper)
+ * @oper:       Operation (enum ionic_q_control_oper)
  */
 struct ionic_q_control_cmd {
        u8     opcode;
@@ -919,14 +1047,17 @@ struct ionic_q_control_cmd {
 
 typedef struct ionic_admin_comp ionic_q_control_comp;
 
-enum q_control_oper {
+enum ionic_q_control_oper {
        IONIC_Q_DISABLE         = 0,
        IONIC_Q_ENABLE          = 1,
        IONIC_Q_HANG_RESET      = 2,
 };
 
 /**
- * Physical connection type
+ * enum ionic_phy_type - Physical connection type
+ * @IONIC_PHY_TYPE_NONE:    No PHY installed
+ * @IONIC_PHY_TYPE_COPPER:  Copper PHY
+ * @IONIC_PHY_TYPE_FIBER:   Fiber PHY
  */
 enum ionic_phy_type {
        IONIC_PHY_TYPE_NONE     = 0,
@@ -935,18 +1066,23 @@ enum ionic_phy_type {
 };
 
 /**
- * Transceiver status
+ * enum ionic_xcvr_state - Transceiver status
+ * @IONIC_XCVR_STATE_REMOVED:        Transceiver removed
+ * @IONIC_XCVR_STATE_INSERTED:       Transceiver inserted
+ * @IONIC_XCVR_STATE_PENDING:        Transceiver pending
+ * @IONIC_XCVR_STATE_SPROM_READ:     Transceiver data read
+ * @IONIC_XCVR_STATE_SPROM_READ_ERR: Transceiver data read error
  */
 enum ionic_xcvr_state {
        IONIC_XCVR_STATE_REMOVED         = 0,
        IONIC_XCVR_STATE_INSERTED        = 1,
        IONIC_XCVR_STATE_PENDING         = 2,
        IONIC_XCVR_STATE_SPROM_READ      = 3,
-       IONIC_XCVR_STATE_SPROM_READ_ERR  = 4,
+       IONIC_XCVR_STATE_SPROM_READ_ERR  = 4,
 };
 
 /**
- * Supported link modes
+ * enum ionic_xcvr_pid - Supported link modes
  */
 enum ionic_xcvr_pid {
        IONIC_XCVR_PID_UNKNOWN           = 0,
@@ -980,67 +1116,74 @@ enum ionic_xcvr_pid {
        IONIC_XCVR_PID_SFP_10GBASE_CU   = 68,
        IONIC_XCVR_PID_QSFP_100G_CWDM4  = 69,
        IONIC_XCVR_PID_QSFP_100G_PSM4   = 70,
+       IONIC_XCVR_PID_SFP_25GBASE_ACC  = 71,
 };
 
 /**
- * Port types
- */
-enum ionic_port_type {
-       IONIC_PORT_TYPE_NONE = 0,  /* port type not configured */
-       IONIC_PORT_TYPE_ETH  = 1,  /* port carries ethernet traffic (inband) */
-       IONIC_PORT_TYPE_MGMT = 2,  /* port carries mgmt traffic (out-of-band) */
-};
-
-/**
- * Port config state
+ * enum ionic_port_admin_state - Port config state
+ * @IONIC_PORT_ADMIN_STATE_NONE:    Port admin state not configured
+ * @IONIC_PORT_ADMIN_STATE_DOWN:    Port admin disabled
+ * @IONIC_PORT_ADMIN_STATE_UP:      Port admin enabled
  */
 enum ionic_port_admin_state {
-       IONIC_PORT_ADMIN_STATE_NONE = 0,   /* port admin state not configured */
-       IONIC_PORT_ADMIN_STATE_DOWN = 1,   /* port is admin disabled */
-       IONIC_PORT_ADMIN_STATE_UP   = 2,   /* port is admin enabled */
+       IONIC_PORT_ADMIN_STATE_NONE = 0,
+       IONIC_PORT_ADMIN_STATE_DOWN = 1,
+       IONIC_PORT_ADMIN_STATE_UP   = 2,
 };
 
 /**
- * Port operational status
+ * enum ionic_port_oper_status - Port operational status
+ * @IONIC_PORT_OPER_STATUS_NONE:    Port disabled
+ * @IONIC_PORT_OPER_STATUS_UP:      Port link status up
+ * @IONIC_PORT_OPER_STATUS_DOWN:    Port link status down
  */
 enum ionic_port_oper_status {
-       IONIC_PORT_OPER_STATUS_NONE  = 0,       /* port is disabled */
-       IONIC_PORT_OPER_STATUS_UP    = 1,       /* port is linked up */
-       IONIC_PORT_OPER_STATUS_DOWN  = 2,       /* port link status is down */
+       IONIC_PORT_OPER_STATUS_NONE  = 0,
+       IONIC_PORT_OPER_STATUS_UP    = 1,
+       IONIC_PORT_OPER_STATUS_DOWN  = 2,
 };
 
 /**
- * Ethernet Forward error correction (fec) modes
+ * enum ionic_port_fec_type - Ethernet Forward error correction (FEC) modes
+ * @IONIC_PORT_FEC_TYPE_NONE:       FEC Disabled
+ * @IONIC_PORT_FEC_TYPE_FC:         FireCode FEC
+ * @IONIC_PORT_FEC_TYPE_RS:         ReedSolomon FEC
  */
 enum ionic_port_fec_type {
-       IONIC_PORT_FEC_TYPE_NONE = 0,           /* Disabled */
-       IONIC_PORT_FEC_TYPE_FC   = 1,           /* FireCode */
-       IONIC_PORT_FEC_TYPE_RS   = 2,           /* ReedSolomon */
+       IONIC_PORT_FEC_TYPE_NONE = 0,
+       IONIC_PORT_FEC_TYPE_FC   = 1,
+       IONIC_PORT_FEC_TYPE_RS   = 2,
 };
 
 /**
- * Ethernet pause (flow control) modes
+ * enum ionic_port_pause_type - Ethernet pause (flow control) modes
+ * @IONIC_PORT_PAUSE_TYPE_NONE:     Disable Pause
+ * @IONIC_PORT_PAUSE_TYPE_LINK:     Link level pause
+ * @IONIC_PORT_PAUSE_TYPE_PFC:      Priority-Flow Control
  */
 enum ionic_port_pause_type {
-       IONIC_PORT_PAUSE_TYPE_NONE = 0, /* Disable Pause */
-       IONIC_PORT_PAUSE_TYPE_LINK = 1, /* Link level pause */
-       IONIC_PORT_PAUSE_TYPE_PFC  = 2, /* Priority-Flow control */
+       IONIC_PORT_PAUSE_TYPE_NONE = 0,
+       IONIC_PORT_PAUSE_TYPE_LINK = 1,
+       IONIC_PORT_PAUSE_TYPE_PFC  = 2,
 };
 
 /**
- * Loopback modes
+ * enum ionic_port_loopback_mode - Loopback modes
+ * @IONIC_PORT_LOOPBACK_MODE_NONE:  Disable loopback
+ * @IONIC_PORT_LOOPBACK_MODE_MAC:   MAC loopback
+ * @IONIC_PORT_LOOPBACK_MODE_PHY:   PHY/SerDes loopback
  */
 enum ionic_port_loopback_mode {
-       IONIC_PORT_LOOPBACK_MODE_NONE = 0,      /* Disable loopback */
-       IONIC_PORT_LOOPBACK_MODE_MAC  = 1,      /* MAC loopback */
-       IONIC_PORT_LOOPBACK_MODE_PHY  = 2,      /* PHY/Serdes loopback */
+       IONIC_PORT_LOOPBACK_MODE_NONE = 0,
+       IONIC_PORT_LOOPBACK_MODE_MAC  = 1,
+       IONIC_PORT_LOOPBACK_MODE_PHY  = 2,
 };
 
 /**
- * Transceiver Status information
+ * struct ionic_xcvr_status - Transceiver Status information
  * @state:    Transceiver status (enum ionic_xcvr_state)
  * @phy:      Physical connection type (enum ionic_phy_type)
- * @pid:      Transceiver link mode (enum pid)
+ * @pid:      Transceiver link mode (enum ionic_xcvr_pid)
  * @sprom:    Transceiver sprom contents
  */
 struct ionic_xcvr_status {
@@ -1051,10 +1194,10 @@ struct ionic_xcvr_status {
 };
 
 /**
- * Port configuration
+ * union ionic_port_config - Port configuration
  * @speed:              port speed (in Mbps)
  * @mtu:                mtu
- * @state:              port admin state (enum port_admin_state)
+ * @state:              port admin state (enum ionic_port_admin_state)
  * @an_enable:          autoneg enable
  * @fec_type:           fec type (enum ionic_port_fec_type)
  * @pause_type:         pause type (enum ionic_port_pause_type)
@@ -1084,19 +1227,23 @@ union ionic_port_config {
 };
 
 /**
- * Port Status information
+ * struct ionic_port_status - Port Status information
  * @status:             link status (enum ionic_port_oper_status)
  * @id:                 port id
  * @speed:              link speed (in Mbps)
+ * @link_down_count:    number of times link went from up to down
+ * @fec_type:           fec type (enum ionic_port_fec_type)
  * @xcvr:               transceiver status
  */
 struct ionic_port_status {
        __le32 id;
        __le32 speed;
        u8     status;
-       u8     rsvd[51];
+       __le16 link_down_count;
+       u8     fec_type;
+       u8     rsvd[48];
        struct ionic_xcvr_status  xcvr;
-};
+} __rte_packed;
 
 /**
  * struct ionic_port_identify_cmd - Port identify command
@@ -1113,7 +1260,7 @@ struct ionic_port_identify_cmd {
 
 /**
  * struct ionic_port_identify_comp - Port identify command completion
- * @status: The status of the command (enum status_code)
+ * @status: Status of the command (enum ionic_status_code)
  * @ver:    Version of identify returned by device
  */
 struct ionic_port_identify_comp {
@@ -1138,7 +1285,7 @@ struct ionic_port_init_cmd {
 
 /**
  * struct ionic_port_init_comp - Port initialization command completion
- * @status: The status of the command (enum status_code)
+ * @status: Status of the command (enum ionic_status_code)
  */
 struct ionic_port_init_comp {
        u8 status;
@@ -1158,7 +1305,7 @@ struct ionic_port_reset_cmd {
 
 /**
  * struct ionic_port_reset_comp - Port reset command completion
- * @status: The status of the command (enum status_code)
+ * @status: Status of the command (enum ionic_status_code)
  */
 struct ionic_port_reset_comp {
        u8 status;
@@ -1166,15 +1313,23 @@ struct ionic_port_reset_comp {
 };
 
 /**
- * enum stats_ctl_cmd - List of commands for stats control
+ * enum ionic_stats_ctl_cmd - List of commands for stats control
+ * @IONIC_STATS_CTL_RESET:      Reset statistics
  */
 enum ionic_stats_ctl_cmd {
        IONIC_STATS_CTL_RESET           = 0,
 };
 
-
 /**
  * enum ionic_port_attr - List of device attributes
+ * @IONIC_PORT_ATTR_STATE:      Port state attribute
+ * @IONIC_PORT_ATTR_SPEED:      Port speed attribute
+ * @IONIC_PORT_ATTR_MTU:        Port MTU attribute
+ * @IONIC_PORT_ATTR_AUTONEG:    Port autonegotiation attribute
+ * @IONIC_PORT_ATTR_FEC:        Port FEC attribute
+ * @IONIC_PORT_ATTR_PAUSE:      Port pause attribute
+ * @IONIC_PORT_ATTR_LOOPBACK:   Port loopback attribute
+ * @IONIC_PORT_ATTR_STATS_CTRL: Port statistics control attribute
  */
 enum ionic_port_attr {
        IONIC_PORT_ATTR_STATE           = 0,
@@ -1189,9 +1344,17 @@ enum ionic_port_attr {
 
 /**
  * struct ionic_port_setattr_cmd - Set port attributes on the NIC
- * @opcode:     Opcode
- * @index:      port index
- * @attr:       Attribute type (enum ionic_port_attr)
+ * @opcode:         Opcode
+ * @index:          Port index
+ * @attr:           Attribute type (enum ionic_port_attr)
+ * @state:          Port state
+ * @speed:          Port speed
+ * @mtu:            Port MTU
+ * @an_enable:      Port autonegotiation setting
+ * @fec_type:       Port FEC type setting
+ * @pause_type:     Port pause type setting
+ * @loopback_mode:  Port loopback mode
+ * @stats_ctl:      Port stats setting
  */
 struct ionic_port_setattr_cmd {
        u8     opcode;
@@ -1206,14 +1369,14 @@ struct ionic_port_setattr_cmd {
                u8      fec_type;
                u8      pause_type;
                u8      loopback_mode;
-               u8      stats_ctl;
+               u8      stats_ctl;
                u8      rsvd2[60];
        };
 };
 
 /**
  * struct ionic_port_setattr_comp - Port set attr command completion
- * @status:     The status of the command (enum status_code)
+ * @status:     Status of the command (enum ionic_status_code)
  * @color:      Color bit
  */
 struct ionic_port_setattr_comp {
@@ -1237,8 +1400,15 @@ struct ionic_port_getattr_cmd {
 
 /**
  * struct ionic_port_getattr_comp - Port get attr command completion
- * @status:     The status of the command (enum status_code)
- * @color:      Color bit
+ * @status:         Status of the command (enum ionic_status_code)
+ * @state:          Port state
+ * @speed:          Port speed
+ * @mtu:            Port MTU
+ * @an_enable:      Port autonegotiation setting
+ * @fec_type:       Port FEC type setting
+ * @pause_type:     Port pause type setting
+ * @loopback_mode:  Port loopback mode
+ * @color:          Color bit
  */
 struct ionic_port_getattr_comp {
        u8     status;
@@ -1252,17 +1422,17 @@ struct ionic_port_getattr_comp {
                u8      pause_type;
                u8      loopback_mode;
                u8      rsvd2[11];
-       };
+       } __rte_packed;
        u8     color;
 };
 
 /**
- * struct ionic_lif_status - Lif status register
+ * struct ionic_lif_status - LIF status register
  * @eid:             most recent NotifyQ event id
- * @port_num:        port the lif is connected to
+ * @port_num:        port the LIF is connected to
  * @link_status:     port status (enum ionic_port_oper_status)
  * @link_speed:      speed of link in Mbps
- * @link_down_count: number of times link status changes
+ * @link_down_count: number of times link went from up to down
  */
 struct ionic_lif_status {
        __le64 eid;
@@ -1296,6 +1466,9 @@ enum ionic_dev_state {
 
 /**
  * enum ionic_dev_attr - List of device attributes
+ * @IONIC_DEV_ATTR_STATE:     Device state attribute
+ * @IONIC_DEV_ATTR_NAME:      Device name attribute
+ * @IONIC_DEV_ATTR_FEATURES:  Device feature attributes
  */
 enum ionic_dev_attr {
        IONIC_DEV_ATTR_STATE    = 0,
@@ -1320,12 +1493,12 @@ struct ionic_dev_setattr_cmd {
                char    name[IONIC_IFNAMSIZ];
                __le64  features;
                u8      rsvd2[60];
-       };
+       } __rte_packed;
 };
 
 /**
  * struct ionic_dev_setattr_comp - Device set attr command completion
- * @status:     The status of the command (enum status_code)
+ * @status:     Status of the command (enum ionic_status_code)
  * @features:   Device features
  * @color:      Color bit
  */
@@ -1335,7 +1508,7 @@ struct ionic_dev_setattr_comp {
        union {
                __le64  features;
                u8      rsvd2[11];
-       };
+       } __rte_packed;
        u8     color;
 };
 
@@ -1352,7 +1525,7 @@ struct ionic_dev_getattr_cmd {
 
 /**
  * struct ionic_dev_setattr_comp - Device set attr command completion
- * @status:     The status of the command (enum status_code)
+ * @status:     Status of the command (enum ionic_status_code)
  * @features:   Device features
  * @color:      Color bit
  */
@@ -1362,7 +1535,7 @@ struct ionic_dev_getattr_comp {
        union {
                __le64  features;
                u8      rsvd2[11];
-       };
+       } __rte_packed;
        u8     color;
 };
 
@@ -1382,6 +1555,13 @@ enum ionic_rss_hash_types {
 
 /**
  * enum ionic_lif_attr - List of LIF attributes
+ * @IONIC_LIF_ATTR_STATE:       LIF state attribute
+ * @IONIC_LIF_ATTR_NAME:        LIF name attribute
+ * @IONIC_LIF_ATTR_MTU:         LIF MTU attribute
+ * @IONIC_LIF_ATTR_MAC:         LIF MAC attribute
+ * @IONIC_LIF_ATTR_FEATURES:    LIF features attribute
+ * @IONIC_LIF_ATTR_RSS:         LIF RSS attribute
+ * @IONIC_LIF_ATTR_STATS_CTRL:  LIF statistics control attribute
  */
 enum ionic_lif_attr {
        IONIC_LIF_ATTR_STATE        = 0,
@@ -1396,18 +1576,18 @@ enum ionic_lif_attr {
 /**
  * struct ionic_lif_setattr_cmd - Set LIF attributes on the NIC
  * @opcode:     Opcode
- * @type:       Attribute type (enum ionic_lif_attr)
+ * @attr:       Attribute type (enum ionic_lif_attr)
  * @index:      LIF index
- * @state:      lif state (enum lif_state)
+ * @state:      LIF state (enum ionic_lif_state)
  * @name:       The netdev name string, 0 terminated
  * @mtu:        Mtu
  * @mac:        Station mac
  * @features:   Features (enum ionic_eth_hw_features)
  * @rss:        RSS properties
- *              @types:     The hash types to enable (see rss_hash_types).
- *              @key:       The hash secret key.
- *              @addr:      Address for the indirection table shared memory.
- * @stats_ctl:  stats control commands (enum stats_ctl_cmd)
+ *              @types:     The hash types to enable (see rss_hash_types)
+ *              @key:       The hash secret key
+ *              @addr:      Address for the indirection table shared memory
+ * @stats_ctl:  stats control commands (enum ionic_stats_ctl_cmd)
  */
 struct ionic_lif_setattr_cmd {
        u8     opcode;
@@ -1425,16 +1605,15 @@ struct ionic_lif_setattr_cmd {
                        u8     rsvd[6];
                        __le64 addr;
                } rss;
-               u8      stats_ctl;
+               u8      stats_ctl;
                u8      rsvd[60];
-       };
+       } __rte_packed;
 };
 
 /**
  * struct ionic_lif_setattr_comp - LIF set attr command completion
- * @status:     The status of the command (enum status_code)
- * @comp_index: The index in the descriptor ring for which this
- *              is the completion.
+ * @status:     Status of the command (enum ionic_status_code)
+ * @comp_index: Index in the descriptor ring for which this is the completion
  * @features:   features (enum ionic_eth_hw_features)
  * @color:      Color bit
  */
@@ -1445,7 +1624,7 @@ struct ionic_lif_setattr_comp {
        union {
                __le64  features;
                u8      rsvd2[11];
-       };
+       } __rte_packed;
        u8     color;
 };
 
@@ -1464,10 +1643,9 @@ struct ionic_lif_getattr_cmd {
 
 /**
  * struct ionic_lif_getattr_comp - LIF get attr command completion
- * @status:     The status of the command (enum status_code)
- * @comp_index: The index in the descriptor ring for which this
- *              is the completion.
- * @state:      lif state (enum lif_state)
+ * @status:     Status of the command (enum ionic_status_code)
+ * @comp_index: Index in the descriptor ring for which this is the completion
+ * @state:      LIF state (enum ionic_lif_state)
  * @name:       The netdev name string, 0 terminated
  * @mtu:        Mtu
  * @mac:        Station mac
@@ -1484,16 +1662,17 @@ struct ionic_lif_getattr_comp {
                u8      mac[6];
                __le64  features;
                u8      rsvd2[11];
-       };
+       } __rte_packed;
        u8     color;
 };
 
 enum ionic_rx_mode {
-       IONIC_RX_MODE_F_UNICAST    = BIT(0),
-       IONIC_RX_MODE_F_MULTICAST  = BIT(1),
-       IONIC_RX_MODE_F_BROADCAST  = BIT(2),
-       IONIC_RX_MODE_F_PROMISC    = BIT(3),
-       IONIC_RX_MODE_F_ALLMULTI   = BIT(4),
+       IONIC_RX_MODE_F_UNICAST         = BIT(0),
+       IONIC_RX_MODE_F_MULTICAST       = BIT(1),
+       IONIC_RX_MODE_F_BROADCAST       = BIT(2),
+       IONIC_RX_MODE_F_PROMISC         = BIT(3),
+       IONIC_RX_MODE_F_ALLMULTI        = BIT(4),
+       IONIC_RX_MODE_F_RDMA_SNIFFER    = BIT(5),
 };
 
 /**
@@ -1501,11 +1680,12 @@ enum ionic_rx_mode {
  * @opcode:     opcode
  * @lif_index:  LIF index
  * @rx_mode:    Rx mode flags:
- *                  IONIC_RX_MODE_F_UNICAST: Accept known unicast packets.
- *                  IONIC_RX_MODE_F_MULTICAST: Accept known multicast packets.
- *                  IONIC_RX_MODE_F_BROADCAST: Accept broadcast packets.
- *                  IONIC_RX_MODE_F_PROMISC: Accept any packets.
- *                  IONIC_RX_MODE_F_ALLMULTI: Accept any multicast packets.
+ *                  IONIC_RX_MODE_F_UNICAST: Accept known unicast packets
+ *                  IONIC_RX_MODE_F_MULTICAST: Accept known multicast packets
+ *                  IONIC_RX_MODE_F_BROADCAST: Accept broadcast packets
+ *                  IONIC_RX_MODE_F_PROMISC: Accept any packets
+ *                  IONIC_RX_MODE_F_ALLMULTI: Accept any multicast packets
+ *                  IONIC_RX_MODE_F_RDMA_SNIFFER: Sniff RDMA packets
  */
 struct ionic_rx_mode_set_cmd {
        u8     opcode;
@@ -1529,9 +1709,14 @@ enum ionic_rx_filter_match_type {
  * @qtype:      Queue type
  * @lif_index:  LIF index
  * @qid:        Queue ID
- * @match:      Rx filter match type.  (See IONIC_RX_FILTER_MATCH_xxx)
- * @vlan:       VLAN ID
- * @addr:       MAC address (network-byte order)
+ * @match:      Rx filter match type (see IONIC_RX_FILTER_MATCH_xxx)
+ * @vlan:       VLAN filter
+ *              @vlan:  VLAN ID
+ * @mac:        MAC filter
+ *              @addr:  MAC address (network-byte order)
+ * @mac_vlan:   MACVLAN filter
+ *              @vlan:  VLAN ID
+ *              @addr:  MAC address (network-byte order)
  */
 struct ionic_rx_filter_add_cmd {
        u8     opcode;
@@ -1556,11 +1741,10 @@ struct ionic_rx_filter_add_cmd {
 
 /**
  * struct ionic_rx_filter_add_comp - Add LIF Rx filter command completion
- * @status:     The status of the command (enum status_code)
- * @comp_index: The index in the descriptor ring for which this
- *              is the completion.
+ * @status:     Status of the command (enum ionic_status_code)
+ * @comp_index: Index in the descriptor ring for which this is the completion
  * @filter_id:  Filter ID
- * @color:      Color bit.
+ * @color:      Color bit
  */
 struct ionic_rx_filter_add_comp {
        u8     status;
@@ -1587,9 +1771,99 @@ struct ionic_rx_filter_del_cmd {
 
 typedef struct ionic_admin_comp ionic_rx_filter_del_comp;
 
+enum ionic_vf_attr {
+       IONIC_VF_ATTR_SPOOFCHK  = 1,
+       IONIC_VF_ATTR_TRUST     = 2,
+       IONIC_VF_ATTR_MAC       = 3,
+       IONIC_VF_ATTR_LINKSTATE = 4,
+       IONIC_VF_ATTR_VLAN      = 5,
+       IONIC_VF_ATTR_RATE      = 6,
+       IONIC_VF_ATTR_STATSADDR = 7,
+};
+
+/**
+ * enum ionic_vf_link_status - Virtual Function link status
+ * @IONIC_VF_LINK_STATUS_AUTO:   Use link state of the uplink
+ * @IONIC_VF_LINK_STATUS_UP:     Link always up
+ * @IONIC_VF_LINK_STATUS_DOWN:   Link always down
+ */
+enum ionic_vf_link_status {
+       IONIC_VF_LINK_STATUS_AUTO = 0,
+       IONIC_VF_LINK_STATUS_UP   = 1,
+       IONIC_VF_LINK_STATUS_DOWN = 2,
+};
+
+/**
+ * struct ionic_vf_setattr_cmd - Set VF attributes on the NIC
+ * @opcode:     Opcode
+ * @attr:       Attribute type (enum ionic_vf_attr)
+ * @vf_index:   VF index
+ *     @macaddr:       mac address
+ *     @vlanid:        vlan ID
+ *     @maxrate:       max Tx rate in Mbps
+ *     @spoofchk:      enable address spoof checking
+ *     @trust:         enable VF trust
+ *     @linkstate:     set link up or down
+ *     @stats_pa:      set DMA address for VF stats
+ */
+struct ionic_vf_setattr_cmd {
+       u8     opcode;
+       u8     attr;
+       __le16 vf_index;
+       union {
+               u8     macaddr[6];
+               __le16 vlanid;
+               __le32 maxrate;
+               u8     spoofchk;
+               u8     trust;
+               u8     linkstate;
+               __le64 stats_pa;
+               u8     pad[60];
+       } __rte_packed;
+};
+
+struct ionic_vf_setattr_comp {
+       u8     status;
+       u8     attr;
+       __le16 vf_index;
+       __le16 comp_index;
+       u8     rsvd[9];
+       u8     color;
+};
+
+/**
+ * struct ionic_vf_getattr_cmd - Get VF attributes from the NIC
+ * @opcode:     Opcode
+ * @attr:       Attribute type (enum ionic_vf_attr)
+ * @vf_index:   VF index
+ */
+struct ionic_vf_getattr_cmd {
+       u8     opcode;
+       u8     attr;
+       __le16 vf_index;
+       u8     rsvd[60];
+};
+
+struct ionic_vf_getattr_comp {
+       u8     status;
+       u8     attr;
+       __le16 vf_index;
+       union {
+               u8     macaddr[6];
+               __le16 vlanid;
+               __le32 maxrate;
+               u8     spoofchk;
+               u8     trust;
+               u8     linkstate;
+               __le64 stats_pa;
+               u8     pad[11];
+       } __rte_packed;
+       u8     color;
+};
+
 /**
  * struct ionic_qos_identify_cmd - QoS identify command
- * @opcode:    opcode
+ * @opcode:  opcode
  * @ver:     Highest version of identify supported by driver
  *
  */
@@ -1601,7 +1875,7 @@ struct ionic_qos_identify_cmd {
 
 /**
  * struct ionic_qos_identify_comp - QoS identify command completion
- * @status: The status of the command (enum status_code)
+ * @status: Status of the command (enum ionic_status_code)
  * @ver:    Version of identify returned by device
  */
 struct ionic_qos_identify_comp {
@@ -1610,9 +1884,15 @@ struct ionic_qos_identify_comp {
        u8 rsvd[14];
 };
 
+#define IONIC_QOS_TC_MAX               8
+#define IONIC_QOS_ALL_TC               0xFF
+/* Capri max supported, should be renamed. */
 #define IONIC_QOS_CLASS_MAX            7
-#define IONIC_QOS_CLASS_NAME_SZ                32
-#define IONIC_QOS_DSCP_MAX_VALUES      64
+#define IONIC_QOS_PCP_MAX              8
+#define IONIC_QOS_CLASS_NAME_SZ        32
+#define IONIC_QOS_DSCP_MAX             64
+#define IONIC_QOS_ALL_PCP              0xFF
+#define IONIC_DSCP_BLOCK_SIZE          8
 
 /**
  * enum ionic_qos_class
@@ -1629,42 +1909,44 @@ enum ionic_qos_class {
 
 /**
  * enum ionic_qos_class_type - Traffic classification criteria
+ * @IONIC_QOS_CLASS_TYPE_NONE:    No QoS
+ * @IONIC_QOS_CLASS_TYPE_PCP:     Dot1Q PCP
+ * @IONIC_QOS_CLASS_TYPE_DSCP:    IP DSCP
  */
 enum ionic_qos_class_type {
        IONIC_QOS_CLASS_TYPE_NONE       = 0,
-       IONIC_QOS_CLASS_TYPE_PCP        = 1,    /* Dot1Q pcp */
-       IONIC_QOS_CLASS_TYPE_DSCP       = 2,    /* IP dscp */
+       IONIC_QOS_CLASS_TYPE_PCP        = 1,
+       IONIC_QOS_CLASS_TYPE_DSCP       = 2,
 };
 
 /**
- * enum ionic_qos_sched_type - Qos class scheduling type
+ * enum ionic_qos_sched_type - QoS class scheduling type
+ * @IONIC_QOS_SCHED_TYPE_STRICT:  Strict priority
+ * @IONIC_QOS_SCHED_TYPE_DWRR:    Deficit weighted round-robin
  */
 enum ionic_qos_sched_type {
-       /* Strict priority */
        IONIC_QOS_SCHED_TYPE_STRICT     = 0,
-       /* Deficit weighted round-robin */
        IONIC_QOS_SCHED_TYPE_DWRR       = 1,
 };
 
 /**
- * union ionic_qos_config - Qos configuration structure
+ * union ionic_qos_config - QoS configuration structure
  * @flags:             Configuration flags
  *     IONIC_QOS_CONFIG_F_ENABLE               enable
- *     IONIC_QOS_CONFIG_F_DROP                 drop/nodrop
+ *     IONIC_QOS_CONFIG_F_NO_DROP              drop/nodrop
  *     IONIC_QOS_CONFIG_F_RW_DOT1Q_PCP         enable dot1q pcp rewrite
  *     IONIC_QOS_CONFIG_F_RW_IP_DSCP           enable ip dscp rewrite
- * @sched_type:                Qos class scheduling type (enum ionic_qos_sched_type)
- * @class_type:                Qos class type (enum ionic_qos_class_type)
- * @pause_type:                Qos pause type (enum qos_pause_type)
- * @name:              Qos class name
+ *     IONIC_QOS_CONFIG_F_NON_DISRUPTIVE       Non-disruptive TC update
+ * @sched_type:                QoS class scheduling type (enum ionic_qos_sched_type)
+ * @class_type:                QoS class type (enum ionic_qos_class_type)
+ * @pause_type:                QoS pause type (enum ionic_qos_pause_type)
+ * @name:              QoS class name
  * @mtu:               MTU of the class
- * @pfc_dot1q_pcp:     Pcp value for pause frames (valid iff F_NODROP)
- * @dwrr_weight:       Qos class scheduling weight
+ * @pfc_cos:           Priority-Flow Control class of service
+ * @dwrr_weight:       QoS class scheduling weight
  * @strict_rlmt:       Rate limit for strict priority scheduling
- * @rw_dot1q_pcp:      Rewrite dot1q pcp to this value
- *                     (valid iff F_RW_DOT1Q_PCP)
- * @rw_ip_dscp:                Rewrite ip dscp to this value
- *                     (valid iff F_RW_IP_DSCP)
+ * @rw_dot1q_pcp:      Rewrite dot1q pcp to value (valid iff F_RW_DOT1Q_PCP)
+ * @rw_ip_dscp:                Rewrite ip dscp to value (valid iff F_RW_IP_DSCP)
  * @dot1q_pcp:         Dot1q pcp value
  * @ndscp:             Number of valid dscp values in the ip_dscp field
  * @ip_dscp:           IP dscp values
@@ -1672,9 +1954,12 @@ enum ionic_qos_sched_type {
 union ionic_qos_config {
        struct {
 #define IONIC_QOS_CONFIG_F_ENABLE              BIT(0)
-#define IONIC_QOS_CONFIG_F_DROP                        BIT(1)
+#define IONIC_QOS_CONFIG_F_NO_DROP             BIT(1)
+/* Used to rewrite PCP or DSCP value. */
 #define IONIC_QOS_CONFIG_F_RW_DOT1Q_PCP                BIT(2)
 #define IONIC_QOS_CONFIG_F_RW_IP_DSCP          BIT(3)
+/* Non-disruptive TC update */
+#define IONIC_QOS_CONFIG_F_NON_DISRUPTIVE      BIT(4)
                u8      flags;
                u8      sched_type;
                u8      class_type;
@@ -1689,6 +1974,7 @@ union ionic_qos_config {
                        __le64  strict_rlmt;
                };
                /* marking */
+               /* Used to rewrite PCP or DSCP value. */
                union {
                        u8      rw_dot1q_pcp;
                        u8      rw_ip_dscp;
@@ -1698,10 +1984,10 @@ union ionic_qos_config {
                        u8      dot1q_pcp;
                        struct {
                                u8      ndscp;
-                               u8      ip_dscp[IONIC_QOS_DSCP_MAX_VALUES];
+                               u8      ip_dscp[IONIC_QOS_DSCP_MAX];
                        };
                };
-       };
+       } __rte_packed;
        __le32  words[64];
 };
 
@@ -1717,15 +2003,15 @@ union ionic_qos_identity {
                u8     version;
                u8     type;
                u8     rsvd[62];
-               union  ionic_qos_config config[IONIC_QOS_CLASS_MAX];
+               union ionic_qos_config config[IONIC_QOS_CLASS_MAX];
        };
-       __le32 words[512];
+       __le32 words[478];
 };
 
 /**
- * struct qos_init_cmd - QoS config init command
+ * struct ionic_qos_init_cmd - QoS config init command
  * @opcode:    Opcode
- * @group:     Qos class id
+ * @group:     QoS class id
  * @info_pa:   destination address for qos info
  */
 struct ionic_qos_init_cmd {
@@ -1739,8 +2025,9 @@ struct ionic_qos_init_cmd {
 typedef struct ionic_admin_comp ionic_qos_init_comp;
 
 /**
- * struct ionic_qos_reset_cmd - Qos config reset command
+ * struct ionic_qos_reset_cmd - QoS config reset command
  * @opcode:    Opcode
+ * @group:     QoS class id
  */
 struct ionic_qos_reset_cmd {
        u8    opcode;
@@ -1748,6 +2035,16 @@ struct ionic_qos_reset_cmd {
        u8    rsvd[62];
 };
 
+/**
+ * struct ionic_qos_clear_port_stats_cmd - Qos config reset command
+ * @opcode:    Opcode
+ */
+struct ionic_qos_clear_stats_cmd {
+       u8    opcode;
+       u8    group_bitmap;
+       u8    rsvd[62];
+};
+
 typedef struct ionic_admin_comp ionic_qos_reset_comp;
 
 /**
@@ -1767,10 +2064,16 @@ struct ionic_fw_download_cmd {
 
 typedef struct ionic_admin_comp ionic_fw_download_comp;
 
+/**
+ * enum ionic_fw_control_oper - FW control operations
+ * @IONIC_FW_RESET:     Reset firmware
+ * @IONIC_FW_INSTALL:   Install firmware
+ * @IONIC_FW_ACTIVATE:  Acticate firmware
+ */
 enum ionic_fw_control_oper {
-       IONIC_FW_RESET          = 0,    /* Reset firmware */
-       IONIC_FW_INSTALL        = 1,    /* Install firmware */
-       IONIC_FW_ACTIVATE       = 2,    /* Activate firmware */
+       IONIC_FW_RESET          = 0,
+       IONIC_FW_INSTALL        = 1,
+       IONIC_FW_ACTIVATE       = 2,
 };
 
 /**
@@ -1789,8 +2092,10 @@ struct ionic_fw_control_cmd {
 
 /**
  * struct ionic_fw_control_comp - Firmware control copletion
- * @opcode:    opcode
- * @slot:      slot where the firmware was installed
+ * @status:     Status of the command (enum ionic_status_code)
+ * @comp_index: Index in the descriptor ring for which this is the completion
+ * @slot:       Slot where the firmware was installed
+ * @color:      Color bit
  */
 struct ionic_fw_control_comp {
        u8     status;
@@ -1808,11 +2113,11 @@ struct ionic_fw_control_comp {
 /**
  * struct ionic_rdma_reset_cmd - Reset RDMA LIF cmd
  * @opcode:        opcode
- * @lif_index:     lif index
+ * @lif_index:     LIF index
  *
- * There is no rdma specific dev command completion struct.  Completion uses
+ * There is no RDMA specific dev command completion struct.  Completion uses
  * the common struct ionic_admin_comp.  Only the status is indicated.
- * Nonzero status means the LIF does not support rdma.
+ * Nonzero status means the LIF does not support RDMA.
  **/
 struct ionic_rdma_reset_cmd {
        u8     opcode;
@@ -1824,30 +2129,29 @@ struct ionic_rdma_reset_cmd {
 /**
  * struct ionic_rdma_queue_cmd - Create RDMA Queue command
  * @opcode:        opcode, 52, 53
- * @lif_index      lif index
- * @qid_ver:       (qid | (rdma version << 24))
+ * @lif_index:     LIF index
+ * @qid_ver:       (qid | (RDMA version << 24))
  * @cid:           intr, eq_id, or cq_id
  * @dbid:          doorbell page id
  * @depth_log2:    log base two of queue depth
  * @stride_log2:   log base two of queue stride
  * @dma_addr:      address of the queue memory
- * @xxx_table_index: temporary, but should not need pgtbl for contig. queues.
  *
- * The same command struct is used to create an rdma event queue, completion
- * queue, or rdma admin queue.  The cid is an interrupt number for an event
+ * The same command struct is used to create an RDMA event queue, completion
+ * queue, or RDMA admin queue.  The cid is an interrupt number for an event
  * queue, an event queue id for a completion queue, or a completion queue id
- * for an rdma admin queue.
+ * for an RDMA admin queue.
  *
  * The queue created via a dev command must be contiguous in dma space.
  *
  * The dev commands are intended only to be used during driver initialization,
- * to create queues supporting the rdma admin queue.  Other queues, and other
- * types of rdma resources like memory regions, will be created and registered
- * via the rdma admin queue, and will support a more complete interface
+ * to create queues supporting the RDMA admin queue.  Other queues, and other
+ * types of RDMA resources like memory regions, will be created and registered
+ * via the RDMA admin queue, and will support a more complete interface
  * providing scatter gather lists for larger, scattered queue buffers and
  * memory registration.
  *
- * There is no rdma specific dev command completion struct.  Completion uses
+ * There is no RDMA specific dev command completion struct.  Completion uses
  * the common struct ionic_admin_comp.  Only the status is indicated.
  **/
 struct ionic_rdma_queue_cmd {
@@ -1860,8 +2164,7 @@ struct ionic_rdma_queue_cmd {
        u8     depth_log2;
        u8     stride_log2;
        __le64 dma_addr;
-       u8     rsvd2[36];
-       __le32 xxx_table_index;
+       u8     rsvd2[40];
 };
 
 /******************************************************************
@@ -1869,7 +2172,7 @@ struct ionic_rdma_queue_cmd {
  ******************************************************************/
 
 /**
- * struct ionic_notifyq_event
+ * struct ionic_notifyq_event - Generic event reporting structure
  * @eid:   event number
  * @ecode: event code
  * @data:  unspecified data about the event
@@ -1884,10 +2187,10 @@ struct ionic_notifyq_event {
 };
 
 /**
- * struct ionic_link_change_event
+ * struct ionic_link_change_event - Link change event notification
  * @eid:               event number
- * @ecode:             event code = EVENT_OPCODE_LINK_CHANGE
- * @link_status:       link up or down, with error bits (enum port_status)
+ * @ecode:             event code = IONIC_EVENT_LINK_CHANGE
+ * @link_status:       link up/down, with error bits (enum ionic_port_status)
  * @link_speed:                speed of the network link
  *
  * Sent when the network link state changes between UP and DOWN
@@ -1901,9 +2204,9 @@ struct ionic_link_change_event {
 };
 
 /**
- * struct ionic_reset_event
+ * struct ionic_reset_event - Reset event notification
  * @eid:               event number
- * @ecode:             event code = EVENT_OPCODE_RESET
+ * @ecode:             event code = IONIC_EVENT_RESET
  * @reset_code:                reset type
  * @state:             0=pending, 1=complete, 2=error
  *
@@ -1919,11 +2222,9 @@ struct ionic_reset_event {
 };
 
 /**
- * struct ionic_heartbeat_event
+ * struct ionic_heartbeat_event - Sent periodically by NIC to indicate health
  * @eid:       event number
- * @ecode:     event code = EVENT_OPCODE_HEARTBEAT
- *
- * Sent periodically by the NIC to indicate continued health
+ * @ecode:     event code = IONIC_EVENT_HEARTBEAT
  */
 struct ionic_heartbeat_event {
        __le64 eid;
@@ -1932,12 +2233,10 @@ struct ionic_heartbeat_event {
 };
 
 /**
- * struct ionic_log_event
+ * struct ionic_log_event - Sent to notify the driver of an internal error
  * @eid:       event number
- * @ecode:     event code = EVENT_OPCODE_LOG
+ * @ecode:     event code = IONIC_EVENT_LOG
  * @data:      log data
- *
- * Sent to notify the driver of an internal error.
  */
 struct ionic_log_event {
        __le64 eid;
@@ -1946,7 +2245,18 @@ struct ionic_log_event {
 };
 
 /**
- * struct ionic_port_stats
+ * struct ionic_xcvr_event - Transceiver change event
+ * @eid:       event number
+ * @ecode:     event code = IONIC_EVENT_XCVR
+ */
+struct ionic_xcvr_event {
+       __le64 eid;
+       __le16 ecode;
+       u8     rsvd[54];
+};
+
+/**
+ * struct ionic_port_stats - Port statistics structure
  */
 struct ionic_port_stats {
        __le64 frames_rx_ok;
@@ -2051,34 +2361,109 @@ struct ionic_mgmt_port_stats {
        __le64 frames_rx_multicast;
        __le64 frames_rx_broadcast;
        __le64 frames_rx_pause;
-       __le64 frames_rx_bad_length0;
-       __le64 frames_rx_undersized1;
-       __le64 frames_rx_oversized2;
-       __le64 frames_rx_fragments3;
-       __le64 frames_rx_jabber4;
-       __le64 frames_rx_64b5;
-       __le64 frames_rx_65b_127b6;
-       __le64 frames_rx_128b_255b7;
-       __le64 frames_rx_256b_511b8;
-       __le64 frames_rx_512b_1023b9;
-       __le64 frames_rx_1024b_1518b0;
-       __le64 frames_rx_gt_1518b1;
-       __le64 frames_rx_fifo_full2;
-       __le64 frames_tx_ok3;
-       __le64 frames_tx_all4;
-       __le64 frames_tx_bad5;
-       __le64 octets_tx_ok6;
-       __le64 octets_tx_total7;
-       __le64 frames_tx_unicast8;
-       __le64 frames_tx_multicast9;
-       __le64 frames_tx_broadcast0;
-       __le64 frames_tx_pause1;
+       __le64 frames_rx_bad_length;
+       __le64 frames_rx_undersized;
+       __le64 frames_rx_oversized;
+       __le64 frames_rx_fragments;
+       __le64 frames_rx_jabber;
+       __le64 frames_rx_64b;
+       __le64 frames_rx_65b_127b;
+       __le64 frames_rx_128b_255b;
+       __le64 frames_rx_256b_511b;
+       __le64 frames_rx_512b_1023b;
+       __le64 frames_rx_1024b_1518b;
+       __le64 frames_rx_gt_1518b;
+       __le64 frames_rx_fifo_full;
+       __le64 frames_tx_ok;
+       __le64 frames_tx_all;
+       __le64 frames_tx_bad;
+       __le64 octets_tx_ok;
+       __le64 octets_tx_total;
+       __le64 frames_tx_unicast;
+       __le64 frames_tx_multicast;
+       __le64 frames_tx_broadcast;
+       __le64 frames_tx_pause;
+};
+
+enum ionic_pb_buffer_drop_stats {
+       IONIC_BUFFER_INTRINSIC_DROP = 0,
+       IONIC_BUFFER_DISCARDED,
+       IONIC_BUFFER_ADMITTED,
+       IONIC_BUFFER_OUT_OF_CELLS_DROP,
+       IONIC_BUFFER_OUT_OF_CELLS_DROP_2,
+       IONIC_BUFFER_OUT_OF_CREDIT_DROP,
+       IONIC_BUFFER_TRUNCATION_DROP,
+       IONIC_BUFFER_PORT_DISABLED_DROP,
+       IONIC_BUFFER_COPY_TO_CPU_TAIL_DROP,
+       IONIC_BUFFER_SPAN_TAIL_DROP,
+       IONIC_BUFFER_MIN_SIZE_VIOLATION_DROP,
+       IONIC_BUFFER_ENQUEUE_ERROR_DROP,
+       IONIC_BUFFER_INVALID_PORT_DROP,
+       IONIC_BUFFER_INVALID_OUTPUT_QUEUE_DROP,
+       IONIC_BUFFER_DROP_MAX,
+};
+
+enum ionic_oflow_drop_stats {
+       IONIC_OFLOW_OCCUPANCY_DROP,
+       IONIC_OFLOW_EMERGENCY_STOP_DROP,
+       IONIC_OFLOW_WRITE_BUFFER_ACK_FILL_UP_DROP,
+       IONIC_OFLOW_WRITE_BUFFER_ACK_FULL_DROP,
+       IONIC_OFLOW_WRITE_BUFFER_FULL_DROP,
+       IONIC_OFLOW_CONTROL_FIFO_FULL_DROP,
+       IONIC_OFLOW_DROP_MAX,
+};
+
+/**
+ * struct port_pb_stats - packet buffers system stats
+ * uses ionic_pb_buffer_drop_stats for drop_counts[]
+ */
+struct ionic_port_pb_stats {
+       __le64 sop_count_in;
+       __le64 eop_count_in;
+       __le64 sop_count_out;
+       __le64 eop_count_out;
+       __le64 drop_counts[IONIC_BUFFER_DROP_MAX];
+       __le64 input_queue_buffer_occupancy[IONIC_QOS_TC_MAX];
+       __le64 input_queue_port_monitor[IONIC_QOS_TC_MAX];
+       __le64 output_queue_port_monitor[IONIC_QOS_TC_MAX];
+       __le64 oflow_drop_counts[IONIC_OFLOW_DROP_MAX];
+       __le64 input_queue_good_pkts_in[IONIC_QOS_TC_MAX];
+       __le64 input_queue_good_pkts_out[IONIC_QOS_TC_MAX];
+       __le64 input_queue_err_pkts_in[IONIC_QOS_TC_MAX];
+       __le64 input_queue_fifo_depth[IONIC_QOS_TC_MAX];
+       __le64 input_queue_max_fifo_depth[IONIC_QOS_TC_MAX];
+       __le64 input_queue_peak_occupancy[IONIC_QOS_TC_MAX];
+       __le64 output_queue_buffer_occupancy[IONIC_QOS_TC_MAX];
+};
+
+/**
+ * enum ionic_port_type - Port types
+ * @IONIC_ETH_UNKNOWN:             Port type not configured
+ * @IONIC_ETH_HOST:                Port carries ethernet traffic (inband)
+ * @IONIC_ETH_HOST_MGMT:           Port carries mgmt traffic (out-of-band)
+ * @IONIC_ETH_MNIC_OOB_MGMT:
+ * @IONIC_ETH_MNIC_INTERNAL_MGMT:
+ * @IONIC_ETH_MNIC_INBAND_MGMT:
+ * @IONIC_ETH_MNIC_CPU:
+ * @IONIC_ETH_MNIC_LEARN:
+ * @IONIC_ETH_MNIC_CONTROL:
+ */
+enum ionic_port_type {
+       IONIC_ETH_UNKNOWN,
+       IONIC_ETH_HOST,
+       IONIC_ETH_HOST_MGMT,
+       IONIC_ETH_MNIC_OOB_MGMT,
+       IONIC_ETH_MNIC_INTERNAL_MGMT,
+       IONIC_ETH_MNIC_INBAND_MGMT,
+       IONIC_ETH_MNIC_CPU,
+       IONIC_ETH_MNIC_LEARN,
+       IONIC_ETH_MNIC_CONTROL,
 };
 
 /**
  * struct ionic_port_identity - port identity structure
  * @version:        identity structure version
- * @type:           type of port (enum port_type)
+ * @type:           type of port (enum ionic_port_type)
  * @num_lanes:      number of lanes for the port
  * @autoneg:        autoneg supported
  * @min_frame_size: minimum frame size supported
@@ -2104,22 +2489,31 @@ union ionic_port_identity {
                u8     rsvd2[44];
                union ionic_port_config config;
        };
-       __le32 words[512];
+       __le32 words[478];
 };
 
 /**
  * struct ionic_port_info - port info structure
- * @port_status:     port status
- * @port_stats:      port stats
+ * @config:          Port configuration data
+ * @status:          Port status data
+ * @stats:           Port statistics data
+ * @mgmt_stats:      Port management statistics data
+ * @port_pb_drop_stats:   uplink pb drop stats
  */
 struct ionic_port_info {
        union ionic_port_config config;
        struct ionic_port_status status;
-       struct ionic_port_stats stats;
+       union {
+               struct ionic_port_stats      stats;
+               struct ionic_mgmt_port_stats mgmt_stats;
+       };
+       /* room for pb_stats to start at 2k offset */
+       u8                          rsvd[760];
+       struct ionic_port_pb_stats  pb_stats;
 };
 
 /**
- * struct ionic_lif_stats
+ * struct ionic_lif_stats - LIF statistics structure
  */
 struct ionic_lif_stats {
        /* RX */
@@ -2172,7 +2566,7 @@ struct ionic_lif_stats {
        __le64 tx_queue_error;
        __le64 tx_desc_fetch_error;
        __le64 tx_desc_data_error;
-       __le64 rsvd9;
+       __le64 tx_queue_empty;
        __le64 rsvd10;
        __le64 rsvd11;
        __le64 rsvd12;
@@ -2273,7 +2667,10 @@ struct ionic_lif_stats {
 };
 
 /**
- * struct ionic_lif_info - lif info structure
+ * struct ionic_lif_info - LIF info structure
+ * @config:    LIF configuration structure
+ * @status:    LIF status structure
+ * @stats:     LIF statistics structure
  */
 struct ionic_lif_info {
        union ionic_lif_config config;
@@ -2298,6 +2695,9 @@ union ionic_dev_cmd {
        struct ionic_port_getattr_cmd port_getattr;
        struct ionic_port_setattr_cmd port_setattr;
 
+       struct ionic_vf_setattr_cmd vf_setattr;
+       struct ionic_vf_getattr_cmd vf_getattr;
+
        struct ionic_lif_identify_cmd lif_identify;
        struct ionic_lif_init_cmd lif_init;
        struct ionic_lif_reset_cmd lif_reset;
@@ -2305,8 +2705,11 @@ union ionic_dev_cmd {
        struct ionic_qos_identify_cmd qos_identify;
        struct ionic_qos_init_cmd qos_init;
        struct ionic_qos_reset_cmd qos_reset;
+       struct ionic_qos_clear_stats_cmd qos_clear_stats;
 
+       struct ionic_q_identify_cmd q_identify;
        struct ionic_q_init_cmd q_init;
+       struct ionic_q_control_cmd q_control;
 };
 
 union ionic_dev_cmd_comp {
@@ -2327,6 +2730,9 @@ union ionic_dev_cmd_comp {
        struct ionic_port_getattr_comp port_getattr;
        struct ionic_port_setattr_comp port_setattr;
 
+       struct ionic_vf_setattr_comp vf_setattr;
+       struct ionic_vf_getattr_comp vf_getattr;
+
        struct ionic_lif_identify_comp lif_identify;
        struct ionic_lif_init_comp lif_init;
        ionic_lif_reset_comp lif_reset;
@@ -2335,19 +2741,20 @@ union ionic_dev_cmd_comp {
        ionic_qos_init_comp qos_init;
        ionic_qos_reset_comp qos_reset;
 
+       struct ionic_q_identify_comp q_identify;
        struct ionic_q_init_comp q_init;
 };
 
 /**
- * union dev_info - Device info register format (read-only)
- * @signature:       Signature value of 0x44455649 ('DEVI').
- * @version:         Current version of info.
- * @asic_type:       Asic type.
- * @asic_rev:        Asic revision.
- * @fw_status:       Firmware status.
- * @fw_heartbeat:    Firmware heartbeat counter.
- * @serial_num:      Serial number.
- * @fw_version:      Firmware version.
+ * union ionic_dev_info_regs - Device info register format (read-only)
+ * @signature:       Signature value of 0x44455649 ('DEVI')
+ * @version:         Current version of info
+ * @asic_type:       Asic type
+ * @asic_rev:        Asic revision
+ * @fw_status:       Firmware status
+ * @fw_heartbeat:    Firmware heartbeat counter
+ * @serial_num:      Serial number
+ * @fw_version:      Firmware version
  */
 union ionic_dev_info_regs {
 #define IONIC_DEVINFO_FWVERS_BUFLEN 32
@@ -2357,6 +2764,7 @@ union ionic_dev_info_regs {
                u8     version;
                u8     asic_type;
                u8     asic_rev;
+#define IONIC_FW_STS_F_RUNNING 0x1
                u8     fw_status;
                u32    fw_heartbeat;
                char   fw_version[IONIC_DEVINFO_FWVERS_BUFLEN];
@@ -2367,10 +2775,10 @@ union ionic_dev_info_regs {
 
 /**
  * union ionic_dev_cmd_regs - Device command register format (read-write)
- * @doorbell:        Device Cmd Doorbell, write-only.
+ * @doorbell:        Device Cmd Doorbell, write-only
  *                   Write a 1 to signal device to process cmd,
  *                   poll done for completion.
- * @done:            Done indicator, bit 0 == 1 when command is complete.
+ * @done:            Done indicator, bit 0 == 1 when command is complete
  * @cmd:             Opcode-specific command bytes
  * @comp:            Opcode-specific response bytes
  * @data:            Opcode-specific side-data
@@ -2383,12 +2791,12 @@ union ionic_dev_cmd_regs {
                union ionic_dev_cmd_comp    comp;
                u8                    rsvd[48];
                u32                   data[478];
-       };
+       } __rte_packed;
        u32 words[512];
 };
 
 /**
- * union ionic_dev_regs - Device register format in for bar 0 page 0
+ * union ionic_dev_regs - Device register format for bar 0 page 0
  * @info:            Device info registers
  * @devcmd:          Device command registers
  */
@@ -2396,13 +2804,14 @@ union ionic_dev_regs {
        struct {
                union ionic_dev_info_regs info;
                union ionic_dev_cmd_regs  devcmd;
-       };
+       } __rte_packed;
        __le32 words[1024];
 };
 
 union ionic_adminq_cmd {
        struct ionic_admin_cmd cmd;
        struct ionic_nop_cmd nop;
+       struct ionic_q_identify_cmd q_identify;
        struct ionic_q_init_cmd q_init;
        struct ionic_q_control_cmd q_control;
        struct ionic_lif_setattr_cmd lif_setattr;
@@ -2419,6 +2828,7 @@ union ionic_adminq_cmd {
 union ionic_adminq_comp {
        struct ionic_admin_comp comp;
        struct ionic_nop_comp nop;
+       struct ionic_q_identify_comp q_identify;
        struct ionic_q_init_comp q_init;
        struct ionic_lif_setattr_comp lif_setattr;
        struct ionic_lif_getattr_comp lif_getattr;
@@ -2444,14 +2854,14 @@ union ionic_adminq_comp {
 /**
  * struct ionic_doorbell - Doorbell register layout
  * @p_index: Producer index
- * @ring:    Selects the specific ring of the queue to update.
+ * @ring:    Selects the specific ring of the queue to update
  *           Type-specific meaning:
- *              ring=0: Default producer/consumer queue.
+ *              ring=0: Default producer/consumer queue
  *              ring=1: (CQ, EQ) Re-Arm queue.  RDMA CQs
  *              send events to EQs when armed.  EQs send
  *              interrupts when armed.
- * @qid:     The queue id selects the queue destination for the
- *           producer index and flags.
+ * @qid_lo:  Queue destination for the producer index and flags (low bits)
+ * @qid_hi:  Queue destination for the producer index and flags (high bits)
  */
 struct ionic_doorbell {
        __le16 p_index;
@@ -2461,6 +2871,92 @@ struct ionic_doorbell {
        u16    rsvd2;
 };
 
+/**
+ * struct ionic_intr_ctrl - Interrupt control register
+ * @coalescing_init:  Coalescing timer initial value, in
+ *                    device units.  Use @identity->intr_coal_mult
+ *                    and @identity->intr_coal_div to convert from
+ *                    usecs to device units:
+ *
+ *                      coal_init = coal_usecs * coal_mutl / coal_div
+ *
+ *                    When an interrupt is sent the interrupt
+ *                    coalescing timer current value
+ *                    (@coalescing_curr) is initialized with this
+ *                    value and begins counting down.  No more
+ *                    interrupts are sent until the coalescing
+ *                    timer reaches 0.  When @coalescing_init=0
+ *                    interrupt coalescing is effectively disabled
+ *                    and every interrupt assert results in an
+ *                    interrupt.  Reset value: 0
+ * @mask:             Interrupt mask.  When @mask=1 the interrupt
+ *                    resource will not send an interrupt.  When
+ *                    @mask=0 the interrupt resource will send an
+ *                    interrupt if an interrupt event is pending
+ *                    or on the next interrupt assertion event.
+ *                    Reset value: 1
+ * @int_credits:      Interrupt credits.  This register indicates
+ *                    how many interrupt events the hardware has
+ *                    sent.  When written by software this
+ *                    register atomically decrements @int_credits
+ *                    by the value written.  When @int_credits
+ *                    becomes 0 then the "pending interrupt" bit
+ *                    in the Interrupt Status register is cleared
+ *                    by the hardware and any pending but unsent
+ *                    interrupts are cleared.
+ *                    !!!IMPORTANT!!! This is a signed register.
+ * @flags:            Interrupt control flags
+ *                       @unmask -- When this bit is written with a 1
+ *                       the interrupt resource will set mask=0.
+ *                       @coal_timer_reset -- When this
+ *                       bit is written with a 1 the
+ *                       @coalescing_curr will be reloaded with
+ *                       @coalescing_init to reset the coalescing
+ *                       timer.
+ * @mask_on_assert:   Automatically mask on assertion.  When
+ *                    @mask_on_assert=1 the interrupt resource
+ *                    will set @mask=1 whenever an interrupt is
+ *                    sent.  When using interrupts in Legacy
+ *                    Interrupt mode the driver must select
+ *                    @mask_on_assert=0 for proper interrupt
+ *                    operation.
+ * @coalescing_curr:  Coalescing timer current value, in
+ *                    microseconds.  When this value reaches 0
+ *                    the interrupt resource is again eligible to
+ *                    send an interrupt.  If an interrupt event
+ *                    is already pending when @coalescing_curr
+ *                    reaches 0 the pending interrupt will be
+ *                    sent, otherwise an interrupt will be sent
+ *                    on the next interrupt assertion event.
+ */
+struct ionic_intr_ctrl {
+       u8 coalescing_init;
+       u8 rsvd[3];
+       u8 mask;
+       u8 rsvd2[3];
+       u16 int_credits;
+       u16 flags;
+#define INTR_F_UNMASK          0x0001
+#define INTR_F_TIMER_RESET     0x0002
+       u8 mask_on_assert;
+       u8 rsvd3[3];
+       u8 coalescing_curr;
+       u8 rsvd4[3];
+       u32 rsvd6[3];
+};
+
+#define IONIC_INTR_CTRL_REGS_MAX       2048
+#define IONIC_INTR_CTRL_COAL_MAX       0x3F
+
+#define intr_to_coal(intr_ctrl)                \
+               ((void __iomem *)&(intr_ctrl)->coalescing_init)
+#define intr_to_mask(intr_ctrl)                \
+               ((void __iomem *)&(intr_ctrl)->mask)
+#define intr_to_credits(intr_ctrl)     \
+               ((void __iomem *)&(intr_ctrl)->int_credits)
+#define intr_to_mask_on_assert(intr_ctrl)\
+               ((void __iomem *)&(intr_ctrl)->mask_on_assert)
+
 struct ionic_intr_status {
        u32 status[2];
 };
@@ -2477,6 +2973,28 @@ union ionic_notifyq_comp {
        struct ionic_log_event log;
 };
 
+/**
+ * struct ionic_eq_comp - Event queue completion descriptor
+ *
+ * @code:      Event code, see enum ionic_eq_comp_code
+ * @lif_index: To which LIF the event pertains
+ * @qid:       To which queue id the event pertains
+ * @gen_color: Event queue wrap counter, init 1, incr each wrap
+ */
+struct ionic_eq_comp {
+       __le16 code;
+       __le16 lif_index;
+       __le32 qid;
+       u8 rsvd[7];
+       u8 gen_color;
+};
+
+enum ionic_eq_comp_code {
+       IONIC_EQ_COMP_CODE_NONE = 0,
+       IONIC_EQ_COMP_CODE_RX_COMP = 1,
+       IONIC_EQ_COMP_CODE_TX_COMP = 2,
+};
+
 /* Deprecate */
 struct ionic_identity {
        union ionic_drv_identity drv;
@@ -2484,8 +3002,7 @@ struct ionic_identity {
        union ionic_lif_identity lif;
        union ionic_port_identity port;
        union ionic_qos_identity qos;
+       union ionic_q_identity txq;
 };
 
-#pragma pack(pop)
-
 #endif /* _IONIC_IF_H_ */