net/pfe: fix double free of MAC address
[dpdk.git] / drivers / net / ionic / ionic_lif.c
index c831519..60a5f3d 100644 (file)
@@ -9,6 +9,11 @@
 #include "ionic_logs.h"
 #include "ionic_lif.h"
 #include "ionic_ethdev.h"
+#include "ionic_rx_filter.h"
+#include "ionic_rxtx.h"
+
+static int ionic_lif_addr_add(struct ionic_lif *lif, const uint8_t *addr);
+static int ionic_lif_addr_del(struct ionic_lif *lif, const uint8_t *addr);
 
 int
 ionic_qcq_enable(struct ionic_qcq *qcq)
@@ -60,6 +65,482 @@ ionic_qcq_disable(struct ionic_qcq *qcq)
        return ionic_adminq_post_wait(lif, &ctx);
 }
 
+int
+ionic_lif_stop(struct ionic_lif *lif __rte_unused)
+{
+       /* Carrier OFF here */
+
+       return 0;
+}
+
+void
+ionic_lif_reset(struct ionic_lif *lif)
+{
+       struct ionic_dev *idev = &lif->adapter->idev;
+
+       IONIC_PRINT_CALL();
+
+       ionic_dev_cmd_lif_reset(idev, lif->index);
+       ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);
+}
+
+static void
+ionic_lif_get_abs_stats(const struct ionic_lif *lif, struct rte_eth_stats *stats)
+{
+       struct ionic_lif_stats *ls = &lif->info->stats;
+       uint32_t i;
+       uint32_t num_rx_q_counters = RTE_MIN(lif->nrxqcqs, (uint32_t)
+                       RTE_ETHDEV_QUEUE_STAT_CNTRS);
+       uint32_t num_tx_q_counters = RTE_MIN(lif->ntxqcqs, (uint32_t)
+                       RTE_ETHDEV_QUEUE_STAT_CNTRS);
+
+       memset(stats, 0, sizeof(*stats));
+
+       if (ls == NULL) {
+               IONIC_PRINT(DEBUG, "Stats on port %u not yet initialized",
+                       lif->port_id);
+               return;
+       }
+
+       /* RX */
+
+       stats->ipackets = ls->rx_ucast_packets +
+               ls->rx_mcast_packets +
+               ls->rx_bcast_packets;
+
+       stats->ibytes = ls->rx_ucast_bytes +
+               ls->rx_mcast_bytes +
+               ls->rx_bcast_bytes;
+
+       for (i = 0; i < lif->nrxqcqs; i++) {
+               struct ionic_rx_stats *rx_stats = &lif->rxqcqs[i]->stats.rx;
+               stats->imissed +=
+                       rx_stats->no_cb_arg +
+                       rx_stats->bad_cq_status +
+                       rx_stats->no_room +
+                       rx_stats->bad_len;
+       }
+
+       stats->imissed +=
+               ls->rx_ucast_drop_packets +
+               ls->rx_mcast_drop_packets +
+               ls->rx_bcast_drop_packets;
+
+       stats->imissed +=
+               ls->rx_queue_empty +
+               ls->rx_dma_error +
+               ls->rx_queue_disabled +
+               ls->rx_desc_fetch_error +
+               ls->rx_desc_data_error;
+
+       for (i = 0; i < num_rx_q_counters; i++) {
+               struct ionic_rx_stats *rx_stats = &lif->rxqcqs[i]->stats.rx;
+               stats->q_ipackets[i] = rx_stats->packets;
+               stats->q_ibytes[i] = rx_stats->bytes;
+               stats->q_errors[i] =
+                       rx_stats->no_cb_arg +
+                       rx_stats->bad_cq_status +
+                       rx_stats->no_room +
+                       rx_stats->bad_len;
+       }
+
+       /* TX */
+
+       stats->opackets = ls->tx_ucast_packets +
+               ls->tx_mcast_packets +
+               ls->tx_bcast_packets;
+
+       stats->obytes = ls->tx_ucast_bytes +
+               ls->tx_mcast_bytes +
+               ls->tx_bcast_bytes;
+
+       for (i = 0; i < lif->ntxqcqs; i++) {
+               struct ionic_tx_stats *tx_stats = &lif->txqcqs[i]->stats.tx;
+               stats->oerrors += tx_stats->drop;
+       }
+
+       stats->oerrors +=
+               ls->tx_ucast_drop_packets +
+               ls->tx_mcast_drop_packets +
+               ls->tx_bcast_drop_packets;
+
+       stats->oerrors +=
+               ls->tx_dma_error +
+               ls->tx_queue_disabled +
+               ls->tx_desc_fetch_error +
+               ls->tx_desc_data_error;
+
+       for (i = 0; i < num_tx_q_counters; i++) {
+               struct ionic_tx_stats *tx_stats = &lif->txqcqs[i]->stats.tx;
+               stats->q_opackets[i] = tx_stats->packets;
+               stats->q_obytes[i] = tx_stats->bytes;
+       }
+}
+
+void
+ionic_lif_get_stats(const struct ionic_lif *lif,
+               struct rte_eth_stats *stats)
+{
+       ionic_lif_get_abs_stats(lif, stats);
+
+       stats->ipackets  -= lif->stats_base.ipackets;
+       stats->opackets  -= lif->stats_base.opackets;
+       stats->ibytes    -= lif->stats_base.ibytes;
+       stats->obytes    -= lif->stats_base.obytes;
+       stats->imissed   -= lif->stats_base.imissed;
+       stats->ierrors   -= lif->stats_base.ierrors;
+       stats->oerrors   -= lif->stats_base.oerrors;
+       stats->rx_nombuf -= lif->stats_base.rx_nombuf;
+}
+
+void
+ionic_lif_reset_stats(struct ionic_lif *lif)
+{
+       uint32_t i;
+
+       for (i = 0; i < lif->nrxqcqs; i++) {
+               memset(&lif->rxqcqs[i]->stats.rx, 0,
+                       sizeof(struct ionic_rx_stats));
+               memset(&lif->txqcqs[i]->stats.tx, 0,
+                       sizeof(struct ionic_tx_stats));
+       }
+
+       ionic_lif_get_abs_stats(lif, &lif->stats_base);
+}
+
+void
+ionic_lif_get_hw_stats(struct ionic_lif *lif, struct ionic_lif_stats *stats)
+{
+       uint16_t i, count = sizeof(struct ionic_lif_stats) / sizeof(uint64_t);
+       uint64_t *stats64 = (uint64_t *)stats;
+       uint64_t *lif_stats64 = (uint64_t *)&lif->info->stats;
+       uint64_t *lif_stats64_base = (uint64_t *)&lif->lif_stats_base;
+
+       for (i = 0; i < count; i++)
+               stats64[i] = lif_stats64[i] - lif_stats64_base[i];
+}
+
+void
+ionic_lif_reset_hw_stats(struct ionic_lif *lif)
+{
+       uint16_t i, count = sizeof(struct ionic_lif_stats) / sizeof(uint64_t);
+       uint64_t *lif_stats64 = (uint64_t *)&lif->info->stats;
+       uint64_t *lif_stats64_base = (uint64_t *)&lif->lif_stats_base;
+
+       for (i = 0; i < count; i++)
+               lif_stats64_base[i] = lif_stats64[i];
+}
+
+static int
+ionic_lif_addr_add(struct ionic_lif *lif, const uint8_t *addr)
+{
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.rx_filter_add = {
+                       .opcode = IONIC_CMD_RX_FILTER_ADD,
+                       .match = IONIC_RX_FILTER_MATCH_MAC,
+               },
+       };
+       int err;
+
+       memcpy(ctx.cmd.rx_filter_add.mac.addr, addr, RTE_ETHER_ADDR_LEN);
+
+       err = ionic_adminq_post_wait(lif, &ctx);
+       if (err)
+               return err;
+
+       IONIC_PRINT(INFO, "rx_filter add (id %d)",
+               ctx.comp.rx_filter_add.filter_id);
+
+       return ionic_rx_filter_save(lif, 0, IONIC_RXQ_INDEX_ANY, &ctx);
+}
+
+static int
+ionic_lif_addr_del(struct ionic_lif *lif, const uint8_t *addr)
+{
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.rx_filter_del = {
+                       .opcode = IONIC_CMD_RX_FILTER_DEL,
+               },
+       };
+       struct ionic_rx_filter *f;
+       int err;
+
+       IONIC_PRINT_CALL();
+
+       rte_spinlock_lock(&lif->rx_filters.lock);
+
+       f = ionic_rx_filter_by_addr(lif, addr);
+       if (!f) {
+               rte_spinlock_unlock(&lif->rx_filters.lock);
+               return -ENOENT;
+       }
+
+       ctx.cmd.rx_filter_del.filter_id = f->filter_id;
+       ionic_rx_filter_free(f);
+
+       rte_spinlock_unlock(&lif->rx_filters.lock);
+
+       err = ionic_adminq_post_wait(lif, &ctx);
+       if (err)
+               return err;
+
+       IONIC_PRINT(INFO, "rx_filter del (id %d)",
+               ctx.cmd.rx_filter_del.filter_id);
+
+       return 0;
+}
+
+int
+ionic_dev_add_mac(struct rte_eth_dev *eth_dev,
+               struct rte_ether_addr *mac_addr,
+               uint32_t index __rte_unused, uint32_t pool __rte_unused)
+{
+       struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);
+
+       IONIC_PRINT_CALL();
+
+       return ionic_lif_addr_add(lif, (const uint8_t *)mac_addr);
+}
+
+void
+ionic_dev_remove_mac(struct rte_eth_dev *eth_dev, uint32_t index __rte_unused)
+{
+       struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);
+       struct ionic_adapter *adapter = lif->adapter;
+
+       IONIC_PRINT_CALL();
+
+       if (index >= adapter->max_mac_addrs) {
+               IONIC_PRINT(WARNING,
+                       "Index %u is above MAC filter limit %u",
+                       index, adapter->max_mac_addrs);
+               return;
+       }
+
+       if (!rte_is_valid_assigned_ether_addr(&eth_dev->data->mac_addrs[index]))
+               return;
+
+       ionic_lif_addr_del(lif, (const uint8_t *)
+               &eth_dev->data->mac_addrs[index]);
+}
+
+int
+ionic_dev_set_mac(struct rte_eth_dev *eth_dev, struct rte_ether_addr *mac_addr)
+{
+       struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);
+
+       IONIC_PRINT_CALL();
+
+       if (mac_addr == NULL) {
+               IONIC_PRINT(NOTICE, "New mac is null");
+               return -1;
+       }
+
+       if (!rte_is_zero_ether_addr((struct rte_ether_addr *)lif->mac_addr)) {
+               IONIC_PRINT(INFO, "Deleting mac addr %pM",
+                       lif->mac_addr);
+               ionic_lif_addr_del(lif, lif->mac_addr);
+               memset(lif->mac_addr, 0, RTE_ETHER_ADDR_LEN);
+       }
+
+       IONIC_PRINT(INFO, "Updating mac addr");
+
+       rte_ether_addr_copy(mac_addr, (struct rte_ether_addr *)lif->mac_addr);
+
+       return ionic_lif_addr_add(lif, (const uint8_t *)mac_addr);
+}
+
+static int
+ionic_vlan_rx_add_vid(struct ionic_lif *lif, uint16_t vid)
+{
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.rx_filter_add = {
+                       .opcode = IONIC_CMD_RX_FILTER_ADD,
+                       .match = IONIC_RX_FILTER_MATCH_VLAN,
+                       .vlan.vlan = vid,
+               },
+       };
+       int err;
+
+       err = ionic_adminq_post_wait(lif, &ctx);
+       if (err)
+               return err;
+
+       IONIC_PRINT(INFO, "rx_filter add VLAN %d (id %d)", vid,
+               ctx.comp.rx_filter_add.filter_id);
+
+       return ionic_rx_filter_save(lif, 0, IONIC_RXQ_INDEX_ANY, &ctx);
+}
+
+static int
+ionic_vlan_rx_kill_vid(struct ionic_lif *lif, uint16_t vid)
+{
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.rx_filter_del = {
+                       .opcode = IONIC_CMD_RX_FILTER_DEL,
+               },
+       };
+       struct ionic_rx_filter *f;
+       int err;
+
+       IONIC_PRINT_CALL();
+
+       rte_spinlock_lock(&lif->rx_filters.lock);
+
+       f = ionic_rx_filter_by_vlan(lif, vid);
+       if (!f) {
+               rte_spinlock_unlock(&lif->rx_filters.lock);
+               return -ENOENT;
+       }
+
+       ctx.cmd.rx_filter_del.filter_id = f->filter_id;
+       ionic_rx_filter_free(f);
+       rte_spinlock_unlock(&lif->rx_filters.lock);
+
+       err = ionic_adminq_post_wait(lif, &ctx);
+       if (err)
+               return err;
+
+       IONIC_PRINT(INFO, "rx_filter del VLAN %d (id %d)", vid,
+               ctx.cmd.rx_filter_del.filter_id);
+
+       return 0;
+}
+
+int
+ionic_dev_vlan_filter_set(struct rte_eth_dev *eth_dev, uint16_t vlan_id,
+               int on)
+{
+       struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);
+       int err;
+
+       if (on)
+               err = ionic_vlan_rx_add_vid(lif, vlan_id);
+       else
+               err = ionic_vlan_rx_kill_vid(lif, vlan_id);
+
+       return err;
+}
+
+static void
+ionic_lif_rx_mode(struct ionic_lif *lif, uint32_t rx_mode)
+{
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.rx_mode_set = {
+                       .opcode = IONIC_CMD_RX_MODE_SET,
+                       .lif_index = lif->index,
+                       .rx_mode = rx_mode,
+               },
+       };
+       int err;
+
+       if (rx_mode & IONIC_RX_MODE_F_UNICAST)
+               IONIC_PRINT(DEBUG, "rx_mode IONIC_RX_MODE_F_UNICAST");
+       if (rx_mode & IONIC_RX_MODE_F_MULTICAST)
+               IONIC_PRINT(DEBUG, "rx_mode IONIC_RX_MODE_F_MULTICAST");
+       if (rx_mode & IONIC_RX_MODE_F_BROADCAST)
+               IONIC_PRINT(DEBUG, "rx_mode IONIC_RX_MODE_F_BROADCAST");
+       if (rx_mode & IONIC_RX_MODE_F_PROMISC)
+               IONIC_PRINT(DEBUG, "rx_mode IONIC_RX_MODE_F_PROMISC");
+       if (rx_mode & IONIC_RX_MODE_F_ALLMULTI)
+               IONIC_PRINT(DEBUG, "rx_mode IONIC_RX_MODE_F_ALLMULTI");
+
+       err = ionic_adminq_post_wait(lif, &ctx);
+       if (err)
+               IONIC_PRINT(ERR, "Failure setting RX mode");
+}
+
+static void
+ionic_set_rx_mode(struct ionic_lif *lif, uint32_t rx_mode)
+{
+       if (lif->rx_mode != rx_mode) {
+               lif->rx_mode = rx_mode;
+               ionic_lif_rx_mode(lif, rx_mode);
+       }
+}
+
+int
+ionic_dev_promiscuous_enable(struct rte_eth_dev *eth_dev)
+{
+       struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);
+       uint32_t rx_mode = lif->rx_mode;
+
+       IONIC_PRINT_CALL();
+
+       rx_mode |= IONIC_RX_MODE_F_PROMISC;
+
+       ionic_set_rx_mode(lif, rx_mode);
+
+       return 0;
+}
+
+int
+ionic_dev_promiscuous_disable(struct rte_eth_dev *eth_dev)
+{
+       struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);
+       uint32_t rx_mode = lif->rx_mode;
+
+       rx_mode &= ~IONIC_RX_MODE_F_PROMISC;
+
+       ionic_set_rx_mode(lif, rx_mode);
+
+       return 0;
+}
+
+int
+ionic_dev_allmulticast_enable(struct rte_eth_dev *eth_dev)
+{
+       struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);
+       uint32_t rx_mode = lif->rx_mode;
+
+       rx_mode |= IONIC_RX_MODE_F_ALLMULTI;
+
+       ionic_set_rx_mode(lif, rx_mode);
+
+       return 0;
+}
+
+int
+ionic_dev_allmulticast_disable(struct rte_eth_dev *eth_dev)
+{
+       struct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);
+       uint32_t rx_mode = lif->rx_mode;
+
+       rx_mode &= ~IONIC_RX_MODE_F_ALLMULTI;
+
+       ionic_set_rx_mode(lif, rx_mode);
+
+       return 0;
+}
+
+int
+ionic_lif_change_mtu(struct ionic_lif *lif, int new_mtu)
+{
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.lif_setattr = {
+                       .opcode = IONIC_CMD_LIF_SETATTR,
+                       .index = lif->index,
+                       .attr = IONIC_LIF_ATTR_MTU,
+                       .mtu = new_mtu,
+               },
+       };
+       int err;
+
+       err = ionic_adminq_post_wait(lif, &ctx);
+       if (err)
+               return err;
+
+       lif->mtu = new_mtu;
+
+       return 0;
+}
+
 int
 ionic_intr_alloc(struct ionic_lif *lif, struct ionic_intr_info *intr)
 {
@@ -240,6 +721,50 @@ ionic_qcq_free(struct ionic_qcq *qcq)
        rte_free(qcq);
 }
 
+int
+ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t index, uint16_t nrxq_descs,
+               struct ionic_qcq **qcq)
+{
+       uint32_t flags;
+       int err = -ENOMEM;
+
+       flags = IONIC_QCQ_F_SG;
+       err = ionic_qcq_alloc(lif, IONIC_QTYPE_RXQ, index, "rx", flags,
+               nrxq_descs,
+               sizeof(struct ionic_rxq_desc),
+               sizeof(struct ionic_rxq_comp),
+               sizeof(struct ionic_rxq_sg_desc),
+               lif->kern_pid, &lif->rxqcqs[index]);
+       if (err)
+               return err;
+
+       *qcq = lif->rxqcqs[index];
+
+       return 0;
+}
+
+int
+ionic_tx_qcq_alloc(struct ionic_lif *lif, uint32_t index, uint16_t ntxq_descs,
+               struct ionic_qcq **qcq)
+{
+       uint32_t flags;
+       int err = -ENOMEM;
+
+       flags = IONIC_QCQ_F_SG;
+       err = ionic_qcq_alloc(lif, IONIC_QTYPE_TXQ, index, "tx", flags,
+               ntxq_descs,
+               sizeof(struct ionic_txq_desc),
+               sizeof(struct ionic_txq_comp),
+               sizeof(struct ionic_txq_sg_desc),
+               lif->kern_pid, &lif->txqcqs[index]);
+       if (err)
+               return err;
+
+       *qcq = lif->txqcqs[index];
+
+       return 0;
+}
+
 static int
 ionic_admin_qcq_alloc(struct ionic_lif *lif)
 {
@@ -316,10 +841,25 @@ ionic_lif_alloc(struct ionic_lif *lif)
                return -ENOMEM;
        }
 
+       lif->txqcqs = rte_zmalloc("ionic", sizeof(*lif->txqcqs) *
+               adapter->max_ntxqs_per_lif, 0);
+
+       if (!lif->txqcqs) {
+               IONIC_PRINT(ERR, "Cannot allocate tx queues array");
+               return -ENOMEM;
+       }
+
+       lif->rxqcqs = rte_zmalloc("ionic", sizeof(*lif->rxqcqs) *
+               adapter->max_nrxqs_per_lif, 0);
+
+       if (!lif->rxqcqs) {
+               IONIC_PRINT(ERR, "Cannot allocate rx queues array");
+               return -ENOMEM;
+       }
+
        IONIC_PRINT(DEBUG, "Allocating Notify Queue");
 
        err = ionic_notify_qcq_alloc(lif);
-
        if (err) {
                IONIC_PRINT(ERR, "Cannot allocate notify queue");
                return err;
@@ -366,12 +906,113 @@ ionic_lif_free(struct ionic_lif *lif)
                lif->adminqcq = NULL;
        }
 
+       if (lif->txqcqs) {
+               rte_free(lif->txqcqs);
+               lif->txqcqs = NULL;
+       }
+
+       if (lif->rxqcqs) {
+               rte_free(lif->rxqcqs);
+               lif->rxqcqs = NULL;
+       }
+
        if (lif->info) {
                rte_memzone_free(lif->info_z);
                lif->info = NULL;
        }
 }
 
+int
+ionic_lif_rss_config(struct ionic_lif *lif,
+               const uint16_t types, const uint8_t *key, const uint32_t *indir)
+{
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.lif_setattr = {
+                       .opcode = IONIC_CMD_LIF_SETATTR,
+                       .attr = IONIC_LIF_ATTR_RSS,
+                       .rss.types = types,
+                       .rss.addr = lif->rss_ind_tbl_pa,
+               },
+       };
+       unsigned int i;
+
+       IONIC_PRINT_CALL();
+
+       lif->rss_types = types;
+
+       if (key)
+               memcpy(lif->rss_hash_key, key, IONIC_RSS_HASH_KEY_SIZE);
+
+       if (indir)
+               for (i = 0; i < lif->adapter->ident.lif.eth.rss_ind_tbl_sz; i++)
+                       lif->rss_ind_tbl[i] = indir[i];
+
+       memcpy(ctx.cmd.lif_setattr.rss.key, lif->rss_hash_key,
+              IONIC_RSS_HASH_KEY_SIZE);
+
+       return ionic_adminq_post_wait(lif, &ctx);
+}
+
+static int
+ionic_lif_rss_setup(struct ionic_lif *lif)
+{
+       size_t tbl_size = sizeof(*lif->rss_ind_tbl) *
+               lif->adapter->ident.lif.eth.rss_ind_tbl_sz;
+       static const uint8_t toeplitz_symmetric_key[] = {
+               0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A,
+               0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A,
+               0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A,
+               0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A,
+               0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A, 0x6D, 0x5A,
+       };
+       uint32_t socket_id = rte_socket_id();
+       uint32_t i;
+       int err;
+
+       IONIC_PRINT_CALL();
+
+       lif->rss_ind_tbl_z = rte_eth_dma_zone_reserve(lif->eth_dev,
+               "rss_ind_tbl",
+               0 /* queue_idx*/, tbl_size, IONIC_ALIGN, socket_id);
+
+       if (!lif->rss_ind_tbl_z) {
+               IONIC_PRINT(ERR, "OOM");
+               return -ENOMEM;
+       }
+
+       lif->rss_ind_tbl = lif->rss_ind_tbl_z->addr;
+       lif->rss_ind_tbl_pa = lif->rss_ind_tbl_z->iova;
+
+       /* Fill indirection table with 'default' values */
+       for (i = 0; i < lif->adapter->ident.lif.eth.rss_ind_tbl_sz; i++)
+               lif->rss_ind_tbl[i] = i % lif->nrxqcqs;
+
+       err = ionic_lif_rss_config(lif, IONIC_RSS_OFFLOAD_ALL,
+               toeplitz_symmetric_key, NULL);
+       if (err)
+               return err;
+
+       return 0;
+}
+
+static void
+ionic_lif_rss_teardown(struct ionic_lif *lif)
+{
+       if (!lif->rss_ind_tbl)
+               return;
+
+       if (lif->rss_ind_tbl_z) {
+               /* Disable RSS on the NIC */
+               ionic_lif_rss_config(lif, 0x0, NULL, NULL);
+
+               lif->rss_ind_tbl = NULL;
+               lif->rss_ind_tbl_pa = 0;
+               rte_memzone_free(lif->rss_ind_tbl_z);
+               lif->rss_ind_tbl_z = NULL;
+       }
+}
+
 static void
 ionic_lif_qcq_deinit(struct ionic_lif *lif, struct ionic_qcq *qcq)
 {
@@ -387,6 +1028,18 @@ ionic_lif_qcq_deinit(struct ionic_lif *lif, struct ionic_qcq *qcq)
        qcq->flags &= ~IONIC_QCQ_F_INITED;
 }
 
+void
+ionic_lif_txq_deinit(struct ionic_qcq *qcq)
+{
+       ionic_lif_qcq_deinit(qcq->lif, qcq);
+}
+
+void
+ionic_lif_rxq_deinit(struct ionic_qcq *qcq)
+{
+       ionic_lif_qcq_deinit(qcq->lif, qcq);
+}
+
 bool
 ionic_adminq_service(struct ionic_cq *cq, uint32_t cq_desc_index,
                void *cb_arg __rte_unused)
@@ -593,6 +1246,219 @@ ionic_lif_notifyq_init(struct ionic_lif *lif)
        return 0;
 }
 
+int
+ionic_lif_set_features(struct ionic_lif *lif)
+{
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.lif_setattr = {
+                       .opcode = IONIC_CMD_LIF_SETATTR,
+                       .index = lif->index,
+                       .attr = IONIC_LIF_ATTR_FEATURES,
+                       .features = lif->features,
+               },
+       };
+       int err;
+
+       err = ionic_adminq_post_wait(lif, &ctx);
+       if (err)
+               return err;
+
+       lif->hw_features = (ctx.cmd.lif_setattr.features &
+               ctx.comp.lif_setattr.features);
+
+       if (lif->hw_features & IONIC_ETH_HW_VLAN_TX_TAG)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_VLAN_TX_TAG");
+       if (lif->hw_features & IONIC_ETH_HW_VLAN_RX_STRIP)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_VLAN_RX_STRIP");
+       if (lif->hw_features & IONIC_ETH_HW_VLAN_RX_FILTER)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_VLAN_RX_FILTER");
+       if (lif->hw_features & IONIC_ETH_HW_RX_HASH)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_RX_HASH");
+       if (lif->hw_features & IONIC_ETH_HW_TX_SG)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TX_SG");
+       if (lif->hw_features & IONIC_ETH_HW_RX_SG)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_RX_SG");
+       if (lif->hw_features & IONIC_ETH_HW_TX_CSUM)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TX_CSUM");
+       if (lif->hw_features & IONIC_ETH_HW_RX_CSUM)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_RX_CSUM");
+       if (lif->hw_features & IONIC_ETH_HW_TSO)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TSO");
+       if (lif->hw_features & IONIC_ETH_HW_TSO_IPV6)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TSO_IPV6");
+       if (lif->hw_features & IONIC_ETH_HW_TSO_ECN)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TSO_ECN");
+       if (lif->hw_features & IONIC_ETH_HW_TSO_GRE)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TSO_GRE");
+       if (lif->hw_features & IONIC_ETH_HW_TSO_GRE_CSUM)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TSO_GRE_CSUM");
+       if (lif->hw_features & IONIC_ETH_HW_TSO_IPXIP4)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TSO_IPXIP4");
+       if (lif->hw_features & IONIC_ETH_HW_TSO_IPXIP6)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TSO_IPXIP6");
+       if (lif->hw_features & IONIC_ETH_HW_TSO_UDP)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TSO_UDP");
+       if (lif->hw_features & IONIC_ETH_HW_TSO_UDP_CSUM)
+               IONIC_PRINT(DEBUG, "feature IONIC_ETH_HW_TSO_UDP_CSUM");
+
+       return 0;
+}
+
+int
+ionic_lif_txq_init(struct ionic_qcq *qcq)
+{
+       struct ionic_queue *q = &qcq->q;
+       struct ionic_lif *lif = qcq->lif;
+       struct ionic_cq *cq = &qcq->cq;
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.q_init = {
+                       .opcode = IONIC_CMD_Q_INIT,
+                       .lif_index = lif->index,
+                       .type = q->type,
+                       .index = q->index,
+                       .flags = IONIC_QINIT_F_SG,
+                       .intr_index = cq->bound_intr->index,
+                       .pid = q->pid,
+                       .ring_size = rte_log2_u32(q->num_descs),
+                       .ring_base = q->base_pa,
+                       .cq_ring_base = cq->base_pa,
+                       .sg_ring_base = q->sg_base_pa,
+               },
+       };
+       int err;
+
+       IONIC_PRINT(DEBUG, "txq_init.pid %d", ctx.cmd.q_init.pid);
+       IONIC_PRINT(DEBUG, "txq_init.index %d", ctx.cmd.q_init.index);
+       IONIC_PRINT(DEBUG, "txq_init.ring_base 0x%" PRIx64 "",
+               ctx.cmd.q_init.ring_base);
+       IONIC_PRINT(DEBUG, "txq_init.ring_size %d",
+               ctx.cmd.q_init.ring_size);
+
+       err = ionic_adminq_post_wait(qcq->lif, &ctx);
+       if (err)
+               return err;
+
+       q->hw_type = ctx.comp.q_init.hw_type;
+       q->hw_index = ctx.comp.q_init.hw_index;
+       q->db = ionic_db_map(lif, q);
+
+       IONIC_PRINT(DEBUG, "txq->hw_type %d", q->hw_type);
+       IONIC_PRINT(DEBUG, "txq->hw_index %d", q->hw_index);
+       IONIC_PRINT(DEBUG, "txq->db %p", q->db);
+
+       qcq->flags |= IONIC_QCQ_F_INITED;
+
+       return 0;
+}
+
+int
+ionic_lif_rxq_init(struct ionic_qcq *qcq)
+{
+       struct ionic_queue *q = &qcq->q;
+       struct ionic_lif *lif = qcq->lif;
+       struct ionic_cq *cq = &qcq->cq;
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.q_init = {
+                       .opcode = IONIC_CMD_Q_INIT,
+                       .lif_index = lif->index,
+                       .type = q->type,
+                       .index = q->index,
+                       .flags = IONIC_QINIT_F_SG,
+                       .intr_index = cq->bound_intr->index,
+                       .pid = q->pid,
+                       .ring_size = rte_log2_u32(q->num_descs),
+                       .ring_base = q->base_pa,
+                       .cq_ring_base = cq->base_pa,
+                       .sg_ring_base = q->sg_base_pa,
+               },
+       };
+       int err;
+
+       IONIC_PRINT(DEBUG, "rxq_init.pid %d", ctx.cmd.q_init.pid);
+       IONIC_PRINT(DEBUG, "rxq_init.index %d", ctx.cmd.q_init.index);
+       IONIC_PRINT(DEBUG, "rxq_init.ring_base 0x%" PRIx64 "",
+               ctx.cmd.q_init.ring_base);
+       IONIC_PRINT(DEBUG, "rxq_init.ring_size %d",
+               ctx.cmd.q_init.ring_size);
+
+       err = ionic_adminq_post_wait(qcq->lif, &ctx);
+       if (err)
+               return err;
+
+       q->hw_type = ctx.comp.q_init.hw_type;
+       q->hw_index = ctx.comp.q_init.hw_index;
+       q->db = ionic_db_map(lif, q);
+
+       qcq->flags |= IONIC_QCQ_F_INITED;
+
+       IONIC_PRINT(DEBUG, "rxq->hw_type %d", q->hw_type);
+       IONIC_PRINT(DEBUG, "rxq->hw_index %d", q->hw_index);
+       IONIC_PRINT(DEBUG, "rxq->db %p", q->db);
+
+       return 0;
+}
+
+static int
+ionic_station_set(struct ionic_lif *lif)
+{
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.lif_getattr = {
+                       .opcode = IONIC_CMD_LIF_GETATTR,
+                       .index = lif->index,
+                       .attr = IONIC_LIF_ATTR_MAC,
+               },
+       };
+       int err;
+
+       IONIC_PRINT_CALL();
+
+       err = ionic_adminq_post_wait(lif, &ctx);
+       if (err)
+               return err;
+
+       if (!rte_is_zero_ether_addr((struct rte_ether_addr *)
+                       lif->mac_addr)) {
+               IONIC_PRINT(INFO, "deleting station MAC addr");
+
+               ionic_lif_addr_del(lif, lif->mac_addr);
+       }
+
+       memcpy(lif->mac_addr, ctx.comp.lif_getattr.mac, RTE_ETHER_ADDR_LEN);
+
+       if (rte_is_zero_ether_addr((struct rte_ether_addr *)lif->mac_addr)) {
+               IONIC_PRINT(NOTICE, "empty MAC addr (VF?)");
+               return 0;
+       }
+
+       IONIC_PRINT(DEBUG, "adding station MAC addr");
+
+       ionic_lif_addr_add(lif, lif->mac_addr);
+
+       return 0;
+}
+
+static void
+ionic_lif_set_name(struct ionic_lif *lif)
+{
+       struct ionic_admin_ctx ctx = {
+               .pending_work = true,
+               .cmd.lif_setattr = {
+                       .opcode = IONIC_CMD_LIF_SETATTR,
+                       .index = lif->index,
+                       .attr = IONIC_LIF_ATTR_NAME,
+               },
+       };
+
+       snprintf(ctx.cmd.lif_setattr.name, sizeof(ctx.cmd.lif_setattr.name),
+               "%d", lif->port_id);
+
+       ionic_adminq_post_wait(lif, &ctx);
+}
+
 int
 ionic_lif_init(struct ionic_lif *lif)
 {
@@ -600,6 +1466,8 @@ ionic_lif_init(struct ionic_lif *lif)
        struct ionic_q_init_comp comp;
        int err;
 
+       memset(&lif->stats_base, 0, sizeof(lif->stats_base));
+
        ionic_dev_cmd_lif_init(idev, lif->index, lif->info_pa);
        err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);
        ionic_dev_cmd_comp(idev, &comp);
@@ -616,10 +1484,43 @@ ionic_lif_init(struct ionic_lif *lif)
        if (err)
                goto err_out_adminq_deinit;
 
+       lif->features =
+                 IONIC_ETH_HW_VLAN_TX_TAG
+               | IONIC_ETH_HW_VLAN_RX_STRIP
+               | IONIC_ETH_HW_VLAN_RX_FILTER
+               | IONIC_ETH_HW_RX_HASH
+               | IONIC_ETH_HW_TX_SG
+               | IONIC_ETH_HW_RX_SG
+               | IONIC_ETH_HW_TX_CSUM
+               | IONIC_ETH_HW_RX_CSUM
+               | IONIC_ETH_HW_TSO
+               | IONIC_ETH_HW_TSO_IPV6
+               | IONIC_ETH_HW_TSO_ECN;
+
+       err = ionic_lif_set_features(lif);
+       if (err)
+               goto err_out_notifyq_deinit;
+
+       err = ionic_rx_filters_init(lif);
+       if (err)
+               goto err_out_notifyq_deinit;
+
+       err = ionic_station_set(lif);
+       if (err)
+               goto err_out_rx_filter_deinit;
+
+       ionic_lif_set_name(lif);
+
        lif->state |= IONIC_LIF_F_INITED;
 
        return 0;
 
+err_out_rx_filter_deinit:
+       ionic_rx_filters_deinit(lif);
+
+err_out_notifyq_deinit:
+       ionic_lif_qcq_deinit(lif, lif->notifyqcq);
+
 err_out_adminq_deinit:
        ionic_lif_qcq_deinit(lif, lif->adminqcq);
 
@@ -632,12 +1533,98 @@ ionic_lif_deinit(struct ionic_lif *lif)
        if (!(lif->state & IONIC_LIF_F_INITED))
                return;
 
+       ionic_rx_filters_deinit(lif);
+       ionic_lif_rss_teardown(lif);
        ionic_lif_qcq_deinit(lif, lif->notifyqcq);
        ionic_lif_qcq_deinit(lif, lif->adminqcq);
 
        lif->state &= ~IONIC_LIF_F_INITED;
 }
 
+int
+ionic_lif_configure(struct ionic_lif *lif)
+{
+       struct ionic_identity *ident = &lif->adapter->ident;
+       uint32_t ntxqs_per_lif =
+               ident->lif.eth.config.queue_count[IONIC_QTYPE_TXQ];
+       uint32_t nrxqs_per_lif =
+               ident->lif.eth.config.queue_count[IONIC_QTYPE_RXQ];
+       uint32_t nrxqs = lif->eth_dev->data->nb_rx_queues;
+       uint32_t ntxqs = lif->eth_dev->data->nb_tx_queues;
+
+       lif->port_id = lif->eth_dev->data->port_id;
+
+       IONIC_PRINT(DEBUG, "Configuring LIF on port %u",
+               lif->port_id);
+
+       if (nrxqs > 0)
+               nrxqs_per_lif = RTE_MIN(nrxqs_per_lif, nrxqs);
+
+       if (ntxqs > 0)
+               ntxqs_per_lif = RTE_MIN(ntxqs_per_lif, ntxqs);
+
+       lif->nrxqcqs = nrxqs_per_lif;
+       lif->ntxqcqs = ntxqs_per_lif;
+
+       return 0;
+}
+
+int
+ionic_lif_start(struct ionic_lif *lif)
+{
+       uint32_t rx_mode = 0;
+       uint32_t i;
+       int err;
+
+       IONIC_PRINT(DEBUG, "Setting RSS configuration on port %u",
+               lif->port_id);
+
+       err = ionic_lif_rss_setup(lif);
+       if (err)
+               return err;
+
+       IONIC_PRINT(DEBUG, "Setting RX mode on port %u",
+               lif->port_id);
+
+       rx_mode |= IONIC_RX_MODE_F_UNICAST;
+       rx_mode |= IONIC_RX_MODE_F_MULTICAST;
+       rx_mode |= IONIC_RX_MODE_F_BROADCAST;
+
+       lif->rx_mode = 0; /* set by ionic_set_rx_mode */
+
+       ionic_set_rx_mode(lif, rx_mode);
+
+       IONIC_PRINT(DEBUG, "Starting %u RX queues and %u TX queues "
+               "on port %u",
+               lif->nrxqcqs, lif->ntxqcqs, lif->port_id);
+
+       for (i = 0; i < lif->nrxqcqs; i++) {
+               struct ionic_qcq *rxq = lif->rxqcqs[i];
+               if (!rxq->deferred_start) {
+                       err = ionic_dev_rx_queue_start(lif->eth_dev, i);
+
+                       if (err)
+                               return err;
+               }
+       }
+
+       for (i = 0; i < lif->ntxqcqs; i++) {
+               struct ionic_qcq *txq = lif->txqcqs[i];
+               if (!txq->deferred_start) {
+                       err = ionic_dev_tx_queue_start(lif->eth_dev, i);
+
+                       if (err)
+                               return err;
+               }
+       }
+
+       ionic_link_status_check(lif);
+
+       /* Carrier ON here */
+
+       return 0;
+}
+
 int
 ionic_lif_identify(struct ionic_adapter *adapter)
 {