net/i40e: remove duplicate tunnel type check
[dpdk.git] / drivers / net / ixgbe / base / ixgbe_x550.c
index 5cf9e40..8810d16 100644 (file)
@@ -1,35 +1,6 @@
-/*******************************************************************************
-
-Copyright (c) 2001-2015, Intel Corporation
-All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions are met:
-
- 1. Redistributions of source code must retain the above copyright notice,
-    this list of conditions and the following disclaimer.
-
- 2. Redistributions in binary form must reproduce the above copyright
-    notice, this list of conditions and the following disclaimer in the
-    documentation and/or other materials provided with the distribution.
-
- 3. Neither the name of the Intel Corporation nor the names of its
-    contributors may be used to endorse or promote products derived from
-    this software without specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
-LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
-POSSIBILITY OF SUCH DAMAGE.
-
-***************************************************************************/
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2001-2020 Intel Corporation
+ */
 
 #include "ixgbe_x550.h"
 #include "ixgbe_x540.h"
@@ -44,11 +15,11 @@ STATIC void ixgbe_release_swfw_sync_X550a(struct ixgbe_hw *, u32 mask);
 STATIC s32 ixgbe_read_mng_if_sel_x550em(struct ixgbe_hw *hw);
 
 /**
- *  ixgbe_init_ops_X550 - Inits func ptrs and MAC type
- *  @hw: pointer to hardware structure
+ * ixgbe_init_ops_X550 - Inits func ptrs and MAC type
+ * @hw: pointer to hardware structure
  *
- *  Initialize the function pointers and assign the MAC type for X550.
- *  Does not touch the hardware.
+ * Initialize the function pointers and assign the MAC type for X550.
+ * Does not touch the hardware.
  **/
 s32 ixgbe_init_ops_X550(struct ixgbe_hw *hw)
 {
@@ -62,7 +33,7 @@ s32 ixgbe_init_ops_X550(struct ixgbe_hw *hw)
        mac->ops.dmac_config = ixgbe_dmac_config_X550;
        mac->ops.dmac_config_tcs = ixgbe_dmac_config_tcs_X550;
        mac->ops.dmac_update_tcs = ixgbe_dmac_update_tcs_X550;
-       mac->ops.setup_eee = ixgbe_setup_eee_X550;
+       mac->ops.setup_eee = NULL;
        mac->ops.set_source_address_pruning =
                        ixgbe_set_source_address_pruning_X550;
        mac->ops.set_ethertype_anti_spoofing =
@@ -82,10 +53,15 @@ s32 ixgbe_init_ops_X550(struct ixgbe_hw *hw)
        mac->ops.enable_mdd = ixgbe_enable_mdd_X550;
        mac->ops.mdd_event = ixgbe_mdd_event_X550;
        mac->ops.restore_mdd_vf = ixgbe_restore_mdd_vf_X550;
+       mac->ops.fw_recovery_mode = ixgbe_fw_recovery_mode_X550;
        mac->ops.disable_rx = ixgbe_disable_rx_x550;
        /* Manageability interface */
        mac->ops.set_fw_drv_ver = ixgbe_set_fw_drv_ver_x550;
        switch (hw->device_id) {
+       case IXGBE_DEV_ID_X550EM_X_1G_T:
+               hw->mac.ops.led_on = NULL;
+               hw->mac.ops.led_off = NULL;
+               break;
        case IXGBE_DEV_ID_X550EM_X_10G_T:
        case IXGBE_DEV_ID_X550EM_A_10G_T:
                hw->mac.ops.led_on = ixgbe_led_on_t_X550em;
@@ -331,98 +307,6 @@ STATIC void ixgbe_setup_mux_ctl(struct ixgbe_hw *hw)
        IXGBE_WRITE_FLUSH(hw);
 }
 
-/**
- * ixgbe_read_phy_reg_mdi_22 - Read from a clause 22 PHY register without lock
- * @hw: pointer to hardware structure
- * @reg_addr: 32 bit address of PHY register to read
- * @dev_type: always unused
- * @phy_data: Pointer to read data from PHY register
- */
-STATIC s32 ixgbe_read_phy_reg_mdi_22(struct ixgbe_hw *hw, u32 reg_addr,
-                                    u32 dev_type, u16 *phy_data)
-{
-       u32 i, data, command;
-       UNREFERENCED_1PARAMETER(dev_type);
-
-       /* Setup and write the read command */
-       command = (reg_addr << IXGBE_MSCA_DEV_TYPE_SHIFT) |
-                 (hw->phy.addr << IXGBE_MSCA_PHY_ADDR_SHIFT) |
-                 IXGBE_MSCA_OLD_PROTOCOL | IXGBE_MSCA_READ_AUTOINC |
-                 IXGBE_MSCA_MDI_COMMAND;
-
-       IXGBE_WRITE_REG(hw, IXGBE_MSCA, command);
-
-       /* Check every 10 usec to see if the access completed.
-        * The MDI Command bit will clear when the operation is
-        * complete
-        */
-       for (i = 0; i < IXGBE_MDIO_COMMAND_TIMEOUT; i++) {
-               usec_delay(10);
-
-               command = IXGBE_READ_REG(hw, IXGBE_MSCA);
-               if (!(command & IXGBE_MSCA_MDI_COMMAND))
-                       break;
-       }
-
-       if (command & IXGBE_MSCA_MDI_COMMAND) {
-               ERROR_REPORT1(IXGBE_ERROR_POLLING,
-                             "PHY read command did not complete.\n");
-               return IXGBE_ERR_PHY;
-       }
-
-       /* Read operation is complete.  Get the data from MSRWD */
-       data = IXGBE_READ_REG(hw, IXGBE_MSRWD);
-       data >>= IXGBE_MSRWD_READ_DATA_SHIFT;
-       *phy_data = (u16)data;
-
-       return IXGBE_SUCCESS;
-}
-
-/**
- * ixgbe_write_phy_reg_mdi_22 - Write to a clause 22 PHY register without lock
- * @hw: pointer to hardware structure
- * @reg_addr: 32 bit PHY register to write
- * @dev_type: always unused
- * @phy_data: Data to write to the PHY register
- */
-STATIC s32 ixgbe_write_phy_reg_mdi_22(struct ixgbe_hw *hw, u32 reg_addr,
-                                     u32 dev_type, u16 phy_data)
-{
-       u32 i, command;
-       UNREFERENCED_1PARAMETER(dev_type);
-
-       /* Put the data in the MDI single read and write data register*/
-       IXGBE_WRITE_REG(hw, IXGBE_MSRWD, (u32)phy_data);
-
-       /* Setup and write the write command */
-       command = (reg_addr << IXGBE_MSCA_DEV_TYPE_SHIFT) |
-                 (hw->phy.addr << IXGBE_MSCA_PHY_ADDR_SHIFT) |
-                 IXGBE_MSCA_OLD_PROTOCOL | IXGBE_MSCA_WRITE |
-                 IXGBE_MSCA_MDI_COMMAND;
-
-       IXGBE_WRITE_REG(hw, IXGBE_MSCA, command);
-
-       /* Check every 10 usec to see if the access completed.
-        * The MDI Command bit will clear when the operation is
-        * complete
-        */
-       for (i = 0; i < IXGBE_MDIO_COMMAND_TIMEOUT; i++) {
-               usec_delay(10);
-
-               command = IXGBE_READ_REG(hw, IXGBE_MSCA);
-               if (!(command & IXGBE_MSCA_MDI_COMMAND))
-                       break;
-       }
-
-       if (command & IXGBE_MSCA_MDI_COMMAND) {
-               ERROR_REPORT1(IXGBE_ERROR_POLLING,
-                             "PHY write cmd didn't complete\n");
-               return IXGBE_ERR_PHY;
-       }
-
-       return IXGBE_SUCCESS;
-}
-
 /**
  * ixgbe_identify_phy_x550em - Get PHY type based on device id
  * @hw: pointer to hardware structure
@@ -437,7 +321,7 @@ STATIC s32 ixgbe_identify_phy_x550em(struct ixgbe_hw *hw)
 
        switch (hw->device_id) {
        case IXGBE_DEV_ID_X550EM_A_SFP:
-               return ixgbe_identify_module_generic(hw);
+               return ixgbe_identify_sfp_module_X550em(hw);
        case IXGBE_DEV_ID_X550EM_X_SFP:
                /* set up for CS4227 usage */
                ixgbe_setup_mux_ctl(hw);
@@ -445,28 +329,166 @@ STATIC s32 ixgbe_identify_phy_x550em(struct ixgbe_hw *hw)
                /* Fallthrough */
 
        case IXGBE_DEV_ID_X550EM_A_SFP_N:
-               return ixgbe_identify_module_generic(hw);
+               return ixgbe_identify_sfp_module_X550em(hw);
                break;
        case IXGBE_DEV_ID_X550EM_X_KX4:
                hw->phy.type = ixgbe_phy_x550em_kx4;
                break;
+       case IXGBE_DEV_ID_X550EM_X_XFI:
+               hw->phy.type = ixgbe_phy_x550em_xfi;
+               break;
        case IXGBE_DEV_ID_X550EM_X_KR:
        case IXGBE_DEV_ID_X550EM_A_KR:
        case IXGBE_DEV_ID_X550EM_A_KR_L:
                hw->phy.type = ixgbe_phy_x550em_kr;
                break;
        case IXGBE_DEV_ID_X550EM_A_10G_T:
-       case IXGBE_DEV_ID_X550EM_A_1G_T:
-       case IXGBE_DEV_ID_X550EM_A_1G_T_L:
-       case IXGBE_DEV_ID_X550EM_X_1G_T:
        case IXGBE_DEV_ID_X550EM_X_10G_T:
                return ixgbe_identify_phy_generic(hw);
+       case IXGBE_DEV_ID_X550EM_X_1G_T:
+               hw->phy.type = ixgbe_phy_ext_1g_t;
+               break;
+       case IXGBE_DEV_ID_X550EM_A_1G_T:
+       case IXGBE_DEV_ID_X550EM_A_1G_T_L:
+               hw->phy.type = ixgbe_phy_fw;
+               if (hw->bus.lan_id)
+                       hw->phy.phy_semaphore_mask |= IXGBE_GSSR_PHY1_SM;
+               else
+                       hw->phy.phy_semaphore_mask |= IXGBE_GSSR_PHY0_SM;
+               break;
        default:
                break;
        }
        return IXGBE_SUCCESS;
 }
 
+/**
+ * ixgbe_fw_phy_activity - Perform an activity on a PHY
+ * @hw: pointer to hardware structure
+ * @activity: activity to perform
+ * @data: Pointer to 4 32-bit words of data
+ */
+s32 ixgbe_fw_phy_activity(struct ixgbe_hw *hw, u16 activity,
+                         u32 (*data)[FW_PHY_ACT_DATA_COUNT])
+{
+       union {
+               struct ixgbe_hic_phy_activity_req cmd;
+               struct ixgbe_hic_phy_activity_resp rsp;
+       } hic;
+       u16 retries = FW_PHY_ACT_RETRIES;
+       s32 rc;
+       u16 i;
+
+       do {
+               memset(&hic, 0, sizeof(hic));
+               hic.cmd.hdr.cmd = FW_PHY_ACT_REQ_CMD;
+               hic.cmd.hdr.buf_len = FW_PHY_ACT_REQ_LEN;
+               hic.cmd.hdr.checksum = FW_DEFAULT_CHECKSUM;
+               hic.cmd.port_number = hw->bus.lan_id;
+               hic.cmd.activity_id = IXGBE_CPU_TO_LE16(activity);
+               for (i = 0; i < FW_PHY_ACT_DATA_COUNT; ++i)
+                       hic.cmd.data[i] = IXGBE_CPU_TO_BE32((*data)[i]);
+
+               rc = ixgbe_host_interface_command(hw, (u32 *)&hic.cmd,
+                                                 sizeof(hic.cmd),
+                                                 IXGBE_HI_COMMAND_TIMEOUT,
+                                                 true);
+               if (rc != IXGBE_SUCCESS)
+                       return rc;
+               if (hic.rsp.hdr.cmd_or_resp.ret_status ==
+                   FW_CEM_RESP_STATUS_SUCCESS) {
+                       for (i = 0; i < FW_PHY_ACT_DATA_COUNT; ++i)
+                               (*data)[i] = IXGBE_BE32_TO_CPU(hic.rsp.data[i]);
+                       return IXGBE_SUCCESS;
+               }
+               usec_delay(20);
+               --retries;
+       } while (retries > 0);
+
+       return IXGBE_ERR_HOST_INTERFACE_COMMAND;
+}
+
+static const struct {
+       u16 fw_speed;
+       ixgbe_link_speed phy_speed;
+} ixgbe_fw_map[] = {
+       { FW_PHY_ACT_LINK_SPEED_10, IXGBE_LINK_SPEED_10_FULL },
+       { FW_PHY_ACT_LINK_SPEED_100, IXGBE_LINK_SPEED_100_FULL },
+       { FW_PHY_ACT_LINK_SPEED_1G, IXGBE_LINK_SPEED_1GB_FULL },
+       { FW_PHY_ACT_LINK_SPEED_2_5G, IXGBE_LINK_SPEED_2_5GB_FULL },
+       { FW_PHY_ACT_LINK_SPEED_5G, IXGBE_LINK_SPEED_5GB_FULL },
+       { FW_PHY_ACT_LINK_SPEED_10G, IXGBE_LINK_SPEED_10GB_FULL },
+};
+
+/**
+ * ixgbe_get_phy_id_fw - Get the phy ID via firmware command
+ * @hw: pointer to hardware structure
+ *
+ * Returns error code
+ */
+static s32 ixgbe_get_phy_id_fw(struct ixgbe_hw *hw)
+{
+       u32 info[FW_PHY_ACT_DATA_COUNT] = { 0 };
+       u16 phy_speeds;
+       u16 phy_id_lo;
+       s32 rc;
+       u16 i;
+
+       rc = ixgbe_fw_phy_activity(hw, FW_PHY_ACT_GET_PHY_INFO, &info);
+       if (rc)
+               return rc;
+
+       hw->phy.speeds_supported = 0;
+       phy_speeds = info[0] & FW_PHY_INFO_SPEED_MASK;
+       for (i = 0; i < sizeof(ixgbe_fw_map) / sizeof(ixgbe_fw_map[0]); ++i) {
+               if (phy_speeds & ixgbe_fw_map[i].fw_speed)
+                       hw->phy.speeds_supported |= ixgbe_fw_map[i].phy_speed;
+       }
+       if (!hw->phy.autoneg_advertised)
+               hw->phy.autoneg_advertised = hw->phy.speeds_supported;
+
+       hw->phy.id = info[0] & FW_PHY_INFO_ID_HI_MASK;
+       phy_id_lo = info[1] & FW_PHY_INFO_ID_LO_MASK;
+       hw->phy.id |= phy_id_lo & IXGBE_PHY_REVISION_MASK;
+       hw->phy.revision = phy_id_lo & ~IXGBE_PHY_REVISION_MASK;
+       if (!hw->phy.id || hw->phy.id == IXGBE_PHY_REVISION_MASK)
+               return IXGBE_ERR_PHY_ADDR_INVALID;
+       return IXGBE_SUCCESS;
+}
+
+/**
+ * ixgbe_identify_phy_fw - Get PHY type based on firmware command
+ * @hw: pointer to hardware structure
+ *
+ * Returns error code
+ */
+static s32 ixgbe_identify_phy_fw(struct ixgbe_hw *hw)
+{
+       if (hw->bus.lan_id)
+               hw->phy.phy_semaphore_mask = IXGBE_GSSR_PHY1_SM;
+       else
+               hw->phy.phy_semaphore_mask = IXGBE_GSSR_PHY0_SM;
+
+       hw->phy.type = ixgbe_phy_fw;
+       hw->phy.ops.read_reg = NULL;
+       hw->phy.ops.write_reg = NULL;
+       return ixgbe_get_phy_id_fw(hw);
+}
+
+/**
+ * ixgbe_shutdown_fw_phy - Shutdown a firmware-controlled PHY
+ * @hw: pointer to hardware structure
+ *
+ * Returns error code
+ */
+s32 ixgbe_shutdown_fw_phy(struct ixgbe_hw *hw)
+{
+       u32 setup[FW_PHY_ACT_DATA_COUNT] = { 0 };
+
+       setup[0] = FW_PHY_ACT_FORCE_LINK_DOWN_OFF;
+       return ixgbe_fw_phy_activity(hw, FW_PHY_ACT_FORCE_LINK_DOWN, &setup);
+}
+
 STATIC s32 ixgbe_read_phy_reg_x550em(struct ixgbe_hw *hw, u32 reg_addr,
                                     u32 device_type, u16 *phy_data)
 {
@@ -603,18 +625,25 @@ s32 ixgbe_init_ops_X550EM(struct ixgbe_hw *hw)
        else
                mac->ops.setup_fc = ixgbe_setup_fc_X550em;
 
+       /* PHY */
+       phy->ops.init = ixgbe_init_phy_ops_X550em;
        switch (hw->device_id) {
-       case IXGBE_DEV_ID_X550EM_X_KR:
-       case IXGBE_DEV_ID_X550EM_A_KR:
-       case IXGBE_DEV_ID_X550EM_A_KR_L:
+       case IXGBE_DEV_ID_X550EM_A_1G_T:
+       case IXGBE_DEV_ID_X550EM_A_1G_T_L:
+               mac->ops.setup_fc = NULL;
+               phy->ops.identify = ixgbe_identify_phy_fw;
+               phy->ops.set_phy_power = NULL;
+               phy->ops.get_firmware_version = NULL;
+               break;
+       case IXGBE_DEV_ID_X550EM_X_1G_T:
+               mac->ops.setup_fc = NULL;
+               phy->ops.identify = ixgbe_identify_phy_x550em;
+               phy->ops.set_phy_power = NULL;
                break;
        default:
-               mac->ops.setup_eee = NULL;
+               phy->ops.identify = ixgbe_identify_phy_x550em;
        }
 
-       /* PHY */
-       phy->ops.init = ixgbe_init_phy_ops_X550em;
-       phy->ops.identify = ixgbe_identify_phy_x550em;
        if (mac->ops.get_media_type(hw) != ixgbe_media_type_copper)
                phy->ops.set_phy_power = NULL;
 
@@ -632,6 +661,92 @@ s32 ixgbe_init_ops_X550EM(struct ixgbe_hw *hw)
        return ret_val;
 }
 
+/**
+ * ixgbe_setup_fw_link - Setup firmware-controlled PHYs
+ * @hw: pointer to hardware structure
+ */
+static s32 ixgbe_setup_fw_link(struct ixgbe_hw *hw)
+{
+       u32 setup[FW_PHY_ACT_DATA_COUNT] = { 0 };
+       s32 rc;
+       u16 i;
+
+       if (hw->phy.reset_disable || ixgbe_check_reset_blocked(hw))
+               return 0;
+
+       if (hw->fc.strict_ieee && hw->fc.requested_mode == ixgbe_fc_rx_pause) {
+               ERROR_REPORT1(IXGBE_ERROR_UNSUPPORTED,
+                             "ixgbe_fc_rx_pause not valid in strict IEEE mode\n");
+               return IXGBE_ERR_INVALID_LINK_SETTINGS;
+       }
+
+       switch (hw->fc.requested_mode) {
+       case ixgbe_fc_full:
+               setup[0] |= FW_PHY_ACT_SETUP_LINK_PAUSE_RXTX <<
+                           FW_PHY_ACT_SETUP_LINK_PAUSE_SHIFT;
+               break;
+       case ixgbe_fc_rx_pause:
+               setup[0] |= FW_PHY_ACT_SETUP_LINK_PAUSE_RX <<
+                           FW_PHY_ACT_SETUP_LINK_PAUSE_SHIFT;
+               break;
+       case ixgbe_fc_tx_pause:
+               setup[0] |= FW_PHY_ACT_SETUP_LINK_PAUSE_TX <<
+                           FW_PHY_ACT_SETUP_LINK_PAUSE_SHIFT;
+               break;
+       default:
+               break;
+       }
+
+       for (i = 0; i < sizeof(ixgbe_fw_map) / sizeof(ixgbe_fw_map[0]); ++i) {
+               if (hw->phy.autoneg_advertised & ixgbe_fw_map[i].phy_speed)
+                       setup[0] |= (u32)(ixgbe_fw_map[i].fw_speed);
+       }
+       setup[0] |= FW_PHY_ACT_SETUP_LINK_HP | FW_PHY_ACT_SETUP_LINK_AN;
+
+       if (hw->phy.eee_speeds_advertised)
+               setup[0] |= FW_PHY_ACT_SETUP_LINK_EEE;
+
+       rc = ixgbe_fw_phy_activity(hw, FW_PHY_ACT_SETUP_LINK, &setup);
+       if (rc)
+               return rc;
+       if (setup[0] == FW_PHY_ACT_SETUP_LINK_RSP_DOWN)
+               return IXGBE_ERR_OVERTEMP;
+       return IXGBE_SUCCESS;
+}
+
+/**
+ * ixgbe_fc_autoneg_fw _ Set up flow control for FW-controlled PHYs
+ * @hw: pointer to hardware structure
+ *
+ * Called at init time to set up flow control.
+ */
+static s32 ixgbe_fc_autoneg_fw(struct ixgbe_hw *hw)
+{
+       if (hw->fc.requested_mode == ixgbe_fc_default)
+               hw->fc.requested_mode = ixgbe_fc_full;
+
+       return ixgbe_setup_fw_link(hw);
+}
+
+/**
+ * ixgbe_setup_eee_fw - Enable/disable EEE support
+ * @hw: pointer to the HW structure
+ * @enable_eee: boolean flag to enable EEE
+ *
+ * Enable/disable EEE based on enable_eee flag.
+ * This function controls EEE for firmware-based PHY implementations.
+ */
+static s32 ixgbe_setup_eee_fw(struct ixgbe_hw *hw, bool enable_eee)
+{
+       if (!!hw->phy.eee_speeds_advertised == enable_eee)
+               return IXGBE_SUCCESS;
+       if (enable_eee)
+               hw->phy.eee_speeds_advertised = hw->phy.eee_speeds_supported;
+       else
+               hw->phy.eee_speeds_advertised = 0;
+       return hw->phy.ops.setup_link(hw);
+}
+
 /**
 *  ixgbe_init_ops_X550EM_a - Inits func ptrs and MAC type
 *  @hw: pointer to hardware structure
@@ -673,10 +788,18 @@ s32 ixgbe_init_ops_X550EM_a(struct ixgbe_hw *hw)
                break;
        }
 
-       if ((hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T) ||
-               (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L)) {
+       switch (hw->device_id) {
+       case IXGBE_DEV_ID_X550EM_A_1G_T:
+       case IXGBE_DEV_ID_X550EM_A_1G_T_L:
                mac->ops.fc_autoneg = ixgbe_fc_autoneg_sgmii_x550em_a;
-               mac->ops.setup_fc = ixgbe_setup_fc_sgmii_x550em_a;
+               mac->ops.setup_fc = ixgbe_fc_autoneg_fw;
+               mac->ops.setup_eee = ixgbe_setup_eee_fw;
+               hw->phy.eee_speeds_supported = IXGBE_LINK_SPEED_100_FULL |
+                                              IXGBE_LINK_SPEED_1GB_FULL;
+               hw->phy.eee_speeds_advertised = hw->phy.eee_speeds_supported;
+               break;
+       default:
+               break;
        }
 
        return ret_val;
@@ -711,15 +834,21 @@ s32 ixgbe_init_ops_X550EM_x(struct ixgbe_hw *hw)
                                      ixgbe_write_i2c_combined_generic_unlocked;
        link->addr = IXGBE_CS4227;
 
+       if (hw->device_id == IXGBE_DEV_ID_X550EM_X_1G_T) {
+               mac->ops.setup_fc = NULL;
+               mac->ops.setup_eee = NULL;
+               mac->ops.init_led_link_act = NULL;
+       }
+
        return ret_val;
 }
 
 /**
- *  ixgbe_dmac_config_X550
- *  @hw: pointer to hardware structure
+ * ixgbe_dmac_config_X550
+ * @hw: pointer to hardware structure
  *
- *  Configure DMA coalescing. If enabling dmac, dmac is activated.
- *  When disabling dmac, dmac enable dmac bit is cleared.
+ * Configure DMA coalescing. If enabling dmac, dmac is activated.
+ * When disabling dmac, dmac enable dmac bit is cleared.
  **/
 s32 ixgbe_dmac_config_X550(struct ixgbe_hw *hw)
 {
@@ -763,11 +892,11 @@ out:
 }
 
 /**
- *  ixgbe_dmac_config_tcs_X550
- *  @hw: pointer to hardware structure
+ * ixgbe_dmac_config_tcs_X550
+ * @hw: pointer to hardware structure
  *
- *  Configure DMA coalescing threshold per TC. The dmac enable bit must
- *  be cleared before configuring.
+ * Configure DMA coalescing threshold per TC. The dmac enable bit must
+ * be cleared before configuring.
  **/
 s32 ixgbe_dmac_config_tcs_X550(struct ixgbe_hw *hw)
 {
@@ -819,10 +948,10 @@ s32 ixgbe_dmac_config_tcs_X550(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_dmac_update_tcs_X550
- *  @hw: pointer to hardware structure
+ * ixgbe_dmac_update_tcs_X550
+ * @hw: pointer to hardware structure
  *
- *  Disables dmac, updates per TC settings, and then enables dmac.
+ * Disables dmac, updates per TC settings, and then enables dmac.
  **/
 s32 ixgbe_dmac_update_tcs_X550(struct ixgbe_hw *hw)
 {
@@ -846,11 +975,11 @@ s32 ixgbe_dmac_update_tcs_X550(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_init_eeprom_params_X550 - Initialize EEPROM params
- *  @hw: pointer to hardware structure
+ * ixgbe_init_eeprom_params_X550 - Initialize EEPROM params
+ * @hw: pointer to hardware structure
  *
- *  Initializes the EEPROM parameters ixgbe_eeprom_info within the
- *  ixgbe_hw struct in order to set up EEPROM access.
+ * Initializes the EEPROM parameters ixgbe_eeprom_info within the
+ * ixgbe_hw struct in order to set up EEPROM access.
  **/
 s32 ixgbe_init_eeprom_params_X550(struct ixgbe_hw *hw)
 {
@@ -877,159 +1006,6 @@ s32 ixgbe_init_eeprom_params_X550(struct ixgbe_hw *hw)
        return IXGBE_SUCCESS;
 }
 
-/**
- * ixgbe_enable_eee_x550 - Enable EEE support
- * @hw: pointer to hardware structure
- */
-STATIC s32 ixgbe_enable_eee_x550(struct ixgbe_hw *hw)
-{
-       u16 autoneg_eee_reg;
-       u32 link_reg;
-       s32 status;
-
-       if (hw->mac.type == ixgbe_mac_X550) {
-               /* Advertise EEE capability */
-               hw->phy.ops.read_reg(hw, IXGBE_MDIO_AUTO_NEG_EEE_ADVT,
-                                    IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
-                                    &autoneg_eee_reg);
-
-               autoneg_eee_reg |= (IXGBE_AUTO_NEG_10GBASE_EEE_ADVT |
-                                   IXGBE_AUTO_NEG_1000BASE_EEE_ADVT |
-                                   IXGBE_AUTO_NEG_100BASE_EEE_ADVT);
-
-               hw->phy.ops.write_reg(hw, IXGBE_MDIO_AUTO_NEG_EEE_ADVT,
-                                     IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
-                                     autoneg_eee_reg);
-               return IXGBE_SUCCESS;
-       }
-
-       switch (hw->device_id) {
-       case IXGBE_DEV_ID_X550EM_X_KR:
-       case IXGBE_DEV_ID_X550EM_A_KR:
-       case IXGBE_DEV_ID_X550EM_A_KR_L:
-               status = hw->mac.ops.read_iosf_sb_reg(hw,
-                                       IXGBE_KRM_LINK_CTRL_1(hw->bus.lan_id),
-                                       IXGBE_SB_IOSF_TARGET_KR_PHY, &link_reg);
-               if (status != IXGBE_SUCCESS)
-                       return status;
-
-               link_reg |= IXGBE_KRM_LINK_CTRL_1_TETH_EEE_CAP_KR |
-                           IXGBE_KRM_LINK_CTRL_1_TETH_EEE_CAP_KX;
-
-               /* Don't advertise FEC capability when EEE enabled. */
-               link_reg &= ~IXGBE_KRM_LINK_CTRL_1_TETH_AN_CAP_FEC;
-
-               status = hw->mac.ops.write_iosf_sb_reg(hw,
-                                       IXGBE_KRM_LINK_CTRL_1(hw->bus.lan_id),
-                                       IXGBE_SB_IOSF_TARGET_KR_PHY, link_reg);
-               if (status != IXGBE_SUCCESS)
-                       return status;
-               break;
-       default:
-               break;
-       }
-
-       return IXGBE_SUCCESS;
-}
-
-/**
- * ixgbe_disable_eee_x550 - Disable EEE support
- * @hw: pointer to hardware structure
- */
-STATIC s32 ixgbe_disable_eee_x550(struct ixgbe_hw *hw)
-{
-       u16 autoneg_eee_reg;
-       u32 link_reg;
-       s32 status;
-
-       if (hw->mac.type == ixgbe_mac_X550) {
-               /* Disable advertised EEE capability */
-               hw->phy.ops.read_reg(hw, IXGBE_MDIO_AUTO_NEG_EEE_ADVT,
-                                    IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
-                                    &autoneg_eee_reg);
-
-               autoneg_eee_reg &= ~(IXGBE_AUTO_NEG_10GBASE_EEE_ADVT |
-                                    IXGBE_AUTO_NEG_1000BASE_EEE_ADVT |
-                                    IXGBE_AUTO_NEG_100BASE_EEE_ADVT);
-
-               hw->phy.ops.write_reg(hw, IXGBE_MDIO_AUTO_NEG_EEE_ADVT,
-                                     IXGBE_MDIO_AUTO_NEG_DEV_TYPE,
-                                     autoneg_eee_reg);
-               return IXGBE_SUCCESS;
-       }
-
-       switch (hw->device_id) {
-       case IXGBE_DEV_ID_X550EM_X_KR:
-       case IXGBE_DEV_ID_X550EM_A_KR:
-       case IXGBE_DEV_ID_X550EM_A_KR_L:
-               status = hw->mac.ops.read_iosf_sb_reg(hw,
-                                       IXGBE_KRM_LINK_CTRL_1(hw->bus.lan_id),
-                                       IXGBE_SB_IOSF_TARGET_KR_PHY, &link_reg);
-               if (status != IXGBE_SUCCESS)
-                       return status;
-
-               link_reg &= ~(IXGBE_KRM_LINK_CTRL_1_TETH_EEE_CAP_KR |
-                             IXGBE_KRM_LINK_CTRL_1_TETH_EEE_CAP_KX);
-
-               /* Advertise FEC capability when EEE is disabled. */
-               link_reg |= IXGBE_KRM_LINK_CTRL_1_TETH_AN_CAP_FEC;
-
-               status = hw->mac.ops.write_iosf_sb_reg(hw,
-                                       IXGBE_KRM_LINK_CTRL_1(hw->bus.lan_id),
-                                       IXGBE_SB_IOSF_TARGET_KR_PHY, link_reg);
-               if (status != IXGBE_SUCCESS)
-                       return status;
-               break;
-       default:
-               break;
-       }
-
-       return IXGBE_SUCCESS;
-}
-
-/**
- *  ixgbe_setup_eee_X550 - Enable/disable EEE support
- *  @hw: pointer to the HW structure
- *  @enable_eee: boolean flag to enable EEE
- *
- *  Enable/disable EEE based on enable_eee flag.
- *  Auto-negotiation must be started after BASE-T EEE bits in PHY register 7.3C
- *  are modified.
- *
- **/
-s32 ixgbe_setup_eee_X550(struct ixgbe_hw *hw, bool enable_eee)
-{
-       s32 status;
-       u32 eeer;
-
-       DEBUGFUNC("ixgbe_setup_eee_X550");
-
-       eeer = IXGBE_READ_REG(hw, IXGBE_EEER);
-       /* Enable or disable EEE per flag */
-       if (enable_eee) {
-               eeer |= (IXGBE_EEER_TX_LPI_EN | IXGBE_EEER_RX_LPI_EN);
-
-               /* Not supported on first revision of X550EM_x. */
-               if ((hw->mac.type == ixgbe_mac_X550EM_x) &&
-                   !(IXGBE_FUSES0_REV_MASK &
-                     IXGBE_READ_REG(hw, IXGBE_FUSES0_GROUP(0))))
-                       return IXGBE_SUCCESS;
-
-               status = ixgbe_enable_eee_x550(hw);
-               if (status)
-                       return status;
-       } else {
-               eeer &= ~(IXGBE_EEER_TX_LPI_EN | IXGBE_EEER_RX_LPI_EN);
-
-               status = ixgbe_disable_eee_x550(hw);
-               if (status)
-                       return status;
-       }
-       IXGBE_WRITE_REG(hw, IXGBE_EEER, eeer);
-
-       return IXGBE_SUCCESS;
-}
-
 /**
  * ixgbe_set_source_address_pruning_X550 - Enable/Disbale source address pruning
  * @hw: pointer to hardware structure
@@ -1058,10 +1034,10 @@ void ixgbe_set_source_address_pruning_X550(struct ixgbe_hw *hw, bool enable,
 }
 
 /**
- *  ixgbe_set_ethertype_anti_spoofing_X550 - Enable/Disable Ethertype anti-spoofing
- *  @hw: pointer to hardware structure
- *  @enable: enable or disable switch for Ethertype anti-spoofing
- *  @vf: Virtual Function pool - VF Pool to set for Ethertype anti-spoofing
+ * ixgbe_set_ethertype_anti_spoofing_X550 - Configure Ethertype anti-spoofing
+ * @hw: pointer to hardware structure
+ * @enable: enable or disable switch for Ethertype anti-spoofing
+ * @vf: Virtual Function pool - VF Pool to set for Ethertype anti-spoofing
  *
  **/
 void ixgbe_set_ethertype_anti_spoofing_X550(struct ixgbe_hw *hw,
@@ -1116,12 +1092,12 @@ STATIC s32 ixgbe_iosf_wait(struct ixgbe_hw *hw, u32 *ctrl)
 }
 
 /**
- *  ixgbe_write_iosf_sb_reg_x550 - Writes a value to specified register
- *  of the IOSF device
- *  @hw: pointer to hardware structure
- *  @reg_addr: 32 bit PHY register to write
- *  @device_type: 3 bit device type
- *  @data: Data to write to the register
+ * ixgbe_write_iosf_sb_reg_x550 - Writes a value to specified register
+ * of the IOSF device
+ * @hw: pointer to hardware structure
+ * @reg_addr: 32 bit PHY register to write
+ * @device_type: 3 bit device type
+ * @data: Data to write to the register
  **/
 s32 ixgbe_write_iosf_sb_reg_x550(struct ixgbe_hw *hw, u32 reg_addr,
                            u32 device_type, u32 data)
@@ -1163,11 +1139,11 @@ out:
 }
 
 /**
- *  ixgbe_read_iosf_sb_reg_x550 - Reads specified register of the IOSF device
- *  @hw: pointer to hardware structure
- *  @reg_addr: 32 bit PHY register to write
- *  @device_type: 3 bit device type
- *  @data: Pointer to read data from the register
+ * ixgbe_read_iosf_sb_reg_x550 - Reads specified register of the IOSF device
+ * @hw: pointer to hardware structure
+ * @reg_addr: 32 bit PHY register to write
+ * @device_type: 3 bit device type
+ * @data: Pointer to read data from the register
  **/
 s32 ixgbe_read_iosf_sb_reg_x550(struct ixgbe_hw *hw, u32 reg_addr,
                           u32 device_type, u32 *data)
@@ -1229,13 +1205,20 @@ s32 ixgbe_get_phy_token(struct ixgbe_hw *hw)
                                              sizeof(token_cmd),
                                              IXGBE_HI_COMMAND_TIMEOUT,
                                              true);
-       if (status)
+       if (status) {
+               DEBUGOUT1("Issuing host interface command failed with Status = %d\n",
+                         status);
                return status;
+       }
        if (token_cmd.hdr.cmd_or_resp.ret_status == FW_PHY_TOKEN_OK)
                return IXGBE_SUCCESS;
-       if (token_cmd.hdr.cmd_or_resp.ret_status != FW_PHY_TOKEN_RETRY)
+       if (token_cmd.hdr.cmd_or_resp.ret_status != FW_PHY_TOKEN_RETRY) {
+               DEBUGOUT1("Host interface command returned 0x%08x , returning IXGBE_ERR_FW_RESP_INVALID\n",
+                         token_cmd.hdr.cmd_or_resp.ret_status);
                return IXGBE_ERR_FW_RESP_INVALID;
+       }
 
+       DEBUGOUT("Returning  IXGBE_ERR_TOKEN_RETRY\n");
        return IXGBE_ERR_TOKEN_RETRY;
 }
 
@@ -1270,12 +1253,12 @@ s32 ixgbe_put_phy_token(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_write_iosf_sb_reg_x550a - Writes a value to specified register
- *  of the IOSF device
- *  @hw: pointer to hardware structure
- *  @reg_addr: 32 bit PHY register to write
- *  @device_type: 3 bit device type
- *  @data: Data to write to the register
+ * ixgbe_write_iosf_sb_reg_x550a - Writes a value to specified register
+ * of the IOSF device
+ * @hw: pointer to hardware structure
+ * @reg_addr: 32 bit PHY register to write
+ * @device_type: 3 bit device type
+ * @data: Data to write to the register
  **/
 s32 ixgbe_write_iosf_sb_reg_x550a(struct ixgbe_hw *hw, u32 reg_addr,
                                  u32 device_type, u32 data)
@@ -1301,11 +1284,11 @@ s32 ixgbe_write_iosf_sb_reg_x550a(struct ixgbe_hw *hw, u32 reg_addr,
 }
 
 /**
- *  ixgbe_read_iosf_sb_reg_x550a - Reads specified register of the IOSF device
- *  @hw: pointer to hardware structure
- *  @reg_addr: 32 bit PHY register to write
- *  @device_type: 3 bit device type
- *  @data: Pointer to read data from the register
+ * ixgbe_read_iosf_sb_reg_x550a - Reads specified register of the IOSF device
+ * @hw: pointer to hardware structure
+ * @reg_addr: 32 bit PHY register to write
+ * @device_type: 3 bit device type
+ * @data: Pointer to read data from the register
  **/
 s32 ixgbe_read_iosf_sb_reg_x550a(struct ixgbe_hw *hw, u32 reg_addr,
                                 u32 device_type, u32 *data)
@@ -1336,10 +1319,10 @@ s32 ixgbe_read_iosf_sb_reg_x550a(struct ixgbe_hw *hw, u32 reg_addr,
 }
 
 /**
- *  ixgbe_disable_mdd_X550
- *  @hw: pointer to hardware structure
+ * ixgbe_disable_mdd_X550
+ * @hw: pointer to hardware structure
  *
- *  Disable malicious driver detection
+ * Disable malicious driver detection
  **/
 void ixgbe_disable_mdd_X550(struct ixgbe_hw *hw)
 {
@@ -1359,10 +1342,10 @@ void ixgbe_disable_mdd_X550(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_enable_mdd_X550
- *  @hw: pointer to hardware structure
+ * ixgbe_enable_mdd_X550
+ * @hw: pointer to hardware structure
  *
- *  Enable malicious driver detection
+ * Enable malicious driver detection
  **/
 void ixgbe_enable_mdd_X550(struct ixgbe_hw *hw)
 {
@@ -1382,11 +1365,11 @@ void ixgbe_enable_mdd_X550(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_restore_mdd_vf_X550
- *  @hw: pointer to hardware structure
- *  @vf: vf index
+ * ixgbe_restore_mdd_vf_X550
+ * @hw: pointer to hardware structure
+ * @vf: vf index
  *
- *  Restore VF that was disabled during malicious driver detection event
+ * Restore VF that was disabled during malicious driver detection event
  **/
 void ixgbe_restore_mdd_vf_X550(struct ixgbe_hw *hw, u32 vf)
 {
@@ -1422,11 +1405,11 @@ void ixgbe_restore_mdd_vf_X550(struct ixgbe_hw *hw, u32 vf)
 }
 
 /**
- *  ixgbe_mdd_event_X550
- *  @hw: pointer to hardware structure
- *  @vf_bitmap: vf bitmap of malicious vfs
+ * ixgbe_mdd_event_X550
+ * @hw: pointer to hardware structure
+ * @vf_bitmap: vf bitmap of malicious vfs
  *
- *  Handle malicious driver detection event.
+ * Handle malicious driver detection event.
  **/
 void ixgbe_mdd_event_X550(struct ixgbe_hw *hw, u32 *vf_bitmap)
 {
@@ -1479,10 +1462,10 @@ void ixgbe_mdd_event_X550(struct ixgbe_hw *hw, u32 *vf_bitmap)
 }
 
 /**
- *  ixgbe_get_media_type_X550em - Get media type
- *  @hw: pointer to hardware structure
+ * ixgbe_get_media_type_X550em - Get media type
+ * @hw: pointer to hardware structure
  *
- *  Returns the media type (fiber, copper, backplane)
+ * Returns the media type (fiber, copper, backplane)
  */
 enum ixgbe_media_type ixgbe_get_media_type_X550em(struct ixgbe_hw *hw)
 {
@@ -1494,6 +1477,7 @@ enum ixgbe_media_type ixgbe_get_media_type_X550em(struct ixgbe_hw *hw)
        switch (hw->device_id) {
        case IXGBE_DEV_ID_X550EM_X_KR:
        case IXGBE_DEV_ID_X550EM_X_KX4:
+       case IXGBE_DEV_ID_X550EM_X_XFI:
        case IXGBE_DEV_ID_X550EM_A_KR:
        case IXGBE_DEV_ID_X550EM_A_KR_L:
                media_type = ixgbe_media_type_backplane;
@@ -1527,9 +1511,9 @@ enum ixgbe_media_type ixgbe_get_media_type_X550em(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_supported_sfp_modules_X550em - Check if SFP module type is supported
- *  @hw: pointer to hardware structure
- *  @linear: true if SFP module is linear
+ * ixgbe_supported_sfp_modules_X550em - Check if SFP module type is supported
+ * @hw: pointer to hardware structure
+ * @linear: true if SFP module is linear
  */
 STATIC s32 ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool *linear)
 {
@@ -1550,6 +1534,8 @@ STATIC s32 ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool *linear)
        case ixgbe_sfp_type_1g_sx_core1:
        case ixgbe_sfp_type_1g_lx_core0:
        case ixgbe_sfp_type_1g_lx_core1:
+       case ixgbe_sfp_type_1g_lha_core0:
+       case ixgbe_sfp_type_1g_lha_core1:
                *linear = false;
                break;
        case ixgbe_sfp_type_unknown:
@@ -1563,10 +1549,10 @@ STATIC s32 ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool *linear)
 }
 
 /**
- *  ixgbe_identify_sfp_module_X550em - Identifies SFP modules
- *  @hw: pointer to hardware structure
+ * ixgbe_identify_sfp_module_X550em - Identifies SFP modules
+ * @hw: pointer to hardware structure
  *
- *  Searches for and identifies the SFP module and assigns appropriate PHY type.
+ * Searches for and identifies the SFP module and assigns appropriate PHY type.
  **/
 s32 ixgbe_identify_sfp_module_X550em(struct ixgbe_hw *hw)
 {
@@ -1587,8 +1573,8 @@ s32 ixgbe_identify_sfp_module_X550em(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_setup_sfp_modules_X550em - Setup MAC link ops
- *  @hw: pointer to hardware structure
+ * ixgbe_setup_sfp_modules_X550em - Setup MAC link ops
+ * @hw: pointer to hardware structure
  */
 s32 ixgbe_setup_sfp_modules_X550em(struct ixgbe_hw *hw)
 {
@@ -1659,6 +1645,8 @@ STATIC s32 ixgbe_restart_an_internal_phy_x550em(struct ixgbe_hw *hw)
 /**
  * ixgbe_setup_sgmii - Set up link for sgmii
  * @hw: pointer to hardware structure
+ * @speed: new link speed
+ * @autoneg_wait: true when waiting for completion is needed
  */
 STATIC s32 ixgbe_setup_sgmii(struct ixgbe_hw *hw, ixgbe_link_speed speed,
                             bool autoneg_wait)
@@ -1724,11 +1712,13 @@ STATIC s32 ixgbe_setup_sgmii(struct ixgbe_hw *hw, ixgbe_link_speed speed,
 }
 
 /**
- * ixgbe_setup_sgmii_m88 - Set up link for sgmii with Marvell PHYs
+ * ixgbe_setup_sgmii_fw - Set up link for internal PHY SGMII auto-negotiation
  * @hw: pointer to hardware structure
+ * @speed: new link speed
+ * @autoneg_wait: true when waiting for completion is needed
  */
-STATIC s32 ixgbe_setup_sgmii_m88(struct ixgbe_hw *hw, ixgbe_link_speed speed,
-                                bool autoneg_wait)
+STATIC s32 ixgbe_setup_sgmii_fw(struct ixgbe_hw *hw, ixgbe_link_speed speed,
+                               bool autoneg_wait)
 {
        struct ixgbe_mac_info *mac = &hw->mac;
        u32 lval, sval, flx_val;
@@ -1795,8 +1785,8 @@ STATIC s32 ixgbe_setup_sgmii_m88(struct ixgbe_hw *hw, ixgbe_link_speed speed,
 }
 
 /**
- *  ixgbe_init_mac_link_ops_X550em - init mac link function pointers
- *  @hw: pointer to hardware structure
+ * ixgbe_init_mac_link_ops_X550em - init mac link function pointers
+ * @hw: pointer to hardware structure
  */
 void ixgbe_init_mac_link_ops_X550em(struct ixgbe_hw *hw)
 {
@@ -1825,10 +1815,14 @@ void ixgbe_init_mac_link_ops_X550em(struct ixgbe_hw *hw)
                                                ixgbe_setup_mac_link_sfp_x550em;
                break;
        case ixgbe_media_type_copper:
+               if (hw->device_id == IXGBE_DEV_ID_X550EM_X_1G_T)
+                       break;
                if (hw->mac.type == ixgbe_mac_X550EM_a) {
                        if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T ||
                            hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L) {
-                               mac->ops.setup_link = ixgbe_setup_sgmii_m88;
+                               mac->ops.setup_link = ixgbe_setup_sgmii_fw;
+                               mac->ops.check_link =
+                                                  ixgbe_check_mac_link_generic;
                        } else {
                                mac->ops.setup_link =
                                                  ixgbe_setup_mac_link_t_X550em;
@@ -1849,10 +1843,10 @@ void ixgbe_init_mac_link_ops_X550em(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_get_link_capabilities_x550em - Determines link capabilities
- *  @hw: pointer to hardware structure
- *  @speed: pointer to link speed
- *  @autoneg: true when autoneg or autotry is enabled
+ * ixgbe_get_link_capabilities_x550em - Determines link capabilities
+ * @hw: pointer to hardware structure
+ * @speed: pointer to link speed
+ * @autoneg: true when autoneg or autotry is enabled
  */
 s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,
                                       ixgbe_link_speed *speed,
@@ -1861,6 +1855,12 @@ s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,
        DEBUGFUNC("ixgbe_get_link_capabilities_X550em");
 
 
+       if (hw->phy.type == ixgbe_phy_fw) {
+               *autoneg = true;
+               *speed = hw->phy.speeds_supported;
+               return 0;
+       }
+
        /* SFP */
        if (hw->phy.media_type == ixgbe_media_type_fiber) {
 
@@ -1870,6 +1870,8 @@ s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,
                /* Check if 1G SFP module. */
                if (hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core0 ||
                    hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core1
+                   || hw->phy.sfp_type == ixgbe_sfp_type_1g_lha_core0 ||
+                   hw->phy.sfp_type == ixgbe_sfp_type_1g_lha_core1
                    || hw->phy.sfp_type == ixgbe_sfp_type_1g_lx_core0 ||
                    hw->phy.sfp_type == ixgbe_sfp_type_1g_lx_core1) {
                        *speed = IXGBE_LINK_SPEED_1GB_FULL;
@@ -1883,12 +1885,15 @@ s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,
                else
                        *speed = IXGBE_LINK_SPEED_10GB_FULL;
        } else {
+               *autoneg = true;
+
                switch (hw->phy.type) {
-               case ixgbe_phy_m88:
+               case ixgbe_phy_x550em_xfi:
                        *speed = IXGBE_LINK_SPEED_1GB_FULL |
-                                IXGBE_LINK_SPEED_100_FULL |
-                                IXGBE_LINK_SPEED_10_FULL;
+                                IXGBE_LINK_SPEED_10GB_FULL;
+                       *autoneg = false;
                        break;
+               case ixgbe_phy_ext_1g_t:
                case ixgbe_phy_sgmii:
                        *speed = IXGBE_LINK_SPEED_1GB_FULL;
                        break;
@@ -1911,7 +1916,6 @@ s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,
                                 IXGBE_LINK_SPEED_1GB_FULL;
                        break;
                }
-               *autoneg = true;
        }
 
        return IXGBE_SUCCESS;
@@ -1921,7 +1925,7 @@ s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw,
  * ixgbe_get_lasi_ext_t_x550em - Determime external Base T PHY interrupt cause
  * @hw: pointer to hardware structure
  * @lsc: pointer to boolean flag which indicates whether external Base T
- *       PHY interrupt is lsc
+ *      PHY interrupt is lsc
  *
  * Determime if external Base T PHY interrupt cause is high temperature
  * failure alarm or link status change.
@@ -2107,11 +2111,11 @@ STATIC s32 ixgbe_enable_lasi_ext_t_x550em(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_setup_kr_speed_x550em - Configure the KR PHY for link speed.
- *  @hw: pointer to hardware structure
- *  @speed: link speed
+ * ixgbe_setup_kr_speed_x550em - Configure the KR PHY for link speed.
+ * @hw: pointer to hardware structure
+ * @speed: link speed
  *
- *  Configures the integrated KR PHY.
+ * Configures the integrated KR PHY.
  **/
 STATIC s32 ixgbe_setup_kr_speed_x550em(struct ixgbe_hw *hw,
                                       ixgbe_link_speed speed)
@@ -2161,274 +2165,59 @@ STATIC s32 ixgbe_setup_kr_speed_x550em(struct ixgbe_hw *hw,
                                    IXGBE_SB_IOSF_TARGET_KR_PHY, reg_val);
        }
 
-       return ixgbe_restart_an_internal_phy_x550em(hw);
-}
-
-/**
- * ixgbe_setup_m88 - setup m88 PHY
- * @hw: pointer to hardware structure
- */
-STATIC s32 ixgbe_setup_m88(struct ixgbe_hw *hw)
-{
-       u32 mask = hw->phy.phy_semaphore_mask | IXGBE_GSSR_TOKEN_SM;
-       u16 reg;
-       s32 rc;
-
-       if (hw->phy.reset_disable || ixgbe_check_reset_blocked(hw))
-               return IXGBE_SUCCESS;
-
-       rc = hw->mac.ops.acquire_swfw_sync(hw, mask);
-       if (rc)
-               return rc;
-
-       rc = hw->phy.ops.read_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0, &reg);
-       if (rc)
-               goto out;
-       if (reg & IXGBE_M88E1500_COPPER_CTRL_POWER_DOWN) {
-               reg &= ~IXGBE_M88E1500_COPPER_CTRL_POWER_DOWN;
-               hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0,
-                                         reg);
-       }
-
-       rc = hw->phy.ops.read_reg_mdi(hw, IXGBE_M88E1500_MAC_CTRL_1, 0, &reg);
-       if (rc)
-               goto out;
-       if (reg & IXGBE_M88E1500_MAC_CTRL_1_POWER_DOWN) {
-               reg &= ~IXGBE_M88E1500_MAC_CTRL_1_POWER_DOWN;
-               hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_MAC_CTRL_1, 0,
-                                         reg);
-       }
-
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0, 2);
-       if (rc)
-               goto out;
-
-       rc = hw->phy.ops.read_reg_mdi(hw, IXGBE_M88E1500_MAC_SPEC_CTRL, 0,
-                                     &reg);
-       if (rc)
-               goto out;
-       if (reg & IXGBE_M88E1500_MAC_SPEC_CTRL_POWER_DOWN) {
-               reg &= ~IXGBE_M88E1500_MAC_SPEC_CTRL_POWER_DOWN;
-               hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_MAC_SPEC_CTRL, 0,
-                                         reg);
-               rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0,
-                                              0);
-               if (rc)
-                       goto out;
-               rc = hw->phy.ops.read_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0,
-                                             &reg);
-               if (rc)
-                       goto out;
-               reg |= IXGBE_M88E1500_COPPER_CTRL_RESET;
-               hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0,
-                                         reg);
-               usec_delay(50);
-       } else {
-               rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0,
-                                              0);
-               if (rc)
-                       goto out;
-       }
-
-       rc = hw->phy.ops.read_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0, &reg);
-       if (rc)
-               goto out;
-
-       if (!(reg & IXGBE_M88E1500_COPPER_CTRL_AN_EN)) {
-               reg |= IXGBE_M88E1500_COPPER_CTRL_AN_EN;
-               hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0,
-                                         reg);
-       }
-
-       rc = hw->phy.ops.read_reg_mdi(hw, IXGBE_M88E1500_1000T_CTRL, 0, &reg);
-       if (rc)
-               goto out;
-       reg &= ~IXGBE_M88E1500_1000T_CTRL_HALF_DUPLEX;
-       reg &= ~IXGBE_M88E1500_1000T_CTRL_FULL_DUPLEX;
-       if (hw->phy.autoneg_advertised & IXGBE_LINK_SPEED_1GB_FULL)
-               reg |= IXGBE_M88E1500_1000T_CTRL_FULL_DUPLEX;
-       hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_1000T_CTRL, 0, reg);
-
-       rc = hw->phy.ops.read_reg_mdi(hw, IXGBE_M88E1500_COPPER_AN, 0, &reg);
-       if (rc)
-               goto out;
-       reg &= ~IXGBE_M88E1500_COPPER_AN_T4;
-       reg &= ~IXGBE_M88E1500_COPPER_AN_100TX_FD;
-       reg &= ~IXGBE_M88E1500_COPPER_AN_100TX_HD;
-       reg &= ~IXGBE_M88E1500_COPPER_AN_10TX_FD;
-       reg &= ~IXGBE_M88E1500_COPPER_AN_10TX_HD;
-
-       /* Flow control auto negotiation configuration was moved from here to
-        * the function ixgbe_setup_fc_sgmii_x550em_a()
-        */
-
-       if (hw->phy.autoneg_advertised & IXGBE_LINK_SPEED_100_FULL)
-               reg |= IXGBE_M88E1500_COPPER_AN_100TX_FD;
-       if (hw->phy.autoneg_advertised & IXGBE_LINK_SPEED_10_FULL)
-               reg |= IXGBE_M88E1500_COPPER_AN_10TX_FD;
-       hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_COPPER_AN, 0, reg);
-
-       rc = hw->phy.ops.read_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0, &reg);
-       if (rc)
-               goto out;
-       reg |= IXGBE_M88E1500_COPPER_CTRL_RESTART_AN;
-       hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0, reg);
-
-
-       hw->mac.ops.release_swfw_sync(hw, mask);
-       return rc;
-
-out:
-       hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0, 0);
-       hw->mac.ops.release_swfw_sync(hw, mask);
-       return rc;
+       return ixgbe_restart_an_internal_phy_x550em(hw);
 }
 
 /**
- * ixgbe_reset_phy_m88e1500 - Reset m88e1500 PHY
+ * ixgbe_reset_phy_fw - Reset firmware-controlled PHYs
  * @hw: pointer to hardware structure
- *
- * The PHY token must be held when calling this function.
  */
-static s32 ixgbe_reset_phy_m88e1500(struct ixgbe_hw *hw)
+static s32 ixgbe_reset_phy_fw(struct ixgbe_hw *hw)
 {
-       u16 reg;
+       u32 store[FW_PHY_ACT_DATA_COUNT] = { 0 };
        s32 rc;
 
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0, 0);
+       if (hw->phy.reset_disable || ixgbe_check_reset_blocked(hw))
+               return IXGBE_SUCCESS;
+
+       rc = ixgbe_fw_phy_activity(hw, FW_PHY_ACT_PHY_SW_RESET, &store);
        if (rc)
                return rc;
+       memset(store, 0, sizeof(store));
 
-       rc = hw->phy.ops.read_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0, &reg);
+       rc = ixgbe_fw_phy_activity(hw, FW_PHY_ACT_INIT_PHY, &store);
        if (rc)
                return rc;
 
-       reg |= IXGBE_M88E1500_COPPER_CTRL_RESET;
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0, reg);
-
-       usec_delay(10);
-
-       return rc;
+       return ixgbe_setup_fw_link(hw);
 }
 
 /**
- * ixgbe_reset_phy_m88e1543 - Reset m88e1543 PHY
- * @hw: pointer to hardware structure
- *
- * The PHY token must be held when calling this function.
- */
-static s32 ixgbe_reset_phy_m88e1543(struct ixgbe_hw *hw)
-{
-       return hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0, 0);
-}
-
-/**
- * ixgbe_reset_phy_m88 - Reset m88 PHY
+ * ixgbe_check_overtemp_fw - Check firmware-controlled PHYs for overtemp
  * @hw: pointer to hardware structure
  */
-STATIC s32 ixgbe_reset_phy_m88(struct ixgbe_hw *hw)
+static s32 ixgbe_check_overtemp_fw(struct ixgbe_hw *hw)
 {
-       u32 mask = hw->phy.phy_semaphore_mask | IXGBE_GSSR_TOKEN_SM;
-       u16 reg;
+       u32 store[FW_PHY_ACT_DATA_COUNT] = { 0 };
        s32 rc;
 
-       if (hw->phy.reset_disable || ixgbe_check_reset_blocked(hw))
-               return IXGBE_SUCCESS;
-
-       rc = hw->mac.ops.acquire_swfw_sync(hw, mask);
+       rc = ixgbe_fw_phy_activity(hw, FW_PHY_ACT_GET_LINK_INFO, &store);
        if (rc)
                return rc;
 
-       switch (hw->phy.id) {
-       case IXGBE_M88E1500_E_PHY_ID:
-               rc = ixgbe_reset_phy_m88e1500(hw);
-               break;
-       case IXGBE_M88E1543_E_PHY_ID:
-               rc = ixgbe_reset_phy_m88e1543(hw);
-               break;
-       default:
-               rc = IXGBE_ERR_PHY;
-               break;
+       if (store[0] & FW_PHY_ACT_GET_LINK_INFO_TEMP) {
+               ixgbe_shutdown_fw_phy(hw);
+               return IXGBE_ERR_OVERTEMP;
        }
-
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0, 1);
-       if (rc)
-               goto out;
-
-       reg = IXGBE_M88E1500_FIBER_CTRL_RESET |
-             IXGBE_M88E1500_FIBER_CTRL_DUPLEX_FULL |
-             IXGBE_M88E1500_FIBER_CTRL_SPEED_MSB;
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_FIBER_CTRL, 0, reg);
-       if (rc)
-               goto out;
-
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0, 18);
-       if (rc)
-               goto out;
-
-       reg = IXGBE_M88E1500_GEN_CTRL_RESET |
-             IXGBE_M88E1500_GEN_CTRL_MODE_SGMII_COPPER;
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_GEN_CTRL, 0, reg);
-       if (rc)
-               goto out;
-
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0, 1);
-       if (rc)
-               goto out;
-
-       reg = IXGBE_M88E1500_FIBER_CTRL_RESET |
-             IXGBE_M88E1500_FIBER_CTRL_AN_EN |
-             IXGBE_M88E1500_FIBER_CTRL_DUPLEX_FULL |
-             IXGBE_M88E1500_FIBER_CTRL_SPEED_MSB;
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_FIBER_CTRL, 0, reg);
-       if (rc)
-               goto out;
-
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0, 0);
-       if (rc)
-               goto out;
-
-       reg = (IXGBE_M88E1500_MAC_CTRL_1_DWN_4X <<
-              IXGBE_M88E1500_MAC_CTRL_1_DWN_SHIFT) |
-             (IXGBE_M88E1500_MAC_CTRL_1_ED_TM <<
-              IXGBE_M88E1500_MAC_CTRL_1_ED_SHIFT) |
-             (IXGBE_M88E1500_MAC_CTRL_1_MDIX_AUTO <<
-              IXGBE_M88E1500_MAC_CTRL_1_MDIX_SHIFT);
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_MAC_CTRL_1, 0, reg);
-       if (rc)
-               goto out;
-
-       reg = IXGBE_M88E1500_COPPER_CTRL_RESET |
-             IXGBE_M88E1500_COPPER_CTRL_AN_EN |
-             IXGBE_M88E1500_COPPER_CTRL_RESTART_AN |
-             IXGBE_M88E1500_COPPER_CTRL_FULL_DUPLEX |
-             IXGBE_M88E1500_COPPER_CTRL_SPEED_MSB;
-       rc = hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_COPPER_CTRL, 0, reg);
-       if (rc)
-               goto out;
-
-       hw->mac.ops.release_swfw_sync(hw, mask);
-
-       /* In case of first reset set advertised speeds to default value */
-       if (!hw->phy.autoneg_advertised)
-               hw->phy.autoneg_advertised = IXGBE_LINK_SPEED_1GB_FULL |
-                                            IXGBE_LINK_SPEED_100_FULL |
-                                            IXGBE_LINK_SPEED_10_FULL;
-
-       return ixgbe_setup_m88(hw);
-
-out:
-       hw->phy.ops.write_reg_mdi(hw, IXGBE_M88E1500_PAGE_ADDR, 0, 0);
-       hw->mac.ops.release_swfw_sync(hw, mask);
-       return rc;
+       return IXGBE_SUCCESS;
 }
 
 /**
- *  ixgbe_read_mng_if_sel_x550em - Read NW_MNG_IF_SEL register
- *  @hw: pointer to hardware structure
+ * ixgbe_read_mng_if_sel_x550em - Read NW_MNG_IF_SEL register
+ * @hw: pointer to hardware structure
  *
- *  Read NW_MNG_IF_SEL register and save field values, and check for valid field
- *  values.
+ * Read NW_MNG_IF_SEL register and save field values, and check for valid field
+ * values.
  **/
 STATIC s32 ixgbe_read_mng_if_sel_x550em(struct ixgbe_hw *hw)
 {
@@ -2451,12 +2240,12 @@ STATIC s32 ixgbe_read_mng_if_sel_x550em(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_init_phy_ops_X550em - PHY/SFP specific init
- *  @hw: pointer to hardware structure
+ * ixgbe_init_phy_ops_X550em - PHY/SFP specific init
+ * @hw: pointer to hardware structure
  *
- *  Initialize any function pointers that were not able to be
- *  set during init_shared_code because the PHY/SFP type was
- *  not known.  Perform the SFP init if necessary.
+ * Initialize any function pointers that were not able to be
+ * set during init_shared_code because the PHY/SFP type was
+ * not known.  Perform the SFP init if necessary.
  */
 s32 ixgbe_init_phy_ops_X550em(struct ixgbe_hw *hw)
 {
@@ -2465,6 +2254,9 @@ s32 ixgbe_init_phy_ops_X550em(struct ixgbe_hw *hw)
 
        DEBUGFUNC("ixgbe_init_phy_ops_X550em");
 
+       hw->mac.ops.set_lan_id(hw);
+       ixgbe_read_mng_if_sel_x550em(hw);
+
        if (hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) {
                phy->phy_semaphore_mask = IXGBE_GSSR_SHARED_I2C_SM;
                ixgbe_setup_mux_ctl(hw);
@@ -2474,10 +2266,11 @@ s32 ixgbe_init_phy_ops_X550em(struct ixgbe_hw *hw)
        switch (hw->device_id) {
        case IXGBE_DEV_ID_X550EM_A_1G_T:
        case IXGBE_DEV_ID_X550EM_A_1G_T_L:
-               phy->ops.read_reg_mdi = ixgbe_read_phy_reg_mdi_22;
-               phy->ops.write_reg_mdi = ixgbe_write_phy_reg_mdi_22;
-               hw->phy.ops.read_reg = ixgbe_read_phy_reg_x550a;
-               hw->phy.ops.write_reg = ixgbe_write_phy_reg_x550a;
+               phy->ops.read_reg_mdi = NULL;
+               phy->ops.write_reg_mdi = NULL;
+               hw->phy.ops.read_reg = NULL;
+               hw->phy.ops.write_reg = NULL;
+               phy->ops.check_overtemp = ixgbe_check_overtemp_fw;
                if (hw->bus.lan_id)
                        hw->phy.phy_semaphore_mask |= IXGBE_GSSR_PHY1_SM;
                else
@@ -2497,13 +2290,17 @@ s32 ixgbe_init_phy_ops_X550em(struct ixgbe_hw *hw)
                /* set up for CS4227 usage */
                hw->phy.phy_semaphore_mask = IXGBE_GSSR_SHARED_I2C_SM;
                break;
+       case IXGBE_DEV_ID_X550EM_X_1G_T:
+               phy->ops.read_reg_mdi = NULL;
+               phy->ops.write_reg_mdi = NULL;
        default:
                break;
        }
 
        /* Identify the PHY or SFP module */
        ret_val = phy->ops.identify(hw);
-       if (ret_val == IXGBE_ERR_SFP_NOT_SUPPORTED)
+       if (ret_val == IXGBE_ERR_SFP_NOT_SUPPORTED ||
+           ret_val == IXGBE_ERR_PHY_ADDR_INVALID)
                return ret_val;
 
        /* Setup function pointers based on detected hardware */
@@ -2523,6 +2320,17 @@ s32 ixgbe_init_phy_ops_X550em(struct ixgbe_hw *hw)
                phy->ops.read_reg = ixgbe_read_phy_reg_x550em;
                phy->ops.write_reg = ixgbe_write_phy_reg_x550em;
                break;
+       case ixgbe_phy_ext_1g_t:
+               /* link is managed by FW */
+               phy->ops.setup_link = NULL;
+               phy->ops.reset = NULL;
+               break;
+       case ixgbe_phy_x550em_xfi:
+               /* link is managed by HW */
+               phy->ops.setup_link = NULL;
+               phy->ops.read_reg = ixgbe_read_phy_reg_x550em;
+               phy->ops.write_reg = ixgbe_write_phy_reg_x550em;
+               break;
        case ixgbe_phy_x550em_ext_t:
                /* If internal link mode is XFI, then setup iXFI internal link,
                 * else setup KR now.
@@ -2542,9 +2350,9 @@ s32 ixgbe_init_phy_ops_X550em(struct ixgbe_hw *hw)
        case ixgbe_phy_sgmii:
                phy->ops.setup_link = NULL;
                break;
-       case ixgbe_phy_m88:
-               phy->ops.setup_link = ixgbe_setup_m88;
-               phy->ops.reset = ixgbe_reset_phy_m88;
+       case ixgbe_phy_fw:
+               phy->ops.setup_link = ixgbe_setup_fw_link;
+               phy->ops.reset = ixgbe_reset_phy_fw;
                break;
        default:
                break;
@@ -2554,7 +2362,7 @@ s32 ixgbe_init_phy_ops_X550em(struct ixgbe_hw *hw)
 
 /**
  * ixgbe_set_mdio_speed - Set MDIO clock speed
- *  @hw: pointer to hardware structure
+ * @hw: pointer to hardware structure
  */
 STATIC void ixgbe_set_mdio_speed(struct ixgbe_hw *hw)
 {
@@ -2585,12 +2393,12 @@ STATIC void ixgbe_set_mdio_speed(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_reset_hw_X550em - Perform hardware reset
- *  @hw: pointer to hardware structure
+ * ixgbe_reset_hw_X550em - Perform hardware reset
+ * @hw: pointer to hardware structure
  *
- *  Resets the hardware by resetting the transmit and receive units, masks
- *  and clears all interrupts, perform a PHY reset, and perform a link (MAC)
- *  reset.
+ * Resets the hardware by resetting the transmit and receive units, masks
+ * and clears all interrupts, perform a PHY reset, and perform a link (MAC)
+ * reset.
  */
 s32 ixgbe_reset_hw_X550em(struct ixgbe_hw *hw)
 {
@@ -2599,14 +2407,16 @@ s32 ixgbe_reset_hw_X550em(struct ixgbe_hw *hw)
        u32 ctrl = 0;
        u32 i;
        bool link_up = false;
+       u32 swfw_mask = hw->phy.phy_semaphore_mask;
 
        DEBUGFUNC("ixgbe_reset_hw_X550em");
 
        /* Call adapter stop to disable Tx/Rx and clear interrupts */
        status = hw->mac.ops.stop_adapter(hw);
-       if (status != IXGBE_SUCCESS)
+       if (status != IXGBE_SUCCESS) {
+               DEBUGOUT1("Failed to stop adapter, STATUS = %d\n", status);
                return status;
-
+       }
        /* flush pending Tx transactions */
        ixgbe_clear_tx_pending(hw);
 
@@ -2615,14 +2425,24 @@ s32 ixgbe_reset_hw_X550em(struct ixgbe_hw *hw)
        /* PHY ops must be identified and initialized prior to reset */
        status = hw->phy.ops.init(hw);
 
-       if (status == IXGBE_ERR_SFP_NOT_SUPPORTED)
+       if (status)
+               DEBUGOUT1("Failed to initialize PHY ops, STATUS = %d\n",
+                         status);
+
+       if (status == IXGBE_ERR_SFP_NOT_SUPPORTED ||
+           status == IXGBE_ERR_PHY_ADDR_INVALID) {
+               DEBUGOUT("Returning from reset HW due to PHY init failure\n");
                return status;
+       }
 
        /* start the external PHY */
        if (hw->phy.type == ixgbe_phy_x550em_ext_t) {
                status = ixgbe_init_ext_t_x550em(hw);
-               if (status)
+               if (status) {
+                       DEBUGOUT1("Failed to start the external PHY, STATUS = %d\n",
+                                 status);
                        return status;
+               }
        }
 
        /* Setup SFP module if there is one present. */
@@ -2635,8 +2455,10 @@ s32 ixgbe_reset_hw_X550em(struct ixgbe_hw *hw)
                return status;
 
        /* Reset PHY */
-       if (!hw->phy.reset_disable && hw->phy.ops.reset)
-               hw->phy.ops.reset(hw);
+       if (!hw->phy.reset_disable && hw->phy.ops.reset) {
+               if (hw->phy.ops.reset(hw) == IXGBE_ERR_OVERTEMP)
+                       return IXGBE_ERR_OVERTEMP;
+       }
 
 mac_reset_top:
        /* Issue global reset to the MAC.  Needs to be SW reset if link is up.
@@ -2651,9 +2473,16 @@ mac_reset_top:
                        ctrl = IXGBE_CTRL_RST;
        }
 
+       status = hw->mac.ops.acquire_swfw_sync(hw, swfw_mask);
+       if (status != IXGBE_SUCCESS) {
+               ERROR_REPORT2(IXGBE_ERROR_CAUTION,
+                       "semaphore failed with %d", status);
+               return IXGBE_ERR_SWFW_SYNC;
+       }
        ctrl |= IXGBE_READ_REG(hw, IXGBE_CTRL);
        IXGBE_WRITE_REG(hw, IXGBE_CTRL, ctrl);
        IXGBE_WRITE_FLUSH(hw);
+       hw->mac.ops.release_swfw_sync(hw, swfw_mask);
 
        /* Poll for reset bit to self-clear meaning reset is complete */
        for (i = 0; i < 10; i++) {
@@ -2694,6 +2523,9 @@ mac_reset_top:
        if (hw->device_id == IXGBE_DEV_ID_X550EM_X_SFP)
                ixgbe_setup_mux_ctl(hw);
 
+       if (status != IXGBE_SUCCESS)
+               DEBUGOUT1("Reset HW failed, STATUS = %d\n", status);
+
        return status;
 }
 
@@ -2741,24 +2573,28 @@ s32 ixgbe_init_ext_t_x550em(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_setup_kr_x550em - Configure the KR PHY.
- *  @hw: pointer to hardware structure
- *
- *  Configures the integrated KR PHY for X550EM_x.
+ * ixgbe_setup_kr_x550em - Configure the KR PHY.
+ * @hw: pointer to hardware structure
  **/
 s32 ixgbe_setup_kr_x550em(struct ixgbe_hw *hw)
 {
-       if (hw->mac.type != ixgbe_mac_X550EM_x)
+       /* leave link alone for 2.5G */
+       if (hw->phy.autoneg_advertised & IXGBE_LINK_SPEED_2_5GB_FULL)
                return IXGBE_SUCCESS;
 
+       if (ixgbe_check_reset_blocked(hw))
+               return 0;
+
        return ixgbe_setup_kr_speed_x550em(hw, hw->phy.autoneg_advertised);
 }
 
 /**
- *  ixgbe_setup_mac_link_sfp_x550em - Setup internal/external the PHY for SFP
- *  @hw: pointer to hardware structure
+ * ixgbe_setup_mac_link_sfp_x550em - Setup internal/external the PHY for SFP
+ * @hw: pointer to hardware structure
+ * @speed: new link speed
+ * @autoneg_wait_to_complete: unused
  *
- *  Configure the external PHY and the integrated KR PHY for SFP support.
+ * Configure the external PHY and the integrated KR PHY for SFP support.
  **/
 s32 ixgbe_setup_mac_link_sfp_x550em(struct ixgbe_hw *hw,
                                    ixgbe_link_speed speed,
@@ -2782,63 +2618,28 @@ s32 ixgbe_setup_mac_link_sfp_x550em(struct ixgbe_hw *hw,
        if (ret_val != IXGBE_SUCCESS)
                return ret_val;
 
-       if (!(hw->phy.nw_mng_if_sel & IXGBE_NW_MNG_IF_SEL_INT_PHY_MODE)) {
-               /* Configure CS4227 LINE side to 10G SR. */
-               reg_slice = IXGBE_CS4227_LINE_SPARE22_MSB +
-                           (hw->bus.lan_id << 12);
-               reg_val = IXGBE_CS4227_SPEED_10G;
-               ret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,
-                                                 reg_val);
+       /* Configure internal PHY for KR/KX. */
+       ixgbe_setup_kr_speed_x550em(hw, speed);
 
-               reg_slice = IXGBE_CS4227_LINE_SPARE24_LSB +
-                           (hw->bus.lan_id << 12);
+       /* Configure CS4227 LINE side to proper mode. */
+       reg_slice = IXGBE_CS4227_LINE_SPARE24_LSB +
+                   (hw->bus.lan_id << 12);
+       if (setup_linear)
+               reg_val = (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 0x1;
+       else
                reg_val = (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;
-               ret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,
-                                                 reg_val);
-
-               /* Configure CS4227 for HOST connection rate then type. */
-               reg_slice = IXGBE_CS4227_HOST_SPARE22_MSB +
-                           (hw->bus.lan_id << 12);
-               reg_val = (speed & IXGBE_LINK_SPEED_10GB_FULL) ?
-               IXGBE_CS4227_SPEED_10G : IXGBE_CS4227_SPEED_1G;
-               ret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,
-                                                 reg_val);
-
-               reg_slice = IXGBE_CS4227_HOST_SPARE24_LSB +
-                           (hw->bus.lan_id << 12);
-               if (setup_linear)
-                       reg_val = (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 0x1;
-               else
-                       reg_val = (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;
-               ret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,
-                                                 reg_val);
-
-               /* Setup XFI internal link. */
-               ret_val = ixgbe_setup_ixfi_x550em(hw, &speed);
-       } else {
-               /* Configure internal PHY for KR/KX. */
-               ixgbe_setup_kr_speed_x550em(hw, speed);
-
-               /* Configure CS4227 LINE side to proper mode. */
-               reg_slice = IXGBE_CS4227_LINE_SPARE24_LSB +
-                           (hw->bus.lan_id << 12);
-               if (setup_linear)
-                       reg_val = (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 0x1;
-               else
-                       reg_val = (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;
-               ret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,
-                                                 reg_val);
-       }
+       ret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice,
+                                         reg_val);
        return ret_val;
 }
 
 /**
- *  ixgbe_setup_sfi_x550a - Configure the internal PHY for native SFI mode
- *  @hw: pointer to hardware structure
- *  @speed: the link speed to force
+ * ixgbe_setup_sfi_x550a - Configure the internal PHY for native SFI mode
+ * @hw: pointer to hardware structure
+ * @speed: the link speed to force
  *
- *  Configures the integrated PHY for native SFI mode. Used to connect the
- *  internal PHY directly to an SFP cage, without autonegotiation.
+ * Configures the integrated PHY for native SFI mode. Used to connect the
+ * internal PHY directly to an SFP cage, without autonegotiation.
  **/
 STATIC s32 ixgbe_setup_sfi_x550a(struct ixgbe_hw *hw, ixgbe_link_speed *speed)
 {
@@ -2882,10 +2683,12 @@ STATIC s32 ixgbe_setup_sfi_x550a(struct ixgbe_hw *hw, ixgbe_link_speed *speed)
 }
 
 /**
- *  ixgbe_setup_mac_link_sfp_x550a - Setup internal PHY for SFP
- *  @hw: pointer to hardware structure
+ * ixgbe_setup_mac_link_sfp_x550a - Setup internal PHY for SFP
+ * @hw: pointer to hardware structure
+ * @speed: new link speed
+ * @autoneg_wait_to_complete: unused
  *
- *  Configure the the integrated PHY for SFP support.
+ * Configure the integrated PHY for SFP support.
  **/
 s32 ixgbe_setup_mac_link_sfp_x550a(struct ixgbe_hw *hw,
                                    ixgbe_link_speed speed,
@@ -2960,21 +2763,35 @@ s32 ixgbe_setup_mac_link_sfp_x550a(struct ixgbe_hw *hw,
 
                /* Configure CS4227/CS4223 LINE side to proper mode. */
                reg_slice = IXGBE_CS4227_LINE_SPARE24_LSB + slice_offset;
+
+               ret_val = hw->phy.ops.read_reg(hw, reg_slice,
+                                       IXGBE_MDIO_ZERO_DEV_TYPE, &reg_phy_ext);
+
+               if (ret_val != IXGBE_SUCCESS)
+                       return ret_val;
+
+               reg_phy_ext &= ~((IXGBE_CS4227_EDC_MODE_CX1 << 1) |
+                                (IXGBE_CS4227_EDC_MODE_SR << 1));
+
                if (setup_linear)
-                       reg_phy_ext = (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 0x1;
+                       reg_phy_ext |= (IXGBE_CS4227_EDC_MODE_CX1 << 1) | 0x1;
                else
-                       reg_phy_ext = (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;
+                       reg_phy_ext |= (IXGBE_CS4227_EDC_MODE_SR << 1) | 0x1;
                ret_val = hw->phy.ops.write_reg(hw, reg_slice,
                                         IXGBE_MDIO_ZERO_DEV_TYPE, reg_phy_ext);
+
+               /* Flush previous write with a read */
+               ret_val = hw->phy.ops.read_reg(hw, reg_slice,
+                                       IXGBE_MDIO_ZERO_DEV_TYPE, &reg_phy_ext);
        }
        return ret_val;
 }
 
 /**
- *  ixgbe_setup_ixfi_x550em_x - MAC specific iXFI configuration
- *  @hw: pointer to hardware structure
+ * ixgbe_setup_ixfi_x550em_x - MAC specific iXFI configuration
+ * @hw: pointer to hardware structure
  *
- *  iXfI configuration needed for ixgbe_mac_X550EM_x devices.
+ * iXfI configuration needed for ixgbe_mac_X550EM_x devices.
  **/
 STATIC s32 ixgbe_setup_ixfi_x550em_x(struct ixgbe_hw *hw)
 {
@@ -3040,12 +2857,12 @@ STATIC s32 ixgbe_setup_ixfi_x550em_x(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_setup_ixfi_x550em - Configure the KR PHY for iXFI mode.
- *  @hw: pointer to hardware structure
- *  @speed: the link speed to force
+ * ixgbe_setup_ixfi_x550em - Configure the KR PHY for iXFI mode.
+ * @hw: pointer to hardware structure
+ * @speed: the link speed to force
  *
- *  Configures the integrated KR PHY to use iXFI mode. Used to connect an
- *  internal and external PHY at a specific speed, without autonegotiation.
+ * Configures the integrated KR PHY to use iXFI mode. Used to connect an
+ * internal and external PHY at a specific speed, without autonegotiation.
  **/
 STATIC s32 ixgbe_setup_ixfi_x550em(struct ixgbe_hw *hw, ixgbe_link_speed *speed)
 {
@@ -3201,10 +3018,10 @@ s32 ixgbe_setup_internal_phy_t_x550em(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_setup_phy_loopback_x550em - Configure the KR PHY for loopback.
- *  @hw: pointer to hardware structure
+ * ixgbe_setup_phy_loopback_x550em - Configure the KR PHY for loopback.
+ * @hw: pointer to hardware structure
  *
- *  Configures the integrated KR PHY to use internal loopback mode.
+ * Configures the integrated KR PHY to use internal loopback mode.
  **/
 s32 ixgbe_setup_phy_loopback_x550em(struct ixgbe_hw *hw)
 {
@@ -3268,13 +3085,13 @@ s32 ixgbe_setup_phy_loopback_x550em(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_read_ee_hostif_X550 - Read EEPROM word using a host interface command
- *  assuming that the semaphore is already obtained.
- *  @hw: pointer to hardware structure
- *  @offset: offset of  word in the EEPROM to read
- *  @data: word read from the EEPROM
+ * ixgbe_read_ee_hostif_X550 - Read EEPROM word using a host interface command
+ * assuming that the semaphore is already obtained.
+ * @hw: pointer to hardware structure
+ * @offset: offset of  word in the EEPROM to read
+ * @data: word read from the EEPROM
  *
- *  Reads a 16 bit word from the EEPROM using the hostif.
+ * Reads a 16 bit word from the EEPROM using the hostif.
  **/
 s32 ixgbe_read_ee_hostif_X550(struct ixgbe_hw *hw, u16 offset, u16 *data)
 {
@@ -3292,6 +3109,9 @@ s32 ixgbe_read_ee_hostif_X550(struct ixgbe_hw *hw, u16 offset, u16 *data)
        buffer.address = IXGBE_CPU_TO_BE32(offset * 2);
        /* one word */
        buffer.length = IXGBE_CPU_TO_BE16(sizeof(u16));
+       buffer.pad2 = 0;
+       buffer.data = 0;
+       buffer.pad3 = 0;
 
        status = hw->mac.ops.acquire_swfw_sync(hw, mask);
        if (status)
@@ -3309,13 +3129,13 @@ s32 ixgbe_read_ee_hostif_X550(struct ixgbe_hw *hw, u16 offset, u16 *data)
 }
 
 /**
- *  ixgbe_read_ee_hostif_buffer_X550- Read EEPROM word(s) using hostif
- *  @hw: pointer to hardware structure
- *  @offset: offset of  word in the EEPROM to read
- *  @words: number of words
- *  @data: word(s) read from the EEPROM
+ * ixgbe_read_ee_hostif_buffer_X550- Read EEPROM word(s) using hostif
+ * @hw: pointer to hardware structure
+ * @offset: offset of  word in the EEPROM to read
+ * @words: number of words
+ * @data: word(s) read from the EEPROM
  *
- *  Reads a 16 bit word(s) from the EEPROM using the hostif.
+ * Reads a 16 bit word(s) from the EEPROM using the hostif.
  **/
 s32 ixgbe_read_ee_hostif_buffer_X550(struct ixgbe_hw *hw,
                                     u16 offset, u16 words, u16 *data)
@@ -3350,6 +3170,9 @@ s32 ixgbe_read_ee_hostif_buffer_X550(struct ixgbe_hw *hw,
                /* convert offset from words to bytes */
                buffer.address = IXGBE_CPU_TO_BE32((offset + current_word) * 2);
                buffer.length = IXGBE_CPU_TO_BE16(words_to_read * 2);
+               buffer.pad2 = 0;
+               buffer.data = 0;
+               buffer.pad3 = 0;
 
                status = ixgbe_hic_unlocked(hw, (u32 *)&buffer, sizeof(buffer),
                                            IXGBE_HI_COMMAND_TIMEOUT);
@@ -3382,12 +3205,12 @@ out:
 }
 
 /**
- *  ixgbe_write_ee_hostif_X550 - Write EEPROM word using hostif
- *  @hw: pointer to hardware structure
- *  @offset: offset of  word in the EEPROM to write
- *  @data: word write to the EEPROM
+ * ixgbe_write_ee_hostif_X550 - Write EEPROM word using hostif
+ * @hw: pointer to hardware structure
+ * @offset: offset of  word in the EEPROM to write
+ * @data: word write to the EEPROM
  *
- *  Write a 16 bit word to the EEPROM using the hostif.
+ * Write a 16 bit word to the EEPROM using the hostif.
  **/
 s32 ixgbe_write_ee_hostif_data_X550(struct ixgbe_hw *hw, u16 offset,
                                    u16 data)
@@ -3409,18 +3232,29 @@ s32 ixgbe_write_ee_hostif_data_X550(struct ixgbe_hw *hw, u16 offset,
 
        status = ixgbe_host_interface_command(hw, (u32 *)&buffer,
                                              sizeof(buffer),
-                                             IXGBE_HI_COMMAND_TIMEOUT, false);
+                                             IXGBE_HI_COMMAND_TIMEOUT, true);
+       if (status != IXGBE_SUCCESS) {
+               DEBUGOUT2("for offset %04x failed with status %d\n",
+                         offset, status);
+               return status;
+       }
+
+       if (buffer.hdr.rsp.buf_lenh_status != FW_CEM_RESP_STATUS_SUCCESS) {
+               DEBUGOUT2("for offset %04x host interface return status %02x\n",
+                         offset, buffer.hdr.rsp.buf_lenh_status);
+               return IXGBE_ERR_HOST_INTERFACE_COMMAND;
+       }
 
        return status;
 }
 
 /**
- *  ixgbe_write_ee_hostif_X550 - Write EEPROM word using hostif
- *  @hw: pointer to hardware structure
- *  @offset: offset of  word in the EEPROM to write
- *  @data: word write to the EEPROM
+ * ixgbe_write_ee_hostif_X550 - Write EEPROM word using hostif
+ * @hw: pointer to hardware structure
+ * @offset: offset of  word in the EEPROM to write
+ * @data: word write to the EEPROM
  *
- *  Write a 16 bit word to the EEPROM using the hostif.
+ * Write a 16 bit word to the EEPROM using the hostif.
  **/
 s32 ixgbe_write_ee_hostif_X550(struct ixgbe_hw *hw, u16 offset,
                               u16 data)
@@ -3442,13 +3276,13 @@ s32 ixgbe_write_ee_hostif_X550(struct ixgbe_hw *hw, u16 offset,
 }
 
 /**
- *  ixgbe_write_ee_hostif_buffer_X550 - Write EEPROM word(s) using hostif
- *  @hw: pointer to hardware structure
- *  @offset: offset of  word in the EEPROM to write
- *  @words: number of words
- *  @data: word(s) write to the EEPROM
+ * ixgbe_write_ee_hostif_buffer_X550 - Write EEPROM word(s) using hostif
+ * @hw: pointer to hardware structure
+ * @offset: offset of  word in the EEPROM to write
+ * @words: number of words
+ * @data: word(s) write to the EEPROM
  *
- *  Write a 16 bit word(s) to the EEPROM using the hostif.
+ * Write a 16 bit word(s) to the EEPROM using the hostif.
  **/
 s32 ixgbe_write_ee_hostif_buffer_X550(struct ixgbe_hw *hw,
                                      u16 offset, u16 words, u16 *data)
@@ -3487,6 +3321,8 @@ out:
  * @ptr: pointer offset in eeprom
  * @size: size of section pointed by ptr, if 0 first word will be used as size
  * @csum: address of checksum to update
+ * @buffer: pointer to buffer containing calculated checksum
+ * @buffer_size: size of buffer
  *
  * Returns error status for any failure
  */
@@ -3552,12 +3388,12 @@ STATIC s32 ixgbe_checksum_ptr_x550(struct ixgbe_hw *hw, u16 ptr,
 }
 
 /**
- *  ixgbe_calc_checksum_X550 - Calculates and returns the checksum
- *  @hw: pointer to hardware structure
- *  @buffer: pointer to buffer containing calculated checksum
- *  @buffer_size: size of buffer
+ * ixgbe_calc_checksum_X550 - Calculates and returns the checksum
+ * @hw: pointer to hardware structure
+ * @buffer: pointer to buffer containing calculated checksum
+ * @buffer_size: size of buffer
  *
- *  Returns a negative error code on error, or the 16-bit checksum
+ * Returns a negative error code on error, or the 16-bit checksum
  **/
 s32 ixgbe_calc_checksum_X550(struct ixgbe_hw *hw, u16 *buffer, u32 buffer_size)
 {
@@ -3635,10 +3471,10 @@ s32 ixgbe_calc_checksum_X550(struct ixgbe_hw *hw, u16 *buffer, u32 buffer_size)
 }
 
 /**
- *  ixgbe_calc_eeprom_checksum_X550 - Calculates and returns the checksum
- *  @hw: pointer to hardware structure
+ * ixgbe_calc_eeprom_checksum_X550 - Calculates and returns the checksum
+ * @hw: pointer to hardware structure
  *
- *  Returns a negative error code on error, or the 16-bit checksum
+ * Returns a negative error code on error, or the 16-bit checksum
  **/
 s32 ixgbe_calc_eeprom_checksum_X550(struct ixgbe_hw *hw)
 {
@@ -3646,12 +3482,12 @@ s32 ixgbe_calc_eeprom_checksum_X550(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_validate_eeprom_checksum_X550 - Validate EEPROM checksum
- *  @hw: pointer to hardware structure
- *  @checksum_val: calculated checksum
+ * ixgbe_validate_eeprom_checksum_X550 - Validate EEPROM checksum
+ * @hw: pointer to hardware structure
+ * @checksum_val: calculated checksum
  *
- *  Performs checksum calculation and validates the EEPROM checksum.  If the
- *  caller does not need checksum_val, the value can be NULL.
+ * Performs checksum calculation and validates the EEPROM checksum.  If the
+ * caller does not need checksum_val, the value can be NULL.
  **/
 s32 ixgbe_validate_eeprom_checksum_X550(struct ixgbe_hw *hw, u16 *checksum_val)
 {
@@ -3740,10 +3576,10 @@ s32 ixgbe_update_eeprom_checksum_X550(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_update_flash_X550 - Instruct HW to copy EEPROM to Flash device
- *  @hw: pointer to hardware structure
+ * ixgbe_update_flash_X550 - Instruct HW to copy EEPROM to Flash device
+ * @hw: pointer to hardware structure
  *
- *  Issue a shadow RAM dump to FW to copy EEPROM from shadow RAM to the flash.
+ * Issue a shadow RAM dump to FW to copy EEPROM from shadow RAM to the flash.
  **/
 s32 ixgbe_update_flash_X550(struct ixgbe_hw *hw)
 {
@@ -3765,14 +3601,14 @@ s32 ixgbe_update_flash_X550(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_get_supported_physical_layer_X550em - Returns physical layer type
- *  @hw: pointer to hardware structure
+ * ixgbe_get_supported_physical_layer_X550em - Returns physical layer type
+ * @hw: pointer to hardware structure
  *
- *  Determines physical layer capabilities of the current configuration.
+ * Determines physical layer capabilities of the current configuration.
  **/
-u32 ixgbe_get_supported_physical_layer_X550em(struct ixgbe_hw *hw)
+u64 ixgbe_get_supported_physical_layer_X550em(struct ixgbe_hw *hw)
 {
-       u32 physical_layer = IXGBE_PHYSICAL_LAYER_UNKNOWN;
+       u64 physical_layer = IXGBE_PHYSICAL_LAYER_UNKNOWN;
        u16 ext_ability = 0;
 
        DEBUGFUNC("ixgbe_get_supported_physical_layer_X550em");
@@ -3781,6 +3617,21 @@ u32 ixgbe_get_supported_physical_layer_X550em(struct ixgbe_hw *hw)
 
        switch (hw->phy.type) {
        case ixgbe_phy_x550em_kr:
+               if (hw->mac.type == ixgbe_mac_X550EM_a) {
+                       if (hw->phy.nw_mng_if_sel &
+                           IXGBE_NW_MNG_IF_SEL_PHY_SPEED_2_5G) {
+                               physical_layer =
+                                       IXGBE_PHYSICAL_LAYER_2500BASE_KX;
+                               break;
+                       } else if (hw->device_id ==
+                                  IXGBE_DEV_ID_X550EM_A_KR_L) {
+                               physical_layer =
+                                       IXGBE_PHYSICAL_LAYER_1000BASE_KX;
+                               break;
+                       }
+               }
+               /* fall through */
+       case ixgbe_phy_x550em_xfi:
                physical_layer = IXGBE_PHYSICAL_LAYER_10GBASE_KR |
                                 IXGBE_PHYSICAL_LAYER_1000BASE_KX;
                break;
@@ -3797,8 +3648,20 @@ u32 ixgbe_get_supported_physical_layer_X550em(struct ixgbe_hw *hw)
                if (ext_ability & IXGBE_MDIO_PHY_1000BASET_ABILITY)
                        physical_layer |= IXGBE_PHYSICAL_LAYER_1000BASE_T;
                break;
-       case ixgbe_phy_m88:
-               physical_layer = IXGBE_PHYSICAL_LAYER_1000BASE_T;
+       case ixgbe_phy_fw:
+               if (hw->phy.speeds_supported & IXGBE_LINK_SPEED_1GB_FULL)
+                       physical_layer |= IXGBE_PHYSICAL_LAYER_1000BASE_T;
+               if (hw->phy.speeds_supported & IXGBE_LINK_SPEED_100_FULL)
+                       physical_layer |= IXGBE_PHYSICAL_LAYER_100BASE_TX;
+               if (hw->phy.speeds_supported & IXGBE_LINK_SPEED_10_FULL)
+                       physical_layer |= IXGBE_PHYSICAL_LAYER_10BASE_T;
+               break;
+       case ixgbe_phy_sgmii:
+               physical_layer = IXGBE_PHYSICAL_LAYER_1000BASE_KX;
+               break;
+       case ixgbe_phy_ext_1g_t:
+               physical_layer |= IXGBE_PHYSICAL_LAYER_1000BASE_T;
+               break;
        default:
                break;
        }
@@ -3831,6 +3694,7 @@ s32 ixgbe_get_bus_info_X550em(struct ixgbe_hw *hw)
 
 /**
  * ixgbe_disable_rx_x550 - Disable RX unit
+ * @hw: pointer to hardware structure
  *
  * Enables the Rx DMA unit for x550
  **/
@@ -3875,7 +3739,7 @@ void ixgbe_disable_rx_x550(struct ixgbe_hw *hw)
 
 /**
  * ixgbe_enter_lplu_x550em - Transition to low power states
- *  @hw: pointer to hardware structure
+ * @hw: pointer to hardware structure
  *
  * Configures Low Power Link Up on transition to low power states
  * (from D0 to non-D0). Link is required to enter LPLU so avoid resetting the
@@ -3983,8 +3847,8 @@ s32 ixgbe_enter_lplu_t_x550em(struct ixgbe_hw *hw)
 
 /**
  * ixgbe_get_lcd_x550em - Determine lowest common denominator
- *  @hw: pointer to hardware structure
- *  @lcd_speed: pointer to lowest common link speed
+ * @hw: pointer to hardware structure
+ * @lcd_speed: pointer to lowest common link speed
  *
  * Determine lowest common link speed with link partner.
  **/
@@ -4020,10 +3884,10 @@ s32 ixgbe_get_lcd_t_x550em(struct ixgbe_hw *hw, ixgbe_link_speed *lcd_speed)
 }
 
 /**
- *  ixgbe_setup_fc_X550em - Set up flow control
- *  @hw: pointer to hardware structure
+ * ixgbe_setup_fc_X550em - Set up flow control
+ * @hw: pointer to hardware structure
  *
- *  Called at init time to set up flow control.
+ * Called at init time to set up flow control.
  **/
 s32 ixgbe_setup_fc_X550em(struct ixgbe_hw *hw)
 {
@@ -4098,6 +3962,9 @@ s32 ixgbe_setup_fc_X550em(struct ixgbe_hw *hw)
                /* This device does not fully support AN. */
                hw->fc.disable_fc_autoneg = true;
                break;
+       case IXGBE_DEV_ID_X550EM_X_XFI:
+               hw->fc.disable_fc_autoneg = true;
+               break;
        default:
                break;
        }
@@ -4107,10 +3974,10 @@ out:
 }
 
 /**
- *  ixgbe_fc_autoneg_backplane_x550em_a - Enable flow control IEEE clause 37
- *  @hw: pointer to hardware structure
+ * ixgbe_fc_autoneg_backplane_x550em_a - Enable flow control IEEE clause 37
+ * @hw: pointer to hardware structure
  *
- *  Enable flow control according to IEEE clause 37.
+ * Enable flow control according to IEEE clause 37.
  **/
 void ixgbe_fc_autoneg_backplane_x550em_a(struct ixgbe_hw *hw)
 {
@@ -4185,8 +4052,8 @@ out:
 }
 
 /**
- *  ixgbe_fc_autoneg_fiber_x550em_a - passthrough FC settings
- *  @hw: pointer to hardware structure
+ * ixgbe_fc_autoneg_fiber_x550em_a - passthrough FC settings
+ * @hw: pointer to hardware structure
  *
  **/
 void ixgbe_fc_autoneg_fiber_x550em_a(struct ixgbe_hw *hw)
@@ -4196,15 +4063,15 @@ void ixgbe_fc_autoneg_fiber_x550em_a(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_fc_autoneg_sgmii_x550em_a - Enable flow control IEEE clause 37
- *  @hw: pointer to hardware structure
+ * ixgbe_fc_autoneg_sgmii_x550em_a - Enable flow control IEEE clause 37
+ * @hw: pointer to hardware structure
  *
- *  Enable flow control according to IEEE clause 37.
+ * Enable flow control according to IEEE clause 37.
  **/
 void ixgbe_fc_autoneg_sgmii_x550em_a(struct ixgbe_hw *hw)
 {
        s32 status = IXGBE_ERR_FC_NOT_NEGOTIATED;
-       u16 reg, pcs_an_lp, pcs_an;
+       u32 info[FW_PHY_ACT_DATA_COUNT] = { 0 };
        ixgbe_link_speed speed;
        bool link_up;
 
@@ -4226,34 +4093,20 @@ void ixgbe_fc_autoneg_sgmii_x550em_a(struct ixgbe_hw *hw)
        }
 
        /* Check if auto-negotiation has completed */
-       status = hw->phy.ops.read_reg(hw, IXGBE_M88E1500_COPPER_STATUS,
-                                       IXGBE_MDIO_ZERO_DEV_TYPE, &reg);
+       status = ixgbe_fw_phy_activity(hw, FW_PHY_ACT_GET_LINK_INFO, &info);
        if (status != IXGBE_SUCCESS ||
-           (reg & IXGBE_M88E1500_COPPER_STATUS_AN_DONE) == 0) {
+           !(info[0] & FW_PHY_ACT_GET_LINK_INFO_AN_COMPLETE)) {
                DEBUGOUT("Auto-Negotiation did not complete\n");
                status = IXGBE_ERR_FC_NOT_NEGOTIATED;
                goto out;
        }
 
-       /* Get the advertized flow control */
-       status = hw->phy.ops.read_reg(hw, IXGBE_M88E1500_COPPER_AN,
-                                       IXGBE_MDIO_ZERO_DEV_TYPE, &pcs_an);
-       if (status != IXGBE_SUCCESS)
-               goto out;
-
-       /* Get link partner's flow control */
-       status = hw->phy.ops.read_reg(hw,
-                       IXGBE_M88E1500_COPPER_AN_LP_ABILITY,
-                                       IXGBE_MDIO_ZERO_DEV_TYPE, &pcs_an_lp);
-       if (status != IXGBE_SUCCESS)
-               goto out;
-
        /* Negotiate the flow control */
-       status = ixgbe_negotiate_fc(hw, (u32)pcs_an, (u32)pcs_an_lp,
-                                   IXGBE_M88E1500_COPPER_AN_PAUSE,
-                                   IXGBE_M88E1500_COPPER_AN_AS_PAUSE,
-                                   IXGBE_M88E1500_COPPER_AN_LP_PAUSE,
-                                   IXGBE_M88E1500_COPPER_AN_LP_AS_PAUSE);
+       status = ixgbe_negotiate_fc(hw, info[0], info[0],
+                                   FW_PHY_ACT_GET_LINK_INFO_FC_RX,
+                                   FW_PHY_ACT_GET_LINK_INFO_FC_TX,
+                                   FW_PHY_ACT_GET_LINK_INFO_LP_FC_RX,
+                                   FW_PHY_ACT_GET_LINK_INFO_LP_FC_TX);
 
 out:
        if (status == IXGBE_SUCCESS) {
@@ -4265,87 +4118,10 @@ out:
 }
 
 /**
- *  ixgbe_setup_fc_sgmii_x550em_a - Set up flow control
- *  @hw: pointer to hardware structure
- *
- *  Called at init time to set up flow control.
- **/
-s32 ixgbe_setup_fc_sgmii_x550em_a(struct ixgbe_hw *hw)
-{
-       u16 reg;
-       s32 rc;
-
-       /* Validate the requested mode */
-       if (hw->fc.strict_ieee && hw->fc.requested_mode == ixgbe_fc_rx_pause) {
-               ERROR_REPORT1(IXGBE_ERROR_UNSUPPORTED,
-                             "ixgbe_fc_rx_pause not valid in strict IEEE mode\n");
-               return IXGBE_ERR_INVALID_LINK_SETTINGS;
-       }
-
-       if (hw->fc.requested_mode == ixgbe_fc_default)
-               hw->fc.requested_mode = ixgbe_fc_full;
-
-       /* Read contents of the Auto-Negotiation register, page 0 reg 4 */
-       rc = hw->phy.ops.read_reg(hw, IXGBE_M88E1500_COPPER_AN,
-                                       IXGBE_MDIO_ZERO_DEV_TYPE, &reg);
-       if (rc)
-               goto out;
-
-       /* Disable all the settings related to Flow control Auto-negotiation */
-       reg &= ~IXGBE_M88E1500_COPPER_AN_AS_PAUSE;
-       reg &= ~IXGBE_M88E1500_COPPER_AN_PAUSE;
-
-       /* Configure the Asymmetric and symmetric pause according to the user
-        * requested mode.
-        */
-       switch (hw->fc.requested_mode) {
-       case ixgbe_fc_full:
-               reg |= IXGBE_M88E1500_COPPER_AN_PAUSE;
-               reg |= IXGBE_M88E1500_COPPER_AN_AS_PAUSE;
-               break;
-       case ixgbe_fc_rx_pause:
-               reg |= IXGBE_M88E1500_COPPER_AN_PAUSE;
-               reg |= IXGBE_M88E1500_COPPER_AN_AS_PAUSE;
-               break;
-       case ixgbe_fc_tx_pause:
-               reg |= IXGBE_M88E1500_COPPER_AN_AS_PAUSE;
-               break;
-       default:
-               break;
-       }
-
-       /* Write back to the Auto-Negotiation register with newly configured
-        * fields
-        */
-       hw->phy.ops.write_reg(hw, IXGBE_M88E1500_COPPER_AN,
-                                       IXGBE_MDIO_ZERO_DEV_TYPE, reg);
-
-       /* In this section of the code we restart Auto-negotiation */
-
-       /* Read the CONTROL register, Page 0 reg 0 */
-       rc = hw->phy.ops.read_reg(hw, IXGBE_M88E1500_COPPER_CTRL,
-                                       IXGBE_MDIO_ZERO_DEV_TYPE, &reg);
-       if (rc)
-               goto out;
-
-       /* Set the bit to restart Auto-Neg. The bit to enable Auto-neg is ON
-        * by default
-        */
-       reg |= IXGBE_M88E1500_COPPER_CTRL_RESTART_AN;
-
-       /* write the new values to the register to restart Auto-Negotiation */
-       hw->phy.ops.write_reg(hw, IXGBE_M88E1500_COPPER_CTRL,
-                                       IXGBE_MDIO_ZERO_DEV_TYPE, reg);
-
-out:
-       return rc;
-}
-
-/**
- *  ixgbe_setup_fc_backplane_x550em_a - Set up flow control
- *  @hw: pointer to hardware structure
+ * ixgbe_setup_fc_backplane_x550em_a - Set up flow control
+ * @hw: pointer to hardware structure
  *
- *  Called at init time to set up flow control.
+ * Called at init time to set up flow control.
  **/
 s32 ixgbe_setup_fc_backplane_x550em_a(struct ixgbe_hw *hw)
 {
@@ -4450,11 +4226,11 @@ STATIC void ixgbe_set_mux(struct ixgbe_hw *hw, u8 state)
 }
 
 /**
- *  ixgbe_acquire_swfw_sync_X550em - Acquire SWFW semaphore
- *  @hw: pointer to hardware structure
- *  @mask: Mask to specify which semaphore to acquire
+ * ixgbe_acquire_swfw_sync_X550em - Acquire SWFW semaphore
+ * @hw: pointer to hardware structure
+ * @mask: Mask to specify which semaphore to acquire
  *
- *  Acquires the SWFW semaphore and sets the I2C MUX
+ * Acquires the SWFW semaphore and sets the I2C MUX
  **/
 s32 ixgbe_acquire_swfw_sync_X550em(struct ixgbe_hw *hw, u32 mask)
 {
@@ -4473,11 +4249,11 @@ s32 ixgbe_acquire_swfw_sync_X550em(struct ixgbe_hw *hw, u32 mask)
 }
 
 /**
- *  ixgbe_release_swfw_sync_X550em - Release SWFW semaphore
- *  @hw: pointer to hardware structure
- *  @mask: Mask to specify which semaphore to release
+ * ixgbe_release_swfw_sync_X550em - Release SWFW semaphore
+ * @hw: pointer to hardware structure
+ * @mask: Mask to specify which semaphore to release
  *
- *  Releases the SWFW semaphore and sets the I2C MUX
+ * Releases the SWFW semaphore and sets the I2C MUX
  **/
 void ixgbe_release_swfw_sync_X550em(struct ixgbe_hw *hw, u32 mask)
 {
@@ -4490,11 +4266,11 @@ void ixgbe_release_swfw_sync_X550em(struct ixgbe_hw *hw, u32 mask)
 }
 
 /**
- *  ixgbe_acquire_swfw_sync_X550a - Acquire SWFW semaphore
- *  @hw: pointer to hardware structure
- *  @mask: Mask to specify which semaphore to acquire
+ * ixgbe_acquire_swfw_sync_X550a - Acquire SWFW semaphore
+ * @hw: pointer to hardware structure
+ * @mask: Mask to specify which semaphore to acquire
  *
- *  Acquires the SWFW semaphore and get the shared phy token as needed
+ * Acquires the SWFW semaphore and get the shared phy token as needed
  */
 STATIC s32 ixgbe_acquire_swfw_sync_X550a(struct ixgbe_hw *hw, u32 mask)
 {
@@ -4508,30 +4284,43 @@ STATIC s32 ixgbe_acquire_swfw_sync_X550a(struct ixgbe_hw *hw, u32 mask)
                status = IXGBE_SUCCESS;
                if (hmask)
                        status = ixgbe_acquire_swfw_sync_X540(hw, hmask);
-               if (status)
+               if (status) {
+                       DEBUGOUT1("Could not acquire SWFW semaphore, Status = %d\n",
+                                 status);
                        return status;
+               }
                if (!(mask & IXGBE_GSSR_TOKEN_SM))
                        return IXGBE_SUCCESS;
 
                status = ixgbe_get_phy_token(hw);
+               if (status == IXGBE_ERR_TOKEN_RETRY)
+                       DEBUGOUT1("Could not acquire PHY token, Status = %d\n",
+                                 status);
+
                if (status == IXGBE_SUCCESS)
                        return IXGBE_SUCCESS;
 
                if (hmask)
                        ixgbe_release_swfw_sync_X540(hw, hmask);
-               if (status != IXGBE_ERR_TOKEN_RETRY)
+
+               if (status != IXGBE_ERR_TOKEN_RETRY) {
+                       DEBUGOUT1("Unable to retry acquiring the PHY token, Status = %d\n",
+                                 status);
                        return status;
+               }
        }
 
+       DEBUGOUT1("Semaphore acquisition retries failed!: PHY ID = 0x%08X\n",
+                 hw->phy.id);
        return status;
 }
 
 /**
- *  ixgbe_release_swfw_sync_X550a - Release SWFW semaphore
- *  @hw: pointer to hardware structure
- *  @mask: Mask to specify which semaphore to release
+ * ixgbe_release_swfw_sync_X550a - Release SWFW semaphore
+ * @hw: pointer to hardware structure
+ * @mask: Mask to specify which semaphore to release
  *
- *  Releases the SWFW semaphore and puts the shared phy token as needed
+ * Releases the SWFW semaphore and puts the shared phy token as needed
  */
 STATIC void ixgbe_release_swfw_sync_X550a(struct ixgbe_hw *hw, u32 mask)
 {
@@ -4547,14 +4336,15 @@ STATIC void ixgbe_release_swfw_sync_X550a(struct ixgbe_hw *hw, u32 mask)
 }
 
 /**
- *  ixgbe_read_phy_reg_x550a  - Reads specified PHY register
- *  @hw: pointer to hardware structure
- *  @reg_addr: 32 bit address of PHY register to read
- *  @phy_data: Pointer to read data from PHY register
+ * ixgbe_read_phy_reg_x550a  - Reads specified PHY register
+ * @hw: pointer to hardware structure
+ * @reg_addr: 32 bit address of PHY register to read
+ * @device_type: 5 bit device type
+ * @phy_data: Pointer to read data from PHY register
  *
- *  Reads a value from a specified PHY register using the SWFW lock and PHY
- *  Token. The PHY Token is needed since the MDIO is shared between to MAC
- *  instances.
+ * Reads a value from a specified PHY register using the SWFW lock and PHY
+ * Token. The PHY Token is needed since the MDIO is shared between to MAC
+ * instances.
  **/
 s32 ixgbe_read_phy_reg_x550a(struct ixgbe_hw *hw, u32 reg_addr,
                               u32 device_type, u16 *phy_data)
@@ -4575,14 +4365,14 @@ s32 ixgbe_read_phy_reg_x550a(struct ixgbe_hw *hw, u32 reg_addr,
 }
 
 /**
- *  ixgbe_write_phy_reg_x550a - Writes specified PHY register
- *  @hw: pointer to hardware structure
- *  @reg_addr: 32 bit PHY register to write
- *  @device_type: 5 bit device type
- *  @phy_data: Data to write to the PHY register
+ * ixgbe_write_phy_reg_x550a - Writes specified PHY register
+ * @hw: pointer to hardware structure
+ * @reg_addr: 32 bit PHY register to write
+ * @device_type: 5 bit device type
+ * @phy_data: Data to write to the PHY register
  *
- *  Writes a value to specified PHY register using the SWFW lock and PHY Token.
- *  The PHY Token is needed since the MDIO is shared between to MAC instances.
+ * Writes a value to specified PHY register using the SWFW lock and PHY Token.
+ * The PHY Token is needed since the MDIO is shared between to MAC instances.
  **/
 s32 ixgbe_write_phy_reg_x550a(struct ixgbe_hw *hw, u32 reg_addr,
                                u32 device_type, u16 phy_data)
@@ -4647,6 +4437,8 @@ s32 ixgbe_setup_mac_link_t_X550em(struct ixgbe_hw *hw,
 {
        s32 status;
        ixgbe_link_speed force_speed;
+       u32 i;
+       bool link_up = false;
 
        DEBUGFUNC("ixgbe_setup_mac_link_t_X550em");
 
@@ -4666,6 +4458,19 @@ s32 ixgbe_setup_mac_link_t_X550em(struct ixgbe_hw *hw,
 
                if (status != IXGBE_SUCCESS)
                        return status;
+
+               /* Wait for the controller to acquire link */
+               for (i = 0; i < 10; i++) {
+                       msec_delay(100);
+
+                       status = ixgbe_check_link(hw, &force_speed, &link_up,
+                                                 false);
+                       if (status != IXGBE_SUCCESS)
+                               return status;
+
+                       if (link_up)
+                               break;
+               }
        }
 
        return hw->phy.ops.setup_link_speed(hw, speed, autoneg_wait_to_complete);
@@ -4718,8 +4523,8 @@ s32 ixgbe_check_link_t_X550em(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
 }
 
 /**
- *  ixgbe_reset_phy_t_X550em - Performs X557 PHY reset and enables LASI
- *  @hw: pointer to hardware structure
+ * ixgbe_reset_phy_t_X550em - Performs X557 PHY reset and enables LASI
+ * @hw: pointer to hardware structure
  **/
 s32 ixgbe_reset_phy_t_X550em(struct ixgbe_hw *hw)
 {
@@ -4735,9 +4540,9 @@ s32 ixgbe_reset_phy_t_X550em(struct ixgbe_hw *hw)
 }
 
 /**
- *  ixgbe_led_on_t_X550em - Turns on the software controllable LEDs.
- *  @hw: pointer to hardware structure
- *  @led_idx: led number to turn on
+ * ixgbe_led_on_t_X550em - Turns on the software controllable LEDs.
+ * @hw: pointer to hardware structure
+ * @led_idx: led number to turn on
  **/
 s32 ixgbe_led_on_t_X550em(struct ixgbe_hw *hw, u32 led_idx)
 {
@@ -4755,13 +4560,14 @@ s32 ixgbe_led_on_t_X550em(struct ixgbe_hw *hw, u32 led_idx)
        ixgbe_write_phy_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
                            IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE, phy_data);
 
-       return IXGBE_SUCCESS;
+       /* Some designs have the LEDs wired to the MAC */
+       return ixgbe_led_on_generic(hw, led_idx);
 }
 
 /**
- *  ixgbe_led_off_t_X550em - Turns off the software controllable LEDs.
- *  @hw: pointer to hardware structure
- *  @led_idx: led number to turn off
+ * ixgbe_led_off_t_X550em - Turns off the software controllable LEDs.
+ * @hw: pointer to hardware structure
+ * @led_idx: led number to turn off
  **/
 s32 ixgbe_led_off_t_X550em(struct ixgbe_hw *hw, u32 led_idx)
 {
@@ -4779,23 +4585,24 @@ s32 ixgbe_led_off_t_X550em(struct ixgbe_hw *hw, u32 led_idx)
        ixgbe_write_phy_reg(hw, IXGBE_X557_LED_PROVISIONING + led_idx,
                            IXGBE_MDIO_VENDOR_SPECIFIC_1_DEV_TYPE, phy_data);
 
-       return IXGBE_SUCCESS;
+       /* Some designs have the LEDs wired to the MAC */
+       return ixgbe_led_off_generic(hw, led_idx);
 }
 
 /**
- *  ixgbe_set_fw_drv_ver_x550 - Sends driver version to firmware
- *  @hw: pointer to the HW structure
- *  @maj: driver version major number
- *  @min: driver version minor number
- *  @build: driver version build number
- *  @sub: driver version sub build number
- *  @len: length of driver_ver string
- *  @driver_ver: driver string
+ * ixgbe_set_fw_drv_ver_x550 - Sends driver version to firmware
+ * @hw: pointer to the HW structure
+ * @maj: driver version major number
+ * @min: driver version minor number
+ * @build: driver version build number
+ * @sub: driver version sub build number
+ * @len: length of driver_ver string
+ * @driver_ver: driver string
  *
- *  Sends driver version number to firmware through the manageability
- *  block.  On success return IXGBE_SUCCESS
- *  else returns IXGBE_ERR_SWFW_SYNC when encountering an error acquiring
- *  semaphore or IXGBE_ERR_HOST_INTERFACE_COMMAND when command fails.
+ * Sends driver version number to firmware through the manageability
+ * block.  On success return IXGBE_SUCCESS
+ * else returns IXGBE_ERR_SWFW_SYNC when encountering an error acquiring
+ * semaphore or IXGBE_ERR_HOST_INTERFACE_COMMAND when command fails.
  **/
 s32 ixgbe_set_fw_drv_ver_x550(struct ixgbe_hw *hw, u8 maj, u8 min,
                              u8 build, u8 sub, u16 len, const char *driver_ver)
@@ -4842,3 +4649,18 @@ s32 ixgbe_set_fw_drv_ver_x550(struct ixgbe_hw *hw, u8 maj, u8 min,
 
        return ret_val;
 }
+
+/**
+ * ixgbe_fw_recovery_mode_X550 - Check FW NVM recovery mode
+ * @hw: pointer t hardware structure
+ *
+ * Returns true if in FW NVM recovery mode.
+ **/
+bool ixgbe_fw_recovery_mode_X550(struct ixgbe_hw *hw)
+{
+       u32 fwsm;
+
+       fwsm = IXGBE_READ_REG(hw, IXGBE_FWSM_BY_MAC(hw));
+
+       return !!(fwsm & IXGBE_FWSM_FW_NVM_RECOVERY_MODE);
+}