ethdev: separate driver APIs
[dpdk.git] / drivers / net / mlx4 / mlx4_intr.c
index e1e6c05..2ff7218 100644 (file)
@@ -52,7 +52,8 @@
 
 #include <rte_alarm.h>
 #include <rte_errno.h>
-#include <rte_ethdev.h>
+#include <rte_ethdev_driver.h>
+#include <rte_io.h>
 #include <rte_interrupts.h>
 
 #include "mlx4.h"
@@ -97,7 +98,7 @@ mlx4_rx_intr_vec_enable(struct priv *priv)
        struct rte_intr_handle *intr_handle = &priv->intr_handle;
 
        mlx4_rx_intr_vec_disable(priv);
-       intr_handle->intr_vec = malloc(sizeof(intr_handle->intr_vec[rxqs_n]));
+       intr_handle->intr_vec = malloc(n * sizeof(intr_handle->intr_vec[0]));
        if (intr_handle->intr_vec == NULL) {
                rte_errno = ENOMEM;
                ERROR("failed to allocate memory for interrupt vector,"
@@ -134,53 +135,6 @@ mlx4_rx_intr_vec_enable(struct priv *priv)
        return 0;
 }
 
-/**
- * Collect interrupt events.
- *
- * @param priv
- *   Pointer to private structure.
- * @param events
- *   Pointer to event flags holder.
- *
- * @return
- *   Number of events.
- */
-static int
-mlx4_collect_interrupt_events(struct priv *priv, uint32_t *events)
-{
-       struct ibv_async_event event;
-       const struct rte_intr_conf *const intr_conf =
-               &priv->dev->data->dev_conf.intr_conf;
-       int ret = 0;
-
-       *events = 0;
-       /* Read all message and acknowledge them. */
-       for (;;) {
-               if (ibv_get_async_event(priv->ctx, &event))
-                       break;
-               switch (event.event_type) {
-               case IBV_EVENT_PORT_ACTIVE:
-               case IBV_EVENT_PORT_ERR:
-                       if (!intr_conf->lsc || mlx4_link_status_check(priv))
-                               break;
-                       *events |= (1 << RTE_ETH_EVENT_INTR_LSC);
-                       ret++;
-                       break;
-               case IBV_EVENT_DEVICE_FATAL:
-                       if (!intr_conf->rmv)
-                               break;
-                       *events |= (1 << RTE_ETH_EVENT_INTR_RMV);
-                       ret++;
-                       break;
-               default:
-                       DEBUG("event type %d on port %d not handled",
-                             event.event_type, event.element.port_num);
-               }
-               ibv_ack_async_event(&event);
-       }
-       return ret;
-}
-
 /**
  * Process scheduled link status check.
  *
@@ -200,7 +154,7 @@ mlx4_link_status_alarm(struct priv *priv)
        if (intr_conf->lsc && !mlx4_link_status_check(priv))
                _rte_eth_dev_callback_process(priv->dev,
                                              RTE_ETH_EVENT_INTR_LSC,
-                                             NULL, NULL);
+                                             NULL);
 }
 
 /**
@@ -250,26 +204,68 @@ mlx4_link_status_check(struct priv *priv)
 static void
 mlx4_interrupt_handler(struct priv *priv)
 {
-       int ret;
-       uint32_t ev;
-       int i;
+       enum { LSC, RMV, };
+       static const enum rte_eth_event_type type[] = {
+               [LSC] = RTE_ETH_EVENT_INTR_LSC,
+               [RMV] = RTE_ETH_EVENT_INTR_RMV,
+       };
+       uint32_t caught[RTE_DIM(type)] = { 0 };
+       struct ibv_async_event event;
+       const struct rte_intr_conf *const intr_conf =
+               &priv->dev->data->dev_conf.intr_conf;
+       unsigned int i;
 
-       ret = mlx4_collect_interrupt_events(priv, &ev);
-       if (ret > 0) {
-               for (i = RTE_ETH_EVENT_UNKNOWN;
-                    i < RTE_ETH_EVENT_MAX;
-                    i++) {
-                       if (ev & (1 << i)) {
-                               ev &= ~(1 << i);
-                               _rte_eth_dev_callback_process(priv->dev, i,
-                                                             NULL, NULL);
-                               ret--;
-                       }
+       /* Read all message and acknowledge them. */
+       while (!ibv_get_async_event(priv->ctx, &event)) {
+               switch (event.event_type) {
+               case IBV_EVENT_PORT_ACTIVE:
+               case IBV_EVENT_PORT_ERR:
+                       if (intr_conf->lsc && !mlx4_link_status_check(priv))
+                               ++caught[LSC];
+                       break;
+               case IBV_EVENT_DEVICE_FATAL:
+                       if (intr_conf->rmv)
+                               ++caught[RMV];
+                       break;
+               default:
+                       DEBUG("event type %d on physical port %d not handled",
+                             event.event_type, event.element.port_num);
                }
-               if (ret)
-                       WARN("%d event%s not processed", ret,
-                            (ret > 1 ? "s were" : " was"));
+               ibv_ack_async_event(&event);
        }
+       for (i = 0; i != RTE_DIM(caught); ++i)
+               if (caught[i])
+                       _rte_eth_dev_callback_process(priv->dev, type[i],
+                                                     NULL);
+}
+
+/**
+ * MLX4 CQ notification .
+ *
+ * @param rxq
+ *   Pointer to receive queue structure.
+ * @param solicited
+ *   Is request solicited or not.
+ */
+static void
+mlx4_arm_cq(struct rxq *rxq, int solicited)
+{
+       struct mlx4_cq *cq = &rxq->mcq;
+       uint64_t doorbell;
+       uint32_t sn = cq->arm_sn & MLX4_CQ_DB_GEQ_N_MASK;
+       uint32_t ci = cq->cons_index & MLX4_CQ_DB_CI_MASK;
+       uint32_t cmd = solicited ? MLX4_CQ_DB_REQ_NOT_SOL : MLX4_CQ_DB_REQ_NOT;
+
+       *cq->arm_db = rte_cpu_to_be_32(sn << 28 | cmd | ci);
+       /*
+        * Make sure that the doorbell record in host memory is
+        * written before ringing the doorbell via PCI MMIO.
+        */
+       rte_wmb();
+       doorbell = sn << 28 | cmd | cq->cqn;
+       doorbell <<= 32;
+       doorbell |= ci;
+       rte_write64(rte_cpu_to_be_64(doorbell), cq->cq_db_reg);
 }
 
 /**
@@ -367,6 +363,7 @@ mlx4_rx_intr_disable(struct rte_eth_dev *dev, uint16_t idx)
                WARN("unable to disable interrupt on rx queue %d",
                     idx);
        } else {
+               rxq->mcq.arm_sn++;
                ibv_ack_cq_events(rxq->cq, 1);
        }
        return -ret;
@@ -387,15 +384,14 @@ int
 mlx4_rx_intr_enable(struct rte_eth_dev *dev, uint16_t idx)
 {
        struct rxq *rxq = dev->data->rx_queues[idx];
-       int ret;
+       int ret = 0;
 
-       if (!rxq || !rxq->channel)
+       if (!rxq || !rxq->channel) {
                ret = EINVAL;
-       else
-               ret = ibv_req_notify_cq(rxq->cq, 0);
-       if (ret) {
                rte_errno = ret;
                WARN("unable to arm interrupt on rx queue %d", idx);
+       } else {
+               mlx4_arm_cq(rxq, 0);
        }
        return -ret;
 }