net/axgbe: support scattered Rx
[dpdk.git] / drivers / net / mlx4 / mlx4_rxq.c
index 9737da2..0699bdd 100644 (file)
@@ -8,7 +8,6 @@
  * Rx queues configuration for mlx4 driver.
  */
 
-#include <assert.h>
 #include <errno.h>
 #include <stddef.h>
 #include <stdint.h>
@@ -87,7 +86,7 @@ mlx4_rss_hash_key_default[MLX4_RSS_HASH_KEY_SIZE] = {
  *   Pointer to RSS context on success, NULL otherwise and rte_errno is set.
  */
 struct mlx4_rss *
-mlx4_rss_get(struct priv *priv, uint64_t fields,
+mlx4_rss_get(struct mlx4_priv *priv, uint64_t fields,
             const uint8_t key[MLX4_RSS_HASH_KEY_SIZE],
             uint16_t queues, const uint16_t queue_id[])
 {
@@ -140,12 +139,12 @@ error:
 void
 mlx4_rss_put(struct mlx4_rss *rss)
 {
-       assert(rss->refcnt);
+       MLX4_ASSERT(rss->refcnt);
        if (--rss->refcnt)
                return;
-       assert(!rss->usecnt);
-       assert(!rss->qp);
-       assert(!rss->ind);
+       MLX4_ASSERT(!rss->usecnt);
+       MLX4_ASSERT(!rss->qp);
+       MLX4_ASSERT(!rss->ind);
        LIST_REMOVE(rss, next);
        rte_free(rss);
 }
@@ -167,15 +166,16 @@ mlx4_rss_put(struct mlx4_rss *rss)
 int
 mlx4_rss_attach(struct mlx4_rss *rss)
 {
-       assert(rss->refcnt);
+       MLX4_ASSERT(rss->refcnt);
        if (rss->usecnt++) {
-               assert(rss->qp);
-               assert(rss->ind);
+               MLX4_ASSERT(rss->qp);
+               MLX4_ASSERT(rss->ind);
                return 0;
        }
 
        struct ibv_wq *ind_tbl[rss->queues];
-       struct priv *priv = rss->priv;
+       struct mlx4_priv *priv = rss->priv;
+       struct rte_eth_dev *dev = ETH_DEV(priv);
        const char *msg;
        unsigned int i = 0;
        int ret;
@@ -189,8 +189,8 @@ mlx4_rss_attach(struct mlx4_rss *rss)
                uint16_t id = rss->queue_id[i];
                struct rxq *rxq = NULL;
 
-               if (id < priv->dev->data->nb_rx_queues)
-                       rxq = priv->dev->data->rx_queues[id];
+               if (id < dev->data->nb_rx_queues)
+                       rxq = dev->data->rx_queues[id];
                if (!rxq) {
                        ret = EINVAL;
                        msg = "RSS target queue is not configured";
@@ -269,7 +269,7 @@ error:
                rss->ind = NULL;
        }
        while (i--)
-               mlx4_rxq_detach(priv->dev->data->rx_queues[rss->queue_id[i]]);
+               mlx4_rxq_detach(dev->data->rx_queues[rss->queue_id[i]]);
        ERROR("mlx4: %s", msg);
        --rss->usecnt;
        rte_errno = ret;
@@ -290,12 +290,13 @@ error:
 void
 mlx4_rss_detach(struct mlx4_rss *rss)
 {
-       struct priv *priv = rss->priv;
+       struct mlx4_priv *priv = rss->priv;
+       struct rte_eth_dev *dev = ETH_DEV(priv);
        unsigned int i;
 
-       assert(rss->refcnt);
-       assert(rss->qp);
-       assert(rss->ind);
+       MLX4_ASSERT(rss->refcnt);
+       MLX4_ASSERT(rss->qp);
+       MLX4_ASSERT(rss->ind);
        if (--rss->usecnt)
                return;
        claim_zero(mlx4_glue->destroy_qp(rss->qp));
@@ -303,7 +304,7 @@ mlx4_rss_detach(struct mlx4_rss *rss)
        claim_zero(mlx4_glue->destroy_rwq_ind_table(rss->ind));
        rss->ind = NULL;
        for (i = 0; i != rss->queues; ++i)
-               mlx4_rxq_detach(priv->dev->data->rx_queues[rss->queue_id[i]]);
+               mlx4_rxq_detach(dev->data->rx_queues[rss->queue_id[i]]);
 }
 
 /**
@@ -327,9 +328,9 @@ mlx4_rss_detach(struct mlx4_rss *rss)
  *   0 on success, a negative errno value otherwise and rte_errno is set.
  */
 int
-mlx4_rss_init(struct priv *priv)
+mlx4_rss_init(struct mlx4_priv *priv)
 {
-       struct rte_eth_dev *dev = priv->dev;
+       struct rte_eth_dev *dev = ETH_DEV(priv);
        uint8_t log2_range = rte_log2_u32(dev->data->nb_rx_queues);
        uint32_t wq_num_prev = 0;
        const char *msg;
@@ -338,7 +339,7 @@ mlx4_rss_init(struct priv *priv)
 
        if (priv->rss_init)
                return 0;
-       if (priv->dev->data->nb_rx_queues > priv->hw_rss_max_qps) {
+       if (ETH_DEV(priv)->data->nb_rx_queues > priv->hw_rss_max_qps) {
                ERROR("RSS does not support more than %d queues",
                      priv->hw_rss_max_qps);
                rte_errno = EINVAL;
@@ -356,15 +357,15 @@ mlx4_rss_init(struct priv *priv)
                rte_errno = ret;
                return -ret;
        }
-       for (i = 0; i != priv->dev->data->nb_rx_queues; ++i) {
-               struct rxq *rxq = priv->dev->data->rx_queues[i];
+       for (i = 0; i != ETH_DEV(priv)->data->nb_rx_queues; ++i) {
+               struct rxq *rxq = ETH_DEV(priv)->data->rx_queues[i];
                struct ibv_cq *cq;
                struct ibv_wq *wq;
                uint32_t wq_num;
 
                /* Attach the configured Rx queues. */
                if (rxq) {
-                       assert(!rxq->usecnt);
+                       MLX4_ASSERT(!rxq->usecnt);
                        ret = mlx4_rxq_attach(rxq);
                        if (!ret) {
                                wq_num = rxq->wq->wq_num;
@@ -432,7 +433,7 @@ error:
        ERROR("cannot initialize common RSS resources (queue %u): %s: %s",
              i, msg, strerror(ret));
        while (i--) {
-               struct rxq *rxq = priv->dev->data->rx_queues[i];
+               struct rxq *rxq = ETH_DEV(priv)->data->rx_queues[i];
 
                if (rxq)
                        mlx4_rxq_detach(rxq);
@@ -451,17 +452,17 @@ error:
  *   Pointer to private structure.
  */
 void
-mlx4_rss_deinit(struct priv *priv)
+mlx4_rss_deinit(struct mlx4_priv *priv)
 {
        unsigned int i;
 
        if (!priv->rss_init)
                return;
-       for (i = 0; i != priv->dev->data->nb_rx_queues; ++i) {
-               struct rxq *rxq = priv->dev->data->rx_queues[i];
+       for (i = 0; i != ETH_DEV(priv)->data->nb_rx_queues; ++i) {
+               struct rxq *rxq = ETH_DEV(priv)->data->rx_queues[i];
 
                if (rxq) {
-                       assert(rxq->usecnt == 1);
+                       MLX4_ASSERT(rxq->usecnt == 1);
                        mlx4_rxq_detach(rxq);
                }
        }
@@ -486,15 +487,15 @@ int
 mlx4_rxq_attach(struct rxq *rxq)
 {
        if (rxq->usecnt++) {
-               assert(rxq->cq);
-               assert(rxq->wq);
-               assert(rxq->wqes);
-               assert(rxq->rq_db);
+               MLX4_ASSERT(rxq->cq);
+               MLX4_ASSERT(rxq->wq);
+               MLX4_ASSERT(rxq->wqes);
+               MLX4_ASSERT(rxq->rq_db);
                return 0;
        }
 
-       struct priv *priv = rxq->priv;
-       struct rte_eth_dev *dev = priv->dev;
+       struct mlx4_priv *priv = rxq->priv;
+       struct rte_eth_dev *dev = ETH_DEV(priv);
        const uint32_t elts_n = 1 << rxq->elts_n;
        const uint32_t sges_n = 1 << rxq->sges_n;
        struct rte_mbuf *(*elts)[elts_n] = rxq->elts;
@@ -510,7 +511,9 @@ mlx4_rxq_attach(struct rxq *rxq)
        unsigned int i;
        int ret;
 
-       assert(rte_is_power_of_2(elts_n));
+       MLX4_ASSERT(rte_is_power_of_2(elts_n));
+       priv->verbs_alloc_ctx.type = MLX4_VERBS_ALLOC_TYPE_RX_QUEUE;
+       priv->verbs_alloc_ctx.obj = rxq;
        cq = mlx4_glue->create_cq(priv->ctx, elts_n / sges_n, NULL,
                                  rxq->channel, 0);
        if (!cq) {
@@ -561,7 +564,7 @@ mlx4_rxq_attach(struct rxq *rxq)
        }
        /* Pre-register Rx mempool. */
        DEBUG("port %u Rx queue %u registering mp %s having %u chunks",
-             priv->dev->data->port_id, rxq->stats.idx,
+             ETH_DEV(priv)->data->port_id, rxq->stats.idx,
              rxq->mp->name, rxq->mp->nb_mem_chunks);
        mlx4_mr_update_mp(dev, &rxq->mr_ctrl, rxq->mp);
        wqes = (volatile struct mlx4_wqe_data_seg (*)[])
@@ -580,10 +583,10 @@ mlx4_rxq_attach(struct rxq *rxq)
                        goto error;
                }
                /* Headroom is reserved by rte_pktmbuf_alloc(). */
-               assert(buf->data_off == RTE_PKTMBUF_HEADROOM);
+               MLX4_ASSERT(buf->data_off == RTE_PKTMBUF_HEADROOM);
                /* Buffer is supposed to be empty. */
-               assert(rte_pktmbuf_data_len(buf) == 0);
-               assert(rte_pktmbuf_pkt_len(buf) == 0);
+               MLX4_ASSERT(rte_pktmbuf_data_len(buf) == 0);
+               MLX4_ASSERT(rte_pktmbuf_pkt_len(buf) == 0);
                /* Only the first segment keeps headroom. */
                if (i % sges_n)
                        buf->data_off = 0;
@@ -618,6 +621,7 @@ mlx4_rxq_attach(struct rxq *rxq)
        rxq->rq_ci = elts_n / sges_n;
        rte_wmb();
        *rxq->rq_db = rte_cpu_to_be_32(rxq->rq_ci);
+       priv->verbs_alloc_ctx.type = MLX4_VERBS_ALLOC_TYPE_NONE;
        return 0;
 error:
        if (wq)
@@ -628,6 +632,7 @@ error:
        rte_errno = ret;
        ERROR("error while attaching Rx queue %p: %s: %s",
              (void *)rxq, msg, strerror(ret));
+       priv->verbs_alloc_ctx.type = MLX4_VERBS_ALLOC_TYPE_NONE;
        return -ret;
 }
 
@@ -675,12 +680,12 @@ mlx4_rxq_detach(struct rxq *rxq)
  *   Supported Tx offloads.
  */
 uint64_t
-mlx4_get_rx_queue_offloads(struct priv *priv)
+mlx4_get_rx_queue_offloads(struct mlx4_priv *priv)
 {
        uint64_t offloads = DEV_RX_OFFLOAD_SCATTER |
-                           DEV_RX_OFFLOAD_CRC_STRIP |
                            DEV_RX_OFFLOAD_KEEP_CRC |
-                           DEV_RX_OFFLOAD_JUMBO_FRAME;
+                           DEV_RX_OFFLOAD_JUMBO_FRAME |
+                           DEV_RX_OFFLOAD_RSS_HASH;
 
        if (priv->hw_csum)
                offloads |= DEV_RX_OFFLOAD_CHECKSUM;
@@ -697,7 +702,7 @@ mlx4_get_rx_queue_offloads(struct priv *priv)
  *   Supported Rx offloads.
  */
 uint64_t
-mlx4_get_rx_port_offloads(struct priv *priv)
+mlx4_get_rx_port_offloads(struct mlx4_priv *priv)
 {
        uint64_t offloads = DEV_RX_OFFLOAD_VLAN_FILTER;
 
@@ -729,7 +734,7 @@ mlx4_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
                    unsigned int socket, const struct rte_eth_rxconf *conf,
                    struct rte_mempool *mp)
 {
-       struct priv *priv = dev->data->dev_private;
+       struct mlx4_priv *priv = dev->data->dev_private;
        uint32_t mb_len = rte_pktmbuf_data_room_size(mp);
        struct rte_mbuf *(*elts)[rte_align32pow2(desc)];
        struct rxq *rxq;
@@ -780,7 +785,7 @@ mlx4_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
        }
        /* By default, FCS (CRC) is stripped by hardware. */
        crc_present = 0;
-       if (rte_eth_dev_must_keep_crc(offloads)) {
+       if (offloads & DEV_RX_OFFLOAD_KEEP_CRC) {
                if (priv->hw_fcs_strip) {
                        crc_present = 1;
                } else {
@@ -822,7 +827,7 @@ mlx4_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
                .socket = socket,
        };
        /* Enable scattered packets support for this queue if necessary. */
-       assert(mb_len >= RTE_PKTMBUF_HEADROOM);
+       MLX4_ASSERT(mb_len >= RTE_PKTMBUF_HEADROOM);
        if (dev->data->dev_conf.rxmode.max_rx_pkt_len <=
            (mb_len - RTE_PKTMBUF_HEADROOM)) {
                ;
@@ -898,7 +903,7 @@ error:
        ret = rte_errno;
        mlx4_rx_queue_release(rxq);
        rte_errno = ret;
-       assert(rte_errno > 0);
+       MLX4_ASSERT(rte_errno > 0);
        return -rte_errno;
 }
 
@@ -912,23 +917,23 @@ void
 mlx4_rx_queue_release(void *dpdk_rxq)
 {
        struct rxq *rxq = (struct rxq *)dpdk_rxq;
-       struct priv *priv;
+       struct mlx4_priv *priv;
        unsigned int i;
 
        if (rxq == NULL)
                return;
        priv = rxq->priv;
-       for (i = 0; i != priv->dev->data->nb_rx_queues; ++i)
-               if (priv->dev->data->rx_queues[i] == rxq) {
+       for (i = 0; i != ETH_DEV(priv)->data->nb_rx_queues; ++i)
+               if (ETH_DEV(priv)->data->rx_queues[i] == rxq) {
                        DEBUG("%p: removing Rx queue %p from list",
-                             (void *)priv->dev, (void *)rxq);
-                       priv->dev->data->rx_queues[i] = NULL;
+                             (void *)ETH_DEV(priv), (void *)rxq);
+                       ETH_DEV(priv)->data->rx_queues[i] = NULL;
                        break;
                }
-       assert(!rxq->cq);
-       assert(!rxq->wq);
-       assert(!rxq->wqes);
-       assert(!rxq->rq_db);
+       MLX4_ASSERT(!rxq->cq);
+       MLX4_ASSERT(!rxq->wq);
+       MLX4_ASSERT(!rxq->wqes);
+       MLX4_ASSERT(!rxq->rq_db);
        if (rxq->channel)
                claim_zero(mlx4_glue->destroy_comp_channel(rxq->channel));
        mlx4_mr_btree_free(&rxq->mr_ctrl.cache_bh);