net/mlx5: support MPLS-in-GRE and MPLS-in-UDP
[dpdk.git] / drivers / net / mlx5 / mlx5_flow.c
index b71def5..3af9524 100644 (file)
@@ -91,11 +91,21 @@ mlx5_flow_create_vxlan(const struct rte_flow_item *item,
                       const void *default_mask,
                       struct mlx5_flow_data *data);
 
+static int
+mlx5_flow_create_vxlan_gpe(const struct rte_flow_item *item,
+                          const void *default_mask,
+                          struct mlx5_flow_data *data);
+
 static int
 mlx5_flow_create_gre(const struct rte_flow_item *item,
                     const void *default_mask,
                     struct mlx5_flow_data *data);
 
+static int
+mlx5_flow_create_mpls(const struct rte_flow_item *item,
+                     const void *default_mask,
+                     struct mlx5_flow_data *data);
+
 struct mlx5_flow_parse;
 
 static void
@@ -242,11 +252,15 @@ struct rte_flow {
 
 #define IS_TUNNEL(type) ( \
        (type) == RTE_FLOW_ITEM_TYPE_VXLAN || \
-       (type) == RTE_FLOW_ITEM_TYPE_GRE)
+       (type) == RTE_FLOW_ITEM_TYPE_VXLAN_GPE || \
+       (type) == RTE_FLOW_ITEM_TYPE_GRE || \
+       (type) == RTE_FLOW_ITEM_TYPE_MPLS)
 
 const uint32_t flow_ptype[] = {
        [RTE_FLOW_ITEM_TYPE_VXLAN] = RTE_PTYPE_TUNNEL_VXLAN,
+       [RTE_FLOW_ITEM_TYPE_VXLAN_GPE] = RTE_PTYPE_TUNNEL_VXLAN_GPE,
        [RTE_FLOW_ITEM_TYPE_GRE] = RTE_PTYPE_TUNNEL_GRE,
+       [RTE_FLOW_ITEM_TYPE_MPLS] = RTE_PTYPE_TUNNEL_MPLS_IN_GRE,
 };
 
 #define PTYPE_IDX(t) ((RTE_PTYPE_TUNNEL_MASK & (t)) >> 12)
@@ -254,7 +268,13 @@ const uint32_t flow_ptype[] = {
 const uint32_t ptype_ext[] = {
        [PTYPE_IDX(RTE_PTYPE_TUNNEL_VXLAN)] = RTE_PTYPE_TUNNEL_VXLAN |
                                              RTE_PTYPE_L4_UDP,
+       [PTYPE_IDX(RTE_PTYPE_TUNNEL_VXLAN_GPE)] = RTE_PTYPE_TUNNEL_VXLAN_GPE |
+                                                 RTE_PTYPE_L4_UDP,
        [PTYPE_IDX(RTE_PTYPE_TUNNEL_GRE)] = RTE_PTYPE_TUNNEL_GRE,
+       [PTYPE_IDX(RTE_PTYPE_TUNNEL_MPLS_IN_GRE)] =
+               RTE_PTYPE_TUNNEL_MPLS_IN_GRE,
+       [PTYPE_IDX(RTE_PTYPE_TUNNEL_MPLS_IN_UDP)] =
+               RTE_PTYPE_TUNNEL_MPLS_IN_GRE | RTE_PTYPE_L4_UDP,
 };
 
 /** Structure to generate a simple graph of layers supported by the NIC. */
@@ -311,6 +331,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
        [RTE_FLOW_ITEM_TYPE_END] = {
                .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH,
                               RTE_FLOW_ITEM_TYPE_VXLAN,
+                              RTE_FLOW_ITEM_TYPE_VXLAN_GPE,
                               RTE_FLOW_ITEM_TYPE_GRE),
        },
        [RTE_FLOW_ITEM_TYPE_ETH] = {
@@ -389,7 +410,9 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
                .dst_sz = sizeof(struct ibv_flow_spec_ipv6),
        },
        [RTE_FLOW_ITEM_TYPE_UDP] = {
-               .items = ITEMS(RTE_FLOW_ITEM_TYPE_VXLAN),
+               .items = ITEMS(RTE_FLOW_ITEM_TYPE_VXLAN,
+                              RTE_FLOW_ITEM_TYPE_VXLAN_GPE,
+                              RTE_FLOW_ITEM_TYPE_MPLS),
                .actions = valid_actions,
                .mask = &(const struct rte_flow_item_udp){
                        .hdr = {
@@ -418,7 +441,8 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
        [RTE_FLOW_ITEM_TYPE_GRE] = {
                .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH,
                               RTE_FLOW_ITEM_TYPE_IPV4,
-                              RTE_FLOW_ITEM_TYPE_IPV6),
+                              RTE_FLOW_ITEM_TYPE_IPV6,
+                              RTE_FLOW_ITEM_TYPE_MPLS),
                .actions = valid_actions,
                .mask = &(const struct rte_flow_item_gre){
                        .protocol = -1,
@@ -426,7 +450,26 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
                .default_mask = &rte_flow_item_gre_mask,
                .mask_sz = sizeof(struct rte_flow_item_gre),
                .convert = mlx5_flow_create_gre,
+#ifdef HAVE_IBV_DEVICE_MPLS_SUPPORT
+               .dst_sz = sizeof(struct ibv_flow_spec_gre),
+#else
                .dst_sz = sizeof(struct ibv_flow_spec_tunnel),
+#endif
+       },
+       [RTE_FLOW_ITEM_TYPE_MPLS] = {
+               .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH,
+                              RTE_FLOW_ITEM_TYPE_IPV4,
+                              RTE_FLOW_ITEM_TYPE_IPV6),
+               .actions = valid_actions,
+               .mask = &(const struct rte_flow_item_mpls){
+                       .label_tc_s = "\xff\xff\xf0",
+               },
+               .default_mask = &rte_flow_item_mpls_mask,
+               .mask_sz = sizeof(struct rte_flow_item_mpls),
+               .convert = mlx5_flow_create_mpls,
+#ifdef HAVE_IBV_DEVICE_MPLS_SUPPORT
+               .dst_sz = sizeof(struct ibv_flow_spec_mpls),
+#endif
        },
        [RTE_FLOW_ITEM_TYPE_VXLAN] = {
                .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH,
@@ -441,6 +484,19 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
                .convert = mlx5_flow_create_vxlan,
                .dst_sz = sizeof(struct ibv_flow_spec_tunnel),
        },
+       [RTE_FLOW_ITEM_TYPE_VXLAN_GPE] = {
+               .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH,
+                              RTE_FLOW_ITEM_TYPE_IPV4,
+                              RTE_FLOW_ITEM_TYPE_IPV6),
+               .actions = valid_actions,
+               .mask = &(const struct rte_flow_item_vxlan_gpe){
+                       .vni = "\xff\xff\xff",
+               },
+               .default_mask = &rte_flow_item_vxlan_gpe_mask,
+               .mask_sz = sizeof(struct rte_flow_item_vxlan_gpe),
+               .convert = mlx5_flow_create_vxlan_gpe,
+               .dst_sz = sizeof(struct ibv_flow_spec_tunnel),
+       },
 };
 
 /** Structure to pass to the conversion function. */
@@ -514,7 +570,7 @@ struct ibv_spec_header {
 };
 
 /**
- * Check support for a given item.
+ * Check item is fully supported by the NIC matching capability.
  *
  * @param item[in]
  *   Item specification.
@@ -531,60 +587,33 @@ static int
 mlx5_flow_item_validate(const struct rte_flow_item *item,
                        const uint8_t *mask, unsigned int size)
 {
-       if (!item->spec && (item->mask || item->last)) {
-               rte_errno = EINVAL;
-               return -rte_errno;
-       }
-       if (item->spec && !item->mask) {
-               unsigned int i;
-               const uint8_t *spec = item->spec;
-
-               for (i = 0; i < size; ++i)
-                       if ((spec[i] | mask[i]) != mask[i]) {
-                               rte_errno = EINVAL;
-                               return -rte_errno;
-                       }
-       }
-       if (item->last && !item->mask) {
-               unsigned int i;
-               const uint8_t *spec = item->last;
-
-               for (i = 0; i < size; ++i)
-                       if ((spec[i] | mask[i]) != mask[i]) {
-                               rte_errno = EINVAL;
-                               return -rte_errno;
-                       }
-       }
-       if (item->mask) {
-               unsigned int i;
-               const uint8_t *spec = item->spec;
-
-               for (i = 0; i < size; ++i)
-                       if ((spec[i] | mask[i]) != mask[i]) {
-                               rte_errno = EINVAL;
-                               return -rte_errno;
-                       }
-       }
-       if (item->spec && item->last) {
-               uint8_t spec[size];
-               uint8_t last[size];
-               const uint8_t *apply = mask;
-               unsigned int i;
-               int ret;
+       unsigned int i;
+       const uint8_t *spec = item->spec;
+       const uint8_t *last = item->last;
+       const uint8_t *m = item->mask ? item->mask : mask;
 
-               if (item->mask)
-                       apply = item->mask;
-               for (i = 0; i < size; ++i) {
-                       spec[i] = ((const uint8_t *)item->spec)[i] & apply[i];
-                       last[i] = ((const uint8_t *)item->last)[i] & apply[i];
-               }
-               ret = memcmp(spec, last, size);
-               if (ret != 0) {
-                       rte_errno = EINVAL;
-                       return -rte_errno;
-               }
+       if (!spec && (item->mask || last))
+               goto error;
+       if (!spec)
+               return 0;
+       /*
+        * Single-pass check to make sure that:
+        * - item->mask is supported, no bits are set outside mask.
+        * - Both masked item->spec and item->last are equal (no range
+        *   supported).
+        */
+       for (i = 0; i < size; i++) {
+               if (!m[i])
+                       continue;
+               if ((m[i] | mask[i]) != mask[i])
+                       goto error;
+               if (last && ((spec[i] & m[i]) != (last[i] & m[i])))
+                       goto error;
        }
        return 0;
+error:
+       rte_errno = ENOTSUP;
+       return -rte_errno;
 }
 
 /**
@@ -868,6 +897,7 @@ mlx5_flow_convert_items_validate(struct rte_eth_dev *dev,
        struct priv *priv = dev->data->dev_private;
        const struct mlx5_flow_items *cur_item = mlx5_flow_items;
        unsigned int i;
+       unsigned int last_voids = 0;
        int ret = 0;
 
        /* Initialise the offsets to start after verbs attribute. */
@@ -877,8 +907,10 @@ mlx5_flow_convert_items_validate(struct rte_eth_dev *dev,
                const struct mlx5_flow_items *token = NULL;
                unsigned int n;
 
-               if (items->type == RTE_FLOW_ITEM_TYPE_VOID)
+               if (items->type == RTE_FLOW_ITEM_TYPE_VOID) {
+                       last_voids++;
                        continue;
+               }
                for (i = 0;
                     cur_item->items &&
                     cur_item->items[i] != RTE_FLOW_ITEM_TYPE_END;
@@ -899,7 +931,10 @@ mlx5_flow_convert_items_validate(struct rte_eth_dev *dev,
                if (ret)
                        goto exit_item_not_supported;
                if (IS_TUNNEL(items->type)) {
-                       if (parser->tunnel) {
+                       if (parser->tunnel &&
+                           !((items - last_voids - 1)->type ==
+                             RTE_FLOW_ITEM_TYPE_GRE && items->type ==
+                             RTE_FLOW_ITEM_TYPE_MPLS)) {
                                rte_flow_error_set(error, ENOTSUP,
                                                   RTE_FLOW_ERROR_TYPE_ITEM,
                                                   items,
@@ -907,6 +942,16 @@ mlx5_flow_convert_items_validate(struct rte_eth_dev *dev,
                                                   " tunnel encapsulations.");
                                return -rte_errno;
                        }
+                       if (items->type == RTE_FLOW_ITEM_TYPE_MPLS &&
+                           !priv->config.mpls_en) {
+                               rte_flow_error_set(error, ENOTSUP,
+                                                  RTE_FLOW_ERROR_TYPE_ITEM,
+                                                  items,
+                                                  "MPLS not supported or"
+                                                  " disabled in firmware"
+                                                  " configuration.");
+                               return -rte_errno;
+                       }
                        if (!priv->config.tunnel_en &&
                            parser->rss_conf.level > 1) {
                                rte_flow_error_set(error, ENOTSUP,
@@ -924,6 +969,7 @@ mlx5_flow_convert_items_validate(struct rte_eth_dev *dev,
                        for (n = 0; n != hash_rxq_init_n; ++n)
                                parser->queue[n].offset += cur_item->dst_sz;
                }
+               last_voids = 0;
        }
        if (parser->drop) {
                parser->queue[HASH_RXQ_ETH].offset +=
@@ -1776,7 +1822,8 @@ mlx5_flow_create_vxlan(const struct rte_flow_item *item,
         * before will also match this rule.
         * To avoid such situation, VNI 0 is currently refused.
         */
-       if (!vxlan.val.tunnel_id)
+       /* Only allow tunnel w/o tunnel id pattern after proper outer spec. */
+       if (parser->out_layer == HASH_RXQ_ETH && !vxlan.val.tunnel_id)
                return rte_flow_error_set(data->error, EINVAL,
                                          RTE_FLOW_ERROR_TYPE_ITEM,
                                          item,
@@ -1785,6 +1832,87 @@ mlx5_flow_create_vxlan(const struct rte_flow_item *item,
        return 0;
 }
 
+/**
+ * Convert VXLAN-GPE item to Verbs specification.
+ *
+ * @param item[in]
+ *   Item specification.
+ * @param default_mask[in]
+ *   Default bit-masks to use when item->mask is not provided.
+ * @param data[in, out]
+ *   User structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+mlx5_flow_create_vxlan_gpe(const struct rte_flow_item *item,
+                          const void *default_mask,
+                          struct mlx5_flow_data *data)
+{
+       struct priv *priv = data->dev->data->dev_private;
+       const struct rte_flow_item_vxlan_gpe *spec = item->spec;
+       const struct rte_flow_item_vxlan_gpe *mask = item->mask;
+       struct mlx5_flow_parse *parser = data->parser;
+       unsigned int size = sizeof(struct ibv_flow_spec_tunnel);
+       struct ibv_flow_spec_tunnel vxlan = {
+               .type = parser->inner | IBV_FLOW_SPEC_VXLAN_TUNNEL,
+               .size = size,
+       };
+       union vni {
+               uint32_t vlan_id;
+               uint8_t vni[4];
+       } id;
+
+       if (!priv->config.l3_vxlan_en)
+               return rte_flow_error_set(data->error, EINVAL,
+                                         RTE_FLOW_ERROR_TYPE_ITEM,
+                                         item,
+                                         "L3 VXLAN not enabled by device"
+                                         " parameter and/or not configured"
+                                         " in firmware");
+       id.vni[0] = 0;
+       parser->inner = IBV_FLOW_SPEC_INNER;
+       parser->tunnel = ptype_ext[PTYPE_IDX(RTE_PTYPE_TUNNEL_VXLAN_GPE)];
+       parser->out_layer = parser->layer;
+       parser->layer = HASH_RXQ_TUNNEL;
+       /* Default VXLAN-GPE to outer RSS. */
+       if (!parser->rss_conf.level)
+               parser->rss_conf.level = 1;
+       if (spec) {
+               if (!mask)
+                       mask = default_mask;
+               memcpy(&id.vni[1], spec->vni, 3);
+               vxlan.val.tunnel_id = id.vlan_id;
+               memcpy(&id.vni[1], mask->vni, 3);
+               vxlan.mask.tunnel_id = id.vlan_id;
+               if (spec->protocol)
+                       return rte_flow_error_set(data->error, EINVAL,
+                                                 RTE_FLOW_ERROR_TYPE_ITEM,
+                                                 item,
+                                                 "VxLAN-GPE protocol not"
+                                                 " supported");
+               /* Remove unwanted bits from values. */
+               vxlan.val.tunnel_id &= vxlan.mask.tunnel_id;
+       }
+       /*
+        * Tunnel id 0 is equivalent as not adding a VXLAN layer, if only this
+        * layer is defined in the Verbs specification it is interpreted as
+        * wildcard and all packets will match this rule, if it follows a full
+        * stack layer (ex: eth / ipv4 / udp), all packets matching the layers
+        * before will also match this rule.
+        * To avoid such situation, VNI 0 is currently refused.
+        */
+       /* Only allow tunnel w/o tunnel id pattern after proper outer spec. */
+       if (parser->out_layer == HASH_RXQ_ETH && !vxlan.val.tunnel_id)
+               return rte_flow_error_set(data->error, EINVAL,
+                                         RTE_FLOW_ERROR_TYPE_ITEM,
+                                         item,
+                                         "VxLAN-GPE vni cannot be 0");
+       mlx5_flow_create_copy(parser, &vxlan, size);
+       return 0;
+}
+
 /**
  * Convert GRE item to Verbs specification.
  *
@@ -1799,16 +1927,27 @@ mlx5_flow_create_vxlan(const struct rte_flow_item *item,
  *   0 on success, a negative errno value otherwise and rte_errno is set.
  */
 static int
-mlx5_flow_create_gre(const struct rte_flow_item *item __rte_unused,
-                    const void *default_mask __rte_unused,
+mlx5_flow_create_gre(const struct rte_flow_item *item,
+                    const void *default_mask,
                     struct mlx5_flow_data *data)
 {
        struct mlx5_flow_parse *parser = data->parser;
+#ifndef HAVE_IBV_DEVICE_MPLS_SUPPORT
+       (void)default_mask;
        unsigned int size = sizeof(struct ibv_flow_spec_tunnel);
        struct ibv_flow_spec_tunnel tunnel = {
                .type = parser->inner | IBV_FLOW_SPEC_VXLAN_TUNNEL,
                .size = size,
        };
+#else
+       const struct rte_flow_item_gre *spec = item->spec;
+       const struct rte_flow_item_gre *mask = item->mask;
+       unsigned int size = sizeof(struct ibv_flow_spec_gre);
+       struct ibv_flow_spec_gre tunnel = {
+               .type = parser->inner | IBV_FLOW_SPEC_GRE,
+               .size = size,
+       };
+#endif
        struct ibv_flow_spec_ipv4_ext *ipv4;
        struct ibv_flow_spec_ipv6 *ipv6;
        unsigned int i;
@@ -1820,6 +1959,20 @@ mlx5_flow_create_gre(const struct rte_flow_item *item __rte_unused,
        /* Default GRE to inner RSS. */
        if (!parser->rss_conf.level)
                parser->rss_conf.level = 2;
+#ifdef HAVE_IBV_DEVICE_MPLS_SUPPORT
+       if (spec) {
+               if (!mask)
+                       mask = default_mask;
+               tunnel.val.c_ks_res0_ver = spec->c_rsvd0_ver;
+               tunnel.val.protocol = spec->protocol;
+               tunnel.mask.c_ks_res0_ver = mask->c_rsvd0_ver;
+               tunnel.mask.protocol = mask->protocol;
+               /* Remove unwanted bits from values. */
+               tunnel.val.c_ks_res0_ver &= tunnel.mask.c_ks_res0_ver;
+               tunnel.val.protocol &= tunnel.mask.protocol;
+               tunnel.val.key &= tunnel.mask.key;
+       }
+#endif
        /* Update encapsulation IP layer protocol. */
        for (i = 0; i != hash_rxq_init_n; ++i) {
                if (!parser->queue[i].ibv_attr)
@@ -1852,6 +2005,79 @@ mlx5_flow_create_gre(const struct rte_flow_item *item __rte_unused,
        return 0;
 }
 
+/**
+ * Convert MPLS item to Verbs specification.
+ * MPLS tunnel types currently supported are MPLS-in-GRE and MPLS-in-UDP.
+ *
+ * @param item[in]
+ *   Item specification.
+ * @param default_mask[in]
+ *   Default bit-masks to use when item->mask is not provided.
+ * @param data[in, out]
+ *   User structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+mlx5_flow_create_mpls(const struct rte_flow_item *item,
+                     const void *default_mask,
+                     struct mlx5_flow_data *data)
+{
+#ifndef HAVE_IBV_DEVICE_MPLS_SUPPORT
+       (void)default_mask;
+       return rte_flow_error_set(data->error, ENOTSUP,
+                                 RTE_FLOW_ERROR_TYPE_ITEM,
+                                 item,
+                                 "MPLS is not supported by driver");
+#else
+       const struct rte_flow_item_mpls *spec = item->spec;
+       const struct rte_flow_item_mpls *mask = item->mask;
+       struct mlx5_flow_parse *parser = data->parser;
+       unsigned int size = sizeof(struct ibv_flow_spec_mpls);
+       struct ibv_flow_spec_mpls mpls = {
+               .type = IBV_FLOW_SPEC_MPLS,
+               .size = size,
+       };
+
+       parser->inner = IBV_FLOW_SPEC_INNER;
+       if (parser->layer == HASH_RXQ_UDPV4 ||
+           parser->layer == HASH_RXQ_UDPV6) {
+               parser->tunnel =
+                       ptype_ext[PTYPE_IDX(RTE_PTYPE_TUNNEL_MPLS_IN_UDP)];
+               parser->out_layer = parser->layer;
+       } else {
+               parser->tunnel =
+                       ptype_ext[PTYPE_IDX(RTE_PTYPE_TUNNEL_MPLS_IN_GRE)];
+               /* parser->out_layer stays as in GRE out_layer. */
+       }
+       parser->layer = HASH_RXQ_TUNNEL;
+       /*
+        * For MPLS-in-GRE, RSS level should have been set.
+        * For MPLS-in-UDP, use outer RSS.
+        */
+       if (!parser->rss_conf.level)
+               parser->rss_conf.level = 1;
+       if (spec) {
+               if (!mask)
+                       mask = default_mask;
+               /*
+                * The verbs label field includes the entire MPLS header:
+                * bits 0:19 - label value field.
+                * bits 20:22 - traffic class field.
+                * bits 23 - bottom of stack bit.
+                * bits 24:31 - ttl field.
+                */
+               mpls.val.label = *(const uint32_t *)spec;
+               mpls.mask.label = *(const uint32_t *)mask;
+               /* Remove unwanted bits from values. */
+               mpls.val.label &= mpls.mask.label;
+       }
+       mlx5_flow_create_copy(parser, &mpls, size);
+       return 0;
+#endif
+}
+
 /**
  * Convert mark/flag action to Verbs specification.
  *
@@ -1955,7 +2181,7 @@ mlx5_flow_create_action_queue_drop(struct rte_eth_dev *dev,
                parser->queue[HASH_RXQ_ETH].ibv_attr;
        if (parser->count)
                flow->cs = parser->cs;
-       if (!priv->dev->data->dev_started)
+       if (!dev->data->dev_started)
                return 0;
        parser->queue[HASH_RXQ_ETH].ibv_attr = NULL;
        flow->frxq[HASH_RXQ_ETH].ibv_flow =
@@ -2007,7 +2233,6 @@ mlx5_flow_create_action_queue_rss(struct rte_eth_dev *dev,
                                  struct rte_flow *flow,
                                  struct rte_flow_error *error)
 {
-       struct priv *priv = dev->data->dev_private;
        unsigned int i;
 
        for (i = 0; i != hash_rxq_init_n; ++i) {
@@ -2016,7 +2241,7 @@ mlx5_flow_create_action_queue_rss(struct rte_eth_dev *dev,
                flow->frxq[i].ibv_attr = parser->queue[i].ibv_attr;
                parser->queue[i].ibv_attr = NULL;
                flow->frxq[i].hash_fields = parser->queue[i].hash_fields;
-               if (!priv->dev->data->dev_started)
+               if (!dev->data->dev_started)
                        continue;
                flow->frxq[i].hrxq =
                        mlx5_hrxq_get(dev,
@@ -2090,6 +2315,57 @@ mlx5_flow_create_update_rxqs(struct rte_eth_dev *dev, struct rte_flow *flow)
        }
 }
 
+/**
+ * Dump flow hash RX queue detail.
+ *
+ * @param dev
+ *   Pointer to Ethernet device.
+ * @param flow
+ *   Pointer to the rte_flow.
+ * @param hrxq_idx
+ *   Hash RX queue index.
+ */
+static void
+mlx5_flow_dump(struct rte_eth_dev *dev __rte_unused,
+              struct rte_flow *flow __rte_unused,
+              unsigned int hrxq_idx __rte_unused)
+{
+#ifndef NDEBUG
+       uintptr_t spec_ptr;
+       uint16_t j;
+       char buf[256];
+       uint8_t off;
+
+       spec_ptr = (uintptr_t)(flow->frxq[hrxq_idx].ibv_attr + 1);
+       for (j = 0, off = 0; j < flow->frxq[hrxq_idx].ibv_attr->num_of_specs;
+            j++) {
+               struct ibv_flow_spec *spec = (void *)spec_ptr;
+               off += sprintf(buf + off, " %x(%hu)", spec->hdr.type,
+                              spec->hdr.size);
+               spec_ptr += spec->hdr.size;
+       }
+       DRV_LOG(DEBUG,
+               "port %u Verbs flow %p type %u: hrxq:%p qp:%p ind:%p,"
+               " hash:%" PRIx64 "/%u specs:%hhu(%hu), priority:%hu, type:%d,"
+               " flags:%x, comp_mask:%x specs:%s",
+               dev->data->port_id, (void *)flow, hrxq_idx,
+               (void *)flow->frxq[hrxq_idx].hrxq,
+               (void *)flow->frxq[hrxq_idx].hrxq->qp,
+               (void *)flow->frxq[hrxq_idx].hrxq->ind_table,
+               flow->frxq[hrxq_idx].hash_fields |
+               (flow->tunnel &&
+                flow->rss_conf.level > 1 ? (uint32_t)IBV_RX_HASH_INNER : 0),
+               flow->rss_conf.queue_num,
+               flow->frxq[hrxq_idx].ibv_attr->num_of_specs,
+               flow->frxq[hrxq_idx].ibv_attr->size,
+               flow->frxq[hrxq_idx].ibv_attr->priority,
+               flow->frxq[hrxq_idx].ibv_attr->type,
+               flow->frxq[hrxq_idx].ibv_attr->flags,
+               flow->frxq[hrxq_idx].ibv_attr->comp_mask,
+               buf);
+#endif
+}
+
 /**
  * Complete flow rule creation.
  *
@@ -2111,7 +2387,7 @@ mlx5_flow_create_action_queue(struct rte_eth_dev *dev,
                              struct rte_flow *flow,
                              struct rte_flow_error *error)
 {
-       struct priv *priv = dev->data->dev_private;
+       struct priv *priv __rte_unused = dev->data->dev_private;
        int ret;
        unsigned int i;
        unsigned int flows_n = 0;
@@ -2124,7 +2400,7 @@ mlx5_flow_create_action_queue(struct rte_eth_dev *dev,
                goto error;
        if (parser->count)
                flow->cs = parser->cs;
-       if (!priv->dev->data->dev_started)
+       if (!dev->data->dev_started)
                return 0;
        for (i = 0; i != hash_rxq_init_n; ++i) {
                if (!flow->frxq[i].hrxq)
@@ -2132,6 +2408,7 @@ mlx5_flow_create_action_queue(struct rte_eth_dev *dev,
                flow->frxq[i].ibv_flow =
                        mlx5_glue->create_flow(flow->frxq[i].hrxq->qp,
                                               flow->frxq[i].ibv_attr);
+               mlx5_flow_dump(dev, flow, i);
                if (!flow->frxq[i].ibv_flow) {
                        rte_flow_error_set(error, ENOMEM,
                                           RTE_FLOW_ERROR_TYPE_HANDLE,
@@ -2139,11 +2416,6 @@ mlx5_flow_create_action_queue(struct rte_eth_dev *dev,
                        goto error;
                }
                ++flows_n;
-               DRV_LOG(DEBUG, "port %u %p type %d QP %p ibv_flow %p",
-                       dev->data->port_id,
-                       (void *)flow, i,
-                       (void *)flow->frxq[i].hrxq->qp,
-                       (void *)flow->frxq[i].ibv_flow);
        }
        if (!flows_n) {
                rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE,
@@ -2687,24 +2959,25 @@ mlx5_flow_start(struct rte_eth_dev *dev, struct mlx5_flows *list)
                                              flow->rss_conf.level);
                        if (!flow->frxq[i].hrxq) {
                                DRV_LOG(DEBUG,
-                                       "port %u flow %p cannot be applied",
+                                       "port %u flow %p cannot create hash"
+                                       " rxq",
                                        dev->data->port_id, (void *)flow);
                                rte_errno = EINVAL;
                                return -rte_errno;
                        }
 flow_create:
+                       mlx5_flow_dump(dev, flow, i);
                        flow->frxq[i].ibv_flow =
                                mlx5_glue->create_flow(flow->frxq[i].hrxq->qp,
                                                       flow->frxq[i].ibv_attr);
                        if (!flow->frxq[i].ibv_flow) {
                                DRV_LOG(DEBUG,
-                                       "port %u flow %p cannot be applied",
-                                       dev->data->port_id, (void *)flow);
+                                       "port %u flow %p type %u cannot be"
+                                       " applied",
+                                       dev->data->port_id, (void *)flow, i);
                                rte_errno = EINVAL;
                                return -rte_errno;
                        }
-                       DRV_LOG(DEBUG, "port %u flow %p applied",
-                               dev->data->port_id, (void *)flow);
                }
                mlx5_flow_create_update_rxqs(dev, flow);
        }
@@ -2925,7 +3198,7 @@ mlx5_flow_query_count(struct ibv_counter_set *cs,
 int
 mlx5_flow_query(struct rte_eth_dev *dev __rte_unused,
                struct rte_flow *flow,
-               enum rte_flow_action_type action __rte_unused,
+               const struct rte_flow_action *action __rte_unused,
                void *data,
                struct rte_flow_error *error)
 {
@@ -2970,9 +3243,9 @@ mlx5_flow_isolate(struct rte_eth_dev *dev,
        }
        priv->isolated = !!enable;
        if (enable)
-               priv->dev->dev_ops = &mlx5_dev_ops_isolate;
+               dev->dev_ops = &mlx5_dev_ops_isolate;
        else
-               priv->dev->dev_ops = &mlx5_dev_ops;
+               dev->dev_ops = &mlx5_dev_ops;
        return 0;
 }
 
@@ -3271,11 +3544,14 @@ mlx5_fdir_filter_delete(struct rte_eth_dev *dev,
                struct ibv_spec_header *flow_h;
                void *flow_spec;
                unsigned int specs_n;
+               unsigned int queue_id = parser.drop ? HASH_RXQ_ETH :
+                                                     parser.layer;
 
-               attr = parser.queue[HASH_RXQ_ETH].ibv_attr;
-               flow_attr = flow->frxq[HASH_RXQ_ETH].ibv_attr;
+               attr = parser.queue[queue_id].ibv_attr;
+               flow_attr = flow->frxq[queue_id].ibv_attr;
                /* Compare first the attributes. */
-               if (memcmp(attr, flow_attr, sizeof(struct ibv_flow_attr)))
+               if (!flow_attr ||
+                   memcmp(attr, flow_attr, sizeof(struct ibv_flow_attr)))
                        continue;
                if (attr->num_of_specs == 0)
                        continue;
@@ -3360,11 +3636,10 @@ mlx5_fdir_filter_flush(struct rte_eth_dev *dev)
 static void
 mlx5_fdir_info_get(struct rte_eth_dev *dev, struct rte_eth_fdir_info *fdir_info)
 {
-       struct priv *priv = dev->data->dev_private;
        struct rte_eth_fdir_masks *mask =
-               &priv->dev->data->dev_conf.fdir_conf.mask;
+               &dev->data->dev_conf.fdir_conf.mask;
 
-       fdir_info->mode = priv->dev->data->dev_conf.fdir_conf.mode;
+       fdir_info->mode = dev->data->dev_conf.fdir_conf.mode;
        fdir_info->guarant_spc = 0;
        rte_memcpy(&fdir_info->mask, mask, sizeof(fdir_info->mask));
        fdir_info->max_flexpayload = 0;
@@ -3392,9 +3667,8 @@ static int
 mlx5_fdir_ctrl_func(struct rte_eth_dev *dev, enum rte_filter_op filter_op,
                    void *arg)
 {
-       struct priv *priv = dev->data->dev_private;
        enum rte_fdir_mode fdir_mode =
-               priv->dev->data->dev_conf.fdir_conf.mode;
+               dev->data->dev_conf.fdir_conf.mode;
 
        if (filter_op == RTE_ETH_FILTER_NOP)
                return 0;