net/mlx5: fix default context in flow age action
[dpdk.git] / drivers / net / mlx5 / mlx5_flow_dv.c
index 70e8d0b..7fc7efb 100644 (file)
@@ -6627,10 +6627,12 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
        uint32_t rw_act_num = 0;
        uint64_t is_root;
        const struct mlx5_flow_tunnel *tunnel;
+       enum mlx5_tof_rule_type tof_rule_type;
        struct flow_grp_info grp_info = {
                .external = !!external,
                .transfer = !!attr->transfer,
                .fdb_def_rule = !!priv->fdb_def_rule,
+               .std_tbl_fix = true,
        };
        const struct rte_eth_hairpin_conf *conf;
        const struct rte_flow_item *rule_items = items;
@@ -6638,23 +6640,22 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
 
        if (items == NULL)
                return -1;
-       if (is_flow_tunnel_match_rule(dev, attr, items, actions)) {
-               tunnel = flow_items_to_tunnel(items);
-               action_flags |= MLX5_FLOW_ACTION_TUNNEL_MATCH |
-                               MLX5_FLOW_ACTION_DECAP;
-       } else if (is_flow_tunnel_steer_rule(dev, attr, items, actions)) {
-               tunnel = flow_actions_to_tunnel(actions);
-               action_flags |= MLX5_FLOW_ACTION_TUNNEL_SET;
-       } else {
-               tunnel = NULL;
+       tunnel = is_tunnel_offload_active(dev) ?
+                mlx5_get_tof(items, actions, &tof_rule_type) : NULL;
+       if (tunnel) {
+               if (priv->representor)
+                       return rte_flow_error_set
+                               (error, ENOTSUP,
+                                RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+                                NULL, "decap not supported for VF representor");
+               if (tof_rule_type == MLX5_TUNNEL_OFFLOAD_SET_RULE)
+                       action_flags |= MLX5_FLOW_ACTION_TUNNEL_SET;
+               else if (tof_rule_type == MLX5_TUNNEL_OFFLOAD_MATCH_RULE)
+                       action_flags |= MLX5_FLOW_ACTION_TUNNEL_MATCH |
+                                       MLX5_FLOW_ACTION_DECAP;
+               grp_info.std_tbl_fix = tunnel_use_standard_attr_group_translate
+                                       (dev, attr, tunnel, tof_rule_type);
        }
-       if (tunnel && priv->representor)
-               return rte_flow_error_set(error, ENOTSUP,
-                                         RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
-                                         "decap not supported "
-                                         "for VF representor");
-       grp_info.std_tbl_fix = tunnel_use_standard_attr_group_translate
-                               (dev, tunnel, attr, items, actions);
        ret = flow_dv_validate_attributes(dev, tunnel, attr, &grp_info, error);
        if (ret < 0)
                return ret;
@@ -6668,15 +6669,6 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
                                                  RTE_FLOW_ERROR_TYPE_ITEM,
                                                  NULL, "item not supported");
                switch (type) {
-               case MLX5_RTE_FLOW_ITEM_TYPE_TUNNEL:
-                       if (items[0].type != (typeof(items[0].type))
-                                               MLX5_RTE_FLOW_ITEM_TYPE_TUNNEL)
-                               return rte_flow_error_set
-                                               (error, EINVAL,
-                                               RTE_FLOW_ERROR_TYPE_ITEM,
-                                               NULL, "MLX5 private items "
-                                               "must be the first");
-                       break;
                case RTE_FLOW_ITEM_TYPE_VOID:
                        break;
                case RTE_FLOW_ITEM_TYPE_PORT_ID:
@@ -6975,6 +6967,11 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
                        if (ret < 0)
                                return ret;
                        break;
+               case MLX5_RTE_FLOW_ITEM_TYPE_TUNNEL:
+                       /* tunnel offload item was processed before
+                        * list it here as a supported type
+                        */
+                       break;
                default:
                        return rte_flow_error_set(error, ENOTSUP,
                                                  RTE_FLOW_ERROR_TYPE_ITEM,
@@ -7516,17 +7513,6 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
                        action_flags |= MLX5_FLOW_ACTION_SAMPLE;
                        ++actions_n;
                        break;
-               case MLX5_RTE_FLOW_ACTION_TYPE_TUNNEL_SET:
-                       if (actions[0].type != (typeof(actions[0].type))
-                               MLX5_RTE_FLOW_ACTION_TYPE_TUNNEL_SET)
-                               return rte_flow_error_set
-                                               (error, EINVAL,
-                                               RTE_FLOW_ERROR_TYPE_ACTION,
-                                               NULL, "MLX5 private action "
-                                               "must be the first");
-
-                       action_flags |= MLX5_FLOW_ACTION_TUNNEL_SET;
-                       break;
                case RTE_FLOW_ACTION_TYPE_MODIFY_FIELD:
                        ret = flow_dv_validate_action_modify_field(dev,
                                                                   action_flags,
@@ -7551,6 +7537,11 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,
                                return ret;
                        action_flags |= MLX5_FLOW_ACTION_CT;
                        break;
+               case MLX5_RTE_FLOW_ACTION_TYPE_TUNNEL_SET:
+                       /* tunnel offload action was processed before
+                        * list it here as a supported type
+                        */
+                       break;
                default:
                        return rte_flow_error_set(error, ENOTSUP,
                                                  RTE_FLOW_ERROR_TYPE_ACTION,
@@ -11492,38 +11483,35 @@ flow_dv_aso_age_alloc(struct rte_eth_dev *dev, struct rte_flow_error *error)
 }
 
 /**
- * Create a age action using ASO mechanism.
+ * Initialize flow ASO age parameters.
  *
  * @param[in] dev
  *   Pointer to rte_eth_dev structure.
- * @param[in] age
- *   Pointer to the aging action configuration.
- * @param[out] error
- *   Pointer to the error structure.
+ * @param[in] age_idx
+ *   Index of ASO age action.
+ * @param[in] context
+ *   Pointer to flow counter age context.
+ * @param[in] timeout
+ *   Aging timeout in seconds.
  *
- * @return
- *   Index to flow counter on success, 0 otherwise.
  */
-static uint32_t
-flow_dv_translate_create_aso_age(struct rte_eth_dev *dev,
-                                const struct rte_flow_action_age *age,
-                                struct rte_flow_error *error)
+static void
+flow_dv_aso_age_params_init(struct rte_eth_dev *dev,
+                           uint32_t age_idx,
+                           void *context,
+                           uint32_t timeout)
 {
-       uint32_t age_idx = 0;
        struct mlx5_aso_age_action *aso_age;
 
-       age_idx = flow_dv_aso_age_alloc(dev, error);
-       if (!age_idx)
-               return 0;
        aso_age = flow_aso_age_get_by_idx(dev, age_idx);
-       aso_age->age_params.context = age->context;
-       aso_age->age_params.timeout = age->timeout;
+       MLX5_ASSERT(aso_age);
+       aso_age->age_params.context = context;
+       aso_age->age_params.timeout = timeout;
        aso_age->age_params.port_id = dev->data->port_id;
        __atomic_store_n(&aso_age->age_params.sec_since_last_hit, 0,
                         __ATOMIC_RELAXED);
        __atomic_store_n(&aso_age->age_params.state, AGE_CANDIDATE,
                         __ATOMIC_RELAXED);
-       return age_idx;
 }
 
 static void
@@ -12035,13 +12023,14 @@ flow_dv_translate(struct rte_eth_dev *dev,
        int tmp_actions_n = 0;
        uint32_t table;
        int ret = 0;
-       const struct mlx5_flow_tunnel *tunnel;
+       const struct mlx5_flow_tunnel *tunnel = NULL;
        struct flow_grp_info grp_info = {
                .external = !!dev_flow->external,
                .transfer = !!attr->transfer,
                .fdb_def_rule = !!priv->fdb_def_rule,
                .skip_scale = dev_flow->skip_scale &
                        (1 << MLX5_SCALE_FLOW_GROUP_BIT),
+               .std_tbl_fix = true,
        };
        const struct rte_flow_item *head_item = items;
 
@@ -12057,15 +12046,21 @@ flow_dv_translate(struct rte_eth_dev *dev,
                                           MLX5DV_FLOW_TABLE_TYPE_NIC_RX;
        /* update normal path action resource into last index of array */
        sample_act = &mdest_res.sample_act[MLX5_MAX_DEST_NUM - 1];
-       tunnel = is_flow_tunnel_match_rule(dev, attr, items, actions) ?
-                flow_items_to_tunnel(items) :
-                is_flow_tunnel_steer_rule(dev, attr, items, actions) ?
-                flow_actions_to_tunnel(actions) :
-                dev_flow->tunnel ? dev_flow->tunnel : NULL;
+       if (is_tunnel_offload_active(dev)) {
+               if (dev_flow->tunnel) {
+                       RTE_VERIFY(dev_flow->tof_type ==
+                                  MLX5_TUNNEL_OFFLOAD_MISS_RULE);
+                       tunnel = dev_flow->tunnel;
+               } else {
+                       tunnel = mlx5_get_tof(items, actions,
+                                             &dev_flow->tof_type);
+                       dev_flow->tunnel = tunnel;
+               }
+               grp_info.std_tbl_fix = tunnel_use_standard_attr_group_translate
+                                       (dev, attr, tunnel, dev_flow->tof_type);
+       }
        mhdr_res->ft_type = attr->egress ? MLX5DV_FLOW_TABLE_TYPE_NIC_TX :
                                           MLX5DV_FLOW_TABLE_TYPE_NIC_RX;
-       grp_info.std_tbl_fix = tunnel_use_standard_attr_group_translate
-                               (dev, tunnel, attr, items, actions);
        ret = mlx5_flow_group_to_table(dev, tunnel, attr->group, &table,
                                       &grp_info, error);
        if (ret)
@@ -12075,7 +12070,7 @@ flow_dv_translate(struct rte_eth_dev *dev,
                mhdr_res->ft_type = MLX5DV_FLOW_TABLE_TYPE_FDB;
        /* number of actions must be set to 0 in case of dirty stack. */
        mhdr_res->actions_num = 0;
-       if (is_flow_tunnel_match_rule(dev, attr, items, actions)) {
+       if (is_flow_tunnel_match_rule(dev_flow->tof_type)) {
                /*
                 * do not add decap action if match rule drops packet
                 * HW rejects rules with decap & drop
@@ -12615,7 +12610,7 @@ flow_dv_translate(struct rte_eth_dev *dev,
                                if ((non_shared_age &&
                                     count && !count->shared) ||
                                    !(priv->sh->flow_hit_aso_en &&
-                                     attr->group)) {
+                                     (attr->group || attr->transfer))) {
                                        /* Creates age by counters. */
                                        cnt_act = flow_dv_prepare_counter
                                                                (dev, dev_flow,
@@ -12629,17 +12624,17 @@ flow_dv_translate(struct rte_eth_dev *dev,
                                        break;
                                }
                                if (!flow->age && non_shared_age) {
-                                       flow->age =
-                                               flow_dv_translate_create_aso_age
-                                                               (dev,
-                                                                non_shared_age,
-                                                                error);
+                                       flow->age = flow_dv_aso_age_alloc
+                                                               (dev, error);
                                        if (!flow->age)
-                                               return rte_flow_error_set
-                                                   (error, rte_errno,
-                                                    RTE_FLOW_ERROR_TYPE_ACTION,
-                                                    NULL,
-                                                    "can't create ASO age action");
+                                               return -rte_errno;
+                                       flow_dv_aso_age_params_init
+                                                   (dev, flow->age,
+                                                    non_shared_age->context ?
+                                                    non_shared_age->context :
+                                                    (void *)(uintptr_t)
+                                                    (dev_flow->flow_idx),
+                                                    non_shared_age->timeout);
                                }
                                age_act = flow_aso_age_get_by_idx(dev,
                                                                  flow->age);
@@ -14201,9 +14196,10 @@ flow_dv_action_create(struct rte_eth_dev *dev,
                      const struct rte_flow_action *action,
                      struct rte_flow_error *err)
 {
+       struct mlx5_priv *priv = dev->data->dev_private;
+       uint32_t age_idx = 0;
        uint32_t idx = 0;
        uint32_t ret = 0;
-       struct mlx5_priv *priv = dev->data->dev_private;
 
        switch (action->type) {
        case RTE_FLOW_ACTION_TYPE_RSS:
@@ -14212,17 +14208,22 @@ flow_dv_action_create(struct rte_eth_dev *dev,
                       MLX5_INDIRECT_ACTION_TYPE_OFFSET) | ret;
                break;
        case RTE_FLOW_ACTION_TYPE_AGE:
-               ret = flow_dv_translate_create_aso_age(dev, action->conf, err);
-               idx = (MLX5_INDIRECT_ACTION_TYPE_AGE <<
-                      MLX5_INDIRECT_ACTION_TYPE_OFFSET) | ret;
-               if (ret) {
-                       struct mlx5_aso_age_action *aso_age =
-                                             flow_aso_age_get_by_idx(dev, ret);
-
-                       if (!aso_age->age_params.context)
-                               aso_age->age_params.context =
-                                                        (void *)(uintptr_t)idx;
+               age_idx = flow_dv_aso_age_alloc(dev, err);
+               if (!age_idx) {
+                       ret = -rte_errno;
+                       break;
                }
+               idx = (MLX5_INDIRECT_ACTION_TYPE_AGE <<
+                      MLX5_INDIRECT_ACTION_TYPE_OFFSET) | age_idx;
+               flow_dv_aso_age_params_init(dev, age_idx,
+                                       ((const struct rte_flow_action_age *)
+                                               action->conf)->context ?
+                                       ((const struct rte_flow_action_age *)
+                                               action->conf)->context :
+                                       (void *)(uintptr_t)idx,
+                                       ((const struct rte_flow_action_age *)
+                                               action->conf)->timeout);
+               ret = age_idx;
                break;
        case RTE_FLOW_ACTION_TYPE_COUNT:
                ret = flow_dv_translate_create_counter(dev, NULL, NULL, NULL);