net/mlx5: add flex parser DevX object management
[dpdk.git] / drivers / net / mlx5 / mlx5_flow_meter.c
index 0f51710..f4a7b69 100644 (file)
@@ -245,17 +245,23 @@ mlx5_flow_meter_profile_validate(struct rte_eth_dev *dev,
 static inline void
 mlx5_flow_meter_xir_man_exp_calc(int64_t xir, uint8_t *man, uint8_t *exp)
 {
-       int64_t _cir;
+       int64_t _xir;
        int64_t delta = INT64_MAX;
        uint8_t _man = 0;
        uint8_t _exp = 0;
        uint64_t m, e;
 
+       /* Special case xir == 0 ? both exp and matissa are 0. */
+       if (xir == 0) {
+               *man = 0;
+               *exp = 0;
+               return;
+       }
        for (m = 0; m <= 0xFF; m++) { /* man width 8 bit */
                for (e = 0; e <= 0x1F; e++) { /* exp width 5bit */
-                       _cir = (1000000000ULL * m) >> e;
-                       if (llabs(xir - _cir) <= delta) {
-                               delta = llabs(xir - _cir);
+                       _xir = (1000000000ULL * m) >> e;
+                       if (llabs(xir - _xir) <= delta) {
+                               delta = llabs(xir - _xir);
                                _man = m;
                                _exp = e;
                        }
@@ -1783,24 +1789,21 @@ mlx5_flow_meter_find(struct mlx5_priv *priv, uint32_t meter_id,
        struct mlx5_aso_mtr_pools_mng *pools_mng =
                                &priv->sh->mtrmng->pools_mng;
        union mlx5_l3t_data data;
+       uint16_t n_valid;
 
        if (priv->sh->meter_aso_en) {
-               rte_spinlock_lock(&pools_mng->mtrsl);
-               if (!pools_mng->n_valid || !priv->mtr_idx_tbl) {
-                       rte_spinlock_unlock(&pools_mng->mtrsl);
+               rte_rwlock_read_lock(&pools_mng->resize_mtrwl);
+               n_valid = pools_mng->n_valid;
+               rte_rwlock_read_unlock(&pools_mng->resize_mtrwl);
+               if (!n_valid || !priv->mtr_idx_tbl ||
+                   (mlx5_l3t_get_entry(priv->mtr_idx_tbl, meter_id, &data) ||
+                   !data.dword))
                        return NULL;
-               }
-               if (mlx5_l3t_get_entry(priv->mtr_idx_tbl, meter_id, &data) ||
-                       !data.dword) {
-                       rte_spinlock_unlock(&pools_mng->mtrsl);
-                       return NULL;
-               }
                if (mtr_idx)
                        *mtr_idx = data.dword;
                aso_mtr = mlx5_aso_meter_by_idx(priv, data.dword);
                /* Remove reference taken by the mlx5_l3t_get_entry. */
                mlx5_l3t_clear_entry(priv->mtr_idx_tbl, meter_id);
-               rte_spinlock_unlock(&pools_mng->mtrsl);
                if (!aso_mtr || aso_mtr->state == ASO_METER_FREE)
                        return NULL;
                return &aso_mtr->fm;
@@ -2162,7 +2165,7 @@ mlx5_flow_meter_flush(struct rte_eth_dev *dev, struct rte_mtr_error *error)
                        priv->mtr_idx_tbl = NULL;
                }
        } else {
-               TAILQ_FOREACH_SAFE(legacy_fm, fms, next, tmp) {
+               RTE_TAILQ_FOREACH_SAFE(legacy_fm, fms, next, tmp) {
                        fm = &legacy_fm->fm;
                        if (mlx5_flow_meter_params_flush(dev, fm, 0))
                                return -rte_mtr_error_set(error, EINVAL,