net/mlx5: rebuild flows on updating RETA
[dpdk.git] / drivers / net / mlx5 / mlx5_rss.c
index bf19aca..a2dd7d1 100644 (file)
 /* Verbs header. */
 /* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */
 #ifdef PEDANTIC
-#pragma GCC diagnostic ignored "-pedantic"
+#pragma GCC diagnostic ignored "-Wpedantic"
 #endif
 #include <infiniband/verbs.h>
 #ifdef PEDANTIC
-#pragma GCC diagnostic error "-pedantic"
+#pragma GCC diagnostic error "-Wpedantic"
 #endif
 
 /* DPDK headers don't like -pedantic. */
 #ifdef PEDANTIC
-#pragma GCC diagnostic ignored "-pedantic"
+#pragma GCC diagnostic ignored "-Wpedantic"
 #endif
 #include <rte_malloc.h>
 #include <rte_ethdev.h>
 #ifdef PEDANTIC
-#pragma GCC diagnostic error "-pedantic"
+#pragma GCC diagnostic error "-Wpedantic"
 #endif
 
 #include "mlx5.h"
@@ -156,17 +156,8 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev,
                                                rss_conf->rss_key,
                                                rss_conf->rss_key_len,
                                                rss_conf->rss_hf);
-       else
-               err = rss_hash_rss_conf_new_key(priv,
-                                               rss_hash_default_key,
-                                               rss_hash_default_key_len,
-                                               ETH_RSS_PROTO_MASK);
-
-       /* Store the configuration set into port configure.
-        * This will enable/disable hash RX queues associated to the protocols
-        * enabled/disabled by this update. */
-       priv->dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf =
-               rss_conf->rss_hf;
+       /* Store protocols for which RSS is enabled. */
+       priv->rss_hf = rss_conf->rss_hf;
        priv_unlock(priv);
        assert(err >= 0);
        return -err;
@@ -211,3 +202,166 @@ mlx5_rss_hash_conf_get(struct rte_eth_dev *dev,
        priv_unlock(priv);
        return 0;
 }
+
+/**
+ * Allocate/reallocate RETA index table.
+ *
+ * @param priv
+ *   Pointer to private structure.
+ * @praram reta_size
+ *   The size of the array to allocate.
+ *
+ * @return
+ *   0 on success, errno value on failure.
+ */
+int
+priv_rss_reta_index_resize(struct priv *priv, unsigned int reta_size)
+{
+       void *mem;
+       unsigned int old_size = priv->reta_idx_n;
+
+       if (priv->reta_idx_n == reta_size)
+               return 0;
+
+       mem = rte_realloc(priv->reta_idx,
+                         reta_size * sizeof((*priv->reta_idx)[0]), 0);
+       if (!mem)
+               return ENOMEM;
+       priv->reta_idx = mem;
+       priv->reta_idx_n = reta_size;
+
+       if (old_size < reta_size)
+               memset(&(*priv->reta_idx)[old_size], 0,
+                      (reta_size - old_size) *
+                      sizeof((*priv->reta_idx)[0]));
+       return 0;
+}
+
+/**
+ * Query RETA table.
+ *
+ * @param priv
+ *   Pointer to private structure.
+ * @param[in, out] reta_conf
+ *   Pointer to the first RETA configuration structure.
+ * @param reta_size
+ *   Number of entries.
+ *
+ * @return
+ *   0 on success, errno value on failure.
+ */
+static int
+priv_dev_rss_reta_query(struct priv *priv,
+                       struct rte_eth_rss_reta_entry64 *reta_conf,
+                       unsigned int reta_size)
+{
+       unsigned int idx;
+       unsigned int i;
+
+       if (!reta_size || reta_size > priv->reta_idx_n)
+               return EINVAL;
+       /* Fill each entry of the table even if its bit is not set. */
+       for (idx = 0, i = 0; (i != reta_size); ++i) {
+               idx = i / RTE_RETA_GROUP_SIZE;
+               reta_conf[idx].reta[i % RTE_RETA_GROUP_SIZE] =
+                       (*priv->reta_idx)[i];
+       }
+       return 0;
+}
+
+/**
+ * Update RETA table.
+ *
+ * @param priv
+ *   Pointer to private structure.
+ * @param[in] reta_conf
+ *   Pointer to the first RETA configuration structure.
+ * @param reta_size
+ *   Number of entries.
+ *
+ * @return
+ *   0 on success, errno value on failure.
+ */
+static int
+priv_dev_rss_reta_update(struct priv *priv,
+                        struct rte_eth_rss_reta_entry64 *reta_conf,
+                        unsigned int reta_size)
+{
+       unsigned int idx;
+       unsigned int i;
+       unsigned int pos;
+       int ret;
+
+       if (!reta_size)
+               return EINVAL;
+       ret = priv_rss_reta_index_resize(priv, reta_size);
+       if (ret)
+               return ret;
+
+       for (idx = 0, i = 0; (i != reta_size); ++i) {
+               idx = i / RTE_RETA_GROUP_SIZE;
+               pos = i % RTE_RETA_GROUP_SIZE;
+               if (((reta_conf[idx].mask >> i) & 0x1) == 0)
+                       continue;
+               assert(reta_conf[idx].reta[pos] < priv->rxqs_n);
+               (*priv->reta_idx)[i] = reta_conf[idx].reta[pos];
+       }
+       return 0;
+}
+
+/**
+ * DPDK callback to get the RETA indirection table.
+ *
+ * @param dev
+ *   Pointer to Ethernet device structure.
+ * @param reta_conf
+ *   Pointer to RETA configuration structure array.
+ * @param reta_size
+ *   Size of the RETA table.
+ *
+ * @return
+ *   0 on success, negative errno value on failure.
+ */
+int
+mlx5_dev_rss_reta_query(struct rte_eth_dev *dev,
+                       struct rte_eth_rss_reta_entry64 *reta_conf,
+                       uint16_t reta_size)
+{
+       int ret;
+       struct priv *priv = dev->data->dev_private;
+
+       priv_lock(priv);
+       ret = priv_dev_rss_reta_query(priv, reta_conf, reta_size);
+       priv_unlock(priv);
+       return -ret;
+}
+
+/**
+ * DPDK callback to update the RETA indirection table.
+ *
+ * @param dev
+ *   Pointer to Ethernet device structure.
+ * @param reta_conf
+ *   Pointer to RETA configuration structure array.
+ * @param reta_size
+ *   Size of the RETA table.
+ *
+ * @return
+ *   0 on success, negative errno value on failure.
+ */
+int
+mlx5_dev_rss_reta_update(struct rte_eth_dev *dev,
+                        struct rte_eth_rss_reta_entry64 *reta_conf,
+                        uint16_t reta_size)
+{
+       int ret;
+       struct priv *priv = dev->data->dev_private;
+
+       mlx5_dev_stop(dev);
+       priv_lock(priv);
+       ret = priv_dev_rss_reta_update(priv, reta_conf, reta_size);
+       priv_unlock(priv);
+       if (ret)
+               return -ret;
+       return mlx5_dev_start(dev);
+}