net/mlx5: fix overflow of Memory Region cache
[dpdk.git] / drivers / net / mlx5 / mlx5_trigger.c
index 4143571..88f60a0 100644 (file)
@@ -64,8 +64,11 @@ priv_txq_start(struct priv *priv)
 
                if (!txq_ctrl)
                        continue;
-               LIST_FOREACH(mr, &priv->mr, next)
+               LIST_FOREACH(mr, &priv->mr, next) {
                        priv_txq_mp2mr_reg(priv, &txq_ctrl->txq, mr->mp, idx++);
+                       if (idx == MLX5_PMD_TX_MP_CACHE)
+                               break;
+               }
                txq_alloc_elts(txq_ctrl);
                txq_ctrl->ibv = mlx5_priv_txq_ibv_new(priv, i);
                if (!txq_ctrl->ibv) {
@@ -132,9 +135,6 @@ mlx5_dev_start(struct rte_eth_dev *dev)
        struct mlx5_mr *mr = NULL;
        int err;
 
-       if (mlx5_is_secondary())
-               return -E_RTE_SECONDARY;
-
        dev->data->dev_started = 1;
        priv_lock(priv);
        err = priv_flow_create_drop_queue(priv);
@@ -161,9 +161,9 @@ mlx5_dev_start(struct rte_eth_dev *dev)
        }
        /* Update receive callback. */
        priv_dev_select_rx_function(priv, dev);
-       err = priv_create_hash_rxqs(priv);
+       err = priv_dev_traffic_enable(priv, dev);
        if (err) {
-               ERROR("%p: an error occurred while configuring hash RX queues:"
+               ERROR("%p: an error occurred while configuring control flows:"
                      " %s",
                      (void *)priv, strerror(err));
                goto error;
@@ -188,10 +188,10 @@ mlx5_dev_start(struct rte_eth_dev *dev)
 error:
        /* Rollback. */
        dev->data->dev_started = 0;
-       LIST_FOREACH(mr, &priv->mr, next)
+       for (mr = LIST_FIRST(&priv->mr); mr; mr = LIST_FIRST(&priv->mr))
                priv_mr_release(priv, mr);
-       priv_destroy_hash_rxqs(priv);
        priv_flow_stop(priv, &priv->flows);
+       priv_dev_traffic_disable(priv, dev);
        priv_txq_stop(priv);
        priv_rxq_stop(priv);
        priv_flow_delete_drop_queue(priv);
@@ -213,9 +213,6 @@ mlx5_dev_stop(struct rte_eth_dev *dev)
        struct priv *priv = dev->data->dev_private;
        struct mlx5_mr *mr;
 
-       if (mlx5_is_secondary())
-               return;
-
        priv_lock(priv);
        dev->data->dev_started = 0;
        /* Prevent crashes when queues are still in use. */
@@ -224,16 +221,14 @@ mlx5_dev_stop(struct rte_eth_dev *dev)
        rte_wmb();
        usleep(1000 * priv->rxqs_n);
        DEBUG("%p: cleaning up and destroying hash RX queues", (void *)dev);
-       priv_destroy_hash_rxqs(priv);
        priv_flow_stop(priv, &priv->flows);
-       priv_flow_flush(priv, &priv->ctrl_flows);
+       priv_dev_traffic_disable(priv, dev);
        priv_rx_intr_vec_disable(priv);
        priv_dev_interrupt_handler_uninstall(priv, dev);
        priv_txq_stop(priv);
        priv_rxq_stop(priv);
-       LIST_FOREACH(mr, &priv->mr, next) {
+       for (mr = LIST_FIRST(&priv->mr); mr; mr = LIST_FIRST(&priv->mr))
                priv_mr_release(priv, mr);
-       }
        priv_flow_delete_drop_queue(priv);
        priv_unlock(priv);
 }
@@ -252,6 +247,29 @@ mlx5_dev_stop(struct rte_eth_dev *dev)
 int
 priv_dev_traffic_enable(struct priv *priv, struct rte_eth_dev *dev)
 {
+       struct rte_flow_item_eth bcast = {
+               .dst.addr_bytes = "\xff\xff\xff\xff\xff\xff",
+       };
+       struct rte_flow_item_eth ipv6_multi_spec = {
+               .dst.addr_bytes = "\x33\x33\x00\x00\x00\x00",
+       };
+       struct rte_flow_item_eth ipv6_multi_mask = {
+               .dst.addr_bytes = "\xff\xff\x00\x00\x00\x00",
+       };
+       struct rte_flow_item_eth unicast = {
+               .src.addr_bytes = "\x00\x00\x00\x00\x00\x00",
+       };
+       struct rte_flow_item_eth unicast_mask = {
+               .dst.addr_bytes = "\xff\xff\xff\xff\xff\xff",
+       };
+       const unsigned int vlan_filter_n = priv->vlan_filter_n;
+       const struct ether_addr cmp = {
+               .addr_bytes = "\x00\x00\x00\x00\x00\x00",
+       };
+       unsigned int i;
+       unsigned int j;
+       int ret;
+
        if (priv->isolated)
                return 0;
        if (dev->data->promiscuous) {
@@ -262,81 +280,80 @@ priv_dev_traffic_enable(struct priv *priv, struct rte_eth_dev *dev)
                };
 
                claim_zero(mlx5_ctrl_flow(dev, &promisc, &promisc));
-       } else if (dev->data->all_multicast) {
+               return 0;
+       }
+       if (dev->data->all_multicast) {
                struct rte_flow_item_eth multicast = {
                        .dst.addr_bytes = "\x01\x00\x00\x00\x00\x00",
-                       .src.addr_bytes = "\x01\x00\x00\x00\x00\x00",
+                       .src.addr_bytes = "\x00\x00\x00\x00\x00\x00",
                        .type = 0,
                };
 
                claim_zero(mlx5_ctrl_flow(dev, &multicast, &multicast));
        } else {
-               struct rte_flow_item_eth bcast = {
-                       .dst.addr_bytes = "\xff\xff\xff\xff\xff\xff",
-               };
-               struct rte_flow_item_eth ipv6_multi_spec = {
-                       .dst.addr_bytes = "\x33\x33\x00\x00\x00\x00",
-               };
-               struct rte_flow_item_eth ipv6_multi_mask = {
-                       .dst.addr_bytes = "\xff\xff\x00\x00\x00\x00",
-               };
-               struct rte_flow_item_eth unicast = {
-                       .src.addr_bytes = "\x00\x00\x00\x00\x00\x00",
-               };
-               struct rte_flow_item_eth unicast_mask = {
-                       .dst.addr_bytes = "\xff\xff\xff\xff\xff\xff",
-               };
-               const unsigned int vlan_filter_n = priv->vlan_filter_n;
-               const struct ether_addr cmp = {
-                       .addr_bytes = "\x00\x00\x00\x00\x00\x00",
-               };
-               unsigned int i;
-               unsigned int j;
-               unsigned int unicast_flow = 0;
-               int ret;
+               /* Add broadcast/multicast flows. */
+               for (i = 0; i != vlan_filter_n; ++i) {
+                       uint16_t vlan = priv->vlan_filter[i];
 
-               for (i = 0; i != MLX5_MAX_MAC_ADDRESSES; ++i) {
-                       struct ether_addr *mac = &dev->data->mac_addrs[i];
+                       struct rte_flow_item_vlan vlan_spec = {
+                               .tci = rte_cpu_to_be_16(vlan),
+                       };
+                       struct rte_flow_item_vlan vlan_mask = {
+                               .tci = 0xffff,
+                       };
 
-                       if (!memcmp(mac, &cmp, sizeof(*mac)))
-                               continue;
-                       memcpy(&unicast.dst.addr_bytes,
-                              mac->addr_bytes,
-                              ETHER_ADDR_LEN);
-                       for (j = 0; j != vlan_filter_n; ++j) {
-                               uint16_t vlan = priv->vlan_filter[j];
+                       ret = mlx5_ctrl_flow_vlan(dev, &bcast, &bcast,
+                                                 &vlan_spec, &vlan_mask);
+                       if (ret)
+                               goto error;
+                       ret = mlx5_ctrl_flow_vlan(dev, &ipv6_multi_spec,
+                                                 &ipv6_multi_mask,
+                                                 &vlan_spec, &vlan_mask);
+                       if (ret)
+                               goto error;
+               }
+               if (!vlan_filter_n) {
+                       ret = mlx5_ctrl_flow(dev, &bcast, &bcast);
+                       if (ret)
+                               goto error;
+                       ret = mlx5_ctrl_flow(dev, &ipv6_multi_spec,
+                                            &ipv6_multi_mask);
+                       if (ret)
+                               goto error;
+               }
+       }
+       /* Add MAC address flows. */
+       for (i = 0; i != MLX5_MAX_MAC_ADDRESSES; ++i) {
+               struct ether_addr *mac = &dev->data->mac_addrs[i];
 
-                               struct rte_flow_item_vlan vlan_spec = {
-                                       .tci = rte_cpu_to_be_16(vlan),
-                               };
-                               struct rte_flow_item_vlan vlan_mask = {
-                                       .tci = 0xffff,
-                               };
+               if (!memcmp(mac, &cmp, sizeof(*mac)))
+                       continue;
+               memcpy(&unicast.dst.addr_bytes,
+                      mac->addr_bytes,
+                      ETHER_ADDR_LEN);
+               for (j = 0; j != vlan_filter_n; ++j) {
+                       uint16_t vlan = priv->vlan_filter[j];
 
-                               ret = mlx5_ctrl_flow_vlan(dev, &unicast,
-                                                         &unicast_mask,
-                                                         &vlan_spec,
-                                                         &vlan_mask);
-                               if (ret)
-                                       goto error;
-                               unicast_flow = 1;
-                       }
-                       if (!vlan_filter_n) {
-                               ret = mlx5_ctrl_flow(dev, &unicast,
-                                                    &unicast_mask);
-                               if (ret)
-                                       goto error;
-                               unicast_flow = 1;
-                       }
+                       struct rte_flow_item_vlan vlan_spec = {
+                               .tci = rte_cpu_to_be_16(vlan),
+                       };
+                       struct rte_flow_item_vlan vlan_mask = {
+                               .tci = 0xffff,
+                       };
+
+                       ret = mlx5_ctrl_flow_vlan(dev, &unicast,
+                                                 &unicast_mask,
+                                                 &vlan_spec,
+                                                 &vlan_mask);
+                       if (ret)
+                               goto error;
+               }
+               if (!vlan_filter_n) {
+                       ret = mlx5_ctrl_flow(dev, &unicast,
+                                            &unicast_mask);
+                       if (ret)
+                               goto error;
                }
-               if (!unicast_flow)
-                       return 0;
-               ret = mlx5_ctrl_flow(dev, &bcast, &bcast);
-               if (ret)
-                       goto error;
-               ret = mlx5_ctrl_flow(dev, &ipv6_multi_spec, &ipv6_multi_mask);
-               if (ret)
-                       goto error;
        }
        return 0;
 error: