net/mlx5: remove pedantic pragma

[dpdk.git] / drivers / net / mlx5 / mlx5_vlan.c

diff --git a/drivers/net/mlx5/mlx5_vlan.c b/drivers/net/mlx5/mlx5_vlan.c
index ca80571..353ae49 100644 (file)
--- a/drivers/net/mlx5/mlx5_vlan.c
+++ b/drivers/net/mlx5/mlx5_vlan.c
@@ -36,18 +36,12 @@
 #include <assert.h>
 #include <stdint.h>
 
-/* DPDK headers don't like -pedantic. */
-#ifdef PEDANTIC
-#pragma GCC diagnostic ignored "-pedantic"
-#endif
 #include <rte_ethdev.h>
 #include <rte_common.h>
-#ifdef PEDANTIC
-#pragma GCC diagnostic error "-pedantic"
-#endif
 
 #include "mlx5_utils.h"
 #include "mlx5.h"
+#include "mlx5_autoconf.h"
 
 /**
  * Configure a VLAN filter.
@@ -67,8 +61,6 @@ vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
 {
        struct priv *priv = dev->data->dev_private;
        unsigned int i;
-       unsigned int r;
-       struct rxq *rxq;
 
        DEBUG("%p: %s VLAN filter ID %" PRIu16,
              (void *)dev, (on ? "enable" : "disable"), vlan_id);
@@ -88,7 +80,8 @@ vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
                --priv->vlan_filter_n;
                memmove(&priv->vlan_filter[i],
                        &priv->vlan_filter[i + 1],
-                       priv->vlan_filter_n - i);
+                       sizeof(priv->vlan_filter[i]) *
+                       (priv->vlan_filter_n - i));
                priv->vlan_filter[priv->vlan_filter_n] = 0;
        } else {
                assert(i == priv->vlan_filter_n);
@@ -99,34 +92,10 @@ vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
                priv->vlan_filter[priv->vlan_filter_n] = vlan_id;
                ++priv->vlan_filter_n;
        }
-       if (!priv->started)
-               return 0;
-       /* Rehash MAC flows in all RX queues. */
-       if (priv->rss) {
-               rxq = &priv->rxq_parent;
-               r = 1;
-       } else {
-               rxq = (*priv->rxqs)[0];
-               r = priv->rxqs_n;
-       }
-       for (i = 0; (i < r); rxq = (*priv->rxqs)[++i]) {
-               int ret;
-
-               if (rxq == NULL)
-                       continue;
-               rxq_mac_addrs_del(rxq);
-               ret = rxq_mac_addrs_add(rxq);
-               if (!ret)
-                       continue;
-               /* Rollback. */
-               while (i != 0) {
-                       rxq = (*priv->rxqs)[--i];
-                       if (rxq != NULL)
-                               rxq_mac_addrs_del(rxq);
-               }
-               return ret;
-       }
-       return 0;
+       /* Rehash flows in all hash RX queues. */
+       priv_mac_addrs_disable(priv);
+       priv_special_flow_disable_all(priv);
+       return priv_rehash_flows(priv);
 }
 
 /**
@@ -154,3 +123,104 @@ mlx5_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
        assert(ret >= 0);
        return -ret;
 }
+
+/**
+ * Set/reset VLAN stripping for a specific queue.
+ *
+ * @param priv
+ *   Pointer to private structure.
+ * @param idx
+ *   RX queue index.
+ * @param on
+ *   Enable/disable VLAN stripping.
+ */
+static void
+priv_vlan_strip_queue_set(struct priv *priv, uint16_t idx, int on)
+{
+       struct rxq *rxq = (*priv->rxqs)[idx];
+       struct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq);
+       struct ibv_exp_wq_attr mod;
+       uint16_t vlan_offloads =
+               (on ? IBV_EXP_RECEIVE_WQ_CVLAN_STRIP : 0) |
+               0;
+       int err;
+
+       DEBUG("set VLAN offloads 0x%x for port %d queue %d",
+             vlan_offloads, rxq->port_id, idx);
+       mod = (struct ibv_exp_wq_attr){
+               .attr_mask = IBV_EXP_WQ_ATTR_VLAN_OFFLOADS,
+               .vlan_offloads = vlan_offloads,
+       };
+
+       err = ibv_exp_modify_wq(rxq_ctrl->wq, &mod);
+       if (err) {
+               ERROR("%p: failed to modified stripping mode: %s",
+                     (void *)priv, strerror(err));
+               return;
+       }
+
+       /* Update related bits in RX queue. */
+       rxq->vlan_strip = !!on;
+}
+
+/**
+ * Callback to set/reset VLAN stripping for a specific queue.
+ *
+ * @param dev
+ *   Pointer to Ethernet device structure.
+ * @param queue
+ *   RX queue index.
+ * @param on
+ *   Enable/disable VLAN stripping.
+ */
+void
+mlx5_vlan_strip_queue_set(struct rte_eth_dev *dev, uint16_t queue, int on)
+{
+       struct priv *priv = dev->data->dev_private;
+
+       /* Validate hw support */
+       if (!priv->hw_vlan_strip) {
+               ERROR("VLAN stripping is not supported");
+               return;
+       }
+
+       /* Validate queue number */
+       if (queue >= priv->rxqs_n) {
+               ERROR("VLAN stripping, invalid queue number %d", queue);
+               return;
+       }
+
+       priv_lock(priv);
+       priv_vlan_strip_queue_set(priv, queue, on);
+       priv_unlock(priv);
+}
+
+/**
+ * Callback to set/reset VLAN offloads for a port.
+ *
+ * @param dev
+ *   Pointer to Ethernet device structure.
+ * @param mask
+ *   VLAN offload bit mask.
+ */
+void
+mlx5_vlan_offload_set(struct rte_eth_dev *dev, int mask)
+{
+       struct priv *priv = dev->data->dev_private;
+       unsigned int i;
+
+       if (mask & ETH_VLAN_STRIP_MASK) {
+               int hw_vlan_strip = !!dev->data->dev_conf.rxmode.hw_vlan_strip;
+
+               if (!priv->hw_vlan_strip) {
+                       ERROR("VLAN stripping is not supported");
+                       return;
+               }
+
+               /* Run on every RX queue and set/reset VLAN stripping. */
+               priv_lock(priv);
+               for (i = 0; (i != priv->rxqs_n); i++)
+                       priv_vlan_strip_queue_set(priv, i, hw_vlan_strip);
+               priv_unlock(priv);
+       }
+}