net/mvpp2: fix configured state dependency
[dpdk.git] / drivers / net / mvpp2 / mrvl_ethdev.c
index 48f161b..1802695 100644 (file)
@@ -52,8 +52,6 @@
 #define MRVL_IFACE_NAME_ARG "iface"
 #define MRVL_CFG_ARG "cfg"
 
-#define MRVL_BURST_SIZE 64
-
 #define MRVL_ARP_LENGTH 28
 
 #define MRVL_COOKIE_ADDR_INVALID ~0ULL
@@ -90,6 +88,8 @@ static int used_bpools[PP2_NUM_PKT_PROC] = {
 static struct pp2_bpool *mrvl_port_to_bpool_lookup[RTE_MAX_ETHPORTS];
 static int mrvl_port_bpool_size[PP2_NUM_PKT_PROC][PP2_BPOOL_NUM_POOLS][RTE_MAX_LCORE];
 static uint64_t cookie_addr_high = MRVL_COOKIE_ADDR_INVALID;
+static int dummy_pool_id[PP2_NUM_PKT_PROC];
+struct pp2_bpool *dummy_pool[PP2_NUM_PKT_PROC] = {0};
 
 struct mrvl_ifnames {
        const char *names[PP2_NUM_ETH_PPIO * PP2_NUM_PKT_PROC];
@@ -162,6 +162,8 @@ static int
 mrvl_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on);
 static int mrvl_promiscuous_enable(struct rte_eth_dev *dev);
 static int mrvl_allmulticast_enable(struct rte_eth_dev *dev);
+static int
+mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf);
 
 #define MRVL_XSTATS_TBL_ENTRY(name) { \
        #name, offsetof(struct pp2_ppio_statistics, name),      \
@@ -189,6 +191,52 @@ static struct {
        MRVL_XSTATS_TBL_ENTRY(tx_errors)
 };
 
+static inline int
+mrvl_reserve_bit(int *bitmap, int max)
+{
+       int n = sizeof(*bitmap) * 8 - __builtin_clz(*bitmap);
+
+       if (n >= max)
+               return -1;
+
+       *bitmap |= 1 << n;
+
+       return n;
+}
+
+static int
+mrvl_pp2_fixup_init(void)
+{
+       struct pp2_bpool_params bpool_params;
+       char                    name[15];
+       int                     err, i;
+
+       memset(dummy_pool, 0, sizeof(dummy_pool));
+       for (i = 0; i < pp2_get_num_inst(); i++) {
+               dummy_pool_id[i] = mrvl_reserve_bit(&used_bpools[i],
+                                            PP2_BPOOL_NUM_POOLS);
+               if (dummy_pool_id[i] < 0) {
+                       MRVL_LOG(ERR, "Can't find free pool\n");
+                       return -1;
+               }
+
+               memset(name, 0, sizeof(name));
+               snprintf(name, sizeof(name), "pool-%d:%d", i, dummy_pool_id[i]);
+               memset(&bpool_params, 0, sizeof(bpool_params));
+               bpool_params.match = name;
+               bpool_params.buff_len = MRVL_PKT_OFFS;
+               bpool_params.dummy_short_pool = 1;
+               err = pp2_bpool_init(&bpool_params, &dummy_pool[i]);
+               if (err != 0 || !dummy_pool[i]) {
+                       MRVL_LOG(ERR, "BPool init failed!\n");
+                       used_bpools[i] &= ~(1 << dummy_pool_id[i]);
+                       return -1;
+               }
+       }
+
+       return 0;
+}
+
 /**
  * Initialize packet processor.
  *
@@ -198,7 +246,8 @@ static struct {
 static int
 mrvl_init_pp2(void)
 {
-       struct pp2_init_params init_params;
+       struct pp2_init_params  init_params;
+       int                     err;
 
        memset(&init_params, 0, sizeof(init_params));
        init_params.hif_reserved_map = MRVL_MUSDK_HIFS_RESERVED;
@@ -207,7 +256,32 @@ mrvl_init_pp2(void)
        if (mrvl_cfg && mrvl_cfg->pp2_cfg.prs_udfs.num_udfs)
                memcpy(&init_params.prs_udfs, &mrvl_cfg->pp2_cfg.prs_udfs,
                       sizeof(struct pp2_parse_udfs));
-       return pp2_init(&init_params);
+       err = pp2_init(&init_params);
+       if (err != 0) {
+               MRVL_LOG(ERR, "PP2 init failed");
+               return -1;
+       }
+
+       err = mrvl_pp2_fixup_init();
+       if (err != 0) {
+               MRVL_LOG(ERR, "PP2 fixup init failed");
+               return -1;
+       }
+
+       return 0;
+}
+
+static void
+mrvl_pp2_fixup_deinit(void)
+{
+       int i;
+
+       for (i = 0; i < PP2_NUM_PKT_PROC; i++) {
+               if (!dummy_pool[i])
+                       continue;
+               pp2_bpool_deinit(dummy_pool[i]);
+               used_bpools[i] &= ~(1 << dummy_pool_id[i]);
+       }
 }
 
 /**
@@ -219,6 +293,7 @@ mrvl_init_pp2(void)
 static void
 mrvl_deinit_pp2(void)
 {
+       mrvl_pp2_fixup_deinit();
        pp2_deinit();
 }
 
@@ -275,19 +350,6 @@ mrvl_get_bpool_size(int pp2_id, int pool_id)
        return size;
 }
 
-static inline int
-mrvl_reserve_bit(int *bitmap, int max)
-{
-       int n = sizeof(*bitmap) * 8 - __builtin_clz(*bitmap);
-
-       if (n >= max)
-               return -1;
-
-       *bitmap |= 1 << n;
-
-       return n;
-}
-
 static int
 mrvl_init_hif(int core_id)
 {
@@ -434,9 +496,17 @@ mrvl_dev_configure(struct rte_eth_dev *dev)
                return -EINVAL;
        }
 
-       if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME)
+       if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {
                dev->data->mtu = dev->data->dev_conf.rxmode.max_rx_pkt_len -
                                 MRVL_PP2_ETH_HDRS_LEN;
+               if (dev->data->mtu > priv->max_mtu) {
+                       MRVL_LOG(ERR, "inherit MTU %u from max_rx_pkt_len %u is larger than max_mtu %u\n",
+                                dev->data->mtu,
+                                dev->data->dev_conf.rxmode.max_rx_pkt_len,
+                                priv->max_mtu);
+                       return -EINVAL;
+               }
+       }
 
        if (dev->data->dev_conf.txmode.offloads & DEV_TX_OFFLOAD_MULTI_SEGS)
                priv->multiseg = 1;
@@ -463,12 +533,18 @@ mrvl_dev_configure(struct rte_eth_dev *dev)
            dev->data->dev_conf.rxmode.mq_mode == ETH_MQ_RX_RSS) {
                MRVL_LOG(WARNING, "Disabling hash for 1 rx queue");
                priv->ppio_params.inqs_params.hash_type = PP2_PPIO_HASH_T_NONE;
-
+               priv->configured = 1;
                return 0;
        }
 
-       return mrvl_configure_rss(priv,
+       ret = mrvl_configure_rss(priv,
                        &dev->data->dev_conf.rx_adv_conf.rss_conf);
+       if (ret < 0)
+               return ret;
+
+       priv->configured = 1;
+
+       return 0;
 }
 
 /**
@@ -741,9 +817,17 @@ mrvl_dev_start(struct rte_eth_dev *dev)
                 priv->pp_id, priv->ppio_id);
        priv->ppio_params.match = match;
        priv->ppio_params.eth_start_hdr = PP2_PPIO_HDR_ETH;
-       if (mrvl_cfg)
+       priv->forward_bad_frames = 0;
+       priv->fill_bpool_buffs = MRVL_BURST_SIZE;
+
+       if (mrvl_cfg) {
                priv->ppio_params.eth_start_hdr =
                        mrvl_cfg->port[dev->data->port_id].eth_start_hdr;
+               priv->forward_bad_frames =
+                       mrvl_cfg->port[dev->data->port_id].forward_bad_frames;
+               priv->fill_bpool_buffs =
+                       mrvl_cfg->port[dev->data->port_id].fill_bpool_buffs;
+       }
 
        /*
         * Calculate the minimum bpool size for refill feature as follows:
@@ -828,7 +912,7 @@ mrvl_dev_start(struct rte_eth_dev *dev)
 
        /* For default QoS config, don't start classifier. */
        if (mrvl_cfg  &&
-           mrvl_cfg->port[dev->data->port_id].use_global_defaults == 0) {
+           mrvl_cfg->port[dev->data->port_id].use_qos_global_defaults == 0) {
                ret = mrvl_start_qos_mapping(priv);
                if (ret) {
                        MRVL_LOG(ERR, "Failed to setup QoS mapping");
@@ -845,6 +929,15 @@ mrvl_dev_start(struct rte_eth_dev *dev)
        if (dev->data->promiscuous == 1)
                mrvl_promiscuous_enable(dev);
 
+       if (priv->flow_ctrl) {
+               ret = mrvl_flow_ctrl_set(dev, &priv->fc_conf);
+               if (ret) {
+                       MRVL_LOG(ERR, "Failed to configure flow control");
+                       goto out;
+               }
+               priv->flow_ctrl = 0;
+       }
+
        if (dev->data->dev_link.link_status == ETH_LINK_UP) {
                ret = mrvl_dev_set_link_up(dev);
                if (ret) {
@@ -1126,6 +1219,9 @@ mrvl_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused)
        case SPEED_1000:
                dev->data->dev_link.link_speed = ETH_SPEED_NUM_1G;
                break;
+       case SPEED_2500:
+               dev->data->dev_link.link_speed = ETH_SPEED_NUM_2_5G;
+               break;
        case SPEED_10000:
                dev->data->dev_link.link_speed = ETH_SPEED_NUM_10G;
                break;
@@ -1617,12 +1713,15 @@ mrvl_xstats_get_names(struct rte_eth_dev *dev __rte_unused,
  *   Info structure output buffer.
  */
 static int
-mrvl_dev_infos_get(struct rte_eth_dev *dev __rte_unused,
+mrvl_dev_infos_get(struct rte_eth_dev *dev,
                   struct rte_eth_dev_info *info)
 {
+       struct mrvl_priv *priv = dev->data->dev_private;
+
        info->speed_capa = ETH_LINK_SPEED_10M |
                           ETH_LINK_SPEED_100M |
                           ETH_LINK_SPEED_1G |
+                          ETH_LINK_SPEED_2_5G |
                           ETH_LINK_SPEED_10G;
 
        info->max_rx_queues = MRVL_PP2_RXQ_MAX;
@@ -1651,6 +1750,7 @@ mrvl_dev_infos_get(struct rte_eth_dev *dev __rte_unused,
        info->default_rxconf.rx_drop_en = 1;
 
        info->max_rx_pktlen = MRVL_PKT_SIZE_MAX;
+       info->max_mtu = priv->max_mtu;
 
        return 0;
 }
@@ -2073,9 +2173,12 @@ mrvl_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        struct mrvl_priv *priv = dev->data->dev_private;
        int ret, en;
 
-       if (!priv)
-               return -EPERM;
+       if (!priv->ppio) {
+               memcpy(fc_conf, &priv->fc_conf, sizeof(struct rte_eth_fc_conf));
+               return 0;
+       }
 
+       fc_conf->autoneg = 1;
        ret = pp2_ppio_get_rx_pause(priv->ppio, &en);
        if (ret) {
                MRVL_LOG(ERR, "Failed to read rx pause state");
@@ -2119,19 +2222,26 @@ mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        int ret;
        int rx_en, tx_en;
 
-       if (!priv)
-               return -EPERM;
-
        if (fc_conf->high_water ||
            fc_conf->low_water ||
            fc_conf->pause_time ||
-           fc_conf->mac_ctrl_frame_fwd ||
-           fc_conf->autoneg) {
+           fc_conf->mac_ctrl_frame_fwd) {
                MRVL_LOG(ERR, "Flowctrl parameter is not supported");
 
                return -EINVAL;
        }
 
+       if (fc_conf->autoneg == 0) {
+               MRVL_LOG(ERR, "Flowctrl Autoneg disable is not supported");
+               return -EINVAL;
+       }
+
+       if (!priv->ppio) {
+               memcpy(&priv->fc_conf, fc_conf, sizeof(struct rte_eth_fc_conf));
+               priv->flow_ctrl = 1;
+               return 0;
+       }
+
        switch (fc_conf->mode) {
        case RTE_FC_FULL:
                rx_en = 1;
@@ -2236,32 +2346,18 @@ mrvl_rss_hash_conf_get(struct rte_eth_dev *dev,
  *
  * @param dev
  *   Pointer to the device structure.
- * @param filer_type
- *   Flow filter type.
- * @param filter_op
- *   Flow filter operation.
- * @param arg
+ * @param ops
  *   Pointer to pass the flow ops.
  *
  * @return
  *   0 on success, negative error value otherwise.
  */
 static int
-mrvl_eth_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
-                    enum rte_filter_type filter_type,
-                    enum rte_filter_op filter_op, void *arg)
+mrvl_eth_flow_ops_get(struct rte_eth_dev *dev __rte_unused,
+                     const struct rte_flow_ops **ops)
 {
-       switch (filter_type) {
-       case RTE_ETH_FILTER_GENERIC:
-               if (filter_op != RTE_ETH_FILTER_GET)
-                       return -EINVAL;
-               *(const void **)arg = &mrvl_flow_ops;
-               return 0;
-       default:
-               MRVL_LOG(WARNING, "Filter type (%d) not supported",
-                               filter_type);
-               return -EINVAL;
-       }
+       *ops = &mrvl_flow_ops;
+       return 0;
 }
 
 /**
@@ -2339,7 +2435,7 @@ static const struct eth_dev_ops mrvl_ops = {
        .flow_ctrl_set = mrvl_flow_ctrl_set,
        .rss_hash_update = mrvl_rss_hash_update,
        .rss_hash_conf_get = mrvl_rss_hash_conf_get,
-       .filter_ctrl = mrvl_eth_filter_ctrl,
+       .flow_ops_get = mrvl_eth_flow_ops_get,
        .mtr_ops_get = mrvl_mtr_ops_get,
        .tm_ops_get = mrvl_tm_ops_get,
 };
@@ -2437,22 +2533,27 @@ mrvl_desc_to_packet_type_and_offset(struct pp2_ppio_desc *desc,
  *   Mbuf offload flags.
  */
 static inline uint64_t
-mrvl_desc_to_ol_flags(struct pp2_ppio_desc *desc)
+mrvl_desc_to_ol_flags(struct pp2_ppio_desc *desc, uint64_t packet_type)
 {
-       uint64_t flags;
+       uint64_t flags = 0;
        enum pp2_inq_desc_status status;
 
-       status = pp2_ppio_inq_desc_get_l3_pkt_error(desc);
-       if (unlikely(status != PP2_DESC_ERR_OK))
-               flags = PKT_RX_IP_CKSUM_BAD;
-       else
-               flags = PKT_RX_IP_CKSUM_GOOD;
+       if (RTE_ETH_IS_IPV4_HDR(packet_type)) {
+               status = pp2_ppio_inq_desc_get_l3_pkt_error(desc);
+               if (unlikely(status != PP2_DESC_ERR_OK))
+                       flags |= PKT_RX_IP_CKSUM_BAD;
+               else
+                       flags |= PKT_RX_IP_CKSUM_GOOD;
+       }
 
-       status = pp2_ppio_inq_desc_get_l4_pkt_error(desc);
-       if (unlikely(status != PP2_DESC_ERR_OK))
-               flags |= PKT_RX_L4_CKSUM_BAD;
-       else
-               flags |= PKT_RX_L4_CKSUM_GOOD;
+       if (((packet_type & RTE_PTYPE_L4_UDP) == RTE_PTYPE_L4_UDP) ||
+           ((packet_type & RTE_PTYPE_L4_TCP) == RTE_PTYPE_L4_TCP)) {
+               status = pp2_ppio_inq_desc_get_l4_pkt_error(desc);
+               if (unlikely(status != PP2_DESC_ERR_OK))
+                       flags |= PKT_RX_L4_CKSUM_BAD;
+               else
+                       flags |= PKT_RX_L4_CKSUM_GOOD;
+       }
 
        return flags;
 }
@@ -2519,7 +2620,8 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 
                /* drop packet in case of mac, overrun or resource error */
                status = pp2_ppio_inq_desc_get_l2_pkt_error(&descs[i]);
-               if (unlikely(status != PP2_DESC_ERR_OK)) {
+               if ((unlikely(status != PP2_DESC_ERR_OK)) &&
+                       !(q->priv->forward_bad_frames)) {
                        struct pp2_buff_inf binf = {
                                .addr = rte_mbuf_data_iova_default(mbuf),
                                .cookie = (uint64_t)mbuf,
@@ -2544,7 +2646,9 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
                mbuf->l3_len = l4_offset - l3_offset;
 
                if (likely(q->cksum_enabled))
-                       mbuf->ol_flags = mrvl_desc_to_ol_flags(&descs[i]);
+                       mbuf->ol_flags =
+                               mrvl_desc_to_ol_flags(&descs[i],
+                                                     mbuf->packet_type);
 
                rx_pkts[rx_done++] = mbuf;
                q->bytes_recv += mbuf->pkt_len;
@@ -2555,7 +2659,7 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 
                if (unlikely(num <= q->priv->bpool_min_size ||
                             (!rx_done && num < q->priv->bpool_init_size))) {
-                       mrvl_fill_bpool(q, MRVL_BURST_SIZE);
+                       mrvl_fill_bpool(q, q->priv->fill_bpool_buffs);
                } else if (unlikely(num > q->priv->bpool_max_size)) {
                        int i;
                        int pkt_to_remove = num - q->priv->bpool_init_size;
@@ -2953,6 +3057,7 @@ mrvl_priv_create(const char *dev_name)
        struct pp2_bpool_params bpool_params;
        char match[MRVL_MATCH_LEN];
        struct mrvl_priv *priv;
+       uint16_t max_frame_size;
        int ret, bpool_bit;
 
        priv = rte_zmalloc_socket(dev_name, sizeof(*priv), 0, rte_socket_id());
@@ -2964,6 +3069,14 @@ mrvl_priv_create(const char *dev_name)
        if (ret)
                goto out_free_priv;
 
+       ret = pp2_ppio_get_l4_cksum_max_frame_size(priv->pp_id, priv->ppio_id,
+                                                  &max_frame_size);
+       if (ret)
+               goto out_free_priv;
+
+       priv->max_mtu = max_frame_size + RTE_ETHER_CRC_LEN -
+               MRVL_PP2_ETH_HDRS_LEN;
+
        bpool_bit = mrvl_reserve_bit(&used_bpools[priv->pp_id],
                                     PP2_BPOOL_NUM_POOLS);
        if (bpool_bit < 0)
@@ -3202,4 +3315,4 @@ static struct rte_vdev_driver pmd_mrvl_drv = {
 
 RTE_PMD_REGISTER_VDEV(net_mvpp2, pmd_mrvl_drv);
 RTE_PMD_REGISTER_ALIAS(net_mvpp2, eth_mvpp2);
-RTE_LOG_REGISTER(mrvl_logtype, pmd.net.mvpp2, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(mrvl_logtype, NOTICE);