net/mvpp2: update flow control autoneg disable handling
[dpdk.git] / drivers / net / mvpp2 / mrvl_ethdev.c
index f215500..c543137 100644 (file)
 /* prefetch shift */
 #define MRVL_MUSDK_PREFETCH_SHIFT 2
 
-/* TCAM has 25 entries reserved for uc/mc filter entries */
-#define MRVL_MAC_ADDRS_MAX 25
+/* TCAM has 25 entries reserved for uc/mc filter entries
+ * + 1 for primary mac address
+ */
+#define MRVL_MAC_ADDRS_MAX (1 + 25)
 #define MRVL_MATCH_LEN 16
 #define MRVL_PKT_EFFEC_OFFS (MRVL_PKT_OFFS + MV_MH_SIZE)
 /* Maximum allowable packet size */
                          DEV_RX_OFFLOAD_CHECKSUM)
 
 /** Port Tx offloads capabilities */
-#define MRVL_TX_OFFLOADS (DEV_TX_OFFLOAD_IPV4_CKSUM | \
-                         DEV_TX_OFFLOAD_UDP_CKSUM | \
-                         DEV_TX_OFFLOAD_TCP_CKSUM | \
+#define MRVL_TX_OFFLOAD_CHECKSUM (DEV_TX_OFFLOAD_IPV4_CKSUM | \
+                                 DEV_TX_OFFLOAD_UDP_CKSUM  | \
+                                 DEV_TX_OFFLOAD_TCP_CKSUM)
+#define MRVL_TX_OFFLOADS (MRVL_TX_OFFLOAD_CHECKSUM | \
                          DEV_TX_OFFLOAD_MULTI_SEGS)
 
+#define MRVL_TX_PKT_OFFLOADS (PKT_TX_IP_CKSUM | \
+                             PKT_TX_TCP_CKSUM | \
+                             PKT_TX_UDP_CKSUM)
+
 static const char * const valid_args[] = {
        MRVL_IFACE_NAME_ARG,
        MRVL_CFG_ARG,
@@ -83,6 +90,8 @@ static int used_bpools[PP2_NUM_PKT_PROC] = {
 static struct pp2_bpool *mrvl_port_to_bpool_lookup[RTE_MAX_ETHPORTS];
 static int mrvl_port_bpool_size[PP2_NUM_PKT_PROC][PP2_BPOOL_NUM_POOLS][RTE_MAX_LCORE];
 static uint64_t cookie_addr_high = MRVL_COOKIE_ADDR_INVALID;
+static int dummy_pool_id[PP2_NUM_PKT_PROC];
+struct pp2_bpool *dummy_pool[PP2_NUM_PKT_PROC] = {0};
 
 struct mrvl_ifnames {
        const char *names[PP2_NUM_ETH_PPIO * PP2_NUM_PKT_PROC];
@@ -182,6 +191,112 @@ static struct {
        MRVL_XSTATS_TBL_ENTRY(tx_errors)
 };
 
+static inline int
+mrvl_reserve_bit(int *bitmap, int max)
+{
+       int n = sizeof(*bitmap) * 8 - __builtin_clz(*bitmap);
+
+       if (n >= max)
+               return -1;
+
+       *bitmap |= 1 << n;
+
+       return n;
+}
+
+static int
+mrvl_pp2_fixup_init(void)
+{
+       struct pp2_bpool_params bpool_params;
+       char                    name[15];
+       int                     err, i;
+
+       memset(dummy_pool, 0, sizeof(dummy_pool));
+       for (i = 0; i < pp2_get_num_inst(); i++) {
+               dummy_pool_id[i] = mrvl_reserve_bit(&used_bpools[i],
+                                            PP2_BPOOL_NUM_POOLS);
+               if (dummy_pool_id[i] < 0) {
+                       MRVL_LOG(ERR, "Can't find free pool\n");
+                       return -1;
+               }
+
+               memset(name, 0, sizeof(name));
+               snprintf(name, sizeof(name), "pool-%d:%d", i, dummy_pool_id[i]);
+               memset(&bpool_params, 0, sizeof(bpool_params));
+               bpool_params.match = name;
+               bpool_params.buff_len = MRVL_PKT_OFFS;
+               bpool_params.dummy_short_pool = 1;
+               err = pp2_bpool_init(&bpool_params, &dummy_pool[i]);
+               if (err != 0 || !dummy_pool[i]) {
+                       MRVL_LOG(ERR, "BPool init failed!\n");
+                       used_bpools[i] &= ~(1 << dummy_pool_id[i]);
+                       return -1;
+               }
+       }
+
+       return 0;
+}
+
+/**
+ * Initialize packet processor.
+ *
+ * @return
+ *   0 on success, negative error value otherwise.
+ */
+static int
+mrvl_init_pp2(void)
+{
+       struct pp2_init_params  init_params;
+       int                     err;
+
+       memset(&init_params, 0, sizeof(init_params));
+       init_params.hif_reserved_map = MRVL_MUSDK_HIFS_RESERVED;
+       init_params.bm_pool_reserved_map = MRVL_MUSDK_BPOOLS_RESERVED;
+       init_params.rss_tbl_reserved_map = MRVL_MUSDK_RSS_RESERVED;
+       if (mrvl_cfg && mrvl_cfg->pp2_cfg.prs_udfs.num_udfs)
+               memcpy(&init_params.prs_udfs, &mrvl_cfg->pp2_cfg.prs_udfs,
+                      sizeof(struct pp2_parse_udfs));
+       err = pp2_init(&init_params);
+       if (err != 0) {
+               MRVL_LOG(ERR, "PP2 init failed");
+               return -1;
+       }
+
+       err = mrvl_pp2_fixup_init();
+       if (err != 0) {
+               MRVL_LOG(ERR, "PP2 fixup init failed");
+               return -1;
+       }
+
+       return 0;
+}
+
+static void
+mrvl_pp2_fixup_deinit(void)
+{
+       int i;
+
+       for (i = 0; i < PP2_NUM_PKT_PROC; i++) {
+               if (!dummy_pool[i])
+                       continue;
+               pp2_bpool_deinit(dummy_pool[i]);
+               used_bpools[i] &= ~(1 << dummy_pool_id[i]);
+       }
+}
+
+/**
+ * Deinitialize packet processor.
+ *
+ * @return
+ *   0 on success, negative error value otherwise.
+ */
+static void
+mrvl_deinit_pp2(void)
+{
+       mrvl_pp2_fixup_deinit();
+       pp2_deinit();
+}
+
 static inline void
 mrvl_fill_shadowq(struct mrvl_shadow_txq *sq, struct rte_mbuf *buf)
 {
@@ -198,6 +313,22 @@ mrvl_fill_shadowq(struct mrvl_shadow_txq *sq, struct rte_mbuf *buf)
        sq->size++;
 }
 
+/**
+ * Deinitialize per-lcore MUSDK hardware interfaces (hifs).
+ */
+static void
+mrvl_deinit_hifs(void)
+{
+       int i;
+
+       for (i = mrvl_lcore_first; i <= mrvl_lcore_last; i++) {
+               if (hifs[i])
+                       pp2_hif_deinit(hifs[i]);
+       }
+       used_hifs = MRVL_MUSDK_HIFS_RESERVED;
+       memset(hifs, 0, sizeof(hifs));
+}
+
 static inline void
 mrvl_fill_desc(struct pp2_ppio_desc *desc, struct rte_mbuf *buf)
 {
@@ -219,19 +350,6 @@ mrvl_get_bpool_size(int pp2_id, int pool_id)
        return size;
 }
 
-static inline int
-mrvl_reserve_bit(int *bitmap, int max)
-{
-       int n = sizeof(*bitmap) * 8 - __builtin_clz(*bitmap);
-
-       if (n >= max)
-               return -1;
-
-       *bitmap |= 1 << n;
-
-       return n;
-}
-
 static int
 mrvl_init_hif(int core_id)
 {
@@ -616,6 +734,51 @@ mrvl_tx_queue_stop(struct rte_eth_dev *dev, uint16_t queue_id)
        return 0;
 }
 
+/**
+ * Populate VLAN Filter configuration.
+ *
+ * @param dev
+ *   Pointer to Ethernet device structure.
+ * @param on
+ *   Toggle filter.
+ *
+ * @return
+ *   0 on success, negative error value otherwise.
+ */
+static int mrvl_populate_vlan_table(struct rte_eth_dev *dev, int on)
+{
+       uint32_t j;
+       int ret;
+       struct rte_vlan_filter_conf *vfc;
+
+       vfc = &dev->data->vlan_filter_conf;
+       for (j = 0; j < RTE_DIM(vfc->ids); j++) {
+               uint64_t vlan;
+               uint64_t vbit;
+               uint64_t ids = vfc->ids[j];
+
+               if (ids == 0)
+                       continue;
+
+               while (ids) {
+                       vlan = 64 * j;
+                       /* count trailing zeroes */
+                       vbit = ~ids & (ids - 1);
+                       /* clear least significant bit set */
+                       ids ^= (ids ^ (ids - 1)) ^ vbit;
+                       for (; vbit; vlan++)
+                               vbit >>= 1;
+                       ret = mrvl_vlan_filter_set(dev, vlan, on);
+                       if (ret) {
+                               MRVL_LOG(ERR, "Failed to setup VLAN filter\n");
+                               return ret;
+                       }
+               }
+       }
+
+       return 0;
+}
+
 /**
  * DPDK callback to start the device.
  *
@@ -631,8 +794,6 @@ mrvl_dev_start(struct rte_eth_dev *dev)
        struct mrvl_priv *priv = dev->data->dev_private;
        char match[MRVL_MATCH_LEN];
        int ret = 0, i, def_init_size;
-       uint32_t j;
-       struct rte_vlan_filter_conf *vfc;
        struct rte_ether_addr *mac_addr;
 
        if (priv->ppio)
@@ -641,6 +802,10 @@ mrvl_dev_start(struct rte_eth_dev *dev)
        snprintf(match, sizeof(match), "ppio-%d:%d",
                 priv->pp_id, priv->ppio_id);
        priv->ppio_params.match = match;
+       priv->ppio_params.eth_start_hdr = PP2_PPIO_HDR_ETH;
+       if (mrvl_cfg)
+               priv->ppio_params.eth_start_hdr =
+                       mrvl_cfg->port[dev->data->port_id].eth_start_hdr;
 
        /*
         * Calculate the minimum bpool size for refill feature as follows:
@@ -715,34 +880,17 @@ mrvl_dev_start(struct rte_eth_dev *dev)
        if (dev->data->all_multicast == 1)
                mrvl_allmulticast_enable(dev);
 
-       vfc = &dev->data->vlan_filter_conf;
-       for (j = 0; j < RTE_DIM(vfc->ids); j++) {
-               uint64_t vlan;
-               uint64_t vbit;
-               uint64_t ids = vfc->ids[j];
-
-               if (ids == 0)
-                       continue;
-
-               while (ids) {
-                       vlan = 64 * j;
-                       /* count trailing zeroes */
-                       vbit = ~ids & (ids - 1);
-                       /* clear least significant bit set */
-                       ids ^= (ids ^ (ids - 1)) ^ vbit;
-                       for (; vbit; vlan++)
-                               vbit >>= 1;
-                       ret = mrvl_vlan_filter_set(dev, vlan, 1);
-                       if (ret) {
-                               MRVL_LOG(ERR, "Failed to setup VLAN filter\n");
-                               goto out;
-                       }
+       if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_VLAN_FILTER) {
+               ret = mrvl_populate_vlan_table(dev, 1);
+               if (ret) {
+                       MRVL_LOG(ERR, "Failed to populate VLAN table");
+                       goto out;
                }
        }
 
        /* For default QoS config, don't start classifier. */
-       if (mrvl_qos_cfg  &&
-           mrvl_qos_cfg->port[dev->data->port_id].use_global_defaults == 0) {
+       if (mrvl_cfg  &&
+           mrvl_cfg->port[dev->data->port_id].use_global_defaults == 0) {
                ret = mrvl_start_qos_mapping(priv);
                if (ret) {
                        MRVL_LOG(ERR, "Failed to setup QoS mapping");
@@ -1671,6 +1819,41 @@ mrvl_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
                    pp2_ppio_remove_vlan(priv->ppio, vlan_id);
 }
 
+/**
+ * DPDK callback to Configure VLAN offload.
+ *
+ * @param dev
+ *   Pointer to Ethernet device structure.
+ * @param mask
+ *   VLAN offload mask.
+ *
+ * @return
+ *   0 on success, negative error value otherwise.
+ */
+static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask)
+{
+       uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;
+       int ret;
+
+       if (mask & ETH_VLAN_STRIP_MASK)
+               MRVL_LOG(ERR, "VLAN stripping is not supported\n");
+
+       if (mask & ETH_VLAN_FILTER_MASK) {
+               if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
+                       ret = mrvl_populate_vlan_table(dev, 1);
+               else
+                       ret = mrvl_populate_vlan_table(dev, 0);
+
+               if (ret)
+                       return ret;
+       }
+
+       if (mask & ETH_VLAN_EXTEND_MASK)
+               MRVL_LOG(ERR, "Extend VLAN not supported\n");
+
+       return 0;
+}
+
 /**
  * Release buffers to hardware bpool (buffer-pool)
  *
@@ -1955,6 +2138,7 @@ mrvl_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        if (!priv)
                return -EPERM;
 
+       fc_conf->autoneg = 1;
        ret = pp2_ppio_get_rx_pause(priv->ppio, &en);
        if (ret) {
                MRVL_LOG(ERR, "Failed to read rx pause state");
@@ -1963,6 +2147,19 @@ mrvl_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
 
        fc_conf->mode = en ? RTE_FC_RX_PAUSE : RTE_FC_NONE;
 
+       ret = pp2_ppio_get_tx_pause(priv->ppio, &en);
+       if (ret) {
+               MRVL_LOG(ERR, "Failed to read tx pause state");
+               return ret;
+       }
+
+       if (en) {
+               if (fc_conf->mode == RTE_FC_NONE)
+                       fc_conf->mode = RTE_FC_TX_PAUSE;
+               else
+                       fc_conf->mode = RTE_FC_FULL;
+       }
+
        return 0;
 }
 
@@ -1981,6 +2178,9 @@ static int
 mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
 {
        struct mrvl_priv *priv = dev->data->dev_private;
+       struct pp2_ppio_tx_pause_params mrvl_pause_params;
+       int ret;
+       int rx_en, tx_en;
 
        if (!priv)
                return -EPERM;
@@ -1988,23 +2188,54 @@ mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        if (fc_conf->high_water ||
            fc_conf->low_water ||
            fc_conf->pause_time ||
-           fc_conf->mac_ctrl_frame_fwd ||
-           fc_conf->autoneg) {
+           fc_conf->mac_ctrl_frame_fwd) {
                MRVL_LOG(ERR, "Flowctrl parameter is not supported");
 
                return -EINVAL;
        }
 
-       if (fc_conf->mode == RTE_FC_NONE ||
-           fc_conf->mode == RTE_FC_RX_PAUSE) {
-               int ret, en;
+       if (fc_conf->autoneg == 0) {
+               MRVL_LOG(ERR, "Flowctrl Autoneg disable is not supported");
+               return -EINVAL;
+       }
 
-               en = fc_conf->mode == RTE_FC_NONE ? 0 : 1;
-               ret = pp2_ppio_set_rx_pause(priv->ppio, en);
-               if (ret)
-                       MRVL_LOG(ERR,
-                               "Failed to change flowctrl on RX side");
+       switch (fc_conf->mode) {
+       case RTE_FC_FULL:
+               rx_en = 1;
+               tx_en = 1;
+               break;
+       case RTE_FC_TX_PAUSE:
+               rx_en = 0;
+               tx_en = 1;
+               break;
+       case RTE_FC_RX_PAUSE:
+               rx_en = 1;
+               tx_en = 0;
+               break;
+       case RTE_FC_NONE:
+               rx_en = 0;
+               tx_en = 0;
+               break;
+       default:
+               MRVL_LOG(ERR, "Incorrect Flow control flag (%d)",
+                        fc_conf->mode);
+               return -EINVAL;
+       }
 
+       /* Set RX flow control */
+       ret = pp2_ppio_set_rx_pause(priv->ppio, rx_en);
+       if (ret) {
+               MRVL_LOG(ERR, "Failed to change RX flowctrl");
+               return ret;
+       }
+
+       /* Set TX flow control */
+       mrvl_pause_params.en = tx_en;
+       /* all inqs participate in xon/xoff decision */
+       mrvl_pause_params.use_tc_pause_inqs = 0;
+       ret = pp2_ppio_set_tx_pause(priv->ppio, &mrvl_pause_params);
+       if (ret) {
+               MRVL_LOG(ERR, "Failed to change TX flowctrl");
                return ret;
        }
 
@@ -2164,6 +2395,7 @@ static const struct eth_dev_ops mrvl_ops = {
        .rxq_info_get = mrvl_rxq_info_get,
        .txq_info_get = mrvl_txq_info_get,
        .vlan_filter_set = mrvl_vlan_filter_set,
+       .vlan_offload_set = mrvl_vlan_offload_set,
        .tx_queue_start = mrvl_tx_queue_start,
        .tx_queue_stop = mrvl_tx_queue_stop,
        .rx_queue_setup = mrvl_rx_queue_setup,
@@ -2419,8 +2651,6 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
  *
  * @param ol_flags
  *   Offload flags.
- * @param packet_type
- *   Packet type bitfield.
  * @param l3_type
  *   Pointer to the pp2_ouq_l3_type structure.
  * @param l4_type
@@ -2429,12 +2659,9 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
  *   Will be set to 1 in case l3 checksum is computed.
  * @param l4_cksum
  *   Will be set to 1 in case l4 checksum is computed.
- *
- * @return
- *   0 on success, negative error value otherwise.
  */
-static inline int
-mrvl_prepare_proto_info(uint64_t ol_flags, uint32_t packet_type,
+static inline void
+mrvl_prepare_proto_info(uint64_t ol_flags,
                        enum pp2_outq_l3_type *l3_type,
                        enum pp2_outq_l4_type *l4_type,
                        int *gen_l3_cksum,
@@ -2444,26 +2671,22 @@ mrvl_prepare_proto_info(uint64_t ol_flags, uint32_t packet_type,
         * Based on ol_flags prepare information
         * for pp2_ppio_outq_desc_set_proto_info() which setups descriptor
         * for offloading.
+        * in most of the checksum cases ipv4 must be set, so this is the
+        * default value
         */
-       if (ol_flags & PKT_TX_IPV4) {
-               *l3_type = PP2_OUTQ_L3_TYPE_IPV4;
-               *gen_l3_cksum = ol_flags & PKT_TX_IP_CKSUM ? 1 : 0;
-       } else if (ol_flags & PKT_TX_IPV6) {
+       *l3_type = PP2_OUTQ_L3_TYPE_IPV4;
+       *gen_l3_cksum = ol_flags & PKT_TX_IP_CKSUM ? 1 : 0;
+
+       if (ol_flags & PKT_TX_IPV6) {
                *l3_type = PP2_OUTQ_L3_TYPE_IPV6;
                /* no checksum for ipv6 header */
                *gen_l3_cksum = 0;
-       } else {
-               /* if something different then stop processing */
-               return -1;
        }
 
-       ol_flags &= PKT_TX_L4_MASK;
-       if ((packet_type & RTE_PTYPE_L4_TCP) &&
-           ol_flags == PKT_TX_TCP_CKSUM) {
+       if ((ol_flags & PKT_TX_L4_MASK) == PKT_TX_TCP_CKSUM) {
                *l4_type = PP2_OUTQ_L4_TYPE_TCP;
                *gen_l4_cksum = 1;
-       } else if ((packet_type & RTE_PTYPE_L4_UDP) &&
-                  ol_flags == PKT_TX_UDP_CKSUM) {
+       } else if ((ol_flags & PKT_TX_L4_MASK) ==  PKT_TX_UDP_CKSUM) {
                *l4_type = PP2_OUTQ_L4_TYPE_UDP;
                *gen_l4_cksum = 1;
        } else {
@@ -2471,8 +2694,6 @@ mrvl_prepare_proto_info(uint64_t ol_flags, uint32_t packet_type,
                /* no checksum for other type */
                *gen_l4_cksum = 0;
        }
-
-       return 0;
 }
 
 /**
@@ -2573,7 +2794,7 @@ mrvl_tx_pkt_burst(void *txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
        struct pp2_hif *hif;
        struct pp2_ppio_desc descs[nb_pkts];
        unsigned int core_id = rte_lcore_id();
-       int i, ret, bytes_sent = 0;
+       int i, bytes_sent = 0;
        uint16_t num, sq_free_size;
        uint64_t addr;
 
@@ -2613,11 +2834,10 @@ mrvl_tx_pkt_burst(void *txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
                 * in case unsupported ol_flags were passed
                 * do not update descriptor offload information
                 */
-               ret = mrvl_prepare_proto_info(mbuf->ol_flags, mbuf->packet_type,
-                                             &l3_type, &l4_type, &gen_l3_cksum,
-                                             &gen_l4_cksum);
-               if (unlikely(ret))
+               if (!(mbuf->ol_flags & MRVL_TX_PKT_OFFLOADS))
                        continue;
+               mrvl_prepare_proto_info(mbuf->ol_flags, &l3_type, &l4_type,
+                                       &gen_l3_cksum, &gen_l4_cksum);
 
                pp2_ppio_outq_desc_set_proto_info(&descs[i], l3_type, l4_type,
                                                  mbuf->l2_len,
@@ -2667,7 +2887,7 @@ mrvl_tx_sg_pkt_burst(void *txq, struct rte_mbuf **tx_pkts,
        struct pp2_ppio_sg_pkts pkts;
        uint8_t frags[nb_pkts];
        unsigned int core_id = rte_lcore_id();
-       int i, j, ret, bytes_sent = 0;
+       int i, j, bytes_sent = 0;
        int tail, tail_first;
        uint16_t num, sq_free_size;
        uint16_t nb_segs, total_descs = 0;
@@ -2750,11 +2970,10 @@ mrvl_tx_sg_pkt_burst(void *txq, struct rte_mbuf **tx_pkts,
                /* In case unsupported ol_flags were passed
                 * do not update descriptor offload information
                 */
-               ret = mrvl_prepare_proto_info(mbuf->ol_flags, mbuf->packet_type,
-                                             &l3_type, &l4_type, &gen_l3_cksum,
-                                             &gen_l4_cksum);
-               if (unlikely(ret))
+               if (!(mbuf->ol_flags & MRVL_TX_PKT_OFFLOADS))
                        continue;
+               mrvl_prepare_proto_info(mbuf->ol_flags, &l3_type, &l4_type,
+                                       &gen_l3_cksum, &gen_l4_cksum);
 
                pp2_ppio_outq_desc_set_proto_info(&descs[tail_first], l3_type,
                                                  l4_type, mbuf->l2_len,
@@ -2786,37 +3005,6 @@ mrvl_tx_sg_pkt_burst(void *txq, struct rte_mbuf **tx_pkts,
        return nb_pkts;
 }
 
-/**
- * Initialize packet processor.
- *
- * @return
- *   0 on success, negative error value otherwise.
- */
-static int
-mrvl_init_pp2(void)
-{
-       struct pp2_init_params init_params;
-
-       memset(&init_params, 0, sizeof(init_params));
-       init_params.hif_reserved_map = MRVL_MUSDK_HIFS_RESERVED;
-       init_params.bm_pool_reserved_map = MRVL_MUSDK_BPOOLS_RESERVED;
-       init_params.rss_tbl_reserved_map = MRVL_MUSDK_RSS_RESERVED;
-
-       return pp2_init(&init_params);
-}
-
-/**
- * Deinitialize packet processor.
- *
- * @return
- *   0 on success, negative error value otherwise.
- */
-static void
-mrvl_deinit_pp2(void)
-{
-       pp2_deinit();
-}
-
 /**
  * Create private device structure.
  *
@@ -2956,22 +3144,6 @@ mrvl_get_ifnames(const char *key __rte_unused, const char *value,
        return 0;
 }
 
-/**
- * Deinitialize per-lcore MUSDK hardware interfaces (hifs).
- */
-static void
-mrvl_deinit_hifs(void)
-{
-       int i;
-
-       for (i = mrvl_lcore_first; i <= mrvl_lcore_last; i++) {
-               if (hifs[i])
-                       pp2_hif_deinit(hifs[i]);
-       }
-       used_hifs = MRVL_MUSDK_HIFS_RESERVED;
-       memset(hifs, 0, sizeof(hifs));
-}
-
 /**
  * DPDK callback to register the virtual device.
  *
@@ -3011,7 +3183,7 @@ rte_pmd_mrvl_probe(struct rte_vdev_device *vdev)
         * The below system initialization should be done only once,
         * on the first provided configuration file
         */
-       if (!mrvl_qos_cfg) {
+       if (!mrvl_cfg) {
                cfgnum = rte_kvargs_count(kvlist, MRVL_CFG_ARG);
                MRVL_LOG(INFO, "Parsing config file!");
                if (cfgnum > 1) {
@@ -3019,7 +3191,7 @@ rte_pmd_mrvl_probe(struct rte_vdev_device *vdev)
                        goto out_free_kvlist;
                } else if (cfgnum == 1) {
                        rte_kvargs_process(kvlist, MRVL_CFG_ARG,
-                                          mrvl_get_qoscfg, &mrvl_qos_cfg);
+                                          mrvl_get_cfg, &mrvl_cfg);
                }
        }