eventdev: hide event device related structures
[dpdk.git] / drivers / net / octeontx / octeontx_ethdev.c
index 1918696..0a2e34d 100644 (file)
@@ -9,13 +9,14 @@
 #include <string.h>
 #include <unistd.h>
 
+#include <eventdev_pmd.h>
 #include <rte_alarm.h>
 #include <rte_branch_prediction.h>
 #include <rte_bus_vdev.h>
 #include <rte_cycles.h>
 #include <rte_debug.h>
-#include <rte_devargs.h>
 #include <rte_dev.h>
+#include <rte_devargs.h>
 #include <rte_kvargs.h>
 #include <rte_malloc.h>
 #include <rte_mbuf_pool_ops.h>
@@ -47,24 +48,9 @@ enum octeontx_link_speed {
        OCTEONTX_LINK_SPEED_RESERVE2
 };
 
-int otx_net_logtype_mbox;
-int otx_net_logtype_init;
-int otx_net_logtype_driver;
-
-RTE_INIT(otx_net_init_log)
-{
-       otx_net_logtype_mbox = rte_log_register("pmd.net.octeontx.mbox");
-       if (otx_net_logtype_mbox >= 0)
-               rte_log_set_level(otx_net_logtype_mbox, RTE_LOG_NOTICE);
-
-       otx_net_logtype_init = rte_log_register("pmd.net.octeontx.init");
-       if (otx_net_logtype_init >= 0)
-               rte_log_set_level(otx_net_logtype_init, RTE_LOG_NOTICE);
-
-       otx_net_logtype_driver = rte_log_register("pmd.net.octeontx.driver");
-       if (otx_net_logtype_driver >= 0)
-               rte_log_set_level(otx_net_logtype_driver, RTE_LOG_NOTICE);
-}
+RTE_LOG_REGISTER_SUFFIX(otx_net_logtype_mbox, mbox, NOTICE);
+RTE_LOG_REGISTER_SUFFIX(otx_net_logtype_init, init, NOTICE);
+RTE_LOG_REGISTER_SUFFIX(otx_net_logtype_driver, driver, NOTICE);
 
 /* Parse integer from integer argument */
 static int
@@ -242,9 +228,9 @@ octeontx_link_status_poll(void *arg)
                        octeontx_link_status_update(nic, &link);
                        octeontx_link_status_print(dev, &link);
                        rte_eth_linkstatus_set(dev, &link);
-                       _rte_eth_dev_callback_process(dev,
-                                                     RTE_ETH_EVENT_INTR_LSC,
-                                                     NULL);
+                       rte_eth_dev_callback_process(dev,
+                                                    RTE_ETH_EVENT_INTR_LSC,
+                                                    NULL);
                }
        }
 
@@ -370,6 +356,16 @@ octeontx_tx_offload_flags(struct rte_eth_dev *eth_dev)
        struct octeontx_nic *nic = octeontx_pmd_priv(eth_dev);
        uint16_t flags = 0;
 
+       if (nic->tx_offloads & DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM ||
+           nic->tx_offloads & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM)
+               flags |= OCCTX_TX_OFFLOAD_OL3_OL4_CSUM_F;
+
+       if (nic->tx_offloads & DEV_TX_OFFLOAD_IPV4_CKSUM ||
+           nic->tx_offloads & DEV_TX_OFFLOAD_TCP_CKSUM ||
+           nic->tx_offloads & DEV_TX_OFFLOAD_UDP_CKSUM ||
+           nic->tx_offloads & DEV_TX_OFFLOAD_SCTP_CKSUM)
+               flags |= OCCTX_TX_OFFLOAD_L3_L4_CSUM_F;
+
        if (!(nic->tx_offloads & DEV_TX_OFFLOAD_MBUF_FAST_FREE))
                flags |= OCCTX_TX_OFFLOAD_MBUF_NOFF_F;
 
@@ -383,13 +379,15 @@ static uint16_t
 octeontx_rx_offload_flags(struct rte_eth_dev *eth_dev)
 {
        struct octeontx_nic *nic = octeontx_pmd_priv(eth_dev);
-       struct rte_eth_dev_data *data = eth_dev->data;
-       struct rte_eth_conf *conf = &data->dev_conf;
-       struct rte_eth_rxmode *rxmode = &conf->rxmode;
        uint16_t flags = 0;
 
-       if (rxmode->mq_mode == ETH_MQ_RX_RSS)
-               flags |= OCCTX_RX_OFFLOAD_RSS_F;
+       if (nic->rx_offloads & (DEV_RX_OFFLOAD_TCP_CKSUM |
+                        DEV_RX_OFFLOAD_UDP_CKSUM))
+               flags |= OCCTX_RX_OFFLOAD_CSUM_F;
+
+       if (nic->rx_offloads & (DEV_RX_OFFLOAD_IPV4_CKSUM |
+                               DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM))
+               flags |= OCCTX_RX_OFFLOAD_CSUM_F;
 
        if (nic->rx_offloads & DEV_RX_OFFLOAD_SCATTER) {
                flags |= OCCTX_RX_MULTI_SEG_F;
@@ -481,7 +479,7 @@ octeontx_dev_configure(struct rte_eth_dev *dev)
        return 0;
 }
 
-static void
+static int
 octeontx_dev_close(struct rte_eth_dev *dev)
 {
        struct octeontx_txq *txq = NULL;
@@ -490,6 +488,8 @@ octeontx_dev_close(struct rte_eth_dev *dev)
        int ret;
 
        PMD_INIT_FUNC_TRACE();
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+               return 0;
 
        rte_event_dev_close(nic->evdev);
 
@@ -512,14 +512,9 @@ octeontx_dev_close(struct rte_eth_dev *dev)
                rte_free(txq);
        }
 
-       /* Free MAC address table */
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = NULL;
-
        octeontx_port_close(nic);
 
-       dev->tx_pkt_burst = NULL;
-       dev->rx_pkt_burst = NULL;
+       return 0;
 }
 
 static int
@@ -530,10 +525,6 @@ octeontx_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)
        struct rte_eth_dev_data *data = eth_dev->data;
        int rc = 0;
 
-       /* Check if MTU is within the allowed range */
-       if (frame_size < OCCTX_MIN_FRS || frame_size > OCCTX_MAX_FRS)
-               return -EINVAL;
-
        buffsz = data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM;
 
        /* Refuse MTU that requires the support of scattered packets
@@ -558,13 +549,6 @@ octeontx_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu)
        if (rc)
                return rc;
 
-       if (frame_size > RTE_ETHER_MAX_LEN)
-               nic->rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
-       else
-               nic->rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
-
-       /* Update max_rx_pkt_len */
-       data->dev_conf.rxmode.max_rx_pkt_len = frame_size;
        octeontx_log_info("Received pkt beyond  maxlen %d will be dropped",
                          frame_size);
 
@@ -587,7 +571,7 @@ octeontx_recheck_rx_offloads(struct octeontx_rxq *rxq)
        buffsz = mbp_priv->mbuf_data_room_size - RTE_PKTMBUF_HEADROOM;
 
        /* Setup scatter mode if needed by jumbo */
-       if (data->dev_conf.rxmode.max_rx_pkt_len > buffsz) {
+       if (data->mtu > buffsz) {
                nic->rx_offloads |= DEV_RX_OFFLOAD_SCATTER;
                nic->rx_offload_flags |= octeontx_rx_offload_flags(eth_dev);
                nic->tx_offload_flags |= octeontx_tx_offload_flags(eth_dev);
@@ -599,8 +583,8 @@ octeontx_recheck_rx_offloads(struct octeontx_rxq *rxq)
        evdev_priv->rx_offload_flags = nic->rx_offload_flags;
        evdev_priv->tx_offload_flags = nic->tx_offload_flags;
 
-       /* Setup MTU based on max_rx_pkt_len */
-       nic->mtu = data->dev_conf.rxmode.max_rx_pkt_len - OCCTX_L2_OVERHEAD;
+       /* Setup MTU */
+       nic->mtu = data->mtu;
 
        return 0;
 }
@@ -621,7 +605,7 @@ octeontx_dev_start(struct rte_eth_dev *dev)
                octeontx_recheck_rx_offloads(rxq);
        }
 
-       /* Setting up the mtu based on max_rx_pkt_len */
+       /* Setting up the mtu */
        ret = octeontx_dev_mtu_set(dev, nic->mtu);
        if (ret) {
                octeontx_log_err("Failed to set default MTU size %d", ret);
@@ -679,7 +663,7 @@ error:
        return ret;
 }
 
-static void
+static int
 octeontx_dev_stop(struct rte_eth_dev *dev)
 {
        struct octeontx_nic *nic = octeontx_pmd_priv(dev);
@@ -693,14 +677,14 @@ octeontx_dev_stop(struct rte_eth_dev *dev)
        if (ret < 0) {
                octeontx_log_err("failed to req stop port %d res=%d",
                                        nic->port_id, ret);
-               return;
+               return ret;
        }
 
        ret = octeontx_pki_port_stop(nic->port_id);
        if (ret < 0) {
                octeontx_log_err("failed to stop pki port %d res=%d",
                                        nic->port_id, ret);
-               return;
+               return ret;
        }
 
        ret = octeontx_pko_channel_stop(nic->base_ochan);
@@ -708,8 +692,10 @@ octeontx_dev_stop(struct rte_eth_dev *dev)
                octeontx_log_err("failed to stop channel %d VF%d %d %d",
                             nic->base_ochan, nic->port_id, nic->num_tx_queues,
                             ret);
-               return;
+               return ret;
        }
+
+       return 0;
 }
 
 static int
@@ -871,7 +857,6 @@ octeontx_dev_info(struct rte_eth_dev *dev,
 
        dev_info->max_mac_addrs =
                                octeontx_bgx_port_mac_entries_get(nic->port_id);
-       dev_info->max_rx_pktlen = PKI_MAX_PKTLEN;
        dev_info->max_rx_queues = 1;
        dev_info->max_tx_queues = PKO_MAX_NUM_DQ;
        dev_info->min_rx_bufsize = 0;
@@ -976,20 +961,18 @@ octeontx_dev_tx_queue_stop(struct rte_eth_dev *dev, uint16_t qidx)
 }
 
 static void
-octeontx_dev_tx_queue_release(void *tx_queue)
+octeontx_dev_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid)
 {
-       struct octeontx_txq *txq = tx_queue;
        int res;
 
        PMD_INIT_FUNC_TRACE();
 
-       if (txq) {
-               res = octeontx_dev_tx_queue_stop(txq->eth_dev, txq->queue_id);
+       if (dev->data->tx_queues[qid]) {
+               res = octeontx_dev_tx_queue_stop(dev, qid);
                if (res < 0)
-                       octeontx_log_err("failed stop tx_queue(%d)\n",
-                                  txq->queue_id);
+                       octeontx_log_err("failed stop tx_queue(%d)\n", qid);
 
-               rte_free(txq);
+               rte_free(dev->data->tx_queues[qid]);
        }
 }
 
@@ -1018,7 +1001,7 @@ octeontx_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t qidx,
        if (dev->data->tx_queues[qidx] != NULL) {
                PMD_TX_LOG(DEBUG, "freeing memory prior to re-allocation %d",
                                qidx);
-               octeontx_dev_tx_queue_release(dev->data->tx_queues[qidx]);
+               octeontx_dev_tx_queue_release(dev, qidx);
                dev->data->tx_queues[qidx] = NULL;
        }
 
@@ -1226,9 +1209,9 @@ octeontx_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t qidx,
 }
 
 static void
-octeontx_dev_rx_queue_release(void *rxq)
+octeontx_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid)
 {
-       rte_free(rxq);
+       rte_free(dev->data->rx_queues[qid]);
 }
 
 static const uint32_t *
@@ -1366,7 +1349,6 @@ octeontx_create(struct rte_vdev_device *dev, int port, uint8_t evdev,
 
        eth_dev->device = &dev->device;
        eth_dev->intr_handle = NULL;
-       eth_dev->data->kdrv = RTE_KDRV_NONE;
        eth_dev->data->numa_node = dev->device.numa_node;
 
        data->port_id = eth_dev->data->port_id;
@@ -1442,6 +1424,7 @@ octeontx_create(struct rte_vdev_device *dev, int port, uint8_t evdev,
 
 free_mac_addrs:
        rte_free(data->mac_addrs);
+       data->mac_addrs = NULL;
 err:
        if (nic)
                octeontx_port_close(nic);
@@ -1466,10 +1449,9 @@ octeontx_remove(struct rte_vdev_device *dev)
        for (i = 0; i < OCTEONTX_VDEV_DEFAULT_MAX_NR_PORT; i++) {
                sprintf(octtx_name, "eth_octeontx_%d", i);
 
-               /* reserve an ethdev entry */
                eth_dev = rte_eth_dev_allocated(octtx_name);
                if (eth_dev == NULL)
-                       return -ENODEV;
+                       continue; /* port already released */
 
                if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
                        rte_eth_dev_release_port(eth_dev);
@@ -1479,9 +1461,8 @@ octeontx_remove(struct rte_vdev_device *dev)
                nic = octeontx_pmd_priv(eth_dev);
                rte_event_dev_stop(nic->evdev);
                PMD_INIT_LOG(INFO, "Closing octeontx device %s", octtx_name);
-
+               octeontx_dev_close(eth_dev);
                rte_eth_dev_release_port(eth_dev);
-               rte_event_dev_close(nic->evdev);
        }
 
        if (rte_eal_process_type() != RTE_PROC_PRIMARY)