ethdev: remove detachable device flag
[dpdk.git] / drivers / net / pcap / rte_eth_pcap.c
index 493db31..3205df8 100644 (file)
@@ -40,6 +40,7 @@
 
 #include <rte_cycles.h>
 #include <rte_ethdev.h>
+#include <rte_ethdev_vdev.h>
 #include <rte_kvargs.h>
 #include <rte_malloc.h>
 #include <rte_mbuf.h>
@@ -74,7 +75,7 @@ struct queue_stat {
 
 struct pcap_rx_queue {
        pcap_t *pcap;
-       uint8_t in_port;
+       uint16_t in_port;
        struct rte_mempool *mb_pool;
        struct queue_stat rx_stat;
        char name[PATH_MAX];
@@ -97,7 +98,7 @@ struct pmd_internals {
 };
 
 struct pmd_devargs {
-       unsigned num_of_queue;
+       unsigned int num_of_queue;
        struct devargs_queue {
                pcap_dumper_t *dumper;
                pcap_t *pcap;
@@ -118,7 +119,7 @@ static const char *valid_arguments[] = {
 static struct ether_addr eth_addr = {
        .addr_bytes = { 0, 0, 0, 0x1, 0x2, 0x3 }
 };
-static const char *drivername = "Pcap PMD";
+
 static struct rte_eth_link pmd_link = {
                .link_speed = ETH_SPEED_NUM_10G,
                .link_duplex = ETH_LINK_FULL_DUPLEX,
@@ -182,7 +183,7 @@ eth_pcap_gather_data(unsigned char *data, struct rte_mbuf *mbuf)
 static uint16_t
 eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       unsigned i;
+       unsigned int i;
        struct pcap_pkthdr header;
        const u_char *packet;
        struct rte_mbuf *mbuf;
@@ -202,17 +203,17 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                packet = pcap_next(pcap_q->pcap, &header);
                if (unlikely(packet == NULL))
                        break;
-               else
-                       mbuf = rte_pktmbuf_alloc(pcap_q->mb_pool);
+
+               mbuf = rte_pktmbuf_alloc(pcap_q->mb_pool);
                if (unlikely(mbuf == NULL))
                        break;
 
                /* Now get the space available for data in the mbuf */
-               buf_size = (uint16_t)(rte_pktmbuf_data_room_size(pcap_q->mb_pool) -
-                               RTE_PKTMBUF_HEADROOM);
+               buf_size = rte_pktmbuf_data_room_size(pcap_q->mb_pool) -
+                               RTE_PKTMBUF_HEADROOM;
 
                if (header.caplen <= buf_size) {
-                       /* pcap packet will fit in the mbuf, go ahead and copy */
+                       /* pcap packet will fit in the mbuf, can copy it */
                        rte_memcpy(rte_pktmbuf_mtod(mbuf, void *), packet,
                                        header.caplen);
                        mbuf->data_len = (uint16_t)header.caplen;
@@ -221,8 +222,10 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                        if (unlikely(eth_pcap_rx_jumbo(pcap_q->mb_pool,
                                                       mbuf,
                                                       packet,
-                                                      header.caplen) == -1))
+                                                      header.caplen) == -1)) {
+                               rte_pktmbuf_free(mbuf);
                                break;
+                       }
                }
 
                mbuf->pkt_len = (uint16_t)header.caplen;
@@ -244,7 +247,7 @@ calculate_timestamp(struct timeval *ts) {
 
        cycles = rte_get_timer_cycles() - start_cycles;
        cur_time.tv_sec = cycles / hz;
-       cur_time.tv_usec = (cycles % hz) * 10e6 / hz;
+       cur_time.tv_usec = (cycles % hz) * 1e6 / hz;
        timeradd(&start_time, &cur_time, ts);
 }
 
@@ -254,7 +257,7 @@ calculate_timestamp(struct timeval *ts) {
 static uint16_t
 eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       unsigned i;
+       unsigned int i;
        struct rte_mbuf *mbuf;
        struct pcap_tx_queue *dumper_q = queue;
        uint16_t num_tx = 0;
@@ -264,7 +267,8 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        if (dumper_q->dumper == NULL || nb_pkts == 0)
                return 0;
 
-       /* writes the nb_pkts packets to the previously opened pcap file dumper */
+       /* writes the nb_pkts packets to the previously opened pcap file
+        * dumper */
        for (i = 0; i < nb_pkts; i++) {
                mbuf = bufs[i];
                calculate_timestamp(&header.ts);
@@ -281,8 +285,7 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                                          tx_pcap_data);
                        } else {
                                RTE_LOG(ERR, PMD,
-                                       "Dropping PCAP packet. "
-                                       "Size (%d) > max jumbo size (%d).\n",
+                                       "Dropping PCAP packet. Size (%d) > max jumbo size (%d).\n",
                                        mbuf->pkt_len,
                                        ETHER_MAX_JUMBO_FRAME_LEN);
 
@@ -291,9 +294,9 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                        }
                }
 
-               rte_pktmbuf_free(mbuf);
                num_tx++;
                tx_bytes += mbuf->pkt_len;
+               rte_pktmbuf_free(mbuf);
        }
 
        /*
@@ -315,7 +318,7 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 static uint16_t
 eth_pcap_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       unsigned i;
+       unsigned int i;
        int ret;
        struct rte_mbuf *mbuf;
        struct pcap_tx_queue *tx_queue = queue;
@@ -339,8 +342,7 @@ eth_pcap_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                                                tx_pcap_data, mbuf->pkt_len);
                        } else {
                                RTE_LOG(ERR, PMD,
-                                       "Dropping PCAP packet. "
-                                       "Size (%d) > max jumbo size (%d).\n",
+                                       "Dropping PCAP packet. Size (%d) > max jumbo size (%d).\n",
                                        mbuf->pkt_len,
                                        ETHER_MAX_JUMBO_FRAME_LEN);
 
@@ -400,14 +402,15 @@ open_single_tx_pcap(const char *pcap_filename, pcap_dumper_t **dumper)
         * with pcap_dump_open(). We create big enough an Ethernet
         * pcap holder.
         */
-       if ((tx_pcap = pcap_open_dead(DLT_EN10MB, RTE_ETH_PCAP_SNAPSHOT_LEN))
-                       == NULL) {
+       tx_pcap = pcap_open_dead(DLT_EN10MB, RTE_ETH_PCAP_SNAPSHOT_LEN);
+       if (tx_pcap == NULL) {
                RTE_LOG(ERR, PMD, "Couldn't create dead pcap\n");
                return -1;
        }
 
        /* The dumper is created using the previous pcap_t reference */
-       if ((*dumper = pcap_dump_open(tx_pcap, pcap_filename)) == NULL) {
+       *dumper = pcap_dump_open(tx_pcap, pcap_filename);
+       if (*dumper == NULL) {
                RTE_LOG(ERR, PMD, "Couldn't open %s for writing.\n",
                        pcap_filename);
                return -1;
@@ -419,8 +422,10 @@ open_single_tx_pcap(const char *pcap_filename, pcap_dumper_t **dumper)
 static int
 open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap)
 {
-       if ((*pcap = pcap_open_offline(pcap_filename, errbuf)) == NULL) {
-               RTE_LOG(ERR, PMD, "Couldn't open %s: %s\n", pcap_filename, errbuf);
+       *pcap = pcap_open_offline(pcap_filename, errbuf);
+       if (*pcap == NULL) {
+               RTE_LOG(ERR, PMD, "Couldn't open %s: %s\n", pcap_filename,
+                       errbuf);
                return -1;
        }
 
@@ -430,7 +435,7 @@ open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap)
 static int
 eth_dev_start(struct rte_eth_dev *dev)
 {
-       unsigned i;
+       unsigned int i;
        struct pmd_internals *internals = dev->data->dev_private;
        struct pcap_tx_queue *tx;
        struct pcap_rx_queue *rx;
@@ -452,10 +457,12 @@ eth_dev_start(struct rte_eth_dev *dev)
        for (i = 0; i < dev->data->nb_tx_queues; i++) {
                tx = &internals->tx_queue[i];
 
-               if (!tx->dumper && strcmp(tx->type, ETH_PCAP_TX_PCAP_ARG) == 0) {
+               if (!tx->dumper &&
+                               strcmp(tx->type, ETH_PCAP_TX_PCAP_ARG) == 0) {
                        if (open_single_tx_pcap(tx->name, &tx->dumper) < 0)
                                return -1;
-               } else if (!tx->pcap && strcmp(tx->type, ETH_PCAP_TX_IFACE_ARG) == 0) {
+               } else if (!tx->pcap &&
+                               strcmp(tx->type, ETH_PCAP_TX_IFACE_ARG) == 0) {
                        if (open_single_iface(tx->name, &tx->pcap) < 0)
                                return -1;
                }
@@ -491,7 +498,7 @@ status_up:
 static void
 eth_dev_stop(struct rte_eth_dev *dev)
 {
-       unsigned i;
+       unsigned int i;
        struct pmd_internals *internals = dev->data->dev_private;
        struct pcap_tx_queue *tx;
        struct pcap_rx_queue *rx;
@@ -545,20 +552,18 @@ eth_dev_info(struct rte_eth_dev *dev,
 {
        struct pmd_internals *internals = dev->data->dev_private;
 
-       dev_info->driver_name = drivername;
        dev_info->if_index = internals->if_index;
        dev_info->max_mac_addrs = 1;
        dev_info->max_rx_pktlen = (uint32_t) -1;
        dev_info->max_rx_queues = dev->data->nb_rx_queues;
        dev_info->max_tx_queues = dev->data->nb_tx_queues;
        dev_info->min_rx_bufsize = 0;
-       dev_info->pci_dev = NULL;
 }
 
-static void
+static int
 eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 {
-       unsigned i;
+       unsigned int i;
        unsigned long rx_packets_total = 0, rx_bytes_total = 0;
        unsigned long tx_packets_total = 0, tx_bytes_total = 0;
        unsigned long tx_packets_err_total = 0;
@@ -587,12 +592,14 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
        stats->opackets = tx_packets_total;
        stats->obytes = tx_bytes_total;
        stats->oerrors = tx_packets_err_total;
+
+       return 0;
 }
 
 static void
 eth_stats_reset(struct rte_eth_dev *dev)
 {
-       unsigned i;
+       unsigned int i;
        struct pmd_internals *internal = dev->data->dev_private;
 
        for (i = 0; i < dev->data->nb_rx_queues; i++) {
@@ -649,7 +656,6 @@ eth_tx_queue_setup(struct rte_eth_dev *dev,
                unsigned int socket_id __rte_unused,
                const struct rte_eth_txconf *tx_conf __rte_unused)
 {
-
        struct pmd_internals *internals = dev->data->dev_private;
 
        dev->data->tx_queues[tx_queue_id] = &internals->tx_queue[tx_queue_id];
@@ -679,7 +685,7 @@ static const struct eth_dev_ops ops = {
 static int
 open_rx_pcap(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
+       unsigned int i;
        const char *pcap_filename = value;
        struct pmd_devargs *rx = extra_args;
        pcap_t *pcap = NULL;
@@ -703,7 +709,7 @@ open_rx_pcap(const char *key, const char *value, void *extra_args)
 static int
 open_tx_pcap(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
+       unsigned int i;
        const char *pcap_filename = value;
        struct pmd_devargs *dumpers = extra_args;
        pcap_dumper_t *dumper;
@@ -746,7 +752,7 @@ open_rx_tx_iface(const char *key, const char *value, void *extra_args)
 static inline int
 open_rx_iface(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
+       unsigned int i;
        const char *iface = value;
        struct pmd_devargs *rx = extra_args;
        pcap_t *pcap = NULL;
@@ -768,7 +774,7 @@ open_rx_iface(const char *key, const char *value, void *extra_args)
 static int
 open_tx_iface(const char *key, const char *value, void *extra_args)
 {
-       unsigned i;
+       unsigned int i;
        const char *iface = value;
        struct pmd_devargs *tx = extra_args;
        pcap_t *pcap;
@@ -784,14 +790,20 @@ open_tx_iface(const char *key, const char *value, void *extra_args)
        return 0;
 }
 
+static struct rte_vdev_driver pmd_pcap_drv;
+
 static int
-rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
-               const unsigned nb_tx_queues, struct pmd_internals **internals,
+pmd_init_internals(struct rte_vdev_device *vdev,
+               const unsigned int nb_rx_queues,
+               const unsigned int nb_tx_queues,
+               struct pmd_internals **internals,
                struct rte_eth_dev **eth_dev)
 {
        struct rte_eth_dev_data *data = NULL;
-       unsigned int numa_node = rte_socket_id();
+       unsigned int numa_node = vdev->device.numa_node;
+       const char *name;
 
+       name = rte_vdev_device_name(vdev);
        RTE_LOG(INFO, PMD, "Creating pcap-backed ethdev on numa socket %u\n",
                numa_node);
 
@@ -800,17 +812,14 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
         */
        data = rte_zmalloc_socket(name, sizeof(*data), 0, numa_node);
        if (data == NULL)
-               goto error;
-
-       *internals = rte_zmalloc_socket(name, sizeof(**internals), 0,
-                       numa_node);
-       if (*internals == NULL)
-               goto error;
+               return -1;
 
        /* reserve an ethdev entry */
-       *eth_dev = rte_eth_dev_allocate(name);
-       if (*eth_dev == NULL)
-               goto error;
+       *eth_dev = rte_eth_vdev_allocate(vdev, sizeof(**internals));
+       if (*eth_dev == NULL) {
+               rte_free(data);
+               return -1;
+       }
 
        /* now put it all together
         * - store queue data in internals,
@@ -818,9 +827,8 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
         * - point eth_dev_data to internals
         * - and point eth_dev structure to new eth_dev_data structure
         */
-       data->dev_private = *internals;
-       data->port_id = (*eth_dev)->data->port_id;
-       snprintf(data->name, sizeof(data->name), "%s", (*eth_dev)->data->name);
+       *internals = (*eth_dev)->data->dev_private;
+       rte_memcpy(data, (*eth_dev)->data, sizeof(*data));
        data->nb_rx_queues = (uint16_t)nb_rx_queues;
        data->nb_tx_queues = (uint16_t)nb_tx_queues;
        data->dev_link = pmd_link;
@@ -832,30 +840,20 @@ rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues,
         */
        (*eth_dev)->data = data;
        (*eth_dev)->dev_ops = &ops;
-       (*eth_dev)->driver = NULL;
-       data->dev_flags = RTE_ETH_DEV_DETACHABLE;
-       data->kdrv = RTE_KDRV_NONE;
-       data->drv_name = drivername;
-       data->numa_node = numa_node;
 
        return 0;
-
-error:
-       rte_free(data);
-       rte_free(*internals);
-
-       return -1;
 }
 
 static int
-rte_eth_from_pcaps_common(const char *name, struct pmd_devargs *rx_queues,
-               const unsigned nb_rx_queues, struct pmd_devargs *tx_queues,
-               const unsigned nb_tx_queues, struct rte_kvargs *kvlist,
-               struct pmd_internals **internals, struct rte_eth_dev **eth_dev)
+eth_from_pcaps_common(struct rte_vdev_device *vdev,
+               struct pmd_devargs *rx_queues, const unsigned int nb_rx_queues,
+               struct pmd_devargs *tx_queues, const unsigned int nb_tx_queues,
+               struct rte_kvargs *kvlist, struct pmd_internals **internals,
+               struct rte_eth_dev **eth_dev)
 {
        struct rte_kvargs_pair *pair = NULL;
-       unsigned k_idx;
-       unsigned i;
+       unsigned int k_idx;
+       unsigned int i;
 
        /* do some parameter checking */
        if (rx_queues == NULL && nb_rx_queues > 0)
@@ -863,7 +861,7 @@ rte_eth_from_pcaps_common(const char *name, struct pmd_devargs *rx_queues,
        if (tx_queues == NULL && nb_tx_queues > 0)
                return -1;
 
-       if (rte_pmd_init_internals(name, nb_rx_queues, nb_tx_queues, internals,
+       if (pmd_init_internals(vdev, nb_rx_queues, nb_tx_queues, internals,
                        eth_dev) < 0)
                return -1;
 
@@ -901,16 +899,17 @@ rte_eth_from_pcaps_common(const char *name, struct pmd_devargs *rx_queues,
 }
 
 static int
-rte_eth_from_pcaps(const char *name, struct pmd_devargs *rx_queues,
-               const unsigned nb_rx_queues, struct pmd_devargs *tx_queues,
-               const unsigned nb_tx_queues, struct rte_kvargs *kvlist,
-               int single_iface, unsigned int using_dumpers)
+eth_from_pcaps(struct rte_vdev_device *vdev,
+               struct pmd_devargs *rx_queues, const unsigned int nb_rx_queues,
+               struct pmd_devargs *tx_queues, const unsigned int nb_tx_queues,
+               struct rte_kvargs *kvlist, int single_iface,
+               unsigned int using_dumpers)
 {
        struct pmd_internals *internals = NULL;
        struct rte_eth_dev *eth_dev = NULL;
        int ret;
 
-       ret = rte_eth_from_pcaps_common(name, rx_queues, nb_rx_queues,
+       ret = eth_from_pcaps_common(vdev, rx_queues, nb_rx_queues,
                tx_queues, nb_tx_queues, kvlist, &internals, &eth_dev);
 
        if (ret < 0)
@@ -930,8 +929,9 @@ rte_eth_from_pcaps(const char *name, struct pmd_devargs *rx_queues,
 }
 
 static int
-rte_pmd_pcap_devinit(const char *name, const char *params)
+pmd_pcap_probe(struct rte_vdev_device *dev)
 {
+       const char *name;
        unsigned int is_rx_pcap = 0, is_tx_pcap = 0;
        struct rte_kvargs *kvlist;
        struct pmd_devargs pcaps = {0};
@@ -939,13 +939,14 @@ rte_pmd_pcap_devinit(const char *name, const char *params)
        int single_iface = 0;
        int ret;
 
+       name = rte_vdev_device_name(dev);
        RTE_LOG(INFO, PMD, "Initializing pmd_pcap for %s\n", name);
 
        gettimeofday(&start_time, NULL);
        start_cycles = rte_get_timer_cycles();
        hz = rte_get_timer_hz();
 
-       kvlist = rte_kvargs_parse(params, valid_arguments);
+       kvlist = rte_kvargs_parse(rte_vdev_device_args(dev), valid_arguments);
        if (kvlist == NULL)
                return -1;
 
@@ -1019,7 +1020,7 @@ rte_pmd_pcap_devinit(const char *name, const char *params)
                goto free_kvlist;
 
 create_eth:
-       ret = rte_eth_from_pcaps(name, &pcaps, pcaps.num_of_queue, &dumpers,
+       ret = eth_from_pcaps(dev, &pcaps, pcaps.num_of_queue, &dumpers,
                dumpers.num_of_queue, kvlist, single_iface, is_tx_pcap);
 
 free_kvlist:
@@ -1029,18 +1030,18 @@ free_kvlist:
 }
 
 static int
-rte_pmd_pcap_devuninit(const char *name)
+pmd_pcap_remove(struct rte_vdev_device *dev)
 {
        struct rte_eth_dev *eth_dev = NULL;
 
        RTE_LOG(INFO, PMD, "Closing pcap ethdev on numa socket %u\n",
                        rte_socket_id());
 
-       if (name == NULL)
+       if (!dev)
                return -1;
 
        /* reserve an ethdev entry */
-       eth_dev = rte_eth_dev_allocated(name);
+       eth_dev = rte_eth_dev_allocated(rte_vdev_device_name(dev));
        if (eth_dev == NULL)
                return -1;
 
@@ -1053,12 +1054,13 @@ rte_pmd_pcap_devuninit(const char *name)
 }
 
 static struct rte_vdev_driver pmd_pcap_drv = {
-       .init = rte_pmd_pcap_devinit,
-       .uninit = rte_pmd_pcap_devuninit,
+       .probe = pmd_pcap_probe,
+       .remove = pmd_pcap_remove,
 };
 
-DRIVER_REGISTER_VDEV(net_pcap, pmd_pcap_drv);
-DRIVER_REGISTER_PARAM_STRING(net_pcap,
+RTE_PMD_REGISTER_VDEV(net_pcap, pmd_pcap_drv);
+RTE_PMD_REGISTER_ALIAS(net_pcap, eth_pcap);
+RTE_PMD_REGISTER_PARAM_STRING(net_pcap,
        ETH_PCAP_RX_PCAP_ARG "=<string> "
        ETH_PCAP_TX_PCAP_ARG "=<string> "
        ETH_PCAP_RX_IFACE_ARG "=<ifc> "