log: add log stream accessor
[dpdk.git] / drivers / net / pcap / rte_eth_pcap.c
index 764e599..5186d8f 100644 (file)
 #define ETH_PCAP_TX_IFACE_ARG "tx_iface"
 #define ETH_PCAP_IFACE_ARG    "iface"
 #define ETH_PCAP_PHY_MAC_ARG  "phy_mac"
+#define ETH_PCAP_INFINITE_RX_ARG  "infinite_rx"
 
 #define ETH_PCAP_ARG_MAXLEN    64
 
 #define RTE_PMD_PCAP_MAX_QUEUES 16
 
 static char errbuf[PCAP_ERRBUF_SIZE];
-static unsigned char tx_pcap_data[RTE_ETH_PCAP_SNAPLEN];
 static struct timeval start_time;
 static uint64_t start_cycles;
 static uint64_t hz;
@@ -64,6 +64,9 @@ struct pcap_rx_queue {
        struct queue_stat rx_stat;
        char name[PATH_MAX];
        char type[ETH_PCAP_ARG_MAXLEN];
+
+       /* Contains pre-generated packets to be looped through */
+       struct rte_ring *pkts;
 };
 
 struct pcap_tx_queue {
@@ -82,6 +85,7 @@ struct pmd_internals {
        int if_index;
        int single_iface;
        int phy_mac;
+       unsigned int infinite_rx;
 };
 
 struct pmd_process_private {
@@ -107,6 +111,9 @@ struct pmd_devargs_all {
        int single_iface;
        unsigned int is_tx_pcap;
        unsigned int is_tx_iface;
+       unsigned int is_rx_pcap;
+       unsigned int is_rx_iface;
+       unsigned int infinite_rx;
 };
 
 static const char *valid_arguments[] = {
@@ -117,6 +124,7 @@ static const char *valid_arguments[] = {
        ETH_PCAP_TX_IFACE_ARG,
        ETH_PCAP_IFACE_ARG,
        ETH_PCAP_PHY_MAC_ARG,
+       ETH_PCAP_INFINITE_RX_ARG,
        NULL
 };
 
@@ -171,19 +179,41 @@ eth_pcap_rx_jumbo(struct rte_mempool *mb_pool, struct rte_mbuf *mbuf,
        return mbuf->nb_segs;
 }
 
-/* Copy data from mbuf chain to a buffer suitable for writing to a PCAP file. */
-static void
-eth_pcap_gather_data(unsigned char *data, struct rte_mbuf *mbuf)
+static uint16_t
+eth_pcap_rx_infinite(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 {
-       uint16_t data_len = 0;
+       int i;
+       struct pcap_rx_queue *pcap_q = queue;
+       uint32_t rx_bytes = 0;
+
+       if (unlikely(nb_pkts == 0))
+               return 0;
 
-       while (mbuf) {
-               rte_memcpy(data + data_len, rte_pktmbuf_mtod(mbuf, void *),
-                       mbuf->data_len);
+       if (rte_pktmbuf_alloc_bulk(pcap_q->mb_pool, bufs, nb_pkts) != 0)
+               return 0;
 
-               data_len += mbuf->data_len;
-               mbuf = mbuf->next;
+       for (i = 0; i < nb_pkts; i++) {
+               struct rte_mbuf *pcap_buf;
+               int err = rte_ring_dequeue(pcap_q->pkts, (void **)&pcap_buf);
+               if (err)
+                       return i;
+
+               rte_memcpy(rte_pktmbuf_mtod(bufs[i], void *),
+                               rte_pktmbuf_mtod(pcap_buf, void *),
+                               pcap_buf->data_len);
+               bufs[i]->data_len = pcap_buf->data_len;
+               bufs[i]->pkt_len = pcap_buf->pkt_len;
+               bufs[i]->port = pcap_q->port_id;
+               rx_bytes += pcap_buf->data_len;
+
+               /* Enqueue packet back on ring to allow infinite rx. */
+               rte_ring_enqueue(pcap_q->pkts, pcap_buf);
        }
+
+       pcap_q->rx_stat.pkts += i;
+       pcap_q->rx_stat.bytes += rx_bytes;
+
+       return i;
 }
 
 static uint16_t
@@ -196,7 +226,6 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        struct rte_mbuf *mbuf;
        struct pcap_rx_queue *pcap_q = queue;
        uint16_t num_rx = 0;
-       uint16_t buf_size;
        uint32_t rx_bytes = 0;
        pcap_t *pcap;
 
@@ -219,11 +248,7 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                if (unlikely(mbuf == NULL))
                        break;
 
-               /* Now get the space available for data in the mbuf */
-               buf_size = rte_pktmbuf_data_room_size(pcap_q->mb_pool) -
-                               RTE_PKTMBUF_HEADROOM;
-
-               if (header.caplen <= buf_size) {
+               if (header.caplen <= rte_pktmbuf_tailroom(mbuf)) {
                        /* pcap packet will fit in the mbuf, can copy it */
                        rte_memcpy(rte_pktmbuf_mtod(mbuf, void *), packet,
                                        header.caplen);
@@ -240,6 +265,9 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                }
 
                mbuf->pkt_len = (uint16_t)header.caplen;
+               mbuf->timestamp = (uint64_t)header.ts.tv_sec * 1000000
+                                                       + header.ts.tv_usec;
+               mbuf->ol_flags |= PKT_RX_TIMESTAMP;
                mbuf->port = pcap_q->port_id;
                bufs[num_rx] = mbuf;
                num_rx++;
@@ -251,6 +279,14 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        return num_rx;
 }
 
+static uint16_t
+eth_null_rx(void *queue __rte_unused,
+               struct rte_mbuf **bufs __rte_unused,
+               uint16_t nb_pkts __rte_unused)
+{
+       return 0;
+}
+
 static inline void
 calculate_timestamp(struct timeval *ts) {
        uint64_t cycles;
@@ -276,6 +312,8 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        uint32_t tx_bytes = 0;
        struct pcap_pkthdr header;
        pcap_dumper_t *dumper;
+       unsigned char temp_data[RTE_ETH_PCAP_SNAPLEN];
+       size_t len;
 
        pp = rte_eth_devices[dumper_q->port_id].process_private;
        dumper = pp->tx_dumper[dumper_q->queue_id];
@@ -287,31 +325,28 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
         * dumper */
        for (i = 0; i < nb_pkts; i++) {
                mbuf = bufs[i];
+               len = rte_pktmbuf_pkt_len(mbuf);
+               if (unlikely(!rte_pktmbuf_is_contiguous(mbuf) &&
+                               len > sizeof(temp_data))) {
+                       PMD_LOG(ERR,
+                               "Dropping multi segment PCAP packet. Size (%zd) > max size (%zd).",
+                               len, sizeof(temp_data));
+                       rte_pktmbuf_free(mbuf);
+                       continue;
+               }
+
                calculate_timestamp(&header.ts);
-               header.len = mbuf->pkt_len;
+               header.len = len;
                header.caplen = header.len;
-
-               if (likely(mbuf->nb_segs == 1)) {
-                       pcap_dump((u_char *)dumper, &header,
-                                 rte_pktmbuf_mtod(mbuf, void*));
-               } else {
-                       if (mbuf->pkt_len <= RTE_ETHER_MAX_JUMBO_FRAME_LEN) {
-                               eth_pcap_gather_data(tx_pcap_data, mbuf);
-                               pcap_dump((u_char *)dumper, &header,
-                                         tx_pcap_data);
-                       } else {
-                               PMD_LOG(ERR,
-                                       "Dropping PCAP packet. Size (%d) > max jumbo size (%d).",
-                                       mbuf->pkt_len,
-                                       RTE_ETHER_MAX_JUMBO_FRAME_LEN);
-
-                               rte_pktmbuf_free(mbuf);
-                               break;
-                       }
-               }
+               /* rte_pktmbuf_read() returns a pointer to the data directly
+                * in the mbuf (when the mbuf is contiguous) or, otherwise,
+                * a pointer to temp_data after copying into it.
+                */
+               pcap_dump((u_char *)dumper, &header,
+                       rte_pktmbuf_read(mbuf, 0, len, temp_data));
 
                num_tx++;
-               tx_bytes += mbuf->pkt_len;
+               tx_bytes += len;
                rte_pktmbuf_free(mbuf);
        }
 
@@ -325,7 +360,31 @@ eth_pcap_tx_dumper(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        dumper_q->tx_stat.bytes += tx_bytes;
        dumper_q->tx_stat.err_pkts += nb_pkts - num_tx;
 
-       return num_tx;
+       return nb_pkts;
+}
+
+/*
+ * Callback to handle dropping packets in the infinite rx case.
+ */
+static uint16_t
+eth_tx_drop(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
+{
+       unsigned int i;
+       uint32_t tx_bytes = 0;
+       struct pcap_tx_queue *tx_queue = queue;
+
+       if (unlikely(nb_pkts == 0))
+               return 0;
+
+       for (i = 0; i < nb_pkts; i++) {
+               tx_bytes += bufs[i]->data_len;
+               rte_pktmbuf_free(bufs[i]);
+       }
+
+       tx_queue->tx_stat.pkts += nb_pkts;
+       tx_queue->tx_stat.bytes += tx_bytes;
+
+       return i;
 }
 
 /*
@@ -342,6 +401,8 @@ eth_pcap_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
        uint16_t num_tx = 0;
        uint32_t tx_bytes = 0;
        pcap_t *pcap;
+       unsigned char temp_data[RTE_ETH_PCAP_SNAPLEN];
+       size_t len;
 
        pp = rte_eth_devices[tx_queue->port_id].process_private;
        pcap = pp->tx_pcap[tx_queue->queue_id];
@@ -351,39 +412,34 @@ eth_pcap_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 
        for (i = 0; i < nb_pkts; i++) {
                mbuf = bufs[i];
-
-               if (likely(mbuf->nb_segs == 1)) {
-                       ret = pcap_sendpacket(pcap,
-                                       rte_pktmbuf_mtod(mbuf, u_char *),
-                                       mbuf->pkt_len);
-               } else {
-                       if (mbuf->pkt_len <= RTE_ETHER_MAX_JUMBO_FRAME_LEN) {
-                               eth_pcap_gather_data(tx_pcap_data, mbuf);
-                               ret = pcap_sendpacket(pcap,
-                                               tx_pcap_data, mbuf->pkt_len);
-                       } else {
-                               PMD_LOG(ERR,
-                                       "Dropping PCAP packet. Size (%d) > max jumbo size (%d).",
-                                       mbuf->pkt_len,
-                                       RTE_ETHER_MAX_JUMBO_FRAME_LEN);
-
-                               rte_pktmbuf_free(mbuf);
-                               break;
-                       }
+               len = rte_pktmbuf_pkt_len(mbuf);
+               if (unlikely(!rte_pktmbuf_is_contiguous(mbuf) &&
+                               len > sizeof(temp_data))) {
+                       PMD_LOG(ERR,
+                               "Dropping multi segment PCAP packet. Size (%zd) > max size (%zd).",
+                               len, sizeof(temp_data));
+                       rte_pktmbuf_free(mbuf);
+                       continue;
                }
 
+               /* rte_pktmbuf_read() returns a pointer to the data directly
+                * in the mbuf (when the mbuf is contiguous) or, otherwise,
+                * a pointer to temp_data after copying into it.
+                */
+               ret = pcap_sendpacket(pcap,
+                       rte_pktmbuf_read(mbuf, 0, len, temp_data), len);
                if (unlikely(ret != 0))
                        break;
                num_tx++;
-               tx_bytes += mbuf->pkt_len;
+               tx_bytes += len;
                rte_pktmbuf_free(mbuf);
        }
 
        tx_queue->tx_stat.pkts += num_tx;
        tx_queue->tx_stat.bytes += tx_bytes;
-       tx_queue->tx_stat.err_pkts += nb_pkts - num_tx;
+       tx_queue->tx_stat.err_pkts += i - num_tx;
 
-       return num_tx;
+       return i;
 }
 
 /*
@@ -455,6 +511,24 @@ open_single_rx_pcap(const char *pcap_filename, pcap_t **pcap)
        return 0;
 }
 
+static uint64_t
+count_packets_in_pcap(pcap_t **pcap, struct pcap_rx_queue *pcap_q)
+{
+       const u_char *packet;
+       struct pcap_pkthdr header;
+       uint64_t pcap_pkt_count = 0;
+
+       while ((packet = pcap_next(*pcap, &header)))
+               pcap_pkt_count++;
+
+       /* The pcap is reopened so it can be used as normal later. */
+       pcap_close(*pcap);
+       *pcap = NULL;
+       open_single_rx_pcap(pcap_q->name, pcap);
+
+       return pcap_pkt_count;
+}
+
 static int
 eth_dev_start(struct rte_eth_dev *dev)
 {
@@ -578,7 +652,7 @@ eth_dev_configure(struct rte_eth_dev *dev __rte_unused)
        return 0;
 }
 
-static void
+static int
 eth_dev_info(struct rte_eth_dev *dev,
                struct rte_eth_dev_info *dev_info)
 {
@@ -590,6 +664,8 @@ eth_dev_info(struct rte_eth_dev *dev,
        dev_info->max_rx_queues = dev->data->nb_rx_queues;
        dev_info->max_tx_queues = dev->data->nb_tx_queues;
        dev_info->min_rx_bufsize = 0;
+
+       return 0;
 }
 
 static int
@@ -627,7 +703,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
        return 0;
 }
 
-static void
+static int
 eth_stats_reset(struct rte_eth_dev *dev)
 {
        unsigned int i;
@@ -643,11 +719,30 @@ eth_stats_reset(struct rte_eth_dev *dev)
                internal->tx_queue[i].tx_stat.bytes = 0;
                internal->tx_queue[i].tx_stat.err_pkts = 0;
        }
+
+       return 0;
 }
 
 static void
-eth_dev_close(struct rte_eth_dev *dev __rte_unused)
+eth_dev_close(struct rte_eth_dev *dev)
 {
+       unsigned int i;
+       struct pmd_internals *internals = dev->data->dev_private;
+
+       /* Device wide flag, but cleanup must be performed per queue. */
+       if (internals->infinite_rx) {
+               for (i = 0; i < dev->data->nb_rx_queues; i++) {
+                       struct pcap_rx_queue *pcap_q = &internals->rx_queue[i];
+                       struct rte_mbuf *pcap_buf;
+
+                       while (!rte_ring_dequeue(pcap_q->pkts,
+                                       (void **)&pcap_buf))
+                               rte_pktmbuf_free(pcap_buf);
+
+                       rte_ring_free(pcap_q->pkts);
+               }
+       }
+
 }
 
 static void
@@ -678,6 +773,59 @@ eth_rx_queue_setup(struct rte_eth_dev *dev,
        pcap_q->queue_id = rx_queue_id;
        dev->data->rx_queues[rx_queue_id] = pcap_q;
 
+       if (internals->infinite_rx) {
+               struct pmd_process_private *pp;
+               char ring_name[NAME_MAX];
+               static uint32_t ring_number;
+               uint64_t pcap_pkt_count = 0;
+               struct rte_mbuf *bufs[1];
+               pcap_t **pcap;
+
+               pp = rte_eth_devices[pcap_q->port_id].process_private;
+               pcap = &pp->rx_pcap[pcap_q->queue_id];
+
+               if (unlikely(*pcap == NULL))
+                       return -ENOENT;
+
+               pcap_pkt_count = count_packets_in_pcap(pcap, pcap_q);
+
+               snprintf(ring_name, sizeof(ring_name), "PCAP_RING%" PRIu16,
+                               ring_number);
+
+               pcap_q->pkts = rte_ring_create(ring_name,
+                               rte_align64pow2(pcap_pkt_count + 1), 0,
+                               RING_F_SP_ENQ | RING_F_SC_DEQ);
+               ring_number++;
+               if (!pcap_q->pkts)
+                       return -ENOENT;
+
+               /* Fill ring with packets from PCAP file one by one. */
+               while (eth_pcap_rx(pcap_q, bufs, 1)) {
+                       /* Check for multiseg mbufs. */
+                       if (bufs[0]->nb_segs != 1) {
+                               rte_pktmbuf_free(*bufs);
+
+                               while (!rte_ring_dequeue(pcap_q->pkts,
+                                               (void **)bufs))
+                                       rte_pktmbuf_free(*bufs);
+
+                               rte_ring_free(pcap_q->pkts);
+                               PMD_LOG(ERR, "Multiseg mbufs are not supported in infinite_rx "
+                                               "mode.");
+                               return -EINVAL;
+                       }
+
+                       rte_ring_enqueue_bulk(pcap_q->pkts,
+                                       (void * const *)bufs, 1, NULL);
+               }
+               /*
+                * Reset the stats for this queue since eth_pcap_rx calls above
+                * didn't result in the application receiving packets.
+                */
+               pcap_q->rx_stat.pkts = 0;
+               pcap_q->rx_stat.bytes = 0;
+       }
+
        return 0;
 }
 
@@ -915,7 +1063,19 @@ select_phy_mac(const char *key __rte_unused, const char *value,
        return 0;
 }
 
-static struct rte_vdev_driver pmd_pcap_drv;
+static int
+get_infinite_rx_arg(const char *key __rte_unused,
+               const char *value, void *extra_args)
+{
+       if (extra_args) {
+               const int infinite_rx = atoi(value);
+               int *enable_infinite_rx = extra_args;
+
+               if (infinite_rx > 0)
+                       *enable_infinite_rx = 1;
+       }
+       return 0;
+}
 
 static int
 pmd_init_internals(struct rte_vdev_device *vdev,
@@ -969,6 +1129,8 @@ pmd_init_internals(struct rte_vdev_device *vdev,
        data->nb_tx_queues = (uint16_t)nb_tx_queues;
        data->dev_link = pmd_link;
        data->mac_addrs = &(*internals)->eth_addr;
+       data->promiscuous = 1;
+       data->all_multicast = 1;
 
        /*
         * NOTE: we'll replace the data element, of originally allocated
@@ -1119,6 +1281,7 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
        struct rte_eth_dev *eth_dev = NULL;
        struct pmd_devargs *rx_queues = &devargs_all->rx_queues;
        int single_iface = devargs_all->single_iface;
+       unsigned int infinite_rx = devargs_all->infinite_rx;
        int ret;
 
        ret = eth_from_pcaps_common(vdev, devargs_all, &internals, &eth_dev);
@@ -1141,13 +1304,23 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
                }
        }
 
-       eth_dev->rx_pkt_burst = eth_pcap_rx;
+       internals->infinite_rx = infinite_rx;
+       /* Assign rx ops. */
+       if (infinite_rx)
+               eth_dev->rx_pkt_burst = eth_pcap_rx_infinite;
+       else if (devargs_all->is_rx_pcap || devargs_all->is_rx_iface ||
+                       single_iface)
+               eth_dev->rx_pkt_burst = eth_pcap_rx;
+       else
+               eth_dev->rx_pkt_burst = eth_null_rx;
 
        /* Assign tx ops. */
        if (devargs_all->is_tx_pcap)
                eth_dev->tx_pkt_burst = eth_pcap_tx_dumper;
-       else
+       else if (devargs_all->is_tx_iface || single_iface)
                eth_dev->tx_pkt_burst = eth_pcap_tx;
+       else
+               eth_dev->tx_pkt_burst = eth_tx_drop;
 
        rte_eth_dev_probing_finish(eth_dev);
        return 0;
@@ -1157,18 +1330,18 @@ static int
 pmd_pcap_probe(struct rte_vdev_device *dev)
 {
        const char *name;
-       unsigned int is_rx_pcap = 0;
        struct rte_kvargs *kvlist;
        struct pmd_devargs pcaps = {0};
        struct pmd_devargs dumpers = {0};
        struct rte_eth_dev *eth_dev =  NULL;
        struct pmd_internals *internal;
-       int ret;
+       int ret = 0;
 
        struct pmd_devargs_all devargs_all = {
                .single_iface = 0,
                .is_tx_pcap = 0,
                .is_tx_iface = 0,
+               .infinite_rx = 0,
        };
 
        name = rte_vdev_device_name(dev);
@@ -1225,37 +1398,93 @@ pmd_pcap_probe(struct rte_vdev_device *dev)
        }
 
        /*
-        * We check whether we want to open a RX stream from a real NIC or a
-        * pcap file
+        * We check whether we want to open a RX stream from a real NIC, a
+        * pcap file or open a dummy RX stream
         */
-       is_rx_pcap = rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG) ? 1 : 0;
+       devargs_all.is_rx_pcap =
+               rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG) ? 1 : 0;
+       devargs_all.is_rx_iface =
+               rte_kvargs_count(kvlist, ETH_PCAP_RX_IFACE_ARG) ? 1 : 0;
        pcaps.num_of_queue = 0;
 
-       if (is_rx_pcap) {
+       devargs_all.is_tx_pcap =
+               rte_kvargs_count(kvlist, ETH_PCAP_TX_PCAP_ARG) ? 1 : 0;
+       devargs_all.is_tx_iface =
+               rte_kvargs_count(kvlist, ETH_PCAP_TX_IFACE_ARG) ? 1 : 0;
+       dumpers.num_of_queue = 0;
+
+       if (devargs_all.is_rx_pcap) {
+               /*
+                * We check whether we want to infinitely rx the pcap file.
+                */
+               unsigned int infinite_rx_arg_cnt = rte_kvargs_count(kvlist,
+                               ETH_PCAP_INFINITE_RX_ARG);
+
+               if (infinite_rx_arg_cnt == 1) {
+                       ret = rte_kvargs_process(kvlist,
+                                       ETH_PCAP_INFINITE_RX_ARG,
+                                       &get_infinite_rx_arg,
+                                       &devargs_all.infinite_rx);
+                       if (ret < 0)
+                               goto free_kvlist;
+                       PMD_LOG(INFO, "infinite_rx has been %s for %s",
+                                       devargs_all.infinite_rx ? "enabled" : "disabled",
+                                       name);
+
+               } else if (infinite_rx_arg_cnt > 1) {
+                       PMD_LOG(WARNING, "infinite_rx has not been enabled since the "
+                                       "argument has been provided more than once "
+                                       "for %s", name);
+               }
+
                ret = rte_kvargs_process(kvlist, ETH_PCAP_RX_PCAP_ARG,
                                &open_rx_pcap, &pcaps);
-       } else {
+       } else if (devargs_all.is_rx_iface) {
                ret = rte_kvargs_process(kvlist, NULL,
                                &rx_iface_args_process, &pcaps);
-       }
+       } else if (devargs_all.is_tx_iface || devargs_all.is_tx_pcap) {
+               unsigned int i;
+
+               /* Count number of tx queue args passed before dummy rx queue
+                * creation so a dummy rx queue can be created for each tx queue
+                */
+               unsigned int num_tx_queues =
+                       (rte_kvargs_count(kvlist, ETH_PCAP_TX_PCAP_ARG) +
+                       rte_kvargs_count(kvlist, ETH_PCAP_TX_IFACE_ARG));
 
+               PMD_LOG(INFO, "Creating null rx queue since no rx queues were provided.");
+
+               /* Creating a dummy rx queue for each tx queue passed */
+               for (i = 0; i < num_tx_queues; i++)
+                       ret = add_queue(&pcaps, "dummy_rx", "rx_null", NULL,
+                                       NULL);
+       } else {
+               PMD_LOG(ERR, "Error - No rx or tx queues provided");
+               ret = -ENOENT;
+       }
        if (ret < 0)
                goto free_kvlist;
 
        /*
-        * We check whether we want to open a TX stream to a real NIC or a
-        * pcap file
+        * We check whether we want to open a TX stream to a real NIC,
+        * a pcap file, or drop packets on tx
         */
-       devargs_all.is_tx_pcap =
-               rte_kvargs_count(kvlist, ETH_PCAP_TX_PCAP_ARG) ? 1 : 0;
-       dumpers.num_of_queue = 0;
-
-       if (devargs_all.is_tx_pcap)
+       if (devargs_all.is_tx_pcap) {
                ret = rte_kvargs_process(kvlist, ETH_PCAP_TX_PCAP_ARG,
                                &open_tx_pcap, &dumpers);
-       else
+       } else if (devargs_all.is_tx_iface) {
                ret = rte_kvargs_process(kvlist, ETH_PCAP_TX_IFACE_ARG,
                                &open_tx_iface, &dumpers);
+       } else {
+               unsigned int i;
+
+               PMD_LOG(INFO, "Dropping packets on tx since no tx queues were provided.");
+
+               /* Add 1 dummy queue per rxq which counts and drops packets. */
+               for (i = 0; i < pcaps.num_of_queue; i++)
+                       ret = add_queue(&dumpers, "dummy_tx", "tx_drop", NULL,
+                                       NULL);
+       }
 
        if (ret < 0)
                goto free_kvlist;
@@ -1336,6 +1565,8 @@ pmd_pcap_remove(struct rte_vdev_device *dev)
                        eth_dev->data->mac_addrs = NULL;
        }
 
+       eth_dev_close(eth_dev);
+
        rte_free(eth_dev->process_private);
        rte_eth_dev_release_port(eth_dev);
 
@@ -1356,7 +1587,8 @@ RTE_PMD_REGISTER_PARAM_STRING(net_pcap,
        ETH_PCAP_RX_IFACE_IN_ARG "=<ifc> "
        ETH_PCAP_TX_IFACE_ARG "=<ifc> "
        ETH_PCAP_IFACE_ARG "=<ifc> "
-       ETH_PCAP_PHY_MAC_ARG "=<int>");
+       ETH_PCAP_PHY_MAC_ARG "=<int>"
+       ETH_PCAP_INFINITE_RX_ARG "=<0|1>");
 
 RTE_INIT(eth_pcap_init_log)
 {